[clang] [clang][RISCV] Handle target features correctly in CheckBuiltinFunctionCall (PR #141548)

2025-06-01 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/141548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 88aa5cb - [clang][RISCV] Handle target features correctly in CheckBuiltinFunctionCall (#141548)

2025-06-01 Thread via cfe-commits
Author: Brandon Wu Date: 2025-06-01T17:57:08+08:00 New Revision: 88aa5cbbda67857891a740dd8326f6f45f4eb6fd URL: https://github.com/llvm/llvm-project/commit/88aa5cbbda67857891a740dd8326f6f45f4eb6fd DIFF: https://github.com/llvm/llvm-project/commit/88aa5cbbda67857891a740dd8326f6f45f4eb6fd.diff LO

[libcxx] [libunwind] [llvm] [libc++] Upgrade to GCC 15 (PR #138293)

2025-06-01 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/138293 >From 29273cf49b2cae51f6eee43970deb547272eb97f Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 2 May 2025 17:24:13 +0200 Subject: [PATCH] [libc++] Upgrade to GCC 15 --- .github/workflows/libcxx-bu

[clang] [clang] Fix bad error recovery when classes are defined inside template (PR #142278)

2025-06-01 Thread Artyom Zabroda via cfe-commits
@@ -220,6 +220,14 @@ static ExprResult EvaluateAtomicConstraint( if (Inst.isInvalid()) return ExprError(); +if (const TemplateTypeParmType *TTPT = + dyn_cast(AtomicExpr->getType().getDesugaredType(S.Context))) { + TemplateTypeParmDecl *TTPD = TTPT->

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 edited https://github.com/llvm/llvm-project/pull/142273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Áron Hárnási via cfe-commits
ConcreteCactus wrote: Hi Everyone, I fixed a crash in the ExecutionVisitor. It wasn't checking whether the definition of a class exists before trying to recurse into the destructor. Can I get a re-review on this PR? I think I addressed most of the comments. https://github.com/llvm/llvm-project

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 converted_to_draft https://github.com/llvm/llvm-project/pull/142273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][WIP] Normalize constraints before checking for satisfaction (PR #141776)

2025-06-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/AST/ASTConcept.h clang/include/

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Mike Crowe (mikecrowe) Changes These checks previously failed with absl::StrFormat and absl::PrintF etc. with: Unable to use 'std::format' instead of 'StrFormat' because first argument is not a

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe created https://github.com/llvm/llvm-project/pull/142312 These checks previously failed with absl::StrFormat and absl::PrintF etc. with: Unable to use 'std::format' instead of 'StrFormat' because first argument is not a narrow string literal [modernize-use-std-for

[clang] 2a19efe - [Serialization] Remove unused includes (NFC) (#142300)

2025-06-01 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-06-01T08:10:01-07:00 New Revision: 2a19efe7fe8adcb5d89d3587ee23d9f954b11896 URL: https://github.com/llvm/llvm-project/commit/2a19efe7fe8adcb5d89d3587ee23d9f954b11896 DIFF: https://github.com/llvm/llvm-project/commit/2a19efe7fe8adcb5d89d3587ee23d9f954b11896.diff L

[clang] [Serialization] Remove unused includes (NFC) (PR #142300)

2025-06-01 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/142300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 ready_for_review https://github.com/llvm/llvm-project/pull/142273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - performance-lost-std-move + +performance-lost-std-move += + +Warns if copy constructor is used instead of std::move() and suggests a fix. +It honours cycles, lambdas, and unspecified call order in compound expressio

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Mike Crowe via cfe-commits
mikecrowe wrote: Thanks to @gle8098 who suggested the fix for this. https://github.com/llvm/llvm-project/pull/142312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libunwind] [llvm] [libc++] Upgrade to GCC 15 (PR #138293)

2025-06-01 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/138293 >From 68a5c9df4e5dc4599a97ccd24b95708ac0e0a327 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 2 May 2025 17:24:13 +0200 Subject: [PATCH] [libc++] Upgrade to GCC 15 --- .github/workflows/libcxx-bu

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/142273 >From 725dd21adcd2f776b2e6adc648e3038812059bf3 Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Sat, 31 May 2025 10:05:52 -0400 Subject: [PATCH 1/6] [clang-doc] Refactor CommentInfo.Kind to use CommentKind

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/142273 >From cd99fbe06a384db3775d1fc8c923275df07d4db3 Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Sat, 31 May 2025 10:05:52 -0400 Subject: [PATCH 1/7] [clang-doc] Refactor CommentInfo.Kind to use CommentKind

[clang] [clang] Fix bad error recovery when classes are defined inside template (PR #142278)

2025-06-01 Thread Matheus Izvekov via cfe-commits
@@ -220,6 +220,14 @@ static ExprResult EvaluateAtomicConstraint( if (Inst.isInvalid()) return ExprError(); +if (const TemplateTypeParmType *TTPT = + dyn_cast(AtomicExpr->getType().getDesugaredType(S.Context))) { + TemplateTypeParmDecl *TTPD = TTPT->

[clang] [llvm] Introduce Intra-procedural lifetime analysis in Clang (PR #142313)

2025-06-01 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/142313 None >From c8f62770b164216bd67810a1035996180ec6c3d8 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 1 Jun 2025 15:44:37 + Subject: [PATCH] Introduce Intra-procedural lifetime analysis in Clang ---

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - performance-lost-std-move + +performance-lost-std-move += + +Warns if copy constructor is used instead of std::move() and suggests a fix. +It honours cycles, lambdas, and unspecified call order in compound expressio

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-06-01 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/140556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove Native Client support (PR #133661)

2025-06-01 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Thanks for working on this! This will be the first time I'm not going to > oppose an effort to remove Native Client support 🎉 Although I am going to ask > you to wait a couple of months to land it, until we finally turn it off for > good and start deleting the support code fro

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/139525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - performance-lost-std-move + +performance-lost-std-move += + +Warns if copy constructor is used instead of std::move() and suggests a fix. +It honours cycles, lambdas, and unspecified call order in compound expressio

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
@@ -0,0 +1,21 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/142288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add initial support for bitfields in structs (PR #142041)

2025-06-01 Thread via cfe-commits
@@ -14,6 +14,105 @@ namespace clang::CIRGen { +/// Record with information about how a bitfield should be accessed. This is +/// very similar to what LLVM codegen does, once CIR evolves it's possible we +/// can use a more higher level representation. +/// +/// Often we lay o

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/142288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
@@ -2156,6 +2157,52 @@ def VecCmpOp : CIR_Op<"vec.cmp", [Pure, SameTypeOperands]> { }]; } +//===--===// +// VecShuffleOp +//===--===// + +

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/142273 >From cd99fbe06a384db3775d1fc8c923275df07d4db3 Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Sat, 31 May 2025 10:05:52 -0400 Subject: [PATCH 1/8] [clang-doc] Refactor CommentInfo.Kind to use CommentKind

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Samarth Narang via cfe-commits
@@ -26,6 +26,66 @@ namespace clang { namespace doc { +CommentKind stringToCommentKind(llvm::StringRef KindStr) { + if (KindStr == "FullComment") +return CommentKind::CK_FullComment; snarang181 wrote: Updated the function to do a `StringMap` lookup. htt

[clang-tools-extra] [clang-tidy] Add performance-bool-bitwise-operation check (PR #142324)

2025-06-01 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread Fabian Keßler via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - performance-lost-std-move + +performance-lost-std-move += + +Warns if copy constructor is used instead of std::move() and suggests a fix. +It honours cycles, lambdas, and unspecified call order in compound expressio

[clang] [clang][AIX] Fix -print-runtime-dir fallback on AIX (PR #141439)

2025-06-01 Thread Jake Egan via cfe-commits
@@ -933,11 +933,16 @@ ToolChain::getTargetSubDirPath(StringRef BaseDir) const { if (auto Path = getPathForTriple(T)) return *Path; - if (T.isOSAIX() && T.getEnvironment() == Triple::UnknownEnvironment) { -// Strip unknown environment from the triple. -const llvm

[clang] [clang-format] Handle token-pasted function decl names (PR #142251)

2025-06-01 Thread Pierre Jolivet via cfe-commits
prj- wrote: @owenca, this introduced multiple regressions (or maybe they are all the same), I do believe. ```diff diff --git a/include/petsc/private/hashmap.h b/include/petsc/private/hashmap.h index c48d69d73ce..265a968a95c 100644 --- a/include/petsc/private/hashmap.h +++ b/include/petsc/private

[clang] [PAuth] Use different discriminators for __int128_t / __uint128_t / _BitInt(n) (PR #140276)

2025-06-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c -- clang/lib/AST/ASTContext.cpp clang/lib/Driver/ToolC

[clang] [PAuth] Use different discriminators for __int128_t / __uint128_t / _BitInt(n) (PR #140276)

2025-06-01 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl updated https://github.com/llvm/llvm-project/pull/140276 >From 21d2b2da72d9e8f3994cb913a86c093212bb8711 Mon Sep 17 00:00:00 2001 From: Anton Korobeynikov Date: Fri, 16 May 2025 19:25:57 +0300 Subject: [PATCH 1/2] [PAuth] Use different discriminators for __int128_t / __uin

[clang] [clang-format] Correctly annotate token-pasted function decl names (PR #142337)

2025-06-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #142178 --- Full diff: https://github.com/llvm/llvm-project/pull/142337.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+2) - (modified) clang/unittests/Format/TokenAnnotato

[clang] [clang][AIX] Fix -print-runtime-dir fallback on AIX (PR #141439)

2025-06-01 Thread Jake Egan via cfe-commits
https://github.com/jakeegan updated https://github.com/llvm/llvm-project/pull/141439 >From b044f81c6d1ed67ce7ee27bce7a62d36b3841bad Mon Sep 17 00:00:00 2001 From: Jake Egan Date: Sun, 25 May 2025 19:40:59 -0400 Subject: [PATCH 1/4] Fix rt dir fallback --- clang/lib/Driver/ToolChain.cpp

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-06-01 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,170 @@ +//===-- AMDGPUTargetVerifier.cpp - AMDGPU ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-06-01 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,170 @@ +//===-- AMDGPUTargetVerifier.cpp - AMDGPU ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [RISCV] Add pre-defined macro tests for Andes vendor extension. NFC. (PR #141172)

2025-06-01 Thread Jim Lin via cfe-commits
tclin914 wrote: Kindly ping. https://github.com/llvm/llvm-project/pull/141172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][FMV] Stop emitting implicit default version using target_clones. (PR #141808)

2025-06-01 Thread Piyou Chen via cfe-commits
https://github.com/BeMg approved this pull request. RISC-V part LGTM. https://github.com/llvm/llvm-project/pull/141808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add pre-defined macro tests for Andes vendor extension. NFC. (PR #141172)

2025-06-01 Thread Sam Elliott via cfe-commits
https://github.com/lenary approved this pull request. https://github.com/llvm/llvm-project/pull/141172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add pre-defined macro tests for Andes vendor extension. NFC. (PR #141172)

2025-06-01 Thread Sam Elliott via cfe-commits
https://github.com/lenary updated https://github.com/llvm/llvm-project/pull/141172 >From 036a3bd7024fe358d670b49d1d62bfe3cc0bc6d4 Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Thu, 22 May 2025 15:05:30 +0800 Subject: [PATCH] [RISCV] Add pre-defined macro tests for Andes vendor extension. NFC.

[clang] c5cce48 - Revert "[clang-format] Handle token-pasted function decl names (#142251)"

2025-06-01 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2025-06-01T23:32:00-07:00 New Revision: c5cce4861cb011d10af7f6afba4176682f5f862f URL: https://github.com/llvm/llvm-project/commit/c5cce4861cb011d10af7f6afba4176682f5f862f DIFF: https://github.com/llvm/llvm-project/commit/c5cce4861cb011d10af7f6afba4176682f5f862f.diff LOG:

[clang] [Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives (PR #140532)

2025-06-01 Thread Walter J.T.V via cfe-commits
eZWALT wrote: gentle ping :) https://github.com/llvm/llvm-project/pull/140532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread Vasiliy Kulikov via cfe-commits
https://github.com/segoon updated https://github.com/llvm/llvm-project/pull/139525 >From 3abbce9f817f6d09f9a5b7549a8122c80821eaf8 Mon Sep 17 00:00:00 2001 From: Vasily Kulikov Date: Mon, 12 May 2025 13:05:43 +0300 Subject: [PATCH 01/16] [clang-tidy] Add check performance-lost-std-move --- ...

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. vbvictor wrote: "conflicting" may not be very meaningfu

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -151,6 +157,14 @@ New checks New check aliases ^ +- New `cert-exp30-c ` alias for vbvictor wrote: Please create entries in `docs/` folder for these aliases, they should have filling like this: https://github.com/llvm/llvm-project/blob/mai

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/130421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor commented: Mostly left comments in docs about general improvements. Didn't look closely at the code, but here are some general recommendations that you should do before major review: There are a lot of new code that is relatively hard to review, you should try to f

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - performance-lost-std-move + +performance-lost-std-move += + +Warns if copy constructor is used instead of std::move() and suggests a fix. +It honours cycles, lambdas, and unspecified call order in compound expressio

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,186 @@ +//===--- LostStdMoveCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread via cfe-commits
@@ -136,6 +136,12 @@ New checks Finds unintended character output from ``unsigned char`` and ``signed char`` to an ``ostream``. +- New :doc:`performance-lost-std-move + ` check. + + Warns if copy constructor is used instead of std::move() and suggests a fix.

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - performance-lost-std-move + +performance-lost-std-move += + +Warns if copy constructor is used instead of std::move() and suggests a fix. EugeneZelenko wrote: ```suggestion Warns if copy constructo

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. + +Modifying twice or reading and modifying a memory location without a +

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-06-01 Thread via cfe-commits
@@ -0,0 +1,72 @@ +.. title:: clang-tidy - bugprone-conflicting-global-accesses + +bugprone-conflicting-global-accesses + + +Finds conflicting accesses on global variables. EugeneZelenko wrote: Please synchronize first statement

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -9,15 +9,16 @@ #include #include +#include namespace absl { // Use const char * for the format since the real type is hard to mock up. vbvictor wrote: Unnecessary comment for now? https://github.com/llvm/llvm-project/pull/142312 __

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-06-01 Thread Abid Qadeer via cfe-commits
https://github.com/abidh updated https://github.com/llvm/llvm-project/pull/140556 >From 5d20af48673adebc2ab3e1a6c8442f67d84f1847 Mon Sep 17 00:00:00 2001 From: Abid Qadeer Date: Mon, 19 May 2025 15:21:25 +0100 Subject: [PATCH 1/8] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. This PR add fun

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-06-01 Thread Abid Qadeer via cfe-commits
@@ -614,3 +614,30 @@ nvfortran defines `-fast` as - `-Mcache_align`: there is no equivalent flag in Flang or Clang. - `-Mflushz`: flush-to-zero mode - when `-ffast-math` is specified, Flang will link to `crtfastmath.o` to ensure denormal numbers are flushed to zero. + + +#

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Amr Hesham via cfe-commits
@@ -2156,6 +2156,50 @@ def VecCmpOp : CIR_Op<"vec.cmp", [Pure, SameTypeOperands]> { }]; } +//===--===// +// VecShuffleOp +//===--===// + +

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Mike Crowe via cfe-commits
@@ -16,8 +16,8 @@ namespace absl { -template -std::string StrFormat(const S &format, const Args&... args); +template +std::string StrFormat(const std::string &format, const Args&... args); mikecrowe wrote: `std::string` probably works just as well but I oug

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Mike Crowe via cfe-commits
@@ -9,15 +9,16 @@ #include #include +#include namespace absl { // Use const char * for the format since the real type is hard to mock up. mikecrowe wrote: It should really say `std::string_view`, but the same is true in other files which lack the com

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-06-01 Thread Abid Qadeer via cfe-commits
@@ -614,3 +614,30 @@ nvfortran defines `-fast` as - `-Mcache_align`: there is no equivalent flag in Flang or Clang. - `-Mflushz`: flush-to-zero mode - when `-ffast-math` is specified, Flang will link to `crtfastmath.o` to ensure denormal numbers are flushed to zero. + + +#

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Paul Kirth via cfe-commits
@@ -26,6 +26,66 @@ namespace clang { namespace doc { +CommentKind stringToCommentKind(llvm::StringRef KindStr) { + if (KindStr == "FullComment") +return CommentKind::CK_FullComment; ilovepi wrote: IDK if the huge set of conditionals is great. There are a

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/142273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: > Quoiting the docs: the result of `__builtin_shufflevector` is a vector with > the same element type as `vec1` and `vec2` but that has an element count > equal to the number of indices specified. Thank you, i will put it back to the description https://github.com/llvm/llv

[clang-tools-extra] Refactor clang doc comment structure (PR #142273)

2025-06-01 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: I'll take another pass later in the week, but here are some initial comments. https://github.com/llvm/llvm-project/pull/142273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe updated https://github.com/llvm/llvm-project/pull/142312 >From b334ec47c79098f7b370bdba0bcc0bbaced1f96d Mon Sep 17 00:00:00 2001 From: Mike Crowe Date: Thu, 29 May 2025 21:19:11 +0100 Subject: [PATCH 1/3] [clang-tidy] modernize-use-std-print,format: Fix checks with

[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

2025-06-01 Thread Vasiliy Kulikov via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - performance-lost-std-move + +performance-lost-std-move += + +Warns if copy constructor is used instead of std::move() and suggests a fix. +It honours cycles, lambdas, and unspecified call order in compound expressio

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/142288 >From 1080f1cb13950b3fbeb1536227ee61e2ade9eac7 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 31 May 2025 19:53:56 +0200 Subject: [PATCH 1/2] [CIR] Upstream ShuffleOp for VectorType --- clang/incl

[clang] [CIR] Implement folder for VecShuffleDynamicOp (PR #142315)

2025-06-01 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/142315 This change adds a folder for the VecShuffleDynamicOp Issue https://github.com/llvm/llvm-project/issues/136487 >From a2eaa7f28e912f6aa0df909995ec2daf665fbf4d Mon Sep 17 00:00:00 2001 From: AmrDeveloper Da

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Baranov Victor via cfe-commits
@@ -16,8 +16,8 @@ namespace absl { -template -std::string StrFormat(const S &format, const Args&... args); +template +std::string StrFormat(const std::string &format, const Args&... args); vbvictor wrote: Shouldn't this also be a `std::string_view`? ```sugg

[clang] [CIR] Implement folder for VecShuffleDynamicOp (PR #142315)

2025-06-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds a folder for the VecShuffleDynamicOp Issue https://github.com/llvm/llvm-project/issues/136487 --- Full diff: https://github.com/llvm/llvm-project/pull/142315.diff 4 Files Affected: -

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
@@ -0,0 +1,21 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/142288 >From 1080f1cb13950b3fbeb1536227ee61e2ade9eac7 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 31 May 2025 19:53:56 +0200 Subject: [PATCH 1/3] [CIR] Upstream ShuffleOp for VectorType --- clang/incl

[clang] [Serialization] Remove unused includes (NFC) (PR #142300)

2025-06-01 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/142300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Stop moving lambda to new line only to indent it more. (PR #141576)

2025-06-01 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. Please wait for @owenca or @mydeveloperday. https://github.com/llvm/llvm-project/pull/141576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [llvm] [WIP] ABI Lowering Library (PR #140112)

2025-06-01 Thread via cfe-commits
https://github.com/vortex73 updated https://github.com/llvm/llvm-project/pull/140112 >From 322c1cfb925f3073f3d3b30abe1b2e35ae7745f3 Mon Sep 17 00:00:00 2001 From: Narayan Sreekumar Date: Thu, 15 May 2025 23:13:50 +0530 Subject: [PATCH 1/5] [LLVM ABI] The Typesystem --- llvm/include/llvm/ABI/T

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
@@ -2156,6 +2156,50 @@ def VecCmpOp : CIR_Op<"vec.cmp", [Pure, SameTypeOperands]> { }]; } +//===--===// +// VecShuffleOp +//===--===// + +

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/142288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream ShuffleOp for VectorType (PR #142288)

2025-06-01 Thread Henrich Lauko via cfe-commits
@@ -2156,6 +2156,50 @@ def VecCmpOp : CIR_Op<"vec.cmp", [Pure, SameTypeOperands]> { }]; } +//===--===// +// VecShuffleOp +//===--===// + +

[clang] [llvm] [WIP] ABI Lowering Library (PR #140112)

2025-06-01 Thread via cfe-commits
https://github.com/vortex73 updated https://github.com/llvm/llvm-project/pull/140112 >From 322c1cfb925f3073f3d3b30abe1b2e35ae7745f3 Mon Sep 17 00:00:00 2001 From: Narayan Sreekumar Date: Thu, 15 May 2025 23:13:50 +0530 Subject: [PATCH 1/5] [LLVM ABI] The Typesystem --- llvm/include/llvm/ABI/T

[clang] [llvm] [WIP] ABI Lowering Library (PR #140112)

2025-06-01 Thread via cfe-commits
https://github.com/vortex73 updated https://github.com/llvm/llvm-project/pull/140112 >From 322c1cfb925f3073f3d3b30abe1b2e35ae7745f3 Mon Sep 17 00:00:00 2001 From: Narayan Sreekumar Date: Thu, 15 May 2025 23:13:50 +0530 Subject: [PATCH 1/5] [LLVM ABI] The Typesystem --- llvm/include/llvm/ABI/T

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe updated https://github.com/llvm/llvm-project/pull/142312 >From b334ec47c79098f7b370bdba0bcc0bbaced1f96d Mon Sep 17 00:00:00 2001 From: Mike Crowe Date: Thu, 29 May 2025 21:19:11 +0100 Subject: [PATCH] [clang-tidy] modernize-use-std-print,format: Fix checks with Abs

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread via cfe-commits
@@ -232,10 +232,20 @@ Changes in existing checks matched scenarios of ``find`` and ``rfind`` methods and fixing false positives when those methods were called with 3 arguments. +- Improved :doc:`modernize-use-std-print EugeneZelenko wrote: Please keep alp

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-06-01 Thread Mike Crowe via cfe-commits
@@ -232,10 +232,20 @@ Changes in existing checks matched scenarios of ``find`` and ``rfind`` methods and fixing false positives when those methods were called with 3 arguments. +- Improved :doc:`modernize-use-std-print mikecrowe wrote: Arggh, I edited the

  1   2   >