================ @@ -16,8 +16,8 @@ namespace absl { -template <typename S, typename... Args> -std::string StrFormat(const S &format, const Args&... args); +template <typename... Args> +std::string StrFormat(const std::string &format, const Args&... args); ---------------- vbvictor wrote:
Shouldn't this also be a `std::string_view`? ```suggestion std::string StrFormat(const std::string_view &format, const Args&... args); ``` https://github.com/llvm/llvm-project/pull/142312 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits