[clang] [libcxx] [Clang] Add __builtin_common_reference (PR #121199)

2025-05-26 Thread A. Jiang via cfe-commits
@@ -17,16 +17,37 @@ #include <__type_traits/is_reference.h> #include <__type_traits/remove_cvref.h> #include <__type_traits/remove_reference.h> +#include <__type_traits/type_identity.h> #include <__utility/declval.h> #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) # pra

[clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread Akash Agrawal via cfe-commits
akashagrwl wrote: Adding @iajbar @androm3da @svs-quic for review. https://github.com/llvm/llvm-project/pull/141478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread Akash Agrawal via cfe-commits
https://github.com/akashagrwl created https://github.com/llvm/llvm-project/pull/141478 A few files of lldb dir & few other files had duplicate headers included. This patch removes those redundancies. >From 72ce442847fe03dd489938eff0eee06c65f53e90 Mon Sep 17 00:00:00 2001 From: Akash Agrawal D

[clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/InstallAPI/FileList.cpp compiler-rt/lib/sa

[clang] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV-like ABIs (PR #135230)

2025-05-26 Thread via cfe-commits
@@ -2595,6 +2595,14 @@ GetX86_64ByValArgumentPair(llvm::Type *Lo, llvm::Type *Hi, ABIArgInfo X86_64ABIInfo:: classifyReturnType(QualType RetTy) const { + // return int128 as i128 + if (const BuiltinType *BT = RetTy->getAs()) { +BuiltinType::Kind k = BT->getKind(); +

[clang] [Sema] built-in args type checking using hasSameUnqualifiedType (PR #141485)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: QiYue (QiYueFeiXue) Changes Fixes #141397 --- Full diff: https://github.com/llvm/llvm-project/pull/141485.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+5-5) - (added) clang/test/SemaCXX/bug141397.cpp (+16) ``

[clang] [llvm] [HLSL][SPIR-V] Implement vk::ext_builtin_input attribute (PR #138530)

2025-05-26 Thread Nathan Gauër via cfe-commits
Keenuts wrote: @llvm-beanz are you OK with the HLSL-side of the change? https://github.com/llvm/llvm-project/pull/138530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][X86] Fix LIT test failure on Solaris OS + AMD64 CPU. (PR #141486)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Feng Zou (fzou1) Changes The LIT test is introduced by https://github.com/llvm/llvm-project/pull/140874. --- Full diff: https://github.com/llvm/llvm-project/pull/141486.diff 1 Files Affected: - (modified) clang/test/Driver/cl-x86

[clang] [Driver][X86] Fix LIT test failure on Solaris OS + AMD64 CPU. (PR #141486)

2025-05-26 Thread Feng Zou via cfe-commits
https://github.com/fzou1 created https://github.com/llvm/llvm-project/pull/141486 The LIT test is introduced by https://github.com/llvm/llvm-project/pull/140874. >From 5f839ebc0d21f393b30821b1df44d066e4b11d2b Mon Sep 17 00:00:00 2001 From: Feng Zou Date: Mon, 26 May 2025 20:16:34 +0800 Subject

[clang] [clang-tools-extra] [clangd] Collect references in array designators (PR #140356)

2025-05-26 Thread Aleksandr Platonov via cfe-commits
ArcsinX wrote: Friendly ping https://github.com/llvm/llvm-project/pull/140356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-26 Thread Feng Zou via cfe-commits
fzou1 wrote: > This patch broke the [Solaris/amd64 > buildbot](https://lab.llvm.org/staging/#/builders/120/builds/8977). I suspect > the test should use `--target=i386-pc-windows` instead of just `i386`? Sorry for that. I've uploaded a PR (#141486) to fix that. But I didn't verify that since

[clang] [clang][Lex][NFC] Reorder SrcMgr checks in CheckMacroName (PR #141483)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141483 isInPredefinedFile() will look at the presumed loc, which is comparatively slow. Move it after isInSystemFile(). http://llvm-compile-time-tracker.com/compare.php?from=843e362318e884991e517a54446b4faeacdad789&t

[clang] [clang][Lex] Use getBufferName() in isInPredefinedFile() (PR #141490)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes I don't think this depends on #line directives, to it should be fine to use getBufferName. --- Full diff: https://github.com/llvm/llvm-project/pull/141490.diff 1 Files Affected: - (modified) clang/include

[clang] [flang] [flang] add -floop-interchange and enable it with opt levels (PR #140182)

2025-05-26 Thread Ryotaro Kasuga via cfe-commits
kasuga-fj wrote: There is still a correctness issue with LoopInterchange, as I reported in #140238. This problem is not specific to C/C++. The following code demonstrates a case where illegal loop-interchange occurs. ```fortran program main implicit none real, save :: A(5, 5) real,

[clang] dff6aee - [clang][NFC] Call Stmt::getBeginLoc() once in DiagnoseForRangeVariable (#141472)

2025-05-26 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-26T13:46:12+02:00 New Revision: dff6aee94597fda742c41390b1890a5434215dec URL: https://github.com/llvm/llvm-project/commit/dff6aee94597fda742c41390b1890a5434215dec DIFF: https://github.com/llvm/llvm-project/commit/dff6aee94597fda742c41390b1890a5434215dec.diff L

[clang] [clang][NFC] Call Stmt::getBeginLoc() once in DiagnoseForRangeVariable (PR #141472)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Introduce the check::BlockEntrance checker callback (PR #140924)

2025-05-26 Thread Balázs Benics via cfe-commits
balazs-benics-sonarsource wrote: I know it didn't actually pass a week for a ping, but let me know if its on the horizon. https://github.com/llvm/llvm-project/pull/140924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread Akash Agrawal via cfe-commits
https://github.com/akashagrwl updated https://github.com/llvm/llvm-project/pull/141478 >From 72ce442847fe03dd489938eff0eee06c65f53e90 Mon Sep 17 00:00:00 2001 From: Akash Agrawal Date: Mon, 26 May 2025 16:54:21 +0530 Subject: [PATCH 1/2] [LLVM] [NFC] - Remove duplicate #include headers from the

[clang] [clang][ExprConst][NFC] Only call getExprLoc() once (PR #141473)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f17b9a7 - [clang][ExprConst][NFC] Only call getExprLoc() once (#141473)

2025-05-26 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-26T13:45:22+02:00 New Revision: f17b9a77aa902082e1851c9bed9c7749d450d9df URL: https://github.com/llvm/llvm-project/commit/f17b9a77aa902082e1851c9bed9c7749d450d9df DIFF: https://github.com/llvm/llvm-project/commit/f17b9a77aa902082e1851c9bed9c7749d450d9df.diff L

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (PR #141208)

2025-05-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! (Previously reviewed in https://github.com/llvm/llvm-project/pull/80180.) https://github.com/llvm/llvm-project/pull/141208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang][NFC] Move Diags.isIgnored check later in checkForRedundantLoop (PR #141470)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141470 ... Iteration. >From 8849adcac5ffb09c72aa0e270891d508f074add3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 26 May 2025 12:21:04 +0200 Subject: [PATCH] [clang][NFC] Move Diags.isIgnor

[clang] [clang][NFC] Call Stmt::getBeginLoc() once in DiagnoseForRangeVariable (PR #141472)

2025-05-26 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/141472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenCL] Only evaluate initializer once to check for zero init (PR #141474)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Both Expr::isIntegerConstantExpr() and Epxr::EvaluateKnownConstInt() evaluate the expression. Just do it once and check the integer result. --- Full diff: https://github.com/llvm/llvm-project/pull/141474.dif

[clang] [clang][OpenCL] Only evaluate initializer once to check for zero init (PR #141474)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141474 Both Expr::isIntegerConstantExpr() and Epxr::EvaluateKnownConstInt() evaluate the expression. Just do it once and check the integer result. >From 000188d3650923c7747aeeb8f7d02786f8243bf0 Mon Sep 17 00:00:00 20

[clang-tools-extra] ac0a880 - [clang-tidy] added `AllowedTypes` option to `readability-qualified-auto` check (#136571)

2025-05-26 Thread via cfe-commits
Author: Baranov Victor Date: 2025-05-26T13:25:35+03:00 New Revision: ac0a880f4eef2eea03a851dc8d52b1d37cbb1df2 URL: https://github.com/llvm/llvm-project/commit/ac0a880f4eef2eea03a851dc8d52b1d37cbb1df2 DIFF: https://github.com/llvm/llvm-project/commit/ac0a880f4eef2eea03a851dc8d52b1d37cbb1df2.diff

[clang] [clang][ExprConst][NFC] Only call getExprLoc() once (PR #141473)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes It's potentially costly, so only do it once. --- Full diff: https://github.com/llvm/llvm-project/pull/141473.diff 1 Files Affected: - (modified) clang/lib/AST/ExprConstant.cpp (+4-3) ``diff diff

[clang] Thread safety analysis: Skip functions acquiring/releasing parameters (PR #141432)

2025-05-26 Thread Marco Elver via cfe-commits
melver wrote: > @melver, this request came from @AaronBallman. But since you're also working > on Thread Safety Analysis in C, you might have some thoughts of your own > about this. > > I haven't checked any real-world code yet. (Specifically, how many functions > would be affected by this ex

[clang] [clang][Sema] Cleanup and optimize DiagnoseAssignmentEnum (PR #141471)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Reorder the precondition checks to move the costly onces last. Also, only evaluate the RHS once to get the integral value. --- Full diff: https://github.com/llvm/llvm-project/pull/141471.diff 1 Files Affec

[clang] [clang][NFC] Call Stmt::getBeginLoc() once in DiagnoseForRangeVariable (PR #141472)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141472 ...Copies. Instead of three times. >From 789064d5997ace0ed145a8d15e1b00452ff33305 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 26 May 2025 12:22:51 +0200 Subject: [PATCH] [clang][NFC

[clang] [clang][ExprConst][NFC] Only call getExprLoc() once (PR #141473)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141473 It's potentially costly, so only do it once. >From 6aab696419ca3762237461e2be46c96015dac4ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 26 May 2025 12:17:24 +0200 Subject: [PATCH] [

[clang] [clang][NFC] Call Stmt::getBeginLoc() once in DiagnoseForRangeVariable (PR #141472)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes ...Copies. Instead of three times. --- Full diff: https://github.com/llvm/llvm-project/pull/141472.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaStmt.cpp (+4-6) ``diff diff --git a/clan

[clang] [Feat] Allow Finding across only parts of an AST. (PR #127423)

2025-05-26 Thread via cfe-commits
matts1 wrote: I've currently put it on hold since I'm prioritising allowing config mismatches https://github.com/llvm/llvm-project/pull/127423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [Clang] Allow Finding across only parts of an AST. (PR #127423)

2025-05-26 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/127423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LoongArch] Support target attribute for function (PR #140700)

2025-05-26 Thread via cfe-commits
@@ -0,0 +1,92 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals all --version 5 +// RUN: %clang --target=loongarch64-linux-gnu %s -S -emit-llvm -o - \ +// RUN: | FileCheck %s + +__attribute__((target("div32"))) +// CHECK

[clang] [Clang] Clean up the fix for deferred access checking (PR #141340)

2025-05-26 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Sure, let's just wait until CWG opines. https://github.com/llvm/llvm-project/pull/141340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
@@ -13372,6 +13376,17 @@ class Sema final : public SemaBase { bool SkipForSpecialization = false, bool ForDefaultArgumentSubstitution = false); + /// Apart from storing the result to \p Result, this behaves the same as + /// another overload. cor

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
@@ -522,6 +522,12 @@ enum class TemplateSubstitutionKind : char { llvm::PointerUnion * findInstantiationOf(const Decl *D); +/// Similar to \p findInstantiationOf(), but it wouldn't assert if the +/// instantiation was not found within the current instantiation

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
@@ -1921,9 +1956,62 @@ Decl *TemplateInstantiator::TransformDecl(SourceLocation Loc, Decl *D) { // template parameter. } + if (SemaRef.CurrentInstantiationScope) { +if (SemaRef.inConstraintSubstitution() && isa(D) && +maybeInstantiateFunctionParameterToScop

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
@@ -10506,7 +10506,8 @@ class Sema final : public SemaBase { FunctionTemplateDecl *FunctionTemplate, ArrayRef ParamTypes, ArrayRef Args, OverloadCandidateSet &CandidateSet, ConversionSequenceList &Conversions, bool SuppressUserConversions, - CXXRecordDecl

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
@@ -12554,7 +12555,9 @@ class Sema final : public SemaBase { sema::TemplateDeductionInfo &Info, SmallVectorImpl const *OriginalCallArgs, bool PartialOverloading, bool PartialOrdering, - llvm::function_ref CheckNonDependent = [] { return false; }); +

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
@@ -13458,6 +13473,10 @@ class Sema final : public SemaBase { // FIXME: Should we have a similar limit for other forms of synthesis? unsigned NonInstantiationEntries; + /// The number of \p CodeSynthesisContexts that are not constraint + /// substitution. + unsigned Non

[clang] [llvm] [clang][CodeGen][AA] Add `!llvm.errno.tbaa` gathering int-compatible TBAA nodes (PR #125258)

2025-05-26 Thread Antonio Frighetto via cfe-commits
antoniofrighetto wrote: Gentle ping, would be nice moving this forward. https://github.com/llvm/llvm-project/pull/125258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-redundant-smartptr-get: disable for smart pointers to arrays (PR #141092)

2025-05-26 Thread via cfe-commits
https://github.com/FabianWolff updated https://github.com/llvm/llvm-project/pull/141092 >From 3ed915b5a5e97e327b132a612a817ebcff42a6a5 Mon Sep 17 00:00:00 2001 From: Fabian Wolff Date: Mon, 26 May 2025 08:45:21 + Subject: [PATCH] [clang-tidy] readability-redundant-smartptr-get: disable for

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
https://github.com/cor3ntin commented: Thanks a lot for working on this https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

2025-05-26 Thread via cfe-commits
@@ -1432,12 +1459,20 @@ namespace { ArrayRef Unexpanded, bool &ShouldExpand, bool &RetainExpansion, UnsignedOrNone &NumExpansions) { - return getSema().CheckParameterPacksFor

[clang] [analyzer] Introduce the check::BlockEntrance checker callback (PR #140924)

2025-05-26 Thread Balázs Benics via cfe-commits
@@ -166,6 +179,23 @@ class CheckerDocumentation /// check::Bind void checkBind(SVal Loc, SVal Val, const Stmt *S, CheckerContext &) const {} + /// Called after a CFG edge is taken within a function. + /// + /// This callback can be used to obtain information about poten

[clang-tools-extra] [clang-tidy] Add avoid-pragma-once. (PR #140388)

2025-05-26 Thread Tommy Chen via cfe-commits
https://github.com/dl8sd11 updated https://github.com/llvm/llvm-project/pull/140388 >From 5bc074dadddb094bf954388a95ecb818abe17b56 Mon Sep 17 00:00:00 2001 From: dl8sd11 Date: Sat, 17 May 2025 17:23:26 + Subject: [PATCH 1/9] [clang-tidy] Add avoid-pragma-once. --- .../portability/AvoidPra

[clang] [analyzer][NFC] Introduce framework for checker families (PR #139256)

2025-05-26 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,Balazs Benics ,Balazs Benics , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?=

[clang-tools-extra] [clang-tidy] Add avoid-pragma-once. (PR #140388)

2025-05-26 Thread Tommy Chen via cfe-commits
https://github.com/dl8sd11 updated https://github.com/llvm/llvm-project/pull/140388 >From 5bc074dadddb094bf954388a95ecb818abe17b56 Mon Sep 17 00:00:00 2001 From: dl8sd11 Date: Sat, 17 May 2025 17:23:26 + Subject: [PATCH 01/10] [clang-tidy] Add avoid-pragma-once. --- .../portability/AvoidP

[clang-tools-extra] [clang-tidy] Add check for assignment or comparision operators' operand in `readability-math-missing-parentheses` (PR #141345)

2025-05-26 Thread Baranov Victor via cfe-commits
vbvictor wrote: Please write "Closes https://github.com/llvm/llvm-project/issues/141249 (issue no)" at the end of PR description. It will automatically link the issue, which will be closed on merge. For now, I added it manually. https://github.com/llvm/llvm-project/pull/141345 ___

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-05-26 Thread Marco Elver via cfe-commits
https://github.com/melver updated https://github.com/llvm/llvm-project/pull/137133 >From bce9df281e5ea7c2efd9c880f791f6572732c31d Mon Sep 17 00:00:00 2001 From: Marco Elver Date: Wed, 23 Apr 2025 11:31:25 +0200 Subject: [PATCH 1/2] Thread Safety Analysis: Convert CapabilityExpr::CapExpr to hol

[clang] [analyzer] Introduce the check::BlockEntrance checker callback (PR #140924)

2025-05-26 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: I finished reviewing the non-test code and overall it LGTM, but I added two minor questions as inline comments. I'll review the tests tomorrow. https://github.com/llvm/llvm-project/pull/140924 ___ cfe-commits ma

[clang] [analyzer] Introduce the check::BlockEntrance checker callback (PR #140924)

2025-05-26 Thread Donát Nagy via cfe-commits
@@ -548,6 +564,8 @@ class CheckerProgramPointTag : public SimpleProgramPointTag { template class Checker : public CHECK1, public CHECKs..., public CheckerBase { public: + using BlockEntrance = clang::BlockEntrance; NagyDonat wrote: Why is this `using` requi

[clang] [analyzer] Introduce the check::BlockEntrance checker callback (PR #140924)

2025-05-26 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/140924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][clangd][test] add clang-tidy config to ensure test cases sandbox (PR #141410)

2025-05-26 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/141410 >From ac614ac46750b19d2810d838112ba8b01388f577 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sun, 25 May 2025 23:30:24 +0800 Subject: [PATCH 1/2] [NFC][clangd][test] add clang-tidy config to ensure test

[clang] [clang][NFC] Move Diags.isIgnored check later in checkForRedundantLoop (PR #141470)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes ... Iteration. --- Full diff: https://github.com/llvm/llvm-project/pull/141470.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaStmt.cpp (+4-4) ``diff diff --git a/clang/lib/Sema/SemaStmt.

[clang] [clang][Sema] Cleanup and optimize DiagnoseAssignmentEnum (PR #141471)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141471 Reorder the precondition checks to move the costly onces last. Also, only evaluate the RHS once to get the integral value. >From 7b0a2b83146623a1674967ff4353a9eea6efd25e Mon Sep 17 00:00:00 2001 From: =?UTF-8?

[clang] [clang][Sema] Cleanup and optimize DiagnoseAssignmentEnum (PR #141471)

2025-05-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: http://llvm-compile-time-tracker.com/compare.php?from=843e362318e884991e517a54446b4faeacdad789&to=7b0a2b83146623a1674967ff4353a9eea6efd25e&stat=instructions:u https://github.com/llvm/llvm-project/pull/141471 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy] Add new `construct-reusable-objects-once` check (PR #131455)

2025-05-26 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/131455 >From 877c3a8c2a6e03d04d0a6b921a01a6f93aa43771 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 15 Mar 2025 17:36:23 +0300 Subject: [PATCH 1/3] add new construct-reusable-objects-once check --- .../cl

[clang] [clang][Sema] Cleanup and optimize DiagnoseAssignmentEnum (PR #141471)

2025-05-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/141471 >From 7b0a2b83146623a1674967ff4353a9eea6efd25e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 26 May 2025 12:19:22 +0200 Subject: [PAT

[clang] [ClangTool] Use CC1Option flag resource-dir in injectResourceDir (PR #140870)

2025-05-26 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. do we know why https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td#L5894-L5901 doesn't declare _EQ version for cc1? i think instead of working around this in various places, we should unify the

[clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Akash Agrawal (akashagrwl) Changes A few files of lldb dir & few other files had duplicate headers included. This patch removes those redundancies. --- Full diff: https://github.com/llvm/llvm-project/pull/141478.diff 15 Files Affected:

[clang] [clang][Lex][NFC] Reorder SrcMgr checks in CheckMacroName (PR #141483)

2025-05-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes isInPredefinedFile() will look at the presumed loc, which is comparatively slow. Move it after isInSystemFile(). http://llvm-compile-time-tracker.com/compare.php?from=843e362318e884991e517a54446b4faeacdad789

[clang] [Sema] built-in args type checking using hasSameUnqualifiedType (PR #141485)

2025-05-26 Thread via cfe-commits
https://github.com/QiYueFeiXue created https://github.com/llvm/llvm-project/pull/141485 Fixes #141397 >From 3973f98b7285796975ca6e7d41e938e28c942a00 Mon Sep 17 00:00:00 2001 From: QiYue Date: Mon, 26 May 2025 19:51:24 +0800 Subject: [PATCH] [Sema] built-in args type checking using hasSameUnqu

[clang-tools-extra] [NFC][clangd][test] add clang-tidy config to ensure test cases sandbox (PR #141410)

2025-05-26 Thread Congcong Cai via cfe-commits
@@ -0,0 +1 @@ +InheritParentConfig: false HerrCai0907 wrote: path-mapping will copy all folder to tmp folder. but i agree disable clangtidy is better https://github.com/llvm/llvm-project/pull/141410 ___ cfe-commits ma

[clang] [clang][Lex] Use getBufferName() in isInPredefinedFile() (PR #141490)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141490 I don't think this depends on #line directives, to it should be fine to use getBufferName. >From e8e0bddda7dcc5e64624912e68f5de8d7ff485eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon

[clang] [clang][Lex] Use getBufferName() in isInPredefinedFile() (PR #141490)

2025-05-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: http://llvm-compile-time-tracker.com/compare.php?from=0917b0525b49f0d8fe64e26947449c55db5fc00a&to=65f3db15d875c7279c95afdd2a9221ec43dc61b4&stat=instructions:u https://github.com/llvm/llvm-project/pull/141490 ___ cfe-commits mailing list

[clang] [clang][Lex] Use getBufferName() in isInPredefinedFile() (PR #141490)

2025-05-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: Damn https://github.com/llvm/llvm-project/pull/141490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Lex] Use getBufferName() in isInPredefinedFile() (PR #141490)

2025-05-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add pm_event intrinsics (PR #141278)

2025-05-26 Thread Durgadoss R via cfe-commits
https://github.com/durga4github updated https://github.com/llvm/llvm-project/pull/141278 >From 0fc21a165a6f9202b441d1d8c4afa1252f9d6cc6 Mon Sep 17 00:00:00 2001 From: Durgadoss R Date: Fri, 23 May 2025 20:43:18 +0530 Subject: [PATCH] [NVPTX] Add pm_event intrinsics This patch adds pm_event.mas

[clang] [llvm] [NVPTX] Add pm_event intrinsics (PR #141278)

2025-05-26 Thread Durgadoss R via cfe-commits
@@ -7172,6 +7172,17 @@ defm INT_SET_MAXNREG_DEC : SET_MAXNREG<"dec", int_nvvm_setmaxnreg_dec_sync_align } // isConvergent +let hasSideEffects = 1 in { +// Performance Monitor events +def INT_PM_EVENT_IDX : NVPTXInst<(outs), (ins i32imm:$idx), durga4github w

[clang] [llvm] [NVPTX] Add pm_event intrinsics (PR #141278)

2025-05-26 Thread Durgadoss R via cfe-commits
@@ -768,6 +768,18 @@ let TargetPrefix = "nvvm" in { DefaultAttrsIntrinsic<[], [llvm_i32_ty], [IntrConvergent, IntrNoMem, IntrHasSideEffects]>; + // Performance Monitor Events (pm events) intrinsics + // The imm-argument to the _idx variant m

[clang] [llvm] [NVPTX] Add pm_event intrinsics (PR #141278)

2025-05-26 Thread Durgadoss R via cfe-commits
https://github.com/durga4github edited https://github.com/llvm/llvm-project/pull/141278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-26 Thread Feng Zou via cfe-commits
fzou1 wrote: > > This patch broke the [Solaris/amd64 > > buildbot](https://lab.llvm.org/staging/#/builders/120/builds/8977). I > > suspect the test should use `--target=i386-pc-windows` instead of just > > `i386`? > > Sorry for that. I've uploaded a PR (#141486) to fix that. But I didn't veri

[clang] [Driver][X86] Fix LIT test failure on Solaris OS + AMD64 CPU. (PR #141486)

2025-05-26 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/141486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3