https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/141472
...Copies. Instead of three times.
>From 789064d5997ace0ed145a8d15e1b00452ff33305 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?= <tbae...@redhat.com>
Date: Mon, 26 May 2025 12:22:51 +0200
Subject: [PATCH] [clang][NFC] Call Stmt::getBeginLoc() once in
DiagnoseForRangeVariable
...Copies. Instead of three times.
---
clang/lib/Sema/SemaStmt.cpp | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp
index ed070649dc1f9..c943645c3ab9d 100644
--- a/clang/lib/Sema/SemaStmt.cpp
+++ b/clang/lib/Sema/SemaStmt.cpp
@@ -3172,13 +3172,11 @@ static void DiagnoseForRangeVariableCopies(Sema
&SemaRef,
if (SemaRef.inTemplateInstantiation())
return;
+ SourceLocation Loc = ForStmt->getBeginLoc();
if (SemaRef.Diags.isIgnored(
- diag::warn_for_range_const_ref_binds_temp_built_from_ref,
- ForStmt->getBeginLoc()) &&
- SemaRef.Diags.isIgnored(diag::warn_for_range_ref_binds_ret_temp,
- ForStmt->getBeginLoc()) &&
- SemaRef.Diags.isIgnored(diag::warn_for_range_copy,
- ForStmt->getBeginLoc())) {
+ diag::warn_for_range_const_ref_binds_temp_built_from_ref, Loc) &&
+ SemaRef.Diags.isIgnored(diag::warn_for_range_ref_binds_ret_temp, Loc) &&
+ SemaRef.Diags.isIgnored(diag::warn_for_range_copy, Loc)) {
return;
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
