[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/141037 >From 1148711cdfdd5a58960564790509559fa86e2649 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Thu, 22 May 2025 09:59:53 +0800 Subject: [PATCH] [Clang][LoongArch] Add inline asm support for the `q` constraint Thi

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher ready_for_review https://github.com/llvm/llvm-project/pull/141037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread WÁNG Xuěruì via cfe-commits
https://github.com/xen0n commented: What about making a test case that exerts great pressure on the register allocator to verify that `$ra` does not get accidentally handed out? Or if that's too fragile, if it's possible, make a variable pinned to `$ra` or `$zero` then pass it to the inline as

[clang] [Sema] Warn about omitting deprecated enumerator in switch (PR #138562)

2025-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Please add a release note to `clang/docs/ReleaseNotes.rst` so users know about the new functionality and flag. Otherwise, LGTM! https://github.com/llvm/llvm-project/pull/138562 ___ cfe-commi

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: hev (heiher) Changes This patch adds support for the `q` constraint: a general-purpose register except for $r0 and $r1 (for the csrxchg instruction) Link: https://gcc.gnu.org/pipermail/gcc-patches/2025-May/684339.html --- Full diff: https

[clang] [XRay] Fix argument parsing with offloading (#140748) (PR #141043)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sebastian Kreutzer (sebastiankreutzer) Changes This PR addressed issue #140748 to support XRay instrumentation on the host side when using offloading. It makes the following changes: - Initializes `XRayArgs` using the processed toolchain

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (LSP 3.18) (PR #80180)

2025-05-22 Thread Tom Praschan via cfe-commits
@@ -851,10 +851,23 @@ struct DocumentRangeFormattingParams { /// The range to format Range range; + + /// The list of ranges to format + std::optional> ranges; tom-anders wrote: Ah yes, this is from an old version of the spec, where `textDocument/range

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (LSP 3.18) (PR #80180)

2025-05-22 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders edited https://github.com/llvm/llvm-project/pull/80180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (LSP 3.18) (PR #80180)

2025-05-22 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders edited https://github.com/llvm/llvm-project/pull/80180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/141037 >From 1148711cdfdd5a58960564790509559fa86e2649 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Thu, 22 May 2025 09:59:53 +0800 Subject: [PATCH 1/2] [Clang][LoongArch] Add inline asm support for the `q` constraint

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher converted_to_draft https://github.com/llvm/llvm-project/pull/141037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed edited https://github.com/llvm/llvm-project/pull/141036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Clean up SemaChecking.cpp (PR #141041)

2025-05-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141041 Make pointer parameters const, remove some unused parameters, fix coding style, etc. >From a79f0474700c1b96b98ef4d05c30816b48742e5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 22 M

[clang] [clang][NFC] Clean up SemaChecking.cpp (PR #141041)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Make pointer parameters const, remove some unused parameters, fix coding style, etc. --- Full diff: https://github.com/llvm/llvm-project/pull/141041.diff 4 Files Affected: - (modified) clang/include/clang

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread via cfe-commits
@@ -61,11 +61,14 @@ struct ScopedFatalErrorHandler { /// @deprecated Use reportFatalInternalError() or reportFatalUsageError() /// instead. [[noreturn]] LLVM_ABI void report_fatal_error(const char *reason, - bool gen_crash_diag = tru

[clang] [CodeGen] Add TBAA struct path info for array members (PR #137719)

2025-05-22 Thread Bruno De Fraine via cfe-commits
brunodf-snps wrote: Hm, I was still adding test cases involving may_alias, but I still found problems with the following: ``` typedef int __attribute__((may_alias)) aliasing_int; typedef int __attribute__((may_alias)) aliasing_array[10]; struct E { aliasing_int x[4]; aliasing_array y; }; ``` B

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread via cfe-commits
@@ -1,15 +1,26 @@ -; REQUIRES: x86, non-root-user -;; Not supported on windows since we use permissions to deny the creation -; UNSUPPORTED: system-windows +;; The output is OS-specific, so this test is limited to Windows. bd1976bris wrote: Thanks. I made the tes

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread via cfe-commits
@@ -744,7 +744,7 @@ template class [[nodiscard]] Expected { /// @deprecated Use reportFatalInternalError() or reportFatalUsageError() /// instead. [[noreturn]] LLVM_ABI void report_fatal_error(Error Err, - bool gen_crash_diag = true

[clang] [XRay] Fix argument parsing with offloading (#140748) (PR #141043)

2025-05-22 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer created https://github.com/llvm/llvm-project/pull/141043 This PR addressed issue #140748 to support XRay instrumentation on the host side when using offloading. It makes the following changes: - Initializes `XRayArgs` using the processed toolchain argument

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/141037 >From 1148711cdfdd5a58960564790509559fa86e2649 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Thu, 22 May 2025 09:59:53 +0800 Subject: [PATCH 1/3] [Clang][LoongArch] Add inline asm support for the `q` constraint

[clang] [clang][bytecode] Fix self-init diagnostics in C++23 (PR #141044)

2025-05-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/141044 None >From bbd228b43194e37e0b5441c3f682a35ff27171b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 22 May 2025 13:34:33 +0200 Subject: [PATCH] [clang][bytecode] Fix self-init diagnosti

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
heiher wrote: > What about making a test case that exerts great pressure on the register > allocator to verify that `$ra` does not get accidentally handed out? I've done that, similar to what was done in #140862 > Or if that's too fragile, if it's possible, make a variable pinned to `$ra` > o

[clang] [clang][bytecode] Fix self-init diagnostics in C++23 (PR #141044)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141044.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Interp.cpp (+2-1) - (modified) clang/test/AST/ByteCode/cxx23.cpp (+6) ```

[clang] move ASTImporter into separate library (PR #140913)

2025-05-22 Thread via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: cor3ntin wrote: Trying to move that seems to work. Are there other nodes with definitions in the wrong place? https://github.com/llvm/llvm-project/compare/main...cor3ntin:llvm-project:corentin/reorg_concepts?expand=1 https://github.com/llvm/llv

[clang] [CIR] Simplify error emission to return failures directly (PR #141032)

2025-05-22 Thread Henrich Lauko via cfe-commits
xlauko wrote: * **#141032** https://app.graphite.dev/github/pr/llvm/llvm-project/141032?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/14103

[clang] [XRay] Fix argument parsing with offloading (#140748) (PR #141043)

2025-05-22 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer updated https://github.com/llvm/llvm-project/pull/141043 >From ff1ff0ca990bc42bbc2a484144050fe3993a0347 Mon Sep 17 00:00:00 2001 From: Sebastian Kreutzer Date: Thu, 22 May 2025 12:55:48 +0200 Subject: [PATCH 1/2] [XRay] Fix argument parsing with offloading

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 76a55d3 - [KeyInstr][Clang] Scalar init atom (#134633)

2025-05-22 Thread via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-05-22T12:50:10+01:00 New Revision: 76a55d3860f76c15ca51d188e10e4352fecf61e9 URL: https://github.com/llvm/llvm-project/commit/76a55d3860f76c15ca51d188e10e4352fecf61e9 DIFF: https://github.com/llvm/llvm-project/commit/76a55d3860f76c15ca51d188e10e4352fecf61

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-22 Thread via cfe-commits
@@ -3373,6 +3409,51 @@ the configuration (without a prefix: ``Auto``). +.. _BreakBeforeCloseBracketIf: + +**BreakBeforeCloseBracketIf** (``Boolean``) :versionbadge:`clang-format 21` :ref:`¶ ` + Force break before the right parenthesis of an if control statement + when the

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-22 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/108332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-22 Thread via cfe-commits
https://github.com/mydeveloperday commented: your BreakBeforeCloseBracket true case seem to imply BreakAfterOpenBracket is that what you expect? https://github.com/llvm/llvm-project/pull/108332 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-22 Thread via cfe-commits
@@ -3373,6 +3409,51 @@ the configuration (without a prefix: ``Auto``). +.. _BreakBeforeCloseBracketIf: + +**BreakBeforeCloseBracketIf** (``Boolean``) :versionbadge:`clang-format 21` :ref:`¶ ` + Force break before the right parenthesis of an if control statement + when the

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread Xi Ruoyao via cfe-commits
xry111 wrote: I have a C test case: ```c unsigned long test (unsigned long x, unsigned long y) { register unsigned long ra asm ("ra"); asm("" : "+r"(ra)); unsigned long t = ra; asm ("csrxchg %0, %1, 0" : "+r" (x) : "r" (t)); return x; } ``` clang-20.1.4 errors out: ``` t.c:8:8: err

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-22 Thread via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -1,15 +1,26 @@ -; REQUIRES: x86, non-root-user -;; Not supported on windows since we use permissions to deny the creation -; UNSUPPORTED: system-windows +;; The output is OS-specific, so this test is limited to Windows. arsenm wrote: This new failure condition

[clang] [OpenMP] Add diagnostic for 'factor' width mismatch in 'unroll partial' (PR #139986)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -14924,6 +14924,21 @@ StmtResult SemaOpenMP::ActOnOpenMPUnrollDirective(ArrayRef Clauses, SourceLocation FactorLoc; if (Expr *FactorVal = PartialClause->getFactor(); FactorVal && !FactorVal->containsErrors()) { +if (!VerifyPositiveIntegerConstantInClause(Facto

[clang] [OpenMP] Add diagnostic for 'factor' width mismatch in 'unroll partial' (PR #139986)

2025-05-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Thanks for the review. I’ve implemented all the requested changes but still > have a few questions: > > * Originally, using `IVTy` to query the iteration variable’s width always > returned “32-bit int,” even if the loop was declared as `char` or `short`. As > a resul

[clang] [OpenMP] Add diagnostic for 'factor' width mismatch in 'unroll partial' (PR #139986)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -14924,6 +14924,21 @@ StmtResult SemaOpenMP::ActOnOpenMPUnrollDirective(ArrayRef Clauses, SourceLocation FactorLoc; if (Expr *FactorVal = PartialClause->getFactor(); FactorVal && !FactorVal->containsErrors()) { +if (!VerifyPositiveIntegerConstantInClause(Facto

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
heiher wrote: > I have a C test case: > > ```c > unsigned long > test (unsigned long x, unsigned long y) > { > register unsigned long ra asm ("ra"); > asm("" : "+r"(ra)); > > unsigned long t = ra; > asm ("csrxchg %0, %1, 0" : "+r" (x) : "r" (t)); > > return x; > } > ``` > > clang-20

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (PR #141052)

2025-05-22 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders created https://github.com/llvm/llvm-project/pull/141052 Uses the protocol changes proposed in https://github.com/microsoft/language-server-protocol/pull/1556 and https://github.com/microsoft/vscode/pull/163190 Related issue: https://github.com/clangd/clangd/issu

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (PR #141052)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Tom Praschan (tom-anders) Changes Uses the protocol changes proposed in https://github.com/microsoft/language-server-protocol/pull/1556 and https://github.com/microsoft/vscode/pull/163190 Related issue: https://github.com/cla

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh created https://github.com/llvm/llvm-project/pull/141053 In some specific scenarios, `Ptr.getElementType()` won't be a primitive type or a vector of primitive types, and thus `getScalarSizeInBits()` returns zero. Use the datalayout to get the proper size of the type

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (PR #141052)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Tom Praschan (tom-anders) Changes Uses the protocol changes proposed in https://github.com/microsoft/language-server-protocol/pull/1556 and https://github.com/microsoft/vscode/pull/163190 Related issue: https://github.com/clangd/clangd/

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: * **#141053** https://app.graphite.dev/github/pr/llvm/llvm-project/141053?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/14

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (PR #141052)

2025-05-22 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Pierre van Houtryve (Pierre-vh) Changes In some specific scenarios, `Ptr.getElementType()` won't be a primitive type or a vector of primitive types, and thus `getScalarSizeInBits()` returns zero. Use the

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh ready_for_review https://github.com/llvm/llvm-project/pull/141053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add support for textDocument/rangesFormatting (PR #141052)

2025-05-22 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders updated https://github.com/llvm/llvm-project/pull/141052 >From bf46903a8c8b063a54918c526c2c1f3aa16466a5 Mon Sep 17 00:00:00 2001 From: tom-anders <13141438+tom-and...@users.noreply.github.com> Date: Thu, 18 May 2023 12:05:01 +0200 Subject: [PATCH] [clangd] Add suppo

[clang] [llvm] Reland "Add macro to suppress -Wunnecessary-virtual-specifier" (PR #141091)

2025-05-22 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/141091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Add test checking for tls support on xros target triples (PR #141170)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/11956 Here is the relevant piece of the build log f

[clang] 835bba9 - [clang][Darwin] Add test checking for tls support on xros target triples (#141170)

2025-05-22 Thread via cfe-commits
Author: Cyndy Ishida Date: 2025-05-22T21:44:34-07:00 New Revision: 835bba973d7a5f539967cdae2dc4bd3fc4a904f9 URL: https://github.com/llvm/llvm-project/commit/835bba973d7a5f539967cdae2dc4bd3fc4a904f9 DIFF: https://github.com/llvm/llvm-project/commit/835bba973d7a5f539967cdae2dc4bd3fc4a904f9.diff

[clang] [clang][Darwin] Add test checking for tls support on xros target triples (PR #141170)

2025-05-22 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/141170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
@@ -135,3 +135,53 @@ void f(void) { } + + +// RUN: not %clang_cl -### --target=i386 -mapx-features=ndd %s 2>&1 | FileCheck --check-prefix=NON-APX %s +// RUN: not %clang_cl -### --target=i386 -mapxf %s 2>&1 | FileCheck --check-prefix=NON-APX %s +// RUN: %clang_cl -### --targe

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
https://github.com/fzou1 updated https://github.com/llvm/llvm-project/pull/140874 >From d683302d4768dfb5c618aa1b09553f3b22142aed Mon Sep 17 00:00:00 2001 From: Feng Zou Date: Tue, 20 May 2025 22:10:07 +0800 Subject: [PATCH 1/3] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group This is to e

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
https://github.com/fzou1 updated https://github.com/llvm/llvm-project/pull/140874 >From d683302d4768dfb5c618aa1b09553f3b22142aed Mon Sep 17 00:00:00 2001 From: Feng Zou Date: Tue, 20 May 2025 22:10:07 +0800 Subject: [PATCH 1/4] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group This is to e

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
@@ -135,3 +135,53 @@ void f(void) { } + + +// RUN: not %clang_cl -### --target=i386 -mapx-features=ndd %s 2>&1 | FileCheck --check-prefix=NON-APX %s +// RUN: not %clang_cl -### --target=i386 -mapxf %s 2>&1 | FileCheck --check-prefix=NON-APX %s +// RUN: %clang_cl -### --targe

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
@@ -6679,8 +6679,13 @@ def mapx_features_EQ : CommaJoined<["-"], "mapx-features=">, Group, Values<"egpr,push2pop2,ppx,ndd,ccmp,nf,cf,zu">, Visibility<[ClangOption, CLOption, FlangOption]>; def mno_apx_features_EQ : CommaJoined<["-"], "mno-apx-features=">, Group, HelpTex

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
@@ -135,3 +135,53 @@ void f(void) { } + + +// RUN: not %clang_cl -### --target=i386 -mapx-features=ndd %s 2>&1 | FileCheck --check-prefix=NON-APX %s +// RUN: not %clang_cl -### --target=i386 -mapxf %s 2>&1 | FileCheck --check-prefix=NON-APX %s +// RUN: %clang_cl -### --targe

[clang] [AST] Simplify string comparisons (NFC) (PR #141189)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/18225 Her

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: Sorry, I mean committing a test w/ the current in-tree behavior, and then this patch would have your fix and a small delta to the test showing the new behavior. Some information on that can be found here: https://llvm.org/docs/TestingGuide.html#precommit-workflow-for-tests http

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: You can find a stack where I did that here: https://app.graphite.dev/github/pr/llvm/llvm-project/135705/%5Bllvm%5D%5Blto%5D-Precommit-test-for-libcall-internalization Those aren't landed, since we're hashing out the proper way to fix things, but I added a test w/ the behavior to

[clang] [llvm] [mlir] Reland "[NVPTX] Unify and extend barrier{.cta} intrinsic support" (PR #141143)

2025-05-22 Thread Alex MacLean via cfe-commits
https://github.com/AlexMaclean updated https://github.com/llvm/llvm-project/pull/141143 >From a46075f9aa3970735104cbcf2503ebef89db Mon Sep 17 00:00:00 2001 From: Alex MacLean Date: Wed, 21 May 2025 08:14:15 -0700 Subject: [PATCH 1/2] [NVPTX] Unify and extend barrier{.cta} intrinsic support

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel` running on `ppc64le-clang-rhel-test` while building `clang-tools-extra` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/720

[clang] [CIR] Add alignment support for global, store, and load ops (PR #141163)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This adds alignment support for GlobalOp, LoadOp, and StoreOp. Tests which failed because cir.store/cir.load now print alignment were updated with wildcard matches, except where the alignment was relevant

[clang] [CIR] Add alignment support for global, store, and load ops (PR #141163)

2025-05-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,c,cpp -- clang/test/CIR/CodeGen/align-load.c clang/test/CI

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-22 Thread Andy Kaylor via cfe-commits
@@ -1427,13 +1427,13 @@ OpFoldResult cir::SelectOp::fold(FoldAdaptor adaptor) { //===--===// LogicalResult cir::ShiftOp::verify() { mlir::Operation *op = getOperation(); - mlir::Type resType = getResult().g

[clang] [OpenACC][CIR] Add lowering for 'copy' array indexes (PR #140971)

2025-05-22 Thread Andy Kaylor via cfe-commits
@@ -184,37 +189,94 @@ class OpenACCClauseCIREmitter final mlir::Location beginLoc; mlir::Value varValue; llvm::StringRef name; +llvm::SmallVector bounds; }; + mlir::Value createBound(mlir::Location boundLoc, mlir::Value lowerBound, +

[clang] [OpenACC][CIR] Add lowering for 'copy' array indexes (PR #140971)

2025-05-22 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/140971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Add lowering for 'copy' array indexes (PR #140971)

2025-05-22 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm with just one nit https://github.com/llvm/llvm-project/pull/140971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add pre-defined macro tests for Andes vendor extension. NFC. (PR #141172)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Jim Lin (tclin914) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141172.diff 1 Files Affected: - (added) clang/test/Preprocessor/riscv-target-features-andes.c (+32) ``diff diff --git a/clang/test/

[clang] [RISCV] Add pre-defined macro tests for Andes vendor extension. NFC. (PR #141172)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jim Lin (tclin914) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141172.diff 1 Files Affected: - (added) clang/test/Preprocessor/riscv-target-features-andes.c (+32) ``diff diff --git a/clang/test/Preproces

[clang] [RISCV] Add pre-defined macro tests for Andes vendor extension. NFC. (PR #141172)

2025-05-22 Thread Jim Lin via cfe-commits
https://github.com/tclin914 created https://github.com/llvm/llvm-project/pull/141172 None >From 036a3bd7024fe358d670b49d1d62bfe3cc0bc6d4 Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Thu, 22 May 2025 15:05:30 +0800 Subject: [PATCH] [RISCV] Add pre-defined macro tests for Andes vendor extension

[clang] [Clang] Preserve CXXParenListInitExpr in TreeTransform. (PR #138518)

2025-05-22 Thread Alexander Kornienko via cfe-commits
alexfh wrote: @cor3ntin this commit causes an assertion failure: https://gcc.godbolt.org/z/7hW4ssrfq ``` $ cat test.cc struct E { virtual void f(); }; struct G { E e; }; template struct Test { virtual void f() { E e; G g(e); } }; auto *t = new Test; $ ./clang-bad -c -o /dev/nul

[clang] [clang][SPIR-V] Fix OpenCL addrspace mapping when using non-zero default AS (PR #137187)

2025-05-22 Thread Wu Yingcong via cfe-commits
yingcong-wu wrote: Hi @sarnex , I just want to let you know that this change is important to us, and want to express our gratitude to you in the previous comment. https://github.com/llvm/llvm-project/pull/137187 ___ cfe-commits mailing list cfe-commi

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/wangleiat approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/141037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSignature] Add parsing of flags to RootDescriptor (PR #140152)

2025-05-22 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/140152 >From 3daccf83b60e2a5435097b950eaf3cf07a39b440 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 15 May 2025 20:31:30 + Subject: [PATCH 1/3] [HLSL][RootSignature] Add parsing of flags to RootParam - de

[clang] [llvm] [Options] Add same-address constraint to the description of '-m[no]ld-seq-sa' (PR #141192)

2025-05-22 Thread via cfe-commits
https://github.com/Ami-zhang updated https://github.com/llvm/llvm-project/pull/141192 >From 6f3c80398e05ead828af2bac844992df8d8f5699 Mon Sep 17 00:00:00 2001 From: Ami-zhang Date: Fri, 23 May 2025 10:21:00 +0800 Subject: [PATCH] [Options] Add same-address constraint to the description of '-m[n

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
https://github.com/fzou1 updated https://github.com/llvm/llvm-project/pull/140874 >From d683302d4768dfb5c618aa1b09553f3b22142aed Mon Sep 17 00:00:00 2001 From: Feng Zou Date: Tue, 20 May 2025 22:10:07 +0800 Subject: [PATCH 1/2] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group This is to e

[clang] [OpenMP] Fix atomic compare handling with overloaded operators (PR #141142)

2025-05-22 Thread Shilei Tian via cfe-commits
@@ -11762,52 +11762,98 @@ bool OpenMPAtomicCompareChecker::checkCondUpdateStmt(IfStmt *S, X = BO->getLHS(); - auto *Cond = dyn_cast(S->getCond()); - if (!Cond) { -ErrorInfo.Error = ErrorTy::NotABinaryOp; -ErrorInfo.ErrorLoc = ErrorInfo.NoteLoc = S->getCond()->get

[clang] [CIR][NFC] Fix failing OpenACC NYI test (PR #141155)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/16418 Here is the relevant piece of the build lo

[clang-tools-extra] [clang-doc] Precommit test for correct conversion function names (PR #141168)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141168.diff 1 Files Affected: - (added) clang-tools-extra/test/clang-doc/conversion_function.cpp (+18) ``diff diff --git a/cl

[clang-tools-extra] [clang-doc] Precommit test for correct conversion function names (PR #141168)

2025-05-22 Thread Erick Velez via cfe-commits
https://github.com/evelez7 created https://github.com/llvm/llvm-project/pull/141168 None >From 4c7294576a85fee8a373b407b39eeb0b35af4923 Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Thu, 22 May 2025 17:31:37 -0700 Subject: [PATCH] [clang-doc] Precommit test for conversion function names --

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Erick Velez via cfe-commits
https://github.com/evelez7 updated https://github.com/llvm/llvm-project/pull/140856 >From b1a07c3dd19f2aa15abc286fdde0a2cb439dd7b7 Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Thu, 22 May 2025 17:08:59 -0700 Subject: [PATCH] separate test from code change --- clang-tools-extra/clang-doc/S

[clang-tools-extra] 34e63be - [clang-doc] Prevent copying loop variables (NFC)

2025-05-22 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2025-05-23T09:00:19+08:00 New Revision: 34e63be925cc91d13f8c57c42664d9a678328f7c URL: https://github.com/llvm/llvm-project/commit/34e63be925cc91d13f8c57c42664d9a678328f7c DIFF: https://github.com/llvm/llvm-project/commit/34e63be925cc91d13f8c57c42664d9a678328f7c.diff LOG: [

[clang] [clang][Darwin] Add test checking for tls support on xros target triples (PR #141170)

2025-05-22 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/141170 None >From 845121fefce0243426d640989f6fdc7008f0b2ef Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Thu, 22 May 2025 17:58:00 -0700 Subject: [PATCH] [clang][Darwin] Add test checking for tls support on xr

[clang] [clang][Darwin] Add test checking for tls support on xros target triples (PR #141170)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141170.diff 1 Files Affected: - (modified) clang/test/Sema/darwin-tls.c (+2) ``diff diff --git a/clang/test/Sema/darwin-tls.c b/clan

[clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang` running on `ppc64le-flang-rhel-test` while building `clang-tools-extra,clang,lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/2

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

2025-05-22 Thread Feng Zou via cfe-commits
@@ -6679,8 +6679,13 @@ def mapx_features_EQ : CommaJoined<["-"], "mapx-features=">, Group, Values<"egpr,push2pop2,ppx,ndd,ccmp,nf,cf,zu">, Visibility<[ClangOption, CLOption, FlangOption]>; def mno_apx_features_EQ : CommaJoined<["-"], "mno-apx-features=">, Group, HelpTex

[clang] 689342d - [Clang][LoongArch] Add inline asm support for the `q` constraint (#141037)

2025-05-22 Thread via cfe-commits
Author: hev Date: 2025-05-23T11:14:41+08:00 New Revision: 689342de25e65597583805eecd367c4982fd53b8 URL: https://github.com/llvm/llvm-project/commit/689342de25e65597583805eecd367c4982fd53b8 DIFF: https://github.com/llvm/llvm-project/commit/689342de25e65597583805eecd367c4982fd53b8.diff LOG: [Cla

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher closed https://github.com/llvm/llvm-project/pull/141037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix AccessKinds in placement new CheckStore() call (PR #141123)

2025-05-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/141123 >From 007962efa820248c12dc7fc2c84de67cf54e5c00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 22 May 2025 21:01:55 +0200 Subject: [PATCH] [clang][bytecode] Fix AccessKinds in placement

[clang] 3280596 - [clang][bytecode] Diagnose placement-new'ing to a temporary (#141099)

2025-05-22 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-23T08:17:22+02:00 New Revision: 32805964fcc2d5ad6296aae91e18053720e7a8a0 URL: https://github.com/llvm/llvm-project/commit/32805964fcc2d5ad6296aae91e18053720e7a8a0 DIFF: https://github.com/llvm/llvm-project/commit/32805964fcc2d5ad6296aae91e18053720e7a8a0.diff L

[clang] [clang][bytecode] Diagnose placement-new'ing to a temporary (PR #141099)

2025-05-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] FormatTokenLexer.cpp cleanup (PR #141202)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141202.diff 1 Files Affected: - (modified) clang/lib/Format/FormatTokenLexer.cpp (+26-39) ``diff diff --git a/clang/lib/Format/FormatT

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test` while building `clang-tools-extra` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/9814

[clang] [CIR][NFC] Fix failing OpenACC NYI test (PR #141155)

2025-05-22 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/141155 A recent change to the error message produced for unhandled compound statements without scope introduced a failure in an OpenACC test that was checking for the old error message. This change updates the test

[clang] [CIR][NFC] Fix failing OpenACC NYI test (PR #141155)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes A recent change to the error message produced for unhandled compound statements without scope introduced a failure in an OpenACC test that was checking for the old error message. This change updates the te

[clang] [llvm] [HLSL][RootSignature] Add parsing of optional parameters for RootDescriptor (PR #140151)

2025-05-22 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/140151 >From 57d166785f06fcdb8e9c9a1b796ec89a9cc91070 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Thu, 15 May 2025 20:07:51 + Subject: [PATCH 1/3] [HLSL][RootSignature] Add parsing of optional parameters for

[clang] [OpenMP] Fix atomic compare handling with overloaded operators (PR #141142)

2025-05-22 Thread Shilei Tian via cfe-commits
@@ -11762,52 +11762,98 @@ bool OpenMPAtomicCompareChecker::checkCondUpdateStmt(IfStmt *S, X = BO->getLHS(); - auto *Cond = dyn_cast(S->getCond()); - if (!Cond) { -ErrorInfo.Error = ErrorTy::NotABinaryOp; -ErrorInfo.ErrorLoc = ErrorInfo.NoteLoc = S->getCond()->get

<    1   2   3   4   5   >