cassiebeckley wrote:
Done.
https://github.com/llvm/llvm-project/pull/134034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cassiebeckley wrote:
Done.
https://github.com/llvm/llvm-project/pull/134034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Spencer
Date: 2025-05-06T16:40:01-07:00
New Revision: 32fb8c5f5fdeb20de28846e2fe9e2c7525f62086
URL:
https://github.com/llvm/llvm-project/commit/32fb8c5f5fdeb20de28846e2fe9e2c7525f62086
DIFF:
https://github.com/llvm/llvm-project/commit/32fb8c5f5fdeb20de28846e2fe9e2c7525f62086.dif
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/132853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a-tarasyuk wrote:
> So I don't believe this is correct either. We want it to always say the
> namespace. So clang::unknown will diagnose as unknown attribute
> 'clang::unknown' ignored
@erichkeane @AaronBallman Thanks for the feedback. I've made changes to include
the _scope_ in the diagnost
https://github.com/a-tarasyuk deleted
https://github.com/llvm/llvm-project/pull/138519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -338,6 +382,87 @@ static Error runSPIRVCodeGen(StringRef File, const ArgList
&Args,
return Error::success();
}
+/// Run AOT compilation for Intel CPU.
+/// Calls opencl-aot tool to generate device code for Intel CPU backend.
jzc wrote:
Changed to `Calls
@@ -3332,6 +3388,39 @@ checkBuiltinTemplateIdType(Sema &SemaRef,
BuiltinTemplateDecl *BTD,
}
return HasNoTypeMember;
}
+
+ case BTK__hlsl_spirv_type: {
+assert(Converted.size() == 4);
+
+if (!Context.getTargetInfo().getTriple().isSPIRV()) {
+ SemaRef.Di
https://github.com/shiltian approved this pull request.
https://github.com/llvm/llvm-project/pull/138774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
ping @AaronBallman @efriedma-quic if you don't have more concerns here, I'd
like to move forward with this patch
https://github.com/llvm/llvm-project/pull/137163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/138323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/138752
In C++, the type of an enumerator is the type of the enumeration, whereas in C,
the type of the enumerator is 'int'. The type of a comma operator is the type
of the right-hand operand, which means you can
AaronBallman wrote:
> @AaronBallman If you try to compile the following c program after this patch
>
> ```
> void free ();
> typedef enum {REG_EESCAPE} reg_errcode_t;
> typedef struct {int *stack;} compile_stack_type;
> reg_errcode_t byte_regex_compile () {
> compile_stack_type compile_stack;
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
In C++, the type of an enumerator is the type of the enumeration, whereas in C,
the type of the enumerator is 'int'. The type of a comma operator is the type
of the right-hand operand, which means you
Author: Erich Keane
Date: 2025-05-06T13:11:49-07:00
New Revision: bb09f79f0f2b8e0cc3ed01d19ae49afbda8f82d2
URL:
https://github.com/llvm/llvm-project/commit/bb09f79f0f2b8e0cc3ed01d19ae49afbda8f82d2
DIFF:
https://github.com/llvm/llvm-project/commit/bb09f79f0f2b8e0cc3ed01d19ae49afbda8f82d2.diff
L
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/138576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rampitec ready_for_review
https://github.com/llvm/llvm-project/pull/138753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rampitec wrote:
* **#138753** https://app.graphite.dev/github/pr/llvm/llvm-project/138753?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/138
https://github.com/fmayer requested changes to this pull request.
Seems like the fsanitize test is failing now
https://github.com/llvm/llvm-project/pull/138577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/138743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rampitec wrote:
Closing in favor of downstream change.
https://github.com/llvm/llvm-project/pull/138745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rampitec closed
https://github.com/llvm/llvm-project/pull/138745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Stanislav Mekhanoshin (rampitec)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/138753.diff
1 Files Affected:
- (modified) clang/test/CodeGenOpenCL/builtins-amdgcn-gfx950.cl (+1-3)
``diff
diff --git a/clang
https://github.com/rampitec created
https://github.com/llvm/llvm-project/pull/138753
None
>From 7aad45e6bb65f6378abb4f76052dab283a9b3f93 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Tue, 6 May 2025 13:10:15 -0700
Subject: [PATCH] [AMDGPU] Remove unused argument in builtins-amdgcn
@@ -5,6 +5,7 @@
// RUN: %clang_cc1 -std=c++17 -verify %s
// RUN: %clang_cc1 -std=c++17 -verify %s -fno-char8_t
// RUN: %clang_cc1 -std=c++20 -verify %s -fno-char8_t
+// RUN: %clang_cc1 -x c -verify %s -fchar8_t
AaronBallman wrote:
Shouldn't this generate a dia
@@ -4529,6 +4529,191 @@ void CodeGenFunction::EmitOMPMasterDirective(const
OMPMasterDirective &S) {
emitMaster(*this, S);
}
+static Expr *replaceWithNewTraitsOrDirectCall(CapturedDecl *CDecl,
+ Expr *NewExpr) {
+ Expr *CurrentCa
@@ -624,6 +624,13 @@ class TagTableInfo
ReleaseOpLength - 1);
Data += ReleaseOpLength - 1;
}
+unsigned DefaultOwnershipLength =
+endian::readNext(Data);
+if (DefaultOwnershipLength > 0) {
fahadna
andykaylor wrote:
@el-ev Can you rebase this now that the call args change has landed? Thanks!
https://github.com/llvm/llvm-project/pull/136854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
mcbarton wrote:
@bellenot ping
https://github.com/llvm/llvm-project/pull/127468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/138716
>From cb8c80432affae6182e995a546c941b3b6afb8b0 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Tue, 6 May 2025 18:18:06 +0200
Subject: [PATCH 1/2] [Clang] Ignore -fchar8_t in C
In C, char8_t is an alias to
Andres-Salamanca wrote:
> @bcardosolopes Adding a test for C++ -> CIR depends on #138003 which adds
> lowering for `?:`, `&&` and `||`. Since this one's ready to be merged apart
> from your remark IMO I'd add that test in #138003
I think you're referring to this PR:
https://github.com/llvm/ll
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/138774.diff
2 Files Affected:
- (modified) clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp
(+3-4)
- (modified) clang-tools-ex
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/138774
None
>From a524a8098d5a513259d0d82b262d4b5a769d4d1f Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Tue, 6 May 2025 15:20:38 -0700
Subject: [PATCH] [clang-tools-extra] Remove redundant calls to
std::un
https://github.com/kikairoya edited
https://github.com/llvm/llvm-project/pull/138773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jansvoboda11 wrote:
Test change LGTM, I was probably trying to get to a minimal test-case and ended
up with something that was relying on implementation details.
https://github.com/llvm/llvm-project/pull/132853
___
cfe-commits mailing list
cfe-commits
@@ -486,6 +486,39 @@ ABIArgInfo AArch64ABIInfo::classifyArgumentType(QualType
Ty, bool IsVariadicFn,
}
Size = llvm::alignTo(Size, Alignment);
+// If the Aggregate is made up of pointers, use an array of pointers for
the
+// coerced type. This prevents having
@@ -486,6 +486,39 @@ ABIArgInfo AArch64ABIInfo::classifyArgumentType(QualType
Ty, bool IsVariadicFn,
}
Size = llvm::alignTo(Size, Alignment);
+// If the Aggregate is made up of pointers, use an array of pointers for
the
+// coerced type. This prevents having
@@ -486,6 +486,39 @@ ABIArgInfo AArch64ABIInfo::classifyArgumentType(QualType
Ty, bool IsVariadicFn,
}
Size = llvm::alignTo(Size, Alignment);
+// If the Aggregate is made up of pointers, use an array of pointers for
the
+// coerced type. This prevents having
https://github.com/PiJoules updated
https://github.com/llvm/llvm-project/pull/135836
>From fc0a5f17e670818c08ceefc68887902dc7bc7984 Mon Sep 17 00:00:00 2001
From: Leonard Chan
Date: Wed, 9 Apr 2025 14:21:00 -0700
Subject: [PATCH] [clang] Function type attribute to prevent CFI
instrumentation
https://github.com/jeremyd2019 updated
https://github.com/llvm/llvm-project/pull/135691
>From 949ec2a683faf53652b21a4c90206befa498bf4e Mon Sep 17 00:00:00 2001
From: Jeremy Drake
Date: Mon, 14 Apr 2025 10:37:59 -0700
Subject: [PATCH 1/3] [Clang] [Driver] add a Cygwin ToolChain
Add a new Cygwin
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar approved this pull request.
https://github.com/llvm/llvm-project/pull/138174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jeremyd2019 edited
https://github.com/llvm/llvm-project/pull/135691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmarker wrote:
It seems like `BinPackParameters` is currently applying to both regular
parameters and also template parameters.
I think it would be inconsistent if it stopped applying to template parameters
only when set to `AlwaysOnePerLine`.
What about separating it out into `BinPackTemplate
@@ -2632,6 +2632,27 @@ void
Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes(
return;
}
+ if (TargetTriple.isWindowsCygwinEnvironment()) {
+static const char *const CygwinX86Triples[] = {"i686-pc-cygwin",
+
https://github.com/jeremyd2019 updated
https://github.com/llvm/llvm-project/pull/135691
>From 949ec2a683faf53652b21a4c90206befa498bf4e Mon Sep 17 00:00:00 2001
From: Jeremy Drake
Date: Mon, 14 Apr 2025 10:37:59 -0700
Subject: [PATCH 1/4] [Clang] [Driver] add a Cygwin ToolChain
Add a new Cygwin
@@ -598,7 +598,7 @@ struct S1 {
};
void foo1() {
- auto s0 = S1([name=]() {}); // expected-error {{expected expression}}
+ auto s0 = S1([]() {}); // Remove invalid capture, no diagnostic expected
cor3ntin wrote:
@charan-003
https://github.com/llvm/llvm-pr
@@ -1255,22 +1255,24 @@ static void tryConsumeLambdaSpecifierToken(Parser &P,
DeclEndLoc = SpecifierLoc;
};
- while (true) {
+ // Process lambda specifiers until an invalid token is found
+ while (P.getCurToken().isOneOf(tok::kw_mutable, tok::kw_static,
+
@@ -6,89 +6,121 @@ void test() {
int i = 0;
int j = 0;
int k = 0;
- int c = 10;
- int a[c];
+ constexpr int c = 10;
+ int a[c]; // Make 'c' constexpr to avoid variable-length array warnings.
- [i,j] { return i; };
+ [i] { return i; };
// CHECK: [i] { return i;
https://github.com/andykaylor approved this pull request.
Looks good to me!
https://github.com/llvm/llvm-project/pull/138003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Thank you for the explanation, that makes sense
https://github.com/llvm/llvm-project/pull/138716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/138640
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial
https://github.com/andykaylor approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/138317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/138482
>From ecea44f2965cda3a4e6e1ccec096066830ddfa41 Mon Sep 17 00:00:00 2001
From: Oliver Hunt
Date: Sun, 4 May 2025 21:07:33 -0700
Subject: [PATCH] [clang][ptrauth] Add support for querying the ptrauth schema
of a t
https://github.com/aaronpuchert updated
https://github.com/llvm/llvm-project/pull/135390
>From d8bc5ebd7976d25e800987b3c95057364dc1c07c Mon Sep 17 00:00:00 2001
From: Aaron Puchert
Date: Fri, 11 Apr 2025 13:47:02 +0200
Subject: [PATCH] Suppress errors from well-formed-testing type traits in
SF
@@ -12464,7 +12487,7 @@ static void AnalyzeImplicitConversions(
<< OrigE->getSourceRange() << T->isBooleanType()
<< FixItHint::CreateReplacement(UO->getBeginLoc(), "!");
- if (const auto *BO = dyn_cast(SourceExpr))
+ if (auto *BO = dyn_cast(SourceExpr))
-
@@ -11647,6 +11647,29 @@ static void DiagnoseFloatingImpCast(Sema &S, Expr *E,
QualType T,
}
}
+static void CheckCommaOperand(Sema &S, Expr *E, QualType T, SourceLocation CC,
+ bool Check) {
+ E = E->IgnoreParenImpCasts();
+ AnalyzeImplicitCon
@@ -11647,6 +11647,29 @@ static void DiagnoseFloatingImpCast(Sema &S, Expr *E,
QualType T,
}
}
+static void CheckCommaOperand(Sema &S, Expr *E, QualType T, SourceLocation CC,
+ bool Check) {
+ E = E->IgnoreParenImpCasts();
+ AnalyzeImplicitCon
@@ -11647,6 +11647,29 @@ static void DiagnoseFloatingImpCast(Sema &S, Expr *E,
QualType T,
}
}
+static void CheckCommaOperand(Sema &S, Expr *E, QualType T, SourceLocation CC,
+ bool Check) {
+ E = E->IgnoreParenImpCasts();
+ AnalyzeImplicitCon
@@ -11647,6 +11647,29 @@ static void DiagnoseFloatingImpCast(Sema &S, Expr *E,
QualType T,
}
}
+static void CheckCommaOperand(Sema &S, Expr *E, QualType T, SourceLocation CC,
+ bool Check) {
erichkeane wrote:
`Check` is pretty
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/138519
>From cbbca4d26b8d00eb103f110c2341fab2e4a2e40d Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Mon, 5 May 2025 15:30:14 +0300
Subject: [PATCH] [Clang] diagnose unknown attribute namespaces
---
clang
aaronpuchert wrote:
Could also add this under "Bug Fixes to C++ Support". The entries about type
traits [don't seem to be consistently
categorized](https://releases.llvm.org/19.1.0/tools/clang/docs/ReleaseNotes.html#bug-fixes-in-this-version),
but I think this is all C++-only.
https://github.
thurstond wrote:
> Thanks for making changes. I have some very minor suggestions but I'll
> approve now and you can decide if it's worth making my suggested changes.
Thanks, I like your wording improvements! I've modified the HelpText and
comment.
https://github.com/llvm/llvm-project/pull/138
@@ -440,9 +570,15 @@ int main(int argc, char **argv) {
DryRun = Args.hasArg(OPT_dry_run);
SaveTemps = Args.hasArg(OPT_save_temps);
- OutputFile = "a.out";
- if (Args.hasArg(OPT_o))
-OutputFile = Args.getLastArgValue(OPT_o);
+ IsAOTCompileNeeded = IsIntelOffloadArch(
https://github.com/jzc edited https://github.com/llvm/llvm-project/pull/133194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thurstond updated
https://github.com/llvm/llvm-project/pull/138577
>From 1cb28ef0b3313c3fd60667cc7928f0fed8d1838a Mon Sep 17 00:00:00 2001
From: Thurston Dang
Date: Mon, 5 May 2025 20:11:09 +
Subject: [PATCH 1/9] [sanitizer] Add plumbing for
-fsanitize-add-pseudo-functio
jeremyd2019 wrote:
split from #138587 - requesting review from @petrhosek
https://github.com/llvm/llvm-project/pull/138783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jeremyd2019)
Changes
The previous approach of using list(REMOVE ...) would remove *all* occurences
of the given item, not just the one appended above.
---
Full diff: https://github.com/llvm/llvm-project/pull/138783.diff
1 Files Af
jeremyd2019 wrote:
Also, should all of those projects be updated in one pull request, or do I need
to open a half-dozen more?
https://github.com/llvm/llvm-project/pull/138587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
301 - 370 of 370 matches
Mail list logo