llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clangd Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/138774.diff 2 Files Affected: - (modified) clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp (+3-4) - (modified) clang-tools-extra/clangd/unittests/PrerequisiteModulesTest.cpp (+2-2) ``````````diff diff --git a/clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp b/clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp index 850df7daf5c03..3e367ab1a5558 100644 --- a/clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp +++ b/clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp @@ -113,7 +113,7 @@ static SourceLocation getStartOfNextLine(SourceLocation Loc, const SourceManager &SM, const LangOptions &LangOpts) { std::unique_ptr<Lexer> Lex = getLexerStartingFromLoc(Loc, SM, LangOpts); - if (!Lex.get()) + if (!Lex) return SourceLocation(); llvm::SmallVector<char, 16> Line; // FIXME: this is a bit hacky to get ReadToEndOfLine work. @@ -647,9 +647,8 @@ static SourceLocation getLocAfterNamespaceLBrace(const NamespaceDecl *NsDecl, const LangOptions &LangOpts) { std::unique_ptr<Lexer> Lex = getLexerStartingFromLoc(NsDecl->getBeginLoc(), SM, LangOpts); - assert(Lex.get() && - "Failed to create lexer from the beginning of namespace."); - if (!Lex.get()) + assert(Lex && "Failed to create lexer from the beginning of namespace."); + if (!Lex) return SourceLocation(); Token Tok; while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) { diff --git a/clang-tools-extra/clangd/unittests/PrerequisiteModulesTest.cpp b/clang-tools-extra/clangd/unittests/PrerequisiteModulesTest.cpp index 27f4c817a8ff3..03e65768c26a6 100644 --- a/clang-tools-extra/clangd/unittests/PrerequisiteModulesTest.cpp +++ b/clang-tools-extra/clangd/unittests/PrerequisiteModulesTest.cpp @@ -545,8 +545,8 @@ void func() { EXPECT_TRUE(Preamble); EXPECT_TRUE(Preamble->RequiredModules); - auto Result = signatureHelp(getFullPath("Use.cpp"), Test.point(), - *Preamble.get(), Use, MarkupKind::PlainText); + auto Result = signatureHelp(getFullPath("Use.cpp"), Test.point(), *Preamble, + Use, MarkupKind::PlainText); EXPECT_FALSE(Result.signatures.empty()); EXPECT_EQ(Result.signatures[0].label, "printA(int a) -> void"); EXPECT_EQ(Result.signatures[0].parameters[0].labelString, "int a"); `````````` </details> https://github.com/llvm/llvm-project/pull/138774 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
