[clang] [clang][ptrauth] reject incorrectly placed ptrauth qualifier (PR #138376)

2025-05-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/138376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ptrauth] reject incorrectly placed ptrauth qualifier (PR #138376)

2025-05-03 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/138376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1c68e0e - [clang][ptrauth] reject incorrectly placed ptrauth qualifier (#138376)

2025-05-03 Thread via cfe-commits
Author: Oliver Hunt Date: 2025-05-03T01:18:20-07:00 New Revision: 1c68e0e4814e7e0f006a238e1c656c78aa10516b URL: https://github.com/llvm/llvm-project/commit/1c68e0e4814e7e0f006a238e1c656c78aa10516b DIFF: https://github.com/llvm/llvm-project/commit/1c68e0e4814e7e0f006a238e1c656c78aa10516b.diff L

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread via cfe-commits
https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/138388 Fix #138185 >From fae4db4ec0f6ff6fe4eb8986bf707f8c33302fde Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Sat, 3 May 2025 10:10:09 +0200 Subject: [PATCH] [clang] Document -fstrict-flex-arrays

[clang] [clang-format] Correctly annotate tok::star in braced list (PR #138389)

2025-05-03 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/138389 Fix #138382 >From 36e7e2002439dcdb084e949a265a280551597800 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 3 May 2025 01:21:03 -0700 Subject: [PATCH] [clang-format] Correctly annotate tok::star in braced list

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (serge-sans-paille) Changes Fix #138185 --- Full diff: https://github.com/llvm/llvm-project/pull/138388.diff 1 Files Affected: - (modified) clang/include/clang/Driver/Options.td (+4-1) ``diff diff --git a/clang/include/c

[clang] [clang-format] Correctly annotate tok::star in braced list (PR #138389)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #138382 --- Full diff: https://github.com/llvm/llvm-project/pull/138389.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+8-4) - (modified) clang/unittests/Format/TokenAnnota

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread via cfe-commits
serge-sans-paille wrote: @zygoloid this restores (and hopefully improves) the original documentation. The values and behavior are obviously the same as gcc. I don't have a strong opinion on value aliases. https://github.com/llvm/llvm-project/pull/138388

[clang] 5b02a26 - [Clang][NFC] Fix typos introduced in #138307

2025-05-03 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2025-05-03T11:36:42+02:00 New Revision: 5b02a2647594719454611132b7c05318d959bf58 URL: https://github.com/llvm/llvm-project/commit/5b02a2647594719454611132b7c05318d959bf58 DIFF: https://github.com/llvm/llvm-project/commit/5b02a2647594719454611132b7c05318d959bf58.diff

[clang] [Clang] Never consider conversion from single-element braced-init-list perfect (PR #138307)

2025-05-03 Thread via cfe-commits
@@ -412,6 +419,12 @@ class Sema; bool isPerfect(const ASTContext &C) const { if (!isIdentityConversion()) return false; + + // We might prefer a std::initializer constructor, cor3ntin wrote: Oups https://github.com/llvm/llvm-project/pul

[clang] [Clang] Fix handling of reference types in tryEvaluateBuiltinObjectSize (PR #138247)

2025-05-03 Thread via cfe-commits
zhscn wrote: Could this PR be backported to the release/20.x branch which also has the same issue? https://github.com/llvm/llvm-project/pull/138247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-03 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/138360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-03 Thread Phoebe Wang via cfe-commits
@@ -138,6 +138,12 @@ let Attributes = [Const, NoThrow, RequiredVectorWidth<256>], Features = "avx" in } } +// PRFCHW +let Features = "prfchw", Header = "intrin.h", Attributes = [NoThrow, Const] in { phoebewang wrote: Although they are in the same file, bo

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-03 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > also seeing "PluginInterface" error: Failure to look up global address: Error > in hsa_executable_get_symbol_by_name(grid_points): > HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name. > omptarget error: Failed to load symbol grid_points Yeah, this i

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-03 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang commented: The pre-checkin failures seem related. https://github.com/llvm/llvm-project/pull/138360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-03 Thread Joseph Huber via cfe-commits
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + // Enable internalization for AMDGPU. + if (TC->getTrip

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
@@ -365,10 +365,15 @@ mlir::Attribute ConstantEmitter::tryEmitPrivateForVarInit(const VarDecl &d) { if (!d.hasLocalStorage()) { QualType ty = cgm.getASTContext().getBaseElementType(d.getType()); if (ty->isRecordType()) - if (d.getInit() && isa(d.getInit())) { -

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
@@ -12,6 +12,17 @@ IncompleteS *p; // LLVM: @p = dso_local global ptr null // OGCG: @p = global ptr null, align 8 +struct CompleteS { mmha wrote: Do simple union work with this? If so, can you add a test for those, too? https://github.com/llvm/llvm-project/p

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
@@ -237,8 +237,11 @@ mlir::Type CIRGenTypes::convertRecordDeclType(const clang::RecordDecl *rd) { assert(insertResult && "isSafeToCovert() should have caught this."); // Force conversion of non-virtual base classes recursively. - if (isa(rd)) { -cgm.errorNYI(rd->getS

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
@@ -177,18 +177,26 @@ void CIRRecordLowering::lower() { return; } - if (isa(recordDecl)) { -cirGenTypes.getCGModule().errorNYI(recordDecl->getSourceRange(), - "lower: class"); -return; - } - assert(!cir::MissingFeatures:

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
@@ -365,10 +365,15 @@ mlir::Attribute ConstantEmitter::tryEmitPrivateForVarInit(const VarDecl &d) { if (!d.hasLocalStorage()) { QualType ty = cgm.getASTContext().getBaseElementType(d.getType()); if (ty->isRecordType()) - if (d.getInit() && isa(d.getInit())) { -

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
https://github.com/mmha edited https://github.com/llvm/llvm-project/pull/138368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
https://github.com/mmha approved this pull request. LGTM, just a few nits https://github.com/llvm/llvm-project/pull/138368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-03 Thread Morris Hafner via cfe-commits
https://github.com/mmha edited https://github.com/llvm/llvm-project/pull/138368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread via cfe-commits
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">, Group, NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "IncompleteOnly"]>, - HelpText<"Enabl

[clang] [Clang][Cygwin] attempt to fix building shared libclang. (PR #138351)

2025-05-03 Thread via cfe-commits
jeremyd2019 wrote: But people build mingw clang with gcc, right? They presumably don't set `LLVM_ENABLE_PIC=OFF`. It seems like having explicit dllexport annotations as libclang does should turn off auto-export. I didn't see `--export-all-symbols` in the command line anyway. https://github

[clang] [Clang][Cygwin] attempt to fix building shared libclang. (PR #138351)

2025-05-03 Thread Mateusz Mikuła via cfe-commits
mati865 wrote: > But people build mingw clang with gcc, right? Dunno. > It seems like having explicit dllexport annotations as libclang does should > turn off auto-export. I didn't see `--export-all-symbols` in the command line > anyway. Yes, linker exports all the symbols by default, but ex

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138413 >From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 3 May 2025 13:43:04 +0200 Subject: [PATCH 1/2] [CIR] Upstream extract op for VectorType --- clang/incl

[clang] 8d8a3d9 - [CIR][NFC] Fix an unused variable warning (#138415)

2025-05-03 Thread via cfe-commits
Author: Amr Hesham Date: 2025-05-03T22:00:15+02:00 New Revision: 8d8a3d9fdcbe823b94e2821b7beb8ead5288b14e URL: https://github.com/llvm/llvm-project/commit/8d8a3d9fdcbe823b94e2821b7beb8ead5288b14e DIFF: https://github.com/llvm/llvm-project/commit/8d8a3d9fdcbe823b94e2821b7beb8ead5288b14e.diff LO

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/138415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

2025-05-03 Thread Oliver Hunt via cfe-commits
ojhunt wrote: @AaronBallman have you made a decision? (if the keyword has to go away I need to replace all the tests and work out how to integrate with other libraries downstream in a way that works in both modes) https://github.com/llvm/llvm-project/pull/137580 ___

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138413 >From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 3 May 2025 13:43:04 +0200 Subject: [PATCH 1/2] [CIR] Upstream extract op for VectorType --- clang/incl

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/17189 Her

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/29] Update SemaL

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/32] Update SemaL

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/33] Update SemaL

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/31] Update SemaL

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/30] Update SemaL

[clang] [Clang][Cygwin] attempt to fix building shared libclang. (PR #138351)

2025-05-03 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Offhand, I don't quite know here. Which configurations is this about? For mingw, the only cases I'm familiar with is building with `LLVM_LINK_LLVM_DYLIB=ON`, which iirc implicitly enables a corresponding one for Clang too. Not sure which of the local variables here that maps to

[clang-tools-extra] Add check 'modernize-use-enum-class' (PR #138282)

2025-05-03 Thread via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - modernize-use-enum-class + +modernize-use-enum-class += + +Scoped enums (enum class) should be preferred over unscoped enums: +https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-class ---

[clang-tools-extra] Add check 'modernize-use-enum-class' (PR #138282)

2025-05-03 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - modernize-use-enum-class + +modernize-use-enum-class += + +Scoped enums (enum class) should be preferred over unscoped enums: +https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-class ---

[clang-tools-extra] Add check 'modernize-use-enum-class' (PR #138282)

2025-05-03 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/138282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add check 'modernize-use-enum-class' (PR #138282)

2025-05-03 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/138282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-03 Thread Shilei Tian via cfe-commits
shiltian wrote: I don't think OpenMP is more special than HIP here. Anything exposed to the host should not be internalized. In addition, OpenMP actually also heavily uses internalization as well in OpenMPOpt. It is likely that this change exposes something bad in the downstream. The motivati

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-03 Thread Shilei Tian via cfe-commits
shiltian wrote: > also seeing > > "PluginInterface" error: Failure to look up global address: Error in > hsa_executable_get_symbol_by_name(grid_points): > HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name. > > omptarget error: Failed to load symbol grid_points > >

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-03 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I don't think OpenMP is more special than HIP here. Anything exposed to the > host should not be internalized. In addition, OpenMP actually also heavily > uses internalization as well in OpenMPOpt. It is likely that this change > exposes something bad in the downstream. > > T

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-03 Thread Shilei Tian via cfe-commits
shiltian wrote: I got it that you are trying to make it generic. That's why I didn’t roll back to using builtin bitcode as we did before. However there is one limitation that we can't really work around, which is the fact that we don't support ABI linking. This is not a new topic at all and wh

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Henrich Lauko via cfe-commits
@@ -1976,4 +1976,28 @@ def VecCreateOp : CIR_Op<"vec.create", [Pure]> { let hasVerifier = 1; } +//===--===// +// VecExtractOp +//===--===//

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm, besides nits https://github.com/llvm/llvm-project/pull/138413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/138413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/138413 This change adds local zero initialization for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 >From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001 From: AmrDeveloper

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds local zero initialization for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 --- Full diff: https://github.com/llvm/llvm-project/pull/138413.diff 7 Files Affected

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/138413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/138388 >From 39cf81caaab7257414d72fae3afbb3baa8113b7f Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Sat, 3 May 2025 10:10:09 +0200 Subject: [PATCH] [clang] Document -fstrict-flex-arrays option Fix #

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread via cfe-commits
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">, Group, NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "IncompleteOnly"]>, - HelpText<"Enabl

[clang] CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/138415 This fixes a warning where a variable assigned in 'if' statement wasn't referenced again. >From 6acc708aabc3f53d2899b322d4d96194bfc9440d Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 3 May 2025 1

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This fixes a warning where a variable assigned in 'if' statement wasn't referenced again. --- Full diff: https://github.com/llvm/llvm-project/pull/138415.diff 1 Files Affected: - (modified) clang/lib/C

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138415 >From 1b43e41c4ad14215977e9f2f0a4f1c2ed3895be1 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 3 May 2025 19:05:36 +0200 Subject: [PATCH] [CIR][NFC] Fix an unused variable warning --- clang/lib/CIR

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This fixes a warning where a variable assigned in 'if' statement wasn't referenced again. --- Full diff: https://github.com/llvm/llvm-project/pull/138415.diff 1 Files Affected: - (modified) clang/lib

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/138415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-03 Thread via cfe-commits
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR +if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC)) ---

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-03 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-03 Thread via cfe-commits
https://github.com/jeremyd2019 approved this pull request. https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-03 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/138003 >From ff564e64a2ca9948e51c174a5e7a71b05acea510 Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Wed, 30 Apr 2025 12:17:31 -0500 Subject: [PATCH 1/5] add support for anyOf, default, and range case k

[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

2025-05-03 Thread Oliver Hunt via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: ojhunt wrote: The pointer auth options PR would also benefit from this - it currently has an ad hoc and restricted version of this as it needed to support

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-05-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux-multistage` running on `systemz-1` while building `llvm` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/98/builds/1349 Here is the relevant piece of the

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Henrich Lauko via cfe-commits
@@ -1976,4 +1976,28 @@ def VecCreateOp : CIR_Op<"vec.create", [Pure]> { let hasVerifier = 1; } +//===--===// +// VecExtractOp +//===--===//

[clang] [clang-format] Correctly annotate tok::star in braced list (PR #138389)

2025-05-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin` running on `doug-worker-3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/9970 Here is the r

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/35] Update SemaL

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-05-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/120925 >From c1aa5c649c052c230cc76d073186ad8fdd14723f Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 4 May 2025 02:13:29 +0300 Subject: [PATCH] [Clang] raise extension warning for unknown namespaced a

[clang] [clang-format] Correctly annotate tok::star in braced list (PR #138389)

2025-05-03 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/138389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Parse/ParseExprCXX.cpp clang/lib/Sema/SemaL

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread Richard Smith via cfe-commits
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">, Group, NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "IncompleteOnly"]>, - HelpText<"Enabl

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread Richard Smith via cfe-commits
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">, Group, NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "IncompleteOnly"]>, - HelpText<"Enabl

[clang] [Clang][Cygwin] attempt to fix building shared libclang. (PR #138351)

2025-05-03 Thread Mateusz Mikuła via cfe-commits
mati865 wrote: I think it works when you build with Clang rather than GCC. Clang will not export symbols with hidden visibility. https://github.com/llvm/llvm-project/pull/138351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/138415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/138415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] attempt to fix building shared libclang. (PR #138351)

2025-05-03 Thread via cfe-commits
jeremyd2019 wrote: `-DLLVM_BUILD_LLVM_DYLIB=OFF -DLLVM_LINK_LLVM_DYLIB=OFF -DLIBCLANG_BUILD_STATIC=ON` Now we know that adding `-DLLVM_ENABLE_PIC=OFF` will turn off building libclang.dll, but otherwise it will be built regardless. https://github.com/llvm/llvm-project/pull/138351 _

[clang] 74d921c - [Clang][Cygwin] don't use -Bsymbolic-functions (#138217)

2025-05-03 Thread via cfe-commits
Author: jeremyd2019 Date: 2025-05-04T00:33:54+03:00 New Revision: 74d921c01ab4aefb5f7f14062ab4aef50d5c6413 URL: https://github.com/llvm/llvm-project/commit/74d921c01ab4aefb5f7f14062ab4aef50d5c6413 DIFF: https://github.com/llvm/llvm-project/commit/74d921c01ab4aefb5f7f14062ab4aef50d5c6413.diff L

[clang] [Clang][Cygwin] don't use -Bsymbolic-functions (PR #138217)

2025-05-03 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/138217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-03 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate tok::star in braced list (PR #138389)

2025-05-03 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/138389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FixIt] Improve Source Ranges and Fix-It Hints for Unused Lambda Captures #106445 (PR #117953)

2025-05-03 Thread via cfe-commits
https://github.com/charan-003 updated https://github.com/llvm/llvm-project/pull/117953 >From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001 From: charan-003 <85248228+charan-...@users.noreply.github.com> Date: Wed, 27 Nov 2024 18:43:38 -0700 Subject: [PATCH 01/34] Update SemaL

[clang] deec7fb - [clang-format] Correctly annotate tok::star in braced list (#138389)

2025-05-03 Thread via cfe-commits
Author: Owen Pan Date: 2025-05-03T14:54:48-07:00 New Revision: deec7fb42dd27d38b2d2925f5e635f27007a0bd7 URL: https://github.com/llvm/llvm-project/commit/deec7fb42dd27d38b2d2925f5e635f27007a0bd7 DIFF: https://github.com/llvm/llvm-project/commit/deec7fb42dd27d38b2d2925f5e635f27007a0bd7.diff LOG:

[clang] [Clang] Minimal support for availability attributes on partial specializations (PR #138426)

2025-05-03 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/138426 There are some limitations. Because we only know which partial specialization to refer to when instantiating, and because we can't instantiate the class before we require a complete type, we can only use the

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-05-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/120925 >From 9bb85586f40f659a8bff414511bed9592083efbd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 4 May 2025 01:13:20 +0300 Subject: [PATCH] [Clang] raise extension warning for unknown namespaced a

[clang] [Clang] Minimal support for availability attributes on partial specializations (PR #138426)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes There are some limitations. Because we only know which partial specialization to refer to when instantiating, and because we can't instantiate the class before we require a complete type, we can only use the p

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-05-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/120925 >From 9bb85586f40f659a8bff414511bed9592083efbd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 4 May 2025 01:13:20 +0300 Subject: [PATCH 1/2] [Clang] raise extension warning for unknown namespace

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-05-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/120925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][Haiku] Fix signal frame unwinding (PR #135367)

2025-05-03 Thread Brad Smith via cfe-commits
brad0 wrote: cc @MaskRay https://github.com/llvm/llvm-project/pull/135367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Use AddRunTimeLibs on Solaris (PR #137596)

2025-05-03 Thread Brad Smith via cfe-commits
https://github.com/brad0 approved this pull request. https://github.com/llvm/llvm-project/pull/137596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't annotate enum colon as InheritanceColon (PR #138440)

2025-05-03 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/138440 Fix #61156 >From 90803c382ecb040e016034d5798d739739ece03a Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 3 May 2025 23:38:18 -0700 Subject: [PATCH] [clang-format] Don't annotate enum colon as InheritanceColo

[clang] [clang-format] Don't annotate enum colon as InheritanceColon (PR #138440)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #61156 --- Full diff: https://github.com/llvm/llvm-project/pull/138440.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+1-1) - (modified) clang/unittests/Format/TokenAnnotat

[clang] [Clang][LoongArch] Match GCC behaviour when parsing FPRs in asm clobbers (PR #138391)

2025-05-03 Thread WÁNG Xuěruì via cfe-commits
https://github.com/xen0n commented: Thank you for the patch! Test assertions can be updated as well -- check for two occurrences of the respective `asm` statement. https://github.com/llvm/llvm-project/pull/138391 ___ cfe-commits mailing list cfe-comm

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-03 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/138429 Update how Sema Checking is done for HLSL builtins to allow for better error messages, mainly using 'err_builtin_invalid_arg_type'. Try to follow the formula outlined in issue #134721 Closes #134721 >From 113910

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Sarah Spall (spall) Changes Update how Sema Checking is done for HLSL builtins to allow for better error messages, mainly using 'err_builtin_invalid_arg_type'. Try to follow the formula outlined in issue #134721 Closes #134721 --- Patch

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sarah Spall (spall) Changes Update how Sema Checking is done for HLSL builtins to allow for better error messages, mainly using 'err_builtin_invalid_arg_type'. Try to follow the formula outlined in issue #134721 Closes #134721 --- Patch

[clang] [clang] Document -fstrict-flex-arrays option (PR #138388)

2025-05-03 Thread Richard Smith via cfe-commits
https://github.com/zygoloid approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/138388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-05-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,35 @@ +// Regression test for https://github.com/llvm/llvm-project/issues/59819 + +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD-MYC

[clang] [Clang] Don't retain template FoundDecl for conversion function calls (PR #138377)

2025-05-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/138377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >