[clang] 92195f6 - Reapply "[DLCov] Implement DebugLoc coverage tracking (#107279)"

2025-04-30 Thread Stephen Tozer via cfe-commits
Author: Stephen Tozer Date: 2025-04-30T11:39:29+01:00 New Revision: 92195f6fc873cd27a5aa0852252dfe44ccdc6ea0 URL: https://github.com/llvm/llvm-project/commit/92195f6fc873cd27a5aa0852252dfe44ccdc6ea0 DIFF: https://github.com/llvm/llvm-project/commit/92195f6fc873cd27a5aa0852252dfe44ccdc6ea0.diff

[libclc] [libclc] Add v3 variants of async_work_group_copy/async_work_group_strided_copy/prefetch (PR #137932)

2025-04-30 Thread Wenju He via cfe-commits
@@ -9,15 +9,31 @@ #define __CLC_DST_ADDR_SPACE local #define __CLC_SRC_ADDR_SPACE global #define __CLC_BODY -#include +#include +#undef __CLC_DST_ADDR_SPACE wenju-he wrote: done, thanks for the suggestion https://github.com/llvm/llvm-project/pull/137932 __

[libclc] [libclc] Add v3 variants of async_work_group_copy/async_work_group_strided_copy/prefetch (PR #137932)

2025-04-30 Thread Wenju He via cfe-commits
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/137932 >From cafb374de8d77c82fa450b732a122663090f6e34 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Wed, 30 Apr 2025 00:44:50 -0700 Subject: [PATCH 1/3] [libclc] Add v3 variants of async_work_group_copy/async_work_gr

[libclc] [libclc] Add v3 variants of async_work_group_copy/async_work_group_strided_copy/prefetch (PR #137932)

2025-04-30 Thread Wenju He via cfe-commits
wenju-he wrote: > We could probably come up with some kind of combined `gentype.inc` that does > them both at once good idea. https://github.com/llvm/llvm-project/pull/137932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[libclc] [libclc] Add v3 variants of async_work_group_copy/async_work_group_strided_copy/prefetch (PR #137932)

2025-04-30 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/137932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] 5b6fc61 - [libclc] Add v3 variants of async_work_group_copy/async_work_group_strided_copy/prefetch (#137932)

2025-04-30 Thread via cfe-commits
Author: Wenju He Date: 2025-04-30T13:19:08+01:00 New Revision: 5b6fc610919cc2e88fe3d9bfcc23637c75a636c9 URL: https://github.com/llvm/llvm-project/commit/5b6fc610919cc2e88fe3d9bfcc23637c75a636c9 DIFF: https://github.com/llvm/llvm-project/commit/5b6fc610919cc2e88fe3d9bfcc23637c75a636c9.diff LOG:

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-04-30 Thread Urvi Rav via cfe-commits
https://github.com/ravurvi20 updated https://github.com/llvm/llvm-project/pull/128640 >From 6ebd5991788608fbd104ea9c23230912044462d3 Mon Sep 17 00:00:00 2001 From: Urvi Rav Date: Tue, 25 Feb 2025 00:49:07 -0600 Subject: [PATCH 1/9] default clause replaced by otherwise clause for metadirective

[libclc] 1180740 - [libclc][NFC] Remove unused integer-gentype.inc

2025-04-30 Thread Fraser Cormack via cfe-commits
Author: Fraser Cormack Date: 2025-04-30T13:39:23+01:00 New Revision: 1180740ced0218865577a09c9245f035e443a6f0 URL: https://github.com/llvm/llvm-project/commit/1180740ced0218865577a09c9245f035e443a6f0 DIFF: https://github.com/llvm/llvm-project/commit/1180740ced0218865577a09c9245f035e443a6f0.diff

[clang] [C] Diagnose use of C++ keywords in C (PR #137234)

2025-04-30 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > The ObjC `@` is essentially an escape into a completely different grammar, > and it doesn't matter whether the following identifier is a keyword or not in > the base language. This warning should never kick in on that identifier. Okay, I've done that. > Similarly, ObjC s

[clang] [llvm] [IR] Do not store Function inside BlockAddress (PR #137958)

2025-04-30 Thread Nikita Popov via cfe-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/137958 Currently BlockAddresses store both the Function and the BasicBlock they reference, and the BlockAddress is part of the use list of both the Function and BasicBlock. This is quite awkward, because this is not re

[clang] [llvm] [IR] Do not store Function inside BlockAddress (PR #137958)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Nikita Popov (nikic) Changes Currently BlockAddresses store both the Function and the BasicBlock they reference, and the BlockAddress is part of the use list of both the Function and BasicBlock. This is

[clang] [llvm] [IR] Do not store Function inside BlockAddress (PR #137958)

2025-04-30 Thread Nikita Popov via cfe-commits
@@ -32,7 +32,7 @@ void llvm::reduceFunctionsDeltaPass(Oracle &O, ReducerWorkItem &WorkItem) { // Intrinsics don't have function bodies that are useful to // reduce. Additionally, intrinsics may have additional operand // constraints. But, do drop intrinsics that ar

[clang] [HLSL][SPIRV] Add CLI option `-fspv-extension` (PR #137985)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Steven Perron (s-perron) Changes This commit implements DXC's `-fspv-extension` options. It is implemented by replaced it with the equivalent `-spirv-ext` option. Note that if the option is not used, that is the same as enabling all extensio

[clang] [HLSL][SPIRV] Add CLI option `-fspv-extension` (PR #137985)

2025-04-30 Thread Steven Perron via cfe-commits
https://github.com/s-perron created https://github.com/llvm/llvm-project/pull/137985 This commit implements DXC's `-fspv-extension` options. It is implemented by replaced it with the equivalent `-spirv-ext` option. Note that if the option is not used, that is the same as enabling all extension,

[clang] [HLSL][SPIRV] Add CLI option `-fspv-extension` (PR #137985)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Steven Perron (s-perron) Changes This commit implements DXC's `-fspv-extension` options. It is implemented by replaced it with the equivalent `-spirv-ext` option. Note that if the option is not used, that i

[clang] d7f096e - [CIR] Upstream TernaryOp (#137184)

2025-04-30 Thread via cfe-commits
Author: Morris Hafner Date: 2025-04-30T18:15:51+02:00 New Revision: d7f096e3fe611ae2cc7403c3cf2f88255a47b61d URL: https://github.com/llvm/llvm-project/commit/d7f096e3fe611ae2cc7403c3cf2f88255a47b61d DIFF: https://github.com/llvm/llvm-project/commit/d7f096e3fe611ae2cc7403c3cf2f88255a47b61d.diff

[clang] [CIR] Upstream TernaryOp (PR #137184)

2025-04-30 Thread Morris Hafner via cfe-commits
https://github.com/mmha closed https://github.com/llvm/llvm-project/pull/137184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootConstants (PR #137999)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Finn Plummer (inbelic) Changes - defines the empty RootConstants in-memory struct - adds test harness for testing it - adds missing parameter keywords to the lexer (`RootConstants`, `num32BitConstants`) First part of implementing: https:

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootConstants (PR #137999)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Finn Plummer (inbelic) Changes - defines the empty RootConstants in-memory struct - adds test harness for testing it - adds missing parameter keywords to the lexer (`RootConstants`, `num32BitConstants`) First part of implementing: https:/

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootConstants (PR #137999)

2025-04-30 Thread Finn Plummer via cfe-commits
https://github.com/inbelic created https://github.com/llvm/llvm-project/pull/137999 - defines the empty RootConstants in-memory struct - adds test harness for testing it - adds missing parameter keywords to the lexer (`RootConstants`, `num32BitConstants`) First part of implementing: https://g

[clang] 2a5ee25 - [HLSL] Allow resource annotations to specify only register space (#135287)

2025-04-30 Thread via cfe-commits
Author: Helena Kotas Date: 2025-04-30T10:27:27-07:00 New Revision: 2a5ee2501d6249933b0dd4f81a4ec56e146b9669 URL: https://github.com/llvm/llvm-project/commit/2a5ee2501d6249933b0dd4f81a4ec56e146b9669 DIFF: https://github.com/llvm/llvm-project/commit/2a5ee2501d6249933b0dd4f81a4ec56e146b9669.diff

[clang] [flang] [flang] Support flag -finstrument-functions (PR #137996)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: Anchu Rajendran S (anchuraj) Changes `f-instrument-functions` helps in profiling functions. This PR adds support for the option by defining values for function attributes `instrument_function_entry` and `instrument_function_exit

[clang] [llvm] [HLSL] Allow resource annotations to specify only register space (PR #135287)

2025-04-30 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/135287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-04-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c,h -- clang/test/Misc/spir-kernel-attr.c clang/include/

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-04-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/138009 We already diagnose when a jump bypasses initialization in C++ because such code is ill-formed there. However, we were not using this to diagnose those same jumps in C. -Wjump-bypasses-init is grouped und

[clang] [clang][Dependency Scanning] Report What a Module Exports during Scanning (PR #137421)

2025-04-30 Thread Qiongsi Wu via cfe-commits
@@ -115,6 +115,15 @@ struct ModuleID { } }; +struct ExtendedModuleID { qiongsiwu wrote: Oh I see what you meant. Thanks for the clarification. I agree using the STL as much as possible is a good idea. In our case here, I prefer the structure for the follo

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-04-30 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/138003 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Ari

[clang] [-Wunsafe-buffer-usage] Fix false positives for constant cases (PR #92432)

2025-04-30 Thread Malavika Samak via cfe-commits
malavikasamak wrote: Identifying safe operations on String literals has already landed as part of: https://github.com/llvm/llvm-project/pull/115552. However, identifying safe pointer arithmetic is not yet available. So, maybe we should revisit this PR once again. https://github.com/llvm/llvm

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We already diagnose when a jump bypasses initialization in C++ because such code is ill-formed there. However, we were not using this to diagnose those same jumps in C. -Wjump-bypasses-init is grouped

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-04-30 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/138003 >From ff564e64a2ca9948e51c174a5e7a71b05acea510 Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Wed, 30 Apr 2025 12:17:31 -0500 Subject: [PATCH 1/4] add support for anyOf, default, and range case k

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-04-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp -- clang/test/Sema/warn-jump-bypasses-init.c clang/lib

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-04-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Frightening how few tests this breaks, but LGTM. https://github.com/llvm/llvm-project/pull/138009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] clang-format: Sort includes by stem rather than full filename (PR #137840)

2025-04-30 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: > > You definitely need some tests. And I'm not sure if everyone would like > > that, of if it should be an option. > > I was hoping to get some feedback on whether it should be an option or not > before adding tests. I would be in favor. https://github.com/llvm/llv

[clang] [CIR] Upstream support for l-value references (PR #138001)

2025-04-30 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/138001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Make lerp overload tests stricter. NFC (PR #137898)

2025-04-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16945 Here is the relevant piece of the

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-04-30 Thread Alan Li via cfe-commits
@@ -444,17 +444,40 @@ def ROCDL_ds_read_tr6_b96 : ROCDL_LDS_Read_Tr_IntrOp<"ds.read.tr6.b96">; def ROCDL_ds_read_tr16_b64 : ROCDL_LDS_Read_Tr_IntrOp<"ds.read.tr16.b64">; //===-===// -// Global load to LDS int

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-04-30 Thread Björn Schäpers via cfe-commits
@@ -5283,6 +5299,7 @@ struct FormatStyle { bool operator==(const FormatStyle &R) const { return AccessModifierOffset == R.AccessModifierOffset && AlignAfterOpenBracket == R.AlignAfterOpenBracket && + AlignAfterControlStatement == R.AlignAfterControlSt

[clang] [Clang][CodeGen] Check `isUnderlyingBasePointerConstantNull` in `emitPointerArithmetic` (PR #137849)

2025-04-30 Thread Eli Friedman via cfe-commits
@@ -4238,7 +4238,8 @@ static Value *emitPointerArithmetic(CodeGenFunction &CGF, else elemTy = CGF.ConvertTypeForMem(elementType); - if (CGF.getLangOpts().PointerOverflowDefined) + if (CGF.getLangOpts().PointerOverflowDefined || + CGF.isUnderlyingBasePointerConstan

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-04-30 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/137991 These documents explain the core ideas and some implementation details of the Key Instructions project. The LLVM document also outlines the two main limitations of our approach. RFC: https://discourse.llvm.or

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Orlando Cazalet-Hyams (OCHyams) Changes These documents explain the core ideas and some implementation details of the Key Instructions project. The LLVM document also outlines the two main limitations of our approach. RFC: https://disco

[clang] [flang] [flang][flang-driver] Support flag -finstrument-functions (PR #137996)

2025-04-30 Thread Anchu Rajendran S via cfe-commits
https://github.com/anchuraj edited https://github.com/llvm/llvm-project/pull/137996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Support flag -finstrument-functions (PR #137996)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver @llvm/pr-subscribers-clang-driver Author: Anchu Rajendran S (anchuraj) Changes `f-instrument-functions` helps in profiling functions. This PR adds support for the option by defining values for function attributes `instrument_function_entry

[clang] [clang][Dependency Scanning] Report What a Module Exports during Scanning (PR #137421)

2025-04-30 Thread Cyndy Ishida via cfe-commits
@@ -115,6 +115,15 @@ struct ModuleID { } }; +struct ExtendedModuleID { cyndyishida wrote: for that `using DepInfo = std::pair` achieves the same thing, right? & you can unpack it like `auto [MID, isExported] = ClangModuleDeps.first()` I don't feel that st

[clang] [clang][Dependency Scanning] Report What a Module Exports during Scanning (PR #137421)

2025-04-30 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida edited https://github.com/llvm/llvm-project/pull/137421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Format two files with CallingConv switches (PR #138000)

2025-04-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/138000 I'm planning on modifying this code so format it so we can pass the formatting check. >From 3ae86aef81e0ae19e49a4c6db9869e327d4ad4fc Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 30 Apr 2025 10:33:58

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootConstants (PR #137999)

2025-04-30 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/137999 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/138001 This adds basic support for handling reference values. >From 1aaf67db799b0fb8d2593d9978b0fd9c27bf6e7e Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Wed, 30 Apr 2025 10:30:32 -0700 Subject: [PATCH] [CIR] U

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This adds basic support for handling reference values. --- Full diff: https://github.com/llvm/llvm-project/pull/138001.diff 4 Files Affected: - (modified) clang/lib/CIR/CodeGen/CIRGenExpr.cpp (+35-1) -

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-04-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 20498a3ab88fc60dfd425958c350e0d80f21951f Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Tue, 29 Apr 2025 14:40:43 -0700 Subject: [PATCH] [clang] Add spir_kernel attribute Signed-off-by: Sarnie, Nick

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/138001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Erich Keane via cfe-commits
@@ -102,3 +102,20 @@ size_type max_size() { // CHECK: %3 = cir.cast(integral, %2 : !s32i), !u64i // CHECK: %4 = cir.const #cir.int<8> : !u64i // CHECK: %5 = cir.binop(div, %3, %4) : !u64i + +void ref_arg(int &x) { + int y = x; + x = 3; +} erichkeane wro

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Erich Keane via cfe-commits
@@ -439,7 +439,13 @@ LValue CIRGenFunction::emitDeclRefLValue(const DeclRefExpr *e) { cgm.errorNYI(e->getSourceRange(), "emitDeclRefLValue: static local"); } -return makeAddrLValue(addr, ty, AlignmentSource::Type); +// Drill into reference types. +LValue

[clang] [clang-format] Add SpaceAfterOperatorKeyword option (PR #137610)

2025-04-30 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/137610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Overloads for `lerp` with a scalar weight (PR #137877)

2025-04-30 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/137877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ae6b4b2 - [HLSL] Overloads for `lerp` with a scalar weight (#137877)

2025-04-30 Thread via cfe-commits
Author: Justin Bogner Date: 2025-04-30T12:30:06-07:00 New Revision: ae6b4b23ea4291e937192a3c08d0f3c9835864c2 URL: https://github.com/llvm/llvm-project/commit/ae6b4b23ea4291e937192a3c08d0f3c9835864c2 DIFF: https://github.com/llvm/llvm-project/commit/ae6b4b23ea4291e937192a3c08d0f3c9835864c2.diff

[clang] [clang-format] Add SpaceAfterOperatorKeyword option (PR #137610)

2025-04-30 Thread Björn Schäpers via cfe-commits
@@ -4463,6 +4463,14 @@ struct FormatStyle { /// \version 9 bool SpaceAfterLogicalNot; + /// If \c true, a space will be inserted after the ``operator`` keyword. + /// \code + ///true:false: + ///bool operator == (int a) vs.

[clang] [clang-format] Add SpaceAfterOperatorKeyword option (PR #137610)

2025-04-30 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. From the technical point of view this is fine (given the version number is corrected). Please wait for feedback from @mydeveloperday . https://github.com/llvm/llvm-project/pull/137610 _

[clang] [flang] [flang][flang-driver] Support flag -finstrument-functions (PR #137996)

2025-04-30 Thread Anchu Rajendran S via cfe-commits
@@ -124,6 +128,8 @@ struct MLIRToLLVMPassPipelineConfig : public FlangEPCallBacks { bool UnsafeFPMath = false; ///< Set unsafe-fp-math attribute for functions. bool NSWOnLoopVarInc = true; ///< Add nsw flag to loop variable increments. bool EnableOpenMP = false; ///< Ena

[clang] [HLSL] Overloads for `lerp` with a scalar weight (PR #137877)

2025-04-30 Thread Justin Bogner via cfe-commits
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/137877 >From a6c359a02712277ba2feab9e2f1be1caf8fa650e Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Tue, 29 Apr 2025 11:59:37 -0700 Subject: [PATCH] [HLSL] Overloads for `lerp` with a scalar weight This adds overl

[clang] clang-format: Sort includes by stem rather than full filename (PR #137840)

2025-04-30 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks commented: How do you think should files be handled, that only differ in the caseness of the extension? https://github.com/llvm/llvm-project/pull/137840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [HLSL] Overloads for `lerp` with a scalar weight (PR #137877)

2025-04-30 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/137877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (PR #134930)

2025-04-30 Thread Tom Stellard via cfe-commits
tstellar wrote: /cherry-pick f5a30f111dc4ad6422863722eb708059a68a9d5c https://github.com/llvm/llvm-project/pull/134930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (PR #134930)

2025-04-30 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/134930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/138001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Erich Keane via cfe-commits
@@ -102,3 +102,20 @@ size_type max_size() { // CHECK: %3 = cir.cast(integral, %2 : !s32i), !u64i // CHECK: %4 = cir.const #cir.int<8> : !u64i // CHECK: %5 = cir.binop(div, %3, %4) : !u64i + +void ref_arg(int &x) { + int y = x; + x = 3; +} erichkeane wro

[clang] [Preprocessor] Do not expand macros if the input is already preprocessed (PR #137665)

2025-04-30 Thread Michael Spencer via cfe-commits
Juan Manuel Martinez =?utf-8?q?Caamaño?= Message-ID: In-Reply-To: Bigcheese wrote: module maps don't get preprocessed, so I don't think it matters what that is set to. For normal module.modulemap files `Preprocessed` is `false`. I think it's fine to remove the true and see if anything breaks

[clang] [Clang][CodeGen] Add workaround for old glibc `__PTR_ALIGN` macro (PR #137851)

2025-04-30 Thread Eli Friedman via cfe-commits
@@ -4820,6 +4820,15 @@ bool CodeGenFunction::isUnderlyingBasePointerConstantNull(const Expr *E) { const Expr *UnderlyingBaseExpr = E->IgnoreParens(); while (auto *BaseMemberExpr = dyn_cast(UnderlyingBaseExpr)) UnderlyingBaseExpr = BaseMemberExpr->getBase()->IgnoreParen

[clang] [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (PR #134930)

2025-04-30 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#138017 https://github.com/llvm/llvm-project/pull/134930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

2025-04-30 Thread Serge Pavlov via cfe-commits
Juan Manuel Martinez =?utf-8?q?Caama=C3=B1o?= Message-ID: In-Reply-To: https://github.com/spavloff approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/137306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang-tools-extra] [clangd] Add CodePatterns config option under Completion (PR #137613)

2025-04-30 Thread via cfe-commits
Noustaa wrote: Code autocomplete works just fine with CodePatterns::None but include autocomplete does not work anymore. Gonna investigate when i have some time. https://github.com/llvm/llvm-project/pull/137613 ___ cfe-commits mailing list cfe-commits

[clang] [HLSL][RootSignature] Add lexing support for floating points (PR #137720)

2025-04-30 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/137720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-04-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] 6274cdb - [clang] Fix UEFI Target info (#127290)

2025-04-30 Thread via cfe-commits
Author: Prabhu Rajasekaran Date: 2025-04-30T10:07:57-07:00 New Revision: 6274cdb9a6714908c8a4e30d2ef0bf22a6949065 URL: https://github.com/llvm/llvm-project/commit/6274cdb9a6714908c8a4e30d2ef0bf22a6949065 DIFF: https://github.com/llvm/llvm-project/commit/6274cdb9a6714908c8a4e30d2ef0bf22a6949065.

[clang] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and older (PR #124651)

2025-04-30 Thread via cfe-commits
https://github.com/Un1q32 updated https://github.com/llvm/llvm-project/pull/124651 >From d4e97c4113086c3d2dfa3bf6e9ecfee377f8c4b6 Mon Sep 17 00:00:00 2001 From: Un1q32 Date: Mon, 27 Jan 2025 18:00:34 -0500 Subject: [PATCH 1/3] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and olde

[clang] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and older (PR #124651)

2025-04-30 Thread via cfe-commits
Un1q32 wrote: bump https://github.com/llvm/llvm-project/pull/124651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] rename enabled flags to `disable-*` (PR #132991)

2025-04-30 Thread Mohamed Emad via cfe-commits
https://github.com/hulxv updated https://github.com/llvm/llvm-project/pull/132991 >From c476948593a80ed31765cdd711a626e4e03930ab Mon Sep 17 00:00:00 2001 From: hulxv Date: Tue, 25 Mar 2025 22:56:51 +0200 Subject: [PATCH 01/12] [include-cleaner] rename enabled flags to `disable-*` --- .../incl

[clang] [clang][Dependency Scanning] Report What a Module Exports during Scanning (PR #137421)

2025-04-30 Thread Qiongsi Wu via cfe-commits
@@ -115,6 +115,15 @@ struct ModuleID { } }; +struct ExtendedModuleID { qiongsiwu wrote: Hmmm I think I am misunderstanding something. Is this what we are proposing? Instead of ``` std::vector ClangModuleDeps; ``` we have ``` std::vector> ClangModule

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: None (Andres-Salamanca) Changes This introduces support for the following cir::case kinds: - `Equal` - `AnyOf` - `Range` --- Full diff: https://github.com/llvm/llvm-project/pull/138003.diff 4 Files Affected: - (modified) clang/includ

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-04-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/CIR/MissingFeatures.h clang/li

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Andy Kaylor via cfe-commits
@@ -102,3 +102,20 @@ size_type max_size() { // CHECK: %3 = cir.cast(integral, %2 : !s32i), !u64i // CHECK: %4 = cir.const #cir.int<8> : !u64i // CHECK: %5 = cir.binop(div, %3, %4) : !u64i + +void ref_arg(int &x) { + int y = x; + x = 3; +} andykaylor wro

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Andy Kaylor via cfe-commits
@@ -439,7 +439,13 @@ LValue CIRGenFunction::emitDeclRefLValue(const DeclRefExpr *e) { cgm.errorNYI(e->getSourceRange(), "emitDeclRefLValue: static local"); } -return makeAddrLValue(addr, ty, AlignmentSource::Type); +// Drill into reference types. +LValue

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-04-30 Thread via cfe-commits
https://github.com/Andres-Salamanca created https://github.com/llvm/llvm-project/pull/138003 This introduces support for the following cir::case kinds: - `Equal` - `AnyOf` - `Range` >From ff564e64a2ca9948e51c174a5e7a71b05acea510 Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Wed, 30 Ap

[clang] [flang] [flang][flang-driver] Support flag -finstrument-functions (PR #137996)

2025-04-30 Thread Tarun Prabhu via cfe-commits
@@ -124,6 +128,8 @@ struct MLIRToLLVMPassPipelineConfig : public FlangEPCallBacks { bool UnsafeFPMath = false; ///< Set unsafe-fp-math attribute for functions. bool NSWOnLoopVarInc = true; ///< Add nsw flag to loop variable increments. bool EnableOpenMP = false; ///< Ena

[clang] [clang] Warn about deprecated volatile-qualified return types (PR #137899)

2025-04-30 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Can you add more details in the summary. Specifically your approach to fixing the issue. Something along the lines of "In GetFullTypeForDeclarator ... moved check ... b/c ..." https://github.com/llvm/llvm-project/pull/137899 ___

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-04-30 Thread via cfe-commits
https://github.com/jofrn edited https://github.com/llvm/llvm-project/pull/123609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Dependency Scanning] Report What a Module Exports during Scanning (PR #137421)

2025-04-30 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu updated https://github.com/llvm/llvm-project/pull/137421 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

2025-04-30 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,35 @@ +// libstdc++ uses the non-constexpr function std::__glibcxx_assert_fail() +// to trigger compilation errors when the __glibcxx_assert(cond) macro +// is used in a constexpr context. +// Compilation fails when using code from the libstdc++ (such as std::array) on

[clang-tools-extra] [clang-tidy] Fix false positive for cppcoreguidelines-pro-bounds-pointer-arithmetic (PR #127394)

2025-04-30 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp edited https://github.com/llvm/llvm-project/pull/127394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Start work to lower 'loop' (PR #137972)

2025-04-30 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru edited https://github.com/llvm/llvm-project/pull/137972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-04-30 Thread via cfe-commits
Andres-Salamanca wrote: @andykaylor https://github.com/llvm/llvm-project/pull/138003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ea0e6e3 - [OpenACC] Improve 'loop' content restrictions

2025-04-30 Thread via cfe-commits
Author: erichkeane Date: 2025-04-30T12:02:52-07:00 New Revision: ea0e6e33835fe9fada89f77cc3a6cd74eb690067 URL: https://github.com/llvm/llvm-project/commit/ea0e6e33835fe9fada89f77cc3a6cd74eb690067 DIFF: https://github.com/llvm/llvm-project/commit/ea0e6e33835fe9fada89f77cc3a6cd74eb690067.diff LO

[clang-tools-extra] [clang-tidy] Fix false positive for cppcoreguidelines-pro-bounds-pointer-arithmetic (PR #127394)

2025-04-30 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: LGTM in general, but won't this fail with a std::map, since the key is an integer? Please rebase on top of latest main and resolve conflicts. https://github.com/llvm/llvm-project/pull/127394 ___ cfe-commits mailing list cfe-commi

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/138001 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang-tools-extra] [clang-tidy] Fix false positive for cppcoreguidelines-pro-bounds-pointer-arithmetic (PR #127394)

2025-04-30 Thread Carlos Galvez via cfe-commits
@@ -106,6 +106,10 @@ Changes in existing checks ` check to allow specifying additional C++ member functions to match. +- Improved :doc:`cppcoreguidelines-pro-bounds-pointer-arithmetic + ` check by + fix false positives related to operator overloading and templates. -

[clang-tools-extra] [clang-tidy] Fix false positive for cppcoreguidelines-pro-bounds-pointer-arithmetic (PR #127394)

2025-04-30 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp edited https://github.com/llvm/llvm-project/pull/127394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for references (PR #138001)

2025-04-30 Thread Andy Kaylor via cfe-commits
@@ -102,3 +102,20 @@ size_type max_size() { // CHECK: %3 = cir.cast(integral, %2 : !s32i), !u64i // CHECK: %4 = cir.const #cir.int<8> : !u64i // CHECK: %5 = cir.binop(div, %3, %4) : !u64i + +void ref_arg(int &x) { + int y = x; + x = 3; +} andykaylor wro

[clang] [OpenACC][CIR] Start work to lower 'loop' (PR #137972)

2025-04-30 Thread Razvan Lupusoru via cfe-commits
@@ -13,17 +13,103 @@ #include "CIRGenBuilder.h" #include "CIRGenFunction.h" #include "CIRGenOpenACCClause.h" -#include "mlir/Dialect/OpenACC/OpenACC.h" + #include "clang/AST/OpenACCClause.h" #include "clang/AST/StmtOpenACC.h" +#include "mlir/Dialect/OpenACC/OpenACC.h" + us

[clang] [OpenACC][CIR] Start work to lower 'loop' (PR #137972)

2025-04-30 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru approved this pull request. Thank you Erich! Your prose on possibilities and challenges is a great idea for inclusion. https://github.com/llvm/llvm-project/pull/137972 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [OpenACC][CIR] Start work to lower 'loop' (PR #137972)

2025-04-30 Thread Razvan Lupusoru via cfe-commits
@@ -13,17 +13,103 @@ #include "CIRGenBuilder.h" #include "CIRGenFunction.h" #include "CIRGenOpenACCClause.h" -#include "mlir/Dialect/OpenACC/OpenACC.h" + #include "clang/AST/OpenACCClause.h" #include "clang/AST/StmtOpenACC.h" +#include "mlir/Dialect/OpenACC/OpenACC.h" + us

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

2025-04-30 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B commented: LGTM in principle. Now the question is -- how do we test it? There are multiple libstdc++ library versions in the wild and we must not break any of them. We do have some testing on CUDA test bots (which I've just discovered to be silently broken for a whil

<    1   2   3   4   5   >