https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/136202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2088,13 +2085,22 @@ llvm::Value *CodeGenFunction::EmitToMemory(llvm::Value
*Value, QualType Ty) {
Value = Builder.CreateBitCast(Value, StoreTy);
}
+ if (Ty->hasBooleanRepresentation() || Ty->isBitIntType()) {
michele-scandale wrote:
I'll double ch
qiongsiwu wrote:
Thanks @jansvoboda11 ! The API is updated so that the end result is a vector of
paths (strings), so the caller can create the diagnostics.
I will add the C-API to https://github.com/swiftlang/llvm-project after this PR
lands.
https://github.com/llvm/llvm-project/pull/135703
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Paul Kirth (ilovepi)
Changes
Reverts llvm/llvm-project#135877
This is causing some problems on Fuchsia's windows CI. We'll need a different
solution to triage other builders.
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/cla
https://github.com/asudarsa converted_to_draft
https://github.com/llvm/llvm-project/pull/135683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Devon Loehr (DKLoehr)
Changes
Followup to #136022, this ensures formatting tests are run with an
empty `.clang-format-ignore` in their root directory, to prevent failures if
the file also exists higher in the tree.
---
Full diff:
https://github.com/tahonermann closed
https://github.com/llvm/llvm-project/pull/133030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/136077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thurstond closed
https://github.com/llvm/llvm-project/pull/129405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/liliumShade updated
https://github.com/llvm/llvm-project/pull/123193
>From 08f81150949fb97411d6cc6e58c2b9f293cc1bf5 Mon Sep 17 00:00:00 2001
From: Chyaka
Date: Thu, 16 Jan 2025 19:02:54 +0800
Subject: [PATCH 1/6] [RISCV] Add processor definition for
XiangShan-KunMingHu-V2R2
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/135573
>From 93c8fc7faba6ab9537039b8745e62f5d79785cd0 Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Thu, 17 Apr 2025 23:58:35 +0300
Subject: [PATCH] [Clang] enhance loop analysis to handle variable changes
farzonl wrote:
> This doesn't seem right. Are we just misusing `DiagnosticInfoUnsupported`
> here? The `Function` argument for `DiagnosticInfoWithLocationBase` is clearly
> meant to be part of the location (as evidenced by the "in function XYZ" part
> of the message). I suspect that we should
https://github.com/chandlerc created
https://github.com/llvm/llvm-project/pull/136213
This lets us pass `-no-disable-free` to re-enable freeing memory for example.
This is especially helpful for library users of Clang where it is important to
not slowly leak memory.
>From 4e4ca5ab0f49252ea5a5
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: None (yronglin)
Changes
This PR reland https://github.com/llvm/llvm-project/pull/135808, fixed some
missed changes in LLDB.
I found this issue when I working on
https://github.com/llvm/llvm-project/pull/107168.
Currently we h
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/135938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Tongsheng Wu (tongshengw)
Changes
IncludeCleaner header not found messages now show file path.
[https://github.com/clangd/clangd/issues/2334](https://github.com/clangd/clangd/issues/2334)
New error messages:
```
E[03:32:43.219] IncludeCl
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/135683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,c --
clang/lib/StaticAnalyzer/Checkers/BuiltinFunctionCh
https://github.com/pskrgag updated
https://github.com/llvm/llvm-project/pull/136345
>From bcc3a8d0654d7a92183fb5b010892740c593e012 Mon Sep 17 00:00:00 2001
From: Pavel Skripkin
Date: Fri, 18 Apr 2025 22:01:02 +0300
Subject: [PATCH 1/2] [clang][Analyzer] Fix error path of builtin overflow
---
HighCommander4 wrote:
@tdupes @kadircet it looks like this PR was approved but has not been merged --
could we merge it?
https://github.com/llvm/llvm-project/pull/71605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
bob-wilson wrote:
I guess we could. Do you think it's worth it? These are only internal cc1
flags. I don't mind to change it, but it will add some minor complexity.
https://github.com/llvm/llvm-project/pull/136232
___
cfe-commits mailing list
cfe-comm
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
clang/test/Analysis/pragma-diag-control.cpp
clang/
DKLoehr wrote:
Here's what cvise gave me; unfortunately, I'm in a rush so I don't have time to
clean it up any further. It crashes when run with `clang++ repro.cc -std=c++20
-Wno-everyt hing -fsyntax-only -ferror-limit=0`
repro.cc:
```
template using conditional_t = _IfRes;
template void for
Author: Andy Kaylor
Date: 2025-04-18T12:52:51-07:00
New Revision: daf3c985f75bae2f4f01594be2fbc02f953e7b06
URL:
https://github.com/llvm/llvm-project/commit/daf3c985f75bae2f4f01594be2fbc02f953e7b06
DIFF:
https://github.com/llvm/llvm-project/commit/daf3c985f75bae2f4f01594be2fbc02f953e7b06.diff
L
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/136335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/127290
>From 3e6122744f355954edb6a5450ae4220ba39bc9c1 Mon Sep 17 00:00:00 2001
From: prabhukr
Date: Fri, 14 Feb 2025 16:53:33 -0800
Subject: [PATCH 01/13] [clang] Fix UEFI Target info
For X64 UEFI targets, making the
https://github.com/xlauko created
https://github.com/llvm/llvm-project/pull/136361
LowerGlobalDtors: Use use_empty instead of getNumUses == 0 (#136337)
[flang] Improve runtime SAME_TYPE_AS() (#135670)
The present implementation of the intrinsic function SAME_TYPE_AS()
yields false positive .TR
xlauko wrote:
* **#136361** https://app.graphite.dev/github/pr/llvm/llvm-project/136361?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13636
https://github.com/jcranmer-intel commented:
Tests for FP operand bundles on a non-intrinsic function would be helpful.
https://github.com/llvm/llvm-project/pull/135658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/xlauko updated
https://github.com/llvm/llvm-project/pull/136361
>From 2c711e7f5365c1fe6a34254f69c6480a469aebe7 Mon Sep 17 00:00:00 2001
From: xlauko
Date: Fri, 18 Apr 2025 21:59:30 +0200
Subject: [PATCH] [CIR] Infer MLIR context in type builders when possible
---
clang/incl
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/136323
>From 3beecb29772e13c6a1a41877e5e8cbbfb17a88f2 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Fri, 18 Apr 2025 12:26:36 -0400
Subject: [PATCH 1/2] Control analysis-based diagnostics with #pragma
Previo
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/136234
>From 562084ce64581b1cffe30024082f9eb84393875c Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Thu, 17 Apr 2025 17:42:34 -0700
Subject: [PATCH 1/2] [DirectX] add Function name to DiagnosticInfoUnsupported
Msg
https://github.com/jansvoboda11 commented:
The diagnostic is confusing - it tells the user they used an invalid
combination of flags, but shows flags they did not use at all. I think we can
improve on this and report when a flag is deduced/assumed/defaulted.
https://github.com/llvm/llvm-projec
@@ -225,17 +235,108 @@ void RecordType::complete(ArrayRef members, bool
packed, bool padded) {
//===--===//
llvm::TypeSize
-RecordType::getTypeSizeInBits(const ::mlir::DataLayout &dataLayout,
-
@@ -502,6 +502,15 @@ def CIR_RecordType : CIR_Type<"Record", "record",
void complete(llvm::ArrayRef members, bool packed,
bool isPadded);
+
+ // Utilities for lazily computing and cacheing data layout info.
+ // FIXME: currently opaque because there's a
Author: Andy Kaylor
Date: 2025-04-18T10:30:36-07:00
New Revision: e298f16e895f1c3e5571ec1adb84f29646b84637
URL:
https://github.com/llvm/llvm-project/commit/e298f16e895f1c3e5571ec1adb84f29646b84637
DIFF:
https://github.com/llvm/llvm-project/commit/e298f16e895f1c3e5571ec1adb84f29646b84637.diff
L
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/136036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc wrote:
> You might want to change the `DisableFree` default for library uses so that
> users don't need to specify `-no-disable-free`.
>
> ```
> // Clang calls BuryPointer on the internal AST and CodeGen-related elements
> like TargetMachine.
> // This will cause memory leaks if
@@ -2493,35 +2493,44 @@ class sema::AnalysisBasedWarnings::InterProceduralData {
CalledOnceInterProceduralData CalledOnceData;
};
-static unsigned isEnabled(DiagnosticsEngine &D, unsigned diag) {
- return (unsigned)!D.isIgnored(diag, SourceLocation());
+static bool isEnable
@@ -2493,35 +2493,44 @@ class sema::AnalysisBasedWarnings::InterProceduralData {
CalledOnceInterProceduralData CalledOnceData;
};
-static unsigned isEnabled(DiagnosticsEngine &D, unsigned diag) {
- return (unsigned)!D.isIgnored(diag, SourceLocation());
+static bool isEnable
@@ -1202,6 +1202,30 @@ Clang also allows you to push and pop the current
warning state. This is
particularly useful when writing a header file that will be compiled by
other people, because you don't know what warning flags they build with.
+Note that the following diagnostic
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,6 @@
+// Check that -Xclangas passes args to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas +v5t %s 2>&1 | \
MaskRay wrote:
change one arg to use `-Xclangas=`
https://github.com/llvm/llvm-project/pull/100714
_
https://github.com/MaskRay approved this pull request.
(I will have limited internet access between April 20th and May 4th, and my
response time may be delayed..)
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
cfe-commi
MaskRay wrote:
> This is one of the ideas I gave in
> https://github.com/llvm/llvm-project/issues/97517. I opted to propose this
> one first as introducing a new -Xclangas option comes with no concerns about
> GCC compatibility as with -Xassembler.
Please update the description/commit messag
@@ -0,0 +1,6 @@
+// Check that -Xclangas passes args to -cc1as.
MaskRay wrote:
`/// ` for non-RUN non-CHECK comments to make them stand out
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
nikic wrote:
> I don't see the necessity of using operand bundles. All of the possible
> arguments are metadata strings, not SSA values. Can't we just use metadata
> instead?
Metadata always has to be droppable. Some of this could in theory be handled
with metadata if we say the behavior (wit
@@ -2493,35 +2493,44 @@ class sema::AnalysisBasedWarnings::InterProceduralData {
CalledOnceInterProceduralData CalledOnceData;
};
-static unsigned isEnabled(DiagnosticsEngine &D, unsigned diag) {
- return (unsigned)!D.isIgnored(diag, SourceLocation());
+static bool isEnable
https://github.com/erichkeane ready_for_review
https://github.com/llvm/llvm-project/pull/135372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2493,35 +2493,44 @@ class sema::AnalysisBasedWarnings::InterProceduralData {
CalledOnceInterProceduralData CalledOnceData;
};
-static unsigned isEnabled(DiagnosticsEngine &D, unsigned diag) {
- return (unsigned)!D.isIgnored(diag, SourceLocation());
+static bool isEnable
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andy Kaylor (andykaylor)
Changes
Previously when we checked to see if it was safe to create CIR for a structure
type, we were conservatively saying no if any structure was in the process of
being converted. That prevented handling nested
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: Andy Kaylor (andykaylor)
Changes
Previously when we checked to see if it was safe to create CIR for a structure
type, we were conservatively saying no if any structure was in the process of
being converted. That prevented handling neste
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/136331
Previously when we checked to see if it was safe to create CIR for a structure
type, we were conservatively saying no if any structure was in the process of
being converted. That prevented handling nested st
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/135372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
@clementval @razvanlupusoru
This should now be ready, though it probably has to be merged with the flang
changes after `num_gangs`/`num_workers`/`vector_length` changes are made.
MOST of this ended up being test changes as we went along, But the
tablegen/ACC.td changes/etc
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/136332
This change adds support for handling ParenExpr in scalar expressions. A few
more places will need to be updated after structure assignment and complex type
support is in place.
>From 15a892df17d7d2fcd32322
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: Andy Kaylor (andykaylor)
Changes
This change adds support for handling ParenExpr in scalar expressions. A few
more places will need to be updated after structure assignment and complex type
support is in place.
---
Full diff: https://g
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andy Kaylor (andykaylor)
Changes
This change adds support for handling ParenExpr in scalar expressions. A few
more places will need to be updated after structure assignment and complex type
support is in place.
---
Full diff: https://git
Author: Qiongsi Wu
Date: 2025-04-18T10:52:39-07:00
New Revision: 9ef91677a4a2d4b017d2b96b8c89c2a9b648d6c3
URL:
https://github.com/llvm/llvm-project/commit/9ef91677a4a2d4b017d2b96b8c89c2a9b648d6c3
DIFF:
https://github.com/llvm/llvm-project/commit/9ef91677a4a2d4b017d2b96b8c89c2a9b648d6c3.diff
LO
https://github.com/qiongsiwu closed
https://github.com/llvm/llvm-project/pull/135703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/macurtis-amd updated
https://github.com/llvm/llvm-project/pull/134621
>From 9d38a08bc91273d961fa1bd855d212b09249d826 Mon Sep 17 00:00:00 2001
From: Matthew Curtis
Date: Fri, 18 Apr 2025 12:46:23 -0500
Subject: [PATCH] [clang] Suppress gnu-line-marker when saving temps
When p
@@ -139,7 +139,7 @@ class DiagnosticInfo {
using DiagnosticHandlerFunction = std::function;
class DiagnosticInfoGeneric : public DiagnosticInfo {
- const Twine &MsgStr;
+ const Twine MsgStr;
bogner wrote:
All of the Twine usage in Diagnostic info is super s
@@ -756,9 +756,10 @@ class OpLowerer {
case Intrinsic::not_intrinsic:
continue;
default: {
-DiagnosticInfoUnsupported Diag(
-F, "Unsupported intrinsic for DXIL lowering");
-M.getContext().diagnose(Diag);
+std::string Msg =
@@ -0,0 +1,7 @@
+// RUN: %if clang-dxc %{not %clang_dxc -T lib_6_3 %s 2>&1 | FileCheck %s %}
bogner wrote:
I don't think there's a `clang-dxc` feature, so I suspect this just never runs
at all. This will fail if the DirectX backend isn't available, so I don't th
@@ -0,0 +1,7 @@
+// RUN: %if clang-dxc %{not %clang_dxc -T lib_6_3 %s 2>&1 | FileCheck %s %}
farzonl wrote:
I tried REQUIRES: directx-registered-target and it just makes it so the test
gets skipped as unsupported even on my local machine with the directx target
https://github.com/kmpeng updated
https://github.com/llvm/llvm-project/pull/135878
>From 69aee464d31dcf585c355808053b0c4d1c7d7f3c Mon Sep 17 00:00:00 2001
From: kmpeng
Date: Mon, 7 Apr 2025 14:46:07 -0700
Subject: [PATCH 1/4] create int_spv_faceforward intrinsic, create faceforward
lowering &
https://github.com/kmpeng updated
https://github.com/llvm/llvm-project/pull/135878
>From d953d95867574dd575cf098668554dfa8e7ffad5 Mon Sep 17 00:00:00 2001
From: kmpeng
Date: Mon, 7 Apr 2025 14:46:07 -0700
Subject: [PATCH 1/4] create int_spv_faceforward intrinsic, create faceforward
lowering &
https://github.com/haoNoQ edited
https://github.com/llvm/llvm-project/pull/136323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ commented:
So from the user's perspective we're checking the flag twice: once at the `}`
to see if we need to ramp up the analysis, then again at the diagnostic
location to see if the diagnostic should be discarded. The warning will only be
emitted if it's enabled at
@@ -202,6 +202,43 @@ class SemaPPCallbacks : public PPCallbacks {
break;
}
}
+ void PragmaDiagnostic(SourceLocation Loc, StringRef Namespace,
+diag::Severity Mapping, StringRef Str) override {
+// If one of the analysis-based diagnostics
@@ -0,0 +1,35 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+
+// RUN: %clang_cc1 -O1 -triple spirv-pc-vulkan-compute %s -emit-llvm -o - |
FileCheck %s
+
+typedef float float2 __attribute__((ext_vector_type(2)));
+typedef
@@ -105,35 +136,27 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned
BuiltinID,
if (SemaRef.checkArgCount(TheCall, 3))
return true;
-// check if the all arguments have floating representation
-for (unsigned i = 0; i < TheCall->getNumArgs(); ++i) {
-
@@ -126,6 +126,24 @@ template constexpr vector lit_impl(T
NDotL, T NDotH, T M) {
return Result;
}
+template constexpr T faceforward_impl(T N, T I, T Ng) {
kmpeng wrote:
You're right. Removed vector implementation
https://github.com/llvm/llvm-project/pul
erichkeane wrote:
> So from the user's perspective we're checking the flag twice: once at the `}`
> to see if we need to ramp up the analysis, then again at the diagnostic
> location to see if the diagnostic should be discarded. The warning will only
> be emitted if it's enabled at both source
501 - 574 of 574 matches
Mail list logo
