================ @@ -139,7 +139,7 @@ class DiagnosticInfo { using DiagnosticHandlerFunction = std::function<void(const DiagnosticInfo &)>; class DiagnosticInfoGeneric : public DiagnosticInfo { - const Twine &MsgStr; + const Twine MsgStr; ---------------- bogner wrote:
All of the Twine usage in Diagnostic info is super sketchy. I think we can drop this from this change and do it more comprehensively here: https://github.com/llvm/llvm-project/pull/136371 https://github.com/llvm/llvm-project/pull/136234 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits