[clang] [clang] Reject character devices in #embed for now (PR #135370)

2025-04-11 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/135370 >From 49e347a73709661fcf3a4805f38cfa2d78e3a196 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Fri, 11 Apr 2025 06:46:00 -0700 Subject: [PATCH 1/3] [clang] Reject character devices in #embed for

[clang] d6c1ef5 - [AMDGPU] vmem-to-lds-load-insts incoherence between TargetParser and AMDGPU.td (#135376)

2025-04-11 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2025-04-11T16:31:04+02:00 New Revision: d6c1ef576f0a44486a8a0f7f33123ad7c9f8c5e9 URL: https://github.com/llvm/llvm-project/commit/d6c1ef576f0a44486a8a0f7f33123ad7c9f8c5e9 DIFF: https://github.com/llvm/llvm-project/commit/d6c1ef576f0a44486a8a0f7f33123ad

[clang] [clang] Reject character devices in #embed for now (PR #135370)

2025-04-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I think we should add some test coverage for both Windows and Linux. I think on Linux we can use `/dev/urandom` and on Windows we could use something like `COM1` on Windows. WDYT? Also, these changes should come with a release note. https://github.co

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

2025-04-11 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/135027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-11 Thread via cfe-commits
@@ -3593,6 +3578,25 @@ class sme_tmopa_32b opc, RegisterOperand zn_ty, RegisterOperand zm_ty, s let Constraints = "$ZAda = $_ZAda"; } +multiclass sme_tmopa_16b opc, RegisterOperand zn_ty, RegisterOperand zm_ty, ValueType vt, string mnemonic, string intrinsic> { + def NAME

[clang] [CIR] Upstream binary assignments and comma (PR #135115)

2025-04-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,c,cpp -- clang/test/CIR/CodeGen/binassign.c clang/test/CIR

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-11 Thread via cfe-commits
@@ -3593,6 +3578,25 @@ class sme_tmopa_32b opc, RegisterOperand zn_ty, RegisterOperand zm_ty, s let Constraints = "$ZAda = $_ZAda"; } +multiclass sme_tmopa_16b opc, RegisterOperand zn_ty, RegisterOperand zm_ty, ValueType vt, string mnemonic, string intrinsic> { + def NAME

[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

2025-04-11 Thread via cfe-commits
MillePlateaux wrote: @AaronBallman Thank you for your selfless guidance. I have modified the code now. Please review it. https://github.com/llvm/llvm-project/pull/134465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [NFC][Clang] Don't check hardcode op num (PR #135375)

2025-04-11 Thread Gang Chen via cfe-commits
https://github.com/cmc-rep approved this pull request. https://github.com/llvm/llvm-project/pull/135375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream binary assignments and comma (PR #135115)

2025-04-11 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/135115 >From 2a9a282dc3227710ce6462d2847876565ba5eb49 Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 11 Apr 2025 16:17:45 +0200 Subject: [PATCH 1/3] [CIR] Upstream binary assignments and comma This patch adds `Vi

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-11 Thread via cfe-commits
@@ -907,6 +907,48 @@ let SMETargetGuard = "sme-f16f16" in { } + +// SME2 - TMOP, SUTMOP, USTMOP + +multiclass USTMOP checks> { + def _ : SInst<"svtmopa_lane_" # za # "[_{d}_{3}]", +

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-11 Thread via cfe-commits
@@ -907,6 +907,48 @@ let SMETargetGuard = "sme-f16f16" in { } + +// SME2 - TMOP, SUTMOP, USTMOP + +multiclass USTMOP checks> { + def _ : SInst<"svtmopa_lane_" # za # "[_{d}_{3}]", +

[clang] [C23] Fix failed assertions with invalid #embed parameters (PR #135368)

2025-04-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/135368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d1ea479 - [C23] Fix failed assertions with invalid #embed parameters (#135368)

2025-04-11 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-04-11T10:44:37-04:00 New Revision: d1ea4799d9a3e2757772a47e9dce5f2e24bb982f URL: https://github.com/llvm/llvm-project/commit/d1ea4799d9a3e2757772a47e9dce5f2e24bb982f DIFF: https://github.com/llvm/llvm-project/commit/d1ea4799d9a3e2757772a47e9dce5f2e24bb982f.diff

[clang] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
erichkeane wrote: Note: No real reason to review this quite yet? I'm still going to do a bunch of work on tablegen to no longer use the FLANG generated things by generating clang ones that are similar, so a lot of the Appertainment.cpp file is going to change. https://github.com/llvm/llvm-p

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/135383 Add support for lambda-expression in `use-trailing-return-type` check. Added two new options: 1. `TransformFunctions` will trigger function declarations to use trailing return type. Values can be `true` or `fa

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) Changes Add support for lambda-expression in `use-trailing-return-type` check. Added two new options: 1. `TransformFunctions` will trigger function declarations to use trailing return type. Values can be `tr

[clang] [clang] Reject character devices in #embed for now (PR #135370)

2025-04-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > on Windows we could use something like COM1 on Windows. > > How would that look like? `#embed "COM1" limit(1)` But when I try that on my Windows machine, I get a file not found error. Perhaps try `#embed "NUL" limit(1)`? https://github.com/llvm/llvm-project/pull/13537

[clang] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
erichkeane wrote: Note: I discovered a bug in my 'exclusive' check that eliminated 2 items from the above list! https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [CIR] Upstream binary assignments and comma (PR #135115)

2025-04-11 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/135115 >From 2a9a282dc3227710ce6462d2847876565ba5eb49 Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 11 Apr 2025 16:17:45 +0200 Subject: [PATCH 1/4] [CIR] Upstream binary assignments and comma This patch adds `Vi

[clang] [CIR] Upstream binary assignments and comma (PR #135115)

2025-04-11 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/135115 >From 2a9a282dc3227710ce6462d2847876565ba5eb49 Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 11 Apr 2025 16:17:45 +0200 Subject: [PATCH 1/4] [CIR] Upstream binary assignments and comma This patch adds `Vi

[clang] [clang][ast]: Add DynamicAllocLValue and TypeInfoLValue support to APValue::dump(). (PR #135178)

2025-04-11 Thread via cfe-commits
YLChenZ wrote: > Would be good to print more information about them. @tbaederr It seems to only dump their type, like this: ```cpp case APValue::LValue: { (void)Context; OS << "LValue Base="; APValue::LValueBase B = Value.getLValueBase(); ... } else if (B.is()) { OS <<

[clang] [clang] Extract `CompilerInstance` creation out of `compileModuleImpl()` (PR #134887)

2025-04-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/134887 >From a41ba702f42671f7e9c51c29a846a6c7c7324378 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 7 Apr 2025 13:30:28 -0700 Subject: [PATCH 1/7] [clang] Extract `CompilerInstance` creation out of `compi

[clang] [NFC][Clang] Don't check hardcode op num (PR #135375)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jinsong Ji (jsji) Changes The num will change for any downstream customization. --- Full diff: https://github.com/llvm/llvm-project/pull/135375.diff 1 Files Affected: - (modified) clang/test/Modules/no-external-type-id.cppm (+1-1) `

[clang] 5a41fc2 - [clang][modules] Name the module map files on PCM file conflict (#134475)

2025-04-11 Thread via cfe-commits
Author: Jan Svoboda Date: 2025-04-11T08:20:12-07:00 New Revision: 5a41fc28f3b3f32a70fd5d81c2e33d10b3225806 URL: https://github.com/llvm/llvm-project/commit/5a41fc28f3b3f32a70fd5d81c2e33d10b3225806 DIFF: https://github.com/llvm/llvm-project/commit/5a41fc28f3b3f32a70fd5d81c2e33d10b3225806.diff L

[clang] [clang] Reject character devices in #embed for now (PR #135370)

2025-04-11 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/135370 >From 49e347a73709661fcf3a4805f38cfa2d78e3a196 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Fri, 11 Apr 2025 06:46:00 -0700 Subject: [PATCH 1/4] [clang] Reject character devices in #embed for

[clang] [clang] fix unresolved dependent template specialization mangling (PR #135111)

2025-04-11 Thread via cfe-commits
asmok-g wrote: Heads-up: We're seeing a clang crash after this commit that is not reproducible in the patch before. working on a repro https://github.com/llvm/llvm-project/pull/135111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [clang] Reject character devices in #embed for now (PR #135370)

2025-04-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM assuming precommit CI comes back green. Thank you! https://github.com/llvm/llvm-project/pull/135370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
@@ -494,4 +554,75 @@ void UseTrailingReturnTypeCheck::check(const MatchFinder::MatchResult &Result) { << FixItHint::CreateInsertion(InsertionLoc, " -> " + ReturnType); } +void UseTrailingReturnTypeCheck::diagOnLambda( +const LambdaExpr *Lambda, +const ast_matche

[clang] Suppress errors from well-formed-testing type traits in SFINAE contexts (PR #135390)

2025-04-11 Thread Aaron Puchert via cfe-commits
aaronpuchert wrote: The tests would produce without the change: ``` error: 'expected-error' diagnostics seen but not expected: File clang/test/SemaCXX/type-traits.cpp Line 2676: calling a private constructor of class 'AllPrivate' File clang/test/SemaCXX/type-traits.cpp Line 2833: 'operator='

[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

2025-04-11 Thread via cfe-commits
MillePlateaux wrote: Since adding this modification, I passed the local test, and there was no response when using command``clang -cc1 -fsyntax-only -verify -Wno-error`` , but I don’t know why there was an error after submitting. https://github.com/llvm/llvm-project/pull/134465 ___

[clang] Suppress errors from well-formed-testing type traits in SFINAE contexts (PR #135390)

2025-04-11 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert updated https://github.com/llvm/llvm-project/pull/135390 >From a1eda3b0d5b54ffc3d3ad4288d1d7685f6486143 Mon Sep 17 00:00:00 2001 From: Aaron Puchert Date: Fri, 11 Apr 2025 13:47:02 +0200 Subject: [PATCH] Suppress errors from well-formed-testing type traits in SF

[clang] Suppress errors from well-formed-testing type traits in SFINAE contexts (PR #135390)

2025-04-11 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert edited https://github.com/llvm/llvm-project/pull/135390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Don't check hardcode op num (PR #135375)

2025-04-11 Thread Mészáros Gergely via cfe-commits
https://github.com/Maetveis approved this pull request. https://github.com/llvm/llvm-project/pull/135375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle default template arguments for alias CTAD guides (PR #134807)

2025-04-11 Thread Matheus Izvekov via cfe-commits
@@ -690,6 +690,23 @@ SmallVector TemplateParamsReferencedInTemplateArgumentList( SemaRef.MarkUsedTemplateParameters( DeducedArgs, TemplateParamsList->getDepth(), ReferencedTemplateParams); + auto MarkDefaultArgs = [&](auto *Param) { +if (!Param || !Param->hasDefa

[clang] [flang] [driver] Generalize the code that adds the path of libflang_rt.runtime.a. (PR #134362)

2025-04-11 Thread Daniel Chen via cfe-commits
@@ -7,35 +7,100 @@ !! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use !! resource_dir_with_per_target_subdir as inputs. -! Check powerpc64-ibm-aix 64-bit linking to static flang-rt -! RUN: %flang %s -### 2>&1 \ +! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by defaul

[clang] [flang] [driver] Generalize the code that adds the path of libflang_rt.runtime.a. (PR #134362)

2025-04-11 Thread Daniel Chen via cfe-commits
@@ -7,35 +7,100 @@ !! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use !! resource_dir_with_per_target_subdir as inputs. -! Check powerpc64-ibm-aix 64-bit linking to static flang-rt -! RUN: %flang %s -### 2>&1 \ +! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by defaul

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor converted_to_draft https://github.com/llvm/llvm-project/pull/135383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement `-dump-minimization-hints` flag. (PR #133910)

2025-04-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/7502 Here is the relevan

[clang] [C23] Fix failed assertions with invalid #embed parameters (PR #135368)

2025-04-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/135368 If the invalid parameter was not the last parameter given, we would fail to skip to the end of the directive and trip a failed assertion. Fixes #126940 >From f7191e135ef4d2824b63009484571ae37bac2762 Mon S

[clang] [flang] [driver] Generalize the code that adds the path of libflang_rt.runtime.a. (PR #134362)

2025-04-11 Thread Slava Zakharin via cfe-commits
@@ -7,35 +7,100 @@ !! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use !! resource_dir_with_per_target_subdir as inputs. -! Check powerpc64-ibm-aix 64-bit linking to static flang-rt -! RUN: %flang %s -### 2>&1 \ +! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by defaul

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
vbvictor wrote: Converted to draft to fix windows compilation https://github.com/llvm/llvm-project/pull/135383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #131838)

2025-04-11 Thread via cfe-commits
@@ -4528,6 +4528,115 @@ void CodeGenFunction::EmitOMPMasterDirective(const OMPMasterDirective &S) { emitMaster(*this, S); } +static Expr *getInitialExprFromCapturedExpr(Expr *Cond) { + + Expr *SubExpr = Cond->IgnoreParenImpCasts(); + + if (auto *DeclRef = dyn_cast(SubExpr

[clang] 8d2f091 - [clang] Extract `CompilerInstance` creation out of `compileModuleImpl()` (#134887)

2025-04-11 Thread via cfe-commits
Author: Jan Svoboda Date: 2025-04-11T09:39:22-07:00 New Revision: 8d2f0911ce8dddb37d064b3065b3be71e3233c2c URL: https://github.com/llvm/llvm-project/commit/8d2f0911ce8dddb37d064b3065b3be71e3233c2c DIFF: https://github.com/llvm/llvm-project/commit/8d2f0911ce8dddb37d064b3065b3be71e3233c2c.diff L

[clang] [clang] fix unresolved dependent template specialization mangling (PR #135111)

2025-04-11 Thread via cfe-commits
asmok-g wrote: Note: only reproducible with modules https://github.com/llvm/llvm-project/pull/135111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Extract `CompilerInstance` creation out of `compileModuleImpl()` (PR #134887)

2025-04-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/134887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #131838)

2025-04-11 Thread via cfe-commits
https://github.com/SunilKuravinakop edited https://github.com/llvm/llvm-project/pull/131838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #131838)

2025-04-11 Thread via cfe-commits
https://github.com/SunilKuravinakop edited https://github.com/llvm/llvm-project/pull/131838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream binary assignments and comma (PR #135115)

2025-04-11 Thread Morris Hafner via cfe-commits
@@ -219,6 +219,13 @@ void CIRGenFunction::emitStoreOfScalar(mlir::Value value, Address addr, assert(!cir::MissingFeatures::opTBAA()); } +void CIRGenFunction::emitStoreThroughBitfieldLValue(RValue src, LValue dst, +mlir::Va

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix AS of globals and set the default AS to 4 (PR #135251)

2025-04-11 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/135251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix AS of globals and set the default AS to 4 (PR #135251)

2025-04-11 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/135251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ARM] Only try to redefine builtins for non-CUDA (PR #128222)

2025-04-11 Thread Nick Sarnie via cfe-commits
@@ -27,6 +27,8 @@ extern "C" { #endif +#if !defined(__CUDA_ARCH__) + sarnex wrote: @rnk Ping on this, thx! https://github.com/llvm/llvm-project/pull/128222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [MS][clang] Make sure vector deleting dtor calls correct operator delete (PR #133950)

2025-04-11 Thread Devon Loehr via cfe-commits
DKLoehr wrote: Thanks! Unfortunately it looks like the fix introduced a regression of #134265 on Windows. Repro: ``` struct Base { virtual ~Base(); void operator delete[](void *) = delete; }; class __declspec(dllexport) Derived : Base {}; ``` Running `clang-cl repro.cc /std:c++20` results in

[clang] [clang] Do not diagnose unused deleted operator delete[] (PR #134357)

2025-04-11 Thread Hans Wennborg via cfe-commits
zmodem wrote: We're seeing crashes that bisect to this change. Here is a reproducer: https://crbug.com/410001969#comment3 I'll see if I can get something more reduced as well. https://github.com/llvm/llvm-project/pull/134357 ___ cfe-commits mailing l

[clang] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV-like ABIs (PR #135230)

2025-04-11 Thread Eli Friedman via cfe-commits
@@ -2595,6 +2595,14 @@ GetX86_64ByValArgumentPair(llvm::Type *Lo, llvm::Type *Hi, ABIArgInfo X86_64ABIInfo:: classifyReturnType(QualType RetTy) const { + // return int128 as i128 + if (const BuiltinType *BT = RetTy->getAs()) { +BuiltinType::Kind k = BT->getKind(); +

[clang] [clang] Extract `CompilerInstance` creation out of `compileModuleImpl()` (PR #134887)

2025-04-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/14360 Here is the relevant piece of the build lo

[clang] [Interp] Mark inline-virtual.cpp as unsupported with ASan (PR #135402)

2025-04-11 Thread Thurston Dang via cfe-commits
https://github.com/thurstond created https://github.com/llvm/llvm-project/pull/135402 See https://github.com/llvm/llvm-project/issues/135401 for full flakiness report. It fails on stage2/asan_ubsan check with: ``` + /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/clang-rep

[clang] [Interp] Mark inline-virtual.cpp as unsupported with ASan (PR #135402)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Thurston Dang (thurstond) Changes See https://github.com/llvm/llvm-project/issues/135401 for full flakiness report. It fails on stage2/asan_ubsan check with: ``` + /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/bin/clang

[clang] [clang][driver] Suppress gnu-line-marker when saving temps (PR #134621)

2025-04-11 Thread Fangrui Song via cfe-commits
MaskRay wrote: I don't, but I wonder what's the GCC behavior. It seems to suppress the diagnostic when processing a .i file. https://github.com/llvm/llvm-project/pull/134621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix AS of globals and set the default AS to 4 (PR #135251)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nick Sarnie (sarnex) Changes Based on feedback from https://github.com/llvm/llvm-project/pull/134399, we use the address space map that sets the default AS to 4 for OpenMP SPIR-V offload. The new AS map had the wrong target AS for `opencl

[clang] [llvm] Case handling MachineOperandType address of a global value in SIFoldOperands (PR #135404)

2025-04-11 Thread Akhilesh Moorthy via cfe-commits
https://github.com/isakhilesh created https://github.com/llvm/llvm-project/pull/135404 While `FoldingImmLike` accepts `MO_Immediate`, `MO_FrameIndex` and `MO_GlobalAddress`, the conditional block after it only covers the first 2, so I have added a case for the global value as well. >From 116

[clang] [llvm] Case handling MachineOperandType address of a global value in SIFoldOperands (PR #135404)

2025-04-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] Case handling MachineOperandType address of a global value in SIFoldOperands (PR #135404)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Akhilesh Moorthy (isakhilesh) Changes While `FoldingImmLike` accepts `MO_Immediate`, `MO_FrameIndex` and `MO_GlobalAddress`, the conditional block after it only covers the first 2, so I have added a case for the global value as well. --

[clang] [clang][frontend] Expose `CompilerInstance::cloneForModuleCompile()` (PR #135405)

2025-04-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/135405 This PR exposes `cloneForModuleCompile()` as a public `CompilerInstance` member function. This will be eventually used in the dependency scanner to customize implicit module builds. >From 4b0c9ddf692da1d1

[clang] [clang][frontend] Expose `CompilerInstance::cloneForModuleCompile()` (PR #135405)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes This PR exposes `cloneForModuleCompile()` as a public `CompilerInstance` member function. This will be eventually used in the dependency scanner to customize implicit module builds. --- Full diff: https

[clang] Disable -fdollars-in-identifiers by default (PR #135407)

2025-04-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/135407 Clang used to enable -fdollars-in-identifiers by default for compatibility with GCC. However, this is no longer a conforming extension after WG21 P2558R2 and WG14 N2701. So this disables the dialect by de

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

2025-04-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/135027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d995b2e - [Clang][AMDGPU] Accept builtins in lambda declarations (#135027)

2025-04-11 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2025-04-11T19:11:46+02:00 New Revision: d995b2ebdc1a312c8583351c13dac90e8e320a09 URL: https://github.com/llvm/llvm-project/commit/d995b2ebdc1a312c8583351c13dac90e8e320a09 DIFF: https://github.com/llvm/llvm-project/commit/d995b2ebdc1a312c8583351c13dac90

[clang] [clang] Extract `CompilerInstance` creation out of `compileModuleImpl()` (PR #134887)

2025-04-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/14412 Here is the relevant piece of

[clang] Disable -fdollars-in-identifiers by default (PR #135407)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Clang used to enable -fdollars-in-identifiers by default for compatibility with GCC. However, this is no longer a conforming extension after WG21 P2558R2 and WG14 N2701. So this disables the dialect b

[clang] [MS][clang] Make sure vector deleting dtor calls correct operator delete (PR #133950)

2025-04-11 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Yeah, but this is kind of expected. Otherwise it is unclear how to emit vector deleting destructor body. Should we fallback to calling something, like MSVC does? See https://github.com/llvm/llvm-project/pull/135041#issuecomment-2790227622 for example. https://github.com/llvm

[clang] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Valentin Clement バレンタイン クレメン via cfe-commits
clementval wrote: > Clang/Flang disagree whether 'seq' and 'self' can appear on the same > serial-loop construct. I see no prose to support this? `seq` and `self` are not in the same set for `serial loop` and seems to be accepted. https://godbolt.org/z/dzdoE3xKr https://github.com/llvm/llvm

[clang] 566c30e - [CIR] Upstream binary assignments and comma (#135115)

2025-04-11 Thread via cfe-commits
Author: Morris Hafner Date: 2025-04-11T10:26:29-07:00 New Revision: 566c30e324a0e87269fc72e5a0219d4c3e1d9fbf URL: https://github.com/llvm/llvm-project/commit/566c30e324a0e87269fc72e5a0219d4c3e1d9fbf DIFF: https://github.com/llvm/llvm-project/commit/566c30e324a0e87269fc72e5a0219d4c3e1d9fbf.diff

[clang] [CIR] Upstream binary assignments and comma (PR #135115)

2025-04-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/135115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/135383 >From 4a7cdb4a9f4de5503eba1488306e238b7334912a Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 11 Apr 2025 20:26:49 +0300 Subject: [PATCH] [clang-tidy] add support for lambdas in use-trailing-return-t

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/135383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Clang/Flang disagree whether 'seq' and 'self' can appear on the same > > serial-loop construct. I see no prose to support this? > > `seq` and `self` are not in the same set for `serial loop` and seems to be > accepted. https://godbolt.org/z/dzdoE3xKr This one seems to be

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-04-11 Thread Luke Lau via cfe-commits
https://github.com/lukel97 approved this pull request. Thanks, LGTM. Though this is a part of the code that I'm not familiar with so probably best to wait for another LGTM https://github.com/llvm/llvm-project/pull/135163 ___ cfe-commits mailing list c

[clang] [llvm] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
erichkeane wrote: Note tablegen changes undid the 'dealiasing' that we were doing in the manual conversion between types, so many more tests will fail. Working now to add dealiasing to these functions. https://github.com/llvm/llvm-project/pull/135372 __

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor ready_for_review https://github.com/llvm/llvm-project/pull/135383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Case handling MachineOperandType address of a global value in SIFoldOperands (PR #135404)

2025-04-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Akhilesh Moorthy (isakhilesh) Changes While `FoldingImmLike` accepts `MO_Immediate`, `MO_FrameIndex` and `MO_GlobalAddress`, the conditional block after it only covers the first 2, so I have added a case for the global value as w

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-11 Thread Baranov Victor via cfe-commits
@@ -494,4 +554,75 @@ void UseTrailingReturnTypeCheck::check(const MatchFinder::MatchResult &Result) { << FixItHint::CreateInsertion(InsertionLoc, " -> " + ReturnType); } +void UseTrailingReturnTypeCheck::diagOnLambda( +const LambdaExpr *Lambda, +const ast_matche

[clang] de5b099 - [-Wunsafe-buffer-usage][NFC] Factor out FixitUtil (#135100)

2025-04-11 Thread via cfe-commits
Author: Jan Korous Date: 2025-04-11T10:47:52-07:00 New Revision: de5b099dd1542deee821b1dcfcb1762e683c672c URL: https://github.com/llvm/llvm-project/commit/de5b099dd1542deee821b1dcfcb1762e683c672c DIFF: https://github.com/llvm/llvm-project/commit/de5b099dd1542deee821b1dcfcb1762e683c672c.diff LO

[clang] [-Wunsafe-buffer-usage][NFC] Factor out FixitUtil (PR #135100)

2025-04-11 Thread Jan Korous via cfe-commits
https://github.com/jkorous-apple closed https://github.com/llvm/llvm-project/pull/135100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

2025-04-11 Thread Aaron Ballman via cfe-commits
@@ -717,6 +717,12 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr &MTA) { return false; } + if (const FunctionDecl *CalleeDecl = CE->getDirectCallee(); + CalleeDecl && CalleeDecl->hasAttr()) { +Diag(St->getBeginLoc(), diag::err_musttail_mismatch) <<

[clang] [clang][modules] Name the module map files on PCM file conflict (PR #134475)

2025-04-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/134475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support '-fmodule-file-home-is-cwd' for C++ modules. (PR #135147)

2025-04-11 Thread Michael Park via cfe-commits
mpark wrote: Synced with @ChuanqiXu9 offline about this. Summarizing the discussion so far: - There are some high-level concerns about the ecosystem, header units specifically. The complexity of the Clang interface and lack of support for header units. - At Meta we are starting to use header un

[clang] abe3b90 - [CIR] Fix warnings, again! (#135284)

2025-04-11 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-04-11T10:57:08-07:00 New Revision: abe3b90b3fa49829a165f2174191c33542597052 URL: https://github.com/llvm/llvm-project/commit/abe3b90b3fa49829a165f2174191c33542597052 DIFF: https://github.com/llvm/llvm-project/commit/abe3b90b3fa49829a165f2174191c33542597052.diff L

[clang] [CIR] Fix warnings, again! (PR #135284)

2025-04-11 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/135284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] implement printing of canonical template arguments of expression kind (PR #135133)

2025-04-11 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Sure, but I'd have to resist the urge to fix them, so that they can end up as test cases. They probably wouldn't survive long either way. For example, I grepped the source tree for diagnostics where we are emitting 'type-parameter-X-X', and where this is happening not because t

[clang] [clang] Reject character devices in #embed for now (PR #135370)

2025-04-11 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: I'm not sure what to say in the release note. Sorry folks, we never really supported these but now we reject to be safe? https://github.com/llvm/llvm-project/pull/135370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] Disable -fdollars-in-identifiers by default (PR #135407)

2025-04-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/135407 >From c7e0132617ab01c12b393876b39381171996b793 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Fri, 11 Apr 2025 13:03:07 -0400 Subject: [PATCH 1/2] Disable -fdollars-in-identifiers by default Clang used

[clang] [HLSL] Resource initialization by constructors (PR #135120)

2025-04-11 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/135120 >From 85001dcbc184491dfb24e9d2a39df46fd4c9a363 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 9 Apr 2025 18:17:26 -0700 Subject: [PATCH 1/4] Initialize resources by constructors - add resource record con

[clang] [llvm] [clang][NVPTX] Add builtins and intrinsics for conversions of new FP types (PR #134345)

2025-04-11 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM in general, with an intrinsic naming nit. https://github.com/llvm/llvm-project/pull/134345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

<    1   2   3   4   5   >