[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang-codegen Author: Mariya Podchishchaeva (Fznamznon) Changes Whereas it is UB in terms of the standard to delete an array of objects via pointer whose static type doesn't match its dynamic type, MSVC supports an extens

[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

2025-02-07 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/126240 >From 04636bea1b873805af02dea865637d7125cee1e5 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Thu, 12 Dec 2024 08:57:37 -0800 Subject: [PATCH 1/2] [MS][clang] Add support for vector deleting des

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread David CARLIER via cfe-commits
https://github.com/devnexen updated https://github.com/llvm/llvm-project/pull/125389 >From e40672e8137c0546b1604795901ccea8b15f7932 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Sun, 2 Feb 2025 09:36:50 + Subject: [PATCH 1/3] [compiler-rt][rtsan] porting the sanitizer to FreeBSD. Most

[clang] [flang] [lld] [Flang] Optionally do not compile the runtime in-tree (PR #122336)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Makes sense, should be fine to transition since we just hit a release milestone. https://github.com/llvm/llvm-project/pull/122336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] a69975d - [clang][bytecode] Remove unnecessary if statement (#126223)

2025-02-07 Thread via cfe-commits
Author: Timm Baeder Date: 2025-02-07T14:24:15+01:00 New Revision: a69975d8349c1e0dcb86814df67d7160395b468e URL: https://github.com/llvm/llvm-project/commit/a69975d8349c1e0dcb86814df67d7160395b468e DIFF: https://github.com/llvm/llvm-project/commit/a69975d8349c1e0dcb86814df67d7160395b468e.diff L

[clang] [clang][bytecode] Remove unnecessary if statement (PR #126223)

2025-02-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/126223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-07 Thread via cfe-commits
nataraj-hates-MS-for-stealing-github wrote: Reported `%p` problem in https://github.com/llvm/llvm-project/issues/126242 issue. In order it will not be lost and forgotten... https://github.com/llvm/llvm-project/pull/123963 ___ cfe-commits mailing list

[clang] [Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP. (PR #126186)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/126186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2a6cfbd - [clang] [test] Adjust XFAILs for windows in unique_object_duplication.cpp (#126139)

2025-02-07 Thread via cfe-commits
Author: Martin Storsjö Date: 2025-02-07T15:30:29+02:00 New Revision: 2a6cfbd98516d902267a39e26ecbbff8c8121b01 URL: https://github.com/llvm/llvm-project/commit/2a6cfbd98516d902267a39e26ecbbff8c8121b01 DIFF: https://github.com/llvm/llvm-project/commit/2a6cfbd98516d902267a39e26ecbbff8c8121b01.diff

[clang] [clang] [test] Adjust XFAILs for windows in unique_object_duplication.cpp (PR #126139)

2025-02-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/126139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/126248 Summary: This patch handles the use of `-Xarch_ -Wl,foo` to send an argument to the linker for the embedded offloading jobs in the linker wrapper. This makes it equivalent to `-Xoffload-linker foo`. >From 10727

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > We already have a host-side `libomptarget`: > > https://github.com/llvm/llvm-project/blob/cfd8980fe79872feb9ed81959aa018681c7b3354/offload/src/CMakeLists.txt#L9 We can have conflicting names since they're in separate install directories. I'd like this to have a more 'standard'

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: This patch handles the use of `-Xarch_ -Wl,foo` to send an argument to the linker for the embedded offloading jobs in the linker wrapper. This makes it equivalent to `-Xoffload-linker foo

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: This patch handles the use of `-Xarch_ -Wl,foo` to send an argument to the linker for the embedded offloading jobs in the linker wrapper. This makes it equivalent to `-Xoffload-linker foo`. --

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126248 >From 10727e968d69bc3f0848a1cbbd0f3e5012b09d5f Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 7 Feb 2025 08:31:08 -0600 Subject: [PATCH 1/2] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains Summary

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2025-02-07 Thread Guillot Tony via cfe-commits
https://github.com/to268 updated https://github.com/llvm/llvm-project/pull/79845 >From 7132c5d853fafb3e956c89b190313bf25ef1c773 Mon Sep 17 00:00:00 2001 From: Guillot Tony Date: Thu, 30 Jan 2025 01:12:13 +0100 Subject: [PATCH] N3006 base --- clang/docs/ReleaseNotes.rst | 2 +

[clang] [analyzer] Remove some false negatives in StackAddrEscapeChecker (PR #125638)

2025-02-07 Thread Gábor Horváth via cfe-commits
@@ -912,3 +924,33 @@ void top_malloc_no_crash_fn() { free(pptr); } } // namespace alloca_region_pointer + +namespace true_negatives_return_expressions { +struct Container { int *x; }; + +int test2() { + int x = 14; Xazax-hun wrote: Could you add an example

[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

2025-02-07 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/126240 Whereas it is UB in terms of the standard to delete an array of objects via pointer whose static type doesn't match its dynamic type, MSVC supports an extension allowing to do it. Aside from array deletion no

[clang] [Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP. (PR #126186)

2025-02-07 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 updated https://github.com/llvm/llvm-project/pull/126186 >From 43433affa692b2690bc3dbb738ab5c76811e68e8 Mon Sep 17 00:00:00 2001 From: Amit Pandey Date: Fri, 7 Feb 2025 12:11:23 +0530 Subject: [PATCH] [Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP.

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I'm not sure if calling it `libomp.a` is a good idea. I personally find it > confusing because "libomp" is already an established name—it refers to the > OpenMP host runtime contributed by Intel, just as "libgomp" is the OpenMP > host runtime for GCC. These names are well-reco

[clang] [BoundsSafety][doc] Add a missing newline in C snippet (PR #126245)

2025-02-07 Thread Piotr Fusik via cfe-commits
https://github.com/pfusik updated https://github.com/llvm/llvm-project/pull/126245 >From 666c1d15556579707c1ebce07ed2774fe13437ec Mon Sep 17 00:00:00 2001 From: Piotr Fusik Date: Fri, 7 Feb 2025 14:58:34 +0100 Subject: [PATCH 1/2] [BoundsSafety][doc] Add a missing newline in C snippet --- cla

[clang] [BoundsSafety][doc] Fix a typo (PR #126247)

2025-02-07 Thread Piotr Fusik via cfe-commits
https://github.com/pfusik created https://github.com/llvm/llvm-project/pull/126247 None >From 7aa0008aafc776941151dec16f52725b8958e730 Mon Sep 17 00:00:00 2001 From: Piotr Fusik Date: Fri, 7 Feb 2025 15:19:11 +0100 Subject: [PATCH] [BoundsSafety][doc] Fix a typo --- clang/docs/BoundsSafety.r

[clang] [BoundsSafety][doc] Fix a typo (PR #126247)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Piotr Fusik (pfusik) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126247.diff 2 Files Affected: - (modified) clang/docs/BoundsSafety.rst (+3-3) - (modified) clang/docs/BoundsSafetyImplPlans.rst (+1-1) ``

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Michael Kruse via cfe-commits
Meinersbur wrote: We already have a host-side `libomptarget`: https://github.com/llvm/llvm-project/blob/cfd8980fe79872feb9ed81959aa018681c7b3354/offload/src/CMakeLists.txt#L9 https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread David CARLIER via cfe-commits
@@ -43,6 +44,21 @@ static __rtsan::Context &GetContextForThisThreadImpl() { return *current_thread_context; } +#else + +// On FreeBSD, pthread api cannot be used as calloc is called under the hood +// at library initialization time. devnexen wrote: So I kno

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread David CARLIER via cfe-commits
https://github.com/devnexen edited https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: None (chrisPyr) Changes #125983 --- Patch is 216.27 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/126243.diff 128 Files Affected: - (modified) bolt/lib/Core/BinaryContext.cpp (+4-

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-bolt @llvm/pr-subscribers-clang Author: None (chrisPyr) Changes #125983 --- Patch is 216.27 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/126243.diff 128 Files Affected: - (modified) bolt/lib/Core/Binar

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126143 >From cda46da874a083ea89bd9bb31616806b0dab7692 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 6 Feb 2025 15:54:19 -0600 Subject: [PATCH 1/2] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use

[clang] [Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP. (PR #126186)

2025-02-07 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/126186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BoundsSafety][doc] Add a missing newline in C snippet (PR #126245)

2025-02-07 Thread Piotr Fusik via cfe-commits
https://github.com/pfusik created https://github.com/llvm/llvm-project/pull/126245 None >From 666c1d15556579707c1ebce07ed2774fe13437ec Mon Sep 17 00:00:00 2001 From: Piotr Fusik Date: Fri, 7 Feb 2025 14:58:34 +0100 Subject: [PATCH] [BoundsSafety][doc] Add a missing newline in C snippet --- c

[clang] [BoundsSafety][doc] Add a missing newline in C snippet (PR #126245)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Piotr Fusik (pfusik) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126245.diff 1 Files Affected: - (modified) clang/docs/BoundsSafety.rst (+3-2) ``diff diff --git a/clang/docs/BoundsSafety.rst b/clang/docs

[clang] [BoundsSafety][doc] Fix formatting (PR #126245)

2025-02-07 Thread Piotr Fusik via cfe-commits
https://github.com/pfusik edited https://github.com/llvm/llvm-project/pull/126245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [profile] Add a clang option -fprofile-continuous that enables continuous instrumentation profiling mode (PR #124353)

2025-02-07 Thread Wael Yehia via cfe-commits
w2yehia wrote: Thank you to the reviewers. I'll merge this tonight if I get no further feedback. https://github.com/llvm/llvm-project/pull/124353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #125706)

2025-02-07 Thread Brox Chen via cfe-commits
broxigarchen wrote: > Same suggestion as in [#119750 > (comment)](https://github.com/llvm/llvm-project/pull/119750#discussion_r1941297212). I see. I think this is better to be done seperately https://github.com/llvm/llvm-project/pull/125706 ___ cfe-c

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #125706)

2025-02-07 Thread Brox Chen via cfe-commits
https://github.com/broxigarchen closed https://github.com/llvm/llvm-project/pull/125706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9203,7 +9203,9 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, ArgStringList CompilerArgs; ArgStringList LinkerArgs; for (Arg *A : C.getArgsForToolChain(TC, /*BoundArch=*/"", Kind)) { -if (ShouldForward(CompilerOptions, A)

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Rahul Joshi via cfe-commits
jurahul wrote: I understand this is mostly mechanical changes, but wondering if review wise it will help if its split up into 4-5 PRs. For example, bolt, clang, flag, llvm, mlir etc. https://github.com/llvm/llvm-project/pull/126243 ___ cfe-commits ma

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-02-07 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping https://github.com/llvm/llvm-project/pull/121291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] combine typedef records if the underlying type's name is underscored (PR #125964)

2025-02-07 Thread via cfe-commits
@@ -1146,11 +1146,29 @@ bool ExtractAPIVisitorBase::VisitTypedefNameDecl( StringRef Name = Decl->getName(); + auto nameMatches = [&Name](TagDecl *TagDecl) { +StringRef TagName = TagDecl->getName(); + +if (TagName == Name) + return true; + +// Also check w

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Saiyedul Islam via cfe-commits
saiislam wrote: > > We already have a host-side `libomptarget`: > > https://github.com/llvm/llvm-project/blob/cfd8980fe79872feb9ed81959aa018681c7b3354/offload/src/CMakeLists.txt#L9 > > We can have conflicting names since they're in separate install directories. > I'd like this to have a more 's

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Rahul Joshi via cfe-commits
jurahul wrote: Yeah, that’s why the description said most but not all. We should get link failures if one of these is made static. On Fri, Feb 7, 2025 at 7:17 AM Joseph Huber ***@***.***> wrote: > ***@***. commented on this pull request. > > This should definitely be split up. Also some opt

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > So I should do like open 5 branches and make a PR for each? > > As for the cases mentioned, when I tried compile all projects (compile with > -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and > I've fixed them all. Now all projects can be successfully

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Joseph Huber via cfe-commits
@@ -9203,7 +9203,9 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, ArgStringList CompilerArgs; ArgStringList LinkerArgs; for (Arg *A : C.getArgsForToolChain(TC, /*BoundArch=*/"", Kind)) { -if (ShouldForward(CompilerOptions, A)

[clang] [llvm] [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (PR #125880)

2025-02-07 Thread via cfe-commits
@@ -438,18 +445,28 @@ void llvm::PointerMayBeCaptured(const Value *V, CaptureTracker *Tracker, }; while (!Worklist.empty()) { const Use *U = Worklist.pop_back_val(); -switch (DetermineUseCaptureKind(*U, IsDereferenceableOrNull)) { -case UseCaptureKind::NO_CAPTU

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

2025-02-07 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM > I don't know if directly using the CodeGenModule here is the best solution. > Let me know if there's something better to use. I think that's ok. The alternative would be Builder.getContext(). https://github.com/llvm/llvm-project/pull

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

2025-02-07 Thread Nikita Popov via cfe-commits
nikic wrote: Well, I guess you could also use Builder.getPtrTy() for the whole thing... https://github.com/llvm/llvm-project/pull/124782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/126248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward `-Xarch_ -Wl,foo` for GPU toolchains (PR #126248)

2025-02-07 Thread Nick Sarnie via cfe-commits
@@ -9203,7 +9203,9 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, ArgStringList CompilerArgs; ArgStringList LinkerArgs; for (Arg *A : C.getArgsForToolChain(TC, /*BoundArch=*/"", Kind)) { -if (ShouldForward(CompilerOptions, A)

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-02-07 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping https://github.com/llvm/llvm-project/pull/122951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread via cfe-commits
chrisPyr wrote: So I should do like open 5 branches and make a PR for each? As for the cases mentioned, when I tried compile all projects (compile with -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and I've fixed them all. Now all projects can be successfully built, s

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126143 >From 4d325d66f9792235f4cdcbcc8b032a5498dcb407 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 6 Feb 2025 15:54:19 -0600 Subject: [PATCH] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use stat

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread via cfe-commits
chrisPyr wrote: OK, I'll do it. Except for checking it on CI, is there any other method I can test locally? E.g. what options should I add I've tried compile with all project enabled, I thought by that way all changes were already being tested. However, the CI failed, so it seems what I thought

[clang] Suppress reference to free variable errors (PR #126254)

2025-02-07 Thread Ron Gut via cfe-commits
https://github.com/gutron created https://github.com/llvm/llvm-project/pull/126254 vc-git-program is referenced but not defined -- vc-git provides the definition. >From 598b1c0df4991b1fb63b54dd358b40103912b80b Mon Sep 17 00:00:00 2001 From: Ron Gut <65685404+gut...@users.noreply.github.com> Dat

[clang] [llvm] [analyzer][NFC] Remove "V2" from ArrayBoundCheckerV2.cpp (PR #126094)

2025-02-07 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/126094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/126243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Suppress reference to free variable errors (PR #126254)

2025-02-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Ron Gut (gutron) Changes vc-git-program is referenced but not defined -- vc-git provides the definition. --- Full diff: https://github.com/llvm/llvm-project/pull/126254.diff 1 Files Affected: - (modified) clang/tools/clang-format

[clang] [llvm] [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (PR #125880)

2025-02-07 Thread via cfe-commits
@@ -438,18 +445,28 @@ void llvm::PointerMayBeCaptured(const Value *V, CaptureTracker *Tracker, }; while (!Worklist.empty()) { const Use *U = Worklist.pop_back_val(); -switch (DetermineUseCaptureKind(*U, IsDereferenceableOrNull)) { -case UseCaptureKind::NO_CAPTU

[clang] [llvm] [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF test again (PR #126142)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF test again (PR #126142)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement HLSL Elementwise casting (excluding splat cases); Re-land #118842 (PR #126258)

2025-02-07 Thread Sarah Spall via cfe-commits
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/126258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement HLSL Elementwise casting (excluding splat cases); Re-land (PR #126258)

2025-02-07 Thread Sarah Spall via cfe-commits
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/126258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF test again (PR #126142)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF test again (PR #126142)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF test again (PR #126142)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF test again (PR #126142)

2025-02-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/126142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/126243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: This should definitely be split up. Also some options are referenced in multiple places, i.e. ``` // foo.h extern cl::opt <...> // foo.cpp cl::opt <...> use opt //bar.cpp use opt. ``` https://github.com/llvm/llvm-project/pull/126243 __

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Should it be named as `liboffload` or `liboffload.devicertl`? I don't want `offload` since I think that should honestly be a separate library. I'll just call it `ompdevice` and be done with it. https://github.com/llvm/llvm-project/pull/126143 __

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

2025-02-07 Thread Mats Jun Larsen via cfe-commits
https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From f3bbd6f0db4109016d98fe15a2b086b491df2d93 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/2] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/126143 >From e3962f9bdab7de8682712857d7b284af2ac99fc3 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 6 Feb 2025 15:54:19 -0600 Subject: [PATCH] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use stat

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I figured that calling it `libomptarget` was fine because we already have `libomptarget-amdgpu.bc` so what's the big difference in `amdgcn-amd-amdhsa/libomptarget.a`. But I can change it. https://github.com/llvm/llvm-project/pull/126143 __

[clang] [llvm] [Clang][Driver] Add an option to control loop-interchange (PR #125830)

2025-02-07 Thread Ryotaro Kasuga via cfe-commits
kasuga-fj wrote: Thanks for the comments. I'll try to work on it in the near future. https://github.com/llvm/llvm-project/pull/125830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (PR #125880)

2025-02-07 Thread Nikita Popov via cfe-commits
@@ -438,18 +445,28 @@ void llvm::PointerMayBeCaptured(const Value *V, CaptureTracker *Tracker, }; while (!Worklist.empty()) { const Use *U = Worklist.pop_back_val(); -switch (DetermineUseCaptureKind(*U, IsDereferenceableOrNull)) { -case UseCaptureKind::NO_CAPTU

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

2025-02-07 Thread Mats Jun Larsen via cfe-commits
junlarsen wrote: I think I'll do that instead. Sounds a lot more reasonable in my opinion https://github.com/llvm/llvm-project/pull/124782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2025-02-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/120896 >From 295df258043ef5a87ae603eedd308b863bad7b59 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 22 Dec 2024 15:14:30 +0200 Subject: [PATCH 1/7] [Clang] allow restrict qualifier for array types with poin

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

2025-02-07 Thread Mats Jun Larsen via cfe-commits
https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From f3bbd6f0db4109016d98fe15a2b086b491df2d93 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/2] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Rahul Joshi via cfe-commits
jurahul wrote: You can check the CI logs for the exact command line it uses and replicate it locally. On Fri, Feb 7, 2025 at 7:46 AM chrisPyr ***@***.***> wrote: > OK, I'll do it. > Except for checking it on CI, is there any other method I can test > locally? E.g. what options should I add > I'

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Rahul Joshi via cfe-commits
jurahul wrote: @arsenm did you intent to approve it without splitting? Is this trivial enough to not need splitting as long as CI checks pass? https://github.com/llvm/llvm-project/pull/126243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] Suppress reference to free variable errors (PR #126254)

2025-02-07 Thread Ron Gut via cfe-commits
gutron wrote: @goldsteinn -- this is a follow-up to your commit 32be90d https://github.com/llvm/llvm-project/pull/126254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread Matt Arsenault via cfe-commits
arsenm wrote: I don't care about splitting or not; either way https://github.com/llvm/llvm-project/pull/126243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Suppress reference to free variable errors (PR #126254)

2025-02-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2025-02-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2025-02-07 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: @to268 and I spoke about this offline and we decided to close this PR because it's heading in the wrong direction. We discussed a different direction that focuses solely on implementing the logic to handle `%select{declaration using a deduced type|constexpr declaration}0 %1

[clang] Suppress reference to free variable errors (PR #126254)

2025-02-07 Thread via cfe-commits
https://github.com/goldsteinn approved this pull request. LGTM and Thank you. I'm going to slightly rename the commit message before merging to refer to the correct component. https://github.com/llvm/llvm-project/pull/126254 ___ cfe-commits mailing li

[clang] Suppress reference to free variable errors (PR #126254)

2025-02-07 Thread via cfe-commits
https://github.com/goldsteinn closed https://github.com/llvm/llvm-project/pull/126254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d017042 - [emacs][clang-format] Suppress reference to free variable errors (#126254)

2025-02-07 Thread via cfe-commits
Author: Ron Gut Date: 2025-02-07T11:04:24-05:00 New Revision: d0170424b7250bf5cda0e6253ec62112a6e1c92a URL: https://github.com/llvm/llvm-project/commit/d0170424b7250bf5cda0e6253ec62112a6e1c92a DIFF: https://github.com/llvm/llvm-project/commit/d0170424b7250bf5cda0e6253ec62112a6e1c92a.diff LOG:

[clang] Suppress reference to free variable errors (PR #126254)

2025-02-07 Thread via cfe-commits
github-actions[bot] wrote: @gutron Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [llvm] [DebugInfo] Update DIBuilder insertion to take InsertPosition (PR #126059)

2025-02-07 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse commented: This looks great, thanks for putting this all together, one nit inline, Is this intended to be cherry-picked into the release branch or not? Seeing how the original motivation was to ease downstream compatibilities, I'd assumed there'd be the need for somet

[clang] [clang] Lower non-builtin sincos[f|l] calls to llvm.sincos.* when -fno-math-errno is set (PR #121763)

2025-02-07 Thread Benjamin Maxwell via cfe-commits
MacDue wrote: Given it looks like #123787 won't be accepted (due to compile time regressions), I think we should restrict this lowering to AArch64 (and other supported targets) until there's a solution for targets without AA in codegen too. Does that seem reasonable? https://github.com/llvm

[clang] [llvm] [DebugInfo] Update DIBuilder insertion to take InsertPosition (PR #126059)

2025-02-07 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse edited https://github.com/llvm/llvm-project/pull/126059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > As for the cases mentioned, when I tried compile all projects (compile with > -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and > I've fixed them all. > Now all projects can be successfully built, so I think it should be fine? Just to explain why

[clang] [llvm] [DebugInfo] Update DIBuilder insertion to take InsertPosition (PR #126059)

2025-02-07 Thread Jeremy Morse via cfe-commits
@@ -1708,19 +1706,9 @@ static void insertDbgValueOrDbgVariableRecord(DIBuilder &Builder, Value *DV, static void insertDbgValueOrDbgVariableRecordAfter( DIBuilder &Builder, Value *DV, DILocalVariable *DIVar, DIExpression *DIExpr, -const DebugLoc &NewLoc, BasicBlock::i

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > You can check the CI logs for the exact command line it uses and replicate it > locally. Should be towards the start of the log, search for `cmake ` to find the command. https://github.com/llvm/llvm-project/pull/126243 ___ cfe-

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

2025-02-07 Thread Mats Jun Larsen via cfe-commits
https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124782 >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 01:29:01 +0900 Subject: [PATCH 1/2] [Clang][TableGen] Use PointerType::get(Context) in MVE

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

2025-02-07 Thread Mats Jun Larsen via cfe-commits
https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124782 >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 01:29:01 +0900 Subject: [PATCH 1/3] [Clang][TableGen] Use PointerType::get(Context) in MVE

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

2025-02-07 Thread Mats Jun Larsen via cfe-commits
https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From 13d65a0cc95fe53f959db343e5be07773ee53f28 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/2] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [llvm] [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (PR #125880)

2025-02-07 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/125880 >From 2f698e27ae61b91019544cc707c134e0aec9ecd3 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 30 Jan 2025 12:08:01 +0100 Subject: [PATCH 1/5] [CaptureTracking][FunctionAttrs] Add support for CaptureInfo

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

2025-02-07 Thread Mats Jun Larsen via cfe-commits
@@ -210,7 +210,7 @@ class PointerType : public Type { return Name + " *"; } std::string llvmName() const override { -return "llvm::PointerType::getUnqual(" + Pointee->llvmName() + ")"; +return "llvm::PointerType::getUnqual(Builder.getPtrTy())";

<    1   2   3   4   5   6   >