[clang] [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124391)

2025-01-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-24 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/119712 >From e2750ef68d3b6bbf879f0dd9eef8e4e4009eb3b6 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Thu, 12 Dec 2024 11:35:49 +0100 Subject: [PATCH] [clang] Extend diagnose_if to accept more detailed warning

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-24 Thread Nikolas Klauser via cfe-commits
@@ -551,10 +547,12 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, // as well as disabling all messages which are currently mapped to Warning // (whether by default or downgraded from Error via e.g. -Wno-error or #pragma // diagnostic.) + /

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-24 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/119712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-24 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 commented: > TBH I find it somewhat confusing to have a severity in `diagnose_if` and an > existing diagnostic group, which already has its own severity. Diagnostic groups don't have severity. Individual diagnostics have severity. This just exposes the same semant

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

2025-01-24 Thread Nikolas Klauser via cfe-commits
@@ -584,7 +582,9 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, const auto &SM = Diag.getSourceManager(); // Custom diagnostics always are emitted in system headers. philnik777 wrote: I don't think this comment adds much value

[clang] 9bb3c62 - [Flang][Driver] Deprecate Ofast (#101701)

2025-01-24 Thread via cfe-commits
Author: Kiran Chandramohan Date: 2025-01-24T10:18:14Z New Revision: 9bb3c62948d0c6dd3fb233186ae6a79744012b8f URL: https://github.com/llvm/llvm-project/commit/9bb3c62948d0c6dd3fb233186ae6a79744012b8f DIFF: https://github.com/llvm/llvm-project/commit/9bb3c62948d0c6dd3fb233186ae6a79744012b8f.diff

[clang] [llvm] [mlir] [TableGen] Only store direct superclasses in Record (PR #123072)

2025-01-24 Thread Jay Foad via cfe-commits
https://github.com/jayfoad updated https://github.com/llvm/llvm-project/pull/123072 >From f12511a0fd30c47ea08e6c126cae558215758183 Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Wed, 15 Jan 2025 13:34:41 + Subject: [PATCH 01/14] Change API of getSuperClasses --- llvm/include/llvm/TableGen/

[clang] [TySan] Add initial documentation for Type Sanitizer (PR #123595)

2025-01-24 Thread via cfe-commits
https://github.com/gbMattN updated https://github.com/llvm/llvm-project/pull/123595 >From 807c2c8be0517cbb1b9db890f48baeb6f226ba2f Mon Sep 17 00:00:00 2001 From: gbMattN Date: Mon, 20 Jan 2025 11:02:06 + Subject: [PATCH 01/11] [TySan] Add initial documentation --- clang/docs/TypeSanitizer

[clang] [llvm] [WIP][RISCV] Support for Zvabd fast-track proposal (PR #124239)

2025-01-24 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/124239 >From 2ce077b011a9dcac0f9649493a50819971695b73 Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Tue, 16 Jul 2024 16:08:16 +0800 Subject: [PATCH 1/2] [RISCV][MC] Support Zvabd instructions Support of these

[clang] [clang] improve suggested attribute location for scoped enums (PR #124122)

2025-01-24 Thread Timm Baeder via cfe-commits
tbaederr wrote: I do remember we already had this in https://github.com/llvm/llvm-project/issues/61660 - is that fix not suficcient for c++ style attributes? https://github.com/llvm/llvm-project/pull/124122 ___ cfe-commits mailing list cfe-commits@li

[clang] [clang] __STDC_NO_THREADS__ is no longer necessary for VS 2022 1939 and above (PR #117149)

2025-01-24 Thread Dipesh Sharma via cfe-commits
https://github.com/dipeshs809 updated https://github.com/llvm/llvm-project/pull/117149 >From 76a484f0e1419eb1b82d26a353fd3b2f238ac4ba Mon Sep 17 00:00:00 2001 From: dipeshs809 Date: Thu, 21 Nov 2024 17:48:22 +0530 Subject: [PATCH] [clang] guard __STDC_NO_THREADS__ defination for MSVCVersion 20

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-01-24 Thread Baranov Victor via cfe-commits
vbvictor wrote: Thank you everyone for the feedback! @PiotrZSL I tried using TK_IgnoreUnlessSpelledInSource with `cxxDependentScopeMemberExpr` ast-matcher but failed to write a working matcher case with nested template parameters: ```cpp template void TemplatePositiveTest() { std::unique_p

[clang] [clang][ASTImporter] Import explicit object parameter location (PR #124262)

2025-01-24 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/124262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features predres and ls64. (PR #124266)

2025-01-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Alexandros Lamprineas (labrinea) Changes These cannot be detected by reading the ID_AA64ISAR1_EL1 register since their corresponding bitfields are hidden. Additionally the instructions that these features enable are unusable fro

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-24 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan closed https://github.com/llvm/llvm-project/pull/101701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][ASan] Refactor Clang-Driver "Sanitizer Bitcode" linking. (PR #123922)

2025-01-24 Thread Matt Arsenault via cfe-commits
@@ -70,6 +70,10 @@ def err_drv_no_rocm_device_lib : Error< "cannot find ROCm device library%select{| for %1| for ABI version %1}0; provide its path via " "'--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to build " "without ROCm device library">; +def err_d

[clang] [clang-format] Fix a bug in annotating overloaded co_await decl (PR #124240)

2025-01-24 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/124240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e6030d3 - [clang][bytecode] Use std::allocator calls for Descriptor source (#123900)

2025-01-24 Thread via cfe-commits
Author: Timm Baeder Date: 2025-01-24T11:50:56+01:00 New Revision: e6030d389571b3f1b0f0c5a35b7fa45937ed0f6c URL: https://github.com/llvm/llvm-project/commit/e6030d389571b3f1b0f0c5a35b7fa45937ed0f6c DIFF: https://github.com/llvm/llvm-project/commit/e6030d389571b3f1b0f0c5a35b7fa45937ed0f6c.diff L

[clang] [llvm] [polly] [NFC][DebugInfo] Use iterator moveBefore at many call-sites (PR #123583)

2025-01-24 Thread Jeremy Morse via cfe-commits
jmorse wrote: If it's alright, I'll deal with the comment and different-arg-name matters in a follow up commit -- I've got rewrite those areas for deprecation anyway. Also force pushing a rebased commit because I don't trust what github will do with merging main into this. https://github.com/

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-01-24 Thread via cfe-commits
mydeveloperday wrote: > > This seems reasonable to me, but wait for the others, maybe @owenca > > I'm wondering if `-0` should turn off all informational messaging as well and > _only_ print the paths. As it is, it will print things like _Running > clang-format on the following files:_, even i

[clang] [llvm] [polly] [NFC][DebugInfo] Use iterator moveBefore at many call-sites (PR #123583)

2025-01-24 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse closed https://github.com/llvm/llvm-project/pull/123583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating overloaded co_await decl (PR #124240)

2025-01-24 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/124240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-01-24 Thread Björn Schäpers via cfe-commits
@@ -205,6 +205,12 @@ def main(): "commits" ), ) +p.add_argument( +"-0", +"--null", +action="store_true", +help="print the affected paths with null-terminated characters", HazardyKnusperkeks wrote: I t

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-01-24 Thread Thorsten Klein via cfe-commits
https://github.com/thorsten-klein created https://github.com/llvm/llvm-project/pull/124265 new option AllowNoNamespaceComments for `google-readability-namespace-comments.AllowNoNamespaceComments` is added. Ref: #124264 When true, the check will allow that no namespace comment is present. If a

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-01-24 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-01-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Thorsten Klein (thorsten-klein) Changes new option AllowNoNamespaceComments for `google-readability-namespace-comments.AllowNoNamespaceComments` is added. Ref: #124264 When true, the check will allow that no namespace comment is pre

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features predres and ls64. (PR #124266)

2025-01-24 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/124266 These cannot be detected by reading the ID_AA64ISAR1_EL1 register since their corresponding bitfields are hidden. Additionally the instructions that these features enable are unusable from EL0. ACLE: https://

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features predres and ls64. (PR #124266)

2025-01-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes These cannot be detected by reading the ID_AA64ISAR1_EL1 register since their corresponding bitfields are hidden. Additionally the instructions that these features enable are unusable from EL0. AC

[clang] [clang][ASTImporter] Import explicit object parameter location (PR #124262)

2025-01-24 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/124262 >From ff885745df0d4842dd4c541ec5e3c6cbb557f6a5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 24 Jan 2025 11:59:42 + Subject: [PATCH 1/2] [clang][ASTImporter] Import explicit object parameter loc

[clang] [clang][ASTImporter] Import explicit object parameter location (PR #124262)

2025-01-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 625e0a40f1a97d181a4641f604495b6aea433bd8 1a3ddf5830a3405d35c2b2848fdc5c9cb67fdb5b --e

[clang] [clang][ASTImporter] Import explicit object parameter location (PR #124262)

2025-01-24 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/124262 Make sure to import the explicit object parameter location for `ParmVarDecl`s. This is how Clang determines whether a parameter `isExplicitObjectParamater`. This will be needed to enable expression evaluatio

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-24 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the fix! The changes look correct to me, but I added the CFG and Analysis maintainers to give a final sign-off. Can you also add something to `clang/docs/ReleaseNotes.rst` so users know about the fix? https://github.com/llvm/llvm-project

[clang] [clang][Sema] Fix initialization of `NonTypeTemplateParmDecl`... (PR #121768)

2025-01-24 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/121768 From da2bbf99b8430d8b6aa6bf7969c9825b4d94219b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Mon, 18 Nov 2024 11:36:03 +0100 Subject: [PATCH 1/7] [

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-01-24 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > > That's how this already works in this patch: > > > > AH! I missed that this was doing that. Awesome! Though I think the > > > > 'no' flag is the one that makes sense in a "turn it on for all BUT > > > > these". The flag as typed there isn't particularly useful (tha

[clang-tools-extra] bug fix for pp-trace (PR #124376)

2025-01-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: seekamoon (seekamoon) Changes When using `pp-trace` in practice, I noticed that the YAML files it generated could contain grammar errors, leading to failed parsing. Specifically, it is the `Args` of `MacroExpands`. E.g., ```

[clang-tools-extra] bug fix for pp-trace (PR #124376)

2025-01-24 Thread via cfe-commits
https://github.com/seekamoon created https://github.com/llvm/llvm-project/pull/124376 When using `pp-trace` in practice, I noticed that the YAML files it generated could contain grammar errors, leading to failed parsing. Specifically, it is the `Args` of `MacroExpands`. E.g., ```YAML - Callb

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `WaveActiveMax` intrinsic (PR #123428)

2025-01-24 Thread Finn Plummer via cfe-commits
@@ -0,0 +1,143 @@ +; RUN: opt -S -scalarizer -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library < %s | FileCheck %s + +; Test that for scalar values, WaveActiveMax maps down to the DirectX op + +define noundef half @wave_active_max_half(half noundef %expr) { +entry: +; CHECK:

[clang] [WebAssembly] Fix EH feature flags when compiling multiple files (PR #124374)

2025-01-24 Thread Derek Schuff via cfe-commits
https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/124374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema][FMV] Add a note to the 'cannot become multiversioned diagnostic (PR #124364)

2025-01-24 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/124364 ... pointing out the previous declaration. >From 3a2d96d127a3c233f7352acb17ef4a3a6b0a0a0b Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Fri, 24 Jan 2025 15:01:18 -0800 Subject: [PATCH] [clang][Sema][FMV] Ad

[clang] [clang][Sema][FMV] Add a note to the 'cannot become multiversioned diagnostic (PR #124364)

2025-01-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jon Roelofs (jroelofs) Changes ... pointing out the previous declaration. --- Full diff: https://github.com/llvm/llvm-project/pull/124364.diff 4 Files Affected: - (modified) clang/lib/Sema/SemaDecl.cpp (+5-2) - (modified) clang/test/Se

[clang] [PGO] Add a clang option -fprofile-continuous that enables PGO continuous mode (PR #124353)

2025-01-24 Thread David Li via cfe-commits
@@ -3033,6 +3033,14 @@ indexed format, regardeless whether it is produced by frontend or the IR pass. overhead. ``prefer-atomic`` will be transformed to ``atomic`` when supported by the target, or ``single`` otherwise. +.. option:: -fprofile-continuous da

[clang-tools-extra] added option `google-readability-namespace-comments.AllowNoNamespaceComments` (PR #124265)

2025-01-24 Thread Thorsten Klein via cfe-commits
https://github.com/thorsten-klein updated https://github.com/llvm/llvm-project/pull/124265 >From 15a8d29ef422afe853adeb1fd66e5218d9ebfa34 Mon Sep 17 00:00:00 2001 From: "Klein, Thorsten (GDE-EDSI1)" Date: Fri, 24 Jan 2025 13:46:24 +0100 Subject: [PATCH] added option AllowNoNamespaceComments for

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-24 Thread John McCall via cfe-commits
rjmccall wrote: It's probably right that these should match the behavior of adding or removing a `*` (the latter of which can happen via template argument deduction), which does mean they need to handle ObjC pointer types correctly. https://github.com/llvm/llvm-project/pull/123678

[clang] [Clang][Sema] Reject declaring an alias template with the same name as its template parameter. (PR #123533)

2025-01-24 Thread Valentyn Yukhymenko via cfe-commits
https://github.com/BaLiKfromUA updated https://github.com/llvm/llvm-project/pull/123533 >From e451a8869420d9240f9006eb2adb599a3e6fd9f8 Mon Sep 17 00:00:00 2001 From: Valentyn Yukhymenko Date: Sun, 19 Jan 2025 23:13:46 + Subject: [PATCH 1/6] [Clang] Reject declaring an alias template with th

[clang] [clang][Sema][FMV] Add a note to the 'cannot become multiversioned' diagnostic (PR #124364)

2025-01-24 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs edited https://github.com/llvm/llvm-project/pull/124364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d92bac8 - [HLSL] Introduce address space `hlsl_constant(2)` for constant buffer declarations (#123411)

2025-01-24 Thread via cfe-commits
Author: Helena Kotas Date: 2025-01-24T16:48:35-08:00 New Revision: d92bac8a3ebb19106f6bca6b7613a27c52cb48ab URL: https://github.com/llvm/llvm-project/commit/d92bac8a3ebb19106f6bca6b7613a27c52cb48ab DIFF: https://github.com/llvm/llvm-project/commit/d92bac8a3ebb19106f6bca6b7613a27c52cb48ab.diff

[clang] [clang-format] Fix a bug in annotating overloaded co_await decl (PR #124240)

2025-01-24 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/124240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4