[clang] [clang][DebugInfo] Emit DW_AT_object_pointer on function definitions with explicit `this` (PR #122897)

2025-01-14 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/122897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Make ASTContext::getPointerAuthTypeDiscriminator const (PR #122931)

2025-01-14 Thread Timm Baeder via cfe-commits
tbaederr wrote: Not that easy I guess. https://github.com/llvm/llvm-project/pull/122931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement D3DCOLORtoUBYTE4 intrinsic (PR #122202)

2025-01-14 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/122202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Make ASTContext::getPointerAuthTypeDiscriminator const (PR #122931)

2025-01-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/122931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Make ASTContext::getPointerAuthTypeDiscriminator const (PR #122931)

2025-01-14 Thread Timm Baeder via cfe-commits
tbaederr wrote: This sucks, but mangling needs a mutable `ASTContext`. https://github.com/llvm/llvm-project/pull/122931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

2025-01-14 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/122629 >From c7c5b740c813afed4ab2c29ac4d4951d62a04bfc Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 14 Jan 2025 11:55:10 -0500 Subject: [PATCH 1/2] [LLVM][Triple] Add an argument to specify canonical form to

[clang] [StaticAnalyzer] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122856)

2025-01-14 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > This one also uses dyn_cast_if_present. Sorry about that. Fixed. https://github.com/llvm/llvm-project/pull/122856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [clang] Fix a use-after-free in expression evaluation (PR #118480)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
VitaNuo wrote: > Here's a small reprocase (thanks to cvise for getting it) The repro doesn't compile in this shape, I've changed it to ``` template constexpr InputIterator find_if(InputIterator first, Predicate pred) { if (pred(*first)) ; return first; } template struct basic_string_

[clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: None (Sirraide) Changes ## Changes tl;dr: The names are inaccurate and continue to cause confusion. This pr currently makes the following changes: - Rename `isAnyPointerType()` to `isPointerOrObjCObjectPointerType()`. - Rename `getPointee

[clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes ## Changes tl;dr: The names are inaccurate and continue to cause confusion. This pr currently makes the following changes: - Rename `isAnyPointerType()` to `isPointerOrObjCObjectPointerType()`. - Rename `getPointeeO

[clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: None (Sirraide) Changes ## Changes tl;dr: The names are inaccurate and continue to cause confusion. This pr currently makes the following changes: - Rename `isAnyPointerType()` to `isPointerOrObjCObjectPointerType()`. - Rename `ge

[clang] 06c6bae - [HLSL] Implement D3DCOLORtoUBYTE4 intrinsic (#122202)

2025-01-14 Thread via cfe-commits
Author: Deric Cheung Date: 2025-01-14T09:11:54-08:00 New Revision: 06c6baeb521e321ffcb60fc0a411451e987cd98b URL: https://github.com/llvm/llvm-project/commit/06c6baeb521e321ffcb60fc0a411451e987cd98b DIFF: https://github.com/llvm/llvm-project/commit/06c6baeb521e321ffcb60fc0a411451e987cd98b.diff

[clang] [HLSL] Implement D3DCOLORtoUBYTE4 intrinsic (PR #122202)

2025-01-14 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/122202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix modernize-use-integer-sign-comparison comparison (PR #121506)

2025-01-14 Thread via cfe-commits
https://github.com/qt-tatiana updated https://github.com/llvm/llvm-project/pull/121506 >From 0591e8b7be49299e2b73634a6ad4f2330557b37a Mon Sep 17 00:00:00 2001 From: Tatiana Borisova Date: Thu, 2 Jan 2025 18:08:26 +0100 Subject: [PATCH 1/4] [clang-tidy] Fix modernize-use-integer-sign-comparison

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122854)

2025-01-14 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/122854 >From 4b3e0285a506072869452e2d422f3aff494517db Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 13 Jan 2025 12:04:16 -0800 Subject: [PATCH 1/2] [AST] Migrate away from PointerUnion::dyn_cast (NFC) N

[clang] [StaticAnalyzer] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122856)

2025-01-14 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/122856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122854)

2025-01-14 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > You are still using dyn_cast_if_present :) Sorry about that. Fixed. https://github.com/llvm/llvm-project/pull/122854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [StaticAnalyzer] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122856)

2025-01-14 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/122856 >From 492cea234d3d7b2a017d1e926272e95bf5fbfefc Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 13 Jan 2025 12:16:18 -0800 Subject: [PATCH 1/2] [StaticAnalyzer] Migrate away from PointerUnion::dyn_ca

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122854)

2025-01-14 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/122854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement D3DCOLORtoUBYTE4 intrinsic (PR #122202)

2025-01-14 Thread via cfe-commits
github-actions[bot] wrote: @Icohedron Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread Kiran Chandramohan via cfe-commits
@@ -0,0 +1,37 @@ +! RUN: %flang_fc1 -emit-llvm -O1 -funroll-loops -mllvm -force-vector-width=2 -o- %s | FileCheck %s --check-prefixes=CHECK,UNROLL +! RUN: %flang_fc1 -emit-llvm -O2 -mllvm -force-vector-width=2 -o- %s | FileCheck %s --check-prefixes=CHECK,UNROLL +! RUN: %flang_fc

[clang] [SPIR-V] Add hlsl_private address space for HLSL/SPIR-V (PR #122103)

2025-01-14 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: We talked about this yesterday in a call with @Keenuts and @s-perron. I think one of the problems we have with HLSL is that we haven't had explicit address space annotations except for `groupshared` in the past. We do need to do that in the future, but

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread Kiran Chandramohan via cfe-commits
@@ -0,0 +1,37 @@ +! RUN: %flang_fc1 -emit-llvm -O1 -funroll-loops -mllvm -force-vector-width=2 -o- %s | FileCheck %s --check-prefixes=CHECK,UNROLL +! RUN: %flang_fc1 -emit-llvm -O2 -mllvm -force-vector-width=2 -o- %s | FileCheck %s --check-prefixes=CHECK,UNROLL +! RUN: %flang_fc

[clang] [WIP][Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
VitaNuo wrote: > Can you add more details to the patch summary explaining why the changes are > needed? That makes it easier for folks to review the patch but also helps us > in the future when digging through historical changes. Thanks! Sure, thank you for the comment. https://github.com/llv

[clang-tools-extra] [clang-tidy]fix incorrect auto-fix for the string contains a user-defined suffix (PR #122901)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes Fixed: #97243 --- Full diff: https://github.com/llvm/llvm-project/pull/122901.diff 4 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/RawStringLiteralCheck.cpp (+21-7) - (mod

[clang-tools-extra] [clang-tidy]fix incorrect auto-fix for the string contains a user-defined suffix (PR #122901)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes Fixed: #97243 --- Full diff: https://github.com/llvm/llvm-project/pull/122901.diff 4 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/RawStringLiteralCheck.cpp (+21-7)

[clang] [Clang] Add AArch64 SME changes to the release notes (PR #122899)

2025-01-14 Thread Maciej Gabka via cfe-commits
@@ -1076,6 +1076,15 @@ Arm and AArch64 Support in leaf functions after enabling ``-fno-omit-frame-pointer``, you can do so by adding the ``-momit-leaf-frame-pointer`` option. +- SME keyword attributes which apply to function types are now represented in the + mangling o

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo closed https://github.com/llvm/llvm-project/pull/122250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo edited https://github.com/llvm/llvm-project/pull/122250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo edited https://github.com/llvm/llvm-project/pull/122726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #122841)

2025-01-14 Thread via cfe-commits
https://github.com/earnol edited https://github.com/llvm/llvm-project/pull/122841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Multilib] Custom flags processing for library selection (PR #110659)

2025-01-14 Thread Victor Campos via cfe-commits
https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From 16aa4a010c22288ba363e4ab680a38fe0b6a327d Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Mon, 13 Jan 2025 13:51:52 + Subject: [PATCH 1/8] [Multilib] Custom flags YAML parsing MIME-Version: 1.0 Con

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
VitaNuo wrote: > The code in https://github.com/llvm/llvm-project/pull/122726 looks better. I > didn't do detailed review since it is marked WIP. It's not WIP anymore. Feel free to review, thanks a lot in advance! https://github.com/llvm/llvm-project/pull/122250 ___

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

2025-01-14 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan updated https://github.com/llvm/llvm-project/pull/122144 >From 483501549b910d1e91dab05cce65793c44aaa6f6 Mon Sep 17 00:00:00 2001 From: Kiran Chandramohan Date: Wed, 8 Jan 2025 17:26:24 + Subject: [PATCH 1/4] [Flang][Driver] Add a flag to control zero ini

[clang] [clang][bytecode] Mark global decls with diagnostics invalid (PR #122895)

2025-01-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/122895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Add init link for the RVO ptr (PR #122904)

2025-01-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/122904 None >From 24b323b514d130b12898eaeb63da05f6456e2f79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 14 Jan 2025 15:09:50 +0100 Subject: [PATCH] [clang][bytecode] Add init link for the R

[clang-tools-extra] [clang-tidy]fix incorrect auto-fix for the string contains a user-defined suffix (PR #122901)

2025-01-14 Thread via cfe-commits
@@ -317,6 +317,10 @@ Changes in existing checks a false positive when only an implicit conversion happened inside an initializer list. +- Improved :doc:`modernize-raw-string-literal + ` check to fix incorrect auto + fix when the string contains a user-defined suffix. ---

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
@@ -1156,6 +1158,19 @@ class ASTReader SmallVector, 16> PendingDeducedVarTypes; + struct PendingPreferredNameAttribute { +Decl *D; +AttributeCommonInfo Info; +serialization::TypeID TypeID; +bool isInherited; +bool isImplicit; +bool isPackExpans

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
@@ -337,6 +337,14 @@ class ASTRecordReader /// Reads attributes from the current stream position, advancing Idx. void readAttributes(AttrVec &Attrs); + /// Reads one attribute from the current stream position, advancing Idx. + /// Parent Decl is provided to delay attribu

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
@@ -9860,6 +9860,33 @@ void ASTReader::finishPendingActions() { } PendingDeducedVarTypes.clear(); +ASTContext &Context = getContext(); +for (unsigned I = 0; I != PendingPreferredNameAttributes.size(); ++I) { + auto *D = PendingPreferredNameAttributes[I].D;

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
@@ -3129,42 +3129,86 @@ class AttrReader { OMPTraitInfo *readOMPTraitInfo() { return Reader.readOMPTraitInfo(); } template T *readDeclAs() { return Reader.readDeclAs(); } + + AttributeCommonInfo readAttributeCommonInfo() { +IdentifierInfo *AttrName = readIdentifier()

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo edited https://github.com/llvm/llvm-project/pull/122250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]fix incorrect auto-fix for the string contains a user-defined suffix (PR #122901)

2025-01-14 Thread via cfe-commits
@@ -136,13 +137,26 @@ void RawStringLiteralCheck::check(const MatchFinder::MatchResult &Result) { void RawStringLiteralCheck::replaceWithRawStringLiteral( const MatchFinder::MatchResult &Result, const StringLiteral *Literal, -StringRef Replacement) { - CharSourceRang

[clang] [clang][bytecode] Add init link for the RVO ptr (PR #122904)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122904.diff 3 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+3) - (modified) clang/lib/AST/ByteCode/Compiler.h (+3-1) - (modi

[clang] [clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #122841)

2025-01-14 Thread via cfe-commits
https://github.com/earnol edited https://github.com/llvm/llvm-project/pull/122841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add AArch64 SME changes to the release notes (PR #122899)

2025-01-14 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm created https://github.com/llvm/llvm-project/pull/122899 None >From e5c0686058f5dac17b02547e283df9bd20d24cae Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Tue, 14 Jan 2025 13:23:54 + Subject: [PATCH] [Clang] Add AArch64 SME changes to the release no

[clang] c1de9b9 - [clang][bytecode] Mark global decls with diagnostics invalid (#122895)

2025-01-14 Thread via cfe-commits
Author: Timm Baeder Date: 2025-01-14T15:10:48+01:00 New Revision: c1de9b920935e7d2fcc8dd7b39c1b7285783e948 URL: https://github.com/llvm/llvm-project/commit/c1de9b920935e7d2fcc8dd7b39c1b7285783e948 DIFF: https://github.com/llvm/llvm-project/commit/c1de9b920935e7d2fcc8dd7b39c1b7285783e948.diff L

[clang] [llvm] [LLVM][AArch64] Add new feature +sme-mop4 and +sme-tmop (PR #121935)

2025-01-14 Thread via cfe-commits
https://github.com/Lukacma approved this pull request. https://github.com/llvm/llvm-project/pull/121935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread David Truby via cfe-commits
https://github.com/DavidTruby created https://github.com/llvm/llvm-project/pull/122906 This patch adds support for the -funroll-loops and -fno-unroll-loops flags with similar behaviour to clang. funroll-loops is enabled at -O2 onwards as is the current default. >From c9b2e5855fdbbaafb5512e1e2

[clang-tools-extra] [clang-tidy][doc] fix incorrectly performance-unnecessary-copy-initialization link in release note (PR #122910)

2025-01-14 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add AArch64 SME changes to the release notes (PR #122899)

2025-01-14 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm approved this pull request. https://github.com/llvm/llvm-project/pull/122899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][doc] fix incorrectly performance-unnecessary-copy-initialization link in release note (PR #122910)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122910.diff 1 Files Affected: - (modified) clang-tools-extra/docs/ReleaseNotes.rst (+2-2) ``diff diff --git a/clang-tool

[clang] [Clang] Add AArch64 SME changes to the release notes (PR #122899)

2025-01-14 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/122899 >From 0218a54ea332dc77a95e887fc5c83ffe9b47d0b8 Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Tue, 14 Jan 2025 13:23:54 + Subject: [PATCH] [Clang] Add AArch64 SME changes to the release notes -

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread Kiran Chandramohan via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %flang_fc1 -emit-llvm -O1 -funroll-loops -mllvm -force-vector-width=1 -o- %s | FileCheck %s --check-prefixes=CHECK,UNROLL kiranchandramohan wrote: The test should probably be in Integration directory and possibly a source to LLVM IR te

[clang-tools-extra] a53fa78 - [clang-tidy][doc] fix incorrectly performance-unnecessary-copy-initialization link in release note (#122910)

2025-01-14 Thread via cfe-commits
Author: Congcong Cai Date: 2025-01-14T22:44:05+08:00 New Revision: a53fa78e7b14e57f0acd5a0981e4c63a1c217a11 URL: https://github.com/llvm/llvm-project/commit/a53fa78e7b14e57f0acd5a0981e4c63a1c217a11 DIFF: https://github.com/llvm/llvm-project/commit/a53fa78e7b14e57f0acd5a0981e4c63a1c217a11.diff

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-14 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Oh, I see, you're suggesting we remove the `getStdNamespace` check from > > this PR. Yeah, I think that's reasonable. > > Yep, that is my suggestion, sorry I was insufficiently clear. > > > But I'd somewhat question whether this PR and warning really has anything > > t

[clang] [clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #122841)

2025-01-14 Thread via cfe-commits
https://github.com/earnol updated https://github.com/llvm/llvm-project/pull/122841 >From 1e0f301f1c41e7f678c3eac2a067a7c81caa3228 Mon Sep 17 00:00:00 2001 From: Vladislav Aranov Date: Mon, 13 Jan 2025 20:19:58 -0500 Subject: [PATCH] [clang-tidy] Address false positives in misc-redundant-expres

[clang] [clang] Fix false warning on reinterpret_casting unknown template type (PR #109430)

2025-01-14 Thread via cfe-commits
cor3ntin wrote: Hum, this actually need a release note, can you edit clang/docs/ReleaseNotes.rst? Thanks https://github.com/llvm/llvm-project/pull/109430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang-tools-extra] [clang-tidy]fix incorrect auto-fix for the string contains a user-defined suffix (PR #122901)

2025-01-14 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/122901 >From 6cec0ebf3b028bdef5c381b0bea1985139d0c916 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 14 Jan 2025 21:10:57 +0800 Subject: [PATCH] [clang-tidy]fix incorrect auto-fix for the string contains a

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread Kiran Chandramohan via cfe-commits
@@ -150,12 +150,17 @@ void Flang::addCodegenOptions(const ArgList &Args, if (shouldLoopVersion(Args)) CmdArgs.push_back("-fversion-loops-for-stride"); + Args.addAllArgs(CmdArgs, {options::OPT_flang_experimental_hlfir, +options::OPT_flang_depr

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %flang_fc1 -emit-llvm -O1 -funroll-loops -mllvm -force-vector-width=1 -o- %s | FileCheck %s --check-prefixes=CHECK,UNROLL tarunprabhu wrote: A source to (at least) HLFIR test will also check that the -f(no-)unroll loops option has not

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-14 Thread Erich Keane via cfe-commits
erichkeane wrote: > > > Oh, I see, you're suggesting we remove the `getStdNamespace` check from > > > this PR. Yeah, I think that's reasonable. > > > > > > Yep, that is my suggestion, sorry I was insufficiently clear. > > > But I'd somewhat question whether this PR and warning really has anyth

[clang] [llvm] [mlir] [OMPIRBuilder] Support runtime number of teams and threads, and SPMD mode (PR #116051)

2025-01-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `clang,llvm,mlir` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/bui

[clang-tools-extra] [clang-tidy]fix incorrect auto-fix for the string contains a user-defined suffix (PR #122901)

2025-01-14 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/122901 Fixed: #97243 >From 6cabc9df5c94226530f6631ce7ee07026a367889 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 14 Jan 2025 21:10:57 +0800 Subject: [PATCH] [clang-tidy]fix incorrect auto-fix for the st

[clang] [Clang] Add AArch64 SME changes to the release notes (PR #122899)

2025-01-14 Thread Maciej Gabka via cfe-commits
https://github.com/mgabka approved this pull request. https://github.com/llvm/llvm-project/pull/122899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
VitaNuo wrote: > BTW, it is better to have better explanation in the summary. I know you > explained it in the issue. But it will be better for other readers after you > land the PR. Thanks @ChuanqiXu9, I have added a detailed summary https://github.com/llvm/llvm-project/pull/122726. After s

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-14 Thread Viktoriia Bakalova via cfe-commits
@@ -3129,42 +3129,86 @@ class AttrReader { OMPTraitInfo *readOMPTraitInfo() { return Reader.readOMPTraitInfo(); } template T *readDeclAs() { return Reader.readDeclAs(); } + + AttributeCommonInfo readAttributeCommonInfo() { +IdentifierInfo *AttrName = readIdentifier()

[clang] [WIP][Modules] Delay deserialization of preferred_name attribute at r… (PR #122726)

2025-01-14 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: I don't feel qualified to review this, but I appreciate that you fix holes in my original quite naive implementation. https://github.com/llvm/llvm-project/pull/122726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] 310c281 - [flang][Driver] Preliminary support for -ftime-report (#122894)

2025-01-14 Thread via cfe-commits
Author: macurtis-amd Date: 2025-01-14T08:02:02-06:00 New Revision: 310c281b020b169e760ca75f878f5873ffbb2a9f URL: https://github.com/llvm/llvm-project/commit/310c281b020b169e760ca75f878f5873ffbb2a9f DIFF: https://github.com/llvm/llvm-project/commit/310c281b020b169e760ca75f878f5873ffbb2a9f.diff

[clang] [flang] [flang][Driver] Preliminary support for -ftime-report (PR #122894)

2025-01-14 Thread via cfe-commits
https://github.com/macurtis-amd closed https://github.com/llvm/llvm-project/pull/122894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Multilib] Custom flags YAML parsing (PR #122903)

2025-01-14 Thread Victor Campos via cfe-commits
https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/122903 This patch is the first step to extend the current multilib system to support the selection of library variants which do not correspond to existing command-line options. Proposal can be found in https://disc

[clang] [Multilib] Custom flags YAML parsing (PR #122903)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Victor Campos (vhscampos) Changes This patch is the first step to extend the current multilib system to support the selection of library variants which do not correspond to existing command-line options. Proposal can be found in https://

[clang] [Multilib] Custom flags YAML parsing (PR #110657)

2025-01-14 Thread Victor Campos via cfe-commits
vhscampos wrote: I've reverted this patch because apparently Clang driver does not meld well with `std::shared_ptr`: memory leaks due to custom allocators I think. Thus I've redone the part to use raw pointers instead: https://github.com/llvm/llvm-project/pull/122903 https://github.com/llvm/l

[clang] [Multilib] Custom flags YAML parsing (PR #122903)

2025-01-14 Thread Victor Campos via cfe-commits
vhscampos wrote: This has been redone to use raw pointers instead, as shared_ptr apparently don't work well in the Clang driver due to custom allocators. Functionally it's exactly the same patch. https://github.com/llvm/llvm-project/pull/122903 ___ c

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Truby (DavidTruby) Changes This patch adds support for the -funroll-loops and -fno-unroll-loops flags with similar behaviour to clang. funroll-loops is enabled at -O2 onwards as is the current default. --- Full diff: https://github

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: David Truby (DavidTruby) Changes This patch adds support for the -funroll-loops and -fno-unroll-loops flags with similar behaviour to clang. funroll-loops is enabled at -O2 onwards as is the current default. --- Full diff: https:/

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

2025-01-14 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan updated https://github.com/llvm/llvm-project/pull/122144 >From 483501549b910d1e91dab05cce65793c44aaa6f6 Mon Sep 17 00:00:00 2001 From: Kiran Chandramohan Date: Wed, 8 Jan 2025 17:26:24 + Subject: [PATCH 1/4] [Flang][Driver] Add a flag to control zero ini

[clang] [llvm] [LLVM][AArch64] Add new feature +sme-mop4 and +sme-tmop (PR #121935)

2025-01-14 Thread via cfe-commits
https://github.com/CarolineConcatto closed https://github.com/llvm/llvm-project/pull/121935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/122887 >From 0555df5f2bd726904e1ac21f44c9623aa057f831 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Dec 2024 16:00:51 +0800 Subject: [PATCH] [C++20] [Modules] Support module level lookup Close https://git

[clang] [clang][bytecode] Mark global decls with diagnostics invalid (PR #122895)

2025-01-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11682 Here is the r

[clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via cfe-commits
@@ -2711,6 +2715,12 @@ class DeclContext { bool Deserialize = false) const; private: + /// Lookup all external visible declarations and the external declarations + /// within the same module specified by \param NamedModule. We can't Chuanq

[clang] [clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #122841)

2025-01-14 Thread via cfe-commits
https://github.com/earnol updated https://github.com/llvm/llvm-project/pull/122841 >From abbc1142211abe99ae36ab0bde5803e375a2 Mon Sep 17 00:00:00 2001 From: Vladislav Aranov Date: Mon, 13 Jan 2025 20:19:58 -0500 Subject: [PATCH] [clang-tidy] Address false positives in misc-redundant-expres

[clang] [clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #122841)

2025-01-14 Thread via cfe-commits
https://github.com/earnol updated https://github.com/llvm/llvm-project/pull/122841 >From 4d49ec7e0d0b1f3f38fa3c3df30dc38627d8997d Mon Sep 17 00:00:00 2001 From: Vladislav Aranov Date: Mon, 13 Jan 2025 20:19:58 -0500 Subject: [PATCH] [clang-tidy] Address false positives in misc-redundant-expres

[clang-tools-extra] [clang-tidy][doc] fix incorrectly performance-unnecessary-copy-initialization link in release note (PR #122910)

2025-01-14 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/122910 None >From bf628c7949451533a9455d7f7cb8938d8f547dc3 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 14 Jan 2025 22:43:31 +0800 Subject: [PATCH] [clang-tidy][doc] fix incorrectly performance-unnecess

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-14 Thread Petr Polezhaev via cfe-commits
https://github.com/petr-polezhaev updated https://github.com/llvm/llvm-project/pull/122606 >From 0813476d626e21828f73e9f9a3a3561becd37277 Mon Sep 17 00:00:00 2001 From: Petr Polezhaev Date: Sat, 11 Jan 2025 21:21:16 +0300 Subject: [PATCH 1/2] [clangd] Support .clangd command line modifications

[clang] fbef1f8 - [clang-format][NFC] Make formatting Verilog faster (#121139)

2025-01-14 Thread via cfe-commits
Author: sstwcw Date: 2025-01-14T15:37:06Z New Revision: fbef1f835f0381a71362199840bee9ec491e3918 URL: https://github.com/llvm/llvm-project/commit/fbef1f835f0381a71362199840bee9ec491e3918 DIFF: https://github.com/llvm/llvm-project/commit/fbef1f835f0381a71362199840bee9ec491e3918.diff LOG: [clang

[clang] [clang-format][NFC] Make formatting Verilog faster (PR #121139)

2025-01-14 Thread via cfe-commits
https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/121139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

2025-01-14 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I'm good here. Please let others make sure they are as well though. https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread David Truby via cfe-commits
https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/122906 >From c9b2e5855fdbbaafb5512e1e2539983201202b25 Mon Sep 17 00:00:00 2001 From: David Truby Date: Wed, 8 Jan 2025 11:19:38 + Subject: [PATCH 1/2] [flang] Add -f[no-]unroll-loops flag This patch adds suppor

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-14 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > > Oh, I see, you're suggesting we remove the `getStdNamespace` check from > > > > this PR. Yeah, I think that's reasonable. > > > > > > > > > Yep, that is my suggestion, sorry I was insufficiently clear. > > > > But I'd somewhat question whether this PR and warning re

[clang] [flang] [flang] Add -f[no-]unroll-loops flag (PR #122906)

2025-01-14 Thread David Truby via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %flang_fc1 -emit-llvm -O1 -funroll-loops -mllvm -force-vector-width=1 -o- %s | FileCheck %s --check-prefixes=CHECK,UNROLL DavidTruby wrote: I guess we should possibly have all 3? A source to HLFIR, this test, and source->llvmir? http

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

2025-01-14 Thread Petr Polezhaev via cfe-commits
petr-polezhaev wrote: > Do we need to update `buildModuleFile` in > `clang-tools-extra/clangd/ModulesBuilder.cpp` to update the commands to build > the module interfaces? It uses `GlobalCompilationDatabase::getCompileCommand` (if I correctly understand what you mean) which is overridden by `

[clang] [HLSL] cbuffer: Create host layout struct and add resource handle to AST (PR #122820)

2025-01-14 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: The one design question I have here is: should we be bothering to create a handle for the cbuffer in the frontend at all? My thought had been that we would instead emit the cbuffer member declarations as constant address space (2 for DXIL) declarations

[clang] [HLSL] cbuffer: Create host layout struct and add resource handle to AST (PR #122820)

2025-01-14 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/122820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] cbuffer: Create host layout struct and add resource handle to AST (PR #122820)

2025-01-14 Thread Chris B via cfe-commits
@@ -253,12 +257,253 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl *BufDecl) { } } +// Returns true if the array has a zero size = if any of the dimensions is 0 +static bool isZeroSizedArray(const ConstantArrayType *CAT) { + while (CAT && !CAT->isZeroSize()) +

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-14 Thread Erich Keane via cfe-commits
erichkeane wrote: > Yes, but the point is: these names aren't reserved but the pain can still > happen. e.g., `cdecl` is not a reserved identifier, but re-defining its > meaning can still break code in ways that could have better diagnostics: > https://godbolt.org/z/vTfWPsYj9. Though, I suppo

[clang] [llvm] [HLSL] Implement elementwise firstbitlow builtin (PR #116858)

2025-01-14 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/116858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > I thought the new driver just got some entropy from the current source file's > `inode` entry? I'm not opposed, since I guess it would make sense to give the > user a way to override it. Sorry I did not quite get your question. Do you suggest that we need some option to over

[clang-tools-extra] [clang-tidy] Add QtEnabled option to modernize-use-integer-sign-comprison (PR #122127)

2025-01-14 Thread via cfe-commits
https://github.com/qt-tatiana updated https://github.com/llvm/llvm-project/pull/122127 >From b870cef0f9e5c62e5dd760a9fc324613b3cc783a Mon Sep 17 00:00:00 2001 From: Tatiana Borisova Date: Wed, 8 Jan 2025 15:29:02 +0100 Subject: [PATCH 1/3] [clang-tidy] Add QtEnabled option to modernize-use-int

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I thought the new driver just got some entropy from the current source > > file's `inode` entry? I'm not opposed, since I guess it would make sense to > > give the user a way to override it. > > Sorry I did not quite get your question. Do you suggest that we need some > opt

<    1   2   3   4   5   6   >