[clang] [clang][Driver][SPIR-V] Make tool names consistent (PR #122343)

2025-01-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nick Sarnie (sarnex) Changes Some use `SPIRV` and some use `SPIR-V`, just use `SPIR-V` which is what we use normally. I noticed this when fixing the test in https://github.com/llvm/llvm-project/pull/122310. --- Full diff: https://github

[clang-tools-extra] aee51b4 - [clang-tidy][NFC] optimize cache for config option (#121406)

2025-01-10 Thread via cfe-commits
Author: Congcong Cai Date: 2025-01-10T23:42:29+08:00 New Revision: aee51b4d75089b4e7d9eb20877e2adbf6adea999 URL: https://github.com/llvm/llvm-project/commit/aee51b4d75089b4e7d9eb20877e2adbf6adea999 DIFF: https://github.com/llvm/llvm-project/commit/aee51b4d75089b4e7d9eb20877e2adbf6adea999.diff

[clang-tools-extra] [clang-tidy][NFC] optimize cache for config option (PR #121406)

2025-01-10 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/121406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] sort a bit more parts of release notes (PR #122475)

2025-01-10 Thread Jan Voung via cfe-commits
https://github.com/jvoung created https://github.com/llvm/llvm-project/pull/122475 and remove a trailing space >From a11558489842cbde57a5237cd28be44fbcb4d211 Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Fri, 10 Jan 2025 15:23:46 + Subject: [PATCH] [clang-tidy] sort a bit more parts of r

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

2025-01-10 Thread Hans Wennborg via cfe-commits
@@ -58,6 +58,26 @@ code bases. containing strict-aliasing violations. The new default behavior can be disabled using ``-fno-pointer-tbaa``. +- Clang will now more aggressively use undefined behavior on pointer addition + overflow for optimization purposes. For example, a

[clang-tools-extra] [clang-tidy] sort / reorder a part of release notes (PR #122475)

2025-01-10 Thread Jan Voung via cfe-commits
https://github.com/jvoung edited https://github.com/llvm/llvm-project/pull/122475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][SPIR-V] Make tool names consistent (PR #122343)

2025-01-10 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks; good to see consistent naming! https://github.com/llvm/llvm-project/pull/122343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [AArch64][Clang] Add support for __arm_agnostic("sme_za_state") (PR #121788)

2025-01-10 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm approved this pull request. https://github.com/llvm/llvm-project/pull/121788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4f69f45 - (reland) [clang] Warn [[clang::lifetimebound]] misusages on types (#118501)

2025-01-10 Thread via cfe-commits
Author: Maksim Ivanov Date: 2025-01-10T12:32:19+01:00 New Revision: 4f69f4579132900949a7886fe3ba92d693430da0 URL: https://github.com/llvm/llvm-project/commit/4f69f4579132900949a7886fe3ba92d693430da0 DIFF: https://github.com/llvm/llvm-project/commit/4f69f4579132900949a7886fe3ba92d693430da0.diff

[clang] Fix a cmake error when using the Xcode generator. (PR #119403)

2025-01-10 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11461 Here is the r

[clang] [AArch64][Clang] Add support for __arm_agnostic("sme_za_state") (PR #121788)

2025-01-10 Thread Kerry McLaughlin via cfe-commits
@@ -7559,6 +7559,32 @@ The attributes ``__arm_in(S)``, ``__arm_out(S)``, ``__arm_inout(S)`` and }]; } +def ArmAgnosticDocs : Documentation { + let Category = DocCatArmSmeAttributes; + let Content = [{ +The ``__arm_agnostic`` keyword applies to prototyped function types an

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-10 Thread Ilya Biryukov via cfe-commits
@@ -3129,42 +3129,86 @@ class AttrReader { OMPTraitInfo *readOMPTraitInfo() { return Reader.readOMPTraitInfo(); } template T *readDeclAs() { return Reader.readDeclAs(); } + + AttributeCommonInfo readAttributeCommonInfo() { +IdentifierInfo *AttrName = readIdentifier()

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov requested changes to this pull request. Thanks for working on this! After looking at the code, I think we should explore an alternative approach that would entail less duplication of serialization logic to ensure the code is correct for arbitrary TypeLocs and i

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-10 Thread Ilya Biryukov via cfe-commits
@@ -9860,6 +9860,33 @@ void ASTReader::finishPendingActions() { } PendingDeducedVarTypes.clear(); +ASTContext &Context = getContext(); +for (unsigned I = 0; I != PendingPreferredNameAttributes.size(); ++I) { + auto *D = PendingPreferredNameAttributes[I].D;

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-10 Thread Ilya Biryukov via cfe-commits
@@ -3129,42 +3129,86 @@ class AttrReader { OMPTraitInfo *readOMPTraitInfo() { return Reader.readOMPTraitInfo(); } template T *readDeclAs() { return Reader.readDeclAs(); } + + AttributeCommonInfo readAttributeCommonInfo() { +IdentifierInfo *AttrName = readIdentifier()

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-10 Thread Ilya Biryukov via cfe-commits
@@ -1156,6 +1158,19 @@ class ASTReader SmallVector, 16> PendingDeducedVarTypes; + struct PendingPreferredNameAttribute { +Decl *D; +AttributeCommonInfo Info; +serialization::TypeID TypeID; +bool isInherited; +bool isImplicit; +bool isPackExpans

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/122250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

2025-01-10 Thread Ilya Biryukov via cfe-commits
@@ -337,6 +337,14 @@ class ASTRecordReader /// Reads attributes from the current stream position, advancing Idx. void readAttributes(AttrVec &Attrs); + /// Reads one attribute from the current stream position, advancing Idx. + /// Parent Decl is provided to delay attribu

[clang] [Clang] Add "extend lifetime" flags and release note (PR #110000)

2025-01-10 Thread Stephen Tozer via cfe-commits
@@ -412,6 +412,20 @@ New Compiler Flags only for thread-local variables, and none (which corresponds to the existing ``-fno-c++-static-destructors`` flag) skips all static destructors registration. +- The ``-fextend-variable-liveness`` flag has been added to allow for imp

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Maksim Ivanov via cfe-commits
https://github.com/emaxx-google created https://github.com/llvm/llvm-project/pull/122473 None >From 67c2e435e7030ca417e685cfa98e39b79248687e Mon Sep 17 00:00:00 2001 From: Maksim Ivanov Date: Fri, 10 Jan 2025 15:10:52 + Subject: [PATCH] [clang] Refactor attr diagnostics to use %select ---

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Maksim Ivanov via cfe-commits
emaxx-google wrote: @ilya-biryukov You suggested previously (https://github.com/llvm/llvm-project/pull/118567/files#r1868729303) to introduce a separate enum, but I didn't manage to do it so far. Instead, I added new strings to `AttributeDeclKind`. My thinking has been: 1. If we create a enum

[clang] [llvm] Handle leading underscores in update_cc_test_checks.py (PR #121800)

2025-01-10 Thread Momchil Velikov via cfe-commits
@@ -650,6 +655,16 @@ def get_triple_from_march(march): print("Cannot find a triple. Assume 'x86'", file=sys.stderr) return "x86" +def get_global_underscores(raw_tool_output): +m = DATA_LAYOUT_RE.search(raw_tool_output) +if not m: +return False +data

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Maksim Ivanov (emaxx-google) Changes A cleanup follow-up to #118567 and #118567. --- Full diff: https://github.com/llvm/llvm-project/pull/122473.diff 8 Files Affected: - (modified) clang/examples/Attribute/Attribute.cpp (+5-4) - (modif

[clang] [llvm] Handle leading underscores in update_cc_test_checks.py (PR #121800)

2025-01-10 Thread Momchil Velikov via cfe-commits
@@ -122,6 +122,11 @@ def parse_clang_ast_json(node, loc, search): if search is None: search = spell mangled = node.get("mangledName", spell) +# Strip leading underscore from globals, so the name matches the LLVM one momchil-

[clang] [clang] Fix implicit integer conversion for opaque enums declared in class templates (PR #121039)

2025-01-10 Thread via cfe-commits
=?utf-8?q?André?= Brand , =?utf-8?q?André?= Brand ,thebrandre , =?utf-8?q?André?= Brand ,thebrandre Message-ID: In-Reply-To: https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/121039 ___ cfe-commits mailing list cfe-commit

[clang] d6b6598 - [clang] Fix implicit integer conversion for opaque enums declared in class templates (#121039)

2025-01-10 Thread via cfe-commits
Author: thebrandre Date: 2025-01-10T16:31:58+01:00 New Revision: d6b6598e8075a5ba0271ee06a20c5a5609c0ec37 URL: https://github.com/llvm/llvm-project/commit/d6b6598e8075a5ba0271ee06a20c5a5609c0ec37 DIFF: https://github.com/llvm/llvm-project/commit/d6b6598e8075a5ba0271ee06a20c5a5609c0ec37.diff LO

[clang] [llvm] Handle leading underscores in update_cc_test_checks.py (PR #121800)

2025-01-10 Thread Momchil Velikov via cfe-commits
@@ -650,6 +655,16 @@ def get_triple_from_march(march): print("Cannot find a triple. Assume 'x86'", file=sys.stderr) return "x86" +def get_global_underscores(raw_tool_output): +m = DATA_LAYOUT_RE.search(raw_tool_output) +if not m: +return False +data

[clang] [clang] Fix implicit integer conversion for opaque enums declared in class templates (PR #121039)

2025-01-10 Thread via cfe-commits
=?utf-8?q?André?= Brand , =?utf-8?q?André?= Brand ,thebrandre , =?utf-8?q?André?= Brand ,thebrandre Message-ID: In-Reply-To: github-actions[bot] wrote: @thebrandre Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with rece

[clang-tools-extra] [clang-tidy] sort / reorder a part of release notes (PR #122475)

2025-01-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Jan Voung (jvoung) Changes and remove a trailing space --- Full diff: https://github.com/llvm/llvm-project/pull/122475.diff 1 Files Affected: - (modified) clang-tools-extra/docs/ReleaseNotes.rst (+3-3) ``diff dif

[clang-tools-extra] [clang-tidy] sort / reorder a part of release notes (PR #122475)

2025-01-10 Thread Jan Voung via cfe-commits
https://github.com/jvoung ready_for_review https://github.com/llvm/llvm-project/pull/122475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Remove some orphaned images (PR #122249)

2025-01-10 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/122249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Remove some orphaned images (PR #122249)

2025-01-10 Thread Donát Nagy via cfe-commits
NagyDonat wrote: I created PR https://github.com/llvm/llvm-project/pull/122481 which properly handles these images. https://github.com/llvm/llvm-project/pull/122249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [NFC][analyzer][docs] Restore/remove orphaned images (PR #122481)

2025-01-10 Thread Donát Nagy via cfe-commits
NagyDonat wrote: The first two commits in this PR are separately reviewed at https://github.com/llvm/llvm-project/pull/122246 and I intend to merge them (squashed into a single commit) through that PR. **In this PR please only review the third commit [[NFC][analyzer][docs] Restore/remove orph

[clang-tools-extra] [clang-tidy] sort / reorder a part of release notes (PR #122475)

2025-01-10 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/122475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

2025-01-10 Thread Nikita Popov via cfe-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/122486 GCC supports three flags related to overflow behavior: * `-fwrapv`: Makes signed integer overflow well-defined. * `-fwrapv-pointer`: Makes pointer overflow well-defined. * `-fno-strict-overflow`: Implies `-fwrap

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-10 Thread Martin Storsjö via cfe-commits
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver &D, CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind : ArchArgFPUKind; (void)llvm::ARM::getFPUFeatures(FPUKind, Features); } else { +bool Generic = true; if (!ForAS) {

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

2025-01-10 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/122486 >From 1f3737d2eeb7681cb57a66f7bd6c4614cd038aac Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 10 Jan 2025 17:01:07 +0100 Subject: [PATCH] [Clang] Add -fwrapv-pointer flag GCC supports three flags related

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

2025-01-10 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/122486 >From b8c7a369fffecc9d1811d286fb1536346045fb74 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 10 Jan 2025 17:01:07 +0100 Subject: [PATCH] [Clang] Add -fwrapv-pointer flag GCC supports three flags related

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

2025-01-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c39500f88c93f668c68bdafe56bd8d16e8abbec1 32fe619505787c434f97b01da0458ba7861f9550 --e

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

2025-01-10 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/122486 >From b32e3e1eee4b359ae2f0a1563420104de8d52277 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 10 Jan 2025 17:01:07 +0100 Subject: [PATCH] [Clang] Add -fwrapv-pointer flag GCC supports three flags related

[clang] -ftime-report: reorganize timers (PR #122225)

2025-01-10 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan approved this pull request. This looks much better. Thanks! https://github.com/llvm/llvm-project/pull/15 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

2025-01-10 Thread Nikita Popov via cfe-commits
@@ -58,6 +58,26 @@ code bases. containing strict-aliasing violations. The new default behavior can be disabled using ``-fno-pointer-tbaa``. +- Clang will now more aggressively use undefined behavior on pointer addition + overflow for optimization purposes. For example, a

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > @ilya-biryukov You suggested previously > (https://github.com/llvm/llvm-project/pull/118567/files#r1868729303) to > introduce a separate enum, but I didn't manage to do it so far. Instead, I > added new strings to `AttributeDeclKind`. My thinking has been: I got confuse

[clang] [WebAssembly] Refactor Wasm EH/SjLj error checking (PR #122466)

2025-01-10 Thread Derek Schuff via cfe-commits
https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/122466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: This looks like a clear improvement. Just a quick check on whether we can remove the `_str` diagnostics completely (see the relevant comment) https://github.com/llvm/llvm-project/pull/122473 ___ cfe-commits

[clang] [llvm] [Clang] Add __builtin_assume_dereferenceable to encode deref assumption. (PR #121789)

2025-01-10 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: > I'm concerned about the soundness of our current implementation for these > assumptions, see my comment at [#120962 > (comment)](https://github.com/llvm/llvm-project/pull/120962#issuecomment-2582864870). > Not sure we should be exposing the current implementation from clang.

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2025-01-10 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/104661 >From ac2bd8cd5d9faf6c9a9ae7846b4110ade92d2f40 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 10 Jan 2025 12:25:03 -0500 Subject: [PATCH] [Clang] Remove 3-element vector load and store special handling

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2025-01-10 Thread Shilei Tian via cfe-commits
@@ -52,6 +52,17 @@ class AMDGPUABIInfo final : public DefaultABIInfo { void computeInfo(CGFunctionInfo &FI) const override; RValue EmitVAArg(CodeGenFunction &CGF, Address VAListAddr, QualType Ty, AggValueSlot Slot) const override; + + llvm::FixedVectorTy

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

2025-01-10 Thread Fangrui Song via cfe-commits
@@ -115,22 +92,12 @@ std::unique_ptr llvm::CreateInfoOutputFile() { return std::make_unique(2, false); // stderr. } -namespace { -struct CreateDefaultTimerGroup { - static void *call() { -return new TimerGroup("misc", "Miscellaneous Ungrouped Timers"); - } -}; -} // na

[clang] [llvm] [HLSL] Reapply Move length support out of the DirectX Backend (#121611) (PR #122337)

2025-01-10 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > @llvm-beanz I'm really confused what is going on here The length test case > passes in the github action: > https://github.com/llvm/llvm-project/actions/runs/12699150463?pr=122337 It > passes locally on: > > 1. MacOS Intel (Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz) > 2. MacO

[clang] [llvm] [HLSL] Reapply Move length support out of the DirectX Backend (#121611) (PR #122337)

2025-01-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122337 >From a7323e97f09db476e622bee9800e1b3e15441beb Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 13:11:52 -0500 Subject: [PATCH 1/3] [HLSL] Move length support out of the DirectX Backend (#1216

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Maksim Ivanov via cfe-commits
@@ -3708,9 +3709,9 @@ void Parser::ParseDeclarationSpecifiers( continue; if (PA.getKind() == ParsedAttr::AT_LifetimeBound) -Diag(PA.getLoc(), diag::err_attribute_wrong_decl_type_str) emaxx-google wrote: There are callsites le

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-10 Thread Fangrui Song via cfe-commits
MaskRay wrote: If hashing is changed, consider replacing xxhash64 with xxh3+_64bits https://github.com/llvm/llvm-project/pull/121070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Maksim Ivanov via cfe-commits
https://github.com/emaxx-google edited https://github.com/llvm/llvm-project/pull/122473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] (reland) [clang] Warn [[clang::lifetimebound]] misusages on types (PR #118501)

2025-01-10 Thread Maksim Ivanov via cfe-commits
emaxx-google wrote: #122473 is the promised follow-up for the diag. https://github.com/llvm/llvm-project/pull/118501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Informative error for lifetimebound in decl-spec (PR #118567)

2025-01-10 Thread Maksim Ivanov via cfe-commits
emaxx-google wrote: #122473 is the promised follow-up for the diag. https://github.com/llvm/llvm-project/pull/118567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-10 Thread Jon Roelofs via cfe-commits
@@ -243,6 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, case llvm::Triple::thumbeb: jroelofs wrote: github won't let me add a comment in the right spot, but I think we need: ``` case llvm::Triple::arm: case llvm::Triple::thumb:

[clang] [FMV][AArch64] Changes in fmv-features metadata. (PR #122192)

2025-01-10 Thread Jon Roelofs via cfe-commits
@@ -2763,9 +2764,10 @@ bool CodeGenModule::GetCPUAndFeaturesAttributes(GlobalDecl GD, Attrs.addAttribute("fmv-features"); AddedAttr = true; } else if (!Feats.empty()) { - llvm::sort(Feats); + // Sort features and remove duplicates. + std::set Ord

[clang] [llvm] [Support] Reduce globaal variable overhead after #121663 (PR #122429)

2025-01-10 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/122429 >From 320ab02a1a3602ac1191d507c67141f330da718b Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 9 Jan 2025 23:10:58 -0800 Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] [llvm] [Support] Reduce globaal variable overhead after #121663 (PR #122429)

2025-01-10 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/122429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64] Changes in fmv-features metadata. (PR #122192)

2025-01-10 Thread Alexandros Lamprineas via cfe-commits
@@ -2763,9 +2764,10 @@ bool CodeGenModule::GetCPUAndFeaturesAttributes(GlobalDecl GD, Attrs.addAttribute("fmv-features"); AddedAttr = true; } else if (!Feats.empty()) { - llvm::sort(Feats); + // Sort features and remove duplicates. + std::set Ord

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-10 Thread Bill Hoffman via cfe-commits
https://github.com/billhoffman updated https://github.com/llvm/llvm-project/pull/122370 >From 231a1efbecbf6c0f28eba49f3479e0320d33f02d Mon Sep 17 00:00:00 2001 From: Bill Hoffman Date: Thu, 9 Jan 2025 15:52:40 -0500 Subject: [PATCH] Fix print module manifest file for macos --- clang/lib/Drive

[clang] [Clang] FunctionEffects: Correctly navigate through array types in FunctionEffectsRef::get(). (PR #121525)

2025-01-10 Thread Doug Wyatt via cfe-commits
dougsonos wrote: Ping https://github.com/llvm/llvm-project/pull/121525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-10 Thread Bill Hoffman via cfe-commits
@@ -6380,6 +6380,11 @@ std::string Driver::GetFilePath(StringRef Name, const ToolChain &TC) const { if (llvm::sys::fs::exists(Twine(R))) return std::string(R); + SmallString<128> R2(ResourceDir); + llvm::sys::path::append(R2, "..", "..", Name); + if (llvm::sys::fs::e

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

2025-01-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Nikita Popov (nikic) Changes GCC supports three flags related to overflow behavior: * `-fwrapv`: Makes signed integer overflow well-defined. * `-fwrapv-pointer`: Makes pointer overflow well-defined. * `-fno-strict-overflow`: Impli

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

2025-01-10 Thread Nikita Popov via cfe-commits
@@ -58,6 +58,26 @@ code bases. containing strict-aliasing violations. The new default behavior can be disabled using ``-fno-pointer-tbaa``. +- Clang will now more aggressively use undefined behavior on pointer addition + overflow for optimization purposes. For example, a

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

2025-01-10 Thread Jan Voung via cfe-commits
jvoung wrote: > program:run-clang-tidy Sure thing -- Done separately in https://github.com/llvm/llvm-project/pull/122475 (I kept the "Improved" cluster together, vs moving `run-clang-tidy` to be after the "Removed" block including the table) For `readability-identifier-naming` it looks like

[clang] [clang][analyzer][doc] Migrate ClangSA www FAQ section (PR #112831)

2025-01-10 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,208 @@ +FAQ and How to Deal with Common False Positives +=== + +.. contents:: + :local: + +Custom Assertions +- + +Q: How do I tell the analyzer that I do not want the bug being reported here since my custom

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

2025-01-10 Thread Nikita Popov via cfe-commits
@@ -58,6 +58,26 @@ code bases. containing strict-aliasing violations. The new default behavior can be disabled using ``-fno-pointer-tbaa``. +- Clang will now more aggressively use undefined behavior on pointer addition nikic wrote: I think it's hard to ad

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2025-01-10 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Some code got rearranged after our initial testing and we started seeing some new errors after this landed. I have filed #122493 to track it, let's continue the discussion there. https://github.com/llvm/llvm-project/pull/111992 __

[clang] [clang][Driver][SPIR-V] Make tool names consistent (PR #122343)

2025-01-10 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. https://github.com/llvm/llvm-project/pull/122343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ac2d529 - [NFC][Clang] Auto generate check lines for `preserve_vec3.cl`

2025-01-10 Thread Shilei Tian via cfe-commits
Author: Shilei Tian Date: 2025-01-10T12:22:25-05:00 New Revision: ac2d529be31d7a670326298036a4b9b3eaed59d3 URL: https://github.com/llvm/llvm-project/commit/ac2d529be31d7a670326298036a4b9b3eaed59d3 DIFF: https://github.com/llvm/llvm-project/commit/ac2d529be31d7a670326298036a4b9b3eaed59d3.diff L

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-10 Thread Scott Constable via cfe-commits
scottconstable wrote: > If hashing is changed, consider replacing xxhash64 with xxh3+_64bits @MaskRay This PR does not change the hashing scheme at all. https://github.com/llvm/llvm-project/pull/121070 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-10 Thread Scott Constable via cfe-commits
@@ -254,6 +254,7 @@ FEATURE(is_trivially_constructible, LangOpts.CPlusPlus) FEATURE(is_trivially_copyable, LangOpts.CPlusPlus) FEATURE(is_union, LangOpts.CPlusPlus) FEATURE(kcfi, LangOpts.Sanitize.has(SanitizerKind::KCFI)) +FEATURE(kcfi_x86_arity, LangOpts.Sanitize.has(Sanitize

[clang] [OpenMP] codegen support for masked combined construct parallel masked taskloop simd. (PR #121746)

2025-01-10 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/121746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64] Changes in fmv-features metadata. (PR #122192)

2025-01-10 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-5` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/12600 Here is th

[clang] [InstrProf] Add frontend temporal profiling flag (PR #122385)

2025-01-10 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg updated https://github.com/llvm/llvm-project/pull/122385 >From 28e1eb2d0383bf417f8f769f6964eacb02a45477 Mon Sep 17 00:00:00 2001 From: Ellis Hoag Date: Thu, 9 Jan 2025 14:51:13 -0800 Subject: [PATCH 1/3] [InstrProf] Add frontent temporal profiling flag --- clang/inc

[clang-tools-extra] Initialize value. (PR #122339)

2025-01-10 Thread Tom Honermann via cfe-commits
tahonermann wrote: The static analysis tool produced a false positive; I see no reason for a change. The static analyzer failed to recognize that `APValue::Kind` is initialized to `None` during default construction of the `EvalResult` variable and that it can't have changed by the time the var

[clang] [OpenMP] codegen support for masked combined construct masked taskloop simd (PR #121916)

2025-01-10 Thread CHANDRA GHALE via cfe-commits
chandraghale wrote: @alexey-bataev Can you approve this and rest of splitted PRs [121914](https://github.com/llvm/llvm-project/pull/121914) and [121746](https://github.com/llvm/llvm-project/pull/121746 ) is the part of combined masked construct [PR-121741](https://github.com/llvm/llvm-pro

[clang] [InstrProf] Add frontend temporal profiling flag (PR #122385)

2025-01-10 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg edited https://github.com/llvm/llvm-project/pull/122385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] codegen support for masked combined construct masked taskloop (PR #121914)

2025-01-10 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/121914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] codegen support for masked combined construct masked taskloop simd (PR #121916)

2025-01-10 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/121916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Qualcomm uC Xqciint (Interrupts) extension (PR #122256)

2025-01-10 Thread Sam Elliott via cfe-commits
@@ -313,6 +313,7 @@ enum OperandType : unsigned { OPERAND_UIMM8_LSB000, OPERAND_UIMM8_GE32, OPERAND_UIMM9_LSB000, + OPERAND_UIMM10, lenary wrote: Please can you add `CASE_OPERAND_UIMM(10)` to the right place in `RISCVInstrInfo::verifyInstruction`? htt

[clang] [NFC][analyzer][docs] Restore/remove orphaned images (PR #122481)

2025-01-10 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) Changes When commit 61a76f58ebf1 converted the static analyzer FAQ from HTML to RST, it accidentally left out three images (`example_*.png`)

[clang] b43c97c - [Headers][X86] amxintrin.h - fix attributes according to Intel SDM (#122204)

2025-01-10 Thread via cfe-commits
Author: Evgenii Kudriashov Date: 2025-01-10T17:52:09+01:00 New Revision: b43c97c2ddfe9e922bb044de01312adb81591a48 URL: https://github.com/llvm/llvm-project/commit/b43c97c2ddfe9e922bb044de01312adb81591a48 DIFF: https://github.com/llvm/llvm-project/commit/b43c97c2ddfe9e922bb044de01312adb81591a48.

[clang] [Headers][X86] amxintrin.h - fix attributes according to Intel SDM (PR #122204)

2025-01-10 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud closed https://github.com/llvm/llvm-project/pull/122204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Support] Reduce globaal variable overhead after #121663 (PR #122429)

2025-01-10 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/122429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Ilya Biryukov via cfe-commits
@@ -3708,9 +3709,9 @@ void Parser::ParseDeclarationSpecifiers( continue; if (PA.getKind() == ParsedAttr::AT_LifetimeBound) -Diag(PA.getLoc(), diag::err_attribute_wrong_decl_type_str) ilya-biryukov wrote: Do we have any instan

[clang] [clang] Refactor attr diagnostics to use %select (PR #122473)

2025-01-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/122473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 953beb9 - [CUDA] Move CUDA to new driver by default (#122312)

2025-01-10 Thread via cfe-commits
Author: Joseph Huber Date: 2025-01-10T10:58:26-06:00 New Revision: 953beb9fe969bf8ab1857924ea0d3dd6ea506ab1 URL: https://github.com/llvm/llvm-project/commit/953beb9fe969bf8ab1857924ea0d3dd6ea506ab1 DIFF: https://github.com/llvm/llvm-project/commit/953beb9fe969bf8ab1857924ea0d3dd6ea506ab1.diff

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

2025-01-10 Thread Hans Wennborg via cfe-commits
@@ -58,6 +58,26 @@ code bases. containing strict-aliasing violations. The new default behavior can be disabled using ``-fno-pointer-tbaa``. +- Clang will now more aggressively use undefined behavior on pointer addition + overflow for optimization purposes. For example, a

[clang] [CUDA] Move CUDA to new driver by default (PR #122312)

2025-01-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/122312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Support] Reduce globaal variable overhead after #121663 (PR #122429)

2025-01-10 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/122429 >From 320ab02a1a3602ac1191d507c67141f330da718b Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 9 Jan 2025 23:10:58 -0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

2025-01-10 Thread Yanzuo Liu via cfe-commits
zwuis wrote: Do we need a test case about explicit object member function? i.e. ```cpp template int get(this triple); template<> int get<0>(this triple t) { return /* ... */; } ``` https://github.com/llvm/llvm-project/pull/122265 ___ cfe-commits mailin

[clang] [llvm] [Support] Reduce globaal variable overhead after #121663 (PR #122429)

2025-01-10 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/122429 >From 320ab02a1a3602ac1191d507c67141f330da718b Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 9 Jan 2025 23:10:58 -0800 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

2025-01-10 Thread Hans Wennborg via cfe-commits
@@ -58,6 +58,26 @@ code bases. containing strict-aliasing violations. The new default behavior can be disabled using ``-fno-pointer-tbaa``. +- Clang will now more aggressively use undefined behavior on pointer addition zmodem wrote: Fair enough. https://

[clang] [Darwin][Driver][clang] arm64-apple-none-macho is missing the Apple macros from arm-apple-none-macho (PR #122427)

2025-01-10 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/122427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Allow using PrintingPolicy with types (PR #122386)

2025-01-10 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum approved this pull request. Thanks for the PR! Please also add a corresponding release note for `Type.pretty_printed` in the Python bindings section. Otherwise, LGTM! https://github.com/llvm/llvm-project/pull/122386 ___

[clang] [FMV][AArch64] Changes in fmv-features metadata. (PR #122192)

2025-01-10 Thread Jon Roelofs via cfe-commits
@@ -2763,9 +2764,10 @@ bool CodeGenModule::GetCPUAndFeaturesAttributes(GlobalDecl GD, Attrs.addAttribute("fmv-features"); AddedAttr = true; } else if (!Feats.empty()) { - llvm::sort(Feats); + // Sort features and remove duplicates. + std::set Ord

[clang] [llvm] [HLSL] Implement elementwise firstbitlow builtin (PR #116858)

2025-01-10 Thread Ashley Coleman via cfe-commits
@@ -3181,136 +3193,250 @@ Register SPIRVInstructionSelector::buildPointerToResource( return AcReg; } -bool SPIRVInstructionSelector::selectFirstBitHigh16(Register ResVReg, -const SPIRVType *ResType, -

<    1   2   3   4   5   >