[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-15 Thread via cfe-commits
leijurv wrote: Ping 🙏 https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BoundsChecking] Add parameters to pass (PR #119894)

2024-12-15 Thread Thurston Dang via cfe-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/119894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix crashes when the macro expansion is empty (PR #119428)

2024-12-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f4081711f0884ec7afe93577e118ecc89cb7b1cf 1e79973ed4ea56c66f8b7eb1db9d00784edac7f0 --e

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-15 Thread Shao-Ce SUN via cfe-commits
@@ -22,11 +22,17 @@ // uses the record name by replacing Feature with Has. // value - Value to assign to the field in RISCVSubtarget when this // extension is enabled. Usually "true", but can be changed. -class RISCVExtension implies = [],

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-15 Thread Pengcheng Wang via cfe-commits
@@ -22,11 +22,20 @@ // uses the record name by replacing Feature with Has. // value - Value to assign to the field in RISCVSubtarget when this // extension is enabled. Usually "true", but can be changed. -class RISCVExtension implies = [],

[clang] [llvm] [PAC][ELF][AArch64] Support signed personality function pointer (PR #119361)

2024-12-15 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/119361 >From 944b2f8fb6357c5ef9efbdaf0c2c3dcd8cb9f890 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Tue, 10 Dec 2024 08:48:09 +0300 Subject: [PATCH 1/2] [PAC][ELF][AArch64] Support signed personality function p

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-15 Thread Pengcheng Wang via cfe-commits
@@ -22,11 +22,20 @@ // uses the record name by replacing Feature with Has. // value - Value to assign to the field in RISCVSubtarget when this // extension is enabled. Usually "true", but can be changed. -class RISCVExtension implies = [],

[clang] f65a21a - [PAC][ELF][AArch64] Support signed personality function pointer (#119361)

2024-12-15 Thread via cfe-commits
Author: Daniil Kovalev Date: 2024-12-16T10:24:09+03:00 New Revision: f65a21a4ecc2e712c700c59842b6b9a1d2a9a060 URL: https://github.com/llvm/llvm-project/commit/f65a21a4ecc2e712c700c59842b6b9a1d2a9a060 DIFF: https://github.com/llvm/llvm-project/commit/f65a21a4ecc2e712c700c59842b6b9a1d2a9a060.diff

[clang] [llvm] [PAC][ELF][AArch64] Support signed personality function pointer (PR #119361)

2024-12-15 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 closed https://github.com/llvm/llvm-project/pull/119361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-15 Thread Shao-Ce SUN via cfe-commits
@@ -22,11 +22,20 @@ // uses the record name by replacing Feature with Has. // value - Value to assign to the field in RISCVSubtarget when this // extension is enabled. Usually "true", but can be changed. -class RISCVExtension implies = [],

[libunwind] eb1f9cc - [libunwind] Fix compilation for the x32 ABI. (#116608)

2024-12-15 Thread via cfe-commits
Author: Alex Rønne Petersen Date: 2024-12-15T05:57:51-05:00 New Revision: eb1f9cced9e878362aeac18e120895995f759ee3 URL: https://github.com/llvm/llvm-project/commit/eb1f9cced9e878362aeac18e120895995f759ee3 DIFF: https://github.com/llvm/llvm-project/commit/eb1f9cced9e878362aeac18e120895995f759ee3

[libunwind] [libunwind] Fix compilation for the x32 ABI. (PR #116608)

2024-12-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/116608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Re-land "support outgoing calls in call hierarchy" (PR #117673)

2024-12-15 Thread via cfe-commits
pidgeon777 wrote: > > I would appreciate confirmation that this will indeed be possible with the > > upcoming **clangd** changes. > > Yes, the returned data is sufficient for clients to implement either of the > above presentations. This is great news, thank you! https://github.com/llvm/llvm

[clang-tools-extra] e1271dd - [clangd] Index reserved symbols from `*intrin.h` system headers (#119735)

2024-12-15 Thread via cfe-commits
Author: Joseph Huber Date: 2024-12-15T08:04:47-06:00 New Revision: e1271dd5a7ecf5cee59c8e2684b93501a1aab82d URL: https://github.com/llvm/llvm-project/commit/e1271dd5a7ecf5cee59c8e2684b93501a1aab82d DIFF: https://github.com/llvm/llvm-project/commit/e1271dd5a7ecf5cee59c8e2684b93501a1aab82d.diff

[clang-tools-extra] [clangd] Index reserved symbols from `*intrin.h` system headers (PR #119735)

2024-12-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/119735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [flang] [libc] [llvm] [polly] [cmake] Drop `AddFileDependencies` and `CMakeParseArguments` (PR #120002)

2024-12-15 Thread via cfe-commits
https://github.com/lntue approved this pull request. LGTM for the libc changes. https://github.com/llvm/llvm-project/pull/120002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Do not show `aParam` parameter hint for argument spelled `param` (PR #119162)

2024-12-15 Thread via cfe-commits
@@ -867,13 +867,28 @@ class InlayHintVisitor : public RecursiveASTVisitor { } } + static bool argumentMatchesParamName(StringRef ArgName, StringRef ParamName) { +// Exact match. +if (ParamName == ArgName) + return true; + +// Parameter name uses "a" p

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-15 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 56670608becf2032867405778fa7b2b1a36fb3cf Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 08:07:59 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang] [Tooling/Inclusion] Update std symbol mapping (PR #118174)

2024-12-15 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 edited https://github.com/llvm/llvm-project/pull/118174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [Clang] Rename GPU intrinsic functions from `__gpu_` to `_gpu_` (PR #118674)

2024-12-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/118674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tooling/Inclusion] Update std symbol mapping (PR #118174)

2024-12-15 Thread Vadim D. via cfe-commits
vvd170501 wrote: @kadircet, could you review this PR or assign someone else? https://github.com/llvm/llvm-project/pull/118174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/120004 follow up patch for #119948. >From b3b848df1a985754580ebbaa5f8136cb2c6bf3d6 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sun, 15 Dec 2024 12:19:55 +0800 Subject: [PATCH] [clang-tidy][NFC] use local co

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes follow up patch for #119948. --- Full diff: https://github.com/llvm/llvm-project/pull/120004.diff 11 Files Affected: - (modified) clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp

[clang] [libc] [Clang] Rename GPU intrinsic functions from `__gpu_` to `_gpu_` (PR #118674)

2024-12-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Unnecessary after updating clangd. https://github.com/llvm/llvm-project/pull/118674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread via cfe-commits
EugeneZelenko wrote: Please mention changes in Release Notes. https://github.com/llvm/llvm-project/pull/119974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-15 Thread Oren Benita Ben Simhon via cfe-commits
@@ -78,6 +78,19 @@ def GENERIC_RV64 : RISCVProcessorModel<"generic-rv64", // to change to the appropriate rv32/rv64 version. def GENERIC : RISCVTuneProcessorModel<"generic", NoSchedModel>, GenericTuneInfo; +def MIPS_P8700 : RISCVProcessorModel<"mips-p8700", +

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-15 Thread via cfe-commits
@@ -0,0 +1,54 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --filter-out "// kill:" --version 4 +; RUN: llc -force-streaming < %s | FileCheck %s +target triple = "aarch64-linux" + +define void @test_fvdot16_1x2_indexed(i32 %slice.0, +

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-15 Thread via cfe-commits
@@ -5882,3 +5882,14 @@ multiclass sme2_fp8_fdot_index_za32_vg1x4; } + +multiclass sme2_fp8_fdotv_index_za32_vg1x4 { + def NAME : sme2_fp8_multi_vec_array_vg4_index, +SMEPseudo2Instr { +let Uses=[FPMR, FPCR]; Spence

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-15 Thread via cfe-commits
@@ -748,11 +748,16 @@ let SMETargetGuard = "sme2" in { let SMETargetGuard = "sme-f8f32" in { def SVDOT_LANE_FP8_ZA32_VG1x2 : Inst<"svdot_lane_za32[_mf8]_vg1x2_fpm", "vm2di>", "m", MergeNone, "aarch64_sme_fp8_fdot_lane_za32_vg1x2", [IsStreaming, IsInOutZA, SetsFPMR, IsOverloa

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-15 Thread via cfe-commits
@@ -5882,3 +5882,14 @@ multiclass sme2_fp8_fdot_index_za32_vg1x4; } + +multiclass sme2_fp8_fdotv_index_za32_vg1x4 { + def NAME : sme2_fp8_multi_vec_array_vg4_index, +SMEPseudo2Instr { +let Uses=[FPMR, FPCR]; + } + + def _PSEUDO :

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-15 Thread via cfe-commits
@@ -664,11 +664,22 @@ StmtResult Sema::ActOnGCCAsmStmt(SourceLocation AsmLoc, bool IsSimple, SmallerValueMentioned |= OutSize < InSize; } +// If the input is an integer register while the output is floating point, +// there is no way they can work together.

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-15 Thread via cfe-commits
@@ -365,3 +365,9 @@ void test19(long long x) // FIXME: This case should be supported by codegen, but it fails now. asm ("" : "=rm" (x): "0" (e)); // expected-error {{unsupported inline asm: input with type 'st_size128' (aka 'struct _st_size128') matching output with type '

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2024-12-15 Thread via cfe-commits
@@ -11774,6 +11774,9 @@ def err_omp_clause_requires_dispatch_construct : Error< "'%0' clause requires 'dispatch' context selector">; def err_omp_append_args_with_varargs : Error< "'append_args' is not allowed with varargs functions">; +def warn_omp_dispatch_clause_novariant

[clang] [compiler-rt] [flang] [libc] [llvm] [polly] [cmake] Drop `AddFileDependencies` and `CMakeParseArguments` (PR #120002)

2024-12-15 Thread via cfe-commits
https://github.com/paperchalice created https://github.com/llvm/llvm-project/pull/120002 Theses modules are deprecated and have trivial implementations in modern cmake. >From 7d7d410e4893de02f69309c5e95f58c949df643a Mon Sep 17 00:00:00 2001 From: PaperChalice Date: Sat, 14 Dec 2024 15:50:00 +0

[clang] [compiler-rt] [flang] [libc] [llvm] [polly] [cmake] Drop `AddFileDependencies` and `CMakeParseArguments` (PR #120002)

2024-12-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (paperchalice) Changes Theses modules are deprecated and have trivial implementations in modern cmake. --- Full diff: https://github.com/llvm/llvm-project/pull/120002.diff 8 Files Affected: - (modified) clang/CMakeLists.txt (-1) -

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2024-12-15 Thread via cfe-commits
@@ -5965,6 +5967,264 @@ static bool teamsLoopCanBeParallelFor(Stmt *AStmt, Sema &SemaRef) { return Checker.teamsLoopCanBeParallelFor(); } +static Expr *getInitialExprFromCapturedExpr(Expr *Cond) { + + Expr *SubExpr = Cond->IgnoreParenImpCasts(); + + if (auto *DeclRef = dy

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2024-12-15 Thread via cfe-commits
@@ -11774,6 +11774,9 @@ def err_omp_clause_requires_dispatch_construct : Error< "'%0' clause requires 'dispatch' context selector">; def err_omp_append_args_with_varargs : Error< "'append_args' is not allowed with varargs functions">; +def warn_omp_dispatch_clause_novariant

[clang] e869103 - [webkit.UncountedLambdaCapturesChecker] Add a fallback for checking lambda captures (#119800)

2024-12-15 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-12-15T13:32:29-08:00 New Revision: e86910337f98e57f5b9253f7d80d5b916eb1d97e URL: https://github.com/llvm/llvm-project/commit/e86910337f98e57f5b9253f7d80d5b916eb1d97e DIFF: https://github.com/llvm/llvm-project/commit/e86910337f98e57f5b9253f7d80d5b916eb1d97e.diff

[clang] [webkit.UncountedLambdaCapturesChecker] Add a fallback for checking lambda captures (PR #119800)

2024-12-15 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Great. Thanks for the review. https://github.com/llvm/llvm-project/pull/119800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-15 Thread via cfe-commits
https://github.com/SpencerAbson edited https://github.com/llvm/llvm-project/pull/119922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Add a fallback for checking lambda captures (PR #119800)

2024-12-15 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/119800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-15 Thread via cfe-commits
https://github.com/SpencerAbson edited https://github.com/llvm/llvm-project/pull/119922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BoundsChecking] Add parameters to pass (PR #119894)

2024-12-15 Thread Fangrui Song via cfe-commits
@@ -1286,6 +1286,33 @@ Expected parseRtSanPassOptions(StringRef Params) { return Result; } +Expected +parseBoundsCheckingOptions(StringRef Params) { + BoundsCheckingPass::ReportingMode Mode = + BoundsCheckingPass::ReportingMode::Trap; + while (!Params.empty()) { +

[clang] [llvm] [BoundsChecking] Add parameters to pass (PR #119894)

2024-12-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/119894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][ELF][AArch64] Support signed personality function pointer (PR #119361)

2024-12-15 Thread Fangrui Song via cfe-commits
@@ -59,3 +61,13 @@ MachineModuleInfoImpl::ExprStubListTy MachineModuleInfoImpl::getSortedExprStubs( ExprStubs.clear(); return List; } + +MachineModuleInfoELF::MachineModuleInfoELF(const MachineModuleInfo &MMI) { + const Module *M = MMI.getModule(); + const auto *Flag = m

[clang] [llvm] [PAC][ELF][AArch64] Support signed personality function pointer (PR #119361)

2024-12-15 Thread Fangrui Song via cfe-commits
@@ -431,6 +432,13 @@ void TargetLoweringObjectFileELF::emitPersonalityValue( Streamer.emitELFSize(Label, E); Streamer.emitLabel(Label); + emitPersonalityValueImpl(Streamer, DL, Sym, MMI); +} + +void TargetLoweringObjectFileELF::emitPersonalityValueImpl( +MCStreamer &S

[clang] [llvm] [PAC][ELF][AArch64] Support signed personality function pointer (PR #119361)

2024-12-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/119361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Do not show `aParam` parameter hint for argument spelled `param` (PR #119162)

2024-12-15 Thread Nathan Ridge via cfe-commits
@@ -867,13 +867,28 @@ class InlayHintVisitor : public RecursiveASTVisitor { } } + static bool argumentMatchesParamName(StringRef ArgName, StringRef ParamName) { +// Exact match. +if (ParamName == ArgName) + return true; + +// Parameter name uses "a" p

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-15 Thread Matt Arsenault via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-15 Thread Jeremy Morse via cfe-commits
jmorse wrote: Indeed @ the language, it's difficult to know that this is definitely going to work when I don't have a full understanding of the patch series, thus the caution, I've studied a bit further and even with the full patch series we seem to be missing an important link. Here's a gist

[clang] [FMV][AArch64] Emit mangled default version if explicitly specified. (PR #120022)

2024-12-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes Curently we need at least one more version other than the default to trigger FMV. However we would like a header file declaration __attribute__((target_version("default"))) void f(void); to guaran

[clang] [FMV][AArch64] Emit mangled default version if explicitly specified. (PR #120022)

2024-12-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/120022 Curently we need at least one more version other than the default to trigger FMV. However we would like a header file declaration __attribute__((target_version("default"))) void f(void); to guarantee that the

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-15 Thread Jeremy Morse via cfe-commits
jmorse wrote: (" it lacks the DW_AT_abstract_origin that gcc produces..." for the DW_TAG_lexical_scopes referring back to the abstract/declaration subprogram). https://github.com/llvm/llvm-project/pull/119001 ___ cfe-commits mailing list cfe-commits@l

[clang] [FMV][AArch64] Emit mangled default version if explicitly specified. (PR #120022)

2024-12-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/120022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Recover necessary AddrSpaceCast (PR #119246)

2024-12-15 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/119246 >From 9dbcf65775a979553bee2c95b16e3e2328e957a1 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Mon, 9 Dec 2024 10:33:18 -0600 Subject: [PATCH 1/3] [clang] Recover necessary AddrSpaceCast A necessary AddrSpace

[clang] 1464b8e - Revert "Move interceptors for libresolv functions to MSan (#119071)"

2024-12-15 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-12-15T14:04:56-05:00 New Revision: 1464b8ec8a675fd11dc7280db1c56aac03771b0a URL: https://github.com/llvm/llvm-project/commit/1464b8ec8a675fd11dc7280db1c56aac03771b0a DIFF: https://github.com/llvm/llvm-project/commit/1464b8ec8a675fd11dc7280db1c56aac03771b0a.diff LO

[clang] 5004622 - Revert "[Driver] Cache SanitizerArgs (NFC) (#119442)"

2024-12-15 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-12-15T14:04:55-05:00 New Revision: 50046221b8e913ec6506eb96ce4c0cd267a5cc99 URL: https://github.com/llvm/llvm-project/commit/50046221b8e913ec6506eb96ce4c0cd267a5cc99 DIFF: https://github.com/llvm/llvm-project/commit/50046221b8e913ec6506eb96ce4c0cd267a5cc99.diff LO

[clang] [compiler-rt] Move interceptors for libresolv functions to MSan (PR #119071)

2024-12-15 Thread Nico Weber via cfe-commits
nico wrote: I reverted this in 1464b8ec8a675fd11dc7280db1c56aac03771b0a for now. https://github.com/llvm/llvm-project/pull/119071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Carlos Galvez via cfe-commits
@@ -26,7 +26,7 @@ class InconsistentDeclarationParameterNameCheck : public ClangTidyCheck { ClangTidyContext *Context) : ClangTidyCheck(Name, Context), IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), -

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Carlos Galvez via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy -check-suffix=STRICT %s cppcoreguidelines-pro-type-const-cast %t -- -config="{CheckOptions: {StrictMode: true}}" +// RUN: %check_clang_tidy -check-suffix=STRICT %s cppcoreguidelines-pro-type-const-cast %t -- -config="{CheckOptions:

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp commented: LGTM except the release notes, I think it would be more helpful to the users if we listed the changes explicitly. https://github.com/llvm/llvm-project/pull/120004 ___ cfe-commits mailing list cfe-commits@lis

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (Indexed) (PR #118549)

2024-12-15 Thread via cfe-commits
https://github.com/SpencerAbson updated https://github.com/llvm/llvm-project/pull/118549 >From 656465bfc10319c8864cefaf3423ac70881b88c9 Mon Sep 17 00:00:00 2001 From: Spencer Abson Date: Sun, 15 Dec 2024 20:28:08 + Subject: [PATCH] [AArch64] Implement intrinsics for SME FP8 FMAL/FMLALL (in

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-15 Thread Matt Arsenault via cfe-commits
@@ -1846,6 +1846,16 @@ class TargetInfo : public TransferrableTargetInfo, return std::make_pair(64, 64); } + /// Returns the optimal vector type elements based on the provided vector + /// type. For example, on some targets, a vector with 3 elements may be + /// treat

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-15 Thread Craig Topper via cfe-commits
@@ -2003,20 +2003,19 @@ llvm::Value *CodeGenFunction::EmitLoadOfScalar(Address Addr, bool Volatile, return EmitFromMemory(V, Ty); } -// Handle vectors of size 3 like size 4 for better performance. -const llvm::Type *EltTy = Addr.getElementType(); -const

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-15 Thread Craig Topper via cfe-commits
@@ -2146,21 +2145,21 @@ void CodeGenFunction::EmitStoreOfScalar(llvm::Value *Value, Address Addr, Addr = Addr.withPointer(Builder.CreateThreadLocalAddress(GV), NotKnownNonNull); + // Handles vectors of sizes that are likely to be expanded

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-15 Thread Matt Arsenault via cfe-commits
@@ -1,4 +1,5 @@ set(LLVM_LINK_COMPONENTS + Core arsenm wrote: This shouldn't be necessary. I think this code is in the wrong place, I would expect it to go in lib/CodeGen/Targets, not lib/Basic https://github.com/llvm/llvm-project/pull/104661

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-15 Thread Craig Topper via cfe-commits
@@ -1,4 +1,5 @@ set(LLVM_LINK_COMPONENTS + Core topperc wrote: Does this create additional dependencies on clang based tools that don't need to use LLVM IR? For example, clang-format? https://github.com/llvm/llvm-project/pull/104661 __

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-15 Thread Joseph Huber via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-15 Thread Matt Arsenault via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Julian Schmidt via cfe-commits
@@ -26,7 +26,7 @@ class InconsistentDeclarationParameterNameCheck : public ClangTidyCheck { ClangTidyContext *Context) : ClangTidyCheck(Name, Context), IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), -

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2024-12-15 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/117904 >From 1703aa62cfe35538aedbacb28e907535e838248c Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Fri, 20 Sep 2024 01:41:29 -0500 Subject: [PATCH 1/6] Support for dispatch construct (Sema & Codegen)

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Carlos Galvez via cfe-commits
@@ -115,6 +115,10 @@ Improvements to clang-tidy - Improved :program:`run-clang-tidy.py` script. Fixed minor shutdown noise happening on certain platforms when interrupting the script. +- Removed :program:`clang-tidy`'s global options for most of checks. All options

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Congcong Cai via cfe-commits
@@ -26,7 +26,7 @@ class InconsistentDeclarationParameterNameCheck : public ClangTidyCheck { ClangTidyContext *Context) : ClangTidyCheck(Name, Context), IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), -

[clang-tools-extra] [clang-tidy][NFC] use local config in test cases (PR #120004)

2024-12-15 Thread Congcong Cai via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy -check-suffix=STRICT %s cppcoreguidelines-pro-type-const-cast %t -- -config="{CheckOptions: {StrictMode: true}}" +// RUN: %check_clang_tidy -check-suffix=STRICT %s cppcoreguidelines-pro-type-const-cast %t -- -config="{CheckOptions:

[clang] [clang-tools-extra] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Julian Schmidt (5chmidti) Changes ```c++ static void foo(); void foo() {} struct A { static void bar(); }; void A::bar() {} ``` Both definitions refer to their previous declaration, but were not considered `static`, because the m

[clang] [clang-tools-extra] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/120027 ```c++ static void foo(); void foo() {} struct A { static void bar(); }; void A::bar() {} ``` Both definitions refer to their previous declaration, but were not considered `static`, because the matcher did

[clang] [clang-tools-extra] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/120027 >From 35a1cecb08d1827fb45c2e6bb06983ed363ca769 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Mon, 16 Dec 2024 01:18:06 +0100 Subject: [PATCH] [ASTMatchers] fix `isStaticStorageClass` not matching definit

[clang] [clang-tools-extra] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/120027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-15 Thread Jonas Toth via cfe-commits
https://github.com/JonasToth updated https://github.com/llvm/llvm-project/pull/118209 >From f7f570b3fa5a96cd3eb140abd02e4351a4586e26 Mon Sep 17 00:00:00 2001 From: Jonas Toth Date: Sun, 1 Dec 2024 12:02:13 +0100 Subject: [PATCH] [clang-tidy][docs] improve documentation on cppcoreguidelines-nar

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-15 Thread Jonas Toth via cfe-commits
@@ -27,6 +27,39 @@ This check will flag: - All applications of binary operators with a narrowing conversions. For example: ``int i; i+= 0.1;``. +Arithmetic with smaller integer types than ``int`` trigger implicit conversions, +as explained under `"Integral Promotion" on c

[clang] [compiler-rt] Move interceptors for libresolv functions to MSan (PR #119071)

2024-12-15 Thread Nico Weber via cfe-commits
nico wrote: This broke Linux/dn_expand.cpp on our bots, see https://issues.chromium.org/issues/384188036 https://github.com/llvm/llvm-project/pull/119071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (Indexed) (PR #118549)

2024-12-15 Thread via cfe-commits
https://github.com/SpencerAbson updated https://github.com/llvm/llvm-project/pull/118549 >From 411f907b30b75e55db27b9259b2eb9b2077d388d Mon Sep 17 00:00:00 2001 From: Spencer Abson Date: Mon, 25 Nov 2024 21:47:20 + Subject: [PATCH 1/3] [AArch64] Implement intrinsics for SME FP8 FMOPA ---

[clang] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/120027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/120027 >From 07dd31ddd40cdb792d33fc3394f6356de029a137 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Mon, 16 Dec 2024 01:28:42 +0100 Subject: [PATCH] [ASTMatchers] fix `isStaticStorageClass` not matching definit

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: > Not sure how many more tests I should add, since this uses the same code > paths as free functions. I think the amount of tests you've added are enough > This is the 5th instance of the `isStatic` matcher in clang-tidy. Good point, thanks. I've checked

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/119974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti ready_for_review https://github.com/llvm/llvm-project/pull/120027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread Julian Schmidt via cfe-commits
@@ -104,14 +104,16 @@ AST_MATCHER_FUNCTION_P(StatementMatcher, hasArgument(0, hasType(ReceiverType); } +AST_MATCHER(CXXMethodDecl, isStatic) { return Node.isStatic(); } + AST_MATCHER_FUNCTION(StatementMatcher, isConstRefReturningFunctionCal

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-15 Thread Shilei Tian via cfe-commits
shiltian wrote: gentle ping https://github.com/llvm/llvm-project/pull/104661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/119974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Add a fallback for checking lambda captures (PR #119800)

2024-12-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/10366 Here is the r

[clang] [compiler-rt] Move interceptors for libresolv functions to MSan (PR #119071)

2024-12-15 Thread Aaron Puchert via cfe-commits
aaronpuchert wrote: @nico, could you provide some more information? This didn't break on the lab.llvm.org infrastructure, and I'm not sure what's different in your build. Locally I also used a Release build with assertions on x86_64 on Linux. For what it's worth, the change simply moves the in

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread Barnabás Pőcze via cfe-commits
https://github.com/pobrn updated https://github.com/llvm/llvm-project/pull/119974 From fcacca26be4350d005c08a781bf4cee29abb404e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Sat, 14 Dec 2024 16:57:57 +0100 Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread Barnabás Pőcze via cfe-commits
https://github.com/pobrn updated https://github.com/llvm/llvm-project/pull/119974 From e9cd529ef486df9b5279aef974f136c63cb367ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Sat, 14 Dec 2024 16:57:57 +0100 Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-15 Thread Barnabás Pőcze via cfe-commits
pobrn wrote: > Please mention changes in Release Notes. Sorry, I hope it is fixed now. https://github.com/llvm/llvm-project/pull/119974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-12-15 Thread Jessica Clarke via cfe-commits
@@ -78,6 +78,19 @@ def GENERIC_RV64 : RISCVProcessorModel<"generic-rv64", // to change to the appropriate rv32/rv64 version. def GENERIC : RISCVTuneProcessorModel<"generic", NoSchedModel>, GenericTuneInfo; +def MIPS_P8700 : RISCVProcessorModel<"mips-p8700", +

[clang-tools-extra] [clang-tidy] fix cppcoreguidelines-narrowing-conversions false positives when narrowing integer to signed integer in C++20 (PR #116591)

2024-12-15 Thread Julian Schmidt via cfe-commits
5chmidti wrote: The move to bugprone makes sense to me. However, I'm not sure that conversions of integers to signed integers should be ignored-by-default since C++20. It may be well-defined behavior w.r.t. the resulting value, but the pattern is still prone to bugs. You will get a well-defi

[clang] [clang-format] Fix crashes when the macro expansion is empty (PR #119428)

2024-12-15 Thread Owen Pan via cfe-commits
owenca wrote: You should add unit tests in `clang/unittests/Format/`. https://github.com/llvm/llvm-project/pull/119428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][docs] improve documentation on cppcoreguidelines-narrowing-conversions (#111510) (PR #118209)

2024-12-15 Thread Jonas Toth via cfe-commits
https://github.com/JonasToth updated https://github.com/llvm/llvm-project/pull/118209 >From f4345664e10ac6a9e87b33b1e816b685a1355bb6 Mon Sep 17 00:00:00 2001 From: Jonas Toth Date: Sun, 1 Dec 2024 12:02:13 +0100 Subject: [PATCH 1/2] [clang-tidy][docs] improve documentation on cppcoreguidelines

  1   2   >