[clang] [clang-format] Add support for `.cjs` as JavaScript file extension (PR #118188)

2024-12-03 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/118188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add support for `.cjs` as JavaScript file extension (PR #118188)

2024-12-03 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/118188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add support for `.cjs` as JavaScript file extension (PR #118188)

2024-12-03 Thread via cfe-commits
github-actions[bot] wrote: @d3x0r Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, y

[clang] 56ab56c - [clang-format] Add support for `.cjs` as JavaScript file extension (#118188)

2024-12-03 Thread via cfe-commits
Author: Jim B Date: 2024-12-03T09:03:51-08:00 New Revision: 56ab56c85729976f29d5de2fd73912449cb6da7c URL: https://github.com/llvm/llvm-project/commit/56ab56c85729976f29d5de2fd73912449cb6da7c DIFF: https://github.com/llvm/llvm-project/commit/56ab56c85729976f29d5de2fd73912449cb6da7c.diff LOG: [c

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
shiltian wrote: * **#118515** https://app.graphite.dev/github/pr/llvm/llvm-project/118515?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/118

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/118515 None >From 537c973c88727c65faf39bd6e7e8d44b48837259 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 3 Dec 2024 11:25:37 -0500 Subject: [PATCH] [AMDGPU] Use COV6 by default --- clang/include/clang/Drive

[clang] [clang] Implement -fstrict-bool (PR #116732)

2024-12-03 Thread Devin Coughlin via cfe-commits
https://github.com/devincoughlin commented: You should split out the change to add the flag from the change to enable it by default for kernel/kexts. https://github.com/llvm/llvm-project/pull/116732 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [llvm] [PowerPC] Update data layout aligment of i128 to 16 (PR #118004)

2024-12-03 Thread Amy Kwan via cfe-commits
https://github.com/amy-kwan commented: For the most part, I think it looks good but I just have one comment about a change that (I think) doesn't need to happen. https://github.com/llvm/llvm-project/pull/118004 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [PowerPC] Update data layout aligment of i128 to 16 (PR #118004)

2024-12-03 Thread Amy Kwan via cfe-commits
https://github.com/amy-kwan edited https://github.com/llvm/llvm-project/pull/118004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Shilei Tian (shiltian) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/118515.diff 13 Files Affected: - (modified) clang/include/clang/Driver/Options.td (+5-5) - (modified) clang/lib/

[clang] [llvm] [PowerPC] Update data layout aligment of i128 to 16 (PR #118004)

2024-12-03 Thread Amy Kwan via cfe-commits
@@ -473,7 +473,7 @@ class LLVM_LIBRARY_VISIBILITY PS3PPUTargetInfo : public OSTargetInfo { this->IntMaxType = TargetInfo::SignedLongLong; this->Int64Type = TargetInfo::SignedLongLong; this->SizeType = TargetInfo::UnsignedInt; -this->resetDataLayout("E-m:e-p:32:

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-offload Author: Shilei Tian (shiltian) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/118515.diff 13 Files Affected: - (modified) clang/include/clang/Driver/Options.td (+5-5) - (modified) clang/lib/Driver/ToolChains/CommonArgs.cpp

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
shiltian wrote: @jplehr @ronlieb A heads-up for OpenMP folks. This change might be intrusive. https://github.com/llvm/llvm-project/pull/118515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: Does V6 have any nasty runtime changes associated with it? Or is it just recognizing the generic targets. https://github.com/llvm/llvm-project/pull/118515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang] Implement -fstrict-bool (PR #116732)

2024-12-03 Thread Devin Coughlin via cfe-commits
https://github.com/devincoughlin approved this pull request. https://github.com/llvm/llvm-project/pull/116732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
shiltian wrote: AFAIK it has nothing fancy for runtime. https://github.com/llvm/llvm-project/pull/118515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fstrict-bool (PR #116732)

2024-12-03 Thread Devin Coughlin via cfe-commits
@@ -6052,6 +6054,10 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX()) CmdArgs.push_back("-mconstructor-aliases"); + // Assume -fno-strict-bool in the Darwin kernel. + if (KernelOrKext) ---

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/118515 >From 169b95d90e1ae5660f400a65f8e5cd9a471accfb Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 3 Dec 2024 11:25:37 -0500 Subject: [PATCH] [AMDGPU] Use COV6 by default --- clang/include/clang/Driver/Opti

[clang] 5ae613c - [NFC] Remove trailing white spaces in `clang/include/clang/Driver/Options.td`

2024-12-03 Thread Shilei Tian via cfe-commits
Author: Shilei Tian Date: 2024-12-03T12:12:58-05:00 New Revision: 5ae613c9b9dc37ec1b0a6d76714099375288d772 URL: https://github.com/llvm/llvm-project/commit/5ae613c9b9dc37ec1b0a6d76714099375288d772 DIFF: https://github.com/llvm/llvm-project/commit/5ae613c9b9dc37ec1b0a6d76714099375288d772.diff L

[clang] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > AFAIK it has nothing fancy for runtime. The `libc` CMake has a variable that sets it to 5, might be worth bumping that up since it's actively tested. It's in the `prepare_libc_gpu_build.cmake`. https://github.com/llvm/llvm-project/pull/118515 __

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
shiltian wrote: > > AFAIK it has nothing fancy for runtime. > > The `libc` CMake has a variable that sets it to 5, might be worth bumping > that up since it's actively tested. It's in the > `prepare_libc_gpu_build.cmake`. Done. https://github.com/llvm/llvm-project/pull/118515 ___

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/118515 >From 57fa521750d902926d210eb9d783a9cbed71ef36 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 3 Dec 2024 11:25:37 -0500 Subject: [PATCH] [AMDGPU] Use COV6 by default --- clang/include/clang/Driver/Opti

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

2024-12-03 Thread Aaron Ballman via cfe-commits
@@ -6408,20 +6408,24 @@ def warn_bitfield_width_exceeds_type_width: Warning< def err_bitfield_too_wide : Error< "%select{bit-field %1|anonymous bit-field}0 is too wide (%2 bits)">; def warn_bitfield_too_small_for_enum : Warning< - "bit-field %0 is not wide enough to store al

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/118515 >From dc6f54cd68819ad280e004f3969fd61db94f31b4 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 3 Dec 2024 11:25:37 -0500 Subject: [PATCH] [AMDGPU] Use COV6 by default --- clang/docs/ReleaseNotes.rst

[clang] 95a4d30 - [NFC] Remove trailing white spaces in `clang/docs/ReleaseNotes.rst`

2024-12-03 Thread Shilei Tian via cfe-commits
Author: Shilei Tian Date: 2024-12-03T12:27:04-05:00 New Revision: 95a4d30b0d64c544106acf306c3d3fa5fde99c02 URL: https://github.com/llvm/llvm-project/commit/95a4d30b0d64c544106acf306c3d3fa5fde99c02 DIFF: https://github.com/llvm/llvm-project/commit/95a4d30b0d64c544106acf306c3d3fa5fde99c02.diff L

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/118515 >From 88df866f5d1cc7fef7bea0d938f9457a3969025b Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 3 Dec 2024 11:25:37 -0500 Subject: [PATCH] [AMDGPU] Use COV6 by default --- clang/docs/ReleaseNotes.rst

[libunwind] [libunwind][Haiku] Improve support (PR #115462)

2024-12-03 Thread Jérôme Duval via cfe-commits
https://github.com/korli updated https://github.com/llvm/llvm-project/pull/115462 From c88a3b1f8c8db4b222c0fdc306088a00bee54938 Mon Sep 17 00:00:00 2001 From: Trung Nguyen Date: Thu, 7 Jul 2022 22:19:34 +0700 Subject: [PATCH 1/3] [libunwind][Haiku] Improve support * Signal frame unwinding on x

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

2024-12-03 Thread Mészáros Gergely via cfe-commits
https://github.com/Maetveis created https://github.com/llvm/llvm-project/pull/118518 This is supported since CMake 3.12, it should be more portable too. This also avoids passing the option to `clang-cl` when linking, because `clang-cl` accepts any `-W` flags (normally warning flags) during lin

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mészáros Gergely (Maetveis) Changes This is supported since CMake 3.12, it should be more portable too. This also avoids passing the option to `clang-cl` when linking, because `clang-cl` accepts any `-W` flags (normally warning flags) dur

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

2024-12-03 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > So I take it we decided not to enable it by default in `-fms-compatibility` > > mode then? > > I don't believe it is appropriate to do so. The intent of this warning is to > indicate MSVC compatibility issues when building in non-ms-compatibility > modes. The existing

[clang] [llvm] [AArch64] Implement FP8 SVE intrinsics for widening conversions (PR #118123)

2024-12-03 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. Momchil, Thank you for the patch. It LGTM! I just would like before you push the patch to update the commit message with the prototypes you are implementing in this patch. So we can check with CVT it has implemented without having

[clang] [llvm] [WebAssembly] Support the new "Lime1" CPU (PR #112035)

2024-12-03 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode updated https://github.com/llvm/llvm-project/pull/112035 >From a42effda1d0e8c8fc1e59ea060018225fe9ba914 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Fri, 11 Oct 2024 04:30:32 -0700 Subject: [PATCH 1/4] [WebAssembly] Support the new "Lime1" CPU This adds WebAss

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

2024-12-03 Thread Mészáros Gergely via cfe-commits
https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/118518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-03 Thread Michael Toguchi via cfe-commits
mdtoguchi wrote: Ping https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][Haiku] Improve support (PR #115462)

2024-12-03 Thread Jérôme Duval via cfe-commits
@@ -2749,6 +2755,63 @@ int UnwindCursor::stepThroughSigReturn(Registers_arm64 &) { _isSignalFrame = true; return UNW_STEP_SUCCESS; } +#elif defined(_LIBUNWIND_TARGET_HAIKU) && defined(_LIBUNWIND_TARGET_X86_64) korli wrote: Done. https://github.com/llvm/ll

[clang] [Clang] Enable -fpointer-tbaa by default. (PR #117244)

2024-12-03 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > ping :) @AaronBallman WDYT re making this clear in the release notes (also > that there's an easy way to disable) + the ongoing work in parallel for the > type sanitizer? I think it's a reasonable experiment to try. I would call it a potentially breaking change because i

[clang] [clang] Apply internal buffering to clang diagnostics printing (PR #113440)

2024-12-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/113440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Apply internal buffering to clang diagnostics printing (PR #113440)

2024-12-03 Thread Aaron Ballman via cfe-commits
@@ -656,15 +656,19 @@ static bool printWordWrapped(raw_ostream &OS, StringRef Str, unsigned Columns, TextDiagnostic::TextDiagnostic(raw_ostream &OS, const LangOptions &LangOpts, DiagnosticOptions *DiagOpts, const Pr

[clang] [clang] Apply internal buffering to clang diagnostics printing (PR #113440)

2024-12-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: This feels like we're hacking around a deeper issue with raw_ostream; I would have expected that `SetBuffered()` is honored. But it also worries me that we're manually enabling colors in all circumstances and no tests broke. I'm also a bit worried we'

[clang] [clang] Apply internal buffering to clang diagnostics printing (PR #113440)

2024-12-03 Thread Aaron Ballman via cfe-commits
@@ -133,12 +133,16 @@ void TextDiagnosticPrinter::HandleDiagnostic(DiagnosticsEngine::Level Level, // diagnostics in a context that lacks language options, a source manager, or // other infrastructure necessary when emitting more rich diagnostics. if (!Info.getLocation()

[clang] [clang][bytecode] Handle bitcasts involving bitfields (PR #116843)

2024-12-03 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. Please update the PR summary so it makes more sense as a commit message. Otherwise, the changes seem reasonable to me. https://github.com/llvm/llvm-project/pul

[clang-tools-extra] Add new tool: clang-read-diagnostics (PR #118522)

2024-12-03 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,129 @@ +//=== ClangReadDiagnostics.cpp - clang-read-diagnostics tool --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Add new tool: clang-read-diagnostics (PR #118522)

2024-12-03 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,10 @@ +include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) jroelofs wrote: I'm not sure this is necessary. https://github.com/llvm/llvm-project/pull/118522 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: Why change the clang default only, and not the backend? https://github.com/llvm/llvm-project/pull/118515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang-tools-extra] Add new tool: clang-read-diagnostics (PR #118522)

2024-12-03 Thread Yuxuan Chen via cfe-commits
@@ -0,0 +1,10 @@ +include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) yuxuanchen1997 wrote: Oops... Copied from a boilerplate. https://github.com/llvm/llvm-project/pull/118522 ___ cfe-commits mailing list cfe-commits@

[clang] [aarch64] Add support for the __{inc|add}x18{byte|word|dword|qword intrinsics (PR #117752)

2024-12-03 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/117752 >From acbd8132ac9d9156abcaac1ab3bb2e1e2e434216 Mon Sep 17 00:00:00 2001 From: Daniel Paoliello Date: Tue, 26 Nov 2024 09:27:54 -0800 Subject: [PATCH] [AArch64] Add support for the __{inc|add}x18{byte|word|dw

[clang] [aarch64] Add support for the __{inc|add}x18{byte|word|dword|qword intrinsics (PR #117752)

2024-12-03 Thread Daniel Paoliello via cfe-commits
dpaoliello wrote: > Sorry, just spotted an issue: I don't think you're emitting the operations in > the correct order. You need to emit both arguments before you read the > register or load the value. > > If you have some non-trivial operation like a call in one of the arguments, > you don't

[clang] allow prefer 256 bit attribute target (PR #117092)

2024-12-03 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB closed https://github.com/llvm/llvm-project/pull/117092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ea6cdb9 - allow prefer 256 bit attribute target (#117092)

2024-12-03 Thread via cfe-commits
Author: Matthias Braun Date: 2024-12-03T15:01:28-08:00 New Revision: ea6cdb9a0708330089d583ce20aeaf81eec94ff7 URL: https://github.com/llvm/llvm-project/commit/ea6cdb9a0708330089d583ce20aeaf81eec94ff7 DIFF: https://github.com/llvm/llvm-project/commit/ea6cdb9a0708330089d583ce20aeaf81eec94ff7.diff

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
@@ -34,7 +34,7 @@ static llvm::cl::opt DefaultAMDHSACodeObjectVersion( "amdhsa-code-object-version", llvm::cl::Hidden, -llvm::cl::init(llvm::AMDGPU::AMDHSA_COV5), +llvm::cl::init(llvm::AMDGPU::AMDHSA_COV6), shiltian wrote: It does things. If we do

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/118515 >From af3d46f389a2b4e77f0d4681c1f62eca86c3140f Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 3 Dec 2024 11:25:37 -0500 Subject: [PATCH] [AMDGPU] Use COV6 by default --- clang/docs/ReleaseNotes.rst

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
@@ -34,7 +34,7 @@ static llvm::cl::opt DefaultAMDHSACodeObjectVersion( "amdhsa-code-object-version", llvm::cl::Hidden, -llvm::cl::init(llvm::AMDGPU::AMDHSA_COV5), +llvm::cl::init(llvm::AMDGPU::AMDHSA_COV6), shiltian wrote: > The .amdhsa_code_objec

[clang] allow prefer 256 bit attribute target (PR #117092)

2024-12-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/9167 Here is the relevant piece of the b

[clang] fdd09e9 - [ASTMatchers] AST matcher support for ObjC pointers (#117021)

2024-12-03 Thread via cfe-commits
Author: Rashmi Mudduluru Date: 2024-12-03T12:26:20-08:00 New Revision: fdd09e9de579e6915d467c1b72efb8c653739602 URL: https://github.com/llvm/llvm-project/commit/fdd09e9de579e6915d467c1b72efb8c653739602 DIFF: https://github.com/llvm/llvm-project/commit/fdd09e9de579e6915d467c1b72efb8c653739602.di

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2024-12-03 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > Suppose you have target_version("i8mm+dotprod") and target_version("fcma"). > The first version clearly has higher priority According to the [current rules](https://arm-software.github.io/acle/main/acle.html#selection) yes, but IMO that rule is broken and doesn't match user

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2024-12-03 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea converted_to_draft https://github.com/llvm/llvm-project/pull/118544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2024-12-03 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: > > Suppose you have target_version("i8mm+dotprod") and target_version("fcma"). > > The first version clearly has higher priority > > According to the [current > rules](https://arm-software.github.io/acle/main/acle.html#selection) yes, but > IMO that rule is broken and doesn'

[libcxx] [libunwind] [llvm] [libc++][libunwind] Fix documentation CI job after #118159 (PR #118555)

2024-12-03 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/118555 None >From b3b1cb221aa7388a3d72f1774c70392042139b04 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 3 Dec 2024 17:06:22 -0500 Subject: [PATCH 1/2] [libc++][libunwind] Fix documentation CI job after #118

[libcxx] [libunwind] [llvm] [libc++][libunwind] Fix documentation CI job after #118159 (PR #118555)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Louis Dionne (ldionne) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/118555.diff 3 Files Affected: - (modified) .github/workflows/docs.yml (+2-2) - (added) libcxx/docs/foo () - (added) libunwind/docs/foo ()

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
@@ -34,7 +34,7 @@ static llvm::cl::opt DefaultAMDHSACodeObjectVersion( "amdhsa-code-object-version", llvm::cl::Hidden, -llvm::cl::init(llvm::AMDGPU::AMDHSA_COV5), +llvm::cl::init(llvm::AMDGPU::AMDHSA_COV6), shiltian wrote: Not really. Nothing chan

[clang] [HLSL] get inout/out ABI for array parameters working (PR #111047)

2024-12-03 Thread Sarah Spall via cfe-commits
https://github.com/spall updated https://github.com/llvm/llvm-project/pull/111047 >From 119def060924f13bd1fe07f6d73ce27a1b52ea12 Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Tue, 17 Sep 2024 20:25:46 + Subject: [PATCH 1/8] theoretically fix issue --- clang/lib/Sema/SemaType.cpp | 4 ++

[clang] e2472d3 - Rework attr-target-x86 test (#117091)

2024-12-03 Thread via cfe-commits
Author: Matthias Braun Date: 2024-12-03T14:25:05-08:00 New Revision: e2472d3b120659ba7cd0e0dd0c6bf1260957fe47 URL: https://github.com/llvm/llvm-project/commit/e2472d3b120659ba7cd0e0dd0c6bf1260957fe47 DIFF: https://github.com/llvm/llvm-project/commit/e2472d3b120659ba7cd0e0dd0c6bf1260957fe47.diff

[clang] Rework attr-target-x86 test (PR #117091)

2024-12-03 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB closed https://github.com/llvm/llvm-project/pull/117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] allow prefer 256 bit attribute target (PR #117092)

2024-12-03 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/117092 >From 3bab9f901045426321d687fc36e4ba3034cc0f30 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Wed, 20 Nov 2024 17:23:56 -0800 Subject: [PATCH 1/2] Rework attr-target-x86 test Rework the attr-target-x86 test

[clang] [HLSL] Implement `Append` and `Consume` methods on `Append`/`ConsumeStructuredBuffer` (PR #118536)

2024-12-03 Thread Justin Bogner via cfe-commits
@@ -430,12 +432,20 @@ struct BuiltinTypeMethodBuilder { // Argument placeholders, inspired by std::placeholder. These are the indices // of arguments to forward to `callBuiltin`, and additionally `Handle` which // refers to the resource handle. - enum class PlaceHolder {

[clang] [HLSL] Implement `Append` and `Consume` methods on `Append`/`ConsumeStructuredBuffer` (PR #118536)

2024-12-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner commented: Looks basically good, but I'll hold off on approving until we've discussed my comment regarding the API. https://github.com/llvm/llvm-project/pull/118536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [HLSL] Implement `Append` and `Consume` methods on `Append`/`ConsumeStructuredBuffer` (PR #118536)

2024-12-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/118536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64][clang] Emit fmv-features metadata in LLVM IR. (PR #118544)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes We need to be able to propagate information about FMV attribute strings from C/C++ source to LLVM IR. This is necessary so that we can distinguish which target-features are coming from the cmdline,

[clang] [llvm] [Clang][Darwin] Introduce `SubFrameworks` as a SDK default location (PR #115048)

2024-12-03 Thread Cyndy Ishida via cfe-commits
@@ -346,6 +346,7 @@ void InitHeaderSearch::AddDefaultIncludePaths( AddPath("/System/DriverKit/System/Library/Frameworks", System, true); cyndyishida wrote: Followup in: https://github.com/llvm/llvm-project/pull/118543 https://github.com/llvm/llvm-projec

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (PR #118549)

2024-12-03 Thread via cfe-commits
https://github.com/SpencerAbson created https://github.com/llvm/llvm-project/pull/118549 This patch implements the following intrinsics: Multi-vector 8-bit floating-point multiply-add long. ``` c // Only if __ARM_FEATURE_SME_F8F16 != 0 void svmla_lane_za16[_mf8]_vg2x1_fpm(uint32_t slice, sv

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-03 Thread Steven Wu via cfe-commits
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths( if (triple.isOSDarwin()) { cachemeifyoucan wrote: Do you think we can just clean up this code block by moving all logics to driver? https://github.com/llvm/llvm-project/pull/118543

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-03 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan edited https://github.com/llvm/llvm-project/pull/118543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-03 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan commented: Some comments in line. https://github.com/llvm/llvm-project/pull/118543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a9bf16d - [StaticAnalyzer] Migrate away from PointerUnion::{is,get} (NFC) (#118421)

2024-12-03 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-12-03T13:53:20-08:00 New Revision: a9bf16d961e9bb0923b401bc26697c6ca707a1f5 URL: https://github.com/llvm/llvm-project/commit/a9bf16d961e9bb0923b401bc26697c6ca707a1f5 DIFF: https://github.com/llvm/llvm-project/commit/a9bf16d961e9bb0923b401bc26697c6ca707a1f5.diff L

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/118515 >From a0dfb34e2c0711826b5bbf5dc0ed15e87918fa27 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Tue, 3 Dec 2024 11:25:37 -0500 Subject: [PATCH] [AMDGPU] Use COV6 by default --- clang/docs/ReleaseNotes.rst

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Shilei Tian via cfe-commits
shiltian wrote: > Why change the clang default only, and not the backend? Yeah, initially I thought that was dictated by the front end but forgot we could invoke directly via `opt`, `llc`, etc. Done. https://github.com/llvm/llvm-project/pull/118515 _

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (PR #118549)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-clang-codegen Author: None (SpencerAbson) Changes This patch implements the following intrinsics: Multi-vector 8-bit floating-point multiply-add long. ``` c // Only if __ARM_FEATURE_SME_F8F16 != 0 void svmla_lane

[clang] [HLSL] get inout/out ABI for array parameters working (PR #111047)

2024-12-03 Thread Chris B via cfe-commits
@@ -5322,6 +5324,11 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, IRCallArgs[FirstIRArg] = Val; break; } + } else if (I->getType()->isArrayParameterType()) { +// use the tmp created by the HLSLOutArgExpr +/

[clang] [HLSL] get inout/out ABI for array parameters working (PR #111047)

2024-12-03 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/111047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-03 Thread Steven Wu via cfe-commits
@@ -192,6 +192,17 @@ class DarwinSDKInfo { Expected> parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS, StringRef SDKRootPath); +/// Get the system platform prefix for the active target triple. cachemeifyoucan wrote: I feel this header is used for parsing `SDKSet

[clang] [libc] [llvm] [AMDGPU] Use COV6 by default (PR #118515)

2024-12-03 Thread Matt Arsenault via cfe-commits
@@ -34,7 +34,7 @@ static llvm::cl::opt DefaultAMDHSACodeObjectVersion( "amdhsa-code-object-version", llvm::cl::Hidden, -llvm::cl::init(llvm::AMDGPU::AMDHSA_COV5), +llvm::cl::init(llvm::AMDGPU::AMDHSA_COV6), arsenm wrote: Missing test update for th

[clang] [Clang] Permit noescape on non-pointer types (PR #117344)

2024-12-03 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: > If that's the intended meaning, should we restrict this to structs that have > pointer fields? Yeah, that is the intended meaning. I am on the fence about restricting to structs with pointers though, mostly to more ergonomically support use cases like: ``` struct Sometimes

[clang] [StaticAnalyzer] Migrate away from PointerUnion::{is,get} (NFC) (PR #118421)

2024-12-03 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/118421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [XRay][RISCV] RISCV support for XRay (PR #117368)

2024-12-03 Thread Craig Topper via cfe-commits
@@ -57,6 +57,10 @@ static const int16_t cSledLength = 64; static const int16_t cSledLength = 8; #elif defined(__hexagon__) static const int16_t cSledLength = 20; +#elif SANITIZER_RISCV64 +static const int16_t cSledLength = 76; +#elif defined(__riscv) && (__riscv_xlen == 32) ---

[clang] [llvm] [IR] Allow fast math flags on fptrunc and fpext (PR #115894)

2024-12-03 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel approved this pull request. I think there's some followup work needed to get this working in SelectionDAG as well, but that can live in a separate patch (especially as we need to do a followup pass in DAGCombine to check for flags on the fpext/fptrunc nodes).

[clang-tools-extra] [clangd] Consolidate two functions converting index to LSP locations (PR #117885)

2024-12-03 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/117885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add new tool: clang-read-diagnostics (PR #118522)

2024-12-03 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/118522 >From 5860f5f25e04930c72dcdb9f0ee4d7386cbcb3d3 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Mon, 2 Dec 2024 15:15:30 -0800 Subject: [PATCH 1/7] start working on the new tool --- .../clang-read-diagn

[clang-tools-extra] Add new tool: clang-read-diagnostics (PR #118522)

2024-12-03 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/118522 >From 5860f5f25e04930c72dcdb9f0ee4d7386cbcb3d3 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Mon, 2 Dec 2024 15:15:30 -0800 Subject: [PATCH 1/8] start working on the new tool --- .../clang-read-diagn

[clang-tools-extra] [clangd][clang-tidy] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-03 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/118569 >From d2257eb43bbd9ce2dfd8a13123c2048e1cf8b439 Mon Sep 17 00:00:00 2001 From: chomosuke Date: Wed, 4 Dec 2024 00:07:31 + Subject: [PATCH 1/2] clangd cleanupAroundReplacements just as clang-tidy does ---

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-03 Thread Cyndy Ishida via cfe-commits
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths( if (triple.isOSDarwin()) { cyndyishida wrote: Looks like that was previously attempted by @ldionne in https://github.com/llvm/llvm-project/pull/75841 The problem was appending `/Library/F

[clang] [HLSL] get inout/out ABI for array parameters working (PR #111047)

2024-12-03 Thread Sarah Spall via cfe-commits
https://github.com/spall closed https://github.com/llvm/llvm-project/pull/111047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 46de3a7 - [HLSL] get inout/out ABI for array parameters working (#111047)

2024-12-03 Thread via cfe-commits
Author: Sarah Spall Date: 2024-12-03T17:43:36-08:00 New Revision: 46de3a7064250bd2dfc7f8dc6e300474afa9fa97 URL: https://github.com/llvm/llvm-project/commit/46de3a7064250bd2dfc7f8dc6e300474afa9fa97 DIFF: https://github.com/llvm/llvm-project/commit/46de3a7064250bd2dfc7f8dc6e300474afa9fa97.diff L

[clang] [Serialization] Downgrade error to warning for inconsistent language flags (PR #117840)

2024-12-03 Thread Ben Boeckel via cfe-commits
mathstuf wrote: > Really we would have to remove the preprocessor from C++ to be able to get > away from this. :clap: Maybe we can get a magic `-fno-preprocess` flag to say "I use no preprocessor shenanigans" and make always-compatible BMIs? Maybe then we could adapt the Fortran/ASM conventio

[clang] [CodeGen] Migrate away from PointerUnion::{is, get} (NFC) (PR #118600)

2024-12-03 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/118600 Note that PointerUnion::{is,get} have been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast I'm not touching

[clang] [CodeGen] Migrate away from PointerUnion::{is, get} (NFC) (PR #118600)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::{is,get} have been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast<

[clang] [mutation analyzer] support mutation analysis for pointee wip (PR #118593)

2024-12-03 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/118593 >From 01657045893c3fca226f0682523f999cabffc1ca Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 4 Dec 2024 15:38:06 +0800 Subject: [PATCH 1/2] [analysis] support mutation analysis for pointee wip ---

[clang] [mutation analyzer] support mutation analysis for pointee wip (PR #118593)

2024-12-03 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 ready_for_review https://github.com/llvm/llvm-project/pull/118593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mutation analyzer] support mutation analysis for pointee wip (PR #118593)

2024-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis @llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes --- Patch is 21.85 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/118593.diff 3 Files Affected: - (modified) clang/inc

[clang-tools-extra] 7be3326 - [clangd] Re-land "support outgoing calls in call hierarchy" (#117673)

2024-12-03 Thread via cfe-commits
Author: Nathan Ridge Date: 2024-12-04T01:07:57-05:00 New Revision: 7be3326200ef382705d8e6b2d7dc5378af96b34a URL: https://github.com/llvm/llvm-project/commit/7be3326200ef382705d8e6b2d7dc5378af96b34a DIFF: https://github.com/llvm/llvm-project/commit/7be3326200ef382705d8e6b2d7dc5378af96b34a.diff

[clang-tools-extra] [clangd] Re-land "support outgoing calls in call hierarchy" (PR #117673)

2024-12-03 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/117673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >