https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/117331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
I agree that having something tying these together would be nice, but should we
also tie them together at the `Type` level similarly, or just the `Decl` level?
https://github.com/llvm/llvm-project/pull/115056
___
cfe-commits mailin
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexrp wrote:
CI failure here seems unrelated:
https://github.com/llvm/llvm-project/actions/runs/11930420176/job/33253113656?pr=116608
https://github.com/llvm/llvm-project/pull/116608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
@@ -588,7 +588,7 @@ llvm::Function
*CGHLSLRuntime::createResourceBindingInitFn() {
auto *Slot = llvm::ConstantInt::get(CGM.IntTy, RBA->getSlotNumber());
// FIXME: resource arrays are not yet implemented
auto *Range = llvm::ConstantInt::get(CGM.IntTy, 1);
-
https://github.com/Fznamznon approved this pull request.
My concerns are resolved, sorry for holding this!
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
smanna12 wrote:
Thank you everyone for reviews.
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron commented:
This generally looks okay for the SPIR-V side.
https://github.com/llvm/llvm-project/pull/117017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smanna12 wrote:
> My concerns are resolved, sorry for holding this!
No worries. Thank you
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: smanna12
Date: 2024-11-22T08:41:20-06:00
New Revision: 4389220549285fc9ef1e96f762eafa5f79a5d1ee
URL:
https://github.com/llvm/llvm-project/commit/4389220549285fc9ef1e96f762eafa5f79a5d1ee
DIFF:
https://github.com/llvm/llvm-project/commit/4389220549285fc9ef1e96f762eafa5f79a5d1ee.diff
LOG:
https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
higher-performance wrote:
Huh, that's strange. Any idea why the warning isn't being emitted?
https://github.com/llvm/llvm-project/blob/672eaced6d114656315780140f105e3177742c41/clang/test/SemaCXX/uninitialized.cpp#L1516-L1522
I feel like the check looks correct:
https://github.com/llvm/llvm-pro
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clangd-ubuntu-tsan`
running on `clangd-ubuntu-clang` while building `clang` at step 6
"test-build-clangd-clangd-index-server-clangd-indexer-check-clangd".
Full details are available at:
https://lab.llvm.org/buildbot/#/builder
StefanPaulet wrote:
I did not remove the `AtEndOfTU` parameter from
`Sema::InstantiateVariableDefinition` as it breaks some tests related to
diagnostics (e.g. `SemaCXX/undefined-internal.cpp`) , as previously the
parameter could have been set to `true` although the end of the translation
unit
Author: Mikhail Goncharov
Date: 2024-11-22T14:09:13+01:00
New Revision: d1dae1e8612a2fa69d0d731e16d07baf8ce10c85
URL:
https://github.com/llvm/llvm-project/commit/d1dae1e8612a2fa69d0d731e16d07baf8ce10c85
DIFF:
https://github.com/llvm/llvm-project/commit/d1dae1e8612a2fa69d0d731e16d07baf8ce10c85.d
@@ -183,40 +210,47 @@ void UseStartsEndsWithCheck::check(const
MatchFinder::MatchResult &Result) {
const auto *EndsWithFunction =
Result.Nodes.getNodeAs("ends_with_fun");
assert(bool(StartsWithFunction) != bool(EndsWithFunction));
+
const CXXMethodDecl *Replacemen
@@ -240,6 +240,9 @@ void UseStartsEndsWithCheck::check(const
MatchFinder::MatchResult &Result) {
ReplacementFunction->getName());
// Replace arguments and everything after the function call.
+ if (FindExpr->getNumArgs() == 0) {
+r
@@ -13,79 +13,88 @@
using namespace clang::ast_matchers;
namespace clang::tidy::cppcoreguidelines {
-namespace {
-AST_MATCHER(FieldDecl, isMemberOfLambda) {
- return Node.getParent()->isLambda();
+static bool hasCopyConstructor(CXXRecordDecl const &Node) {
+ if (Node.needs
https://github.com/sunfishcode updated
https://github.com/llvm/llvm-project/pull/117087
>From 48808d43f41b61a419790fd25f99b5e897e5a419 Mon Sep 17 00:00:00 2001
From: Dan Gohman
Date: Fri, 11 Oct 2024 04:30:32 -0700
Subject: [PATCH 01/15] [WebAssembly] Define call-indirect-overlong and
bulk-mem
@@ -1,7 +1,7 @@
-; RUN: llc < %s -asm-verbose=false -verify-machineinstrs
-disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals
-wasm-keep-registers -mcpu=mvp -mattr=+bulk-memory | FileCheck %s
--check-prefixes CHECK,BULK-MEM
-; RUN: llc < %s -asm-verbose=false -ve
@@ -0,0 +1,179 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/tahonermann commented:
This is looking good to me. I added some questions and noted a couple of
potential concerns for which I'm not well equipped to have an opinion on.
Perhaps others can offer their thoughts on those.
https://github.com/llvm/llvm-project/pull/117268
__
@@ -6591,6 +6681,18 @@ const ToolChain &Driver::getOffloadingDeviceToolChain(
HostTC, Args);
break;
}
+case Action::OFK_SYCL:
+ switch (Target.getArch()) {
+ case llvm::Triple::spir:
+ case
@@ -0,0 +1,179 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/tahonermann edited
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
drmdanowar wrote:
This is the most important part
https://github.com/llvm/llvm-project/pull/111434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6782,16 +6783,21 @@ defm : FlangIgnoredDiagOpt<"frontend-loop-interchange">;
defm : FlangIgnoredDiagOpt<"target-lifetime">;
// C++ SYCL options
+let Group = sycl_Group in {
def fsycl : Flag<["-"], "fsycl">,
- Visibility<[ClangOption, CLOption]>,
- Group, HelpText<"Enabl
@@ -588,7 +588,7 @@ llvm::Function
*CGHLSLRuntime::createResourceBindingInitFn() {
auto *Slot = llvm::ConstantInt::get(CGM.IntTy, RBA->getSlotNumber());
// FIXME: resource arrays are not yet implemented
auto *Range = llvm::ConstantInt::get(CGM.IntTy, 1);
-
Arthapz wrote:
i tried it for a while, it work very well ! thx u
https://github.com/llvm/llvm-project/pull/106683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -112,6 +112,8 @@ class MCTargetOptions {
// Whether or not to use full register names on PowerPC.
bool PPCUseFullRegisterNames : 1;
+ bool PgoInstrumentation = false;
mikolaj-pirog wrote:
As far as I am aware, there isn't any global metadata flag I co
Author: Pengcheng Wang
Date: 2024-11-22T22:58:54+08:00
New Revision: 875b10f7d0888ca7e53f527f4c30531bd6b50bfb
URL:
https://github.com/llvm/llvm-project/commit/875b10f7d0888ca7e53f527f4c30531bd6b50bfb
DIFF:
https://github.com/llvm/llvm-project/commit/875b10f7d0888ca7e53f527f4c30531bd6b50bfb.diff
Author: Utkarsh Saxena
Date: 2024-11-22T16:01:16+01:00
New Revision: 912c502a9e4bab8e07de4419f8cbae35c98b112f
URL:
https://github.com/llvm/llvm-project/commit/912c502a9e4bab8e07de4419f8cbae35c98b112f
DIFF:
https://github.com/llvm/llvm-project/commit/912c502a9e4bab8e07de4419f8cbae35c98b112f.diff
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/117122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/higher-performance updated
https://github.com/llvm/llvm-project/pull/102040
>From e98e6f210f02af0813393d88e1bc4f02c0682e5f Mon Sep 17 00:00:00 2001
From: higher-performance
Date: Mon, 5 Aug 2024 15:04:19 -0400
Subject: [PATCH 01/11] Add Clang attribute to ensure that fields a
@@ -1677,6 +1677,22 @@ MCSection
*TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
/*AddSegmentInfo=*/false))
Kind = SectionKind::getMetadata();
+
+ const Global
https://github.com/yxsamliu approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/117074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2378,13 +2394,28 @@ MCSection
*TargetLoweringObjectFileXCOFF::getExplicitSectionGlobal(
StringRef SectionName = GO->getSection();
vtz wrote:
The focus was from the beginning on COFF format. We misinterpreted and thought
the XCOFF would be the same way. I
https://github.com/vtz updated https://github.com/llvm/llvm-project/pull/112714
>From e01f6fb36734b214e23cbbe66818b3269d21a591 Mon Sep 17 00:00:00 2001
From: Vinicius Tadeu Zein
Date: Fri, 22 Nov 2024 10:39:08 -0500
Subject: [PATCH] [llvm] Implement pragma clang section on COFF targets
This pat
dmpolukhin wrote:
@ilya-biryukov unfortunately it seems that the reproducer is very sensitive to
the exact clang revision. I tried it with current main
b8eef18868570b2f5244d6d43de02a1812d1c880 and this PR on top of the revision. In
both cases I don't see any problems at all (no errors, no warn
@@ -1677,6 +1677,22 @@ MCSection
*TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
/*AddSegmentInfo=*/false))
Kind = SectionKind::getMetadata();
+
+ const Global
@@ -1677,6 +1677,22 @@ MCSection
*TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
/*AddSegmentInfo=*/false))
Kind = SectionKind::getMetadata();
+
+ const Global
https://github.com/llvm-beanz approved this pull request.
This looks great!
I know there was a lot of churn on this, but it came out really great. Thank
you!
https://github.com/llvm/llvm-project/pull/116413
___
cfe-commits mailing list
cfe-commits@li
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s -triple arm64-windows-msvc
+// expected-no-diagnostics
+#pragma clang section bss = "mybss.1" data = "mydata.1" rodata = "myrodata.1"
text = "mytext.1"
+#pragma clang section bss="" data="" rodata="" text=""
+#pragma cl
https://github.com/sunfishcode updated
https://github.com/llvm/llvm-project/pull/117087
>From 48808d43f41b61a419790fd25f99b5e897e5a419 Mon Sep 17 00:00:00 2001
From: Dan Gohman
Date: Fri, 11 Oct 2024 04:30:32 -0700
Subject: [PATCH 01/12] [WebAssembly] Define call-indirect-overlong and
bulk-mem
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/117342
AIX BuildBot failed due to https://github.com/llvm/llvm-project/pull/116556 as
AIX linker does not support version script.
This PR is to fix the failure
This PR is on behalf of gniko...@ca.ibm.com
>From c
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Daniel Chen (DanielCChen)
Changes
AIX BuildBot failed due to https://github.com/llvm/llvm-project/pull/116556 as
AIX linker does not support version script.
This PR is to fix the failure
This PR is on behalf of gnikolov@ca.ibm.com
---
F
vtz wrote:
> This is an LLVM code change, not a clang code change. It's an important
> principle that we test LLVM at the smallest reasonable granularity. Can you
> replace the clang test with an IR test? I'm sure we already have existing IR
> carrying existing sections, we just need to test i
https://github.com/xingxue-ibm approved this pull request.
Thanks, LGTM!
https://github.com/llvm/llvm-project/pull/117342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4666,30 +4666,58 @@ void CGOpenMPRuntime::emitTaskLoopCall(CodeGenFunction
&CGF, SourceLocation Loc,
CGF.getContext().VoidPtrTy);
}
enum { NoSchedule = 0, Grainsize = 1, NumTasks = 2 };
- llvm::Value *TaskArgs[] = {
- UpLoc,
-
paparodeo wrote:
ping
https://github.com/llvm/llvm-project/pull/116476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
What are the chances that this will exploit undefined behavior in existing user
code in ways that will make upgrading to the latest Clang more difficult
because of the perception of "miscompiles?" If this is a likely scenario for
users to hit, do other tools like UBSan (etc
@@ -2660,7 +2660,7 @@ usual build cycle when using sample profilers for
optimization:
> clang-cl /O2 -gdwarf -gline-tables-only ^
/clang:-fdebug-info-for-profiling
/clang:-funique-internal-linkage-names ^
- /fprofile-sample-use=code.prof code.cc /Fe:code /f
@@ -7,3 +7,106 @@ struct S {
};
// CHECK: CXXMethodDecl {{.*}}clang::lifetime_capture_by(a, b, global)
+
+//
+// Infer annotation for STL container methods.
+// ***
zmodem wrote:
> Could anyone with a windows machine see if you can work out what is happening
> with the windows test failure? I don't understand why the tests are failing
> on the windows bot as it seems like it should simply fail everything (e.g.
> windows driver is going wrong) or it should
philnik777 wrote:
@ldionne I think this is the more appropriate place to discuss this.
(From https://github.com/llvm/llvm-project/pull/116637#discussion_r1854114956)
> Chris had a patch on Clang at some point where we discussed this and I voiced
> concerns. Here it is: https://reviews.llvm.org
ojhunt wrote:
> > Could anyone with a windows machine see if you can work out what is
> > happening with the windows test failure? I don't understand why the tests
> > are failing on the windows bot as it seems like it should simply fail
> > everything (e.g. windows driver is going wrong) or i
jcranmer-intel wrote:
> do other tools like UBSan (etc) help users to find and fix the issues?
We don't yet have a reliable tool for sanitizing TBAA failures. There is a
project to do that (the TypeSanitizer, see
https://discourse.llvm.org/t/reviving-typesanitizer-a-sanitizer-to-catch-type-bas
https://github.com/VitaNuo updated
https://github.com/llvm/llvm-project/pull/117346
>From abd3c27d94b7f18990377d518aa8e14b32659b5f Mon Sep 17 00:00:00 2001
From: Viktoriia Bakalova
Date: Fri, 22 Nov 2024 17:26:57 +0100
Subject: [PATCH 1/3] [clang][codegen] Mention the invariant that LLVM
deman
@@ -2047,6 +2047,14 @@ StringRef CodeGenModule::getMangledName(GlobalDecl GD) {
GD.getWithKernelReferenceKind(KernelReferenceKind::Kernel),
ND));
+ // This invariant should hold true in the future.
+ // Prior work:
+ //
https://discourse.l
preames wrote:
> I am not sue about the acceptance of the "tt" naming here given we use full
> names for all other vendors in this context. Can you raise that point
> specifically at the next RISCV sync up call for discussion?
Just to close the loop. We did briefly touch on this in the sync u
rjmccall wrote:
> An abstraction that includes blocks doesn't help us here because we are
> looking for the combination of `NamedDecl` and `DeclContext` and `BlockDecl`
> isn't a `NamedDecl`.
I think you're focusing a little narrowly here. I can't imagine why you'd
specifically need a `NamedD
@@ -6782,16 +6783,21 @@ defm : FlangIgnoredDiagOpt<"frontend-loop-interchange">;
defm : FlangIgnoredDiagOpt<"target-lifetime">;
// C++ SYCL options
+let Group = sycl_Group in {
def fsycl : Flag<["-"], "fsycl">,
- Visibility<[ClangOption, CLOption]>,
- Group, HelpText<"Enabl
@@ -6591,6 +6681,18 @@ const ToolChain &Driver::getOffloadingDeviceToolChain(
HostTC, Args);
break;
}
+case Action::OFK_SYCL:
+ switch (Target.getArch()) {
+ case llvm::Triple::spir:
+ case
@@ -0,0 +1,179 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
401 - 464 of 464 matches
Mail list logo
