[clang] [clang][analyzer][doc] Update Clang SA www docs index.html (PR #112833)

2024-10-24 Thread Endre Fülöp via cfe-commits
@@ -69,48 +69,7 @@ Clang Static Analyzer -The Clang Static Analyzer is a source code analysis tool that finds bugs in -C, C++, and Objective-C programs. - -Currently it can be run either from the command - line or if you use macOS then within Xcode. When -invoked from the co

[clang] [clang][analyzer][doc] Update Clang SA www docs index.html (PR #112833)

2024-10-24 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 closed https://github.com/llvm/llvm-project/pull/112833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-24 Thread Dan Liew via cfe-commits
delcypher wrote: @Sirraide @erichkeane Sorry for the delay in addressing your feedback. This PR is ready for another round of reviews. Note I'm aware there are some code formatting problems. I'll fix them when I squash locally. I've tried to keep all my tweaks as separate commits so it's easi

[libunwind] [libunwind][AArch64] Protect PC within libunwind's context. (PR #113368)

2024-10-24 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/113368 >From 3dd2f4da57eb164e67fd54b66c09cc8b771ee24f Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Wed, 16 Oct 2024 14:48:25 -0700 Subject: [PATCH 1/2] [libunwind][AArch64] Protect PC within libunwind's

[clang] [WebKit Checkers] Make TrivialFunctionAnalysis recognize std::array::operator[] as trivial (PR #113377)

2024-10-24 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud updated https://github.com/llvm/llvm-project/pull/113377 >From 9e21b0f2f0968a5f8810c797913318884dcc8c7b Mon Sep 17 00:00:00 2001 From: Rashmi Mudduluru Date: Tue, 22 Oct 2024 13:16:30 -0700 Subject: [PATCH 1/2] [WebKit Checkers] Make TrivialFunctionAnalysis recognize

[clang] [WebKit Checkers] Make TrivialFunctionAnalysis recognize std::array::operator[] as trivial (PR #113377)

2024-10-24 Thread Ryosuke Niwa via cfe-commits
@@ -452,6 +454,10 @@ class RefCounted { unsigned nonTrivial23() { return DerivedNumber("123").value(); } SomeType nonTrivial24() { return SomeType("123"); } + void call_libcpp_verbose_abort() { rniwa wrote: Can we add this as "trivial65" above right bene

[clang] [WebKit Checkers] Make TrivialFunctionAnalysis recognize std::array::operator[] as trivial (PR #113377)

2024-10-24 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa approved this pull request. https://github.com/llvm/llvm-project/pull/113377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [AArch64] Add support for Armv9.6-A FEAT_PoPS architecture extension (PR #113496)

2024-10-24 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/113496 >From f56eb26dbeb683777a7db97b43ebaea19a88e5b8 Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Sat, 19 Oct 2024 00:20:20 +0100 Subject: [PATCH] [AArch64] Add support for Armv9.6-A FEAT_PoPS architecture

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-10-24 Thread Artem Belevich via cfe-commits
Artem-B wrote: Closing the patch now, as we've figured out a way to move forward with simpler changes. https://github.com/llvm/llvm-project/pull/100247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang-tools-extra] [flang] [llvm] Reland 'Update llvm::Registry to work for LLVM shared library builds on windows' (#109024) (PR #112640)

2024-10-24 Thread Thomas Fransham via cfe-commits
fsfod wrote: The fix for the gn build system would be to unconditionally define CLANG_BUILD_STATIC for the windows platform for now. https://github.com/llvm/llvm-project/pull/112640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov_dpp8 (PR #113610)

2024-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) Changes The same handling as for __builtin_amdgcn_mov_dpp. --- Full diff: https://github.com/llvm/llvm-project/pull/113610.diff 6 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsA

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov_dpp8 (PR #113610)

2024-10-24 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/113610 The same handling as for __builtin_amdgcn_mov_dpp. >From edda0e600abeabff4d44e8b0b897104efacc8f98 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Thu, 24 Oct 2024 11:31:52 -0700 Subject: [PATCH] [AM

[clang] [analyzer] Fix a crash from element region construction during `ArrayInitLoopExpr` analysis (PR #113570)

2024-10-24 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/113570 >From a5fbcd56e08d7202adc8cc80de3c732ed17ee642 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 24 Oct 2024 16:01:42 +0200 Subject: [PATCH] [analyzer] Fix a cras

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2024-10-24 Thread NAKAMURA Takumi via cfe-commits
chapuni wrote: @ornata I put #113115 as the final form. HTH https://github.com/llvm/llvm-project/pull/112702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang]: enhance handling of [[deprecated]] attribute diagnostics for local variables (PR #113575)

2024-10-24 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/113575 Fixes #90073 >From 67a48d3861b44bd5c37fc9740ee2c54ddd1a8d1b Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Thu, 24 Oct 2024 17:21:39 +0300 Subject: [PATCH] [Clang] enhance handling of [[deprecated]] attrib

[clang] [llvm] InstCombine: Order shufflevector operands by complexity (PR #113212)

2024-10-24 Thread Simon Pilgrim via cfe-commits
@@ -1,7 +1,7 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 // REQUIRES: x86-registered-target -// RUN: %clang_cc1 -ffreestanding %s -O3 -triple=x86_64-apple-darwin -target-feature +avx -emit-llvm -o - | FileCheck %s --ch

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-24 Thread via cfe-commits
@@ -49,6 +49,7 @@ #include "MultipleStatementMacroCheck.h" #include "NoEscapeCheck.h" #include "NonZeroEnumToBoolConversionCheck.h" EugeneZelenko wrote: Out of alphabetical order. Clang-format file? https://github.com/llvm/llvm-project/pull/110471 ___

[clang] [llvm] [mlir] [OpenMP][OMPIRBuilder] Error propagation across callbacks (PR #112533)

2024-10-24 Thread Pranav Bhandarkar via cfe-commits
https://github.com/bhandarkar-pranav approved this pull request. Thank you for the changes. https://github.com/llvm/llvm-project/pull/112533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [llvm] [LoongArch] Support LoongArch-specific amswap[_db].{b/h} and amadd[_db].{b/h} instructions (PR #113255)

2024-10-24 Thread Chris Apple via cfe-commits
cjappl wrote: Just a heads up, I think this broke documentation builds. After bisecting it points to this commit. ``` ninja -C build docs-clang-html FAILED: tools/clang/docs/CMakeFiles/docs-clang-html ~/code/radsan_cjappl/llvm-project/build/tools/clang/docs/CMakeFiles/docs-clang-html cd ~/code

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-24 Thread Dan Liew via cfe-commits
@@ -13559,6 +13562,27 @@ QualType Sema::CheckAssignmentOperands(Expr *LHSExpr, ExprResult &RHS, QualType LHSType = LHSExpr->getType(); QualType RHSType = CompoundType.isNull() ? RHS.get()->getType() : CompoundType; + + if (RHS.

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-24 Thread via cfe-commits
@@ -107,6 +107,15 @@ AARCH64_VECTOR_TYPE(Name, MangledName, Id, SingletonId) #endif +#ifndef AARCH64_SCALAR_TYPE +#define AARCH64_SCALAR_TYPE(Name, MangledName, Id, SingletonId) \ + SVE_TYPE(Name, Id, SingletonId) +#endif + +#ifndef AARCH64_SCALAR_TYPE_MFLOAT +#define AARCH

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread Daniel Chen via cfe-commits
@@ -178,7 +192,12 @@ static constexpr TypePattern SameType{AnyType, KindCode::same}; // universal extension feature. static constexpr TypePattern OperandReal{RealType, KindCode::operand}; static constexpr TypePattern OperandInt{IntType, KindCode::operand}; +static constexpr Ty

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-24 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/113189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-24 Thread Justin Bogner via cfe-commits
@@ -460,6 +460,70 @@ class OpLowerer { }); } + [[nodiscard]] bool lowerCtpopToCountBits(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +Type *Int32Ty = IRB.getInt32Ty(); + +return replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.SetInsertPo

[clang] [libcxx] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-24 Thread Nikolas Klauser via cfe-commits
@@ -638,7 +638,7 @@ __uninitialized_allocator_relocate(_Alloc& __alloc, _Tp* __first, _Tp* __last, _ __guard.__complete(); std::__allocator_destroy(__alloc, __first, __last); } else { -__builtin_memcpy(__result, __first, sizeof(_Tp) * (__last - __first)); +__

[clang] [Clang] Disable use of the counted_by attribute for whole struct pointers (PR #112636)

2024-10-24 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: > For the record, I think the most correct definition, in terms of "this is how > much memory you should allocate for a struct with a flexible array member" is > this: > > ```c > max( > sizeof(struct S), // always at least the size of the struct itself > round_up( >

[clang] [clang-linker-wrapper] Add error handling for missing linker path (PR #113613)

2024-10-24 Thread Arvind Sudarsanam via cfe-commits
@@ -370,6 +370,8 @@ Error runLinker(ArrayRef Files, const ArgList &Args) { // Render the linker arguments and add the newly created image. We add it // after the output file to ensure it is linked with the correct libraries. StringRef LinkerPath = Args.getLastArgValue(OP

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-24 Thread Justin Bogner via cfe-commits
@@ -460,6 +460,70 @@ class OpLowerer { }); } + [[nodiscard]] bool lowerCtpopToCountBits(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +Type *Int32Ty = IRB.getInt32Ty(); + +return replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.SetInsertPo

[clang] [llvm] [AMDGPU] Add a type for the named barrier (PR #113614)

2024-10-24 Thread Gang Chen via cfe-commits
https://github.com/cmc-rep updated https://github.com/llvm/llvm-project/pull/113614 >From 166a4aec8a8ee813be0ee3045563cd45efd944c0 Mon Sep 17 00:00:00 2001 From: gangc Date: Thu, 24 Oct 2024 11:18:22 -0700 Subject: [PATCH 1/2] [AMDGPU] Add a type for the named barrier --- clang/include/clang/

[clang] [Clang] Disable use of the counted_by attribute for whole struct pointers (PR #112636)

2024-10-24 Thread Tavian Barnes via cfe-commits
tavianator wrote: > I mean it would be useful to round up to the alignment for when you wanne > have an array of the structs, but I'm not sure this is actually required by > the standard. Do you have more justification for the alignment requirement on > structs containing FAMs? Here's an exam

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread Peter Klausler via cfe-commits
@@ -400,6 +400,69 @@ constexpr TypeBuilderFunc getModel() { return fir::ReferenceType::get(f(context)); }; } +template <> +constexpr TypeBuilderFunc getModel() { + return getModel(); klausler wrote: The existing code does not distinguish `unsigned int`

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `dot4add_i8packed` intrinsic (PR #113623)

2024-10-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff eaa7b385368fa7e3dad9b95411d04be55e71494e 46822507e0b70e91cf6f4f0295d257978652bfbc --e

[clang] [llvm] [DXIL][SPIRV] Lower WaveActiveCountBits intrinsic (PR #113382)

2024-10-24 Thread Finn Plummer via cfe-commits
@@ -1762,6 +1765,36 @@ bool SPIRVInstructionSelector::selectSign(Register ResVReg, return Result; } +bool SPIRVInstructionSelector::selectWaveActiveCountBits( +Register ResVReg, const SPIRVType *ResType, MachineInstr &I) const { + assert(I.getNumOperands() == 3); + as

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `dot4add_i8packed` intrinsic (PR #113623)

2024-10-24 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/113623 >From 46822507e0b70e91cf6f4f0295d257978652bfbc Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Wed, 23 Oct 2024 22:59:15 + Subject: [PATCH 1/2] [HLSL][SPIRV][DXIL] Implement `dot4add_i8packed` intrinsic

[clang] [Clang] Disable use of the counted_by attribute for whole struct pointers (PR #112636)

2024-10-24 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: I think you're correct https://github.com/llvm/llvm-project/pull/112636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Use dynamic type when invalidating by a member function call (PR #111138)

2024-10-24 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/38 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-24 Thread Jesse Huang via cfe-commits
@@ -0,0 +1,30 @@ +; ModuleID = '/home/jhuang4/workspace/test.c' jaidTw wrote: Yeah definitely, I'll remove it https://github.com/llvm/llvm-project/pull/112477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [Driver] Remove ignored Flag form of -fauto-profile/-fprofile-sample-use (PR #113528)

2024-10-24 Thread Mikołaj Piróg via cfe-commits
mikolaj-pirog wrote: This would close #112391 I am copying my comment from my PR #112750 which addresses the issue #112391: I think this isn't the best solution, since it is inconsistent with the behavior of the -fprofile-use option. Why should -fprofile-use be accepted and -fprofile-sample-

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-24 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: @MaskRay, have all your comments been addressed? https://github.com/llvm/llvm-project/pull/109165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Bump Type::NumOfBuiltinTypeBits. NFCI. (PR #113559)

2024-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jay Foad (jayfoad) Changes BuiltinType::LastKind is currently 507 which is close to the current limit of 511. --- Full diff: https://github.com/llvm/llvm-project/pull/113559.diff 1 Files Affected: - (modified) clang/include/clang/AST/T

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-10-24 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm approved this pull request. LGTM. Especially convenient to have all the patches split apart from each other like that – it made them much easier to read! https://github.com/llvm/llvm-project/pull/109943 ___ cfe-commits m

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585, #111173)" (PR #111852)

2024-10-24 Thread via cfe-commits
steelannelida wrote: There's a weird error after this change + #112381. It only reproduces with multiple modules * Module 1, `dep_lib.h`: ``` #ifndef DEB_LIB_H_ #define DEB_LIB_H_ #include #include namespace f{ template class strm; namespace t { template std::vector A(strm stream); } tem

[clang-tools-extra] [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (PR #112496)

2024-10-24 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. Looks good to me, this is an important improvement of report quality. If the analysis is performed in a cloud-based environment (which is common), the full path name of the analyzed file may contain e.g. directory names that are unpredic

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov_dpp8 (PR #113610)

2024-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Stanislav Mekhanoshin (rampitec) Changes The same handling as for __builtin_amdgcn_mov_dpp. --- Full diff: https://github.com/llvm/llvm-project/pull/113610.diff 6 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def

[clang] [clang][dataflow] Disambiguate a ref to "internal" in CachedConstAccessorsLattice (PR #113601)

2024-10-24 Thread Jan Voung via cfe-commits
https://github.com/jvoung closed https://github.com/llvm/llvm-project/pull/113601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread Peter Klausler via cfe-commits
klausler wrote: > Seems a place that needs to add UNSIGNED type case > > ``` > llvm-project/flang/lib/Semantics/resolve-names.cpp:7597:16: error: > enumeration value 'Unsigned' not handled in switch [-Werror,-Wswitch] > switch (type.category()) { > ~^~ > llvm-project/fla

[clang] 4affb2d - [analyzer] Use dynamic type when invalidating by a member function call (#111138)

2024-10-24 Thread via cfe-commits
Author: Balazs Benics Date: 2024-10-24T13:22:19+02:00 New Revision: 4affb2d59a541d8163404d7e21252b4686f1c3b8 URL: https://github.com/llvm/llvm-project/commit/4affb2d59a541d8163404d7e21252b4686f1c3b8 DIFF: https://github.com/llvm/llvm-project/commit/4affb2d59a541d8163404d7e21252b4686f1c3b8.diff

[clang] [clang] Apply internal buffering to clang diagnostics printing (PR #113440)

2024-10-24 Thread via cfe-commits
cor3ntin wrote: Are we calling `SetUnbuffered` somewhere we shouldn't? https://github.com/llvm/llvm-project/pull/113440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread via cfe-commits
@@ -968,21 +968,41 @@ struct BinaryOp {}; fir::FirOpBuilder &builder, \ const Op &, hlfir::Entity lhs, \ hlfir::Entity rhs) {

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread via cfe-commits
https://github.com/jeanPerier commented: This looks great, I have little to say on the lowering and made a few questions/comments inline https://github.com/llvm/llvm-project/pull/113504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread via cfe-commits
@@ -213,6 +213,22 @@ def fir_IntegerType : FIR_Type<"Integer", "int"> { }]; } +def fir_UnsignedType : FIR_Type<"Unsigned", "unsigned"> { jeanPerier wrote: Did you actually need this new type? fir_IntegerType still exits but likely has very limited use in l

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-24 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From cb6359e96c6fd2c2af90f84c32487977a6e1b819 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/3] [libc++] Make benchmarks forward-compatible with the test su

[clang] [HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource (PR #113477)

2024-10-24 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/113477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-24 Thread via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-24 Thread Sarah Spall via cfe-commits
@@ -0,0 +1,107 @@ +; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} + +; CHECK: OpMemoryModel Logical GLSL450 + +define noundef i32 @f

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-24 Thread via cfe-commits
https://github.com/davidtrevelyan approved this pull request. https://github.com/llvm/llvm-project/pull/112727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] af872d5 - [HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource (#113477)

2024-10-24 Thread via cfe-commits
Author: Helena Kotas Date: 2024-10-24T10:34:04-07:00 New Revision: af872d5473e7e1132e0ec8e146d28af239196c53 URL: https://github.com/llvm/llvm-project/commit/af872d5473e7e1132e0ec8e146d28af239196c53 DIFF: https://github.com/llvm/llvm-project/commit/af872d5473e7e1132e0ec8e146d28af239196c53.diff

[clang] [analyzer] Fix a crash from element region construction during `ArrayInitLoopExpr` analysis (PR #113570)

2024-10-24 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [clang][dataflow] Disambiguate a ref to "internal" in CachedConstAccessorsLattice (PR #113601)

2024-10-24 Thread Jan Voung via cfe-commits
https://github.com/jvoung created https://github.com/llvm/llvm-project/pull/113601 Disambiguate to fix a build error (e.g., on windows with clang-cl) >From f5470d4bee2ab991942d6640dd48631ca343bc85 Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Thu, 24 Oct 2024 17:37:03 + Subject: [PATCH]

[clang] [Clang] Provide default value for -fprofile-sample-use, -fprofile-auto (PR #112750)

2024-10-24 Thread Mikołaj Piróg via cfe-commits
mikolaj-pirog wrote: > Actually I think we should drop the accepted and ignored `Flag` form of > `-fprofile-sample-use` and `-fprofile-auto`, which is misleading at the > least. I have a pending patch, which I will upload at night. > > For sample PGO, the profile file extension is usually `.af

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-24 Thread Paul Walker via cfe-commits
@@ -2590,6 +2590,7 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) { OS << "#if defined(__aarch64__) || defined(__arm64ec__)\n"; OS << "typedef __MFloat8x8_t mfloat8x8_t;\n"; OS << "typedef __MFloat8x16_t mfloat8x16_t;\n"; + OS << "typedef __MFloat8_t __mfp8;\n"; --

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-24 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm edited https://github.com/llvm/llvm-project/pull/97277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-24 Thread Jesse Huang via cfe-commits
@@ -607,6 +607,9 @@ class RISCVTargetCodeGenInfo : public TargetCodeGenInfo { auto *Fn = cast(GV); Fn->addFnAttr("interrupt", Kind); + +if (CGM.getCodeGenOpts().CFProtectionReturn) jaidTw wrote: I'm not quite familiar with the code here, is it saf

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-24 Thread Freddy Ye via cfe-commits
@@ -665,6 +665,9 @@ _storebe_i64(void * __P, long long __D) { #include #include #include +#if (defined(__SM4__)) FreddyLeaf wrote: [c0a33ab](https://github.com/llvm/llvm-project/pull/113402/commits/c0a33abe804bafe11e9dcecb092b924bcd08cdb7) https://github.c

[clang] [libcxx] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-24 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/111434 >From c941368f21a769b4903e0d2aac9f8fa732a1e644 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 7 Oct 2024 15:30:24 +0200 Subject: [PATCH 1/2] [clang] Warn about memset/memcpy to NonTriviall

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-24 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang-tools-extra] [compiler-rt] Added support for the .yml file extension (PR #79899)

2024-10-24 Thread Chris Apple via cfe-commits
cjappl wrote: Closing This should be split into multiple reviews that do one small atomic thing. The reviews should have good descriptions and tests. You should try to minimize white space and formatting changes. Feel free to resubmit if you think these changes still need to be made. https://g

[clang] [clang][dataflow] Disambiguate a ref to "internal" in CachedConstAccessorsLattice (PR #113601)

2024-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Jan Voung (jvoung) Changes Disambiguate to fix a build error (e.g., on windows with clang-cl) --- Full diff: https://github.com/llvm/llvm-project/pull/113601.diff 1 Files Affected: - (modified) clang/include/clang/Analysis/Fl

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Louis Dionne via cfe-commits
ldionne wrote: > The script is already written and works, and there still isn't a concrete > timeline for when we are going to move things over to Github actions. This > solves a valid complaint I hear somewhat often. For libc++ at least, there > are definitely platforms that will not be able

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-10-24 Thread Björn Schäpers via cfe-commits
@@ -49,11 +49,29 @@ bool matchFilePath(StringRef Pattern, StringRef FilePath) { return false; break; case '*': { - while (++I < EOP && Pattern[I] == '*') { // Skip consecutive stars. + if (I + 1 < EOP && Pattern[I + 1] == '*') { +// Handle '*

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-24 Thread via cfe-commits
kakkoko wrote: @owenca Thanks for the review. I applied all of the suggestions as I thought they were all appropriate. https://github.com/llvm/llvm-project/pull/113100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang][dataflow] Add a lattice to help cache const accessor methods (PR #111006)

2024-10-24 Thread Jan Voung via cfe-commits
@@ -0,0 +1,218 @@ +//===-- CachedConstAccessorsLattice.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-10-24 Thread via cfe-commits
qt-tatiana wrote: > @qt-tatiana: Please do not forget to resolve fixed comments. Done, thanks! :) https://github.com/llvm/llvm-project/pull/113144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang-tools-extra] [flang] [llvm] Reland 'Update llvm::Registry to work for LLVM shared library builds on windows' (#109024) (PR #112640)

2024-10-24 Thread Thomas Fransham via cfe-commits
fsfod wrote: Its strange that visibility macros are enabled for windows but its not a shared library build, idk if the gn build script need to be manually updated to define the macros correctly to turn off visibility macros by default. https://github.com/llvm/llvm-project/pull/112640 _

[clang] [clang-format] Add an option to control indentation of `export { ... }` (PR #110381)

2024-10-24 Thread Björn Schäpers via cfe-commits
@@ -3107,29 +3131,15 @@ void UnwrappedLineParser::parseNamespace() { DeclarationScopeStack.size() > 1) ? 1u : 0u; -bool ManageWhitesmithsBraces = -AddLevels == 0u && -Style.BreakBeforeBraces == FormatStyle::BS_Whitesm

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-24 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/3] [Clang] fix range calculation for conditionals with throw

[clang] [compiler-rt] Reapply " [XRay] Add support for instrumentation of DSOs on x86_64 (#90959)" (PR #113548)

2024-10-24 Thread Sebastian Kreutzer via cfe-commits
sebastiankreutzer wrote: Buildkite failure is due to unrelated errors in `libcxx/test/libcxx/headers_in_modulemap.sh.py` https://github.com/llvm/llvm-project/pull/113548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-24 Thread Phoebe Wang via cfe-commits
@@ -2339,6 +2339,19 @@ TARGET_BUILTIN(__builtin_ia32_vfmaddnepbh512, "V32yV32yV32yV32y", "ncV:512:", "a TARGET_BUILTIN(__builtin_ia32_vfmaddnepbh256, "V16yV16yV16yV16y", "ncV:256:", "avx10.2-256") TARGET_BUILTIN(__builtin_ia32_vfmaddnepbh128, "V8yV8yV8yV8y", "ncV:128:", "avx1

[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

2024-10-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d269ec321dfdfcd817544da0a94dc42c109694a2 683591114cedc210e3c2f9773330e9e42d38a610 --e

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features which can be expressed as a combination of others. (PR #113580)

2024-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes Removes sve-bf16, sve-ebf16, and sve-i8mm since they are obsolete. One could write target_version("sve+bf16") instead of sve-bf16 for instance. Approved in ACLE as https://github.com/ARM-software/a

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features which can be expressed as a combination of others. (PR #113580)

2024-10-24 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/113580 Removes sve-bf16, sve-ebf16, and sve-i8mm since they are obsolete. One could write target_version("sve+bf16") instead of sve-bf16 for instance. Approved in ACLE as https://github.com/ARM-software/acle/pull/353

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features which can be expressed as a combination of others. (PR #113580)

2024-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Alexandros Lamprineas (labrinea) Changes Removes sve-bf16, sve-ebf16, and sve-i8mm since they are obsolete. One could write target_version("sve+bf16") instead of sve-bf16 for instance. Approved in ACLE as https://github.com/ARM-

[clang] [Clang][AST] Store injected template arguments in TemplateParameterList (PR #113579)

2024-10-24 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/113579 >From 95c86a7036e62240ab7704f0b1e47cdc9ac437c6 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 15 Oct 2024 11:15:55 -0400 Subject: [PATCH] [Clang][AST] Store injected template arguments in Temp

[clang] [Clang][AST] Store injected template arguments in TemplateParameterList (PR #113579)

2024-10-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a18826d75cb0d0d13fc1aef620e04d2901e9bced 69f9da551992f565ca8d839aa499aed278df55a8 --e

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features which can be expressed as a combination of others. (PR #113580)

2024-10-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ea3534b385a713639953fb5dfd287af87b52bead ff05dea7d4509d3a1ead7e2bcef685db62afe07a --e

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-24 Thread Chris Apple via cfe-commits
cjappl wrote: (test failure seems unrelated, but I will ensure it's green before I submit after I get approval, going to rebase now) https://github.com/llvm/llvm-project/pull/112727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread Daniel Chen via cfe-commits
@@ -135,8 +141,12 @@ static constexpr TypePattern SubscriptInt{IntType, KindCode::subscript}; // Match any kind of some intrinsic or derived types static constexpr TypePattern AnyInt{IntType, KindCode::any}; +static constexpr TypePattern AnyUnsigned{UnsignedType, KindCode::an

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove features which can be expressed as a combination of others. (PR #113580)

2024-10-24 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/113580 >From ff05dea7d4509d3a1ead7e2bcef685db62afe07a Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Thu, 24 Oct 2024 15:58:53 +0100 Subject: [PATCH 1/2] [FMV][AArch64] Remove features which can be express

[clang] [Driver] Remove ignored Flag form of -fauto-profile/-fprofile-sample-use (PR #113528)

2024-10-24 Thread Fangrui Song via cfe-commits
MaskRay wrote: > This would close #112391 > > I am copying my comment from my PR #112750 which addresses the issue #112391: > I think this isn't the best solution, since it is inconsistent with the > behavior of the -fprofile-use option. Why should -fprofile-use be accepted > and -fprofile-sa

[clang] Update std symbols mapping (PR #113612)

2024-10-24 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 updated https://github.com/llvm/llvm-project/pull/113612 >From 8fac50dc444eeb6c9ad19eb11f7d95457b153528 Mon Sep 17 00:00:00 2001 From: vvd170501 <36827317+vvd170...@users.noreply.github.com> Date: Thu, 24 Oct 2024 17:36:22 +0300 Subject: [PATCH 1/4] Move assertion to

[clang] 564fd62 - [FlowSensitive] Allow to dump nested RecordStorageLocation (#112457)

2024-10-24 Thread via cfe-commits
Author: Florian Mayer Date: 2024-10-24T11:05:39-07:00 New Revision: 564fd62aedfde6358baa1776a2de975b45bc7778 URL: https://github.com/llvm/llvm-project/commit/564fd62aedfde6358baa1776a2de975b45bc7778 DIFF: https://github.com/llvm/llvm-project/commit/564fd62aedfde6358baa1776a2de975b45bc7778.diff

[clang] [PS5][Driver] Update default linking options for `-r` (PR #113595)

2024-10-24 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd updated https://github.com/llvm/llvm-project/pull/113595 >From 5c5a6f89ca752bf9d0452f486648f2608b7bc609 Mon Sep 17 00:00:00 2001 From: Edd Dawson Date: Thu, 24 Oct 2024 10:15:16 +0100 Subject: [PATCH] [PS5][Driver] Update default linking options when `-r` omi

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-10-24 Thread via cfe-commits
EugeneZelenko wrote: Please resolve all fixed comments. Please rebase from `main`. https://github.com/llvm/llvm-project/pull/102299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-24 Thread Alexey Bader via cfe-commits
@@ -762,6 +762,10 @@ class ToolChain { virtual void AddHIPIncludeArgs(const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args) const; + /// Add arguments to use SYCL specific includes. bader wrote: ```sugge

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-24 Thread Sarah Spall via cfe-commits
https://github.com/spall updated https://github.com/llvm/llvm-project/pull/111082 >From 6239941c302f616f87ed652151e828a8eae1054c Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Mon, 23 Sep 2024 22:10:59 + Subject: [PATCH 1/8] implement firstbithigh hlsl builtin --- clang/include/clang/Ba

[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

2024-10-24 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/110471 >From 3fb376df2bba47e220c6689f011980186e100278 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 26 Sep 2024 16:24:59 +0200 Subject: [PATCH] [clang-tidy] [analyzer] Move nondeterministic pointer usage

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-24 Thread via cfe-commits
https://github.com/kakkoko updated https://github.com/llvm/llvm-project/pull/113100 >From 07ac17e531315126c932b130963798a296736736 Mon Sep 17 00:00:00 2001 From: kakkoko Date: Mon, 21 Oct 2024 03:48:13 +0900 Subject: [PATCH 1/2] [clang-format] Fix working -assume-filename with .clang-format-ig

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-10-24 Thread Daniel Chen via cfe-commits
DanielCChen wrote: Seems a place that needs to add UNSIGNED type case ``` llvm-project/flang/lib/Semantics/resolve-names.cpp:7597:16: error: enumeration value 'Unsigned' not handled in switch [-Werror,-Wswitch] switch (type.category()) { ~^~ llvm-project/flang/lib/Semanti

[clang] [HLSL] Add AppendStructuredBuffer and ConsumeStructuredBuffer to HLSLExternalSemaSource (PR #113643)

2024-10-24 Thread Helena Kotas via cfe-commits
https://github.com/hekota created https://github.com/llvm/llvm-project/pull/113643 Adds AppendStructuredBuffer and ConsumeStructuredBuffer to HLSLExternalSemaSource. Adds separate tests for the AST shape and element types, and adds constructor/handle.fromBinding test case to shared test file

<    1   2   3   4   5   >