[clang] [clang][bytecode] Fix temporary lvalue base expression (PR #111808)

2024-10-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/111808 We need to use the MaterializeTemporaryExpr here so the checks in ExprConstant.cpp do the right thing. >From d06e3aab6e01050db6ceaa43b2659623fc8f1f29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?

[clang] [clang][bytecode] Fix temporary lvalue base expression (PR #111808)

2024-10-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes We need to use the MaterializeTemporaryExpr here so the checks in ExprConstant.cpp do the right thing. --- Full diff: https://github.com/llvm/llvm-project/pull/111808.diff 3 Files Affected: - (modified) c

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-10 Thread Byoungchan Lee via cfe-commits
https://github.com/bc-lee updated https://github.com/llvm/llvm-project/pull/111375 >From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001 From: Byoungchan Lee Date: Mon, 7 Oct 2024 22:19:38 +0900 Subject: [PATCH 1/7] [clang-include-cleaner] Fix incorrect directory issue for wr

[clang] [llvm] [AArch64] Introduce new armv9.6 features (PR #111677)

2024-10-10 Thread via cfe-commits
@@ -1791,22 +1822,52 @@ AArch64ExtensionDependenciesBaseArchTestParams {"sve2-bitperm", "nosve2"}, {}, {"sve2", "sve2-bitperm"}}, -{AArch64::ARMV8A, {"nosve2", "sve2-aes"}, {"sve2", "sve2-aes"}, {}}, -{AArch64::ARMV8A, {"sve2-aes", "no

[clang] [llvm] [AArch64] Introduce new armv9.6 features (PR #111677)

2024-10-10 Thread via cfe-commits
@@ -833,8 +866,8 @@ def HasV9_5aOps : Architecture64<9, 5, "a", "v9.5a", [HasV9_4aOps, FeatureCPA], !listconcat(HasV9_4aOps.DefaultExts, [FeatureCPA, FeatureLUT, FeatureFAMINMAX])>; def HasV9_6aOps : Architecture64<9, 6, "a", "v9.6a", - [HasV9_5aOps], - !listconcat(HasV

[clang] [llvm] [AArch64] Introduce new armv9.6 features (PR #111677)

2024-10-10 Thread via cfe-commits
@@ -1510,12 +1524,16 @@ TEST(TargetParserTest, AArch64ArchExtFeature) { {"rdm", "nordm", "+rdm", "-rdm"}, {"sve", "nosve", "+sve", "-sve"}, {"sve-b16b16", "nosve-b16b16", "+sve-b16b16", "-sve-b16b16"}, + {"sve-bfscale", "nosve-bfscale", "+sve-bfscale", "-

[clang] [llvm] [AArch64] Introduce new armv9.6 features (PR #111677)

2024-10-10 Thread via cfe-commits
@@ -1413,6 +1424,9 @@ TEST(TargetParserTest, AArch64ExtensionFeatures) { EXPECT_TRUE(llvm::is_contained(Features, "+tlbiw")); EXPECT_TRUE(llvm::is_contained(Features, "+jsconv")); EXPECT_TRUE(llvm::is_contained(Features, "+complxnum")); + EXPECT_TRUE(llvm::is_contained(F

[clang] [llvm] [AArch64] Introduce new armv9.6 features (PR #111677)

2024-10-10 Thread via cfe-commits
Lukacma wrote: @jthackray @CarolineConcatto Regarding using Armv9.6-A in feature descriptions, I am bit on the fence here. On the hand, I think it would make it clearer, in what architecture extension these features has been introduced, but on other hand these features can also be used with A

[clang] [Cuda] Handle -fcuda-short-ptr even with -nocudalib (PR #111682)

2024-10-10 Thread Joseph Huber via cfe-commits
jhuber6 wrote: We don't need marshalling because this isn't a cc1 option. This is just handled by the driver which forwards it as `-mllvm` to the backend. You'd need to update the LLVM option to take multiple options and then make the clang driver option pick between them. https://github.com/

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-10 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/110762 >From 9c073cc3145bf6961b565516aea0e8d0c3fca0d7 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 10 Oct 2024 13:08:20 +0200 Subject: [PATCH 1/3] Undo previous changes, keeping the release note and tests ---

[clang] 55d51dd - [clang][bytecode] Fix temporary lvalue base expression (#111808)

2024-10-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-10T14:10:38+02:00 New Revision: 55d51dd9dca8220ffaf9260d56dae9f5c34b7120 URL: https://github.com/llvm/llvm-project/commit/55d51dd9dca8220ffaf9260d56dae9f5c34b7120 DIFF: https://github.com/llvm/llvm-project/commit/55d51dd9dca8220ffaf9260d56dae9f5c34b7120.diff L

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-10 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/110762 >From 9c073cc3145bf6961b565516aea0e8d0c3fca0d7 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 10 Oct 2024 13:08:20 +0200 Subject: [PATCH 1/2] Undo previous changes, keeping the release note and tests ---

[clang] [clang][bytecode] Fix temporary lvalue base expression (PR #111808)

2024-10-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/111808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-10 Thread via cfe-commits
RichBarton-Arm wrote: +1000 Great to see this finally happen. Great job everyone! https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-10-10 Thread via cfe-commits
dmasloff wrote: @owenca @mydeveloperday @HazardyKnusperkeks could somebody continue the review? https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [ItaniumCXXABI] Mark RTTI type name as global unnamed_addr (PR #111343)

2024-10-10 Thread via cfe-commits
https://github.com/luxufan updated https://github.com/llvm/llvm-project/pull/111343 >From cabe9e1ac1305d970d944183ebf10effe783f5fc Mon Sep 17 00:00:00 2001 From: luxufan Date: Mon, 7 Oct 2024 07:14:06 + Subject: [PATCH 1/4] [ItaniumCXXABI] Mark RTTI type name as global unnamed_addr The RT

[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

2024-10-10 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -323,12 +342,13 @@ class ExprEngine { /// ProcessBranch - Called by CoreEngine. Used to generate

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Aaron Ballman via cfe-commits
@@ -790,6 +790,10 @@ def warn_cstruct_memaccess : Warning< "%1 call is a pointer to record %2 that is not trivial to " "%select{primitive-default-initialize|primitive-copy}3">, InGroup; +def warn_cxxstruct_memaccess : Warning< + "%select{destination for|source of|first o

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Aaron Ballman via cfe-commits
@@ -8899,18 +8899,42 @@ void Sema::CheckMemaccessArguments(const CallExpr *Call, << ArgIdx << FnName << PointeeTy << Call->getCallee()->getSourceRange()); else if (const auto *RT = PointeeTy->getAs()) { + + auto IsTriviallyCopyableCXXRecord = [](aut

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Aaron Ballman via cfe-commits
@@ -8899,18 +8899,42 @@ void Sema::CheckMemaccessArguments(const CallExpr *Call, << ArgIdx << FnName << PointeeTy << Call->getCallee()->getSourceRange()); else if (const auto *RT = PointeeTy->getAs()) { + + auto IsTriviallyCopyableCXXRecord = [](aut

[clang] [llvm] [RISCV] Add Smdbltrp and Ssdbltrp extension (PR #111837)

2024-10-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: T-Tie (T-Tie) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111837.diff 7 Files Affected: - (modified) clang/test/Preprocessor/riscv-target-features.c (+18) - (modified) llvm/docs/RISCVUsage.rst (+2) - (modified) llvm

[clang] [llvm] [RISCV] Add Smdbltrp and Ssdbltrp extension (PR #111837)

2024-10-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: T-Tie (T-Tie) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111837.diff 7 Files Affected: - (modified) clang/test/Preprocessor/riscv-target-features.c (+18) - (modified) llvm/docs/RISCVUsage.rst (+2) - (mo

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Aaron Ballman via cfe-commits
@@ -8899,18 +8899,42 @@ void Sema::CheckMemaccessArguments(const CallExpr *Call, << ArgIdx << FnName << PointeeTy << Call->getCallee()->getSourceRange()); else if (const auto *RT = PointeeTy->getAs()) { + + auto IsTriviallyCopyableCXXRecord = [](aut

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for this! It's missing a lot of test coverage that should be added to clang/test/SemaCXX and you should also add a release note to clang/docs/ReleaseNotes.rst so users know about the new diagnostic. https://github.com/llvm/llvm-project/pull/

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Aaron Ballman via cfe-commits
@@ -8899,18 +8899,42 @@ void Sema::CheckMemaccessArguments(const CallExpr *Call, << ArgIdx << FnName << PointeeTy << Call->getCallee()->getSourceRange()); else if (const auto *RT = PointeeTy->getAs()) { + + auto IsTriviallyCopyableCXXRecord = [](aut

[clang] [llvm] [RISCV] Add Smdbltrp and Ssdbltrp extension (PR #111837)

2024-10-10 Thread via cfe-commits
https://github.com/T-Tie created https://github.com/llvm/llvm-project/pull/111837 None >From 2c193cb89f5071ec89ccbe7df363bbff70dda85e Mon Sep 17 00:00:00 2001 From: T-Tie <160845405+t-...@users.noreply.github.com> Date: Thu, 10 Oct 2024 21:11:39 +0800 Subject: [PATCH 1/7] Update riscv-target-fe

[clang] [llvm] [RISCV] Add Smdbltrp and Ssdbltrp extension (PR #111837)

2024-10-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-10 Thread Nikolas Klauser via cfe-commits
@@ -102,7 +102,7 @@ struct __aliasing_iterator_wrapper { _LIBCPP_HIDE_FROM_ABI _Alias operator*() const _NOEXCEPT { _Alias __val; - __builtin_memcpy(&__val, std::__to_address(__base_), sizeof(value_type)); + __builtin_memcpy(&__val, static_cast(std::__to_ad

[clang] [llvm] [clang][LLVM Demangler] Add an assertion that validates that all mang… (PR #111391)

2024-10-10 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > I agree completely. I have a preference for the second thing as well. We can > have this be a warning-as-default-error type thing, which allows us to > disable this with a flag, but is still an error. I MIGHT suggest using the > functionality to see if that diagnostic is

[libclc] [libclc] Create an internal 'clc' builtins library (PR #109985)

2024-10-10 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: > > CC @rjodinchr. I realise now that this idea may prove problematic for > > `clspv`/`clspv64` targets. If this idea were to taken further, things like > > OpenCL `minmag` would call `__clc_minmag` which would call `__clc_fabs` > > (e.g.), but I notice `fabs` is not impleme

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-10-10 Thread Matt Arsenault via cfe-commits
arsenm wrote: > But that will still require to define, what is undesirable address space > right? The LangRef doesn't need to know why it's undesirable. It's like the n field https://github.com/llvm/llvm-project/pull/108786 ___ cfe-commits mailing li

[clang] Add code completion for C++20 keywords. (PR #107982)

2024-10-10 Thread via cfe-commits
https://github.com/16bit-ykiko updated https://github.com/llvm/llvm-project/pull/107982 >From fedea9e4fd57b618fe341e0c30982bff0f098c52 Mon Sep 17 00:00:00 2001 From: ykiko Date: Tue, 10 Sep 2024 14:59:10 +0800 Subject: [PATCH 1/7] add co_return, co_await, co_yield, consteval, constinit, concep

[clang] Add arrangeCXXMethodCall to the CodeGenABITypes interface. (PR #111597)

2024-10-10 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. Thanks, that looks good. https://github.com/llvm/llvm-project/pull/111597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-10 Thread Paul Kirth via cfe-commits
@@ -264,19 +263,18 @@ if (LIBCXX_ENABLE_SHARED) APPEND_STRING PROPERTY LINK_FLAGS " -Xlinker /MANIFEST:NO") endif() endif() -endif() set(CMAKE_STATIC_LIBRARY_PREFIX "lib") # Build the static library. -if (LIBCXX_ENABLE_STATIC) - add_lib

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-10 Thread Alex Voicu via cfe-commits
@@ -1,12 +1,14 @@ ; This test aims to check ability to support "Arithmetic with Overflow" intrinsics ; in the special case when those intrinsics are being generated by the CodeGenPrepare; -; pass during translations with optimization (note -O3 in llc arguments). +; pass during

[clang] [llvm] Apply alignment / size in linker rather than IR (PR #111918)

2024-10-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 923566a67de39a00eb6fc5cabbad307a72aa338e 3a962270521aa7b48b64e5ac5fa0edb900990023 --e

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-10 Thread Paul Kirth via cfe-commits
ilovepi wrote: I think I understand what's happening, but not why. We don't normally build `cxx_shared` on Linux, but now we do. I'm not sure why that's causing a problem on this test per se, but we set `LIBCXX_ENABLE_SHARED=OFF` in our build files, so I'm surprised its happening now. In fact

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-10-10 Thread via cfe-commits
higher-performance wrote: @AaronBallman: Oh I see. I didn't have any plans to upstream any matchers that used this, though I suppose I could. The check I had in mind though ostensibly could be in-tree, if you guys were interested. Though now that I think about it more, I think it would need `i

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (PR #108636)

2024-10-10 Thread Peilin Ye via cfe-commits
@@ -622,6 +665,47 @@ let Predicates = [BPFHasLdsx] in { def LDD : LOADi64; +class LOAD_ACQUIRE +: TYPE_LD_ST { + bits<4> dst; + bits<20> addr; + + let Inst{51-48} = dst; + let Inst{55-52} = addr{19-16}; // base reg + let Inst{47-32} = addr{15-0}; // offset + let Ins

[clang] [clang-format] Make bitwise and imply requires clause (PR #110942)

2024-10-10 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/110942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-10 Thread Jim Lin via cfe-commits
https://github.com/tclin914 updated https://github.com/llvm/llvm-project/pull/111653 >From 80768f580d4ef6b9841b22ee5b287a87d9f25951 Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Wed, 9 Oct 2024 11:37:46 +0800 Subject: [PATCH 1/2] [RISCV] Add support for inline asm constraint vd It constrains ve

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-10 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang-tools-extra] [clangd] Simplify code with *Map::operator[] (NFC) (PR #111939)

2024-10-10 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/111939 None >From aeebcbd92118161c1a75aefa369ba11f40f79ddd Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 10 Oct 2024 08:37:40 -0700 Subject: [PATCH] [clangd] Simplify code with *Map::operator[] (NFC) -

[clang-tools-extra] [clangd] Simplify code with *Map::operator[] (NFC) (PR #111939)

2024-10-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111939.diff 2 Files Affected: - (modified) clang-tools-extra/clangd/Headers.cpp (+2-2) - (modified) clang-tools-extra/clangd/XRe

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-10-10 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @cor3ntin yes, I do. Thanks https://github.com/llvm/llvm-project/pull/107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland: [clang] Finish implementation of P0522 (PR #111711)

2024-10-10 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Oh, i see. https://github.com/llvm/llvm-project/pull/111711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes avr-gcc also rejects since these devices has no SRAM. --- Full diff: https://github.com/llvm/llvm-project/pull/111798.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/AVR.cpp (+8) - (modified)

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Ben Shi (benshi001) Changes avr-gcc also rejects since these devices has no SRAM. --- Full diff: https://github.com/llvm/llvm-project/pull/111798.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/AVR.cpp (+8) - (mo

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-10 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/111798 avr-gcc also rejects since these devices has no SRAM. >From 438b4ed8556445d1950d7878660d893350fa27a6 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Thu, 10 Oct 2024 15:31:19 +0800 Subject: [PATCH] [Driver][AVR]

[clang] Enable matrices in HLSL (PR #111415)

2024-10-10 Thread Florian Hahn via cfe-commits
@@ -17,12 +17,12 @@ void add(sx10x10_t a, sx5x10_t b, sx10x5_t c) { // expected-error@-1 {{assigning to 'sx10x10_t' (aka 'float __attribute__((matrix_type(10, 10)))') from incompatible type 'sx5x10_t' (aka 'float __attribute__((matrix_type(5, 10)))')}} a = b + &c; - //

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #111785)

2024-10-10 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-change-namespace] Avoid repeated hash lookups (NFC) (PR #111784)

2024-10-10 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [flang][OpenMP] Add frontend support for ompx_bare clause (PR #111106)

2024-10-10 Thread Sergio Afonso via cfe-commits
@@ -1103,6 +1105,13 @@ bool ConstructDecompositionT::applyClause( return applyToOutermost(node); } +template +bool ConstructDecompositionT::applyClause( +const tomp::clause::OmpxBareT &clause, +const ClauseTy *node) { + return applyToAll(node); ska

[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-10 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/109147 From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Mon, 24 Jul 2023 13:56:29 +0200 Subject: [PATCH 1/3] [

[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-10 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/109147 From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Mon, 24 Jul 2023 13:56:29 +0200 Subject: [PATCH 1/3] [

[clang-tools-extra] [clang-apply-replacements] Avoid repeated hash lookups (NFC) (PR #111783)

2024-10-10 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-10 Thread Alejandro Álvarez Ayllón via cfe-commits
alejandro-alvarez-sonarsource wrote: > > Or even SuppressInlineNamespace should be changed from bool to some enum > > like None, Redundant, All. > > I think this is the suggestion I'd prefer; it's cleaner than adding a second > boolean option. Agreed. And changes. > Make sure that all curre

[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-10 Thread via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?=, Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-

[clang] 003375f - [clang][x86] Add constexpr support for some basic SSE2 fp intrinsics

2024-10-10 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-10T11:30:31+01:00 New Revision: 003375fb2b62967580712a704934927553fe540f URL: https://github.com/llvm/llvm-project/commit/003375fb2b62967580712a704934927553fe540f DIFF: https://github.com/llvm/llvm-project/commit/003375fb2b62967580712a704934927553fe540f.diff

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-10-10 Thread via cfe-commits
isuckatcs wrote: Thank you for the review! https://github.com/llvm/llvm-project/pull/110099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 6d8e966 - [clang-tidy] Portability Template Virtual Member Function Check (#110099)

2024-10-10 Thread via cfe-commits
Author: isuckatcs Date: 2024-10-10T12:32:39+02:00 New Revision: 6d8e966512f0b050e84b65c1deed479d5c92fe4c URL: https://github.com/llvm/llvm-project/commit/6d8e966512f0b050e84b65c1deed479d5c92fe4c DIFF: https://github.com/llvm/llvm-project/commit/6d8e966512f0b050e84b65c1deed479d5c92fe4c.diff LOG

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-10-10 Thread via cfe-commits
https://github.com/isuckatcs closed https://github.com/llvm/llvm-project/pull/110099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-10 Thread via cfe-commits
h-vetinari wrote: Congratulations on this huge milestone to all involved in flang! 🍾 🥳 🚀 https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] [RISCV] Add Smrnmi extension (PR #111668)

2024-10-10 Thread Sam Elliott via cfe-commits
@@ -813,6 +815,12 @@ def MRET : Priv<"mret", 0b0011000>, Sched<[]> { let rs1 = 0; let rs2 = 0b00010; } + +def MNRET : Priv<"mnret", 0b0111000>, Sched<[]> { lenary wrote: Does this need a `Requires=[HasStdExtSmrnmi]` (And a definition of `HasStdExtSmrnmi`)

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-10 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 83c98b18421e957592cfab88c48c2fd97ad97802 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-10 Thread Byoungchan Lee via cfe-commits
https://github.com/bc-lee updated https://github.com/llvm/llvm-project/pull/111375 >From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001 From: Byoungchan Lee Date: Mon, 7 Oct 2024 22:19:38 +0900 Subject: [PATCH 1/4] [clang-include-cleaner] Fix incorrect directory issue for wr

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-10 Thread Byoungchan Lee via cfe-commits
@@ -305,7 +342,32 @@ int main(int argc, const char **argv) { } } - clang::tooling::ClangTool Tool(OptionsParser->getCompilations(), + auto &CompilationDatabase = OptionsParser->getCompilations(); bc-lee wrote: I didn't simplify it much, but I tried to

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-10 Thread Byoungchan Lee via cfe-commits
https://github.com/bc-lee updated https://github.com/llvm/llvm-project/pull/111375 >From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001 From: Byoungchan Lee Date: Mon, 7 Oct 2024 22:19:38 +0900 Subject: [PATCH 1/5] [clang-include-cleaner] Fix incorrect directory issue for wr

[clang-tools-extra] [clang-include-cleaner] Fix incorrect directory issue for writing files (PR #111375)

2024-10-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f58e85a9725bb7d731c5ff5f79448e7150db6a6c 0c9477d3d7f2eb14f221a0a36cbd9dfd75015ef1 --e

[clang] [clang] Update string and string_view in lifetimebound tests (PR #111737)

2024-10-10 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/111737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

2024-10-10 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -212,6 +212,25 @@ typedef llvm::ImmutableMap REGISTER_TRAIT_WITH_PROGRAMSTATE(PendingArrayDestruction

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm edited https://github.com/llvm/llvm-project/pull/101644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
@@ -69,6 +69,11 @@ #ifndef SVE_VECTOR_TYPE_BFLOAT #define SVE_VECTOR_TYPE_BFLOAT(Name, MangledName, Id, SingletonId, NumEls, ElBits, NF) \ + SVE_VECTOR_TYPE_DETAILS(Name, MangledName, Id, SingletonId, NumEls, ElBits, NF, true, false, true) +#endif + +#ifndef SVE_VECTOR_TYPE

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm commented: Not sure if there's enough support to update all of them but, but many of the following should be extended to cover the new types: clang/test/CodeGenCXX/aarch64-sve-vector-init.cpp clang/test/CodeGenCXX/aarch64-mangle-sve-fixed-vectors.cpp clang/test

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
@@ -4339,7 +4339,6 @@ ASTContext::getBuiltinVectorTypeInfo(const BuiltinType *Ty) const { switch (Ty->getKind()) { default: llvm_unreachable("Unsupported builtin vector type"); - paulwalker-arm wrote: Please can we keep these blank lines. With all th

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
@@ -87,6 +87,10 @@ class SVEType { bool isDefault() const { return DefaultType; } bool isFloat() const { return Float && !BFloat; } bool isBFloat() const { return BFloat && !Float; } + bool isMFloat() const { +return MFloat && !BFloat && !Float; +; --

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
@@ -454,6 +458,8 @@ std::string SVEType::builtin_str() const { else if (isBFloat()) { assert(ElementBitwidth == 16 && "Not a valid BFloat."); S += "y"; + } else if (isMFloat()) { +S += "m"; paulwalker-arm wrote: Perhaps worth adding `assert(Elem

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
@@ -4354,12 +4353,16 @@ ASTContext::getBuiltinVectorTypeInfo(const BuiltinType *Ty) const { ElBits, NF) \ case BuiltinType::Id: \ return {BFloat16T

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-10 Thread Paul Walker via cfe-commits
@@ -87,6 +87,10 @@ class SVEType { bool isDefault() const { return DefaultType; } bool isFloat() const { return Float && !BFloat; } bool isBFloat() const { return BFloat && !Float; } paulwalker-arm wrote: To be consistent I think these need updating to i

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-10 Thread Balazs Benics via cfe-commits
steakhal wrote: > Thanks for the explanation, I agree with your POV and I don't think that we > need a drastic change like renaming or reordering everything. > > However, in this case I think it would be good to remove the type based > section headers, which are no longer accurate. When someon

[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

2024-10-10 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/isuckatcs edited https://github.com/llvm/llvm-project/pull/109804

[clang] [llvm] [AArch64] Introduce new armv9.6 features (PR #111677)

2024-10-10 Thread via cfe-commits
@@ -833,8 +866,8 @@ def HasV9_5aOps : Architecture64<9, 5, "a", "v9.5a", [HasV9_4aOps, FeatureCPA], !listconcat(HasV9_4aOps.DefaultExts, [FeatureCPA, FeatureLUT, FeatureFAMINMAX])>; def HasV9_6aOps : Architecture64<9, 6, "a", "v9.6a", - [HasV9_5aOps], - !listconcat(HasV

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/111701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: I have a few suggestions, but definitely support this. I've also added a few folks suggested by GitHub as reviewers to make sure we have coverage of someone who looks at CodeGen. https://github.com/llvm/llvm-project/pull/111701 __

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-10 Thread Ilya Biryukov via cfe-commits
@@ -0,0 +1,1013 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted -verify + +class AClass { +public: + AClass() {} + AClass &foo() { return *this; } +}; + +void test_bar() { + AClass a; + // expected-warning@* {{stack nearly exhausted; compilation time may suffer, a

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-10 Thread Ilya Biryukov via cfe-commits
@@ -5817,7 +5817,10 @@ LValue CodeGenFunction::EmitHLSLArrayAssignLValue(const BinaryOperator *E) { LValue CodeGenFunction::EmitCallExprLValue(const CallExpr *E, llvm::CallBase **CallOrInvoke) { - RValue RV = EmitCallExpr(E, ReturnV

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-10 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer updated https://github.com/llvm/llvm-project/pull/90959 >From 86e252cb84803bfaa2ec096b671ef366fd3ac5cb Mon Sep 17 00:00:00 2001 From: Sebastian Kreutzer Date: Thu, 26 Oct 2023 15:13:05 +0200 Subject: [PATCH 1/3] [XRay] Add DSO support for XRay instrumentatio

[clang] [clang][frontend] Add support for attribute plugins for statement attributes (PR #110334)

2024-10-10 Thread Eric Astor via cfe-commits
https://github.com/ericastor updated https://github.com/llvm/llvm-project/pull/110334 >From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Fri, 27 Sep 2024 22:35:28 + Subject: [PATCH 1/3] [clang][frontend] Add support for attribute plugins for stat

[clang] [clang][frontend] Support applying the annotate attribute to statements (PR #111841)

2024-10-10 Thread Erich Keane via cfe-commits
@@ -2125,6 +2126,19 @@ TemplateInstantiator::TransformTemplateParmRefExpr(DeclRefExpr *E, Arg, PackIndex); } +const AnnotateAttr * +TemplateInstantiator::TransformAnnotateAttr(const AnnotateAttr *AA) { + SmallVector Args; + for (Expr

[clang] [clang][frontend] Support applying the annotate attribute to statements (PR #111841)

2024-10-10 Thread Erich Keane via cfe-commits
@@ -242,6 +242,24 @@ static Attr *handleNoConvergentAttr(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) NoConvergentAttr(S.Context, A); } +static Attr *handleAnnotateAttr(Sema &S, Stmt *St, const ParsedAttr &A, erichkeane wrote: This is b

[clang] [clang][frontend] Support applying the annotate attribute to statements (PR #111841)

2024-10-10 Thread Erich Keane via cfe-commits
@@ -2125,6 +2126,19 @@ TemplateInstantiator::TransformTemplateParmRefExpr(DeclRefExpr *E, Arg, PackIndex); } +const AnnotateAttr * +TemplateInstantiator::TransformAnnotateAttr(const AnnotateAttr *AA) { + SmallVector Args; + for (Expr

[clang] [clang][analyzer] PointerSubChecker should not warn on pointers converted to numerical value (PR #111846)

2024-10-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) Changes Pointer values casted to integer (non-pointer) type should be able to be subtracted as usual. --- Full diff: https://github.com/llvm/llvm-project/pull/111846.diff

[clang] [clang][analyzer] PointerSubChecker should not warn on pointers converted to numerical value (PR #111846)

2024-10-10 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/111846 Pointer values casted to integer (non-pointer) type should be able to be subtracted as usual. From a9e1790691e01892f7e1b17523cd43421445f3ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= D

[clang] [llvm] [NFC] Replace more DenseMaps with SmallDenseMaps (PR #111836)

2024-10-10 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: Could you open a separate PR the code formatting changes? This will make it easier to review. https://github.com/llvm/llvm-project/pull/111836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [analyzer] Disable graph-trim-interval by default (PR #111843)

2024-10-10 Thread Balazs Benics via cfe-commits
steakhal wrote: And the message I wanted to share xD Is it a possible way forward dropping that assert? https://github.com/llvm/llvm-project/pull/111843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [flang] [mlir] [clang][flang][mlir] Reapply "Support -frecord-command-line option (#102975)" (PR #110132)

2024-10-10 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/110132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585, #111173)" (PR #111852)

2024-10-10 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/111852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA/HIP] fix propagate -cuid to a host-only compilation. (PR #111650)

2024-10-10 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > This does not seem to be the right fix. I tends to think the test > > https://github.com/ROCm/hip-tests/tree/amd-staging/samples/2_Cookbook/16_assembly_to_executable > > needs fix. Since it does not expect host-only compilation to use CUID, it > > should add `-fuse-cuid=non

[clang-tools-extra] [clang-apply-replacements] Avoid repeated hash lookups (NFC) (PR #111783)

2024-10-10 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/111783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >