[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > That's an excellent question, maybe @owenca will know! I should have asked in > https://github.com/llvm/llvm-project/pull/96804#discussion_r1718407404; what > I did instead was try to reason out an explanation based on what I could see, > and I came up with two theories

[clang] [analyzer] Modernize FuchsiaHandleChecker (PR #111588)

2024-10-08 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: CI again looks unrelated ```   | Failed Tests (1):   | LLVM :: Transforms/InstCombine/and-or-icmps.ll ``` https://github.com/llvm/llvm-project/pull/111588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [SPIR-V] strengthen some lit tests (PR #111636)

2024-10-08 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra created https://github.com/llvm/llvm-project/pull/111636 These tests were failing spuriously with unrelated changes under development. >From 107a8819e02c9a5eaf7db5a520543666ea3c3a91 Mon Sep 17 00:00:00 2001 From: Sameer Sahasrabuddhe Date: Wed, 9 Oct 2024 11:30:37 +

[clang] [SPIR-V] strengthen some lit tests (PR #111636)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sameer Sahasrabuddhe (ssahasra) Changes These tests were failing spuriously with unrelated changes under development. --- Full diff: https://github.com/llvm/llvm-project/pull/111636.diff 3 Files Affected: - (modified) clang/test/CodeGen

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-08 Thread Alex Bradbury via cfe-commits
asb wrote: > > We already have hard-coded logic to disable adding these tests to the > > `check-all` target in various cases. > > Why do you have to do that? I've never worked with the clang python bindings before, but you can basically see the reasoning in https://github.com/llvm/llvm-proje

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111528 I just tried using LLVM backend names here e.g. NVPTX but libclc want's targets more like triples. This change adds a mesasge to tell you that. Before you got: ``` libclc target 'AMDGCN' is enabled CMak

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-10-08 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: > still trying to reduce the reproducer... Please create a reproducer, the stack trace doesn't have information to understand what is causing the issue. https://github.com/llvm/llvm-project/pull/109167 ___ cfe-commits mailing list c

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-08 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/111434 >From 1904e7d4a3aeffd6f2f4ff397ae84fde37aa231a Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 7 Oct 2024 15:30:24 +0200 Subject: [PATCH 1/4] [clang] Warn about memset/memcpy to NonTriviall

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111528 >From 686a0404c968d3bcec56bca232599465a9549312 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 8 Oct 2024 12:40:40 + Subject: [PATCH 1/2] [libclc] Give a helpful error when an unknown target i

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-08 Thread via cfe-commits
serge-sans-paille wrote: + patches to make sure llvm, libc++ and compiler-rt don't trigger that extra warning https://github.com/llvm/llvm-project/pull/111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
@@ -151,6 +147,17 @@ if( "spirv-mesa3d-" IN_LIST LIBCLC_TARGETS_TO_BUILD OR "spirv64-mesa3d-" IN_LIST endif() endif() +if( LIBCLC_TARGETS_TO_BUILD STREQUAL "all" ) DavidSpickett wrote: I've put this after the spir-v tool check so that if you already knew t

[clang] [clang][Sema] Add instant event when template instantiation is deferred. (PR #111524)

2024-10-08 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. https://github.com/llvm/llvm-project/pull/111524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Add instant event when template instantiation is deferred. (PR #111524)

2024-10-08 Thread Utkarsh Saxena via cfe-commits
@@ -18146,6 +18148,16 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc, FunctionDecl *Func, std::make_pair(Func, PointOfInstantiation)); // Notify the consumer that a function was implicitly instantiated. Consumer.HandleCXXImplici

[clang] [OpenACC] 'collapse' clause 'force' tag (PR #110906)

2024-10-08 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1165 Here is the relevant piece

[clang] c0a2915 - [SystemZ][z/OS] don't write to source

2024-10-08 Thread Mikhail Goncharov via cfe-commits
Author: Mikhail Goncharov Date: 2024-10-08T15:09:23+02:00 New Revision: c0a2915321870672b1870c1ee1d192c07dddcd04 URL: https://github.com/llvm/llvm-project/commit/c0a2915321870672b1870c1ee1d192c07dddcd04 DIFF: https://github.com/llvm/llvm-project/commit/c0a2915321870672b1870c1ee1d192c07dddcd04.d

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67520 >From 055f7

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111369 >From a2dd2330359ecd3c04e01b6f9121481e6784014a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 7 Oct 2024 12:29:41 + Subject: [PATCH 1/2] [libclc] Update build instructions in readme The conf

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-10-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: Meh, adding the attribute to the definition and declaration of a member functio

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also do you know if libclc has any tests worth running in CI? It doesn't have a check-libclc so I'm not sure if that's because there's not much to run, or running the tests requires a GPU or something else. Context is I've been looking at the pipeline we use for PRs and it

[clang] [llvm] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from Clang to OMPIRBuilder (PR #110001)

2024-10-08 Thread Akash Banerjee via cfe-commits
TIFitis wrote: @jdoerfert @jsjodin Polite request for review :) https://github.com/llvm/llvm-project/pull/110001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread Fraser Cormack via cfe-commits
@@ -137,10 +137,6 @@ if( llvm-spirv_exe ) list( APPEND LIBCLC_TARGETS_ALL spirv-mesa3d- spirv64-mesa3d- ) endif() -if( LIBCLC_TARGETS_TO_BUILD STREQUAL "all" ) - set( LIBCLC_TARGETS_TO_BUILD ${LIBCLC_TARGETS_ALL} ) -endif() - list( SORT LIBCLC_TARGETS_TO_BUILD ) -

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From e02b44cf94c71c15235bb4727211587283778189 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH 1/5] [clang][Sema] Bad register variable type error should

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-10-08 Thread Chuanqi Xu via cfe-commits
@@ -644,8 +646,8 @@ New features if class of allocation and deallocation function mismatches. `Documentation `__. -- Function effects, e.g. the ``nonblocking`` and ``nonallocating`` "perfo

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,773 @@ +//===--- MutexModeling.cpp - Modeling of mutexes --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,126 @@ +//===--- MutexModelingDomain.h - Common vocabulary for modeling mutexes ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,169 @@ +//===--- MutexModelingGDM.h - Modeling of mutexes in GDM --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,773 @@ +//===--- MutexModeling.cpp - Modeling of mutexes --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,773 @@ +//===--- MutexModeling.cpp - Modeling of mutexes --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,139 @@ +//===--- MutexRegionExtractor.h - Modeling of mutexes -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,773 @@ +//===--- MutexModeling.cpp - Modeling of mutexes --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/111381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,139 @@ +//===--- MutexRegionExtractor.h - Modeling of mutexes -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Introduce MutexModeling checker (PR #111381)

2024-10-08 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: Nice well-designed code; I added several remarks, but they are all minor. https://github.com/llvm/llvm-project/pull/111381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67520 >From 055f7

[clang] [Clang] Improve type traits recognition in `__has_builtin` (PR #111516)

2024-10-08 Thread via cfe-commits
https://github.com/timsong-cpp edited https://github.com/llvm/llvm-project/pull/111516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve type traits recognition in `__has_builtin` (PR #111516)

2024-10-08 Thread via cfe-commits
https://github.com/timsong-cpp commented: Can a fix be backported to 19? https://github.com/llvm/llvm-project/pull/111516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Aaron Puchert via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: aaronpuchert wrote: We don't deduplicate "requires" attributes but check them directly. The resu

[clang] baa51ff - [sanitizer] Document AddressSanitizer security considerations (#100937)

2024-10-08 Thread via cfe-commits
Author: bigb4ng Date: 2024-10-08T09:22:10-07:00 New Revision: baa51ffd9c417c9ec272c601673c484bc4335319 URL: https://github.com/llvm/llvm-project/commit/baa51ffd9c417c9ec272c601673c484bc4335319 DIFF: https://github.com/llvm/llvm-project/commit/baa51ffd9c417c9ec272c601673c484bc4335319.diff LOG:

[clang] [llvm] [sanitizer] Document AddressSanitizer security considerations (PR #100937)

2024-10-08 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/100937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [sanitizer] Document AddressSanitizer security considerations (PR #100937)

2024-10-08 Thread via cfe-commits
github-actions[bot] wrote: @bigb4ng Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [llvm] [sanitizer] Document AddressSanitizer security considerations (PR #100937)

2024-10-08 Thread Florian Mayer via cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/100937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Aaron Puchert via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -2282,6 +2308,9 @@ void ThreadSafetyAnalyzer::runAnalysis(AnalysisDeclContex

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Aaron Puchert via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -2249,7 +2249,7 @@ void fooF1(Foo *f) EXCLUSIVE_LOCKS_REQUIRED(f->mu_) { f

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

2024-10-08 Thread via cfe-commits
cor3ntin wrote: > Er, while it would be nice for everything to be formatted properly, this > might cause some merge conflicts with other people’s changes in `Sema.cpp` > (or at least that’s why we don’t do bulk reformatting too often iirc), so I’m > not sure we just want to format entire files

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-08 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/111434 >From 1904e7d4a3aeffd6f2f4ff397ae84fde37aa231a Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 7 Oct 2024 15:30:24 +0200 Subject: [PATCH 1/4] [clang] Warn about memset/memcpy to NonTriviall

[clang] [clang][bytecode] Make sure ia32_bzhi input is an integer (PR #111505)

2024-10-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/111505 None >From 0194defe73dc816fa3993235eac84cb5571e4582 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 8 Oct 2024 10:57:14 +0200 Subject: [PATCH] [clang][bytecode] Make sure ia32_bzhi inpu

[clang] [clang][bytecode] Make sure ia32_bzhi input is an integer (PR #111505)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111505.diff 1 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+7-3) ``diff diff --git a/clang/lib/AST/ByteCode/In

[clang] [clang][bytecode] Make sure ia32_bzhi input is an integer (PR #111505)

2024-10-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/111505 >From bca04d7c89573c5ec1272fc2621b9e4acfae997e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 8 Oct 2024 10:57:14 +0200 Subject: [PATCH] [clang][bytecode] Make sure ia32_bzhi input is a

[clang] 1312369 - [clang][x86] Enable SSE2/AVX/AVX512 setzero intrinsics in constant expressions

2024-10-08 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-08T12:19:27+01:00 New Revision: 1312369afbeb2083094b3d34a88c346b22e86971 URL: https://github.com/llvm/llvm-project/commit/1312369afbeb2083094b3d34a88c346b22e86971 DIFF: https://github.com/llvm/llvm-project/commit/1312369afbeb2083094b3d34a88c346b22e86971.diff

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-10-08 Thread Younan Zhang via cfe-commits
@@ -5585,11 +5585,12 @@ bool Sema::CheckTemplateArgumentList( ContextRAII Context(*this, NewContext); CXXThisScopeRAII(*this, RD, ThisQuals, RD != nullptr); -MultiLevelTemplateArgumentList MLTAL = getTemplateInstantiationArgs( -Template, NewContext, /*Final

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-10-08 Thread Younan Zhang via cfe-commits
@@ -1144,6 +1164,46 @@ bool Sema::CheckInstantiatedFunctionTemplateConstraints( PointOfInstantiation, Satisfaction); } +bool Sema::CheckFunctionConstraintsWithoutInstantiation( zyn0217 wrote: I moved it into CheckFunctionT

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-08 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 4529c986fd4ed2d5801d5b555d107568309a34fc Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] 235067b - [clang][bytecode] Make sure ia32_bzhi input is an integer (#111505)

2024-10-08 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-08T13:30:40+02:00 New Revision: 235067b222e4734839b963e152b6554e20413d11 URL: https://github.com/llvm/llvm-project/commit/235067b222e4734839b963e152b6554e20413d11 DIFF: https://github.com/llvm/llvm-project/commit/235067b222e4734839b963e152b6554e20413d11.diff L

[clang] [clang][bytecode] Make sure ia32_bzhi input is an integer (PR #111505)

2024-10-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/111505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f01364e - [Clang] Instantiate the correct lambda call operator (#110446)

2024-10-08 Thread via cfe-commits
Author: Sirraide Date: 2024-10-08T13:34:00+02:00 New Revision: f01364ebc88d875fbfc0e00413538465aaa8a2b3 URL: https://github.com/llvm/llvm-project/commit/f01364ebc88d875fbfc0e00413538465aaa8a2b3 DIFF: https://github.com/llvm/llvm-project/commit/f01364ebc88d875fbfc0e00413538465aaa8a2b3.diff LOG:

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-10-08 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/110446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-08 Thread Chris B via cfe-commits
@@ -18901,6 +18901,150 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + // This should only be called when targeting DXIL + case Builtin::BI__builtin_hlsl_splitdou

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-08 Thread Chris B via cfe-commits
@@ -18901,6 +18901,150 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + // This should only be called when targeting DXIL + case Builtin::BI__builtin_hlsl_splitdou

[clang] Effect analysis: correctly detect `(x ? a : b)` as nonblocking when a and b are (PR #111224)

2024-10-08 Thread Chris Apple via cfe-commits
cjappl wrote: > @dougsonos Maybe you should ask for commit access since you’ll likely be > contributing more patches to this in the future as I understand it? > > > > CC @AaronBallman Does that still work like it used to or did your maintainers > rfc change something about that too? A few d

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-08 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: I've got a lot of style nits here. In general it is nice to break up changes into smaller changes where you can. One obvious split in this PR would have been to put the DirectX backend changes in first in a separate PR. Smaller PRs are easier to review

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-08 Thread Chris B via cfe-commits
@@ -18901,6 +18901,150 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + // This should only be called when targeting DXIL + case Builtin::BI__builtin_hlsl_splitdou

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-08 Thread Alex Voicu via cfe-commits
@@ -1,12 +1,14 @@ ; This test aims to check ability to support "Arithmetic with Overflow" intrinsics ; in the special case when those intrinsics are being generated by the CodeGenPrepare; -; pass during translations with optimization (note -O3 in llc arguments). +; pass during

[clang] [Clang] [NFC] Remove trailing whitespace in release notes (PR #111506)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111506.diff 1 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2-2) ``diff diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/Rele

[clang] [Clang] [NFC] Remove trailing whitespace in release notes (PR #111506)

2024-10-08 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/111506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Remove trailing whitespace in release notes (PR #111506)

2024-10-08 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/111506 None >From 3c4b656ac32c6dd47f00e312e9321df44b2db531 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Tue, 8 Oct 2024 11:05:42 +0200 Subject: [PATCH] [Clang] [NFC] Remove trailing whitespace in release notes ---

[clang] fbf9bea - [Clang] [NFC] Remove trailing whitespace in release notes (#111506)

2024-10-08 Thread via cfe-commits
Author: Sirraide Date: 2024-10-08T11:06:24+02:00 New Revision: fbf9bead3167d61e2e0fe581e968e86f45a04097 URL: https://github.com/llvm/llvm-project/commit/fbf9bead3167d61e2e0fe581e968e86f45a04097 DIFF: https://github.com/llvm/llvm-project/commit/fbf9bead3167d61e2e0fe581e968e86f45a04097.diff LOG:

[clang] [llvm] [clang][LLVM Demangler] Add an assertion that validates that all mang… (PR #111391)

2024-10-08 Thread Erich Keane via cfe-commits
@@ -1967,6 +1967,10 @@ def fclang_abi_compat_EQ : Joined<["-"], "fclang-abi-compat=">, Group, MetaVarName<"">, Values<".,latest">, HelpText<"Attempt to match the ABI of Clang ">; +def fno_demangling_failures: Flag<["-"], "fno-demangling-failures">, Group,

[clang] [llvm] [clang][LLVM Demangler] Add an assertion that validates that all mang… (PR #111391)

2024-10-08 Thread Erich Keane via cfe-commits
@@ -462,6 +462,9 @@ ENUM_CODEGENOPT(ZeroCallUsedRegs, llvm::ZeroCallUsedRegs::ZeroCallUsedRegsKind, /// non-deleting destructors. (No effect on Microsoft ABI.) CODEGENOPT(CtorDtorReturnThis, 1, 0) +/// Whether to validate if a produced mangled name can be demangled with LLVM

[clang] [llvm] [clang][LLVM Demangler] Add an assertion that validates that all mang… (PR #111391)

2024-10-08 Thread Erich Keane via cfe-commits
erichkeane wrote: > Sorry for jumping in late. > > I think Erich is on point that having a flag that controls an assertion is a > bit of a red flag as we are mixing build configuration and runtime > configuration. > > It is at least unusual and may cause confusion. > > After thinking about t

[clang] Effect analysis: correctly detect `(x ? a : b)` as nonblocking when a and b are (PR #111224)

2024-10-08 Thread Doug Wyatt via cfe-commits
dougsonos wrote: > Oh, also, are there any other places where we should maybe be using > `FunctionEffectsRef::get()`? Good question. I looked for other uses of `QualType` and `getType()` in SemaFunctionEffects, but this is the only spot (`checkIndirectCall`) where we are interested in obtaini

[clang] [clang][Sema] Add instant event when template instantiation is deferred. (PR #111524)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (ivanaivanovska) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111524.diff 3 Files Affected: - (modified) clang/lib/Sema/SemaExpr.cpp (+12) - (modified) clang/lib/Sema/SemaTemplateInstantiateDecl.cpp (+10) - (

[clang-tools-extra] [clang-tidy] New option `CompilationArgsToRemoveRegex` to remove arguments from the command line (PR #111453)

2024-10-08 Thread via cfe-commits
@@ -106,6 +106,9 @@ Improvements to clang-tidy - Improved :program:`run-clang-tidy.py` script. Fixed minor shutdown noise happening on certain platforms when interrupting the script. +- Improved :program:`clang-tidy` by adding the option `CompilationArgsToRemoveRegex` -

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2024-10-08 Thread via cfe-commits
@@ -222,6 +222,12 @@ Changes in existing checks by adding the option `UseUpperCaseLiteralSuffix` to select the case of the literal suffix in fixes. +- Improved :doc:`readability-redundant-casting + ` check by fixing + false negatives related to ``enum`` when setting ``Ig

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-08 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67520 >From 055f7

[clang] [Sema] Support negation/parens with __builtin_available (PR #111439)

2024-10-08 Thread George Burgess IV via cfe-commits
gburgessiv wrote: OK, thanks! I'll try to find someone with more context later today :) https://github.com/llvm/llvm-project/pull/111439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang] Improve type traits recognition in `__has_builtin` (PR #111516)

2024-10-08 Thread via cfe-commits
@@ -31,7 +31,10 @@ !__has_builtin(__underlying_type) || \ !__has_builtin(__is_trivial) || \ !__has_builtin(__is_same_as) || \ -!__has_builtin(__has_unique_object_representations) +!__has_builtin(__has_unique_object_representations) || \ +!__has_builtin(_

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2024-10-08 Thread via cfe-commits
@@ -222,6 +222,12 @@ Changes in existing checks by adding the option `UseUpperCaseLiteralSuffix` to select the case of the literal suffix in fixes. +- Improved :doc:`readability-redundant-casting + ` check by fixing + false negatives related to ``enum`` when setting ``Ig

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Iuri Chaer via cfe-commits
https://github.com/ichaer updated https://github.com/llvm/llvm-project/pull/111513 >From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001 From: Iuri Chaer Date: Tue, 8 Oct 2024 10:52:13 +0100 Subject: [PATCH 1/4] [clang-format] Add CI check confirming ClangFormatStyleOptions.r

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Iuri Chaer via cfe-commits
ichaer wrote: @owenca, see what you think. https://github.com/llvm/llvm-project/pull/111513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Iuri Chaer via cfe-commits
https://github.com/ichaer ready_for_review https://github.com/llvm/llvm-project/pull/111513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Iuri Chaer (ichaer) Changes * Create a new `clang-format-style-options` build target which re-generates ClangFormatStyleOptions.rst from its source header files. * Add CI check confirming that the repository's ClangFormatStyleOptions.rst i

[clang] [clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #111499)

2024-10-08 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/111499 >From 4951a7b9b87f9800bc3629bd44f65141ba98c6b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 8 Oct 2024 08:19:56 + Subject: [PATCH] start working on lifetime capture --- clang/include/clang/Basic/

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-08 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-08 Thread Chris B via cfe-commits
@@ -1992,6 +2001,37 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_hlsl_splitdouble: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +Expr *Op0 = TheCall

[clang] [flang] [llvm] [mlir] [flang][OpenMP] Add frontend support for ompx_bare clause (PR #111106)

2024-10-08 Thread Ivan R. Ivanov via cfe-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/06 >From e70fc69910083e4e6fb9f4e23f41e4eac6ae6c9b Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Fri, 4 Oct 2024 16:20:36 +0900 Subject: [PATCH 01/10] [flang] Add frontend support for OpenMP extension

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-08 Thread Chris B via cfe-commits
@@ -1992,6 +2001,37 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_hlsl_splitdouble: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +Expr *Op0 = TheCall

[clang] [clang] Introduce [[clang::lifetime_capture_by(X)]] (PR #111499)

2024-10-08 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/111499 >From 4951a7b9b87f9800bc3629bd44f65141ba98c6b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 8 Oct 2024 08:19:56 + Subject: [PATCH] start working on lifetime capture --- clang/include/clang/Basic/

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-08 Thread Chris B via cfe-commits
@@ -4681,6 +4681,11 @@ void CallArg::copyInto(CodeGenFunction &CGF, Address Addr) const { IsUsed = true; } +void CodeGenFunction::EmitWritebacks(CodeGenFunction &CGF, + const CallArgList &args) { + emitWritebacks(CGF, args);

[libclc] [libclc] Convert README to Markdown (PR #111549)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Github won't preview the markdown in the diff because the file moved, but you can see it here: https://github.com/llvm/llvm-project/blob/c84c1754ed6142293a2a06e75900772054cfcc67/libclc/README.md https://github.com/llvm/llvm-project/pull/111549 _

[clang] [clang] Change "bad" to "unsupported" in register type error (PR #111550)

2024-10-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Spickett (DavidSpickett) Changes This is maybe a personal take but I expect "bad" to either mean: * Allowed but not ideal, like a "bad" memory alignment might work but it is slow. * The tool won't allow it but is going to tell me why

[clang] d079743 - [clang] Fix comment typos in CodeGen::EmitLoadOfGlobalRegLValue

2024-10-08 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-10-08T15:48:59Z New Revision: d079743fe67e05697fe55409115a3614e6fe5c45 URL: https://github.com/llvm/llvm-project/commit/d079743fe67e05697fe55409115a3614e6fe5c45 DIFF: https://github.com/llvm/llvm-project/commit/d079743fe67e05697fe55409115a3614e6fe5c45.diff LOG

[clang] [clang] Change "bad" to "unsupported" in register type error (PR #111550)

2024-10-08 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM (I’ve definitely seen ‘bad X’ in other places before, and I’ve personally never really had a problem w/ that sort of wording, but I also can’t deny that ‘unsupported X’ is unquestionably clearer ;Þ) https://github.com/llvm/llvm-proj

[clang] [clang] Change "bad" to "unsupported" in register type error (PR #111550)

2024-10-08 Thread via cfe-commits
Sirraide wrote: I think we also might want to add a release note for this since this is technically improving a diagnostic, if only in a very minor way... https://github.com/llvm/llvm-project/pull/111550 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang][RISCV] Extend intrinsic size check variable from 16 -> 32 bits. NFC (PR #111481)

2024-10-08 Thread Brandon Wu via cfe-commits
4vtomat wrote: > Why don’t any of our lit tests that use every intrinsic catch it? Somehow if we add more "target-feature" the intrinsics increase, I'm not sure why. For example: ``` test.c #include "riscv_vector.h" vfloat16mf4x7_t test_vlseg7e16ff_v_f16mf4x7(const _Float16 *base, size_t *n

<    1   2   3   4   5   >