================
@@ -1,12 +1,14 @@
; This test aims to check ability to support "Arithmetic with Overflow"
intrinsics
; in the special case when those intrinsics are being generated by the
CodeGenPrepare;
-; pass during translations with optimization (note -O3 in llc arguments).
+; pass during translations with optimization (note -disable-lsr, to inhibit
+; strength reduction pre-empting with a more preferable match for this pattern
+; in llc arguments).
-; RUN: llc -O3 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
-; RUN: %if spirv-tools %{ llc -O3 -mtriple=spirv32-unknown-unknown %s -o -
-filetype=obj | spirv-val %}
+; RUN: llc -O3 -disable-lsr -mtriple=spirv32-unknown-unknown %s -o - |
FileCheck %s
----------------
AlexVlx wrote:
I'm not entirely sure about the original intent. This retains the current
behaviour of the test. Disabling LSR is necessary for that, and doing things
like so doesn't harm coverage. I don't know that I want to go and fully
re-develop this particular test at this point (it probably should be redone,
I'm just not entirey keen since I'm not entirey sure what is desired), as part
of this particular change. Doing it as strictly IR-to-IR would bypass the
original intent of the SPIR-V folks here, which seems centered around lowering
the staturated ops.
https://github.com/llvm/llvm-project/pull/110695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
