[clang] [clang] Implement transforms for DeducedTemplateName (PR #108491)

2024-09-13 Thread Alexander Kornienko via cfe-commits
alexfh wrote: Unfortunately, the original code, from which I reduced the test case for this, still breaks (without crashing Clang though). I'm trying to come up with another test case now. https://github.com/llvm/llvm-project/pull/108491 ___ cfe-comm

[clang-tools-extra] [clang-tidy]suggest use `std::span` as replacement of c array in C++20 for modernize-avoid-c-arrays (PR #108555)

2024-09-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/108555 >From 35742b5f2f085b8f6626456cd0d21ebecbe8f831 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Sep 2024 23:11:51 +0800 Subject: [PATCH 1/2] [clang-tidy]suggest use `std::span` as replacement of c

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Can you explain why exactly is this necessary/beneficial? If the compilation database got created with just the tool name, I'd expect the rest of the build to be able to use just the tool name when the scanner spits it out again, no? If this is about the scanner finding the

[clang] [RISCV][FMV] Support target_version (PR #99040)

2024-09-13 Thread Philip Reames via cfe-commits
https://github.com/preames edited https://github.com/llvm/llvm-project/pull/99040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/107867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -123,6 +123,10 @@ Changes in existing checks ` check to support replacing member function calls too. +- Improved :doc:`performance-avoid-endl + ` check to use ``std::endl`` as + placeholder when lexer cannot get source text. 5chmidti wrote: Sounds be

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Can you explain why exactly is this necessary/beneficial? If the compilation > database got created with just the tool name, I'd expect the rest of the > build to be able to use just the tool name when the scanner spits it out > again, no? If this is about the scanner finding

[clang] [RISCV][FMV] Support target_version (PR #99040)

2024-09-13 Thread Philip Reames via cfe-commits
@@ -11027,13 +11029,27 @@ static bool CheckMultiVersionValue(Sema &S, const FunctionDecl *FD) { } if (TVA) { -llvm::SmallVector Feats; -TVA->getFeatures(Feats); -for (const auto &Feat : Feats) { - if (!TargetInfo.validateCpuSupports(Feat)) { -S.Di

[clang] [RISCV][FMV] Support target_version (PR #99040)

2024-09-13 Thread Philip Reames via cfe-commits
@@ -10319,8 +10319,10 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC, // Handle attributes. ProcessDeclAttributes(S, NewFD, D); const auto *NewTVA = NewFD->getAttr(); - if (NewTVA && !NewTVA->isDefaultVersion() && - !Context.getTargetInfo

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread Lei Huang via cfe-commits
https://github.com/lei137 created https://github.com/llvm/llvm-project/pull/108584 Checks for clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c seem to have been manually upated to rename temp variables even though it says checks was auto generated. Regenerate via script in prep for ch

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-powerpc Author: Lei Huang (lei137) Changes Checks for clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c seem to have been manually upated to rename temp variables even though it says checks was auto generated. Regenerate via script in p

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Lei Huang (lei137) Changes Checks for clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c seem to have been manually upated to rename temp variables even though it says checks was auto generated. Regenerate via script in prep for ch

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: And practically - in the cases I've seen where CMake generates calls to `clang-scan-deps`, it always invokes `clang-scan-deps ... -- /absolute/path/to/compiler` (CMake in general is very keen on absolute paths to tools). But in separate testing of these tools, I ran into this

[clang] [clang][analyzer] Fix documentation of checker 'StackAddrAsyncEscape' (NFC) (PR #108586)

2024-09-13 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/108586 The checker was indicated as a 'C' language checker but is only applicable to 'ObjC' code. From 620a17fca9e6c011099e223cb965cd4bcc8f413a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date

[clang-tools-extra] [NFC][clang-tidy] document fix to bugprone-return-const-ref-from-parameter (PR #107641)

2024-09-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/107641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[clang] Add nuw attribute to GEPs (#105496)" (PR #107257)

2024-09-13 Thread Arseny Kapoulkine via cfe-commits
zeux wrote: Confirming this fixes the original problem on the larger codebase, thanks! https://github.com/llvm/llvm-project/pull/107257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Fix documentation of checker 'StackAddrAsyncEscape' (NFC) (PR #108586)

2024-09-13 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ffeb793 - [clang][analyzer][docs] Fix documentation of checker 'StackAddrAsyncEscape' (NFC) (#108586)

2024-09-13 Thread via cfe-commits
Author: Balázs Kéri Date: 2024-09-13T17:51:28+02:00 New Revision: ffeb793f3a90623ab3c7f33f922d48a1f5f97cdf URL: https://github.com/llvm/llvm-project/commit/ffeb793f3a90623ab3c7f33f922d48a1f5f97cdf DIFF: https://github.com/llvm/llvm-project/commit/ffeb793f3a90623ab3c7f33f922d48a1f5f97cdf.diff L

[clang] [clang][analyzer] Fix documentation of checker 'StackAddrAsyncEscape' (NFC) (PR #108586)

2024-09-13 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/108586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Joshua Batista via cfe-commits
@@ -1,5 +1,24 @@ // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread Lei Huang via cfe-commits
https://github.com/lei137 updated https://github.com/llvm/llvm-project/pull/108584 >From 70077d359e2f98a3c4b24fcf638a51c6a0272473 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 13 Sep 2024 15:00:19 + Subject: [PATCH 1/2] [PowerPC][NFC] autogen mma tc checks via llvm/utils/update_cc_te

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread Lei Huang via cfe-commits
https://github.com/lei137 edited https://github.com/llvm/llvm-project/pull/108584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread Lei Huang via cfe-commits
https://github.com/lei137 edited https://github.com/llvm/llvm-project/pull/108584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread Lei Huang via cfe-commits
https://github.com/lei137 edited https://github.com/llvm/llvm-project/pull/108584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/106782 >From 99408f31a8946df7ef9efa223d0dba2ab876fcd0 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 30 Aug 2024 12:08:37 -0700 Subject: [PATCH 1/4] add diag and testing for space and global constants ---

[clang] [llvm] [clang][hlsl] Add atan2 intrinsic part 1 (PR #107923)

2024-09-13 Thread Tex Riddell via cfe-commits
https://github.com/tex3d updated https://github.com/llvm/llvm-project/pull/107923 >From 44b355687a3e148bfe3d5e4f95efd39363b58b07 Mon Sep 17 00:00:00 2001 From: Tex Riddell Date: Mon, 9 Sep 2024 14:39:18 -0700 Subject: [PATCH 1/3] [clang][hlsl] Add atan2 intrinsic part 1 Issue: #70096 Changes:

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -1,5 +1,24 @@ // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

2024-09-13 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp edited https://github.com/llvm/llvm-project/pull/67352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-globalisel Author: None (alex-t) Changes ### Brief overview: As we mask the bits on the CF diverge, we have to set them back after executing the instructions in a conditional block. This currently happens at the beginning of the block where the CF

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-regalloc Author: None (alex-t) Changes ### Brief overview: As we mask the bits on the CF diverge, we have to set them back after executing the instructions in a conditional block. This currently happens at the beginning of the block where the CF co

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: None (alex-t) Changes ### Brief overview: As we mask the bits on the CF diverge, we have to set them back after executing the instructions in a conditional block. This currently happens at the beginning of the block where the CF converge

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Ok, thanks for the explanation. This LGTM, but the checks are failing on > Windows due to `.exe` extension that's not accounted for. I don't think any > of the tests you touched really care about the executable path, so I'd be > fine with just removing those check lines. Ah,

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. https://github.com/llvm/llvm-project/pull/108539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp requested changes to this pull request. https://github.com/llvm/llvm-project/pull/106782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Explicitly reject dependent types without diagnostic (PR #108598)

2024-09-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/108598 This should never happen I believe, but if it does, the "non-literal type ''" diagnostic is weird. That dependent type should never reach this stage I believe. If we actually try to generate code for this, we

[clang] [clang][ExprConst] Explicitly reject dependent types without diagnostic (PR #108598)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This should never happen I believe, but if it does, the "non-literal type ''" diagnostic is weird. That dependent type should never reach this stage I believe. If we actually try to generate

[clang] cd6844c - [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (#108584)

2024-09-13 Thread via cfe-commits
Author: Lei Huang Date: 2024-09-13T12:15:11-04:00 New Revision: cd6844c45cbe9a5c4cf055142c4026dc408a8243 URL: https://github.com/llvm/llvm-project/commit/cd6844c45cbe9a5c4cf055142c4026dc408a8243 DIFF: https://github.com/llvm/llvm-project/commit/cd6844c45cbe9a5c4cf055142c4026dc408a8243.diff LOG

[clang] [PowerPC][NFC] autogen mma tc checks via update_cc_test_checks (PR #108584)

2024-09-13 Thread Lei Huang via cfe-commits
https://github.com/lei137 closed https://github.com/llvm/llvm-project/pull/108584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Xiang Li via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/108539 From 4119204e2da13d00bd6ac5d23e05a4f269b2b75c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Fri, 13 Sep 2024 13:57:49 +0300 Subject: [PATCH 1/2] [clang-scan-deps] Infer the tool locatio

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-13 Thread Зишан Мирза via cfe-commits
zimirza wrote: I have now tested `ctime` and `ctime_r` locally. It seems to work now. https://github.com/llvm/llvm-project/pull/107285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-13 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/107627 >From 2d9cc933aa8dc6819c3b0a08f5457bad98e8e6df Mon Sep 17 00:00:00 2001 From: higher-performance Date: Fri, 6 Sep 2024 14:16:15 -0400 Subject: [PATCH 1/2] Propagate lifetimebound from formal parameter

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-13 Thread via cfe-commits
@@ -462,14 +462,16 @@ static void visitFunctionCallArguments(IndirectLocalPath &Path, Expr *Call, } } - for (unsigned I = 0, -N = std::min(Callee->getNumParams(), Args.size()); - I != N; ++I) { -if (CheckCoroCall || Callee->getParamDecl(I)->ha

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-13 Thread via cfe-commits
@@ -266,6 +262,20 @@ void Sema::inferLifetimeBoundAttribute(FunctionDecl *FD) { LifetimeBoundAttr::CreateImplicit(Context, FD->getLocation())); } } + } else if (auto *CanonDecl = FD->getCanonicalDecl(); FD != CanonDecl) { +// Propagate the lifetimeb

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-13 Thread via cfe-commits
https://github.com/higher-performance deleted https://github.com/llvm/llvm-project/pull/107627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-13 Thread via cfe-commits
@@ -266,6 +262,20 @@ void Sema::inferLifetimeBoundAttribute(FunctionDecl *FD) { LifetimeBoundAttr::CreateImplicit(Context, FD->getLocation())); } } + } else if (auto *CanonDecl = FD->getCanonicalDecl(); FD != CanonDecl) { +// Propagate the lifetimeb

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

2024-09-13 Thread James Y Knight via cfe-commits
jyknight wrote: I'll commit as soon as anyone gives it an approval. :) https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGData] Clang Options (PR #90304)

2024-09-13 Thread Jan Svoboda via cfe-commits
@@ -2753,6 +2753,31 @@ void tools::addMachineOutlinerArgs(const Driver &D, addArg(Twine("-enable-machine-outliner=never")); } } + + auto *CodeGenDataGenArg = + Args.getLastArg(options::OPT_fcodegen_data_generate_EQ); + auto *CodeGenDataUseArg = Args.getLastAr

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-13 Thread Зишан Мирза via cfe-commits
zimirza wrote: I am testing locally and did find some issues. I will be fixing it now. https://github.com/llvm/llvm-project/pull/107285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-13 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/107627 >From 2d9cc933aa8dc6819c3b0a08f5457bad98e8e6df Mon Sep 17 00:00:00 2001 From: higher-performance Date: Fri, 6 Sep 2024 14:16:15 -0400 Subject: [PATCH 1/2] Propagate lifetimebound from formal parameter

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

2024-09-13 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f902339 - Adjust modulemap to mark mm3dnow as textual header. (#107155)

2024-09-13 Thread via cfe-commits
Author: James Y Knight Date: 2024-09-13T12:30:04-04:00 New Revision: f902339d7f24a278b9c77d0226053075bd232ee5 URL: https://github.com/llvm/llvm-project/commit/f902339d7f24a278b9c77d0226053075bd232ee5 DIFF: https://github.com/llvm/llvm-project/commit/f902339d7f24a278b9c77d0226053075bd232ee5.diff

[clang] Adjust modulemap to mark mm3dnow as textual header. (PR #107155)

2024-09-13 Thread James Y Knight via cfe-commits
https://github.com/jyknight closed https://github.com/llvm/llvm-project/pull/107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/106782 >From 99408f31a8946df7ef9efa223d0dba2ab876fcd0 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 30 Aug 2024 12:08:37 -0700 Subject: [PATCH 1/5] add diag and testing for space and global constants ---

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-13 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: @ganeshgit OK to commit? https://github.com/llvm/llvm-project/pull/107964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-13 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: I have a fix, so I'll reapply this sometime today. https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-13 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp deleted https://github.com/llvm/llvm-project/pull/106782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-09-13 Thread via cfe-commits
https://github.com/alex-t edited https://github.com/llvm/llvm-project/pull/108596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] Correct the line attribution for IF branches (PR #108300)

2024-09-13 Thread Paul T Robinson via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: %clang_cc1 -debug-info-kind=limited -gno-column-info -triple=x86_64-pc-linux -emit-llvm %s -o - | FileCheck %s + +// The important thing is that the compare and the conditional branch have +// locs with the same scope (the lexical block for the 'if'). B

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-09-13 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/108276 >From 35af05f255db5aef2841212ff35f04eb5e967d93 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 10 Sep 2024 02:22:18 +0100 Subject: [PATCH 1/3] [Clang] Add explicit visibility symbol macros and update CM

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-09-13 Thread via cfe-commits
https://github.com/alex-t edited https://github.com/llvm/llvm-project/pull/108596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-09-13 Thread Thomas Fransham via cfe-commits
@@ -166,7 +166,7 @@ if(ENABLE_SHARED) set_target_properties(libclang PROPERTIES VERSION ${LIBCLANG_LIBRARY_VERSION} - DEFINE_SYMBOL _CINDEX_LIB_) + DEFINE_SYMBOL _CINDEX_LIB_ DEFINE_SYMBOL CLANG_EXPORTS) fsfod wrote: I've fixed this

[clang] [PowerPC] Fix incorrect store alignment for __builtin_vsx_build_pair() (PR #108606)

2024-09-13 Thread Lei Huang via cfe-commits
https://github.com/lei137 created https://github.com/llvm/llvm-project/pull/108606 Fixes #107229 >From 2c268981bb25cd1a1ed6c121789c5bd763fb1296 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 13 Sep 2024 17:11:09 + Subject: [PATCH] [PowerPC] Fix incorrect store alignment for __builtin

[clang] [PowerPC] Fix incorrect store alignment for __builtin_vsx_build_pair() (PR #108606)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Lei Huang (lei137) Changes Fixes #107229 --- Full diff: https://github.com/llvm/llvm-project/pull/108606.diff 3 Files Affected: - (modified) clang/lib/CodeGen/CGBuiltin.cpp (+1-1) - (modified) clang/test/CodeGen/PowerPC/builtin

[clang-tools-extra] [clang-tidy]suggest use `std::span` as replacement of c array in C++20 for modernize-avoid-c-arrays (PR #108555)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -38,6 +39,13 @@ AST_MATCHER(clang::ParmVarDecl, isArgvOfMain) { return FD ? FD->isMain() : false; } +AST_MATCHER_P(clang::TypeLoc, alwaysTrue, + clang::ast_matchers::internal::Matcher, + InnerMatcher) { + InnerMatcher.matches(Node, Finder, Build

[clang] [PowerPC] Fix incorrect store alignment for __builtin_vsx_build_pair() (PR #108606)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-powerpc Author: Lei Huang (lei137) Changes Fixes #107229 --- Full diff: https://github.com/llvm/llvm-project/pull/108606.diff 3 Files Affected: - (modified) clang/lib/CodeGen/CGBuiltin.cpp (+1-1) - (modified) clang/test/CodeGen/PowerPC/built

[clang-tools-extra] [clang-tidy]suggest use `std::span` as replacement of c array in C++20 for modernize-avoid-c-arrays (PR #108555)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -1,9 +1,9 @@ -// RUN: %check_clang_tidy %s modernize-avoid-c-arrays %t -- \ +// RUN: %check_clang_tidy -std=c++17 %s modernize-avoid-c-arrays %t -- \ // RUN: -config='{CheckOptions: { modernize-avoid-c-arrays.AllowStringArrays: true }}' const char name[] = "name"; const

[clang-tools-extra] [clang-tidy]suggest use `std::span` as replacement of c array in C++20 for modernize-avoid-c-arrays (PR #108555)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -111,6 +111,10 @@ Changes in existing checks ` check to suggest replacing the offending code with ``reinterpret_cast``, to more clearly express intent. +- Improved :doc:`modernize-avoid-c-arrays + ` check to suggest use std::span + as replacement of c array in C++20.

[clang-tools-extra] [clang-tidy]suggest use `std::span` as replacement of c array in C++20 for modernize-avoid-c-arrays (PR #108555)

2024-09-13 Thread Julian Schmidt via cfe-commits
@@ -72,11 +81,24 @@ void AvoidCArraysCheck::registerMatchers(MatchFinder *Finder) { void AvoidCArraysCheck::check(const MatchFinder::MatchResult &Result) { const auto *ArrayType = Result.Nodes.getNodeAs("typeloc"); - + const bool IsInParam = + Result.Nodes.getNodeAs("

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-13 Thread Зишан Мирза via cfe-commits
zimirza wrote: Tests for `ctime` and `ctime_r` are now good. https://github.com/llvm/llvm-project/pull/107285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4ef16e3 - [NFC][clang-tidy] document fix to bugprone-return-const-ref-from-parameter (#107641)

2024-09-13 Thread via cfe-commits
Author: Julian Schmidt Date: 2024-09-13T19:05:23+02:00 New Revision: 4ef16e3160750717f447fd76e2383c10b68eb5ae URL: https://github.com/llvm/llvm-project/commit/4ef16e3160750717f447fd76e2383c10b68eb5ae DIFF: https://github.com/llvm/llvm-project/commit/4ef16e3160750717f447fd76e2383c10b68eb5ae.diff

[clang-tools-extra] [NFC][clang-tidy] document fix to bugprone-return-const-ref-from-parameter (PR #107641)

2024-09-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/107641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Prefer std::getenv to ::getenv (PR #108529)

2024-09-13 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Okay, thanks for clarifying. Shall I close this one? https://github.com/llvm/llvm-project/pull/108529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-13 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 updated https://github.com/llvm/llvm-project/pull/100757 >From 99116cbe7fa4ce73b7dd242052cdfd59331f5338 Mon Sep 17 00:00:00 2001 From: Jonas Paulsson Date: Mon, 11 Oct 2021 19:08:42 +0200 Subject: [PATCH 1/2] VerifyIntegerArgs() i8 test. LangRef text. tests IP Tests

[clang] [llvm] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME2 instruction (PR #97602)

2024-09-13 Thread via cfe-commits
@@ -350,3 +350,12 @@ void test_svdot_multi_za32_bad_lane(uint32_t slice_base, svuint16_t z_u16, svsudot_lane_za32_s8_vg1x2(slice_base, z_s8x2, z_u8, 4); // expected-error {{argument value 4 is outside the valid range [0, 3]}} svsudot_lane_za32_s8_vg1x4(slice_base, z_s8x4,

[clang] [llvm] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME2 instruction (PR #97602)

2024-09-13 Thread via cfe-commits
@@ -0,0 +1,401 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +bf16 -target-feature +sme -target-feature +sme2 -target-feature +sme-lutv2 -O2 -Werror -Wa

[clang] [llvm] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME2 instruction (PR #97602)

2024-09-13 Thread via cfe-commits
@@ -935,7 +935,7 @@ defm FAMIN_4Z4Z : sme2_fp_sve_destructive_vector_vg4_multi<"famin", 0b0010101>; } //[HasSME2, HasFAMINMAX] let Predicates = [HasSME2, HasSME_LUTv2] in { SpencerAbson wrote: Not to do with this work, but I think the predication around FEAT

[clang] [llvm] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME2 instruction (PR #97602)

2024-09-13 Thread via cfe-commits
@@ -0,0 +1,401 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +bf16 -target-feature +sme -target-feature +sme2 -target-feature +sme-lutv2 -O2 -Werror -Wa

[clang] [llvm] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME2 instruction (PR #97602)

2024-09-13 Thread via cfe-commits
@@ -2899,6 +2899,15 @@ let TargetPrefix = "aarch64" in { [llvm_i32_ty], [IntrNoMem, IntrHasSideEffects]>; + def int_aarch64_sme_write_lane_zt SpencerAbson wrote: `svzero_zt` is defined like this: `def int_aarch64_sme_zero_zt : DefaultAtt

[clang] [llvm] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME2 instruction (PR #97602)

2024-09-13 Thread via cfe-commits
@@ -0,0 +1,401 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +bf16 -target-feature +sme -target-feature +sme2 -target-feature +sme-lutv2 -O2 -Werror -Wa

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-09-13 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: > I think the general direction is fine here. I would suggest to split this up > into three parts: 1. Add noext attribute and disabled verification, 2. fix > any verification failures (e.g. by emitting noext), 3. enable verification. > > It would be good to still be able to ena

[clang] [llvm] [X86][AVX10.2] Support AVX10.2 MOVZXC new Instructions. (PR #108537)

2024-09-13 Thread via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: llvm-mc -triple i386 --show-encoding %s | FileCheck %s + +// CHECK: vmovd %xmm2, %xmm1 +// CHECK: encoding: [0x62,0xf1,0x7e,0x08,0x7e,0xca] + vmovd %xmm2, %xmm1 mahesh-attarde wrote: These are not preset in akshay's original

[clang] [llvm] [X86][AVX10.2] Support AVX10.2 MOVZXC new Instructions. (PR #108537)

2024-09-13 Thread via cfe-commits
https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/108537 >From d8e76ea27679df40d0c796a5e8e5bc31433b6bff Mon Sep 17 00:00:00 2001 From: mattarde Date: Fri, 13 Sep 2024 03:26:14 -0700 Subject: [PATCH 1/2] update clr --- clang/lib/Headers/CMakeLists.txt

[clang] [llvm] Thin3 (PR #108614)

2024-09-13 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com created https://github.com/llvm/llvm-project/pull/108614 None >From dd7de1a900dceb411931d9d5a49b164096c314a2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/2] [ThinLTO][NFC] Prep for two-codegen rounds --- cla

[clang] [llvm] [X86][AVX10.2] Support AVX10.2 MOVZXC new Instructions. (PR #108537)

2024-09-13 Thread via cfe-commits
https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/108537 >From d8e76ea27679df40d0c796a5e8e5bc31433b6bff Mon Sep 17 00:00:00 2001 From: mattarde Date: Fri, 13 Sep 2024 03:26:14 -0700 Subject: [PATCH 1/3] update clr --- clang/lib/Headers/CMakeLists.txt

[clang] d4f41be - [Utils] add update-verify-tests.py (#97369)

2024-09-13 Thread via cfe-commits
Author: Henrik G. Olsson Date: 2024-09-13T10:47:34-07:00 New Revision: d4f41befb7256f8e8378ae358b2b3d802454d6a4 URL: https://github.com/llvm/llvm-project/commit/d4f41befb7256f8e8378ae358b2b3d802454d6a4 DIFF: https://github.com/llvm/llvm-project/commit/d4f41befb7256f8e8378ae358b2b3d802454d6a4.di

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-13 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn closed https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add `[[hlsl::raw_buffer]]` attribute (PR #107954)

2024-09-13 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/107954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add `[[hlsl::raw_buffer]]` attribute (PR #107954)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -6168,10 +6168,19 @@ class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode { struct Attributes { // Data gathered from HLSL resource attributes llvm::dxil::ResourceClass ResourceClass; + +LLVM_PREFERRED_TYPE(bool) uint8_t IsROV : 1;

[clang] [HLSL] Add `[[hlsl::raw_buffer]]` attribute (PR #107954)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -6168,10 +6168,19 @@ class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode { struct Attributes { // Data gathered from HLSL resource attributes llvm::dxil::ResourceClass ResourceClass; + +LLVM_PREFERRED_TYPE(bool) uint8_t IsROV : 1;

[clang] [HLSL] Add `[[hlsl::raw_buffer]]` attribute (PR #107954)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -6168,10 +6168,19 @@ class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode { struct Attributes { // Data gathered from HLSL resource attributes llvm::dxil::ResourceClass ResourceClass; + +LLVM_PREFERRED_TYPE(bool) uint8_t IsROV : 1;

[clang] [HLSL] Add `[[hlsl::raw_buffer]]` attribute (PR #107954)

2024-09-13 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -ast-dump -o - %s | FileCheck %s damyanp wrote: Presumably we have tests somewhere for resource handles that don't have raw_buffer on them, and they just don't show up here beca

<    1   2   3   4   5   >