mizvekov wrote:
By the way, just realized I should mention this, but we still support
'-fno-relaxed-template-template-args', if anything, you could compile SPEC with
that flag in order to workaround this breakage meanwhile, until the above patch
is merged.
https://github.com/llvm/llvm-project
https://github.com/carlosgalvezp approved this pull request.
LGTM, thanks for the quick fix!
https://github.com/llvm/llvm-project/pull/107412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: Kazu Hirata
Date: 2024-09-05T08:36:09-07:00
New Revision: 0593b95ff4c459ccf71f9472c148967d40f6d865
URL:
https://github.com/llvm/llvm-project/commit/0593b95ff4c459ccf71f9472c148967d40f6d865
DIFF:
https://github.com/llvm/llvm-project/commit/0593b95ff4c459ccf71f9472c148967d40f6d865.diff
L
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/107294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,95 @@
+// RUN: %clang_cc1 -verify -triple x86_64-unknown-linux-gnu -fsyntax-only
--embed-dir=%S/Inputs -std=c23 %s -pedantic -Wall
+
+#include
+
+enum us : unsigned short {
+ us_max = USHRT_MAX,
+ us_violation, // expected-error {{enumerator value 65536 is not
rep
@@ -0,0 +1,95 @@
+// RUN: %clang_cc1 -verify -triple x86_64-unknown-linux-gnu -fsyntax-only
--embed-dir=%S/Inputs -std=c23 %s -pedantic -Wall
AaronBallman wrote:
```suggestion
// RUN: %clang_cc1 -verify -triple x86_64-unknown-linux-gnu -fsyntax-only
-std=c23 %s
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/107260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/107357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/107358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NagyDonat wrote:
@vabridgers I rewrote the title and description of this PR to describe the
current approach. Feel free to adjust (or partially restore) it if you'd prefer
a different phrasing.
https://github.com/llvm/llvm-project/pull/107294
___
cfe
Author: Kazu Hirata
Date: 2024-09-05T08:35:46-07:00
New Revision: abfb340b779f2b20009fe42ebc522417adf79c44
URL:
https://github.com/llvm/llvm-project/commit/abfb340b779f2b20009fe42ebc522417adf79c44
DIFF:
https://github.com/llvm/llvm-project/commit/abfb340b779f2b20009fe42ebc522417adf79c44.diff
L
@@ -5413,18 +5413,20 @@ void Parser::ParseEnumSpecifier(SourceLocation
StartLoc, DeclSpec &DS,
BaseRange = SourceRange(ColonLoc,
DeclaratorInfo.getSourceRange().getEnd());
- if (!getLangOpts().ObjC && !getLangOpts().C23) {
+ if (!getLangOpts().ObjC) {
https://github.com/AaronBallman approved this pull request.
Mostly LGTM, just some minor nits.
https://github.com/llvm/llvm-project/pull/107260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: Mital Ashok
Date: 2024-09-05T17:38:08+02:00
New Revision: be427dfb9ea6689947253d737708dc3645e179dc
URL:
https://github.com/llvm/llvm-project/commit/be427dfb9ea6689947253d737708dc3645e179dc
DIFF:
https://github.com/llvm/llvm-project/commit/be427dfb9ea6689947253d737708dc3645e179dc.diff
L
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/102044
>From 90441c251c1ec5a3b8be923ca9678c8d3d586bee Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Mon, 5 Aug 2024 20:29:12 +0100
Subject: [PATCH 1/8] [Clang][Sema] Backport P2741R3 (static_assert with
user-gener
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/102044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lukel97 wrote:
I tried out #94981 and -fno-relaxed-template-template-args and can confirm both
fix it. I'm now running into a separate LoopVectorizer crash, but I made it out
of the frontend :)
Using -fno-relaxed-template-template-args should be fine, in llvm-test-suite we
already do somethin
vabridgers wrote:
Thanks @NagyDonat I'll update.
https://github.com/llvm/llvm-project/pull/107294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
Thanks for doing that!
LGTM
https://github.com/llvm/llvm-project/pull/107399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/107417
Both feature has target feature so can be checked if the usage is valid.
>From 9dadc9bffc40e02dff9ef6a1d79968c8980892f4 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 5 Sep 2024 16:42:43 +0200
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Daniel Kiss (DanielKristofKiss)
Changes
Both feature has target feature so can be checked if the usage is valid.
---
Full diff: https://github.com/llvm/llvm-project/pull/107417.diff
2 Files Affected:
- (modified) clang/lib/Headers/arm_
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/106658
>From 664c9fa9ade11150d635b9dbfb4c1ada7e32e8cd Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 29 Aug 2024 20:36:05 -0700
Subject: [PATCH] [TableGen] Add const variants of accessors for backend
Split Reco
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/106658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1693d8eb9aa94b0e8e2395234e6c63b57a2017b7
9dadc9bffc40e02dff9ef6a1d79968c8980892f4 --e
https://github.com/tblah commented:
Thanks for the quick updates. I don't have any idea off the top of my head how
to fix the LLVM timings. Do any other reviewers have thoughts/experience in
this area?
https://github.com/llvm/llvm-project/pull/107270
___
zyn0217 wrote:
While looking at it, I found another bug where we seem to have problems
mangling `std::source_location`
https://clang.godbolt.org/z/467E19h45
https://github.com/llvm/llvm-project/pull/107411
___
cfe-commits mailing list
cfe-commits@list
@@ -2287,6 +2288,15 @@ APValue SourceLocExpr::EvaluateInContext(const
ASTContext &Ctx,
Context = getParentContext();
}
+ // If we are currently parsing a lambda declarator, we might not have a fully
+ // formed call operator declaration yet, and we could not form a fu
@@ -326,24 +326,11 @@ static bool shouldTrackFirstArgument(const FunctionDecl
*FD) {
return false;
}
-static bool implicitObjectParamIsLifetimeBound(const FunctionDecl *FD) {
- const TypeSourceInfo *TSI = FD->getTypeSourceInfo();
- if (!TSI)
-return false;
- // Don't
https://github.com/mshockwave approved this pull request.
> I propose the following next steps (once this is committed):
this timeline looks fine, do you also want to add `[[deprecated]]` once the PSA
is out?
Also, I can help on other LLVM TableGen backends if they haven't been updated.
https:
jurahul wrote:
> > I propose the following next steps (once this is committed):
>
> this timeline looks fine, do you also want to add `[[deprecated]]` once the
> PSA is out? Also, I can help on other LLVM TableGen backends if they haven't
> been updated.
Yeah, once all the upstream backends a
jurahul wrote:
I also did a minor update to the diff: I changed the const versions that used
to return references to vectors to instead return `ArrayRef`.
IMO this will prevent accidental vector copies in code like `auto X =
RC.getAllDerivedDefinitions("yyy")`.
https://github.com/llvm/llvm-pr
@@ -412,6 +445,30 @@ class SubstTemplateTemplateParmStorage
std::optional PackIndex);
};
+class DeducedTemplateStorage : public UncommonTemplateNameStorage,
cor3ntin wrote:
I think a comment describing when this is useful would be benefi
@@ -1198,6 +1198,18 @@ void TextNodeDumper::dumpBareTemplateName(TemplateName
TN) {
dumpTemplateName(STS->getReplacement(), "replacement");
return;
}
+ case TemplateName::DeducedTemplate: {
+OS << " deduced";
+const DeducedTemplateStorage *DTS = TN.getAsDedu
@@ -6797,15 +6821,58 @@ ASTContext::getCanonicalTemplateName(const TemplateName
&Name) const {
canonArgPack, subst->getAssociatedDecl()->getCanonicalDecl(),
subst->getFinal(), subst->getIndex());
}
+ case TemplateName::DeducedTemplate: {
+assert(IgnoreDe
@@ -2143,15 +2107,17 @@ static TemplateDeductionResult
DeduceTemplateArgumentsByTypeMatch(
unsigned SubTDF = TDF & TDF_IgnoreQualifiers;
if (auto Result = DeduceTemplateArgumentsByTypeMatch(
S, TemplateParams, PPT, APT, Info, Deduced, SubTDF,
-
@@ -6797,15 +6821,58 @@ ASTContext::getCanonicalTemplateName(const TemplateName
&Name) const {
canonArgPack, subst->getAssociatedDecl()->getCanonicalDecl(),
subst->getFinal(), subst->getIndex());
}
+ case TemplateName::DeducedTemplate: {
+assert(IgnoreDe
@@ -326,6 +320,48 @@ namespace classes {
// expected-error@-1 {{no matching function for call}}
}
} // namespace packs
+ namespace nested {
cor3ntin wrote:
Do we need more tests?
Maybe add the example from #100692 ?
https://github.com/llvm/llvm-p
@@ -5327,9 +5332,29 @@ bool Sema::CheckTemplateArgumentList(
SmallVector CanonicalArgumentPack;
unsigned ArgIdx = 0, NumArgs = NewArgs.size();
LocalInstantiationScope InstScope(*this, true);
- for (TemplateParameterList::iterator Param = Params->begin(),
-
@@ -9219,7 +9222,8 @@ class Sema final : public SemaBase {
/// \returns true if an error occurred, false otherwise.
bool CheckTemplateArgumentList(
TemplateDecl *Template, SourceLocation TemplateLoc,
- TemplateArgumentListInfo &TemplateArgs, bool PartialTemplateA
@@ -6803,9 +6809,6 @@ bool CXXNameMangler::mangleSubstitution(QualType T) {
}
bool CXXNameMangler::mangleSubstitution(TemplateName Template) {
- if (TemplateDecl *TD = Template.getAsTemplateDecl())
-return mangleSubstitution(TD);
-
cor3ntin wrote:
Can yo
@@ -134,11 +134,16 @@ static bool hasSameExtendedValue(llvm::APSInt X,
llvm::APSInt Y) {
return X == Y;
}
+/// What kind of PartialOrdering we're performing template argument deduction
+/// for (C++0x [temp.deduct.partial]).
cor3ntin wrote:
```suggestion
/
@@ -134,11 +134,16 @@ static bool hasSameExtendedValue(llvm::APSInt X,
llvm::APSInt Y) {
return X == Y;
}
+/// What kind of PartialOrdering we're performing template argument deduction
cor3ntin wrote:
```suggestion
/// The kind of PartialOrdering we're per
@@ -1371,11 +1371,17 @@ class TemplateDiff {
/// argument info into a tree.
void DiffTemplate(const TemplateSpecializationType *FromTST,
const TemplateSpecializationType *ToTST) {
+// FIXME: With P3310R0, A TST formed from a DeducedTemplateName might
@@ -645,6 +645,9 @@ static bool
IsStructurallyEquivalent(StructuralEquivalenceContext &Context,
// It is sufficient to check value of getAsTemplateDecl.
break;
+ case TemplateName::DeducedTemplate:
+ // FIXME: We can't reach here.
+ llvm_unreachable("unimp
@@ -139,28 +165,63 @@ TemplateName::NameKind TemplateName::getKind() const {
return AssumedTemplate;
if (uncommon->getAsSubstTemplateTemplateParm())
return SubstTemplateTemplateParm;
+ if (uncommon->getAsDeducedTemplateName())
+return DeducedTemplate;
+
+ assert
@@ -139,28 +165,63 @@ TemplateName::NameKind TemplateName::getKind() const {
return AssumedTemplate;
if (uncommon->getAsSubstTemplateTemplateParm())
return SubstTemplateTemplateParm;
+ if (uncommon->getAsDeducedTemplateName())
+return DeducedTemplate;
+
+ assert
@@ -9219,7 +9222,8 @@ class Sema final : public SemaBase {
/// \returns true if an error occurred, false otherwise.
bool CheckTemplateArgumentList(
TemplateDecl *Template, SourceLocation TemplateLoc,
- TemplateArgumentListInfo &TemplateArgs, bool PartialTemplateA
cor3ntin wrote:
> While looking at it, I found another bug where we seem to have problems
> mangling `std::source_location` https://clang.godbolt.org/z/467E19h45
See https://github.com/llvm/llvm-project/issues/59948#issuecomment-2331676234
:)
https://github.com/llvm/llvm-project/pull/107411
@@ -2287,6 +2288,15 @@ APValue SourceLocExpr::EvaluateInContext(const
ASTContext &Ctx,
Context = getParentContext();
}
+ // If we are currently parsing a lambda declarator, we might not have a fully
+ // formed call operator declaration yet, and we could not form a fu
@@ -4,3 +4,12 @@
int __attribute__((target("arch=rv64g"))) foo(void) { return 0; }
//expected-error@+1 {{redefinition of 'foo'}}
int __attribute__((target("arch=rv64gc"))) foo(void) { return 0; }
+
+//expected-warning@+1 {{unsupported 'notafeature' in the 'target' attribute
st
aaronpuchert wrote:
That might not be enough. A function might not be used (or even referenced) in
the TU that defines it, but only in other TUs. But it would certainly catch a
number of issues already.
https://github.com/llvm/llvm-project/pull/67520
___
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
androm3da wrote:
Hmm, so I already have `CMAKE_CXX_COMPILER_TARGET` set this way in
`hexagon-linux-cross.cmake` (I left this cache out of this PR but I could
include
https://github.com/androm3da updated
https://github.com/llvm/llvm-project/pull/98712
>From bca45b046e8b6092bfa44c01172ecfcad84758d7 Mon Sep 17 00:00:00 2001
From: Brian Cain
Date: Fri, 12 Jul 2024 21:34:56 -0700
Subject: [PATCH] [cmake] Add hexagon-linux cmake cache files
These can be used to
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
Author: Abhina Sree
Date: 2024-09-05T13:25:06-04:00
New Revision: 311ac6381649fa0f7cc495db8fa697d6a9b43988
URL:
https://github.com/llvm/llvm-project/commit/311ac6381649fa0f7cc495db8fa697d6a9b43988
DIFF:
https://github.com/llvm/llvm-project/commit/311ac6381649fa0f7cc495db8fa697d6a9b43988.diff
L
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/107399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 commented:
According to [gcc
docs](https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html) `--sysroot`
applies to headers and libraries, and `-isysroot` overrides it for headers
only. This is different from the "independence" described for World 2. That is,
if we
https://github.com/vabridgers updated
https://github.com/llvm/llvm-project/pull/107294
>From d83ef8d13a2a9d242995eec16d82ca2cf08d8700 Mon Sep 17 00:00:00 2001
From: Vince Bridgers
Date: Wed, 4 Sep 2024 20:36:06 +0200
Subject: [PATCH] [analyzer] Remove overzealous "No dispatcher registered"
ass
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/107280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/eugenis updated
https://github.com/llvm/llvm-project/pull/107280
>From 8b8275314634d40aa40007fa14e8989b61cf87e7 Mon Sep 17 00:00:00 2001
From: Evgenii Stepanov
Date: Wed, 4 Sep 2024 10:06:48 -0700
Subject: [PATCH] [sanitizer] Delay sanitizer args parsing
Delay sanitizer arg
erichkeane wrote:
> That might not be enough. A function might not be used (or even referenced)
> in the TU that defines it, but only in other TUs. But it would certainly
> catch a number of issues already.
Right, though catching that ends up being pretty impossible. The most you could
do is
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/107160
>From 337a9ed1d5e7c71fb5be5741afe7726f5b76af7b Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Tue, 3 Sep 2024 15:30:50 -0700
Subject: [PATCH 1/6] [HLSL] Apply resource attributes to the resource type
rather t
@@ -326,24 +326,11 @@ static bool shouldTrackFirstArgument(const FunctionDecl
*FD) {
return false;
}
-static bool implicitObjectParamIsLifetimeBound(const FunctionDecl *FD) {
- const TypeSourceInfo *TSI = FD->getTypeSourceInfo();
- if (!TSI)
-return false;
- // Don't
https://github.com/joaosaffran edited
https://github.com/llvm/llvm-project/pull/107292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0J
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw==?=,
=?utf
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=,
=?utf-8?b?0J
@@ -18695,6 +18695,48 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
CGM.getHLSLRuntime().getSaturateIntrinsic(), ArrayRef{Op0},
nullptr, "hlsl.saturate");
}
+ case Builtin::BI__builtin_hlsl_select: {
+Value *OpCond = EmitScalarExpr(E->getArg(0));
https://github.com/farzonl deleted
https://github.com/llvm/llvm-project/pull/107129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -556,46 +562,120 @@ void SemaHLSL::handleShaderAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(NewAttr);
}
-void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) {
- if (!AL.isArgIdent(0)) {
-Diag(AL.getLoc(), diag::err_attribute_argument_type)
-
https://github.com/pow3clk edited
https://github.com/llvm/llvm-project/pull/106588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spall updated
https://github.com/llvm/llvm-project/pull/107129
>From 3e0cd3c450eb4aa28742c4879733987e9e2692e7 Mon Sep 17 00:00:00 2001
From: Sarah Spall
Date: Wed, 28 Aug 2024 01:44:35 +
Subject: [PATCH 1/6] implement select intrinsic
---
clang/include/clang/Basic/Built
https://github.com/damyanp commented:
LGTM - would be good to get approval from @farzonl before completing.
https://github.com/llvm/llvm-project/pull/107129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/zimirza updated
https://github.com/llvm/llvm-project/pull/107285
From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?=
=?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>
@@ -42,7 +42,7 @@ static StringRef getReplacementFor(StringRef FunctionName,
// Try to find a better replacement from Annex K first.
StringRef AnnexKReplacementFunction =
StringSwitch(FunctionName)
-.Cases("asctime", "asctime_r", "asctime_s")
+
https://github.com/zimirza updated
https://github.com/llvm/llvm-project/pull/107285
From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?=
=?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>
@@ -62,6 +62,9 @@ struct TimeConstants {
static constexpr int ASCTIME_BUFFER_SIZE = 256;
static constexpr int ASCTIME_MAX_BYTES = 26;
+ static constexpr int CTIME_BUFFER_SIZE = 256;
zimirza wrote:
That is correct. I have removed these and just used `asct
@@ -0,0 +1,22 @@
+//===-- Implementation of ctime_r function
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1600,6 +1602,19 @@ def StdC : StandardSpec<"stdc"> {
ArgSpec,
]
>,
+ FunctionSpec<
+ "ctime",
+ RetValSpec,
+ [ArgSpec]
zimirza wrote:
That is correct. I have now rem
Author: cor3ntin
Date: 2024-09-05T20:45:31+02:00
New Revision: d219c63b16851ba264b6495e3f63016d1c8b2aac
URL:
https://github.com/llvm/llvm-project/commit/d219c63b16851ba264b6495e3f63016d1c8b2aac
DIFF:
https://github.com/llvm/llvm-project/commit/d219c63b16851ba264b6495e3f63016d1c8b2aac.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/107411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
androm3da wrote:
@SundeepKushwaha or @ronlieb could you review this PR? Should be
non-controversial I hope.
https://github.com/llvm/llvm-project/pull/107161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
@@ -0,0 +1,45 @@
+// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
+// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \
+// RUN: -o - | FileCheck %s --check-prefixes=CHECK
+
+// CHECK: %hlsl.select = select i1
+// CHECK: ret i32 %hlsl.selec
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/107129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zimirza updated
https://github.com/llvm/llvm-project/pull/107285
From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?=
=?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>
https://github.com/zimirza updated
https://github.com/llvm/llvm-project/pull/107285
From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?=
=?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>
@@ -28104,6 +28104,251 @@ TEST_F(FormatTest, BreakBinaryOperations) {
Style);
}
+TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) {
+ FormatStyle Style = getLLVMStyle();
+ Style.FixNamespaceComments = false;
+ Style.ShortNamespaceLines = 0;
+ Style.M
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/107451
There are not a lot of outstanding known issues
with deducing this (besides #95112), so it
seems reasonable to claim full support.
Fixes #82780
>From 65a8fbf3f7e0a9ecdd29183ce2a73928b49abde4 Mon Sep 17 00:00:0
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
There are not a lot of outstanding known issues
with deducing this (besides #95112), so it
seems reasonable to claim full support.
Fixes #82780
---
Full diff: https://github.com/llvm/llvm-project/pull/107451.di
@@ -0,0 +1,165 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+
+// RUN: %clang_cc1 -O2 -triple aarch64 -emit-llvm -x c -DUSE_NEON_H %s -o -
| FileCheck %s
+// RUN: %clang_cc1 -O2 -triple aarch64 -emit-llvm -x c -DUSE
https://github.com/SpencerAbson edited
https://github.com/llvm/llvm-project/pull/100608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2582,6 +2582,60 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) {
OS << "typedef double float64_t;\n";
OS << "#endif\n\n";
+ OS << R"(
+typedef uint64_t fpm_t;
+
+enum __ARM_FPM_FORMAT { __ARM_FPM_E5M2, __ARM_FPM_E4M3 };
+
+enum __ARM_FPM_OVERFLOW { __ARM_FPM_INF
https://github.com/SpencerAbson commented:
Thanks for updating the tests! Just a few questions.
https://github.com/llvm/llvm-project/pull/100608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
erichkeane wrote:
It appears that https://github.com/llvm/llvm-project/pull/95112 is actually
pretty close... are we better off holding off on this until after that goes in?
https://github.com/llvm/llvm-project/pull/107451
___
cfe-commits mailing l
https://github.com/lei137 updated
https://github.com/llvm/llvm-project/pull/104816
>From 5ceb717b6f9ce11a12fde4aa9aaa89b4e017ef70 Mon Sep 17 00:00:00 2001
From: Lei Huang
Date: Mon, 19 Aug 2024 12:24:31 -0400
Subject: [PATCH 1/2] Fix codegen for transparent_union function params
Update codegen
cor3ntin wrote:
There is no urgency. I made the pr so we don't forget (I certainly had...)
https://github.com/llvm/llvm-project/pull/107451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
pogo59 wrote:
FTR I have no good explanation for why the PS4 handling is in the state it's
in--thanks for sorting this!
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/107160
>From 337a9ed1d5e7c71fb5be5741afe7726f5b76af7b Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Tue, 3 Sep 2024 15:30:50 -0700
Subject: [PATCH 1/6] [HLSL] Apply resource attributes to the resource type
rather t
201 - 300 of 477 matches
Mail list logo
