[clang] [clang] Catch missing format attributes (PR #105479)

2024-08-22 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From ea3a338fe6207109ca8ab3d4bed9a354141a3898 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] ec5e585 - [NFC] Replace bool <= bool comparison (#102948)

2024-08-22 Thread via cfe-commits
Author: Mital Ashok Date: 2024-08-22T17:04:39+02:00 New Revision: ec5e58519d24010beea937fccf5fc4541db3ec21 URL: https://github.com/llvm/llvm-project/commit/ec5e58519d24010beea937fccf5fc4541db3ec21 DIFF: https://github.com/llvm/llvm-project/commit/ec5e58519d24010beea937fccf5fc4541db3ec21.diff L

[clang] [NFC] Replace bool <= bool comparison (PR #102948)

2024-08-22 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/102948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-22 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Alternatively, we don't need tablegen changes if we leave the encoding of > which language standard a builtin is constexpr since to a helper function. @hubert-reinterpretcast I have implemented what you proposed. Removed the `ConstExprSince` attribute and replaced it with me

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-08-22 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: Patch updated per @nikic suggestion to use a TargetOption flag to simply disable this for llc. With all the llc lit tests out of the way, I now see: - 1 test failing in CodeGenObjC - failing tests in clang/test/Interpreter - failing tetss in llvm/test/ExecutionEngine/Orc/./OrcJ

[clang] [analyzer] Detect leak of a stack address through output arguments 2/3 (PR #105653)

2024-08-22 Thread Donát Nagy via cfe-commits
@@ -297,20 +314,29 @@ std::optional printReferrer(const MemRegion *Referrer) { return "global"; assert(isa(Space)); return "stack"; - }(Referrer->getMemorySpace()); - - // We should really only have VarRegions here. - // Anything else is really surprising, and

[clang] [analyzer] Detect leak of a stack address through output arguments 2/3 (PR #105653)

2024-08-22 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat requested changes to this pull request. Looks good overall, but `getOriginRegion()` is a troublesome function (see inline comment for details). https://github.com/llvm/llvm-project/pull/105653 ___ cfe-commits mailing list

[clang] [analyzer] Detect leak of a stack address through output arguments 2/3 (PR #105653)

2024-08-22 Thread Donát Nagy via cfe-commits
@@ -297,20 +314,29 @@ std::optional printReferrer(const MemRegion *Referrer) { return "global"; assert(isa(Space)); return "stack"; - }(Referrer->getMemorySpace()); - - // We should really only have VarRegions here. - // Anything else is really surprising, and

[clang] [analyzer] Detect leak of a stack address through output arguments 2/3 (PR #105653)

2024-08-22 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/105653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-22 Thread Janek van Oirschot via cfe-commits
@@ -0,0 +1,533 @@ +; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -enable-ipra=0 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s + +; SGPR use may not seem equal to the sgpr use provided in comments as the latter includes extra sgprs (e.g., for vcc use).

[clang] [analyzer] Detect leak of a stack address through output arguments 2/3 (PR #105653)

2024-08-22 Thread Arseniy Zaostrovnykh via cfe-commits
@@ -297,20 +314,29 @@ std::optional printReferrer(const MemRegion *Referrer) { return "global"; assert(isa(Space)); return "stack"; - }(Referrer->getMemorySpace()); - - // We should really only have VarRegions here. - // Anything else is really surprising, and

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-22 Thread Janek van Oirschot via cfe-commits
@@ -0,0 +1,533 @@ +; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -enable-ipra=0 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s + +; SGPR use may not seem equal to the sgpr use provided in comments as the latter includes extra sgprs (e.g., for vcc use). + +; Fun

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

2024-08-22 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm created https://github.com/llvm/llvm-project/pull/105684 Sometimes a collection of multilibs has a gap in it, where a set of driver command-line options can't work with any of the available libraries. For example, the Arm MVE extension requires special startup co

[clang] [clang][Driver] Add a custom error option in multilib.yaml. (PR #105684)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Simon Tatham (statham-arm) Changes Sometimes a collection of multilibs has a gap in it, where a set of driver command-line options can't work with any of the available libraries. For example, the Arm MVE extension requires special startup

[clang] [clang][AArch64] Add SME2.1 feature macros (PR #105657)

2024-08-22 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. Thanks, this looks good to me. https://github.com/llvm/llvm-project/pull/105657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [llvm] [WebAssembly] Change half-precision feature name to fp16. (PR #105434)

2024-08-22 Thread Derek Schuff via cfe-commits
https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/105434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix null pointer dereference in enum debug info generation (PR #105556)

2024-08-22 Thread Paul T Robinson via cfe-commits
pogo59 wrote: The patch title and description claims more than it actually does. The assertion does not "fix" or prevent a null dereference, it's simply documenting a requirement. Please update the title and description. https://github.com/llvm/llvm-project/pull/105556

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-08-22 Thread Galen Elias via cfe-commits
https://github.com/galenelias updated https://github.com/llvm/llvm-project/pull/105597 >From 4118b7dde9adbee7b6aaf5d094d34cb6b64f6c77 Mon Sep 17 00:00:00 2001 From: Galen Elias Date: Wed, 21 Aug 2024 16:33:42 -0700 Subject: [PATCH 1/2] clang-format: Add "AllowShortNamespacesOnASingleLine" opti

[clang] eb549da - [Driver] Add -Wa, options -mmapsyms={default, implicit}

2024-08-22 Thread via cfe-commits
Author: Fangrui Song Date: 2024-08-22T09:20:53-07:00 New Revision: eb549da9e5c1e626edb14ba9ce43e46ad3d088af URL: https://github.com/llvm/llvm-project/commit/eb549da9e5c1e626edb14ba9ce43e46ad3d088af DIFF: https://github.com/llvm/llvm-project/commit/eb549da9e5c1e626edb14ba9ce43e46ad3d088af.diff

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-08-22 Thread via cfe-commits
@@ -2142,85 +2169,35 @@ void NeonEmitter::genOverloadTypeCheckCode(raw_ostream &OS, OS << "#endif\n\n"; } -void NeonEmitter::genIntrinsicRangeCheckCode(raw_ostream &OS, -SmallVectorImpl &Defs) { - OS << "#ifdef GET_NEON_IMMEDIATE_CHE

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-22 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [clang][bytecode] Fix 'if consteval' in non-constant contexts (PR #104707)

2024-08-22 Thread Timm Baeder via cfe-commits
@@ -4368,8 +4363,19 @@ template bool Compiler::visitIfStmt(const IfStmt *IS) { if (!visitDeclStmt(CondDecl)) return false; - if (!this->visitBool(IS->getCond())) -return false; + // Compile condition. + if (IS->isNonNegatedConsteval()) { +if (!this->emit

[clang] 27727d8 - [C23] Remove WG14 N2517 from the status page

2024-08-22 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-08-22T12:37:49-04:00 New Revision: 27727d85a95dd501ce6d6660900b656622de9ae0 URL: https://github.com/llvm/llvm-project/commit/27727d85a95dd501ce6d6660900b656622de9ae0 DIFF: https://github.com/llvm/llvm-project/commit/27727d85a95dd501ce6d6660900b656622de9ae0.diff

[clang] [Clang] Implement P2747 constexpr placement new (PR #104586)

2024-08-22 Thread via cfe-commits
cor3ntin wrote: @AaronBallman ping :) https://github.com/llvm/llvm-project/pull/104586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix 'if consteval' in non-constant contexts (PR #104707)

2024-08-22 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. Thanks for bearing with me! https://github.com/llvm/llvm-project/pull/104707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang][bytecode] Allow adding offsets to function pointers (PR #105641)

2024-08-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/4139 Here is the relevant piece of the build log for

[clang] 7d373ce - [WebAssembly] Change half-precision feature name to fp16. (#105434)

2024-08-22 Thread via cfe-commits
Author: Brendan Dahl Date: 2024-08-22T09:44:33-07:00 New Revision: 7d373cef4941e9be1c2c86375ba9a8943c55e9cd URL: https://github.com/llvm/llvm-project/commit/7d373cef4941e9be1c2c86375ba9a8943c55e9cd DIFF: https://github.com/llvm/llvm-project/commit/7d373cef4941e9be1c2c86375ba9a8943c55e9cd.diff

[clang] [llvm] [WebAssembly] Change half-precision feature name to fp16. (PR #105434)

2024-08-22 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl closed https://github.com/llvm/llvm-project/pull/105434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Update status page for TS 18661 integration (PR #105693)

2024-08-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Up for review just to make sure there's not been work happening that I wasn't aware of, and to verify the removal of N2401. https://github.com/llvm/llvm-project/pull/105693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-22 Thread Doug Wyatt via cfe-commits
dougsonos wrote: I believe I have addressed all feedback so far. https://github.com/llvm/llvm-project/pull/99656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't insert a space between :: and * (PR #105043)

2024-08-22 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/105043 >From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 20 Aug 2024 06:44:41 -0700 Subject: [PATCH 1/5] [clang-format] Don't insert a space between :: and * Also, don't

[clang] [clang][bytecode] Reject void InitListExpr differently (PR #105697)

2024-08-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/105697 This reverts c79d1fa540390f6e37e1ea326153559eeadd0de6 and 125aa10b3d645bd26523a1bc321bb2e6b1cf04e1 Instead, just only use emitInvalid() for void InitListExprs if we're not discarding them. >From 719be4236d30

[clang] [clang][bytecode] Reject void InitListExpr differently (PR #105697)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This reverts c79d1fa540390f6e37e1ea326153559eeadd0de6 and 125aa10b3d645bd26523a1bc321bb2e6b1cf04e1 Instead, just only use emitInvalid() for void InitListExprs if we're not discarding them. --- Full diff: h

[clang] [clang][bytecode][NFC] Get rid of const_casts in Move fns (PR #105698)

2024-08-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/105698 None >From a2fe95e451340d2065f626c8b736a46feb1caa84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 22 Aug 2024 15:32:53 +0200 Subject: [PATCH] [clang][bytecode][NFC] Get rid of const_c

[clang] [clang][bytecode][NFC] Get rid of const_casts in Move fns (PR #105698)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/105698.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Descriptor.cpp (+10-13) - (modified) clang/lib/AST/ByteCode/Descriptor.h (+1-1)

[clang] [clang-format] Don't insert a space between :: and * (PR #105043)

2024-08-22 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/105043 >From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 20 Aug 2024 06:44:41 -0700 Subject: [PATCH 1/6] [clang-format] Don't insert a space between :: and * Also, don't

[clang] [clang][bytecode] Fix 'if consteval' in non-constant contexts (PR #104707)

2024-08-22 Thread Timm Baeder via cfe-commits
tbaederr wrote: No problem, I know how confusing this can be :) https://github.com/llvm/llvm-project/pull/104707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix 'if consteval' in non-constant contexts (PR #104707)

2024-08-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/104707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b9c4c4c - [clang][bytecode] Fix 'if consteval' in non-constant contexts (#104707)

2024-08-22 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-22T19:06:09+02:00 New Revision: b9c4c4ccf921c0481d51d4e0c9e862aa9ea3fcf3 URL: https://github.com/llvm/llvm-project/commit/b9c4c4ccf921c0481d51d4e0c9e862aa9ea3fcf3 DIFF: https://github.com/llvm/llvm-project/commit/b9c4c4ccf921c0481d51d4e0c9e862aa9ea3fcf3.diff L

[clang] [HLSL] Add __builtin_hlsl_is_scalarized_layout_compatible (PR #102227)

2024-08-22 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/102227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] C++20 Coroutines: Introduce Frontend Attribute [[clang::coro_await_elidable]] (PR #99282)

2024-08-22 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/99282 >From 9c8163db0df6f3d89f32239fbbd6dd47f5eec1a6 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH] [Clang] Introduce [[clang::coro_await_elidable]] --- clang/

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-08-22 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/104512 >From 8e11c66e4515bb35671853b89152b43d1ff60ffa Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Thu, 15 Aug 2024 14:03:57 -0700 Subject: [PATCH 1/5] [RFC][C++20][Modules] Fix crash when function and lambd

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-22 Thread Greg Roth via cfe-commits
@@ -363,9 +382,13 @@ static bool expandIntrinsic(Function &F, CallInst *Orig) { case Intrinsic::dx_normalize: Result = expandNormalizeIntrinsic(Orig); break; + case Intrinsic::dx_fdot: +Result = +expandFloatDotIntrinsic(Orig, Orig->getOperand(0), Orig->g

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-22 Thread Greg Roth via cfe-commits
@@ -1446,6 +1452,90 @@ bool SPIRVInstructionSelector::selectRsqrt(Register ResVReg, .constrainAllUses(TII, TRI, RBI); } +// Select the OpDot instruction for the given float dot +bool SPIRVInstructionSelector::selectFloatDot(Register ResVReg, +

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-08-22 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: @ChuanqiXu9 please take another look. I changed approach to remember which lambdas exist in FunctionDecl and load them for the first decl. I'm still testing it but interested to know does it look like something that address your concernes? https://github.com/llvm/llvm-proje

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-08-22 Thread Craig Topper via cfe-commits
@@ -2877,10 +2877,144 @@ void CodeGenFunction::EmitMultiVersionResolver( case llvm::Triple::aarch64: EmitAArch64MultiVersionResolver(Resolver, Options); return; + case llvm::Triple::riscv32: + case llvm::Triple::riscv64: +EmitRISCVMultiVersionResolver(Resolver,

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-08-22 Thread Craig Topper via cfe-commits
@@ -2877,10 +2877,144 @@ void CodeGenFunction::EmitMultiVersionResolver( case llvm::Triple::aarch64: EmitAArch64MultiVersionResolver(Resolver, Options); return; + case llvm::Triple::riscv32: + case llvm::Triple::riscv64: +EmitRISCVMultiVersionResolver(Resolver,

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-08-22 Thread Craig Topper via cfe-commits
@@ -63,9 +63,55 @@ class RISCVABIInfo : public DefaultABIInfo { CharUnits Field2Off) const; ABIArgInfo coerceVLSVector(QualType Ty) const; + + using ABIInfo::appendAttributeMangling; + void appendAttributeMangling(TargetClones

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-08-22 Thread Craig Topper via cfe-commits
@@ -63,9 +63,55 @@ class RISCVABIInfo : public DefaultABIInfo { CharUnits Field2Off) const; ABIArgInfo coerceVLSVector(QualType Ty) const; + + using ABIInfo::appendAttributeMangling; + void appendAttributeMangling(TargetClones

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-08-22 Thread Craig Topper via cfe-commits
@@ -2877,10 +2877,144 @@ void CodeGenFunction::EmitMultiVersionResolver( case llvm::Triple::aarch64: EmitAArch64MultiVersionResolver(Resolver, Options); return; + case llvm::Triple::riscv32: + case llvm::Triple::riscv64: +EmitRISCVMultiVersionResolver(Resolver,

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-08-22 Thread Craig Topper via cfe-commits
@@ -2877,10 +2877,144 @@ void CodeGenFunction::EmitMultiVersionResolver( case llvm::Triple::aarch64: EmitAArch64MultiVersionResolver(Resolver, Options); return; + case llvm::Triple::riscv32: + case llvm::Triple::riscv64: +EmitRISCVMultiVersionResolver(Resolver,

[clang] [clang][CodeGen] Zero init unspecified fields in initializers in C (PR #97121)

2024-08-22 Thread via cfe-commits
yabinc wrote: @rjmccall and @efriedma-quic, ping for review? https://github.com/llvm/llvm-project/pull/97121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-22 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,71 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// This test validates the diagnostics that are emitted when a variable with a "resource" type +// is bound to a register using the register annotation + +/* +tem

[clang] [llvm] [NVPTX] Support __usAtomicCAS builtin (PR #99646)

2024-08-22 Thread Artem Belevich via cfe-commits
Artem-B wrote: Buildkite failures are caused by lldb and are unrelated. We're good to go. https://github.com/llvm/llvm-project/pull/99646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang][bytecode] Reject void InitListExpr differently (PR #105697)

2024-08-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/105697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-22 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-22 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt created https://github.com/llvm/llvm-project/pull/105709 >From @vitalybuka's review on https://github.com/llvm/llvm-project/pull/104889: - [x] remove unused variable in tests - [x] rename `post-decr-while` --> `unsigned-post-decr-while` - [x] split `add-overflow-te

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-22 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Justin Stitt (JustinStitt) Changes >From @vitalybuka's review on >https://github.com/llvm/llvm-project/pull/104889: - [x] remove unused variable in tests - [x] rename `post-decr-while` --> `unsigned-post-decr-while` - [x] split `add

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Justin Stitt (JustinStitt) Changes >From @vitalybuka's review on >https://github.com/llvm/llvm-project/pull/104889: - [x] remove unused variable in tests - [x] rename `post-decr-while` --> `unsigned-post-decr-while` - [x] split `add-overfl

[clang] [flang] [llvm] [mlir] Make MMIWP not have ownership over MMI + Remove Move Constructor of MMI + Make MMI Only Use and Externally-Created MCContext (PR #105541)

2024-08-22 Thread Matt Arsenault via cfe-commits
arsenm wrote: > The TargetMachine interface functions addPassesToEmitFile and > addPassesToEmitMC now require a reference to an MMI; This IMO breaks the > abstraction of the TargetMachine, since an MMI requires a LLVMTargetMachine, > and if you have a TargetMachine you should do the dreaded ca

[clang] 319c7a4 - [HLSL][SPIRV]Add SPIRV generation for HLSL dot (#104656)

2024-08-22 Thread via cfe-commits
Author: Greg Roth Date: 2024-08-22T11:13:52-07:00 New Revision: 319c7a42ba2e5be56757d622747ba317d3b9e9ad URL: https://github.com/llvm/llvm-project/commit/319c7a42ba2e5be56757d622747ba317d3b9e9ad DIFF: https://github.com/llvm/llvm-project/commit/319c7a42ba2e5be56757d622747ba317d3b9e9ad.diff LOG

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-22 Thread Greg Roth via cfe-commits
https://github.com/pow2clk closed https://github.com/llvm/llvm-project/pull/104656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-22 Thread Greg Roth via cfe-commits
@@ -1,161 +1,172 @@ // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ // RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: --check-prefixes=CHECK,NATIVE_HALF +// RUN: --check-pr

[clang] [Clang] Add wraps attribute (for granular integer overflow handling) (PR #86618)

2024-08-22 Thread Justin Stitt via cfe-commits
JustinStitt wrote: > Regarding there not being a `no-wraps` attribute. What happens with code like > this? Is the attribute lost / casted away during the addition? > > ``` > wrapping_int a = INT_MAX; > a = (int) a + 1; > ``` Good question, the attribute is cast away (intentionally so). Additio

[clang] [Clang] correct error message when assigning to const reference captured in lambda (PR #105647)

2024-08-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: I think this PR moves things in the right direction, but it would be nice to make notes more helpful. https://github.com/llvm/llvm-project/pull/105647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [Clang] correct error message when assigning to const reference captured in lambda (PR #105647)

2024-08-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/105647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] correct error message when assigning to const reference captured in lambda (PR #105647)

2024-08-22 Thread Vlad Serebrennikov via cfe-commits
@@ -189,6 +189,11 @@ namespace ModifyingCapture { [=] { n = 1; // expected-error {{cannot assign to a variable captured by copy in a non-mutable lambda}} }; +const int cn = 0; +// cxx03-cxx11-warning@+1 {{initialized lambda captures are a C++14 extension

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-22 Thread Helena Kotas via cfe-commits
@@ -1547,6 +1547,9 @@ def DXILValidation : DiagGroup<"dxil-validation">; // Warning for HLSL API availability def HLSLAvailability : DiagGroup<"hlsl-availability">; +// Warnings for legacy binding behavior +def DisallowLegacyBindingRules : DiagGroup<"disallow-legacy-binding-ru

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-22 Thread Helena Kotas via cfe-commits
@@ -12342,7 +12342,13 @@ def err_hlsl_missing_semantic_annotation : Error< def err_hlsl_init_priority_unsupported : Error< "initializer priorities are not supported in HLSL">; -def err_hlsl_unsupported_register_type : Error<"invalid resource class specifier '%0' used; expec

[clang] [clang] Increase the default expression nesting limit (PR #104717)

2024-08-22 Thread via cfe-commits
dyung wrote: Ping, can we maybe get the test `Parser/parser_overflow.c` disabled for ASan/UBSan configurations? https://github.com/llvm/llvm-project/pull/104717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [Clang] Add wraps attribute (for granular integer overflow handling) (PR #86618)

2024-08-22 Thread Justin Stitt via cfe-commits
JustinStitt wrote: > I’m a little concerned about not allowing the attribute in C++ - the > existence of other options in C++ does not mean they are an option (due to > various and sundry restrictions of C++ version upgrades different projects > have), but also you trivially end up in cases wh

[clang] [llvm] [AsmWriter] Print `nan`, `pinf`, and `ninf` when applicable (PR #105618)

2024-08-22 Thread Joshua Cranmer via cfe-commits
@@ -4387,12 +4387,12 @@ Simple Constants zeros. So '``s0x0001``' of type '``i16``' will be -1, not 1. **Floating-point constants** Floating-point constants use standard decimal notation (e.g. -123.421), exponential notation (e.g. 1.23421e+2), or a more precise -

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-22 Thread Joshua Batista via cfe-commits
@@ -1547,6 +1547,9 @@ def DXILValidation : DiagGroup<"dxil-validation">; // Warning for HLSL API availability def HLSLAvailability : DiagGroup<"hlsl-availability">; +// Warnings for legacy binding behavior +def DisallowLegacyBindingRules : DiagGroup<"disallow-legacy-binding-ru

[clang] Match edit refactoring rule (PR #105717)

2024-08-22 Thread Сергеев Игнатий via cfe-commits
https://github.com/IgnatSergeev created https://github.com/llvm/llvm-project/pull/105717 None From d631dae8cf543b8d02b7d2702d69b143a2874cd7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=98=D0=B3=D0=BD=D0=B0=D1=82=20=D0=A1=D0=B5=D1=80=D0=B3?= =?UTF-8?q?=D0=B5=D0=B5=D0=B2?= Date: Mon, 27 May 202

[clang] Match edit refactoring rule (PR #105717)

2024-08-22 Thread via cfe-commits
=?utf-8?b?0JjQs9C90LDRgiDQodC10YDQsw=?=, =?utf-8?b?0JjQs9C90LDRgiDQodC10YDQsw=?Message-ID: In-Reply-To: github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to,

[clang] Match edit refactoring rule (PR #105717)

2024-08-22 Thread Сергеев Игнатий via cfe-commits
https://github.com/IgnatSergeev closed https://github.com/llvm/llvm-project/pull/105717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Match edit refactoring rule (PR #105717)

2024-08-22 Thread via cfe-commits
___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Change BinPackParameters to enum and add AlwaysOnePerLine (PR #101882)

2024-08-22 Thread via cfe-commits
https://github.com/VolatileAcorn updated https://github.com/llvm/llvm-project/pull/101882 >From ddb5bad1cd1bed8781b9156e1058a9cc1347 Mon Sep 17 00:00:00 2001 From: Tom Pottage Date: Fri, 2 Aug 2024 20:26:47 +0100 Subject: [PATCH 1/5] [clang-format] Change BinPackParameters to an enum and i

[clang] [C23] Update status page for TS 18661 integration (PR #105693)

2024-08-22 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel edited https://github.com/llvm/llvm-project/pull/105693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Update status page for TS 18661 integration (PR #105693)

2024-08-22 Thread Joshua Cranmer via cfe-commits
@@ -216,35 +216,31 @@ C23 implementation status https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2341.pdf";>N2341 -Unknown - - -https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2401.pdf";>N2401 -Unknown +No

[clang] [C23] Update status page for TS 18661 integration (PR #105693)

2024-08-22 Thread Joshua Cranmer via cfe-commits
@@ -216,35 +216,31 @@ C23 implementation status https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2341.pdf";>N2341 -Unknown - - -https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2401.pdf";>N2401 -Unknown +No

[clang] [C23] Update status page for TS 18661 integration (PR #105693)

2024-08-22 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel commented: It might be better to list most of these as "N/A" rather than "No", for the simple reason that decimal floating point is an optional feature we do not support. Or maybe just a footnote saying something to that effect? https://github.com/llvm/llvm-pr

[clang] [Matrix] Preserve signedness when extending matrix index expression. (PR #103044)

2024-08-22 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/103044 >From 3fc96327079c04e9bcac9488d0ee03e61bb5a3fb Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Tue, 13 Aug 2024 12:28:34 +0100 Subject: [PATCH 1/3] [Matrix] Preserve signedness when extending matrix index expre

[clang] [clang] Emit nuw GEPs for array subscript expressions (PR #103088)

2024-08-22 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Oh, I see. If you can prove that it would be illegal to use a negative index with a particular pointer, you might be able to optimize... but I'm not sure how aggressive we want to be here. Even if the C standard technically disallows indexing past the beginning/end of a

[clang-tools-extra] [clang-tidy][run-clang-tidy] Fix minor shutdown noise (PR #105724)

2024-08-22 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank created https://github.com/llvm/llvm-project/pull/105724 On my new machine, the script outputs some shutdown noise: ``` Ctrl-C detected, goodbye. Traceback (most recent call last): File "/home/nvankempen/llvm-project/./clang-tools-extra/clang-tidy/tool/run-clang-ti

[clang-tools-extra] [clang-tidy][run-clang-tidy] Fix minor shutdown noise (PR #105724)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Nicolas van Kempen (nicovank) Changes On my new machine, the script outputs some shutdown noise: ``` Ctrl-C detected, goodbye. Traceback (most recent call last): File "/home/nvankempen/llvm-pro

[libunwind] [libunwind] Stop installing the mach-o module map (PR #105616)

2024-08-22 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/105616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Create IFUNCs in the program address space, not hard-coded 0 (PR #105726)

2024-08-22 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 created https://github.com/llvm/llvm-project/pull/105726 Commit 0d527e56a5ee ("GlobalIFunc: Make ifunc respect function address spaces") added support for this within LLVM, but Clang does not properly honour the target's address spaces when creating IFUNCs, crashing wit

[clang] [CodeGen] Create IFUNCs in the program address space, not hard-coded 0 (PR #105726)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jessica Clarke (jrtc27) Changes Commit 0d527e56a5ee ("GlobalIFunc: Make ifunc respect function address spaces") added support for this within LLVM, but Clang does not properly honour the target's address spaces when creating IFUNCs,

[clang] [CodeGen] Create IFUNCs in the program address space, not hard-coded 0 (PR #105726)

2024-08-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2c12c1e755a1bf453b246027b450b3b8e30fb016 4be2b44f7e400b417e228766169b15f1a20d4602 --e

[clang] [Clang] prevent assertion failure when converting vectors to int/float with invalid expressions (PR #105727)

2024-08-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/105727 Fixes #105486 >From d8bed3f4db8056a6afa9bd7eae5d4a8361f83086 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Thu, 22 Aug 2024 23:25:31 +0300 Subject: [PATCH] [Clang] prevent assertion failure when convertin

[clang] [Clang] prevent assertion failure when converting vectors to int/float with invalid expressions (PR #105727)

2024-08-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #105486 --- Full diff: https://github.com/llvm/llvm-project/pull/105727.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/lib/Sema/SemaExpr.cpp (+6) - (modi

[clang] [CodeGen] Create IFUNCs in the program address space, not hard-coded 0 (PR #105726)

2024-08-22 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 updated https://github.com/llvm/llvm-project/pull/105726 >From cfce8b0d99a088a6a2fb12661a7158786f630802 Mon Sep 17 00:00:00 2001 From: Jessica Clarke Date: Thu, 22 Aug 2024 21:20:23 +0100 Subject: [PATCH] [CodeGen] Create IFUNCs in the program address space, not hard-

[clang] [Clang] correct error message when assigning to const reference captured in lambda (PR #105647)

2024-08-22 Thread via cfe-commits
@@ -189,6 +189,11 @@ namespace ModifyingCapture { [=] { n = 1; // expected-error {{cannot assign to a variable captured by copy in a non-mutable lambda}} }; +const int cn = 0; +// cxx03-cxx11-warning@+1 {{initialized lambda captures are a C++14 extension

[clang] [Clang] correct error message when assigning to const reference captured in lambda (PR #105647)

2024-08-22 Thread via cfe-commits
https://github.com/nfrmtk edited https://github.com/llvm/llvm-project/pull/105647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] correct error message when assigning to const reference captured in lambda (PR #105647)

2024-08-22 Thread via cfe-commits
https://github.com/nfrmtk edited https://github.com/llvm/llvm-project/pull/105647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 172c4a4 - [libunwind] Stop installing the mach-o module map (#105616)

2024-08-22 Thread via cfe-commits
Author: Ian Anderson Date: 2024-08-22T13:44:58-07:00 New Revision: 172c4a4a147833f1c08df1555f3170aa9ccb6cbe URL: https://github.com/llvm/llvm-project/commit/172c4a4a147833f1c08df1555f3170aa9ccb6cbe DIFF: https://github.com/llvm/llvm-project/commit/172c4a4a147833f1c08df1555f3170aa9ccb6cbe.diff

[libunwind] [libunwind] Stop installing the mach-o module map (PR #105616)

2024-08-22 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/105616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] correct error message when assigning to const reference captured in lambda (PR #105647)

2024-08-22 Thread Vlad Serebrennikov via cfe-commits
@@ -189,6 +189,11 @@ namespace ModifyingCapture { [=] { n = 1; // expected-error {{cannot assign to a variable captured by copy in a non-mutable lambda}} }; +const int cn = 0; +// cxx03-cxx11-warning@+1 {{initialized lambda captures are a C++14 extension

<    1   2   3   4   >