arsenm wrote: > The TargetMachine interface functions addPassesToEmitFile and > addPassesToEmitMC now require a reference to an MMI; This IMO breaks the > abstraction of the TargetMachine, since an MMI requires a LLVMTargetMachine, > and if you have a TargetMachine you should do the dreaded casting to > LLVMTargetMachine in order to create it. Now I created a factory method for > MMIs in the TargetMachine interface to remedy this issue, but I still don't > like it since again, it is only implemented for LLVMTargetMachine.
I don't quite follow what the issue is here, but I'm off until Tuesday so I'll look again next week (I hope) https://github.com/llvm/llvm-project/pull/105541 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
