[clang] [clang-format] Add BreakBinaryOperations configuration (PR #95013)

2024-08-10 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: Nah, I can't find a better name, which isn't a whole sentence. https://github.com/llvm/llvm-project/pull/95013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9a227ba - [clang][Interp] Start implementing unions and changing the active member (#102723)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T09:09:12+02:00 New Revision: 9a227ba3e129eaa89498b97421afefb1e9d681df URL: https://github.com/llvm/llvm-project/commit/9a227ba3e129eaa89498b97421afefb1e9d681df DIFF: https://github.com/llvm/llvm-project/commit/9a227ba3e129eaa89498b97421afefb1e9d681df.diff L

[clang] [clang][Interp] Start implementing unions and changing the active member (PR #102723)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86_64] Fix empty field error in vaarg of C++. (PR #101639)

2024-08-10 Thread Longsheng Mou via cfe-commits
https://github.com/CoTinker updated https://github.com/llvm/llvm-project/pull/101639 >From 328ae6052894eb45c4e7541dadf63a3a04540cda Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 2 Aug 2024 16:36:31 +0800 Subject: [PATCH 1/2] [X86_64] Fix empty field error in vaarg of C++. Such struct

[clang] Improve instructions in Clang Format Vim Integration Document (PR #102730)

2024-08-10 Thread via cfe-commits
https://github.com/cuppajoeman created https://github.com/llvm/llvm-project/pull/102730 added a link to where you can download the file. >From b42951aac97b2660bcadb1028e623f9e70981cde Mon Sep 17 00:00:00 2001 From: cuppajoeman Date: Sat, 10 Aug 2024 03:25:15 -0400 Subject: [PATCH] update to sh

[clang] Improve instructions in Clang Format Vim Integration Document (PR #102730)

2024-08-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Improve instructions in Clang Format Vim Integration Document (PR #102730)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: ccn (cuppajoeman) Changes added a link to where you can download the file. --- Full diff: https://github.com/llvm/llvm-project/pull/102730.diff 1 Files Affected: - (modified) clang/docs/ClangFormat.rst (+2-1) ``diff diff --gi

[clang] [clang][Interp] Start implementing unions and changing the active member (PR #102723)

2024-08-10 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-windows` running on `sanitizer-windows` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/107/builds/1721 Here is the relevant piece of the build lo

[clang] [Clang][Concepts] Fix a constraint comparison regression for out-of-line ClassTemplateDecls (PR #102587)

2024-08-10 Thread Younan Zhang via cfe-commits
@@ -599,3 +599,39 @@ template unsigned long DerivedCollection::index() {} } // namespace GH72557 + +namespace GH102320 { + +template +concept Constrained = true; + +template class C { + template > class D; + template +requires Constrained + class E; +}; + +template

[clang] [llvm] Add normalize builtins and normalize HLSL function to DirectX and SPIR-V backend (PR #102683)

2024-08-10 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/102683 >From 547b4da91b20811db156a8c73fcb2f381cfed7bd Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 9 Aug 2024 10:48:10 -0700 Subject: [PATCH 1/8] suboptimal expansion of normalize done --- clang/include/

[clang] [Clang][CodeGen] Fix bad codegen when building Clang with latest MSVC (PR #102681)

2024-08-10 Thread David Chisnall via cfe-commits
davidchisnall wrote: The new version is probably slightly more readable than mine, but I don’t really understand how it would affect codegen with UT C. No objections. https://github.com/llvm/llvm-project/pull/102681 ___ cfe-commits mailing list cfe-co

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-10 Thread Nikita Popov via cfe-commits
nikic wrote: Build fails with: ``` CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/tmp/llvm-project-build-stage1/lib/Support -I/var/llvm-compile-time-tracker/llvm-project

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-10 Thread Mehdi Amini via cfe-commits
joker-eph wrote: Hi, thanks for trying to cleanup the codebase. Can you provide more context on the motivation / what you're trying to achieve here? Did you know that LLVM intentionally does not follow IWYU and favors forward declarations: https://llvm.org/docs/CodingStandards.html#include-

[clang] [Clang][Concepts] Fix a constraint comparison regression for out-of-line ClassTemplateDecls (PR #102587)

2024-08-10 Thread via cfe-commits
@@ -599,3 +599,39 @@ template unsigned long DerivedCollection::index() {} } // namespace GH72557 + +namespace GH102320 { + +template +concept Constrained = true; + +template class C { + template > class D; + template +requires Constrained + class E; +}; + +template

[clang] Improve instructions in Clang Format Vim Integration Document (PR #102730)

2024-08-10 Thread via cfe-commits
https://github.com/cuppajoeman updated https://github.com/llvm/llvm-project/pull/102730 >From b42951aac97b2660bcadb1028e623f9e70981cde Mon Sep 17 00:00:00 2001 From: cuppajoeman Date: Sat, 10 Aug 2024 03:25:15 -0400 Subject: [PATCH 1/2] update to show where you can actually get the mentioned f

[clang] [clang][Interp] Improve "in call to" call argument printing (PR #102735)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/102735 Always go through toAPValue() first and pretty-print that. In the future, I think we could get rid of the individual toDiagnosticString() implementations. This way we also get the correct printing for floats.

[clang] [clang][Interp] Improve "in call to" call argument printing (PR #102735)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Always go through toAPValue() first and pretty-print that. In the future, I think we could get rid of the individual toDiagnosticString() implementations. This way we also get the correct printing for floats

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-08-10 Thread via cfe-commits
https://github.com/skc7 updated https://github.com/llvm/llvm-project/pull/99439 >From b7c0520ab9ea9d00fe5008717d2af04d494942eb Mon Sep 17 00:00:00 2001 From: skc7 Date: Thu, 18 Jul 2024 11:49:24 +0530 Subject: [PATCH] [Sanitizer] Make sanitizer passes idempotent. --- clang/test/CodeGenObjC/no-

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-08-10 Thread via cfe-commits
@@ -12,12 +12,47 @@ //===--===// #include "llvm/Transforms/Instrumentation.h" +#include "llvm/IR/DiagnosticInfo.h" +#include "llvm/IR/DiagnosticPrinter.h" #include "llvm/IR/IntrinsicInst.h" #include "llvm/I

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-08-10 Thread via cfe-commits
https://github.com/skc7 edited https://github.com/llvm/llvm-project/pull/99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-10 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/96301 >From 1a25f021b797e5591f1ae324c8a8b5244047d5f4 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Fri, 21 Jun 2024 18:26:36 +0530 Subject: [PATCH] [clang] Allow class with anonymous union member to be const-default

[clang] 979abf1 - [clang][Interp] Improve "in call to" call argument printing (#102735)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T11:40:04+02:00 New Revision: 979abf142f606bf43a5500e59d72f1286a7180c7 URL: https://github.com/llvm/llvm-project/commit/979abf142f606bf43a5500e59d72f1286a7180c7 DIFF: https://github.com/llvm/llvm-project/commit/979abf142f606bf43a5500e59d72f1286a7180c7.diff L

[clang] [clang][Interp] Improve "in call to" call argument printing (PR #102735)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-08-10 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/99473 >From d6903daf0da6979822b8981ea3641455ff6d06f8 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 16 Jul 2024 14:48:10 +0200 Subject: [PATCH 1/6] [Clang] Add __common_type builtin --- clang/include/cl

[clang] [Clang] Add [[clang::diagnose_specializations]] (PR #101469)

2024-08-10 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/101469 >From 82ab798fc72c6de64ae527d96393f0dc67307e98 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Thu, 1 Aug 2024 12:30:22 +0200 Subject: [PATCH 1/5] [Clang] Add [[clang::diagnose_specializations]] --- cl

[clang] [Driver] Have getTargetSubDirPath better match get_compiler_rt_target (PR #100091)

2024-08-10 Thread Tobias Hieta via cfe-commits
tru wrote: Do we still need to fix this for 19.1.0-final? https://github.com/llvm/llvm-project/pull/100091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Do not call dtors of union members (PR #102739)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/102739 None >From f4ccc8a5d705bcc0eb6a573f24b0bc3e80aa7b5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 10 Aug 2024 11:21:25 +0200 Subject: [PATCH] [clang][Interp] Do not call dtors of unio

[clang] [Clang] Add [[clang::diagnose_specializations]] (PR #101469)

2024-08-10 Thread Mital Ashok via cfe-commits
@@ -5408,7 +5408,10 @@ def note_dependent_function_template_spec_discard_reason : Note< "not a member of the enclosing %select{class template|" "namespace; did you mean to explicitly qualify the specialization?}1}0">; def warn_invalid_specialization : Warning< - "%0 shoul

[clang] #101784 part 2: fix error handling of TranslationUnit.reparse (PR #102410)

2024-08-10 Thread via cfe-commits
https://github.com/TsXor updated https://github.com/llvm/llvm-project/pull/102410 >From 4858eef099dbca66b2e3d36fc17aef574c1f3d58 Mon Sep 17 00:00:00 2001 From: TsXor Date: Thu, 8 Aug 2024 09:25:52 +0800 Subject: [PATCH 1/2] fix error handling of TranslationUnit.reparse --- clang/bindings/pyth

[clang] #101784 part 2: fix error handling of TranslationUnit.reparse (PR #102410)

2024-08-10 Thread via cfe-commits
https://github.com/TsXor edited https://github.com/llvm/llvm-project/pull/102410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] #101784 part 2: fix error handling of TranslationUnit.reparse (PR #102410)

2024-08-10 Thread via cfe-commits
https://github.com/TsXor commented: `CXError` is merged into `TranslationUnitLoadError`, and error code is preserved in another commit. https://github.com/llvm/llvm-project/pull/102410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] #101784 part 2: fix error handling of TranslationUnit.reparse (PR #102410)

2024-08-10 Thread via cfe-commits
@@ -152,6 +152,41 @@ def b(x: str | bytes) -> bytes: ### Exception Classes ### +class CXError(Exception): TsXor wrote: I looked at C header and found that `clang_parseTranslationUnit` and `clang_createTranslationUnit` actually swallows error code. To be uni

[clang] #101784 part 2: fix error handling of TranslationUnit.reparse (PR #102410)

2024-08-10 Thread via cfe-commits
https://github.com/TsXor updated https://github.com/llvm/llvm-project/pull/102410 >From 4858eef099dbca66b2e3d36fc17aef574c1f3d58 Mon Sep 17 00:00:00 2001 From: TsXor Date: Thu, 8 Aug 2024 09:25:52 +0800 Subject: [PATCH 1/2] fix error handling of TranslationUnit.reparse --- clang/bindings/pyth

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-10 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/96301 >From 7efe2bd186cb0a97b8f8b66b9c69da92c79fc60a Mon Sep 17 00:00:00 2001 From: Rajveer Date: Fri, 21 Jun 2024 18:26:36 +0530 Subject: [PATCH] [clang] Allow class with anonymous union member to be const-default

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-10 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: @zygoloid Could you review this? https://github.com/llvm/llvm-project/pull/96301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 86691f8 - [clang][Interp] Do not call dtors of union members (#102739)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T13:45:30+02:00 New Revision: 86691f8d7e86176db7409ccafb7a79964221720a URL: https://github.com/llvm/llvm-project/commit/86691f8d7e86176db7409ccafb7a79964221720a DIFF: https://github.com/llvm/llvm-project/commit/86691f8d7e86176db7409ccafb7a79964221720a.diff L

[clang] [clang][Interp] Do not call dtors of union members (PR #102739)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle nested unions (PR #102743)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/102743 None >From 8d950c9e1a98bc5dd7134b6bd476cca96916c621 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 10 Aug 2024 12:47:38 +0200 Subject: [PATCH] [clang][Interp] Handle nested unions ---

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-08-10 Thread Pavel Skripkin via cfe-commits
@@ -50,6 +101,44 @@ class BuiltinFunctionChecker : public Checker { } // namespace +void BuiltinFunctionChecker::HandleOverflowBuiltin(const CallEvent &Call, + CheckerContext &C, +

[clang] [clang][Interp] Do not call dtors of union members (PR #102739)

2024-08-10 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clangd-ubuntu-tsan` running on `clangd-ubuntu-clang` while building `clang` at step 5 "build-clangd-clangd-index-server-clangd-indexer". Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/3229

[clang] 3b57f6b - [clang][Interp] Handle nested unions (#102743)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T14:16:47+02:00 New Revision: 3b57f6b4c76d9b54b1c42591fdddf0ddc86dc964 URL: https://github.com/llvm/llvm-project/commit/3b57f6b4c76d9b54b1c42591fdddf0ddc86dc964 DIFF: https://github.com/llvm/llvm-project/commit/3b57f6b4c76d9b54b1c42591fdddf0ddc86dc964.diff L

[clang] [clang][Interp] Handle nested unions (PR #102743)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Don't zero-init unions (PR #102744)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/102744 Zero-initializing them would accidentally activate the members. >From b0697976fe655ad9c08e95bc7095d28cda16dfda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 10 Aug 2024 13:48:47 +0200

[clang] [clang][Interp] Do not call dtors of union members (PR #102739)

2024-08-10 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/2700 Here is the relevant piece of the bu

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-10 Thread Vlad Serebrennikov via cfe-commits
@@ -386,6 +386,10 @@ def __contains__(self, other): # same file, in between lines if self.start.line < other.line < self.end.line: return True +# between columns in one-liner range +elif self.start.line == other.line == self.end.line:

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-10 Thread Vlad Serebrennikov via cfe-commits
@@ -386,6 +386,10 @@ def __contains__(self, other): # same file, in between lines if self.start.line < other.line < self.end.line: return True +# between columns in one-liner range +elif self.start.line == other.line == self.end.line:

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/101802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Don't zero-init unions (PR #102744)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/102744 >From 40e78a52c9cbbce88f8a5609eccb20d4aa16ce5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 10 Aug 2024 13:48:47 +0200 Subject: [PATCH] [clang][Interp] Only zero-init first union memb

[clang] [clang][Interp] Only zero-init first union member (PR #102744)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/102744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Only zero-init first union member (PR #102744)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/102744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-10 Thread Jannick Kremer via cfe-commits
@@ -386,6 +386,10 @@ def __contains__(self, other): # same file, in between lines if self.start.line < other.line < self.end.line: return True +# between columns in one-liner range +elif self.start.line == other.line == self.end.line:

[clang] [Clang][Sema][OpenMP] Allow `thread_limit` to accept multiple expressions (PR #102715)

2024-08-10 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/102715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-10 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev commented: A test is required https://github.com/llvm/llvm-project/pull/102716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTDump] TextNodeDumper learned to dump builtin name for AtomicExpr (PR #102748)

2024-08-10 Thread via cfe-commits
https://github.com/Enna1 created https://github.com/llvm/llvm-project/pull/102748 In 4198576157bfd0d08c08b784220d6132b709ae2c, we add support for dumping builtin name for AtomicExpr in JSON dump. This change syncs `TextNodeDumper` with `JSONNodeDumper`, makes `TextNodeDumper` learned to dump b

[clang] ac47edd - [clang][Interp] Only zero-init first union member (#102744)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T15:25:08+02:00 New Revision: ac47edd8a9dadc15aa7b6557e3ac03512aa1cf6f URL: https://github.com/llvm/llvm-project/commit/ac47edd8a9dadc15aa7b6557e3ac03512aa1cf6f DIFF: https://github.com/llvm/llvm-project/commit/ac47edd8a9dadc15aa7b6557e3ac03512aa1cf6f.diff L

[clang] [clang][Interp] Only zero-init first union member (PR #102744)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Ignore unnamed bitfields when zeroing records (PR #102749)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/102749 Including unions, where this is more important. >From e2a9a796b2beb2dcee0f8ec974cc548427091af4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 10 Aug 2024 15:19:55 +0200 Subject: [PATCH

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-10 Thread Vlad Serebrennikov via cfe-commits
@@ -386,6 +386,10 @@ def __contains__(self, other): # same file, in between lines if self.start.line < other.line < self.end.line: return True +# between columns in one-liner range +elif self.start.line == other.line == self.end.line:

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-10 Thread Shilei Tian via cfe-commits
shiltian wrote: > A test is required I literally don't know how to test this TBH. I think our current OpenMP tests generally don't cover this at all. https://github.com/llvm/llvm-project/pull/102716 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] 1c26992 - [Clang][Sema][OpenMP] Allow `thread_limit` to accept multiple expressions (#102715)

2024-08-10 Thread via cfe-commits
Author: Shilei Tian Date: 2024-08-10T09:54:58-04:00 New Revision: 1c269929d03e4a664a1f05d494b8fefe291ef8c0 URL: https://github.com/llvm/llvm-project/commit/1c269929d03e4a664a1f05d494b8fefe291ef8c0 DIFF: https://github.com/llvm/llvm-project/commit/1c269929d03e4a664a1f05d494b8fefe291ef8c0.diff L

[clang] [Clang][Sema][OpenMP] Allow `thread_limit` to accept multiple expressions (PR #102715)

2024-08-10 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/102715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OMPX] Add the code generation for multi-dim `thread_limit` clause (PR #102717)

2024-08-10 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/102717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8d908b8 - [clang][Interp] Ignore unnamed bitfields when zeroing records (#102749)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T15:56:19+02:00 New Revision: 8d908b8cc5f4b3aeb2303437a9c2d35654279fd9 URL: https://github.com/llvm/llvm-project/commit/8d908b8cc5f4b3aeb2303437a9c2d35654279fd9 DIFF: https://github.com/llvm/llvm-project/commit/8d908b8cc5f4b3aeb2303437a9c2d35654279fd9.diff L

[clang] [clang][Interp] Ignore unnamed bitfields when zeroing records (PR #102749)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix activating via indirect field initializers (PR #102753)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/102753 Pointer::activate() propagates up anyway, so that is handled. But we need to call activate() in any case since the parent might not be a union, but the activate() is still needed. Always call it and hope that

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-10 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > > A test is required > > > > I literally don't know how to test this TBH. I think our current OpenMP tests > generally don't cover this at all. They do. To test this, you need to use clause in the template and check that template params successfully replaced upon inst

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-10 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/101802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPARC][clang] Add -m(no-)v8plus flags handling (PR #98713)

2024-08-10 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov approved this pull request. https://github.com/llvm/llvm-project/pull/98713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPARC][Driver] Add -m(no-)v8plus flags handling (PR #98713)

2024-08-10 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov edited https://github.com/llvm/llvm-project/pull/98713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9d6cec5 - [clang][Interp] Fix activating via indirect field initializers (#102753)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T16:32:15+02:00 New Revision: 9d6cec5f349d4e26ac8610565dbbe4678a965278 URL: https://github.com/llvm/llvm-project/commit/9d6cec5f349d4e26ac8610565dbbe4678a965278 DIFF: https://github.com/llvm/llvm-project/commit/9d6cec5f349d4e26ac8610565dbbe4678a965278.diff L

[clang] [clang][Interp] Fix activating via indirect field initializers (PR #102753)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Do not call dtors of union members (PR #102739)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/102739.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/Compiler.cpp (+12-13) - (modified) clang/test/AST/Interp/unions.cpp (+46) `

[clang] [clang][Interp] Handle nested unions (PR #102743)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/102743.diff 3 Files Affected: - (modified) clang/lib/AST/Interp/Interp.cpp (+14-12) - (modified) clang/lib/AST/Interp/Pointer.cpp (+1-1) - (modif

[clang] [clang][Interp] Only zero-init first union member (PR #102744)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Zero-initializing all of them accidentally left the last member active. Only initialize the first one. --- Full diff: https://github.com/llvm/llvm-project/pull/102744.diff 3 Files Affected: - (modified) c

[clang] [ASTDump] TextNodeDumper learned to dump builtin name for AtomicExpr (PR #102748)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Enna1 (Enna1) Changes In 4198576157bfd0d08c08b784220d6132b709ae2c, we add support for dumping builtin name for AtomicExpr in JSON dump. This change syncs `TextNodeDumper` with `JSONNodeDumper`, makes `TextNodeDumper` learned to dump built

[clang] [clang][Interp] Ignore unnamed bitfields when zeroing records (PR #102749)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Including unions, where this is more important. --- Full diff: https://github.com/llvm/llvm-project/pull/102749.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/Compiler.cpp (+3) - (modified) clan

[clang] [clang][Interp] Fix activating via indirect field initializers (PR #102753)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Pointer::activate() propagates up anyway, so that is handled. But we need to call activate() in any case since the parent might not be a union, but the activate() is still needed. Always call it and hope tha

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-10 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/102757 Currently the constexpr vectors lit test depend on CHECK to compare the vector values and IR, but after vector element access feature is implemented. This patch rewrite all tests in constexpr vectors to de

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Currently the constexpr vectors lit test depend on CHECK to compare the vector values and IR, but after vector element access feature is implemented. This patch rewrite all tests in constexpr vectors to d

[clang] ac83582 - [Serialization] Fix a warning

2024-08-10 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-08-10T09:21:02-07:00 New Revision: ac83582a2e7301f7088d14a4c352438e9f62bcf0 URL: https://github.com/llvm/llvm-project/commit/ac83582a2e7301f7088d14a4c352438e9f62bcf0 DIFF: https://github.com/llvm/llvm-project/commit/ac83582a2e7301f7088d14a4c352438e9f62bcf0.diff L

[clang] [Clang][Sema][OpenMP] Allow `thread_limit` to accept multiple expressions (PR #102715)

2024-08-10 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: I've fixed a warning with ac83582a2e7301f7088d14a4c352438e9f62bcf0. We should probably use `for (unsigned I = 0; I != NumVars; ++I)` because the use of `_` requires `(void)_;` and curly braces (or `[[maybe_unused]]`). Will post a patch shortly. https://github.com/llvm

[clang-tools-extra] [clang-tidy] Fix modernize-use-std-format lit test signature (PR #102759)

2024-08-10 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe created https://github.com/llvm/llvm-project/pull/102759 My fix for my original fix of issue #92896 in 666d224248707f373577b5b049b5b022916c modified the function signature for fmt::sprintf to more accurately match the real implementation in libfmt but failed to

[clang-tools-extra] [clang-tidy] Fix modernize-use-std-format lit test signature (PR #102759)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Mike Crowe (mikecrowe) Changes My fix for my original fix of issue #92896 in 666d224248707f373577b5b049b5b022916c modified the function signature for fmt::sprintf to more accurately match the

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-10 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan updated https://github.com/llvm/llvm-project/pull/102078 >From 193e704ea21251ea639bfb733671b4047c93c4ea Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Sun, 4 Aug 2024 19:15:20 -0400 Subject: [PATCH 1/3] [clang-format] Adjust requires clause wrapping (#101550) A

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-10 Thread Nathan Sidwell via cfe-commits
@@ -5682,12 +5683,15 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, (Style.BreakTemplateDeclarations == FormatStyle::BTDS_Leave && Right.NewlinesBefore > 0); } - if (Left.ClosesRequiresClause && Right.isNot(tok::semi) && - Rig

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-10 Thread Nathan Sidwell via cfe-commits
urnathan wrote: Thanks for the comments, I think this addresses them https://github.com/llvm/llvm-project/pull/102078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Use traditional for loops (NFC) (PR #102761)

2024-08-10 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/102761 The use of _ requires either: - (void)_ and curly braces, or - [[maybe_unused]]. For simple repetitions like these, we can use traditional for loops for readable warning-free code. >From 68c22e9e8010c6

[clang] [Serialization] Use traditional for loops (NFC) (PR #102761)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Kazu Hirata (kazutakahirata) Changes The use of _ requires either: - (void)_ and curly braces, or - [[maybe_unused]]. For simple repetitions like these, we can use traditional for loops for readable warning-free code. --- Full d

[clang] [clang][Interp] Handle union copy/move ctors (PR #102762)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/102762 They don't have a body and we need to implement them ourselves. Use the Memcpy op to do that. >From 7c0b32dd559dd5a42ae72d8546c179565be6afc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date:

[clang] [clang][Interp] Handle union copy/move ctors (PR #102762)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes They don't have a body and we need to implement them ourselves. Use the Memcpy op to do that. --- Full diff: https://github.com/llvm/llvm-project/pull/102762.diff 3 Files Affected: - (modified) clang/lib/

[clang] [Serialization] Use traditional for loops (NFC) (PR #102761)

2024-08-10 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/102761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Use traditional for loops (NFC) (PR #102761)

2024-08-10 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/102761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4ce2f98 - [Serialization] Use traditional for loops (NFC) (#102761)

2024-08-10 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-08-10T10:49:39-07:00 New Revision: 4ce2f988b28445dadd067e6990aa6fb3db81a184 URL: https://github.com/llvm/llvm-project/commit/4ce2f988b28445dadd067e6990aa6fb3db81a184 DIFF: https://github.com/llvm/llvm-project/commit/4ce2f988b28445dadd067e6990aa6fb3db81a184.diff L

[clang] 496b224 - [clang][Interp] Handle union copy/move ctors (#102762)

2024-08-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-10T19:54:07+02:00 New Revision: 496b224dc2fabe7c9f72e02fb5096f2b0fdd9e9b URL: https://github.com/llvm/llvm-project/commit/496b224dc2fabe7c9f72e02fb5096f2b0fdd9e9b DIFF: https://github.com/llvm/llvm-project/commit/496b224dc2fabe7c9f72e02fb5096f2b0fdd9e9b.diff L

[clang] [Clang][CodeGen] Fix bad codegen when building Clang with latest MSVC (PR #102681)

2024-08-10 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/102681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle union copy/move ctors (PR #102762)

2024-08-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix modernize-use-std-format lit test signature (PR #102759)

2024-08-10 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/102759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-10 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/102664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-10 Thread Saleem Abdulrasool via cfe-commits
@@ -572,6 +572,13 @@ class TagTableInfo ReleaseOpLength - 1); Data += ReleaseOpLength - 1; } +unsigned ConformsToLength = +endian::readNext(Data); +if (ConformsToLength > 0) { compnerd wrote: ``

  1   2   >