llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Mike Crowe (mikecrowe) <details> <summary>Changes</summary> My fix for my original fix of issue #<!-- -->92896 in 666d224248707f373577b5b049b5b0229100006c modified the function signature for fmt::sprintf to more accurately match the real implementation in libfmt but failed to do the same for absl::StrFormat. The latter fix applied equally well to absl::StrFormat so it's important that its test verifies that the bug is fixed too. --- Full diff: https://github.com/llvm/llvm-project/pull/102759.diff 1 Files Affected: - (modified) clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-format.cpp (+2-3) ``````````diff diff --git a/clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-format.cpp b/clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-format.cpp index e8dea1dce2c972..800a95062e8f1a 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-format.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-format.cpp @@ -11,9 +11,8 @@ namespace absl { -// Use const char * for the format since the real type is hard to mock up. -template <typename... Args> -std::string StrFormat(const char *format, const Args&... args); +template <typename S, typename... Args> +std::string StrFormat(const S &format, const Args&... args); } // namespace absl template <typename T> `````````` </details> https://github.com/llvm/llvm-project/pull/102759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
