[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin milestoned https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-05 Thread via cfe-commits
cor3ntin wrote: /cherry-pick da380b2 https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-05 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#101967 https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > I might be stupid but i still do not get why fold expressions are special, > they should not be. Sorry I was inaccurate suggesting fold expressions are special, it's actually *constraints involving pack expansions* who are special. (I admit inventing another `collectUnexpande

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread via cfe-commits
cor3ntin wrote: Okay so we seem to agree. Can you go over the pr and make sure "fold expression" says "pack expansion" everywhere that it should (release note, comments, function names) ? Thanks! https://github.com/llvm/llvm-project/pull/86265 ___ cf

[clang] [clang] Add test for CWG2091 "Deducing reference non-type template arguments" (PR #100765)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/100765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-05 Thread John Brawn via cfe-commits
john-brawn-arm wrote: > Looks like this breaks building on Android: > https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel/680348/overview Looks like Android here is being built with clang-llvmorg-19-init-14561-gecea8371-3004.tar.xz which looks like it's built from commit http

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Phoebe Wang via cfe-commits
@@ -417,3 +417,173 @@ defm VMINMAXSH : avx10_minmax_scalar<"vminmaxsh", v8f16x_info, X86vminmaxs, X86v AVX512PSIi8Base, VEX_LIG, EVEX, , EVEX_CD8<16, CD8VT1>, TA; defm VMINMAXSS : avx10_minmax_scalar<"vminmaxss", v4f32x_info, X86vminmaxs, X86vminmaxsSae>,

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Phoebe Wang via cfe-commits
@@ -821,6 +821,88 @@ def X86vpdpbuuds : SDNode<"X86ISD::VPDPBUUDS", SDTVnni>; def X86Vmpsadbw : SDNode<"X86ISD::MPSADBW", SDTX86PSADBW>; +def SDTAVX10SATCVT_BF162I : SDTypeProfile<1, 1, [ + SDTCVecEltisVT<0, i16>, SDTCVecEltisVT<1, bf16> +]>; + +def SDTAVX10SATCVT_PH2I : SDT

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-05 Thread Nico Weber via cfe-commits
nico wrote: That sounds believable. We did update our compiler just an hour or so ago, so it's possible it will work for us now. However, it suggests that the assumption `defined(__ARM_FEATURE_GCS_DEFAULT)` => arm_acle.h has `__chkfeat()` isn't valid in this snippet in libunwind/src/cet_unwi

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-08-05 Thread Florian Hahn via cfe-commits
@@ -16,8 +16,8 @@ #include "llvm/ADT/EquivalenceClasses.h" #include "llvm/Analysis/LoopAnalysisManager.h" -#include "llvm/Analysis/ScalarEvolutionExpressions.h" #include "llvm/IR/DiagnosticInfo.h" +#include "llvm/Transforms/Utils/ScalarEvolutionExpander.h" fh

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-08-05 Thread Florian Hahn via cfe-commits
@@ -9838,16 +9902,33 @@ bool LoopVectorizePass::processLoop(Loop *L) { ElementCount UserVF = Hints.getWidth(); unsigned UserIC = Hints.getInterleave(); + bool AddBranchWeights = + hasBranchWeightMD(*L->getLoopLatch()->getTerminator()); + GeneratedRTChecks Checks(*PS

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-08-05 Thread Florian Hahn via cfe-commits
@@ -9,11 +9,11 @@ define void @same_step_and_size(ptr %a, ptr %b, i64 %n) { ; CHECK-NEXT:[[A2:%.*]] = ptrtoint ptr [[A:%.*]] to i64 ; CHECK-NEXT:[[B1:%.*]] = ptrtoint ptr [[B:%.*]] to i64 ; CHECK-NEXT:[[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[N:%.*]], 4 -; CHECK-NEXT

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-08-05 Thread Florian Hahn via cfe-commits
@@ -8520,7 +8561,29 @@ LoopVectorizationPlanner::tryToBuildVPlanWithVPRecipes(VFRange &Range) { // When not folding the tail, we know that the induction increment will not // overflow. bool HasNUW = Style == TailFoldingStyle::None; - addCanonicalIVRecipes(*Plan, Legal->

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-08-05 Thread Florian Hahn via cfe-commits
@@ -0,0 +1,369 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4 +; RUN: opt < %s -passes=loop-vectorize -mtriple=aarch64-linux-gnu -force-vector-interleave=1 -prefer-predicate-over-epilogue=predicate-dont-vectorize -S | FileChe

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-08-05 Thread Florian Hahn via cfe-commits
@@ -428,6 +431,85 @@ Value *VPInstruction::generatePerPart(VPTransformState &State, unsigned Part) { {PredTy, ScalarTC->getType()}, {VIVElem0, ScalarTC}, nullptr, Name); } + case VPInstruction::AliasLaneM

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-08-05 Thread Florian Hahn via cfe-commits
@@ -428,6 +431,85 @@ Value *VPInstruction::generatePerPart(VPTransformState &State, unsigned Part) { {PredTy, ScalarTC->getType()}, {VIVElem0, ScalarTC}, nullptr, Name); } + case VPInstruction::AliasLaneM

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Phoebe Wang via cfe-commits
@@ -821,6 +821,88 @@ def X86vpdpbuuds : SDNode<"X86ISD::VPDPBUUDS", SDTVnni>; def X86Vmpsadbw : SDNode<"X86ISD::MPSADBW", SDTX86PSADBW>; +def SDTAVX10SATCVT_BF162I : SDTypeProfile<1, 1, [ + SDTCVecEltisVT<0, i16>, SDTCVecEltisVT<1, bf16> +]>; + +def SDTAVX10SATCVT_PH2I : SDT

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread Alexis Engelke via cfe-commits
aengelke wrote: Is there a previous discussion (e.g., RFC) about this? Did you consider alternative approaches? (E.g., just a spontaneous idea, adding a specially named symbol for every jump table where the symbol size is the size of the jump table; entry size (4/8) could be encoded in the nam

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-05 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Is there some reason this is an attribute, and not a calling convention, at > > the IR level? > > Thought about it and decided against that, but I agree that this is an > option, my reasoning below. From the semantic point of view the difference > between current attri

[clang] [clang] Fix compile-time regression from attribute arg checking change (PR #101768)

2024-08-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. The code changes LGTM but I wonder if we should put a branch up on https://llvm-compile-time-tracker.com/ to verify the compile-time improvements before landing to verify they in fact resolve the issue. https://github.com/llvm/llvm-pr

[libunwind] [libunwind] Be more careful about enabling GCS (PR #101973)

2024-08-05 Thread John Brawn via cfe-commits
https://github.com/john-brawn-arm created https://github.com/llvm/llvm-project/pull/101973 We need both GCS to be enabled by the compiler (which we do by checking if __ARM_FEATURE_GCS_DEFAULT is defined) and for arm_acle.h to define the GCS intrinsics. Check the latter by checking if _CHKFEAT_

[libunwind] [libunwind] Be more careful about enabling GCS (PR #101973)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: John Brawn (john-brawn-arm) Changes We need both GCS to be enabled by the compiler (which we do by checking if __ARM_FEATURE_GCS_DEFAULT is defined) and for arm_acle.h to define the GCS intrinsics. Check the latter by checking if _CHK

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-05 Thread John Brawn via cfe-commits
john-brawn-arm wrote: https://github.com/llvm/llvm-project/pull/101973 for being more careful about enabling GCS. https://github.com/llvm/llvm-project/pull/99335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-05 Thread Zahira Ammarguellat via cfe-commits
@@ -14683,6 +14710,23 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { default: return false; + case Builtin::BI__builtin_frexp: + case Builtin::BI__builtin_frexpf: + case Builtin::BI__builtin_frexpl: { zahiraam wrote: Done. https://g

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-05 Thread Zahira Ammarguellat via cfe-commits
@@ -14674,6 +14676,31 @@ static bool TryEvaluateBuiltinNaN(const ASTContext &Context, return true; } +// Checks that the value x is in the range (-1;-0.5], [0.5; 1) +static bool isInFrexpResultRange(const llvm::APFloat &x) { + llvm::APFloat minusOne(x.getSemantics(), "-1.

[clang] [llvm] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME2 instruction (PR #97602)

2024-08-05 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/97602 >From 70d1ec0e1c1bd896cf753510a8452325b086430e Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 3 Jul 2024 15:55:45 + Subject: [PATCH 1/4] [Clang][LLVM][AArch64] Add intrinsic for MOVT SME

[clang] [AIX] Turn on `#pragma mc_func` check by default (PR #101336)

2024-08-05 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman sorry to bug you. This patch was not tested sufficiently on my > end and it is causing build failures on AIX buildbots due to the > aforementioned system headers including `#pragma mc_func`. See > https://lab.llvm.org/buildbot/#/builders/64/builds/582/steps/

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-08-05 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/97277 >From fbeca5c357b1a5589757bbb2cac8208f8c9027ab Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Mon, 24 Jun 2024 09:59:24 + Subject: [PATCH 1/5] [WIP][CLANG][AArch64] Add the modal 8 bit float

[clang] Fix codegen of consteval functions returning an empty class, and related issues (PR #93115)

2024-08-05 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Is this worth back porting as it is a bugfix over code gen? IMO, it's worth considering, but if we want to go down this route, I think we need to do so relatively quickly -- we have about two weeks until rc3, and given the size of this change, I'm not certain we should tr

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-08-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping https://github.com/llvm/llvm-project/pull/99687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Arm][AArch64][Clang] Respect function's branch protection attributes. (PR #101978)

2024-08-05 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss created https://github.com/llvm/llvm-project/pull/101978 Default attributes assigned to all functions according to the command line parameters. Some functions might have their own attributes and we need to set or remove attributes accordingly. Tests are upd

[clang] [Arm][AArch64][Clang] Respect function's branch protection attributes. (PR #101978)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Daniel Kiss (DanielKristofKiss) Changes Default attributes assigned to all functions according to the command line parameters. Some functions might have their own attributes and we need to set or remove attributes accordingly. Tes

[clang] [Clang] Implement CWG2351 `void{}` (PR #78060)

2024-08-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/78060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 30e5d71 - [clang][NFC] Add CWG713 test; add example from CWG1584 test (#100747)

2024-08-05 Thread via cfe-commits
Author: Mital Ashok Date: 2024-08-05T15:36:11+02:00 New Revision: 30e5d7190d39fe4f0982435d4fb5043e64acdc9f URL: https://github.com/llvm/llvm-project/commit/30e5d7190d39fe4f0982435d4fb5043e64acdc9f DIFF: https://github.com/llvm/llvm-project/commit/30e5d7190d39fe4f0982435d4fb5043e64acdc9f.diff L

[clang] [clang][NFC] Add CWG713 test; add example from CWG1584 test (PR #100747)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/100747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2024-08-05 Thread via cfe-commits
@@ -314,53 +316,69 @@ class APValue { DataType Data; public: - APValue() : Kind(None) {} - explicit APValue(APSInt I) : Kind(None) { + bool allowConstexprUnknown() const { return AllowConstexprUnknown; } + + void setConstexprUnknown() { AllowConstexprUnknown = true; } --

[clang] [Clang] Check explicit object parameter for defaulted operators properly (PR #100419)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/100419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-05 Thread Zahira Ammarguellat via cfe-commits
@@ -253,8 +253,10 @@ def FmodF16F128 : F16F128MathTemplate, Builtin { def FrexpF16F128 : F16F128MathTemplate, Builtin { let Spellings = ["__builtin_frexp"]; - let Attributes = [FunctionWithBuiltinPrefix, NoThrow]; + let Attributes = [FunctionWithBuiltinPrefix, NoThrow, Con

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-05 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,106 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 + +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -emit-llvm -o - %s | FileCheck %s + +#define NAN (__builtin_nanf("")) +#define

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-05 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,106 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 + +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -emit-llvm -o - %s | FileCheck %s + +#define NAN (__builtin_nanf("")) +#define

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-05 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,108 @@ +// RUN: %clang_cc1 -DWIN -verify=nan-not-constant -std=c++23 -fsyntax-only %s +// RUN: %clang_cc1 -verify -std=c++23 -fsyntax-only %s +// RUN: %clang_cc1 -verify=cplusplus20andless -std=c++20 -fsyntax-only %s + +// expected-no-diagnostics + + +#ifdef WIN +#de

[clang] [llvm] Reapply "Finish deleting the le32/le64 targets" (#99079) (PR #101983)

2024-08-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/101983 This reverts commit d3f8105c65046173e20c4c59394b4a7f1bbe7627. Halide no longer relies on this target: https://github.com/llvm/llvm-project/pull/98497#issuecomment-2253358685 >From 474968e4e9bebbe14885fd752

[clang] [llvm] Reapply "Finish deleting the le32/le64 targets" (#99079) (PR #101983)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes This reverts commit d3f8105c65046173e20c4c59394b4a7f1bbe7627. Halide no longer relies on this target: https://github.com/llvm/llvm-project/pull/98497#issuecomment-2253

[clang] [Clang][Sema] Ensure that the selected candidate for a member function explicit specialization is more constrained than all others (PR #101721)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
@@ -7964,8 +7964,9 @@ NamedDecl *Sema::ActOnVariableDeclarator( D.setRedeclaration(CheckVariableDeclaration(NewVD, Previous)); } else { // If this is an explicit specialization of a static data member, check it. -if (IsMemberSpecialization && !IsVariableTemplateSp

[clang] [Clang][Sema] Ensure that the selected candidate for a member function explicit specialization is more constrained than all others (PR #101721)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/101721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Ensure that the selected candidate for a member function explicit specialization is more constrained than all others (PR #101721)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/101721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Ensure that the selected candidate for a member function explicit specialization is more constrained than all others (PR #101721)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
@@ -10465,7 +10466,7 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC, Previous)) NewFD->setInvalidDecl(); } -} else if (isMemberSpecialization && isa(NewFD)) { +} else if (isMembe

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-08-05 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 01/15] Adding C23 constexpr math functions fmin and frexp.

[clang] [llvm] Reapply "Finish deleting the le32/le64 targets" (#99079) (PR #101983)

2024-08-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 30e5d7190d39fe4f0982435d4fb5043e64acdc9f 474968e4e9bebbe14885fd752ca99af13b404958 --e

[libunwind] [libunwind] Be more careful about enabling GCS (PR #101973)

2024-08-05 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. Makes sense, thanks! https://github.com/llvm/llvm-project/pull/101973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich created https://github.com/llvm/llvm-project/pull/101989 partially fixes #70078 ### Changes - Implemented `sign` clang builtin - Linked `sign` clang builtin with `hlsl_intrinsics.h` - Added sema checks for `sign` to `CheckHLSLBuiltinFunctionCall` in `SemaChecking.cp

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 04f65043bc8711996a4ade05c67ae2d087ae8be5 03e05cc3ee4746b760750515e884ab8ba4674e87 --e

[clang] [clang] [C++20] Defaulted operator== doesn't lookup in using-directive properly #97087 (PR #99542)

2024-08-05 Thread via cfe-commits
@@ -4856,7 +4856,7 @@ bool TemplateDeclInstantiator::SubstDefaultedFunction(FunctionDecl *New, : DFI); } - SemaRef.SetDeclDefaulted(New, Tmpl->getLocation()); + SemaRef.SetDeclDefaulted(nullptr, New, Tmpl->getLocation()); ofAlpaca wrote

[clang] [clang][NFC] Make OffloadLTOMode getter a separate method (PR #101200)

2024-08-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/101200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9884fd3 - [RISCV] Add Syntacore SCR4 RV32/64 processors definition (#101321)

2024-08-05 Thread via cfe-commits
Author: Anton Sidorenko Date: 2024-08-05T17:26:05+03:00 New Revision: 9884fd33dbfe6dc8808a6047f29d8166a6ccb7be URL: https://github.com/llvm/llvm-project/commit/9884fd33dbfe6dc8808a6047f29d8166a6ccb7be DIFF: https://github.com/llvm/llvm-project/commit/9884fd33dbfe6dc8808a6047f29d8166a6ccb7be.dif

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich updated https://github.com/llvm/llvm-project/pull/101989 >From a8a34780fe3311312cb37d48836e63e40bb6f4e0 Mon Sep 17 00:00:00 2001 From: Tim Gymnich Date: Fri, 2 Aug 2024 21:40:24 +0200 Subject: [PATCH 1/2] [clang][HLSL] Add sign intrinsic part 3 --- clang/include/cl

[clang] [llvm] [RISCV] Add Syntacore SCR4 RV32/64 processors definition (PR #101321)

2024-08-05 Thread Anton Sidorenko via cfe-commits
https://github.com/asi-sc closed https://github.com/llvm/llvm-project/pull/101321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/86265 >From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 22 Mar 2024 17:34:08 +0800 Subject: [PATCH 01/24] [Sema] Preserve ContainsUnexpandedParameterPack in Transfor

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/91895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-05 Thread via cfe-commits
@@ -1832,6 +1832,33 @@ static ExprResult BuiltinLaunder(Sema &S, CallExpr *TheCall) { return TheCall; } +static ExprResult BuiltinIsWithinLifetime(Sema &S, CallExpr *TheCall) { + if (checkArgCount(S, TheCall, 1)) +return ExprError(); + + ExprResult Arg = S.DefaultFunc

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin commented: This looks great. Most of the changes to DiagnosticASTKinds.td could be done as a nice NFC cleanup PR. My only real concern is the way we reject function pointer. We also might want tests for member function pointers. Are VLAs something we need to care abo

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-05 Thread via cfe-commits
@@ -17160,3 +17184,72 @@ bool Expr::tryEvaluateStrLen(uint64_t &Result, ASTContext &Ctx) const { EvalInfo Info(Ctx, Status, EvalInfo::EM_ConstantFold); return EvaluateBuiltinStrLen(this, Result, Info); } + +namespace { +struct IsWithinLifetimeHandler { + EvalInfo &Info; +

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: The `.debug_` prefix is for DEARF content, is this being proposed to the DWARF standard? https://github.com/llvm/llvm-project/pull/101962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/86265 >From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 22 Mar 2024 17:34:08 +0800 Subject: [PATCH 01/25] [Sema] Preserve ContainsUnexpandedParameterPack in Transfor

[clang] test (PR #101992)

2024-08-05 Thread via cfe-commits
https://github.com/Damien-Chen created https://github.com/llvm/llvm-project/pull/101992 None >From ee5eb0eac6689fa0ab418218f5a6e76230a605d8 Mon Sep 17 00:00:00 2001 From: Damien-Chen Date: Mon, 5 Aug 2024 22:36:47 +0800 Subject: [PATCH] Fix clang format --- clang/lib/Format/TokenAnnotator.cp

[clang] test (PR #101992)

2024-08-05 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] test (PR #101992)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Damien (Damien-Chen) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/101992.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+3-4) - (modified) clang/unittests/Format/FormatTest.cpp (+16

[clang] test (PR #101992)

2024-08-05 Thread via cfe-commits
https://github.com/Damien-Chen closed https://github.com/llvm/llvm-project/pull/101992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/86265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM (modulo nit) We should probably backport that https://github.com/llvm/llvm-project/pull/86265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread via cfe-commits
@@ -0,0 +1,181 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++20 -verify %s + +namespace GH85667 { + +template +struct identity { + using type = T; +}; + +template void f() { + + static_assert([](Is... x) { +return ([I(x)] { + return I; +}() + ...); + }(1, 2) == 3)

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich updated https://github.com/llvm/llvm-project/pull/101989 >From a8a34780fe3311312cb37d48836e63e40bb6f4e0 Mon Sep 17 00:00:00 2001 From: Tim Gymnich Date: Fri, 2 Aug 2024 21:40:24 +0200 Subject: [PATCH 1/2] [clang][HLSL] Add sign intrinsic part 3 --- clang/include/cl

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich ready_for_review https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Make UnresolvedLookupExprs in class scope explicit specializations instantiation dependent (PR #100392)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > Can we get rid of the whitespace only changes? @cor3ntin I have my editor configured to remove trailing whitespace on save. I'll just merge a commit to `main` that removes the trailing whitespace. > Can we maybe introduce an enum, it's a lot of booleans that will be easy to

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Tim Gymnich (tgymnich) Changes partially fixes #70078 ### Changes - Implemented `sign` clang builtin - Linked `sign` clang builtin with `hlsl_intrinsics.h` - Added sema ch

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/86265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/86265 >From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 22 Mar 2024 17:34:08 +0800 Subject: [PATCH 01/26] [Sema] Preserve ContainsUnexpandedParameterPack in Transfor

[clang] [clang][Interp] Remove GlobalDecl flag (PR #101995)

2024-08-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/101995 When initializing global variables, we still need to create local variables for temporaries created in the process. Otherwise, we will never call their destructors. >From 0d4526e27c897cd9f928ddc16eb72d4c2c592

[clang] [clang][Interp] Remove GlobalDecl flag (PR #101995)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes When initializing global variables, we still need to create local variables for temporaries created in the process. Otherwise, we will never call their destructors. --- Full diff: https://github.com/llvm/ll

[clang] [Clang][Sema] Make UnresolvedLookupExprs in class scope explicit specializations instantiation dependent (PR #100392)

2024-08-05 Thread via cfe-commits
cor3ntin wrote: > This sounds more like an unrelated refactoring change. I'm going to hold off > on doing that in this patch. With this change, some of modified functions get multiple boolean back to back and we are for some of them at 11+ parameters. I think some cleanup would be in order WDY

[clang] [OpenMP][Map][NFC] improve map chain. (PR #101903)

2024-08-05 Thread via cfe-commits
jyu2-git wrote: > LG Thanks, Alexey!! https://github.com/llvm/llvm-project/pull/101903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX] Turn on `#pragma mc_func` check by default (PR #101336)

2024-08-05 Thread via cfe-commits
cor3ntin wrote: Should we consider a feature like `-Wunknown-pragmas=` rather than doing something specific for that one pragma? Have you consider whether this use case generalizes at all? https://github.com/llvm/llvm-project/pull/101336 ___ cfe-comm

[clang] 6848b99 - [OpenMP][Map][NFC] improve map chain. (#101903)

2024-08-05 Thread via cfe-commits
Author: jyu2-git Date: 2024-08-05T08:01:11-07:00 New Revision: 6848b99d170e9ac59ce2007c817bc579536d8e8e URL: https://github.com/llvm/llvm-project/commit/6848b99d170e9ac59ce2007c817bc579536d8e8e DIFF: https://github.com/llvm/llvm-project/commit/6848b99d170e9ac59ce2007c817bc579536d8e8e.diff LOG:

[clang] [OpenMP][Map][NFC] improve map chain. (PR #101903)

2024-08-05 Thread via cfe-commits
https://github.com/jyu2-git closed https://github.com/llvm/llvm-project/pull/101903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Remove trailing whitespace from SemaExpr.cpp (PR #102001)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/102001 None >From 42012dba14c04b00ea0c8f542a9bfc0983002a9e Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 5 Aug 2024 11:03:04 -0400 Subject: [PATCH] [Clang][NFC] Remove trailing whitespace from SemaE

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-05 Thread Daniel Kiss via cfe-commits
@@ -680,7 +680,7 @@ DEFINE_LIBUNWIND_FUNCTION(__libunwind_Registers_arm64_jumpto) ldrx16, [x0, #0x0F8] ldpx0, x1, [x0, #0x000] // restore x0,x1 movsp,x16 // restore sp - retx30// jump to pc Danie

[clang] [Clang][NFC] Remove trailing whitespace from SemaExpr.cpp (PR #102001)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/102001.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaExpr.cpp (+4-4) ``diff diff --git a/clang/lib/Sema/SemaExpr.cpp

[clang] [Clang][NFC] Remove trailing whitespace from SemaExpr.cpp (PR #102001)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/102001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 13dd795 - [clang][NFC] Make OffloadLTOMode getter a separate method (#101200)

2024-08-05 Thread via cfe-commits
Author: macurtis-amd Date: 2024-08-05T10:06:51-05:00 New Revision: 13dd795ef108c75b1b6240832f77ca5282a2e629 URL: https://github.com/llvm/llvm-project/commit/13dd795ef108c75b1b6240832f77ca5282a2e629 DIFF: https://github.com/llvm/llvm-project/commit/13dd795ef108c75b1b6240832f77ca5282a2e629.diff

[clang] [llvm] [LLVM][PassBuilder] Extend the function signature of callback for optimizer pipeline extension point (PR #100953)

2024-08-05 Thread Shilei Tian via cfe-commits
shiltian wrote: ping +1 https://github.com/llvm/llvm-project/pull/100953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Make OffloadLTOMode getter a separate method (PR #101200)

2024-08-05 Thread via cfe-commits
https://github.com/macurtis-amd closed https://github.com/llvm/llvm-project/pull/101200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0b2d50c - [Clang][NFC] Remove trailing whitespace from SemaExpr.cpp (#102001)

2024-08-05 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-08-05T11:15:31-04:00 New Revision: 0b2d50c08d2eadf32f685fcd5b5468bc2ec7a16d URL: https://github.com/llvm/llvm-project/commit/0b2d50c08d2eadf32f685fcd5b5468bc2ec7a16d DIFF: https://github.com/llvm/llvm-project/commit/0b2d50c08d2eadf32f685fcd5b5468bc2ec7a16d

[clang] [Clang][NFC] Remove trailing whitespace from SemaExpr.cpp (PR #102001)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/102001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Remove trailing whitespace from SemaExpr.cpp (PR #102001)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/102001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Make UnresolvedLookupExprs in class scope explicit specializations instantiation dependent (PR #100392)

2024-08-05 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/100392 >From 7d0e70feb5e657c1830901e3ed9a01c1d56c7526 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 24 Jul 2024 10:15:47 -0400 Subject: [PATCH] [Clang][Sema] Make UnresolvedLookupExprs in class scope

<    1   2   3   4   >