Sirraide wrote:
> So I dont end up making 100 commits rewording this:
It’s fine if you do. We do squash+merge anyway, so the entire pr will end up as
one commit either way ;Þ
> How about "Clang now diagnoses template template paramter missing `<` as typo
> for `typename`"
Maybe something li
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/95729
>From 40f18f2be624ed2a5b4922e67e4ed6070d2d2400 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 17 Jun 2024 00:13:20 +
Subject: [PATCH 1/2] [clang][analyzer] use unqualified canonical type during
m
@@ -0,0 +1,40 @@
+//===--- PreferAtOverSubscriptOperatorCheck.h - clang-tidy --*- C++
-*-===//
+//===--- PreferMemberInitializerCheck.h - clang-tidy *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See htt
@@ -0,0 +1,9 @@
+; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s
+
+; CHECK-LABEL: llvm.func @tune_cpu()
+; CHECK-SAME: tune_cpu = "pentium4"
Dinistro wrote:
Can you add a check that ensures that this is not also placed in the
passthrough
@@ -411,6 +412,13 @@ void Flang::addTargetOptions(const ArgList &Args,
}
// TODO: Add target specific flags, ABI, mtune option etc.
+ if (const Arg *A = Args.getLastArg(options::OPT_mtune_EQ)) {
+CmdArgs.push_back("-tune-cpu");
+if (strcmp(A->getValue(), "native")
PBHDK wrote:
> Btw, I realize that this check is part of the [bounds
> profile](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#SS-bounds)
> (Bounds.4), so for consistency it should probably be named
> `cppcoreguidelines-pro-bounds-...`.
What do you think of:
`cppcoreguidelines-
Veeloxfire wrote:
> It’s fine if you do. We do squash+merge anyway, so the entire pr will end up
> as one commit either way ;Þ
Aha I didnt realise!
> seeing as we were already diagnosing this; the only thing that’s changed is
> that we now also provide a fix-it.
I agree but also now it fully
Sirraide wrote:
> This change isnt reflected in that, but I think its probably good enough and
> not worth worrying about
Hmm, yeah, that’s true, but given that this is mainly about error correction,
it’s not too important of a change imo; the program contains an error and won’t
compile eithe
https://github.com/Veeloxfire updated
https://github.com/llvm/llvm-project/pull/95726
>From 44620330cd5238de549d3d77ddc447cd3bc51e60 Mon Sep 17 00:00:00 2001
From: Veeloxfire <58116051+veeloxf...@users.noreply.github.com>
Date: Mon, 17 Jun 2024 01:20:32 +0100
Subject: [PATCH 1/6] [clang][Parser]
ilya-biryukov wrote:
@ChuanqiXu9 are you still planning to chase this given that fixing the hashing
function would fix performance for the aforementioned patch?
The trade-off we are making here is hard to assess without benchmarks that show
how much latency we win and how much more memory we s
@@ -1764,6 +1764,13 @@ class TargetInfo : public TransferrableTargetInfo,
return 0;
}
+ /// \returns Target specific flat ptr address space; a flat ptr is a ptr that
+ /// can be casted to / from all other target address spaces. If the target
+ /// exposes no such add
spaits wrote:
@zyn0217 @cor3ntin Sorry to ping you. Could you please take another look at
this PR? Are my assumptions about the standard correct? Are the tests good now
or I should make other changes?
https://github.com/llvm/llvm-project/pull/94752
_
@@ -1764,6 +1764,13 @@ class TargetInfo : public TransferrableTargetInfo,
return 0;
}
+ /// \returns Target specific flat ptr address space; a flat ptr is a ptr that
+ /// can be casted to / from all other target address spaces. If the target
+ /// exposes no such add
https://github.com/AlexVlx edited
https://github.com/llvm/llvm-project/pull/95061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AlexVlx commented:
Gentle ping.
https://github.com/llvm/llvm-project/pull/95061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/94891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/94891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NagyDonat wrote:
> Consider replacing ":" separator with ","
I switched to ":" (instead of the ";" that was used previously) to emphasize
that the second part of the message is an explanation/reason for the first part
(and not a second, separate issue). However I can switch to "," or ";" if th
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/94892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jan Leyonberg
Date: 2024-06-17T09:31:15-04:00
New Revision: b75e7c61ffc4adea0ec5fca63ba3feba845c8303
URL:
https://github.com/llvm/llvm-project/commit/b75e7c61ffc4adea0ec5fca63ba3feba845c8303
DIFF:
https://github.com/llvm/llvm-project/commit/b75e7c61ffc4adea0ec5fca63ba3feba845c8303.diff
https://github.com/jsjodin closed
https://github.com/llvm/llvm-project/pull/94763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
LGTM, much easier to read. Thank you.
https://github.com/llvm/llvm-project/pull/95727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
I can see the logic, but it seems like there's a fair amount of related
checking that perhaps should happen as well. Marking a destructor as try_lock
makes even less sense than marking a constructor, so why not prohibit that as
well? And since the try
AaronBallman wrote:
> @AaronBallman, please take a look!
>
> What do you think of this approach? I suppose it might be even better to
> enforce that the function's return type is `bool`, which would align with the
> [ThreadSafetyAnalysis
> documentation](https://clang.llvm.org/docs/ThreadSafe
@@ -1764,6 +1764,13 @@ class TargetInfo : public TransferrableTargetInfo,
return 0;
}
+ /// \returns Target specific flat ptr address space; a flat ptr is a ptr that
+ /// can be casted to / from all other target address spaces. If the target
+ /// exposes no such add
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sander de Smalen (sdesmalen-arm)
Changes
This allows code with SVE intrinsics to be compiled with +sme,+nosve,
https://github.com/pratlucas approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/92145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1764,6 +1764,13 @@ class TargetInfo : public TransferrableTargetInfo,
return 0;
}
+ /// \returns Target specific flat ptr address space; a flat ptr is a ptr that
+ /// can be casted to / from all other target address spaces. If the target
+ /// exposes no such add
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/94891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM! Please be sure to add a release note to clang/docs/ReleaseNotes.rst so
users know about the new functionality.
https://github.com/llvm/llvm-project/pull/91100
___
cfe-commits mailing li
Author: Timm Baeder
Date: 2024-06-17T16:07:58+02:00
New Revision: 4bf160e3968d77334e27dc358c497703f315351f
URL:
https://github.com/llvm/llvm-project/commit/4bf160e3968d77334e27dc358c497703f315351f
DIFF:
https://github.com/llvm/llvm-project/commit/4bf160e3968d77334e27dc358c497703f315351f.diff
L
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/91100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/89217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/95797
When a definition is being located, standard library function recognition is
skipped if the function has a definition with body in the main file
>From 71a2c0d29058edac2539fbbe406890e6a6dc875c Mon Sep 17 00:
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Congcong Cai (HerrCai0907)
Changes
When a definition is being located, standard library function recognition is
skipped if the function has a definition with body in the main file
---
Full diff: https://github.com/llvm/llvm-p
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/95479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ye-luo wrote:
progress?
https://github.com/llvm/llvm-project/pull/92430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nishithshah2211 created
https://github.com/llvm/llvm-project/pull/95798
When trying to lex numeric constants that use single quotes as separators, if
the lexer is parsing a preprocessor directive, we can relax the language
options check. These checks will be enforced in a la
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nishith Kumar M Shah (nishithshah2211)
Changes
When trying to lex numeric constants that use single quotes as separators, if
the lexer is parsing a preprocessor directive, we can relax the language
options check. These checks will be enfo
nishithshah2211 wrote:
@jansvoboda11 - I put up this PR to get your thoughts on addressing
https://github.com/llvm/llvm-project/issues/88896, since the previous commit
was reverted. Is this more along the lines of what you were thinking?
I will push more changes to include a test for the Lexer
earnol wrote:
Ping!
Any additional suggestions for the improvements?
https://github.com/llvm/llvm-project/pull/93612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat approved this pull request.
Nice catch, thanks for fixing this bug!
https://github.com/llvm/llvm-project/pull/95729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/95455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/john-brawn-arm updated
https://github.com/llvm/llvm-project/pull/94632
>From c490a8c7d16e03066a3a4ef4985fa64fb28d Mon Sep 17 00:00:00 2001
From: John Brawn
Date: Thu, 14 Mar 2024 16:17:03 +
Subject: [PATCH] [DebugInfo] Change handling of structured bindings of
bitfie
AaronBallman wrote:
> > > I guess the general question is - is it acceptable to have the Scanner
> > > operating in a language standard different than the passed in language
> > > mode and different than the compiler language standard?
> >
> >
> > I think that is acceptable. It is kinda hacky
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/95479
>From 125d9cdd617d6415ef24eb785fe22705149f2d01 Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Fri, 14 Jun 2024 01:26:34 +0300
Subject: [PATCH 1/5] [Clang] disallow non-lvalue values in constant
expressions
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
Excellent quality. Thank for fixing this.
Do you need us to merge this, or you have merge rights?
https://github.com/llvm/llvm-project/pull/95729
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/AaronBallman commented:
The changes should come with a release note in clang/docs/ReleaseNotes.rst so
users know about the fix.
The changes otherwise look correct, but I'd like to hear from @jansvoboda11 as
well (especially in light of the question I raised on the original P
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Mariya Podchishchaeva (Fznamznon)
Changes
This commit implements the entirety of the now-accepted [N3017 -Preprocessor
Embed](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3017.htm) and its
sister C++ paper [p1967](https://wg21
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Mariya Podchishchaeva (Fznamznon)
Changes
This commit implements the entirety of the now-accepted [N3017 -Preprocessor
Embed](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3017.htm) and its
sister C+
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Mariya Podchishchaeva (Fznamznon)
Changes
This commit implements the entirety of the now-accepted [N3017 -Preprocessor
Embed](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3017.htm) and its
sister C++ paper [p1967](h
nishithshah2211 wrote:
> The changes should come with a release note in clang/docs/ReleaseNotes.rst so
> users know about the fix.
Noted. Will include a release note, a lexer test and address any other comments
for the next commit.
https://github.com/llvm/llvm-project/pull/95798
_
Fznamznon wrote:
This fixes
https://github.com/llvm/llvm-project/pull/68620#issuecomment-2163448739 .
There was also
https://github.com/llvm/llvm-project/pull/68620#issuecomment-2163603239
reported, but I'm not able to access proper logs. The link points to sanitizer
buildbots so I suppose it
Michael137 wrote:
Yea the problem with checking the size reported by the AST layout vs. the LLVM
type layout is that in DWARF we get following representation:
```
// main.cpp
struct A {
long c, d;
};
struct B {
[[no_unique_address]] Empty x;
};
struct C {
[[no_unique_address]] Empty x;
}
HerrCai0907 wrote:
> Do you need us to merge this, or you have merge rights?
Yes.
https://github.com/llvm/llvm-project/pull/95729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-06-17T23:37:34+08:00
New Revision: 0851d7b00c651d527a37becc206566580bf3c615
URL:
https://github.com/llvm/llvm-project/commit/0851d7b00c651d527a37becc206566580bf3c615
DIFF:
https://github.com/llvm/llvm-project/commit/0851d7b00c651d527a37becc206566580bf3c615.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/95729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HerrCai0907 wrote:
> Excellent quality. Thank for fixing this.
Should I fix the other type comparison in static analysis? It looks like not
consider this case at lots of position.
https://github.com/llvm/llvm-project/pull/95729
___
cfe-commits mail
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-aarch64
Author: Lucas Duarte Prates (pratlucas)
Changes
This introduces the new '--print-enabled-extensions' command line option
to AArch64, which prints the list of extensins that are enabled for the
target spe
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Lucas Duarte Prates (pratlucas)
Changes
This introduces the new '--print-enabled-extensions' command line option
to AArch64, which prints the list of extensins that are enabled for the
target specified by the combination of '
https://github.com/pratlucas edited
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 964c92d04f039a205327cb47c75919096f9fca94
2e10a741ac8ddfccc661966df096de9c7ff505f1 --
https://github.com/cor3ntin approved this pull request.
The commit to fix the leak LGTM
https://github.com/llvm/llvm-project/pull/95802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5703,6 +5703,11 @@ def print_supported_extensions : Flag<["-", "--"],
"print-supported-extensions">
Visibility<[ClangOption, CC1Option, CLOption]>,
HelpText<"Print supported -march extensions (RISC-V, AArch64 and ARM only)">,
MarshallingInfoFlag>;
+def print_enabled_
steakhal wrote:
> > Excellent quality. Thank for fixing this.
>
> Should I fix the other type comparison in static analysis? It looks like not
> consider this case at lots of position.
>
>
I think you are right. And in most cases within CSA, we should usually compare
canonical types.
If you
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett commented:
Cool idea, should be very useful.
The TableGen has changed so much since I last looked so I didn't look over that
myself.
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-com
@@ -19,3 +19,19 @@
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// ARM
@@ -161,6 +162,39 @@ static int PrintSupportedExtensions(std::string TargetStr)
{
return 0;
}
+static int PrintEnabledExtensions(const TargetOptions& TargetOpts) {
DavidSpickett wrote:
Is int here just following the local code style or would bool do? Since
@@ -13,3 +13,57 @@
// RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6a -### -c %s
2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s
// RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6-a -### -c %s
2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s
// GENER
@@ -134,17 +136,39 @@ std::optional
AArch64::parseCpu(StringRef Name) {
return {};
}
-void AArch64::PrintSupportedExtensions(StringMap DescMap) {
+void AArch64::PrintSupportedExtensions() {
outs() << "All available -march extensions for AArch64\n\n"
<< "" <
@@ -204,6 +238,10 @@ int cc1_main(ArrayRef Argv, const char
*Argv0, void *MainAddr) {
if (Clang->getFrontendOpts().PrintSupportedExtensions)
return PrintSupportedExtensions(Clang->getTargetOpts().Triple);
+ // --print-enabled-extensions takes priority over the actual c
DavidSpickett wrote:
Also please list the impact, if any, on `--print-supported-extensions` in the
commit message. I think it got a column with the FEAT_ names added, which is a
nice improvement.
https://github.com/llvm/llvm-project/pull/95805
___
cf
@@ -19,3 +19,19 @@
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// ARM
Author: John Brawn
Date: 2024-06-17T17:16:30+01:00
New Revision: fae31e283203da9a4a3225e2d016e245d4887c2f
URL:
https://github.com/llvm/llvm-project/commit/fae31e283203da9a4a3225e2d016e245d4887c2f
DIFF:
https://github.com/llvm/llvm-project/commit/fae31e283203da9a4a3225e2d016e245d4887c2f.diff
LO
https://github.com/john-brawn-arm closed
https://github.com/llvm/llvm-project/pull/94632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/94542
>From da4df73607a9edefc8db721818eff50e974a0637 Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Thu, 6 Jun 2024 01:55:54 +0300
Subject: [PATCH] [Clang] skip alignment checks on incomplete types to avoid an
as
@@ -114,12 +114,14 @@ using ExtensionBitset = Bitset;
// SubtargetFeature which may represent either an actual extension or some
// internal LLVM property.
struct ExtensionInfo {
- StringRef Name; // Human readable name, e.g. "profile".
+ StringRef UserVisible
@@ -114,12 +114,14 @@ using ExtensionBitset = Bitset;
// SubtargetFeature which may represent either an actual extension or some
// internal LLVM property.
struct ExtensionInfo {
- StringRef Name; // Human readable name, e.g. "profile".
+ StringRef UserVisible
@@ -114,12 +114,14 @@ using ExtensionBitset = Bitset;
// SubtargetFeature which may represent either an actual extension or some
// internal LLVM property.
struct ExtensionInfo {
- StringRef Name; // Human readable name, e.g. "profile".
+ StringRef UserVisible
@@ -23,6 +23,7 @@
class Extension<
string TargetFeatureName,// String used for -target-feature and
-march, unless overridden.
string Spelling, // The XYZ in HasXYZ and AEK_XYZ.
+ string ArchitectureFeatureName, // The extension's "FEAT
@@ -116,7 +116,9 @@ const AArch64::ArchInfo *AArch64::parseArch(StringRef Arch)
{
std::optional
AArch64::parseArchExtension(StringRef ArchExt) {
for (const auto &A : Extensions) {
-if (ArchExt == A.Name || ArchExt == A.Alias)
+if (A.UserVisibleName.empty() && !A.Alia
@@ -19,3 +19,19 @@
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// ARM
@@ -19,3 +19,19 @@
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// ARM
https://github.com/tmatheson-arm deleted
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
banach-space wrote:
This is probably a border-line case, but I would consider this a "driver"
rather than a "lowering" test. I'm biased though 😅
https://github.com/llvm/llvm-project/pull/95043
___
cfe-commits mailin
https://github.com/banach-space approved this pull request.
LGTM, thanks for implementing this 🙏🏻
https://github.com/llvm/llvm-project/pull/95043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
https://github.com/AaronBallman commented:
The changes seem pretty reasonable to me (aside from a few small nits), but I'd
appreciate someone with more compiler-rt knowledge to also sign off on the
changes.
https://github.com/llvm/llvm-project/pull/93612
___
@@ -3318,6 +3353,20 @@ llvm::Constant
*CodeGenFunction::EmitCheckTypeDescriptor(QualType T) {
DiagnosticsEngine::ak_qualtype, (intptr_t)T.getAsOpaquePtr(),
StringRef(),
StringRef(), std::nullopt, Buffer, std::nullopt);
+ if (IsBitInt) {
+// The Structure is:
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/93612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3318,6 +3353,20 @@ llvm::Constant
*CodeGenFunction::EmitCheckTypeDescriptor(QualType T) {
DiagnosticsEngine::ak_qualtype, (intptr_t)T.getAsOpaquePtr(),
StringRef(),
StringRef(), std::nullopt, Buffer, std::nullopt);
+ if (IsBitInt) {
+// The Structure is:
https://github.com/arsenm requested changes to this pull request.
There are quite a few code quality regressions, and XFAILed tests. The
description needs more elaboration on what the strategy is here
https://github.com/llvm/llvm-project/pull/92809
_
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/92809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15740,6 +15740,32 @@ void
SITargetLowering::finalizeLowering(MachineFunction &MF) const {
}
}
+ // ISel inserts copy to regs for the successor PHIs
+ // at the BB end. We need to move the SI_WAVE_RECONVERGE right before the
+ // branch.
+ for (auto &MBB : MF) {
101 - 200 of 403 matches
Mail list logo
