@@ -159,11 +263,56 @@ AST_MATCHER_P(DeclRefExpr, doesNotMutateObject, int,
Indirections) {
// The method call cannot mutate our variable.
continue;
}
+ if (isLikelyShallowConst(*Method)) {
+// We still have to check that t
@@ -36,6 +36,111 @@ void extractNodesByIdTo(ArrayRef Matches,
StringRef ID,
Nodes.insert(Match.getNodeAs(ID));
}
+// If `D` has a const-qualified overload with otherwise identical
+// ref-qualifiers, returns that overload.
+const CXXMethodDecl *findConstOverload(const CXX
https://github.com/AlexVlx commented:
> I don't think that assumption is currently true. I think it's also worth
> clarifying what this thing is, and possibly renaming it, because
> "unqualified" has C language level meaning that would contradict what it is
> here.
It's probably optimistic,
https://github.com/AlexVlx edited
https://github.com/llvm/llvm-project/pull/94388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -118,6 +124,37 @@ llvm::Type *CodeGenTypes::ConvertTypeForMem(QualType T,
bool ForBitField) {
return R;
}
+bool CodeGenTypes::LLVMTypeLayoutMatchesAST(QualType ASTTy,
+llvm::Type *LLVMTy) {
+ CharUnits ASTSize = Context.getTyp
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/91364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/91364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Daniel Krupp
Date: 2024-06-05T16:33:31+02:00
New Revision: 289725f11c579348ec49c8c606de4291314db0d9
URL:
https://github.com/llvm/llvm-project/commit/289725f11c579348ec49c8c606de4291314db0d9
DIFF:
https://github.com/llvm/llvm-project/commit/289725f11c579348ec49c8c606de4291314db0d9.diff
https://github.com/dkrupp closed https://github.com/llvm/llvm-project/pull/92420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
@jdoerfert Kind reminder for review. Thanks.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/94388
>From cdf95a804614950167d2d4df227d06a86a70d4bb Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Tue, 4 Jun 2024 19:52:28 +0100
Subject: [PATCH] Unqualified `ptr`s should be truly unqualified, and not AS0
ptrs.
-
https://github.com/AlexVlx edited
https://github.com/llvm/llvm-project/pull/94388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pdherbemont updated
https://github.com/llvm/llvm-project/pull/94216
>From 94212789ca0b22380de88521279056ffdce5b3e6 Mon Sep 17 00:00:00 2001
From: Pierre d'Herbemont
Date: Wed, 29 May 2024 11:11:03 +0200
Subject: [PATCH] Support [[guarded_by(mutex)]] and friends attributes ins
https://github.com/pdherbemont updated
https://github.com/llvm/llvm-project/pull/94216
>From 94212789ca0b22380de88521279056ffdce5b3e6 Mon Sep 17 00:00:00 2001
From: Pierre d'Herbemont
Date: Wed, 29 May 2024 11:11:03 +0200
Subject: [PATCH 1/2] Support [[guarded_by(mutex)]] and friends attributes
pdherbemont wrote:
> > > > One question I have is whether there will be follow-up work for other
> > > > thread safety attributes (`acquire_capability`,
> > > > `try_acquire_capability`, etc)?
> > >
> > >
> > > They already work fine in C so far. But if you are aware of some issues
> > > don
@@ -3330,6 +3340,63 @@ void Parser::DistributeCLateParsedAttrs(Decl *Dcl,
}
}
+/// GuardedBy attributes (e.g., guarded_by):
+/// AttrName '(' expression ')'
+void Parser::ParseGuardedByAttribute(IdentifierInfo &AttrName,
+ SourceLocation
pdherbemont wrote:
Pushed an additional change on the documentation: the doc was incorrectly
stating that ACQUIRED_{AFTER,BEFORE} were not implemented but they are.
https://github.com/llvm/llvm-project/pull/94216
___
cfe-commits mailing list
cfe-commi
argentite wrote:
> Unfortunately, this PR cannot be tested in the current testing infrastructure
> in llvm because it needs a browser to provide a proper execution environment.
Just to clarify, we don't need an actual full browser to test it. Nodejs should
probably be sufficient for execution.
@@ -5813,6 +5813,23 @@ static TypoCorrection TryTypoCorrectionForCall(Sema &S,
Expr *Fn,
return TypoCorrection();
}
+static bool isParenthetizedAndQualifiedAddressOfExpr(Expr *Fn) {
+ if (!isa(Fn))
+return false;
+
+ Fn = Fn->IgnoreParens();
cor3ntin
@@ -3048,10 +3050,12 @@ class OverloadExpr : public Expr {
Result.HasFormOfMemberPointer = (E == Ovl && Ovl->getQualifier());
Result.IsAddressOfOperand = true;
+ Result.IsAddressOfOperandWithParen = HasParen;
cor3ntin wrote:
I added a default
Author: cor3ntin
Date: 2024-06-05T16:50:42+02:00
New Revision: d0223b9ffc40146fb4a948ebfa652dc95499b7ba
URL:
https://github.com/llvm/llvm-project/commit/d0223b9ffc40146fb4a948ebfa652dc95499b7ba
DIFF:
https://github.com/llvm/llvm-project/commit/d0223b9ffc40146fb4a948ebfa652dc95499b7ba.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/93430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/94471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: 2024-06-05T08:01:35-07:00
New Revision: f10e71f6d80719c47f3eed117120e74d9d3858c1
URL:
https://github.com/llvm/llvm-project/commit/f10e71f6d80719c47f3eed117120e74d9d3858c1
DIFF:
https://github.com/llvm/llvm-project/commit/f10e71f6d80719c47f3eed117120e74d9d3858c1.diff
LO
NagyDonat wrote:
@EugeneZelenko Thanks for inviting some additional reviewers. I'll add an entry
in the release notes.
https://github.com/llvm/llvm-project/pull/94356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
hokein wrote:
unfortunately, this seems to break an existing test:
```
OK ] InterpreterTest.IncrementalInputTopLevelDecls (66 ms)
[ RUN ] InterpreterTest.Errors
ClangReplInterpreterTests:
/usr/local/google/home/hokein/workspace/llvm-project/clang/lib/Sema/IdentifierResolver.cpp:228:
https://github.com/kzhuravl created
https://github.com/llvm/llvm-project/pull/94483
None
>From 7d64f16e9bdc6b9a195a332a49e5fb9954d5f7c1 Mon Sep 17 00:00:00 2001
From: Konstantin Zhuravlyov
Date: Wed, 5 Jun 2024 11:10:41 -0400
Subject: [PATCH] AMDGPU: Add missing gfx* generic targets handling i
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Konstantin Zhuravlyov (kzhuravl)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/94483.diff
5 Files Affected:
- (modified) clang/include/clang/Basic/Cuda.h (+5)
- (modified) clang/lib/Basic/Cuda.cpp (+5)
- (m
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Konstantin Zhuravlyov (kzhuravl)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/94483.diff
5 Files Affected:
- (modified) clang/include/clang/Basic/Cuda.h (+5)
- (modified) clang/lib/Basic/Cuda.cpp (+5)
- (modified)
https://github.com/tmatheson-arm approved this pull request.
LGTM. The main change to point out is that the target attribute will no longer
accept internal feature names. I don't think it should ever have done so, but
we should get input from others. @davemgreen? There are references to existin
https://github.com/tmatheson-arm edited
https://github.com/llvm/llvm-project/pull/94279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13665,9 +13665,9 @@ QualType
ASTContext::getCorrespondingSignedFixedPointType(QualType Ty) const {
}
// Given a list of FMV features, add each of their backend features to the
list.
tmatheson-arm wrote:
```suggestion
// Given a list of FMV features, ret
@@ -48,5 +48,5 @@ int test_versions() {
return code();
}
// CHECK: attributes #0 = { noinline nounwind optnone
"no-trapping-math"="true" "stack-protector-buffer-size"="8" }
-// CHECK: attributes #1 = { noinline nounwind optnone
"no-trapping-math"="true" "stack-protector-b
@@ -121,6 +121,11 @@ enum class CudaArch {
GFX1151,
GFX1200,
GFX1201,
+ GFX9_GENERIC,
shiltian wrote:
I think you might want to group them with corresponding non-generic targets
such that we can directly use `>=` and `<=` to compare if a GFX version fa
jansvoboda11 wrote:
> > You can have a project that has both C and C++ implementation files that
> > end up including the same header files from the C standard library. One can
> > be compiled under C11 (without separator support), the other under C++14
> > (with separator support).
>
> Thank
https://github.com/pdherbemont updated
https://github.com/llvm/llvm-project/pull/94216
>From bb2effbaf8e06ae933791d8533c006a6db3aadc9 Mon Sep 17 00:00:00 2001
From: Pierre d'Herbemont
Date: Wed, 29 May 2024 11:11:03 +0200
Subject: [PATCH] Support [[guarded_by(mutex)]] and friends attributes ins
rapidsna wrote:
> > You may also want to consider making the attribute late parsed in C when
> > `-fexperimental-late-parse-attributes` is enabled. See
> > https://github.com/llvm/llvm-project/pull/93121/files#diff-ae2ec9524bdbeea1f06917607482634dd89af5bcbb929805032463e5dafe79e7R2260
> > That w
https://github.com/nishithshah2211 created
https://github.com/llvm/llvm-project/pull/94488
…er (#93753)"
This reverts commit 9862080b1cbf685c0d462b29596e3f7206d24aa2.
>From 3bc45673476ae4fbd1166a2d6bff240077104f5e Mon Sep 17 00:00:00 2001
From: Nishith Shah
Date: Tue, 4 Jun 2024 09:47:55 -070
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/92600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nishith Kumar M Shah (nishithshah2211)
Changes
…er (#93753)"
This reverts commit 9862080b1cbf685c0d462b29596e3f7206d24aa2.
---
Full diff: https://github.com/llvm/llvm-project/pull/94488.diff
8 Files Affected:
- (modified) clang/include
nishithshah2211 wrote:
Here is the revert PR: https://github.com/llvm/llvm-project/pull/94488
https://github.com/llvm/llvm-project/pull/93753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/jansvoboda11 approved this pull request.
https://github.com/llvm/llvm-project/pull/94488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -118,6 +124,37 @@ llvm::Type *CodeGenTypes::ConvertTypeForMem(QualType T,
bool ForBitField) {
return R;
}
+bool CodeGenTypes::LLVMTypeLayoutMatchesAST(QualType ASTTy,
+llvm::Type *LLVMTy) {
+ CharUnits ASTSize = Context.getTyp
https://github.com/pdherbemont updated
https://github.com/llvm/llvm-project/pull/94216
>From 0f7d369ac81fd9523e90404c6b863baaf1f6afd9 Mon Sep 17 00:00:00 2001
From: Pierre d'Herbemont
Date: Wed, 29 May 2024 11:11:03 +0200
Subject: [PATCH] Support [[guarded_by(mutex)]] and friends attributes ins
pdherbemont wrote:
> `-fexperimental-late-parse-attributes`
Done
> > > You may also want to consider making the attribute late parsed in C when
> > > `-fexperimental-late-parse-attributes` is enabled. See
> > > https://github.com/llvm/llvm-project/pull/93121/files#diff-ae2ec9524bdbeea1f069176
https://github.com/AlexMaclean updated
https://github.com/llvm/llvm-project/pull/94422
>From 708374e03f1bf70006f2472f19edad1bd621e2d6 Mon Sep 17 00:00:00 2001
From: Alex MacLean
Date: Mon, 3 Jun 2024 16:46:36 +
Subject: [PATCH] [NVPTX] Revamp NVVMIntrRange pass
---
clang/test/CodeGenCUDA/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 50d837e3019136aa42a73c06dd117fe6ca8cf148
91706032a89c11861c073c33aebf0a37fee5bfb2 --
https://github.com/ldionne approved this pull request.
This patch isn't blocked by libc++, thanks for fixing the incorrect usage. This
isn't a review of the patch itself, just unblocking for libcxx-reviewers.
https://github.com/llvm/llvm-project/pull/92957
__
@@ -193,3 +193,8 @@ Options
When `true`, the check will warn on an expression like
``sizeof(expr)`` where the expression is a pointer
to aggregate. Default is `true`.
+
+.. option:: WarnOnSizeOfPointer
+
+ When `true`, the check will warn on an expression like ``size
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/94356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
+- LGTM, except nits.
https://github.com/llvm/llvm-project/pull/94356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -292,11 +318,17 @@ void SizeofExpressionCheck::check(const
MatchFinder::MatchResult &Result) {
diag(E->getBeginLoc(),
"suspicious usage of 'sizeof(char*)'; do you mean 'strlen'?")
<< E->getSourceRange();
- } else if (const auto *E =
- R
@@ -193,3 +193,8 @@ Options
When `true`, the check will warn on an expression like
``sizeof(expr)`` where the expression is a pointer
to aggregate. Default is `true`.
+
+.. option:: WarnOnSizeOfPointer
+
+ When `true`, the check will warn on an expression like ``size
AtariDreams wrote:
@jroelofs on a slight tangent, when do we get to add information on the M4 chip?
https://github.com/llvm/llvm-project/pull/92600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
wxz2020 wrote:
Any more comments? Otherwise, we will move forward. Thanks,
https://github.com/llvm/llvm-project/pull/91022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kzhuravl updated
https://github.com/llvm/llvm-project/pull/94483
>From 7d64f16e9bdc6b9a195a332a49e5fb9954d5f7c1 Mon Sep 17 00:00:00 2001
From: Konstantin Zhuravlyov
Date: Wed, 5 Jun 2024 11:10:41 -0400
Subject: [PATCH 1/2] AMDGPU: Add missing gfx* generic targets handling in
@@ -121,6 +121,11 @@ enum class CudaArch {
GFX1151,
GFX1200,
GFX1201,
+ GFX9_GENERIC,
kzhuravl wrote:
Done.
https://github.com/llvm/llvm-project/pull/94483
___
cfe-commits mailing list
cfe-commits@lists.llvm.
vgvassilev wrote:
Oh, we need to adjust
https://github.com/root-project/root/blob/be5d34934de883270683030b3af2cd1195d17ea8/cmake/modules/RootMacros.cmake#L272
to skip in case of C++...
https://github.com/llvm/llvm-project/pull/94471
___
cfe-commits m
https://github.com/shiltian approved this pull request.
https://github.com/llvm/llvm-project/pull/94483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Konstantin Zhuravlyov
Date: 2024-06-05T11:57:17-04:00
New Revision: 2bfa26d30fb96d77e73be7876d12dd23e768f809
URL:
https://github.com/llvm/llvm-project/commit/2bfa26d30fb96d77e73be7876d12dd23e768f809
DIFF:
https://github.com/llvm/llvm-project/commit/2bfa26d30fb96d77e73be7876d12dd23e768f8
https://github.com/kzhuravl closed
https://github.com/llvm/llvm-project/pull/94483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1509,6 +1511,11 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList
&Args,
AddLinkSanitizerLibArgs(Args, CmdArgs, "asan");
}
cjappl wrote:
Thanks for catching this! Added a few basic ones that test that the flag is
supported, and that s
NagyDonat wrote:
I analyzed several open source project with this check to observe the effects
of my commit and I was (pleasantly?) surprised to see that it detected some
ugly errors (despite the fact that the inputs are stable open source
projects...).
The following table compares the "old"
@@ -8287,6 +8289,13 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI,
SDValue InGlue;
if (RequiresSMChange) {
+
+if (Subtarget->hasSVE()) {
sdesmalen-arm wrote:
@efriedma-quic I think the issue is that when we emit unwind info that is _not_
https://github.com/balazske commented:
It looks relatively good, I found only smaller issues.
https://github.com/llvm/llvm-project/pull/93408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/balazske edited
https://github.com/llvm/llvm-project/pull/93408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -907,6 +945,73 @@ void StreamChecker::preWrite(const FnDescription *Desc,
const CallEvent &Call,
C.addTransition(State);
}
+static std::optional getPointeeType(const MemRegion *R) {
+ if (!R)
+return std::nullopt;
+ if (const auto *ER = dyn_cast(R))
+return ER-
@@ -0,0 +1,412 @@
+// RUN: %clang_analyze_cc1 -verify %s \
+// RUN: -triple x86_64-linux-gnu \
+// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \
+// RUN: -analyzer-checker=debug.ExprInspection
+
+#include "Inputs/system-header-simulator-for-simple-stream.h"
@@ -0,0 +1,412 @@
+// RUN: %clang_analyze_cc1 -verify %s \
+// RUN: -triple x86_64-linux-gnu \
+// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \
+// RUN: -analyzer-checker=debug.ExprInspection
+
+#include "Inputs/system-header-simulator-for-simple-stream.h"
@@ -907,6 +945,73 @@ void StreamChecker::preWrite(const FnDescription *Desc,
const CallEvent &Call,
C.addTransition(State);
}
+static std::optional getPointeeType(const MemRegion *R) {
+ if (!R)
+return std::nullopt;
+ if (const auto *ER = dyn_cast(R))
+return ER-
@@ -0,0 +1,412 @@
+// RUN: %clang_analyze_cc1 -verify %s \
+// RUN: -triple x86_64-linux-gnu \
+// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \
+// RUN: -analyzer-checker=debug.ExprInspection
+
+#include "Inputs/system-header-simulator-for-simple-stream.h"
@@ -0,0 +1,412 @@
+// RUN: %clang_analyze_cc1 -verify %s \
+// RUN: -triple x86_64-linux-gnu \
+// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \
+// RUN: -analyzer-checker=debug.ExprInspection
+
+#include "Inputs/system-header-simulator-for-simple-stream.h"
@@ -0,0 +1,412 @@
+// RUN: %clang_analyze_cc1 -verify %s \
+// RUN: -triple x86_64-linux-gnu \
+// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \
+// RUN: -analyzer-checker=debug.ExprInspection
+
+#include "Inputs/system-header-simulator-for-simple-stream.h"
https://github.com/rapidsna approved this pull request.
LGTM assuming you will be fixing the buildkite failures.
You may still need to wait on @AaronBallman's approval.
https://github.com/llvm/llvm-project/pull/94216
___
cfe-commits mailing list
cfe
@@ -1,4 +1,5 @@
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
+; RUN: llc -O0 -mtriple=spirv64-amd-amdhsa %s -o - | FileCheck %s
AlexVlx wrote:
I've rolled back most of these, except for a couple of places where there is a
substantive d
https://github.com/labrinea updated
https://github.com/llvm/llvm-project/pull/94279
>From a413428bb0fdcd45b4a251e385b6cc00ff6a0a2c Mon Sep 17 00:00:00 2001
From: Alexandros Lamprineas
Date: Mon, 3 Jun 2024 19:57:49 +0100
Subject: [PATCH 1/4] [AArch64] Decouple feature dependency expansion.
The
@@ -1110,23 +1071,26 @@ ParsedTargetAttr
AArch64TargetInfo::parseTargetAttr(StringRef Features) const {
bool FoundArch = false;
auto SplitAndAddFeatures = [](StringRef FeatString,
-std::vector &Features) {
+s
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/94279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70306
>From 471d7a14b6475c4d06365b01ac35847276a464ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Wed, 25 Oct 2023 08:33:30 +0200
Subject: [PATCH] [clang][Interp] Implement dynamic memory allocat
tbaederr wrote:
Rebased and updated with a lot more tests.
https://github.com/llvm/llvm-project/pull/70306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/76893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yxsamliu wrote:
> Ping.
You situation is similar to overloading resolution of functions called in
global variable initializer. You may consider using a similar approach as
https://reviews.llvm.org/D158247
https://github.com/llvm/llvm-project/pull/93546
Author: Andrey Portnoy
Date: 2024-06-05T10:09:24-07:00
New Revision: 8407779bb7256c320f75913edf07c20c4e4c370a
URL:
https://github.com/llvm/llvm-project/commit/8407779bb7256c320f75913edf07c20c4e4c370a
DIFF:
https://github.com/llvm/llvm-project/commit/8407779bb7256c320f75913edf07c20c4e4c370a.diff
https://github.com/Artem-B closed
https://github.com/llvm/llvm-project/pull/94113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein wrote:
> Oh, we need to adjust
> https://github.com/root-project/root/blob/be5d34934de883270683030b3af2cd1195d17ea8/cmake/modules/RootMacros.cmake#L272
> to skip in case of C++...
The link points to an irrelevant project, I assume you mean here
https://github.com/llvm/llvm-project/blob
@@ -1,4 +1,5 @@
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
+; RUN: llc -O0 -mtriple=spirv64-amd-amdhsa %s -o - | FileCheck %s
michalpaszkowski wrote:
I am okay with either approach. I think we can assume that the core
functionality w
https://github.com/davemgreen commented:
> LGTM. The main change to point out is that the target attribute will no
> longer accept internal feature names. I don't think it should ever have done
> so, but we should get input from others. @davemgreen? There are references to
> existing code in [
@@ -118,6 +124,37 @@ llvm::Type *CodeGenTypes::ConvertTypeForMem(QualType T,
bool ForBitField) {
return R;
}
+bool CodeGenTypes::LLVMTypeLayoutMatchesAST(QualType ASTTy,
+llvm::Type *LLVMTy) {
+ CharUnits ASTSize = Context.getTyp
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/94508
Match TAPI behavior and allow input headers to be resolved via a passed
directory, which is expected to be a library sitting in a build directory.
>From c547d990aca29ecfe6f51d37c5c3f8712dfc5e44 Mon Sep 17 00
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
Match TAPI behavior and allow input headers to be resolved via a passed
directory, which is expected to be a library sitting in a build directory.
---
Patch is 34.57 KiB, truncated to 20.00 KiB below, f
@@ -4656,14 +4656,14 @@ static void InitCatchParam(CodeGenFunction &CGF,
auto catchRD = CatchType->getAsCXXRecordDecl();
CharUnits caughtExnAlignment = CGF.CGM.getClassPointerAlignment(catchRD);
- llvm::Type *PtrTy = CGF.UnqualPtrTy; // addrspace 0 ok
ari
@@ -51,9 +51,11 @@ struct CodeGenTypeCache {
llvm::IntegerType *PtrDiffTy;
};
+ /// unqualified void*
+ llvm::PointerType *UnqualPtrTy;
arichardson wrote:
I'd argue we should just remove this variable, and the few cases that actually
want AS0 can cal
nishithshah2211 wrote:
@jansvoboda11 - please merge this revert in when you get a chance, thanks!
https://github.com/llvm/llvm-project/pull/94488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/arichardson commented:
Commit title needs updating to only refer to used metadata. A few wording
suggestions inline.
https://github.com/llvm/llvm-project/pull/93601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/93601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2922,18 +2922,21 @@ static void emitUsed(CodeGenModule &CGM, StringRef Name,
if (List.empty())
return;
+ // We unconditionally use unqualified pointers - this is intentional as these
arichardson wrote:
```suggestion
// We unconditionally use AS0
@@ -8642,8 +8642,9 @@ The '``llvm.used``' Global Variable
The ``@llvm.used`` global is an array which has
:ref:`appending linkage `. This array contains a list of
pointers to named global variables, functions and aliases which may optionally
-have a pointer cast formed of bitca
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/93601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2047,9 +2047,9 @@ void CodeGenModule::EmitCtorList(CtorList &Fns, const
char *GlobalName) {
llvm::Type *CtorPFTy = llvm::PointerType::get(CtorFTy,
TheModule.getDataLayout().getProgramAddressSpace());
- // Get the type of a ctor entry, { i32, void ()*, i8* }.
+ /
https://github.com/yuxuanchen1997 created
https://github.com/llvm/llvm-project/pull/94511
This code uses two namespaces, `llvm` and `llvm::json`. However, we have both
`llvm::Value` and `llvm::json::Value`. Whenever any of the headers declare or
include `llvm::Value`, the lookup becomes ambigu
101 - 200 of 472 matches
Mail list logo
