https://github.com/tmatheson-arm approved this pull request.
LGTM. The main change to point out is that the target attribute will no longer accept internal feature names. I don't think it should ever have done so, but we should get input from others. @davemgreen? There are references to existing code in [D137617](https://reviews.llvm.org/D137617) but no details. If this has been used for e.g. intrinsics definitions, I am surprised there are not more test failures. https://github.com/llvm/llvm-project/pull/94279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
