https://github.com/AaronBallman approved this pull request.
LGTM! Thank you!
https://github.com/llvm/llvm-project/pull/94118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/94118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -999,6 +1001,8 @@ class Sema;
/// Initialization of an object of class type by constructor,
/// using either a parenthesized or braced list of arguments.
CSK_InitByConstructor,
+
+ CSK_AddressOfOverloadSet,
AaronBallman wrote:
Please
@@ -5813,6 +5813,27 @@ static TypoCorrection TryTypoCorrectionForCall(Sema &S,
Expr *Fn,
return TypoCorrection();
}
+// [C++26][[expr.unary.op]/p4
+// A pointer to member is only formed when an explicit &
+// is used and its operand is a qualified-id not enclosed in parenth
@@ -899,6 +899,8 @@ class Sema;
/// object argument.
bool IgnoreObjectArgument : 1;
+bool TookAddressOfOverload : 1;
AaronBallman wrote:
CC @Endilll -- it might be nice to refactor this code to use
`LLVM_PREFERRED_TYPE`, but also to fix the bit-f
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/93966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/93966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
adrian-prantl wrote:
> A revert is not appropriate when:
> lldb tests fail because AST printing has changed in Clang and the printed
> output is valid
Following the logic in this argument, would you also say it's appropriate for
someone to commit an LLVM patch that changes how textual LLVM IR
https://github.com/banach-space approved this pull request.
https://github.com/llvm/llvm-project/pull/94359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/momchil-velikov approved this pull request.
https://github.com/llvm/llvm-project/pull/88710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/momchil-velikov approved this pull request.
https://github.com/llvm/llvm-project/pull/88499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -103,30 +110,220 @@ static cl::opt
ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden,
cl::desc("Dump IR after transformation happens"));
+// This option is meant to be used by LLVM regression test and test the
+// transformation that compares vt
@@ -103,30 +110,220 @@ static cl::opt
ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden,
cl::desc("Dump IR after transformation happens"));
+// This option is meant to be used by LLVM regression test and test the
+// transformation that compares vt
@@ -103,30 +110,220 @@ static cl::opt
ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden,
cl::desc("Dump IR after transformation happens"));
+// This option is meant to be used by LLVM regression test and test the
+// transformation that compares vt
https://github.com/teresajohnson edited
https://github.com/llvm/llvm-project/pull/81442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/teresajohnson commented:
I haven't looked at the tests yet, but some comments/questions from a first
pass through most of the code
https://github.com/llvm/llvm-project/pull/81442
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
@@ -276,35 +585,151 @@ CallBase &llvm::pgo::promoteIndirectCall(CallBase &CB,
Function *DirectCallee,
// Promote indirect-call to conditional direct-call for one callsite.
bool IndirectCallPromoter::tryToPromoteWithFuncCmp(
-CallBase &CB, const std::vector &Candidates,
-
@@ -276,35 +585,151 @@ CallBase &llvm::pgo::promoteIndirectCall(CallBase &CB,
Function *DirectCallee,
// Promote indirect-call to conditional direct-call for one callsite.
bool IndirectCallPromoter::tryToPromoteWithFuncCmp(
-CallBase &CB, const std::vector &Candidates,
-
@@ -103,30 +110,222 @@ static cl::opt
ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden,
cl::desc("Dump IR after transformation happens"));
+// This option is meant to be used by LLVM regression test and test the
+// transformation that compares vt
@@ -341,6 +879,17 @@ static bool promoteIndirectCalls(Module &M,
ProfileSummaryInfo *PSI, bool InLTO,
return false;
}
bool Changed = false;
+ VirtualCallSiteTypeInfoMap VirtualCSInfo;
+
+ computeVirtualCallSiteTypeInfoMap(M, MAM, VirtualCSInfo);
+
+ // This map reco
@@ -140,14 +337,51 @@ class IndirectCallPromoter {
// indirect callee with functions. Returns true if there are IR
// transformations and false otherwise.
bool tryToPromoteWithFuncCmp(
- CallBase &CB, const std::vector &Candidates,
- uint64_t TotalCount, ArrayRe
@@ -103,30 +110,220 @@ static cl::opt
ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden,
cl::desc("Dump IR after transformation happens"));
+// This option is meant to be used by LLVM regression test and test the
+// transformation that compares vt
@@ -103,30 +110,220 @@ static cl::opt
ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden,
cl::desc("Dump IR after transformation happens"));
+// This option is meant to be used by LLVM regression test and test the
+// transformation that compares vt
@@ -321,14 +746,127 @@ bool
IndirectCallPromoter::processFunction(ProfileSummaryInfo *PSI) {
if (!NumCandidates ||
(PSI && PSI->hasProfileSummary() && !PSI->isHotCount(TotalCount)))
continue;
+
auto PromotionCandidates = getPromotionCandidatesForCallSite
@@ -140,14 +337,51 @@ class IndirectCallPromoter {
// indirect callee with functions. Returns true if there are IR
// transformations and false otherwise.
bool tryToPromoteWithFuncCmp(
- CallBase &CB, const std::vector &Candidates,
- uint64_t TotalCount, ArrayRe
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/92031
>From ac5aeb5c3a134d085320fc7fc5cf3f2c8c41a1f1 Mon Sep 17 00:00:00 2001
From: ziqingluo-90
Date: Mon, 13 May 2024 13:31:21 -0700
Subject: [PATCH 1/4] fix safe buffer opt-out region serialization
---
clang/
AaronBallman wrote:
> Following the logic in this argument, would you also say it's appropriate for
> someone to commit an LLVM patch that changes how textual LLVM IR is printed
> in a way that it breaks existing tests in Clang — without updating those
> tests?
Possibly! I'm talking about rel
https://github.com/sayhaan created
https://github.com/llvm/llvm-project/pull/94405
Create a new class and file for functions that update GDB index.
>From f3533c92b6b64f50a933a9eb2f9cc4229bbd8da3 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Tue, 1 Jun 2021 11:37:41 -0700
Subject: [PATCH 1/7
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Sayhaan Siddiqui (sayhaan)
Changes
Create a new class and file for functions that update GDB index.
---
Patch is 40.93 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/94405.diff
24 Files Affect
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sayhaan Siddiqui (sayhaan)
Changes
Create a new class and file for functions that update GDB index.
---
Patch is 40.93 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/94405.diff
24 Files Affec
https://github.com/sayhaan updated
https://github.com/llvm/llvm-project/pull/94405
>From f3533c92b6b64f50a933a9eb2f9cc4229bbd8da3 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Tue, 1 Jun 2021 11:37:41 -0700
Subject: [PATCH 1/2] Rebase: [Facebook] Add clang driver options to test debug
info
ziqingluo-90 wrote:
Learned more about how loaded files & ASTs are managed in clang. Now opt-out
regions in a loaded AST can span over multiple files (within one TU). They now
behave in a consistent way when they are from loaded files or local files.
https://github.com/llvm/llvm-project/pul
https://github.com/ziqingluo-90 edited
https://github.com/llvm/llvm-project/pull/92031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/93783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -826,6 +826,10 @@ SanitizerMask Linux::getSupportedSanitizers() const {
if (IsX86_64 || IsAArch64) {
Res |= SanitizerKind::KernelHWAddress;
}
+ if (IsX86_64) {
+Res |= SanitizerKind::NumericalStability;
MaskRay wrote:
drop braces for single-lin
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/93783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -826,6 +826,10 @@ SanitizerMask Linux::getSupportedSanitizers() const {
if (IsX86_64 || IsAArch64) {
Res |= SanitizerKind::KernelHWAddress;
}
+ if (IsX86_64) {
+Res |= SanitizerKind::NumericalStability;
MaskRay wrote:
This needs a `fsanitize-*.
https://github.com/akshaykumars614 created
https://github.com/llvm/llvm-project/pull/94408
modified parameter for code quality
>From a018f2598f860498711cc46dcb41916d11127f15 Mon Sep 17 00:00:00 2001
From: akshaykumars614
Date: Tue, 4 Jun 2024 18:59:05 -0400
Subject: [PATCH] clang/utils/TableG
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (akshaykumars614)
Changes
modified parameter for code quality
---
Full diff: https://github.com/llvm/llvm-project/pull/94408.diff
1 Files Affected:
- (modified) clang/utils/TableGen/NeonEmitter.cpp (+1-1)
``diff
diff --
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0360d03240f59e6b26a16769943f905c9520fe04
a018f2598f860498711cc46dcb41916d11127f15 --
https://github.com/akshaykumars614 updated
https://github.com/llvm/llvm-project/pull/94408
>From a018f2598f860498711cc46dcb41916d11127f15 Mon Sep 17 00:00:00 2001
From: akshaykumars614
Date: Tue, 4 Jun 2024 18:59:05 -0400
Subject: [PATCH 1/2] clang/utils/TableGen/NeonEmitter.cpp:1058: pointless
https://github.com/akshaykumars614 created
https://github.com/llvm/llvm-project/pull/94413
modified parameter for code quality
>From d07d360dcb00a4e6710c177b79ca4d76a5a863d3 Mon Sep 17 00:00:00 2001
From: akshaykumars614
Date: Tue, 4 Jun 2024 19:21:25 -0400
Subject: [PATCH] clang/utils/TableGe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (akshaykumars614)
Changes
modified parameter for code quality
---
Full diff: https://github.com/llvm/llvm-project/pull/94413.diff
1 Files Affected:
- (modified) clang/utils/TableGen/ClangOptionDocEmitter.cpp (+1-1)
``dif
https://github.com/akshaykumars614 created
https://github.com/llvm/llvm-project/pull/94414
modified parameter for code quality
>From f4dd886d3a33401865f03a4ca086f6f1f0332293 Mon Sep 17 00:00:00 2001
From: akshaykumars614
Date: Tue, 4 Jun 2024 19:25:10 -0400
Subject: [PATCH] clang/utils/TableGe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (akshaykumars614)
Changes
modified parameter for code quality
---
Full diff: https://github.com/llvm/llvm-project/pull/94414.diff
1 Files Affected:
- (modified) clang/utils/TableGen/ClangAttrEmitter.cpp (+3-3)
``diff
dif
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/93760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat edited
https://github.com/llvm/llvm-project/pull/94318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/4vtomat edited
https://github.com/llvm/llvm-project/pull/94318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
4vtomat wrote:
> Could you give few more word on the description to mention we missed that in
> the vector crpyto intrinsic proposal, and it's fixing but rather than
> incompatible/breaking change for the intrinsic API?
Updated description. We are missing `vcpop.v` in the rvv_intrinsic_doc, so
https://github.com/kito-cheng approved this pull request.
https://github.com/llvm/llvm-project/pull/94318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -298,15 +298,15 @@
// FioRACE2: "-E"
// FioRACE2: "-o" "foo.x"
-// RUN: %clang_cl /Z7 /Foa.obj -### -- %s 2>&1 | FileCheck
-check-prefix=ABSOLUTE_OBJPATH %s
+// RUN: %clang_cl -target x86_64-windows /Z7 /Foa.obj -### -- %s 2>&1 |
FileCheck -check-prefix=ABSOLUTE_OBJPATH %
@@ -5,15 +5,15 @@
// NO_GHASH-NOT: "-gcodeview-ghash"
// default
-// RUN: %clang_cl /Z7 -### -- %s 2>&1 | FileCheck -check-prefix=NO_GHASH %s
+// RUN: %clang_cl -target x86_64-windows /Z7 -### -- %s 2>&1 | FileCheck
-check-prefix=NO_GHASH %s
// enabled
-// RUN: %clang_cl /Z7
vitalybuka wrote:
If you want another round, make sure to click `re-request review`
https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1509,6 +1511,11 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList
&Args,
AddLinkSanitizerLibArgs(Args, CmdArgs, "asan");
}
vitalybuka wrote:
Driver needs tests
https://github.com/llvm/llvm-project/pull/92460
__
Author: Phoebe Wang
Date: 2024-06-05T09:56:08+08:00
New Revision: 99b2581a4b162b718925b791433faaa108745a90
URL:
https://github.com/llvm/llvm-project/commit/99b2581a4b162b718925b791433faaa108745a90
DIFF:
https://github.com/llvm/llvm-project/commit/99b2581a4b162b718925b791433faaa108745a90.diff
L
https://github.com/phoebewang closed
https://github.com/llvm/llvm-project/pull/88245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
owenca wrote:
> @owenca Re. draft status: I thought a draft would be a better way (less
> presumptuous, more tentative suggestion) to present one particular solution,
> while acknowledging the possibility of alternatives. If that's not really the
> way a draft is used or if it's more of a prob
Author: Kareem Ergawy
Date: 2024-06-05T05:13:47+02:00
New Revision: 7db4e6c1ec18785ad3f622556362d83c11d7efef
URL:
https://github.com/llvm/llvm-project/commit/7db4e6c1ec18785ad3f622556362d83c11d7efef
DIFF:
https://github.com/llvm/llvm-project/commit/7db4e6c1ec18785ad3f622556362d83c11d7efef.diff
https://github.com/ergawy closed https://github.com/llvm/llvm-project/pull/93920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4026,12 +4030,13 @@ Expected getStyle(StringRef StyleName,
StringRef FileName,
// Reset possible inheritance
Style.InheritsParentConfig = false;
- auto dropDiagnosticHandler = [](const llvm::SMDiagnostic &, void *) {};
+ auto diagHandlerOrDropHandling =
+ DiagH
@@ -4026,12 +4030,13 @@ Expected getStyle(StringRef StyleName,
StringRef FileName,
// Reset possible inheritance
Style.InheritsParentConfig = false;
- auto dropDiagnosticHandler = [](const llvm::SMDiagnostic &, void *) {};
+ auto diagHandlerOrDropHandling =
+ DiagH
@@ -3945,20 +3945,23 @@ const char *DefaultFallbackStyle = "LLVM";
llvm::ErrorOr>
loadAndParseConfigFile(StringRef ConfigFile, llvm::vfs::FileSystem *FS,
- FormatStyle *Style, bool AllowUnknownOptions) {
+ FormatStyle *Style, bool Al
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/94425
Fixes #94326.
>From 7e4c3e6b5b77085f795d6ccdfbf7279e32741b16 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 4 Jun 2024 21:10:14 -0700
Subject: [PATCH] [clang-format] Don't format comments in
SkipMacroDefinit
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #94326.
---
Full diff: https://github.com/llvm/llvm-project/pull/94425.diff
2 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+3-3)
- (modified) clang/unittests/Format/Forma
efriedma-quic wrote:
llvm::PointerType::getUnqual assumes pointers to addr-space 0 are
"unqualified"... but the discussion on #88182 concluded that doesn't make
sense: the "unqualified" address space is a target-specific choice, and
address-space zero isn't required to have any meaning at all.
jrtc27 wrote:
I think the point is there are two things going on here that people think of as
unqualified:
1. "Give me a pointer that's whatever `void *` is"
2. "Give me a pointer in some address space just so I can put a global in some
metadata"
The vast majority of the time we're talking abou
chrisnc wrote:
Ping
https://github.com/llvm/llvm-project/pull/91870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/94425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/93966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spavloff wrote:
The discussion for the proposed mechanism is open here:
https://discourse.llvm.org/t/rfc-calling-functions-if-pragma-fenv-round-is-present/79372
> > This change introduces macro ROUNDING_MODE, which is a string dependent on
> > the constant rounding mode
>
> It expands to an id
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/PiotrZSL approved this pull request.
I accept this change as it's fine for 1.0 version
Any fixed can be always done in this or new change.
https://github.com/llvm/llvm-project/pull/90830
___
cfe-commits mailing list
cfe-commits@lists
301 - 373 of 373 matches
Mail list logo
