https://github.com/akshaykumars614 created https://github.com/llvm/llvm-project/pull/94413
modified parameter for code quality >From d07d360dcb00a4e6710c177b79ca4d76a5a863d3 Mon Sep 17 00:00:00 2001 From: akshaykumars614 <akshaykumars...@gmail.com> Date: Tue, 4 Jun 2024 19:21:25 -0400 Subject: [PATCH] clang/utils/TableGen/ClangOptionDocEmitter.cpp:220: Pointless string copy ? (#94373) modified parameter for code quality --- clang/utils/TableGen/ClangOptionDocEmitter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/utils/TableGen/ClangOptionDocEmitter.cpp b/clang/utils/TableGen/ClangOptionDocEmitter.cpp index 86835611b8421..d0cb7f203c231 100644 --- a/clang/utils/TableGen/ClangOptionDocEmitter.cpp +++ b/clang/utils/TableGen/ClangOptionDocEmitter.cpp @@ -217,7 +217,7 @@ bool canSphinxCopeWithOption(const Record *Option) { return false; } -void emitHeading(int Depth, std::string Heading, raw_ostream &OS) { +void emitHeading(int Depth, const std::string &Heading, raw_ostream &OS) { assert(Depth < 8 && "groups nested too deeply"); OS << Heading << '\n' << std::string(Heading.size(), "=~-_'+<>"[Depth]) << "\n"; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits