[clang] [Clang][Sema] Remove unused function after #88731 (PR #89618)

2024-04-22 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/89618 Removes an unused static function `IsOverloaded` from `SemaOverload.cpp` that is unused after #88731. >From b0dcd5b85d4945530abb8209d8069e5fca65eb72 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: M

[clang] Implementation of '#pragma STDC FENV_ROUND' (PR #89617)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Serge Pavlov (spavloff) Changes This pragma is introduced by forthcoming C2x standard and can be used to set particular rounding mode without need to call 'fesetmode' or accessing control mode registers directly. Previously this p

[clang] [Clang][Sema] Remove unused function after #88731 (PR #89618)

2024-04-22 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/89618 >From ab5add6546306348079041d977735fdac44e5724 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 22 Apr 2024 11:57:18 -0400 Subject: [PATCH] [Clang][Sema] Remove unused function after #88731 ---

[clang] [Clang][Sema] Remove unused function after #88731 (PR #89618)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes Removes an unused static function `IsOverloaded` from `SemaOverload.cpp` that is unused after #88731. --- Full diff: https://github.com/llvm/llvm-project/pull/89618.diff 1 Files Affected: - (mod

[clang] 947cd67 - [C23] Select the correct promoted type for a bit-field (#89254)

2024-04-22 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-04-22T11:59:54-04:00 New Revision: 947cd677083d69412b5a900d8fad59e3062c4875 URL: https://github.com/llvm/llvm-project/commit/947cd677083d69412b5a900d8fad59e3062c4875 DIFF: https://github.com/llvm/llvm-project/commit/947cd677083d69412b5a900d8fad59e3062c4875.diff

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/89254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implementation of '#pragma STDC FENV_ROUND' (PR #89617)

2024-04-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 37b7207651b44743909a427b5509bed5e6c21b59 58adf3643828272d071fd49195cfcf0b2164eb70 --

[clang] [Clang][Sema] Remove unused function after #88731 (PR #89618)

2024-04-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you for catching that! https://github.com/llvm/llvm-project/pull/89618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] 7c581b5 - [Clang][Sema] Remove unused function after #88731 (#89618)

2024-04-22 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-04-22T12:04:13-04:00 New Revision: 7c581b554efa7c720b780f721877107ae0fc78ff URL: https://github.com/llvm/llvm-project/commit/7c581b554efa7c720b780f721877107ae0fc78ff DIFF: https://github.com/llvm/llvm-project/commit/7c581b554efa7c720b780f721877107ae0fc78ff

[clang] [Clang][Sema] Remove unused function after #88731 (PR #89618)

2024-04-22 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/89618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++17] Support __GCC_[CON|DE]STRUCTIVE_SIZE (PR #89446)

2024-04-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > For SystemZ the correct value is 256. > > > > > > Thanks! Double-checking: for both constructive and destructive? > > Yes, for both. Every SystemZ model (supported by GCC/LLVM) has a L1 cache > line size of 256 bytes. Excellent, thank you! > > > In general I agree

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: > @Xazax-hun WDYT? If it really takes over an hour to analyze a file in clang-18, I'd agree that this has similar severity to a crash, and I support backporting the fix. https://github.com/llvm/llvm-project/pull/89606 ___ cfe-commit

[clang] [Clang] Diagnose apply AST consume actions on LLVM IR (PR #88602)

2024-04-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! > I still have some questions, should we give tips to the user that which > options cannot apply on LLVM IR files? I think the diagnostic you've got is reasonable -- these options are CC1 options which are not something we typi

[clang] Implementation of '#pragma STDC FENV_ROUND' (PR #89617)

2024-04-22 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff updated https://github.com/llvm/llvm-project/pull/89617 >From fc7aab600c25b39b2df039c0cbcf517719736311 Mon Sep 17 00:00:00 2001 From: Serge Pavlov Date: Thu, 14 Apr 2022 18:00:14 +0700 Subject: [PATCH] Implementation of '#pragma STDC FENV_ROUND' This pragma is intro

[clang] [Clang] Diagnose apply AST consume actions on LLVM IR (PR #88602)

2024-04-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. https://github.com/llvm/llvm-project/pull/88602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Show struct fields and enum members in hovers (PR #89557)

2024-04-22 Thread via cfe-commits
colin-grant-work wrote: > As not all editors let you interact with hover cards, and just seeing a bunch > of field names, without any extra info, sounds suboptimal to me... I'd like > to have a way for such people to keep using hover cards without definition > eating up the whole screen estate

[clang] [clang][CoverageMapping] do not emit gap when either end is an `ImplicitValueInitExpr` (PR #89564)

2024-04-22 Thread Wentao Zhang via cfe-commits
https://github.com/whentojump updated https://github.com/llvm/llvm-project/pull/89564 >From abbdb318d62bb2e5ab6f07e7d0fe11f4a06b5a11 Mon Sep 17 00:00:00 2001 From: Wentao Zhang Date: Sun, 21 Apr 2024 21:27:01 -0500 Subject: [PATCH 1/2] [clang][CoverageMapping] do not emit gap when either end i

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-04-22 Thread via cfe-commits
js324 wrote: Any insight on why the latest commit is failing? Is it just because of the clang-format change? https://github.com/llvm/llvm-project/pull/86586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-04-22 Thread Erich Keane via cfe-commits
erichkeane wrote: At least the windows failure seems completely unrelated, it is a 'flang' build failure, likely caused by you getting 'unlucky' and the build being broken at the time. You DO have a conflict to resolve, so perhaps doing that will get you back to green. https://github.com/llv

[clang] [Clang][Parser] Don't always destroy template annotations at the end of a declaration (PR #89494)

2024-04-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > My feeling is that it's not worth the complexity. Getting an accurate > benchmak would be difficult, it would only manifest in extremely templated > code I wonder if @AaronBallman has opinion. I think the complexity may be worth it -- FWIW, this originally came from http

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/89441 >From 9165d6086e2570198fba1c333d0c9cb9c09037c7 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 19 Apr 2024 12:13:06 -0700 Subject: [PATCH 1/2] [clang][modules] Allow module map files with textual head

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

2024-04-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-22 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: @sam-mccall That makes sense. I think one option we have here is to consider all module maps describing a textual header that got included as affecting. I'm concerned that a long chain of textual header includes might again be problematic. For this particular test, we only

[clang] [clang][CoverageMapping] do not emit gap when either end is an `ImplicitValueInitExpr` (PR #89564)

2024-04-22 Thread Wentao Zhang via cfe-commits
https://github.com/whentojump updated https://github.com/llvm/llvm-project/pull/89564 >From abbdb318d62bb2e5ab6f07e7d0fe11f4a06b5a11 Mon Sep 17 00:00:00 2001 From: Wentao Zhang Date: Sun, 21 Apr 2024 21:27:01 -0500 Subject: [PATCH 1/4] [clang][CoverageMapping] do not emit gap when either end i

[clang] [clang][CoverageMapping] do not emit gap when either end is an `ImplicitValueInitExpr` (PR #89564)

2024-04-22 Thread Wentao Zhang via cfe-commits
https://github.com/whentojump ready_for_review https://github.com/llvm/llvm-project/pull/89564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Preserve the initializer of invalid VarDecls (PR #88645)

2024-04-22 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/88645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CoverageMapping] do not emit gap when either end is an `ImplicitValueInitExpr` (PR #89564)

2024-04-22 Thread Wentao Zhang via cfe-commits
whentojump wrote: Thanks for your suggestion! @ZequanWu Would you please take another look? https://github.com/llvm/llvm-project/pull/89564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][modules] Stop eagerly reading files with diagnostic pragmas (PR #87442)

2024-04-22 Thread via cfe-commits
alexfh wrote: > @alexfh Can you check it doesn't boil down to the same thing as the issue you > reported in https://reviews.llvm.org/D137213? Oh, that was long ago ;) And indeed, as @sam-mccall said, it turned out to be the problem of our build setup. Sorry for the noise! https://github.com/l

[clang] [llvm] [SPIRV][HLSL] map lerp to Fmix (PR #88976)

2024-04-22 Thread Farzon Lotfi via cfe-commits
@@ -58,4 +58,6 @@ let TargetPrefix = "spv" in { Intrinsic<[ llvm_ptr_ty ], [llvm_i8_ty], [IntrWillReturn]>; def int_spv_all : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty]>; def int_spv_any : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty]>; + def int_spv_lerp

[clang] c4c54af - [SPIRV][HLSL] map lerp to Fmix (#88976)

2024-04-22 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-04-22T12:40:21-04:00 New Revision: c4c54af569f7c17bc89ae73c3e5c5c4be0a586b9 URL: https://github.com/llvm/llvm-project/commit/c4c54af569f7c17bc89ae73c3e5c5c4be0a586b9 DIFF: https://github.com/llvm/llvm-project/commit/c4c54af569f7c17bc89ae73c3e5c5c4be0a586b9.diff

[clang] [llvm] [SPIRV][HLSL] map lerp to Fmix (PR #88976)

2024-04-22 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/88976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash on invalid size in user-defined `static_assert` message (PR #89420)

2024-04-22 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/89420 >From a64b08503ae9f49d8b58ee92c226ba19c450ca27 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Fri, 19 Apr 2024 19:13:26 +0200 Subject: [PATCH 1/2] [Clang] Fix crash on invalid size in static_assert message ---

[clang] b6628c2 - [Clang] Fix crash on invalid size in user-defined `static_assert` message (#89420)

2024-04-22 Thread via cfe-commits
Author: Sirraide Date: 2024-04-22T18:41:36+02:00 New Revision: b6628c24ef017138b8d6eb288e94c141e7c846b0 URL: https://github.com/llvm/llvm-project/commit/b6628c24ef017138b8d6eb288e94c141e7c846b0 DIFF: https://github.com/llvm/llvm-project/commit/b6628c24ef017138b8d6eb288e94c141e7c846b0.diff LOG:

[clang] [Clang] Fix crash on invalid size in user-defined `static_assert` message (PR #89420)

2024-04-22 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/89420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Stop eagerly reading files with diagnostic pragmas (PR #87442)

2024-04-22 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: No worries, happy to get to the bottom of it. https://github.com/llvm/llvm-project/pull/87442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++17] Support __GCC_[CON|DE]STRUCTIVE_SIZE (PR #89446)

2024-04-22 Thread via cfe-commits
cor3ntin wrote: I think it makes sense to go with this patch and let target maintainers tweak the value subsequently. It seems that trying to not provide a value unless explicitly specified by the target would be worse for library vendors as `hardware_destructive_interference_size` is specified

[clang] [Clang][Parser] Don't always destroy template annotations at the end of a declaration (PR #89494)

2024-04-22 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > One question I have is whether it would make sense to modify > DestroyTemplateIdAnnotationsRAIIObj to not call MaybeDestroyTemplateIds() in > the first place I’d love to try if it were feasible, but please note that the annotation was deleted by a direct call to MaybeDestroyT

[clang] [clang-tools-extra] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > @AaronBallman See test results from compile-time-tracker here: > > > https://llvm-compile-time-tracker.com/compare.php?from=693a458287d019c5c6a66fe3019d099df2978cdb&to=dbb5e29d136a18060ba6759b328ad80fa9cea649. > > > It looks like that there is a statistically meaningful

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-22 Thread Andy Kaylor via cfe-commits
@@ -271,30 +271,32 @@ // RUN: 2>&1 | FileCheck --check-prefix=CHECK-NO-UNSAFE-MATH %s // RUN: %clang -### -funsafe-math-optimizations -fno-reciprocal-math -c %s \ -// RUN: 2>&1 | FileCheck --check-prefix=CHECK-NO-UNSAFE-MATH %s +// RUN: 2>&1 | FileCheck --check-prefix=CH

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-04-22 Thread via cfe-commits
https://github.com/js324 updated https://github.com/llvm/llvm-project/pull/86586 >From c822eaf87526567825e9c4403ae9f01dd4ff58a3 Mon Sep 17 00:00:00 2001 From: Jin S Date: Mon, 25 Mar 2024 17:19:41 -0400 Subject: [PATCH 1/2] [BitInt] Expose a _BitInt literal suffix in C++ --- clang/docs/Release

[clang] [C++17] Support __GCC_[CON|DE]STRUCTIVE_SIZE (PR #89446)

2024-04-22 Thread via cfe-commits
@@ -89,6 +89,19 @@ sections with improvements to Clang's support for those languages. C++ Language Changes +C++17 Feature Support +^ +- Clang now exposes ``__GCC_DESTRUCTIVE_SIZE`` and ``__GCC_CONSTRUCTIVE_SIZE`` + predefined macros t

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-22 Thread Andy Kaylor via cfe-commits
@@ -318,12 +320,12 @@ // RUN: %clang -### -fassociative-math -freciprocal-math -fno-signed-zeros \ // RUN: -fno-trapping-math -ftrapping-math -c %s 2>&1 \ -// RUN: | FileCheck --check-prefix=CHECK-NO-REASSOC-NO-UNSAFE-MATH %s +// RUN: | FileCheck --check-prefix=CHECK-N

[clang] [llvm] Computing, storing, and restoring conservative call graphs with LLVM (PR #80104)

2024-04-22 Thread via cfe-commits
https://github.com/Prabhuk closed https://github.com/llvm/llvm-project/pull/80104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Computing, storing, and restoring conservative call graphs with LLVM (PR #80104)

2024-04-22 Thread via cfe-commits
Prabhuk wrote: Closing this pull request as I have sent out stacked pull requests to land the patches individually. https://github.com/llvm/llvm-project/pull/80104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [AMDGPU][WIP] Add support for i64/f64 readlane, writelane and readfirstlane operations. (PR #89217)

2024-04-22 Thread Matt Arsenault via cfe-commits
@@ -4822,6 +4822,111 @@ static MachineBasicBlock *lowerWaveReduce(MachineInstr &MI, return RetBB; } +static MachineBasicBlock *lowerPseudoLaneOp(MachineInstr &MI, arsenm wrote: No, that's a generic pass. I would directly handle this in the legalizer, in S

[clang] [llvm] [AMDGPU][WIP] Add support for i64/f64 readlane, writelane and readfirstlane operations. (PR #89217)

2024-04-22 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix unittests in TargetDeclTest bucket (PR #89630)

2024-04-22 Thread via cfe-commits
https://github.com/zibi2 created https://github.com/llvm/llvm-project/pull/89630 This PR fixes the build errors for one of the `clangd` unit tests bucket similar to the following: ``` .../clang-tools-extra/clangd/unittests/FindTargetTests.cpp:430:29: error: passing no argument for the '...' pa

[clang-tools-extra] [clangd] Fix unittests in TargetDeclTest bucket (PR #89630)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: None (zibi2) Changes This PR fixes the build errors for one of the `clangd` unit tests bucket similar to the following: ``` .../clang-tools-extra/clangd/unittests/FindTargetTests.cpp:430:29: error: passing no argument for the '...' para

[clang] [Clang] Update missing varargs arg extension warnings (PR #84520)

2024-04-22 Thread via cfe-commits
zibi2 wrote: > Actually, a trailing comma in the macro invocation might work too. It’s been > a while since I last had to deal w/ this. Yes, it does and I think it's cleaner than my proposal. Thank you. https://github.com/llvm/llvm-project/pull/84520 ___

[clang-tools-extra] [clangd] Fix unittests in TargetDeclTest bucket (PR #89630)

2024-04-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 832d3a42c34eee2a6ca323ef97a1c6fe14c1f651 69c889cbc4f21194b038ea8908a412ac6ec85ea0 --

[clang-tools-extra] [clangd] Fix unittests in TargetDeclTest bucket (PR #89630)

2024-04-22 Thread via cfe-commits
https://github.com/zibi2 updated https://github.com/llvm/llvm-project/pull/89630 >From 69c889cbc4f21194b038ea8908a412ac6ec85ea0 Mon Sep 17 00:00:00 2001 From: Zibi Sarbinowski Date: Mon, 22 Apr 2024 11:41:43 -0500 Subject: [PATCH 1/2] Fix clangd unittests in TargetDeclTest bucket --- .../clang

[clang] [clang][CoverageMapping] do not emit gap when either end is an `ImplicitValueInitExpr` (PR #89564)

2024-04-22 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu approved this pull request. https://github.com/llvm/llvm-project/pull/89564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Align -ffp-model=fast denormal handling with -ffast-math (PR #89477)

2024-04-22 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > This effort is highly desirable, c.f. this [blog > post](https://moyix.blogspot.com/2022/09/someones-been-messing-with-my-subnormals.html), > so thanks for that! > > Xref: #57589, #80475, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 My patch here still leaves the pro

[clang-tools-extra] [clangd] Fix unittests in TargetDeclTest bucket (PR #89630)

2024-04-22 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM Side note: I’ve looked into this a bit, and this pattern is used rather sparingly throughout the codebase, but there is precedent for it. https://github.com/llvm/llvm-project/pull/89630 ___

[clang] 73ed215 - Carving out -Wformat warning about scoped enums into a subwarning (#88595)

2024-04-22 Thread via cfe-commits
Author: ZijunZhaoCCK Date: 2024-04-22T10:17:12-07:00 New Revision: 73ed2153beb529973741344874c0084d24c2f268 URL: https://github.com/llvm/llvm-project/commit/73ed2153beb529973741344874c0084d24c2f268 DIFF: https://github.com/llvm/llvm-project/commit/73ed2153beb529973741344874c0084d24c2f268.diff

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

2024-04-22 Thread via cfe-commits
https://github.com/ZijunZhaoCCK closed https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++17] Support __GCC_[CON|DE]STRUCTIVE_SIZE (PR #89446)

2024-04-22 Thread Aaron Ballman via cfe-commits
@@ -89,6 +89,19 @@ sections with improvements to Clang's support for those languages. C++ Language Changes +C++17 Feature Support +^ +- Clang now exposes ``__GCC_DESTRUCTIVE_SIZE`` and ``__GCC_CONSTRUCTIVE_SIZE`` + predefined macros t

[clang] [Clang][Parser] Don't always destroy template annotations at the end of a declaration (PR #89494)

2024-04-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > One question I have is whether it would make sense to modify > > DestroyTemplateIdAnnotationsRAIIObj to not call MaybeDestroyTemplateIds() > > in the first place > > I’d love to try if it were feasible, but please note that the annotation > (that is, C from the paramet

[clang] [Clang][Parser] Don't always destroy template annotations at the end of a declaration (PR #89494)

2024-04-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/89494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 180cf4d - [clangd] Fix unittests in TargetDeclTest bucket (#89630)

2024-04-22 Thread via cfe-commits
Author: zibi2 Date: 2024-04-22T13:24:47-04:00 New Revision: 180cf4daec290e68aa4dd6dc14697add3e18bcec URL: https://github.com/llvm/llvm-project/commit/180cf4daec290e68aa4dd6dc14697add3e18bcec DIFF: https://github.com/llvm/llvm-project/commit/180cf4daec290e68aa4dd6dc14697add3e18bcec.diff LOG: [c

[clang-tools-extra] [clangd] Fix unittests in TargetDeclTest bucket (PR #89630)

2024-04-22 Thread via cfe-commits
https://github.com/zibi2 closed https://github.com/llvm/llvm-project/pull/89630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9aa663b - [Clang] Fix __is_trivially_equaltiy_comparable documentation (#88528)

2024-04-22 Thread via cfe-commits
Author: Nikolas Klauser Date: 2024-04-22T19:26:33+02:00 New Revision: 9aa663bb9ef3dbab8ccc324ef3df5138aa458fbd URL: https://github.com/llvm/llvm-project/commit/9aa663bb9ef3dbab8ccc324ef3df5138aa458fbd DIFF: https://github.com/llvm/llvm-project/commit/9aa663bb9ef3dbab8ccc324ef3df5138aa458fbd.dif

[clang] [Clang] Fix __is_trivially_equaltiy_comparable documentation (PR #88528)

2024-04-22 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/88528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++17] Support __GCC_[CON|DE]STRUCTIVE_SIZE (PR #89446)

2024-04-22 Thread Louis Dionne via cfe-commits
ldionne wrote: > > > > For SystemZ the correct value is 256. > > > > > > > > > Thanks! Double-checking: for both constructive and destructive? > > > > > > Yes, for both. Every SystemZ model (supported by GCC/LLVM) has a L1 cache > > line size of 256 bytes. > > Excellent, thank you! > > > >

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-04-22 Thread Nico Weber via cfe-commits
@@ -656,19 +656,29 @@ std::string ToolChain::getCompilerRT(const ArgList &Args, StringRef Component, // Check for runtime files in the new layout without the architecture first. std::string CRTBasename = buildCompilerRTBasename(Args, Component, Type, /*AddArch=*/fals

[clang] Don't wrap immediate invocations in ConstantExprs within constexpr initializers (PR #89565)

2024-04-22 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm updated https://github.com/llvm/llvm-project/pull/89565 >From a3f8a8648e2002273d47d7886b29fb02c728b5b7 Mon Sep 17 00:00:00 2001 From: Dan Katz Date: Tue, 16 Apr 2024 17:14:50 -0400 Subject: [PATCH 1/5] Fix bug with constexpr initialization. --- clang/lib/Parse/ParseD

[clang] [NFC] Rename hlsl semantics to hlsl annotations (PR #89309)

2024-04-22 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/89309 >From 58f7f1c7f99f29fea39b5bd83bb74d3770a6f985 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 18 Apr 2024 13:38:51 -0700 Subject: [PATCH 1/2] rename hlsl semantics to hlsl annotations --- clang/inclu

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

2024-04-22 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/7] implement binding type error for t/cbuffers and rwbuffers -

[clang] [clang][CoverageMapping] do not emit gap when either end is an `ImplicitValueInitExpr` (PR #89564)

2024-04-22 Thread Wentao Zhang via cfe-commits
whentojump wrote: Fwiw, I uncovered #86998 in the first place when I was compiling this file in Linux kernel: https://elixir.bootlin.com/linux/v6.8.1/source/fs/coredump.c#L545. I can confirm on my local side, with this patch, `fs/coredump.o` can be compiled and instrumented successfully. I a

[clang] Don't wrap immediate invocations in ConstantExprs within constexpr initializers (PR #89565)

2024-04-22 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm edited https://github.com/llvm/llvm-project/pull/89565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Don't wrap immediate invocations in ConstantExprs within constexpr initializers (PR #89565)

2024-04-22 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm commented: @cor3ntin Thanks for your review; this is ready for another look. Note that the use of a full `ExpressionEvaluationContext` caused a handful of other tests to start failing - in particular, ones that previously expected warnings related to changes of value

[clang] Don't wrap immediate invocations in ConstantExprs within constexpr initializers (PR #89565)

2024-04-22 Thread Daniel M. Katz via cfe-commits
@@ -2554,16 +2554,26 @@ Decl *Parser::ParseDeclarationAfterDeclarator( return ParseDeclarationAfterDeclaratorAndAttributes(D, TemplateInfo); } +static bool isConstexprVariable(const Decl *D) { + if (const VarDecl *Var = dyn_cast_or_null(D)) katzdm wrote: A

[clang] Don't wrap immediate invocations in ConstantExprs within constexpr initializers (PR #89565)

2024-04-22 Thread Daniel M. Katz via cfe-commits
@@ -1032,17 +1043,15 @@ int f() { namespace GH57682 { void test() { - constexpr auto l1 = []() consteval { // expected-error {{cannot take address of consteval call operator of '(lambda at}} \ - // expected-note 2{{declared here}} + co

[clang] Don't wrap immediate invocations in ConstantExprs within constexpr initializers (PR #89565)

2024-04-22 Thread Daniel M. Katz via cfe-commits
@@ -2554,16 +2554,26 @@ Decl *Parser::ParseDeclarationAfterDeclarator( return ParseDeclarationAfterDeclaratorAndAttributes(D, TemplateInfo); } +static bool isConstexprVariable(const Decl *D) { + if (const VarDecl *Var = dyn_cast_or_null(D)) katzdm wrote: @

[clang] [llvm] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-04-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/87009 >From 50099312ab7c60b8cfce5473a4c154f8d917dc41 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 27 Mar 2024 15:27:16 -0500 Subject: [PATCH 1/3] [Libomptarget] Rename `libomptarget.rtl.x86_64` to `libomptar

[clang] c1b6cca - [clang][CoverageMapping] do not emit a gap region when either end doesn't have valid source locations (#89564)

2024-04-22 Thread via cfe-commits
Author: Wentao Zhang Date: 2024-04-22T12:37:38-05:00 New Revision: c1b6cca1214e7a9c14a30b81585dd8b81baeaa77 URL: https://github.com/llvm/llvm-project/commit/c1b6cca1214e7a9c14a30b81585dd8b81baeaa77 DIFF: https://github.com/llvm/llvm-project/commit/c1b6cca1214e7a9c14a30b81585dd8b81baeaa77.diff

[clang] [clang][CoverageMapping] do not emit gap when either end is an `ImplicitValueInitExpr` (PR #89564)

2024-04-22 Thread Wentao Zhang via cfe-commits
https://github.com/whentojump closed https://github.com/llvm/llvm-project/pull/89564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Rename hlsl semantics to hlsl annotations (PR #89309)

2024-04-22 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/89309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Serialize platform specific unavailable attribute in symbol graphs (PR #89277)

2024-04-22 Thread via cfe-commits
https://github.com/QuietMisdreavus approved this pull request. https://github.com/llvm/llvm-project/pull/89277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Factor out common parts of ArraySections into its own class (PR #89639)

2024-04-22 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/89639 OpenACC is going to need an array sections implementation that is a simpler version/more restrictive version of the OpenMP version. This patch extracts the things that should be common between the two into a

[clang] [NFC] Factor out common parts of ArraySections into its own class (PR #89639)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes OpenACC is going to need an array sections implementation that is a simpler version/more restrictive version of the OpenMP version. This patch extracts the things that should be common between the two int

[clang] [clang-tools-extra] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-22 Thread John McCall via cfe-commits
rjmccall wrote: > Ah, okay, thank you! I had two concerns, but I think neither are valid now > that I better understand how `ExtQuals` works: 1) I thought we were > increasing the in-memory size of `Qualifiers` in a way that matter (like > `SplitQualType`, `ExtProtoInfo` primarily), AFAIK, `S

[clang] [NFC] Factor out common parts of ArraySections into its own class (PR #89639)

2024-04-22 Thread Erich Keane via cfe-commits
erichkeane wrote: Note: this is one of my approaches. This ends up touching the OpenMP work 'the least' (in that this is the entirety of the OpenMP changes as best I can tell), at the expense of more work/a separate AST Node for OpenACC. The OTHER approach I have is to move/rename `OpenMPAr

[clang] [NFC] Factor out common parts of ArraySections into its own class (PR #89639)

2024-04-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dc20a0ea1fd04a2ef95eb5c73e9f88357fc5f694 b95304b22915217ad149c1b22a6517c585067acf --

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-04-22 Thread YunQiang Su via cfe-commits
@@ -656,19 +656,29 @@ std::string ToolChain::getCompilerRT(const ArgList &Args, StringRef Component, // Check for runtime files in the new layout without the architecture first. std::string CRTBasename = buildCompilerRTBasename(Args, Component, Type, /*AddArch=*/fals

[clang] [NFC] Factor out common parts of ArraySections into its own class (PR #89639)

2024-04-22 Thread Alexey Bataev via cfe-commits
@@ -6610,6 +6610,111 @@ class TypoExpr : public Expr { }; +// This is a sub-class for OpenMP and OpenACC array sections. OpenACC uses a +// very small subset of the functionality, so this class only exposes the things +// the two have in common. This type is not expected to

[clang] [NFC] Factor out common parts of ArraySections into its own class (PR #89639)

2024-04-22 Thread Alexey Bataev via cfe-commits
@@ -6610,6 +6610,111 @@ class TypoExpr : public Expr { }; +// This is a sub-class for OpenMP and OpenACC array sections. OpenACC uses a +// very small subset of the functionality, so this class only exposes the things +// the two have in common. This type is not expected to

[clang] [NFC] Factor out common parts of ArraySections into its own class (PR #89639)

2024-04-22 Thread Alexey Bataev via cfe-commits
@@ -6610,6 +6610,111 @@ class TypoExpr : public Expr { }; +// This is a sub-class for OpenMP and OpenACC array sections. OpenACC uses a +// very small subset of the functionality, so this class only exposes the things +// the two have in common. This type is not expected to

[clang-tools-extra] f94ed6f - [clang-tidy] Improved --verify-config when using literal style in config file (#85591)

2024-04-22 Thread via cfe-commits
Author: Félix-Antoine Constantin Date: 2024-04-22T20:05:32+02:00 New Revision: f94ed6f7977305db8fa6b48a85c9db2b8cc4d3b3 URL: https://github.com/llvm/llvm-project/commit/f94ed6f7977305db8fa6b48a85c9db2b8cc4d3b3 DIFF: https://github.com/llvm/llvm-project/commit/f94ed6f7977305db8fa6b48a85c9db2b8cc

[clang-tools-extra] [clang-tidy] Improved --verify-config when using literal style in config file (PR #85591)

2024-04-22 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin Message-ID: In-Reply-To: https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/85591

[clang-tools-extra] [clang-tidy] check `std::string_view` and custom string-like classes in `readability-string-compare` (PR #88636)

2024-04-22 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 edited https://github.com/llvm/llvm-project/pull/88636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved --verify-config when using literal style in config file (PR #85591)

2024-04-22 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin Message-ID: In-Reply-To: @@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = " [-verify-config]\n";

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libra… (PR #89642)

2024-04-22 Thread Nico Weber via cfe-commits
https://github.com/nico created https://github.com/llvm/llvm-project/pull/89642 …ries For ASan, users already manually have to pass in the path to the lib, and for other libraries they have to pass in the path to the libpath. With LLVM's unreliable name of the lib (due to LLVM_ENABLE_PER_TARGE

[clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur ready_for_review https://github.com/llvm/llvm-project/pull/89153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libraries (PR #89642)

2024-04-22 Thread Nico Weber via cfe-commits
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/89642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libraries (PR #89642)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nico Weber (nico) Changes …ries For ASan, users already manually have to pass in the path to the lib, and for other libraries they have to pass in the path to the libpath. With LLVM's unreliable name of the lib (due to LLVM_ENABLE_PER_TA

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libraries (PR #89642)

2024-04-22 Thread Nico Weber via cfe-commits
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/89642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld Author: Michael Kruse (Meinersbur) Changes Update the folder titles for targets in the monorepository that have not seen taken care of for some time. These are the folders that targets are organized in Visual Studio and XCode (`set_property(TARGET

[clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Michael Kruse (Meinersbur) Changes Update the folder titles for targets in the monorepository that have not seen taken care of for some time. These are the folders that targets are organized in Visual Studio and XCode (`set_property(TARG

[clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Kruse (Meinersbur) Changes Update the folder titles for targets in the monorepository that have not seen taken care of for some time. These are the folders that targets are organized in Visual Studio and XCode (`set_property(TARGET

<    1   2   3   4   5   >