iains wrote:
> Got it. I've renamed the flag as `-fexperimental-modules-reduced-bmi`.
Thanks.
> I feel the suggestion like let users to use `-Xclang` options look odd..
I think the point here is that we want **expert** users to try this out (with
understanding that it might not behave exactly
https://github.com/iains commented:
I am happy to defer to @vgvassilev et al. on this one.
https://github.com/llvm/llvm-project/pull/76774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
@@ -338,6 +409,69 @@ static QualType getCoroutineSuspendExprReturnType(const
ASTContext &Ctx,
}
#endif
+llvm::Function *
+CodeGenFunction::generateAwaitSuspendWrapper(Twine const &CoroName,
+ Twine const &SuspendPointName,
+
AMP999 wrote:
I don't know, but it seems to me that ideally the `DSC` here would be
`DSC_template_type_arg`, not just `DSC_template_arg`. Is there a way to make
that happen?
https://github.com/llvm/llvm-project/pull/81298
___
cfe-commits mailing list
dyung wrote:
The reapplication of this change in bbbcc1d is causing many build bots to fail
due to a missing header file as outlined in #87023. The failing bots include
the following:
- https://lab.llvm.org/buildbot/#/builders/188/builds/43765
- https://lab.llvm.org/buildbot/#/builders/176/bui
https://github.com/dyung created https://github.com/llvm/llvm-project/pull/87041
This reverts commit bbbcc1d99d08855069f4501c896c43a6d4d7b598.
This change is causing the following build bots to fail due to a missing header
file:
- https://lab.llvm.org/buildbot/#/builders/188/builds/43765
- http
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: None (dyung)
Changes
This reverts commit bbbcc1d99d08855069f4501c896c43a6d4d7b598.
This change is causing the following build bots to fail due to a missing header
file:
- https://lab.llvm.org/buildbot/#/
Author: dyung
Date: 2024-03-29T00:50:11-07:00
New Revision: 28760b63bbf9e267713957105a8d17091fb0d20e
URL:
https://github.com/llvm/llvm-project/commit/28760b63bbf9e267713957105a8d17091fb0d20e
DIFF:
https://github.com/llvm/llvm-project/commit/28760b63bbf9e267713957105a8d17091fb0d20e.diff
LOG: Re
https://github.com/dyung closed https://github.com/llvm/llvm-project/pull/87041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zygoloid wrote:
IIRC the issue here is that in C++98, the MTE is in a "weird" place in the AST,
because of the different rules governing how and when temporaries are formed.
For example, for `const int &r = C().a[0];`, we'll form an MTE wrapping just
the `C()` expression, converting it to an x
Author: Thomas Köppe
Date: 2024-03-29T09:11:05+01:00
New Revision: aa04f12fa9f086f62f81841f159085723c255245
URL:
https://github.com/llvm/llvm-project/commit/aa04f12fa9f086f62f81841f159085723c255245
DIFF:
https://github.com/llvm/llvm-project/commit/aa04f12fa9f086f62f81841f159085723c255245.diff
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/86964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chuanqi Xu
Date: 2024-03-29T16:21:02+08:00
New Revision: abfc5efb55267689f1852fd7ce3e0a38876aa259
URL:
https://github.com/llvm/llvm-project/commit/abfc5efb55267689f1852fd7ce3e0a38876aa259
DIFF:
https://github.com/llvm/llvm-project/commit/abfc5efb55267689f1852fd7ce3e0a38876aa259.diff
LO
@@ -0,0 +1,199 @@
+//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/85572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/76930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
I took another review on this patch and it shows the patch itself is not so
correct.
The idea of the patch is to skip GMF at first and start to write the module
from the module purview directly. Then everything unused in GMF is not used.
This seems fine. However, in the modu
@@ -49,3 +49,62 @@ if ((MINGW OR CYGWIN) AND BUILD_SHARED_LIBS)
# despite potential dllexports.
target_link_options(clangInterpreter PRIVATE LINKER:--export-all-symbols)
endif()
+
+if(MSVC)
+ set_target_properties(clangInterpreter PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS
1)
Author: Zahira Ammarguellat
Date: 2024-03-29T06:35:22-04:00
New Revision: 5af767926288f837e4fd9fd81a9d4878e0924ced
URL:
https://github.com/llvm/llvm-project/commit/5af767926288f837e4fd9fd81a9d4878e0924ced
DIFF:
https://github.com/llvm/llvm-project/commit/5af767926288f837e4fd9fd81a9d4878e0924ced
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/86741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
> `unreachable` is morally similar to `offsetof` in that it's a macro interface
> where the implementation can give better results by expanding to a builtin
> than a library is likely to be able to give via a naive implementation, but
> the interfaces _can_ be provided by a C
@@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = "
[-verify-config]\n";
static bool verifyChecks(const StringSet<> &AllChecks, StringRef CheckGlob,
StringRef Source) {
- llvm::StringRef Cur, Rest;
+ GlobList Globs(CheckG
https://github.com/SimplyDanny edited
https://github.com/llvm/llvm-project/pull/85591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > `unreachable` is morally similar to `offsetof` in that it's a macro
> > interface where the implementation can give better results by expanding to
> > a builtin than a library is likely to be able to give via a naive
> > implementation, but the interfaces _can_ be provi
justdan96 wrote:
@alexcrichton Not sure if you've seen but this has been released as part of
LLVM 18.1.2:
https://github.com/llvm/llvm-project/tree/llvmorg-18.1.2/clang/lib/Driver/ToolChains
https://github.com/llvm/llvm-project/pull/84569
___
cfe-com
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?=
Message-ID:
In-Reply-To:
@@ -5803,6 +5887,15 @@ RValue CodeGenFu
philnik777 wrote:
> I can see WG21 solving this either by removing `unreachable` from `cstddef`
> or by requiring `utility` to guard against the macro via implementation magic
> (personally, I think `utility` should guard against it because of users
> including `stddef.h` directly) and it woul
Author: Egor Zhdan
Date: 2024-03-29T13:05:12Z
New Revision: 7344e991ade887775cb25beeffa9c8d2a2311dc7
URL:
https://github.com/llvm/llvm-project/commit/7344e991ade887775cb25beeffa9c8d2a2311dc7
DIFF:
https://github.com/llvm/llvm-project/commit/7344e991ade887775cb25beeffa9c8d2a2311dc7.diff
LOG: [A
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/87006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/87064
Adding code for built-in functionality during initialization is very common.
Call this function afterwards to hide it from Undo. Any serious interpreter
needs it.
From e924da63f1e926f7a7008f661730b1fd478
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Stefan Gränitz (weliveindetail)
Changes
Adding code for built-in functionality during initialization is very common.
Call this function afterwards to hide it from Undo. Any serious interpreter
needs it.
---
Full diff: https://github.com/
AaronBallman wrote:
> Thanks for the comments @AaronBallman. The core issue here is that the
> current builtin handling design does not allow multiple overloads for the
> same identifier to coexist (ref.
>
> https://github.com/llvm/llvm-project/blob/eacda36c7dd842cb15c0c954eda74b67d0c73814/cla
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/87066
None
From 1835e627203ece2e81787d6167ccc15b62c31f36 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 29 Mar 2024 13:37:36 +0100
Subject: [PATCH] [clang-repl] Minor cleanups in Va
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Stefan Gränitz (weliveindetail)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/87066.diff
1 Files Affected:
- (modified) clang/lib/Interpreter/Value.cpp (+6-4)
``diff
diff --git a/clang/lib/Interpreter/Valu
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/87009
>From bb5f330cc3d5e0758825b25e3b8209fb7af6be79 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Wed, 27 Mar 2024 15:27:16 -0500
Subject: [PATCH 1/3] [Libomptarget] Rename `libomptarget.rtl.x86_64` to
`libomptar
https://github.com/python3kgae updated
https://github.com/llvm/llvm-project/pull/83933
>From b134854e7e183a1113ee6ae5c5f7b7910270c987 Mon Sep 17 00:00:00 2001
From: Xiang Li
Date: Mon, 4 Mar 2024 16:39:41 -0800
Subject: [PATCH 01/17] [DOC][HLSL] Add documentation for root signature
This patch
Author: Nathan Sidwell
Date: 2024-03-29T09:35:31-04:00
New Revision: a8ca4abfcfa98d28ec46ee497e1fc5e91f8e1ad6
URL:
https://github.com/llvm/llvm-project/commit/a8ca4abfcfa98d28ec46ee497e1fc5e91f8e1ad6
DIFF:
https://github.com/llvm/llvm-project/commit/a8ca4abfcfa98d28ec46ee497e1fc5e91f8e1ad6.diff
Author: Nathan Sidwell
Date: 2024-03-29T09:35:31-04:00
New Revision: 7df79ababee8d03b27bbaba1aabc2ec4ea14143e
URL:
https://github.com/llvm/llvm-project/commit/7df79ababee8d03b27bbaba1aabc2ec4ea14143e
DIFF:
https://github.com/llvm/llvm-project/commit/7df79ababee8d03b27bbaba1aabc2ec4ea14143e.diff
budimirarandjelovicsyrmia wrote:
ping
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1399,13 +1401,22 @@ RValue AtomicInfo::convertAtomicTempToRValue(Address
addr,
LVal.getBaseInfo(), TBAAAccessInfo()));
}
+static bool shouldCastToInt(llvm::Type *ValTy, bool CmpXchg) {
arsenm wrote:
I don't understand the CmpXchg parameter. Also ne
@@ -1414,13 +1425,11 @@ RValue AtomicInfo::ConvertToValueOrAtomic(llvm::Value
*Val,
auto *ValTy = AsValue
? CGF.ConvertTypeForMem(ValueTy)
: getAtomicAddress().getElementType();
-if (ValTy->isIntegerTy() || (!CastFP && ValTy-
@@ -1399,13 +1401,22 @@ RValue AtomicInfo::convertAtomicTempToRValue(Address
addr,
LVal.getBaseInfo(), TBAAAccessInfo()));
}
+static bool shouldCastToInt(llvm::Type *ValTy, bool CmpXchg) {
+ bool KeepType =
+ (ValTy->isIntegerTy() || ValTy->isPointerTy() ||
+
@@ -134,14 +134,11 @@ static _Atomic float glob_flt = 0.0f;
void force_global_uses(void) {
(void)glob_pointer;
- // CHECK: %[[LOCAL_INT:.+]] = load atomic i32, ptr @[[GLOB_POINTER]] seq_cst
- // CHECK-NEXT: inttoptr i32 %[[LOCAL_INT]] to ptr
+ // CHECK: load atomic ptr, p
@@ -367,6 +367,25 @@ class RenamerClangTidyVisitor
return true;
}
+ bool VisitDesignatedInitExpr(DesignatedInitExpr *Expr) {
+for (const auto &Designator : Expr->designators()) {
+ if (!Designator.isFieldDesignator())
+continue;
+ auto *FieldDecl =
@@ -367,6 +367,25 @@ class RenamerClangTidyVisitor
return true;
}
+ bool VisitDesignatedInitExpr(DesignatedInitExpr *Expr) {
+for (const auto &Designator : Expr->designators()) {
+ if (!Designator.isFieldDesignator())
+continue;
+ auto *FieldDecl =
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/Sirraide deleted
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide deleted
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > I can see WG21 solving this either by removing `unreachable` from `cstddef`
> > or by requiring `utility` to guard against the macro via implementation
> > magic (personally, I think `utility` should guard against it because of
> > users including `stddef.h` directly) a
AaronBallman wrote:
> Another option would be to to not acknowledge zero-sized arrays in the type
> traits at all, just like vector types: https://godbolt.org/z/aP685vz8q. That
> may be the most consistent stance on this. Basically "It's non-standard and
> doesn't fit neatly in any of the stan
philnik777 wrote:
I mean that `stddef.h` would be modified to provide it as a function instead of
a macro. In C++ it would simply never be a macro.
https://github.com/llvm/llvm-project/pull/86748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexcrichton wrote:
Oop no I did not, thank you for the heads up! I'll work on updating wasi-sdk
now.
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
AtariDreams wrote:
Ping?
https://github.com/llvm/llvm-project/pull/65742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/79382
>From bd74d7db681cd07fda56f26e79e047c6d1a41f6b Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Thu, 29 Feb 2024 15:37:50 -0600
Subject: [PATCH 1/5] [HLSL] Pass arrays by value
HLSL constant sized array fu
@@ -1127,9 +1148,9 @@ NumericLiteralParser::NumericLiteralParser(StringRef
TokSpelling,
// wb and WB are allowed, but a mixture of cases like Wb or wB is not. We
// explicitly do not support the suffix in C++ as an extension because a
// library-based UDL tha
https://github.com/urnathan closed
https://github.com/llvm/llvm-project/pull/65742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
urnathan wrote:
Committed, expect tailclipping cleanup PR soon
https://github.com/llvm/llvm-project/pull/65742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
The changes LGTM but I'd like to give Corentin and Tom a chance to weigh in as
lexer code owners (you may need to be patient as they were both in WG21
meetings last week and are currently on vacation, so it may be later next week
before we hear back).
@@ -1127,9 +1148,9 @@ NumericLiteralParser::NumericLiteralParser(StringRef
TokSpelling,
// wb and WB are allowed, but a mixture of cases like Wb or wB is not. We
// explicitly do not support the suffix in C++ as an extension because a
// library-based UDL tha
@@ -1127,9 +1148,9 @@ NumericLiteralParser::NumericLiteralParser(StringRef
TokSpelling,
// wb and WB are allowed, but a mixture of cases like Wb or wB is not. We
// explicitly do not support the suffix in C++ as an extension because a
// library-based UDL tha
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/86586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1127,9 +1148,9 @@ NumericLiteralParser::NumericLiteralParser(StringRef
TokSpelling,
// wb and WB are allowed, but a mixture of cases like Wb or wB is not. We
// explicitly do not support the suffix in C++ as an extension because a
// library-based UDL tha
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86914
>From b31ca786d937dc180ad02042132596b2e5f3710f Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 28 Mar 2024 14:13:12 +0800
Subject: [PATCH 1/2] [clang][Sema] Fix a CTAD regression after 42239d2e9
The most
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86914
>From b31ca786d937dc180ad02042132596b2e5f3710f Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 28 Mar 2024 14:13:12 +0800
Subject: [PATCH 1/3] [clang][Sema] Fix a CTAD regression after 42239d2e9
The most
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
AaronBallman wrote:
> I mean that `stddef.h` would be modified to provide it as a function instead
> of a macro. In C++ it would simply never be a macro.
Yeah, that could be done too, but it seems pretty unclean IMO (at least when
aiming for an ideal implementation) -- C++ changing the content
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/farzonl created
https://github.com/llvm/llvm-project/pull/87078
fixes #86999
>From bbb30f792bb9fb28f68079146783d6e8d1f0682b Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Fri, 29 Mar 2024 10:44:37 -0400
Subject: [PATCH] [HLSL][DXIL] HLSL's `round` should follow `roundeven
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
@llvm/pr-subscribers-clang
Author: Farzon Lotfi (farzonl)
Changes
fixes #86999
---
Full diff: https://github.com/llvm/llvm-project/pull/87078.diff
7 Files Affected:
- (modified) clang/lib/Headers/hlsl/hlsl_intrinsics.h (+8-8)
- (modified
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86914
>From b31ca786d937dc180ad02042132596b2e5f3710f Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 28 Mar 2024 14:13:12 +0800
Subject: [PATCH 1/4] [clang][Sema] Fix a CTAD regression after 42239d2e9
The most
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
zyn0217 wrote:
(Since there haven't been any changes besides comments after the very first
commit, which has passed the CI, so I'm landing it anyway.)
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: Younan Zhang
Date: 2024-03-29T23:28:54+08:00
New Revision: 0f6ed4c394fd8f843029f6919230bf8df8618529
URL:
https://github.com/llvm/llvm-project/commit/0f6ed4c394fd8f843029f6919230bf8df8618529
DIFF:
https://github.com/llvm/llvm-project/commit/0f6ed4c394fd8f843029f6919230bf8df8618529.diff
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Cyndy Ishida
Date: 2024-03-29T08:29:22-07:00
New Revision: a4de589d117a4fd52554da3c61ae6eb26c90a0c8
URL:
https://github.com/llvm/llvm-project/commit/a4de589d117a4fd52554da3c61ae6eb26c90a0c8
DIFF:
https://github.com/llvm/llvm-project/commit/a4de589d117a4fd52554da3c61ae6eb26c90a0c8.diff
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sirraide wrote:
@zyn0217 You missed my last comment on the discussion above there
https://github.com/llvm/llvm-project/pull/86914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/AaronBallman commented:
Precommit CI found related failures that should be addressed.
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -7096,6 +7096,111 @@ static void handleSwiftAsyncAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
}
+// This function is called only if function call is not inside template body.
+// TODO: Add call for function calls
@@ -7096,6 +7096,111 @@ static void handleSwiftAsyncAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
}
+// This function is called only if function call is not inside template body.
+// TODO: Add call for function calls
@@ -7096,6 +7096,111 @@ static void handleSwiftAsyncAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
}
+// This function is called only if function call is not inside template body.
+// TODO: Add call for function calls
@@ -0,0 +1,223 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s
+
+#include
+#include
+#include
+#include
AaronBallman wrote:
Our test files should be hermetic and not rely on anything from the test system
itself. `stdarg.h` is fine
@@ -7096,6 +7096,111 @@ static void handleSwiftAsyncAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
}
+// This function is called only if function call is not inside template body.
+// TODO: Add call for function calls
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7096,6 +7096,111 @@ static void handleSwiftAsyncAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
}
+// This function is called only if function call is not inside template body.
+// TODO: Add call for function calls
@@ -288,6 +288,9 @@ Improvements to Clang's diagnostics
- Clang now correctly diagnoses no arguments to a variadic macro parameter as
a C23/C++20 extension.
Fixes #GH84495.
+
+- Clang now diagnoses missing format attributes for non-template functions and
class/struct/unio
@@ -0,0 +1,211 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s
+
+#include
+#include
AaronBallman wrote:
Same issue here with includes as in the C file.
https://github.com/llvm/llvm-project/pull/70024
@@ -7096,6 +7096,111 @@ static void handleSwiftAsyncAttr(Sema &S, Decl *D,
const ParsedAttr &AL) {
checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr);
}
+// This function is called only if function call is not inside template body.
+// TODO: Add call for function calls
@@ -12107,6 +12090,35 @@ bool Sema::CheckFunctionDeclaration(Scope *S,
FunctionDecl *NewFD,
CheckConstPureAttributesUsage(*this, NewFD);
+ // C++23 [dcl.spec.auto.general]p12:
+ // Return type deduction for a templated function with a placeholder in its
+ // declare
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
lntue wrote:
FYI @nickdesaulniers @michaelrj-google
https://github.com/llvm/llvm-project/pull/86748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1836,7 +1836,19 @@ static TemplateParameterList
*GetTemplateParameterList(TemplateDecl *TD) {
// Make sure we get the template parameter list from the most
// recent declaration, since that is the only one that is guaranteed to
// have all the default template argume
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/84169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 218 matches
Mail list logo
