[clang] [clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument (PR #84174)

weliveindetail wrote: Thanks for the quick feedback and review! https://github.com/llvm/llvm-project/pull/84174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6494f9b - [clang-repl] Expose setter for triple in IncrementalCompilerBuilder (#84174)

Author: Stefan Gränitz Date: 2024-03-06T20:23:09+01:00 New Revision: 6494f9bb8ac1e6f7526b72ee07f71527b8e66066 URL: https://github.com/llvm/llvm-project/commit/6494f9bb8ac1e6f7526b72ee07f71527b8e66066 DIFF: https://github.com/llvm/llvm-project/commit/6494f9bb8ac1e6f7526b72ee07f71527b8e66066.diff

[clang] [clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument (PR #84174)

https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/84174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a6c8407 - [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (#83331)

Author: Alexander Yermolovich Date: 2024-03-06T11:24:44-08:00 New Revision: a6c84079f69f13d7454595cf8804b119a6c4 URL: https://github.com/llvm/llvm-project/commit/a6c84079f69f13d7454595cf8804b119a6c4 DIFF: https://github.com/llvm/llvm-project/commit/a6c84079f69f13d7454595cf8804b119a6

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

https://github.com/ayermolo closed https://github.com/llvm/llvm-project/pull/83331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

https://github.com/ilovepi commented: I assume that's what you're doing in the place I asked for a comment is trying to avoid redundantly generating TLSDESC accesses for _TLS_MODULE_BASE_. I see that we don't generate multiple accesses for _TLS_MODULE_BASE_ in the test cases, but I thought t

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

@@ -18522,13 +18522,21 @@ GetTLSADDR(SelectionDAG &DAG, SDValue Chain, GlobalAddressSDNode *GA, MachineFrameInfo &MFI = DAG.getMachineFunction().getFrameInfo(); SDVTList NodeTys = DAG.getVTList(MVT::Other, MVT::Glue); SDLoc dl(GA); - SDValue TGA = DAG.getTargetGlobalAdd

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/83136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

@@ -0,0 +1,165 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc < %s -mtriple=i686-unknown-unknown --relocation-model=pic -enable-tlsdesc | FileCheck %s --check-prefix=X86 +; RUN: llc < %s -mtriple=x86_64-pc-linu

[clang] [clang-repl] Refactor locking of runtime PTU stack (NFC) (PR #84176)

Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: @@ -137,9 +136,10 @@ class Interpreter { Expr *SynthesizeExpr(Expr *E); -private: size_t getEffectivePTUSize() const; + void finalizeInitPTUStack(); vgvassilev wrote: > Do you mean sth like markMax

[clang] [clang-repl] Names declared in if conditions and for-init statements are local to the inner context (C++ 3.3.2p4) (PR #84150)

Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= Message-ID: In-Reply-To: https://github.com/vgvassilev appr

[clang] 3ecd38c - [libomptarget] Build plugins-nextgen for SystemZ (#83978)

Author: Ulrich Weigand Date: 2024-03-06T20:50:01+01:00 New Revision: 3ecd38c8e1d34b1e4639a1de9f0cb56c7957cbd2 URL: https://github.com/llvm/llvm-project/commit/3ecd38c8e1d34b1e4639a1de9f0cb56c7957cbd2 DIFF: https://github.com/llvm/llvm-project/commit/3ecd38c8e1d34b1e4639a1de9f0cb56c7957cbd2.diff

[clang] [llvm] [openmp] [libomptarget] Build plugins-nextgen for SystemZ (PR #83978)

https://github.com/uweigand closed https://github.com/llvm/llvm-project/pull/83978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

@@ -740,7 +740,8 @@ bool tools::isTLSDESCEnabled(const ToolChain &TC, SupportedArgument = V == "desc" || V == "trad"; EnableTLSDESC = V == "desc"; } else if (Triple.isX86()) { -SupportedArgument = V == "gnu"; +SupportedArgument = V == "gnu" || V == "gnu2"; +

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

ymand wrote: Per offline discussion, please see if we can be more targeted in our use of the generalized matching, given the potentially high cost incurred (for every relevant operation, like comparison, we'll be searching the entire type hierchy of the arguments). https://github.com/llvm/llv

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Update value for __cpp_implicit_move (#84216) (PR #84228)

https://github.com/aniplcc created https://github.com/llvm/llvm-project/pull/84228 Fixes #84216 >From 5de5eacdbd0ddf91f060edb003414b576365f2e0 Mon Sep 17 00:00:00 2001 From: aniplcc Date: Thu, 7 Mar 2024 01:39:30 +0530 Subject: [PATCH] [Clang] Update value for __cpp_implicit_move (#84216) -

[clang] [Clang] Update value for __cpp_implicit_move (#84216) (PR #84228)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Update value for __cpp_implicit_move (#84216) (PR #84228)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (aniplcc) Changes Fixes #84216 --- Full diff: https://github.com/llvm/llvm-project/pull/84228.diff 3 Files Affected: - (modified) clang/lib/Frontend/InitPreprocessor.cpp (+1-1) - (modified) clang/test/Lexer/cxx-features.cpp (+1-

[clang] [HLSL][docs] Document hlsl.h in the HLSL docs (PR #84081)

@@ -114,6 +114,44 @@ not re-targetable, we want to share the Clang CodeGen implementation for HLSL with other GPU graphics targets like SPIR-V and possibly other GPU and even CPU targets. +hlsl.h +-- + +HLSL has an extensive library of functionality. This is similar to Op

[clang] [HLSL][docs] Document hlsl.h in the HLSL docs (PR #84081)

https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/84081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Resolve FIXME: Assign E to nullptr (PR #84229)

https://github.com/AtariDreams created https://github.com/llvm/llvm-project/pull/84229 We do not support GCC 4.8 anymore. >From 46da573d7a6be27b808240985b8b2e81eaadba26 Mon Sep 17 00:00:00 2001 From: Rose Date: Wed, 6 Mar 2024 15:26:53 -0500 Subject: [PATCH] [AST] Resolve FIXME: Assign E to nu

[clang] [AST] Resolve FIXME: Assign E to nullptr (PR #84229)

llvmbot wrote: @llvm/pr-subscribers-clang Author: AtariDreams (AtariDreams) Changes We do not support GCC 4.8 anymore. --- Full diff: https://github.com/llvm/llvm-project/pull/84229.diff 1 Files Affected: - (modified) clang/include/clang/AST/Expr.h (+1-1) ``diff diff --git a

[clang] [clang-repl] Refactor locking of runtime PTU stack (NFC) (PR #84176)

@@ -137,9 +136,10 @@ class Interpreter { Expr *SynthesizeExpr(Expr *E); -private: weliveindetail wrote: > We can befriend the test to the interpreter. I don't think we can do this: ``` // Defines FRIEND_TEST. #include ``` > make this `protected:` and ha

[clang] Revert "[clang] Avoid memcopy for small structure with padding under … (PR #84230)

https://github.com/antoniofrighetto created https://github.com/llvm/llvm-project/pull/84230 …-ftrivial-auto-var-init (#71677)" This reverts commit afe8b93ffdfef5d8879e1894b9d7dda40dee2b8d. Fixes regression: https://github.com/llvm/llvm-project/issues/84178. >From bb22eccc90d0e8cb02be5d4c47a08

[clang] Revert "[clang] Avoid memcopy for small structure with padding under … (PR #84230)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Antonio Frighetto (antoniofrighetto) Changes …-ftrivial-auto-var-init (#71677)" This reverts commit afe8b93ffdfef5d8879e1894b9d7dda40dee2b8d. Fixes regression: https://github.com/llvm/llvm-project/issues/84178. --- Full diff: htt

[clang] Revert "[clang] Avoid memcopy for small structure with padding under … (PR #84230)

nikic wrote: Can you please provide more information on what the regression was / how this fixes it? https://github.com/llvm/llvm-project/pull/84230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] 70677c8 - Revert "[libomptarget] Build plugins-nextgen for SystemZ (#83978)"

Author: Ulrich Weigand Date: 2024-03-06T21:37:43+01:00 New Revision: 70677c81debbeacfc2a2fe968e632522ea1b53e1 URL: https://github.com/llvm/llvm-project/commit/70677c81debbeacfc2a2fe968e632522ea1b53e1 DIFF: https://github.com/llvm/llvm-project/commit/70677c81debbeacfc2a2fe968e632522ea1b53e1.diff

[clang] [clang-repl] Refactor locking of runtime PTU stack (NFC) (PR #84176)

Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: @@ -136,6 +136,24 @@ TEST(InterpreterTest, DeclsAndStatements) { EXPECT_TRUE(!!R2); } +TEST(InterpreterTest, PTUStack) { + clang::IncrementalCompilerBuilder CB; + auto CI = cantFail(CB.CreateCpp()); + + llvm::Error Er

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/83716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

@@ -0,0 +1,100 @@ +//===--- SuspiciousStringviewDataUsageCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

@@ -0,0 +1,100 @@ +//===--- SuspiciousStringviewDataUsageCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

@@ -0,0 +1,100 @@ +//===--- SuspiciousStringviewDataUsageCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

https://github.com/5chmidti commented: Overall looks good https://github.com/llvm/llvm-project/pull/83716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

@@ -96,6 +96,10 @@ C++20 Feature Support behavior can use the flag '-Xclang -fno-skip-odr-check-in-gmf'. (`#79240 `_). +- Initial support for class template argument deduciton (CTAD) for type alias + templates (`P1814R0 <

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

https://github.com/h-vetinari edited https://github.com/llvm/llvm-project/pull/77890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Doc][HLSL] Add documentation for root signature. (PR #83933)

https://github.com/python3kgae updated https://github.com/llvm/llvm-project/pull/83933 >From b134854e7e183a1113ee6ae5c5f7b7910270c987 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Mon, 4 Mar 2024 16:39:41 -0800 Subject: [PATCH 1/9] [DOC][HLSL] Add documentation for root signature This patch ad

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/84236 Fix handling of Hungarian Prefix when configured to LowerCase. Warnings no longer will be emited for names that already match this style. Fixes: #80268 >From b94c868070548ebc942479f90614225bd27b447a Mon S

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Fix handling of Hungarian Prefix when configured to LowerCase. Warnings no longer will be emited for names that already match this style. Fixes: #80268 --- Patch is 43.70 KiB, truncated to 20.00

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Piotr Zegar (PiotrZSL) Changes Fix handling of Hungarian Prefix when configured to LowerCase. Warnings no longer will be emited for names that already match this style. Fixes: #80268 --- Patch is 43.70 KiB, truncated to

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

snehasish wrote: > > Here are some things I noticed, haven't looked at the tests yet. > > @snehasish Thanks for the review! > > Talking about tests, I wonder if it looks better if I change the current LLVM > IR test under `llvm/test/tools/llvm-profdata/` into a compiler-rt test under > `compi

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

@@ -1237,6 +1259,101 @@ void InstrLowerer::maybeSetComdat(GlobalVariable *GV, Function *Fn, GV->setLinkage(GlobalValue::InternalLinkage); } +static inline bool shouldRecordVTableAddr(GlobalVariable *GV) { + if (!profDataReferencedByCode(*GV->getParent())) +return fal

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

@@ -560,6 +602,28 @@ Error InstrProfSymtab::addFuncWithName(Function &F, StringRef PGOFuncName) { return Error::success(); } +uint64_t InstrProfSymtab::getVTableHashFromAddress(uint64_t Address) { + finalizeSymtab(); snehasish wrote: Add a comment why its

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

@@ -0,0 +1,100 @@ +//===--- SuspiciousStringviewDataUsageCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] Update value for __cpp_implicit_move (#84216) (PR #84228)

https://github.com/cor3ntin approved this pull request. LGTM, Thanks! https://github.com/llvm/llvm-project/pull/84228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #84014)

@@ -1635,6 +1635,17 @@ void TypePrinter::printElaboratedBefore(const ElaboratedType *T, if (T->getKeyword() != ElaboratedTypeKeyword::None) OS << " "; NestedNameSpecifier *Qualifier = T->getQualifier(); +if (!Policy.SuppressTagKeyword && Policy.SuppressScope

[clang] [clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument (PR #84174)

fmayer wrote: This triggers the leak detector in our HWASan build bot ``` Note: This is test shard 1 of 23. [==] Running 1 test from 1 test suite. [--] Global test environment set-up. [--] 1 test from IncrementalCompilerBuilder [ RUN ] IncrementalCompilerBuilder.SetC

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/82809 >From 557e7163d744890aadfa703a81a0c4f2cd112517 Mon Sep 17 00:00:00 2001 From: zhijian Date: Fri, 23 Feb 2024 13:23:18 -0500 Subject: [PATCH 1/4] Implement a subset of builtin_cpu_supports() features --- clang

[clang] [clang][modules] giving the __stddef_ headers their own modules can cause redeclaration errors with -fbuiltin-headers-in-system-modules (PR #84127)

ian-twilightcoder wrote: > Still need to check the code but > > > Make the __stddef_ headers be non-modular in > > -fbuiltin-headers-in-system-modules and restore them back to not respecting > > their header guards. Still define the header guards though. > > sounds quite questionable. They w

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/82809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/82809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

aheejin wrote: Can I take a look before landing this? I'm OOO this afternoon but will be back tomorrow. https://github.com/llvm/llvm-project/pull/84137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] f8c5a68 - [clang][test] Add test for incompatible cv-qualified reference types in conversion function template (#81950)

Author: Duo Wang Date: 2024-03-06T14:19:27-08:00 New Revision: f8c5a68365fb82d9ffc64511f4b50b9c1e68144f URL: https://github.com/llvm/llvm-project/commit/f8c5a68365fb82d9ffc64511f4b50b9c1e68144f DIFF: https://github.com/llvm/llvm-project/commit/f8c5a68365fb82d9ffc64511f4b50b9c1e68144f.diff LOG:

[clang] [clang][test] Add test for incompatible cv-qualified reference types in conversion function template (PR #81950)

https://github.com/zygoloid closed https://github.com/llvm/llvm-project/pull/81950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] AMDGPU: Define a feature for v_dot4_f32_* instructions (PR #84248)

https://github.com/changpeng created https://github.com/llvm/llvm-project/pull/84248 FeatureDot11Insts (dot11-insts) for: v_dot4_f32_fp8_fp8, v_dot4_f32_fp8_bf8, v_dot4_f32_bf8_fp8, v_dot4_f32_bf8_bf8 >From 1bfc1e048d10e57c3d07038f52b072163f3b4ff9 Mon Sep 17 00:00:00 2001 From: Changpeng Fa

[clang] [llvm] AMDGPU: Define a feature for v_dot4_f32_* instructions (PR #84248)

llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang Author: Changpeng Fang (changpeng) Changes FeatureDot11Insts (dot11-insts) for: v_dot4_f32_fp8_fp8, v_dot4_f32_fp8_bf8, v_dot4_f32_bf8_fp8, v_dot4_f32_bf8_bf8 --- Full diff: https://github.com/llvm/llvm-proj

[clang] [llvm] AMDGPU: Define a feature for v_dot4_f32_* instructions (PR #84248)

https://github.com/rampitec approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/84248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] AMDGPU: Define a feature for v_dot4_f32_* instructions (PR #84248)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5cd45e442e99f8e01127f37548b124fa0e70f96a 1bfc1e048d10e57c3d07038f52b072163f3b4ff9 --

[clang] [clang][CUDA] Disable float128 diagnostics for device compilation (PR #83918)

https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/83918 >From c28121199d5e16efb908a3058a52c6b5b2016848 Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Mon, 4 Mar 2024 22:19:04 + Subject: [PATCH 1/3] [clang][CUDA] Disable float128 diagnostics for device compilati

[clang] 96813de - AMDGPU: Define a feature for v_dot4_f32_* instructions (#84248)

Author: Changpeng Fang Date: 2024-03-06T14:37:03-08:00 New Revision: 96813de52d09d983d14a30ef5e2b4b8658f8e952 URL: https://github.com/llvm/llvm-project/commit/96813de52d09d983d14a30ef5e2b4b8658f8e952 DIFF: https://github.com/llvm/llvm-project/commit/96813de52d09d983d14a30ef5e2b4b8658f8e952.diff

[clang] [llvm] AMDGPU: Define a feature for v_dot4_f32_* instructions (PR #84248)

https://github.com/changpeng closed https://github.com/llvm/llvm-project/pull/84248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

https://github.com/5chmidti commented: I don't know enough about the driver to approve this, but I read this a few times and I think that this is correct. I just added a few small and non-functional nits https://github.com/llvm/llvm-project/pull/66553 __

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr createBaseFS() { return BaseFS; } +static void recreateOptionsParserIfNeeded( +llvm::Expected &OptionsParser, +llvm::ArrayRef Args, +const ClangTidyOptions &EffectiveOptions) { + + auto DoubleDashIt = std::fi

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr createBaseFS() { return BaseFS; } +static void recreateOptionsParserIfNeeded( +llvm::Expected &OptionsParser, +llvm::ArrayRef Args, +const ClangTidyOptions &EffectiveOptions) { + + auto DoubleDashIt = std::fi

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/66553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr createBaseFS() { return BaseFS; } +static void recreateOptionsParserIfNeeded( +llvm::Expected &OptionsParser, +llvm::ArrayRef Args, +const ClangTidyOptions &EffectiveOptions) { + + auto DoubleDashIt = std::fi

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr createBaseFS() { return BaseFS; } +static void recreateOptionsParserIfNeeded( +llvm::Expected &OptionsParser, +llvm::ArrayRef Args, +const ClangTidyOptions &EffectiveOptions) { + + auto DoubleDashIt = std::fi

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

@@ -550,9 +555,91 @@ static llvm::IntrusiveRefCntPtr createBaseFS() { return BaseFS; } +static void recreateOptionsParserIfNeeded( +llvm::Expected &OptionsParser, +llvm::ArrayRef Args, +const ClangTidyOptions &EffectiveOptions) { + + auto DoubleDashIt = std::fi

[clang] Revert "[clang] Avoid memcopy for small structure with padding under … (PR #84230)

https://github.com/antoniofrighetto updated https://github.com/llvm/llvm-project/pull/84230 >From 91ca7b2e5c98a7caa8a97f05f57e84f68d861fa3 Mon Sep 17 00:00:00 2001 From: Antonio Frighetto Date: Wed, 6 Mar 2024 23:49:40 +0100 Subject: [PATCH] [clang][CodeGen] Allow memcpy replace with trivial au

[clang] [clang][CodeGen] Allow memcpy replace with trivial auto var init (PR #84230)

https://github.com/antoniofrighetto edited https://github.com/llvm/llvm-project/pull/84230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Remove '--' separator in the linker wrapper usage (PR #84253)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/84253 Summary: The very first version of the `clang-linker-wrapper` used `--` as a separator for the host and device arguments. I moved away from this towards a commandline parsing implementation years ago but never got

[clang] [clang][CodeGen] Allow memcpy replace with trivial auto var init (PR #84230)

antoniofrighetto wrote: I think manually checking if `TrivialAutoVarInit` is set (to `Pattern`?) may be a better fix, as there was only [one codepath](https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGDecl.cpp#L1972-L1974) in which we were not checking this. https://github.co

[clang] [Clang][NFC] Remove '--' separator in the linker wrapper usage (PR #84253)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-backend-amdgpu Author: Joseph Huber (jhuber6) Changes Summary: The very first version of the `clang-linker-wrapper` used `--` as a separator for the host and device arguments. I moved away from

[clang] [clang][CUDA] Disable float128 diagnostics for device compilation (PR #83918)

https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/83918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Update value for __cpp_implicit_move (#84216) (PR #84228)

https://github.com/aniplcc updated https://github.com/llvm/llvm-project/pull/84228 >From 5de5eacdbd0ddf91f060edb003414b576365f2e0 Mon Sep 17 00:00:00 2001 From: aniplcc Date: Thu, 7 Mar 2024 01:39:30 +0530 Subject: [PATCH] [Clang] Update value for __cpp_implicit_move (#84216) --- clang/lib/Fr

[clang-tools-extra] [clang-tidy] bugprone-assert-side-effect can detect side effect from non-const reference parameters (PR #84095)

https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/84095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] bugprone-assert-side-effect can detect side effect from non-const reference parameters (PR #84095)

@@ -122,6 +122,10 @@ New check aliases Changes in existing checks ^^ +- Improved :doc:`bugprone-assert-side-effect + ` check by detection side 5chmidti wrote: `... detecting side effects from calling a method ...` https://github.com/

[clang-tools-extra] [clang-tidy] bugprone-assert-side-effect can detect side effect from non-const reference parameters (PR #84095)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/84095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] bugprone-assert-side-effect can detect side effect from non-const reference parameters (PR #84095)

@@ -60,16 +60,27 @@ AST_MATCHER_P2(Expr, hasSideEffect, bool, CheckFunctionCalls, } if (const auto *CExpr = dyn_cast(E)) { -bool Result = CheckFunctionCalls; +if (!CheckFunctionCalls) + return false; if (const auto *FuncDecl = CExpr->getDirectCallee()) {

[clang] [clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument (PR #84174)

weliveindetail wrote: Interesting, thanks for reporting! It's this code: ``` llvm::MemoryBuffer *MB = llvm::MemoryBuffer::getMemBuffer("").release(); Clang->getPreprocessorOpts().addRemappedFile("<<< inputs >>>", MB); ``` Apparently, it is related to releasing the MemBuffer and passing the r

[clang] Revert "[clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument" (PR #84261)

https://github.com/weliveindetail created https://github.com/llvm/llvm-project/pull/84261 Reverts llvm/llvm-project#84174 due too sanitizer memory leak detection From efe6097aad69aba7d2421880305198bf09226db6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Thu, 7 Mar 2024

[clang] 6a39a71 - Revert "[clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument" (#84261)

Author: Stefan Gränitz Date: 2024-03-07T01:01:07+01:00 New Revision: 6a39a714423ba5675b9e211a80c1dae1ff0e6eac URL: https://github.com/llvm/llvm-project/commit/6a39a714423ba5675b9e211a80c1dae1ff0e6eac DIFF: https://github.com/llvm/llvm-project/commit/6a39a714423ba5675b9e211a80c1dae1ff0e6eac.diff

[clang] Revert "[clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument" (PR #84261)

https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/84261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang-repl] Pass triple to IncrementalCompilerBuilder as explicit argument" (PR #84261)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Stefan Gränitz (weliveindetail) Changes Reverts llvm/llvm-project#84174 due too sanitizer memory leak detection --- Full diff: https://github.com/llvm/llvm-project/pull/84261.diff 4 Files Affected: - (modified) clang/include/clang/Inter

[clang] [llvm] [Clang] CGCoroutine: Skip moving parameters if the allocation decision is false (PR #81195)

https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/81195 >From 1e03c2ec24c7bc6a303266a7023a56d6449a46e5 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Wed, 7 Feb 2024 16:05:42 -0800 Subject: [PATCH] Skip moving parameters if the allocation decision is false -

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

@@ -0,0 +1,100 @@ +//===--- SuspiciousStringviewDataUsageCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Clang] CGCoroutine: Skip moving parameters if the allocation decision is false (PR #81195)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dcd08daed5fb9928fedb09c2a84d1e9d2ab59630 1e03c2ec24c7bc6a303266a7023a56d6449a46e5 --

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/81014 >From 5ba669011752b6ea6e6fe5f6141c4af66ca7ccbf Mon Sep 17 00:00:00 2001 From: Sirraide Date: Wed, 7 Feb 2024 17:25:10 +0100 Subject: [PATCH 01/21] [Clang] Parsing and Sema for C++23's `assume` attribute --- cl

[clang-tools-extra] [clang-tidy] Add bugprone-suspicious-stringview-data-usage check (PR #83716)

@@ -0,0 +1,100 @@ +//===--- SuspiciousStringviewDataUsageCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

Sirraide wrote: It requests a review automatically if one of the files has a code owner, interesting. https://github.com/llvm/llvm-project/pull/81014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

Sirraide wrote: I’ve implemented what we’ve decided on as a result of the RFC and also renamed the attribute to `CXXAssumeAttr` and the OpenMP one to `OMPAssumeAttr` so we don’t confuse the two. > > But it sounds like my idea doesn't have legs because of OpenMP > > specification requirements.

[clang] [Clang][OpenMP] throw compilation error instead of crash in Stmt::OMPScopeDirectiveClass case (#77535) (PR #84135)

@@ -0,0 +1,8 @@ +// RUN: %clang_cc1 -emit-obj -verify -fopenmp %s Puellaquae wrote: during testing, I found it can't produce this error without `-emit-obj` https://github.com/llvm/llvm-project/pull/84135 ___ cfe-commit

[clang] [Clang][OpenMP] throw compilation error instead of crash in Stmt::OMPScopeDirectiveClass case (#77535) (PR #84135)

@@ -0,0 +1,8 @@ +// RUN: %clang_cc1 -emit-obj -verify -fopenmp %s shiltian wrote: You can use `-emit-llvm` instead. https://github.com/llvm/llvm-project/pull/84135 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/81014 >From 5ba669011752b6ea6e6fe5f6141c4af66ca7ccbf Mon Sep 17 00:00:00 2001 From: Sirraide Date: Wed, 7 Feb 2024 17:25:10 +0100 Subject: [PATCH 01/22] [Clang] Parsing and Sema for C++23's `assume` attribute --- cl

[clang] [X86] Finely handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

@@ -34,6 +34,60 @@ __m128 test_mm_andnot_ps(__m128 A, __m128 B) { return _mm_andnot_ps(A, B); } +__m128 test_mm_cmp_ps_eq_oq(__m128 a, __m128 b) { + // CHECK-LABEL: test_mm_cmp_ps_eq_oq + // CHECK: fcmp oeq <4 x float> %{{.*}}, %{{.*}} + return _mm_cmp_ps(a, b, _CMP_EQ_OQ

[clang] [clang][StaticAnalyzer] Adding getentropy to CStringChecker. (PR #83675)

https://github.com/devnexen updated https://github.com/llvm/llvm-project/pull/83675 >From 1b2fec2c9a41be4ad216d7032189f561eed3f751 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Sat, 2 Mar 2024 14:56:15 + Subject: [PATCH 1/2] [clang][StaticAnalyzer] Adding getentropy to CStringChecker.

[clang] [clang][Sema] Skip the RequiresExprBodyDecls for lambda dependencies (PR #83997)

https://github.com/yuxuanchen1997 approved this pull request. Thank you so much! This looks good. https://github.com/llvm/llvm-project/pull/83997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang][OpenMP] throw compilation error instead of crash in Stmt::OMPScopeDirectiveClass case (#77535) (PR #84135)

https://github.com/Puellaquae updated https://github.com/llvm/llvm-project/pull/84135 >From a2c88b0b615875d625b49e596886a0f5b32cf159 Mon Sep 17 00:00:00 2001 From: Puellaquae Date: Wed, 6 Mar 2024 05:22:08 + Subject: [PATCH 1/3] [Clang][OpenMP] throw compilation error instead of crash in S

[clang] [X86] Finely handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

@@ -2613,6 +2614,24 @@ void CGBuilderInserter::InsertHelper( // called function. void CodeGenFunction::checkTargetFeatures(const CallExpr *E, const FunctionDecl *TargetDecl) { + // SemaCheking cannot handle below x86 builtins because t

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

Sirraide wrote: > Change __attribute__((assume)) (and [[clang::assume]] if we care enough about > that one) to be synonyms for [[assume]]. Actually, I think we could do that immediately because OpenMP’s `assume` isn’t valid as a statement attribute anyway iirc. I’d still deprecate all spelling

<    1   2   3   4   5   6   >