[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Louis Dionne via cfe-commits
ldionne wrote: @jlebar The CI seems to be failing due to a test you were the last to touch: ``` TEST 'Clang :: Preprocessor/cuda-macos-includes.cu' FAILED Exit Code: 1 Command Output (stderr): -- [...] error: CHECK-DAG: expected string not found in inp

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/75841 >From ca2a85880cec704225c0b1d5241cf299d5dcad41 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 18 Dec 2023 12:53:23 -0500 Subject: [PATCH 1/2] [clang][Darwin] Remove legacy framework search path logic in

[llvm] [clang] [lld] [LTO] Improve diagnostics handling when parsing module-level inline assembly (PR #75726)

2023-12-18 Thread Eli Friedman via cfe-commits
@@ -418,6 +418,8 @@ void BackendConsumer::anchor() { } } // namespace clang bool ClangDiagnosticHandler::handleDiagnostics(const DiagnosticInfo &DI) { + if (DI.getSeverity() == DS_Error) +HasErrors = true; efriedma-quic wrote: I'm not sure I like the way

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-18 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google updated https://github.com/llvm/llvm-project/pull/74791 >From 1f4df1b82970c95684eed93c8f6bcaa6d6507b88 Mon Sep 17 00:00:00 2001 From: Jordan R Abrahams-Whitehead Date: Fri, 8 Dec 2023 00:09:59 + Subject: [PATCH 1/7] [libunwind] Replace process_vm_readv wit

[clang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #75711)

2023-12-18 Thread Reid Kleckner via cfe-commits
rnk wrote: > > What I'd like to see is a pull request sent to > > https://github.com/microsoft/stl with some agreement about how to structure > > the ifdefs so we can use intrin0.h when it is available. > > Sounds good I'll do that. Thanks! > I was thinking I could use `__has_include_next`.

[clang-tools-extra] [libunwind] [clang] [llvm] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-18 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google updated https://github.com/llvm/llvm-project/pull/74791 >From 1f4df1b82970c95684eed93c8f6bcaa6d6507b88 Mon Sep 17 00:00:00 2001 From: Jordan R Abrahams-Whitehead Date: Fri, 8 Dec 2023 00:09:59 + Subject: [PATCH 1/7] [libunwind] Replace process_vm_readv wit

[clang-tools-extra] [flang] [clang] [libc] [libcxx] [compiler-rt] [llvm] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-18 Thread Bill Wendling via cfe-commits
@@ -8522,6 +8522,22 @@ bool Sema::CheckCountedByAttr(Scope *S, const FieldDecl *FD) { } } + // We don't support 'counted_by' on flexible array members in substructures. + const DeclContext *DC = FD->getParent(); + while (const auto *RD = dyn_cast(DC)) { +if (!RD-

[clang] [llvm] [clang-tools-extra] [libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-18 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google edited https://github.com/llvm/llvm-project/pull/74791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [libunwind] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google edited https://github.com/llvm/llvm-project/pull/74791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [compiler-rt] [clang] [llvm] [libc] [clang-tools-extra] [flang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-18 Thread Bill Wendling via cfe-commits
@@ -3946,6 +4080,32 @@ static Address emitArraySubscriptGEP(CodeGenFunction &CGF, Address addr, return Address(eltPtr, CGF.ConvertTypeForMem(eltType), eltAlign); } +static bool GetFieldOffsetInBits(CodeGenFunction &CGF, const RecordDecl *RD, +

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Julian Lettner via cfe-commits
https://github.com/yln edited https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Julian Lettner via cfe-commits
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA, } } - // Add non-standard, platform-specific search paths, e.g., for DriverKit: - // -L/System/DriverKit/usr/lib - // -F/System/DriverKit/System/Library/Framework + // Add

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Julian Lettner via cfe-commits
https://github.com/yln approved this pull request. https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [compiler-rt] [flang] [mlir] [libcxx] [lld] [llvm] [builtins] Refactor cpu_model support to reduce #if nesting. NFCI (PR #75635)

2023-12-18 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv commented: Thanks a lot for refactoring! It indeed becomes necessary and looks well-structured now, small nit - rename lse_atomics/fucsia.inc and fmv/fucsia.inc files as well. https://github.com/llvm/llvm-project/pull/75635

[clang] Revert counted_by attribute feature (PR #75857)

2023-12-18 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/75857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cca4d6c - Revert counted_by attribute feature (#75857)

2023-12-18 Thread via cfe-commits
Author: Bill Wendling Date: 2023-12-18T15:16:09-08:00 New Revision: cca4d6cfd2a3780bb432e4f8234704d920dcce50 URL: https://github.com/llvm/llvm-project/commit/cca4d6cfd2a3780bb432e4f8234704d920dcce50 DIFF: https://github.com/llvm/llvm-project/commit/cca4d6cfd2a3780bb432e4f8234704d920dcce50.diff

[libcxx] [compiler-rt] [clang] [llvm] [libc] [clang-tools-extra] [flang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-18 Thread Bill Wendling via cfe-commits
bwendling wrote: https://github.com/llvm/llvm-project/pull/75857 has been merged in. This PR is no longer valid. https://github.com/llvm/llvm-project/pull/73730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [compiler-rt] [flang] [clang-tools-extra] [libcxx] [libc] [llvm] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-18 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/73730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] Add out-of-line-atomics support to GlobalISel (PR #74588)

2023-12-18 Thread James Y Knight via cfe-commits
jyknight wrote: > This sounds extremely unsound It is completely unsound. The constraints that approximately every architecture has on LL/SC loops make it unsound to ever generate isolated LL and SC instructions at the IR level, as we are currently doing on AArch64, ARM, and Hexagon. We alre

[clang] Warning for unsafe invocation of span::data (PR #75650)

2023-12-18 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/75650 >From 809bf6f4237f634feaeb7e5b0b88be3a2e4de455 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 15 Dec 2023 11:40:55 -0800 Subject: [PATCH 1/2] While refactoring projects to eradicate unsafe buffer

[llvm] [clang] [libunwind] [clang-tools-extra] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google updated https://github.com/llvm/llvm-project/pull/74791 >From 1f4df1b82970c95684eed93c8f6bcaa6d6507b88 Mon Sep 17 00:00:00 2001 From: Jordan R Abrahams-Whitehead Date: Fri, 8 Dec 2023 00:09:59 + Subject: [PATCH 1/8] [libunwind] Replace process_vm_readv wit

[clang] Warning for unsafe invocation of span::data (PR #75650)

2023-12-18 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/75650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-18 Thread Eric Biggers via cfe-commits
ebiggers wrote: Rebased to resolve conflicts again https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-18 Thread Craig Topper via cfe-commits
topperc wrote: @ebiggers are you table to commit or do you need someone else to do it? I don't recall seeing a commit from you before so I wasn't sure. https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang-tools-extra] [llvm] [libunwind] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Jordan R AW via cfe-commits
@@ -26,7 +26,7 @@ __attribute__((naked)) void bad_unwind_info() { #if defined(__aarch64__) __asm__("// not using 0 because unwinder was already resilient to that\n" - "mov x8, #4\n" + "mov x8, #12\n" ajordanr-google wrote: Note: cha

[clang] [clang-tools-extra] [llvm] [libunwind] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google edited https://github.com/llvm/llvm-project/pull/74791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-18 Thread Eric Biggers via cfe-commits
ebiggers wrote: No, I don't have commit access. https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-18 Thread Eric Biggers via cfe-commits
ebiggers wrote: Updated to add my Co-authored-by, as the original author is `Brandon Wu `. Someone who has permission to do so will need to approve the GitHub Actions workflow, and merge the commit once everything is ready. https://github.com/llvm/llvm-project/pull/74213 _

[libcxx] [clang-tools-extra] [llvm] [libc] [clang] [compiler-rt] [flang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-18 Thread via cfe-commits
h-vetinari wrote: > #75857 has been merged in. This PR is no longer valid. Couldn't you just rebase it like: - base: `main` - pick revert of #75857 - all the commits of this PR It's a bit of a matter of taste obviously how to deal with such situations. I tend to prefer not to split the contex

[clang] Warning for unsafe invocation of span::data (PR #75650)

2023-12-18 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/75650 >From 809bf6f4237f634feaeb7e5b0b88be3a2e4de455 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 15 Dec 2023 11:40:55 -0800 Subject: [PATCH 1/3] While refactoring projects to eradicate unsafe buffer

[libunwind] [llvm] [clang-tools-extra] [clang] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -2762,18 +2757,17 @@ int UnwindCursor::stepThroughSigReturn(Registers_arm64 &) { template bool UnwindCursor::setInfoForSigReturn(Registers_riscv &) { const pint_t pc = static_cast(getReg(UNW_REG_IP)); - uint32_t instructions[2]; - struct iovec local_iov = {&instructions

[libunwind] [llvm] [clang-tools-extra] [clang] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/74791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [llvm] [clang-tools-extra] [clang] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -2822,13 +2816,11 @@ bool UnwindCursor::setInfoForSigReturn(Registers_s390x &) { // onto the stack. const pint_t pc = static_cast(this->getReg(UNW_REG_IP)); // The PC might contain an invalid address if the unwind info is bad, so - // directly accessing it could cause

[llvm] [lldb] [mlir] [clang-tools-extra] [libcxx] [compiler-rt] [lld] [clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-12-18 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,303 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2023-12-18 Thread via cfe-commits
https://github.com/hstk30-hw edited https://github.com/llvm/llvm-project/pull/75440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2023-12-18 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/75440 >From fdb2b45298ef5282897297c913a195af07aec64b Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Thu, 14 Dec 2023 15:40:03 +0800 Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics --- clang/lib/Header

[clang] Honor -fno-sanitize-link-runtime for libclang_rt.asan_static (PR #66414)

2023-12-18 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Sorry, I guess we need to train our-self to merge patches for non-members. https://github.com/llvm/llvm-project/pull/66414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] Honor -fno-sanitize-link-runtime for libclang_rt.asan_static (PR #66414)

2023-12-18 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/66414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d9d20bd - Honor -fno-sanitize-link-runtime for libclang_rt.asan_static (#66414)

2023-12-18 Thread via cfe-commits
Author: Colin Cross Date: 2023-12-18T17:15:41-08:00 New Revision: d9d20bd81f2f95c9b7510725fb76975e8123a542 URL: https://github.com/llvm/llvm-project/commit/d9d20bd81f2f95c9b7510725fb76975e8123a542 DIFF: https://github.com/llvm/llvm-project/commit/d9d20bd81f2f95c9b7510725fb76975e8123a542.diff L

[libcxx] [compiler-rt] [llvm] [flang] [clang-tools-extra] [clang] [libc] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-18 Thread Bill Wendling via cfe-commits
bwendling wrote: > > #75857 has been merged in. This PR is no longer valid. > > Couldn't you just rebase it like: > > * base: `main` > * pick revert of [Revert counted_by attribute feature  > #75857](https://github.com/llvm/llvm-project/pull/75857) > * all the commits of this PR > > It's a bit

[clang-tools-extra] [libunwind] [llvm] [clang] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -2974,6 +2966,39 @@ bool UnwindCursor::getFunctionName(char *buf, size_t bufLen, buf, bufLen, offset); } +#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) +template +bool UnwindCursor::isReadableAddr(const pint_t addr) const { + // T

[clang] [llvm] [clang-tools-extra] [libunwind] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/74791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libunwind] [llvm] [clang] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -2974,6 +2966,39 @@ bool UnwindCursor::getFunctionName(char *buf, size_t bufLen, buf, bufLen, offset); } +#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) +template +bool UnwindCursor::isReadableAddr(const pint_t addr) const { + // T

[clang-tools-extra] [libunwind] [llvm] [clang] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -2974,6 +2966,39 @@ bool UnwindCursor::getFunctionName(char *buf, size_t bufLen, buf, bufLen, offset); } +#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) +template +bool UnwindCursor::isReadableAddr(const pint_t addr) const { + // T

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

2023-12-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 12cbccc3125725fad00022a9b3a52ed9be69c3a3 141be9754313d239d5a0df61fa18935cd276b0b5 --

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

2023-12-18 Thread Christopher Di Bella via cfe-commits
@@ -0,0 +1,100 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang] [llvm] [libc] [flang] [compiler-rt] [libcxx] [IR] Disallow ZeroInit for spirv.Image (PR #73887)

2023-12-18 Thread Wenju He via cfe-commits
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/73887 >From e369b5d62094c9b48f3c33075d764c115a208a74 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Thu, 30 Nov 2023 09:57:06 +0800 Subject: [PATCH] [IR] Disallow ZeroInit for spirv.Image According to spirv spec, OpCo

[clang] [libunwind] [clang-tools-extra] [llvm] [libunwind] Replace process_vm_readv with SYS_rt_sigprocmask (PR #74791)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -2974,6 +2966,39 @@ bool UnwindCursor::getFunctionName(char *buf, size_t bufLen, buf, bufLen, offset); } +#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) +template +bool UnwindCursor::isReadableAddr(const pint_t addr) const { + // T

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-12-18 Thread Daniel Chen via cfe-commits
DanielCChen wrote: I see. So Fortran and C interoperability of F2003/F2008 is not supported yet in Flang? Those ~100ish regression test cases we have were passing before this PR though. Unfortunately, those test cases are not made public available yet. I think I can copy the source code of on

[clang] [flang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-18 Thread via cfe-commits
h-vetinari wrote: It appears this PR now has conflicts that need resolving... https://github.com/llvm/llvm-project/pull/74377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] Added new check to detect redundant inline keyword (PR #73069)

2023-12-18 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/73069 From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Thu, 16 Nov 2023 22:03:15 -0500 Subject: [PATCH 01/13] =?UTF-8?q?[clang-tidy]=C2=A0

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2023-12-18 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/75883 It seems we were forgetting to call `checkArgsForPlaceholders` on the placement arguments of new-expressions in Sema. I don't think that was intended—at least doing so doesn't seem to break anything—so this pr

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2023-12-18 Thread via cfe-commits
Sirraide wrote: CC @AaronBallman https://github.com/llvm/llvm-project/pull/75883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2023-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes It seems we were forgetting to call `checkArgsForPlaceholders` on the placement arguments of new-expressions in Sema. I don't think that was intended—at least doing so doesn't seem to break anything—so this pr adds

[compiler-rt] [llvm] [libc] [libcxx] [clang] [compiler-rt]Add lld into dependency for apple builds now that lld Mach-O backend is available (PR #75884)

2023-12-18 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/75884 >From 2af4eed3a742173b8f385a5b8222e74d1c6e71ed Mon Sep 17 00:00:00 2001 From: Mingming Liu Date: Mon, 18 Dec 2023 17:22:10 -0800 Subject: [PATCH] [compiler-rt]Add lld into dependency for apple builds now tha

[llvm] [clang] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2023-12-18 Thread via cfe-commits
koachan wrote: Ping? https://github.com/llvm/llvm-project/pull/74927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix CTAD not respect default template arguments that were added after the definition. (PR #75569)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can we please add more detailed summaries, we want the git log to be sufficient for triaging various issues without having to dig into each commit individually. https://github.com/llvm/llvm-project/pull/75569 ___ cfe-commits mailing list

[clang] [clang] Fix CTAD not respect default template arguments that were added after the definition. (PR #75569)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
@@ -2061,13 +2070,13 @@ DeclResult Sema::CheckClassTemplate( if (!(TUK == TUK_Friend && CurContext->isDependentContext()) && CheckTemplateParameterList( TemplateParams, - PrevClassTemplate - ? PrevClassTemplate->getMostRecentDecl()->getTe

[clang] [clang][Interp] Implement integral->complex casts (PR #75590)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can we please have a more detailed summary for this PR? We rely on more detailed summaries in git logs. https://github.com/llvm/llvm-project/pull/75590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [OpenACC] Add 'clause' parsing infrastructure plus a few clauses (PR #75052)

2023-12-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/75052 >From 0bcee977f95f87a5ccf7bc53d6cd0a5d9521d963 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 8 Dec 2023 09:18:40 -0800 Subject: [PATCH 1/4] [OpenACC] Add 'clause' parsing infrastructure plus a few clau

[clang] fdee0a3 - [OpenACC] Add 'clause' parsing infrastructure plus a few clauses (#75052)

2023-12-18 Thread via cfe-commits
Author: Erich Keane Date: 2023-12-18T18:53:37-08:00 New Revision: fdee0a35d9da1febfab20ead8565cf6167103b51 URL: https://github.com/llvm/llvm-project/commit/fdee0a35d9da1febfab20ead8565cf6167103b51 DIFF: https://github.com/llvm/llvm-project/commit/fdee0a35d9da1febfab20ead8565cf6167103b51.diff L

[clang] [OpenACC] Add 'clause' parsing infrastructure plus a few clauses (PR #75052)

2023-12-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/75052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [llvm] [compiler-rt] [libc] [compiler-rt]Add lld into dependency for apple builds now that lld Mach-O backend is available (PR #75884)

2023-12-18 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/75884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement integral->complex casts (PR #75590)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
@@ -283,6 +283,28 @@ bool ByteCodeExprGen::VisitCastExpr(const CastExpr *CE) { case CK_ToVoid: return discard(SubExpr); + case CK_IntegralRealToComplex: + case CK_FloatingRealToComplex: { +// We're creating a complex value here, so we need to +// allocate stor

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: We need a release note and please add a more detailed summary. A description of the problem being solved and the solution to the fix provides. https://github.com/llvm/llvm-project/pull/72428 ___ cfe-commits mailing

[libcxx] [clang] [llvm] [compiler-rt] [libc] [compiler-rt]Add lld into dependency for apple builds now that lld Mach-O backend is available (PR #75884)

2023-12-18 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: thanks for the reviews! https://github.com/llvm/llvm-project/pull/75884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix issue 73559. (PR #74926)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
@@ -641,6 +641,8 @@ Bug Fixes in This Version Fixes (`#67317 `_) - Clang now properly diagnoses use of stand-alone OpenMP directives after a label (including ``case`` or ``default`` labels). +- Fix crash when using C++ only

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-12-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @sam-mccall ping~ https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix issue 73559. (PR #74926)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
shafik wrote: In the future please add a more description title to your PR. Your summary is great though. Also in this case this is a clang and parser fix so you should prefix your title with `[Clang][Parser]` https://github.com/llvm/llvm-project/pull/74926 ___

[llvm] [clang] DiagnosticHandler: refactor error checking (PR #75889)

2023-12-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/75889 In LLVMContext::diagnose, set `HasErrors` for `DS_Error` so that all derived `DiagnosticHandler` have correct `HasErrors` information. An alternative is to set `HasErrors` in `DiagnosticHandler::handleDiagnostics

[clang] [llvm] DiagnosticHandler: refactor error checking (PR #75889)

2023-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Fangrui Song (MaskRay) Changes In LLVMContext::diagnose, set `HasErrors` for `DS_Error` so that all derived `DiagnosticHandler` have correct `HasErrors` information. An alternative is to set `HasErrors` in `DiagnosticHandler::handl

[llvm] [clang] DiagnosticHandler: refactor error checking (PR #75889)

2023-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes In LLVMContext::diagnose, set `HasErrors` for `DS_Error` so that all derived `DiagnosticHandler` have correct `HasErrors` information. An alternative is to set `HasErrors` in `DiagnosticHandler::handleDiagnos

[llvm] [clang] DiagnosticHandler: refactor error checking (PR #75889)

2023-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Fangrui Song (MaskRay) Changes In LLVMContext::diagnose, set `HasErrors` for `DS_Error` so that all derived `DiagnosticHandler` have correct `HasErrors` information. An alternative is to set `HasErrors` in `DiagnosticHandler::handleDiagn

[llvm] [clang] DiagnosticHandler: refactor error checking (PR #75889)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -256,10 +256,13 @@ void LLVMContext::diagnose(const DiagnosticInfo &DI) { RS->emit(*OptDiagBase); // If there is a report handler, use it. - if (pImpl->DiagHandler && - (!pImpl->RespectDiagnosticFilters || isDiagnosticEnabled(DI)) && - pImpl->DiagHandler-

[lld] [llvm] [clang] [LTO] Improve diagnostics handling when parsing module-level inline assembly (PR #75726)

2023-12-18 Thread Fangrui Song via cfe-commits
@@ -418,6 +418,8 @@ void BackendConsumer::anchor() { } } // namespace clang bool ClangDiagnosticHandler::handleDiagnostics(const DiagnosticInfo &DI) { + if (DI.getSeverity() == DS_Error) +HasErrors = true; MaskRay wrote: I created https://github.com/llvm

[clang] Recommit [RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (#73765) (PR #75890)

2023-12-18 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat created https://github.com/llvm/llvm-project/pull/75890 Extend the multi-lib re-use selection mechanism for RISC-V. This funciton will try to re-use multi-lib if they are compatible. Definition of compatible: - ABI must be the same. - multi-lib is a subset of curre

[clang] Recommit [RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (#73765) (PR #75890)

2023-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) Changes Extend the multi-lib re-use selection mechanism for RISC-V. This funciton will try to re-use multi-lib if they are compatible. Definition of compatible: - ABI must be the same. - multi-lib is a subs

[clang] Recommit [RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (#73765) (PR #75890)

2023-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Brandon Wu (4vtomat) Changes Extend the multi-lib re-use selection mechanism for RISC-V. This funciton will try to re-use multi-lib if they are compatible. Definition of compatible: - ABI must be the same. - multi-lib is a subset

[clang] Recommit [RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (#73765) (PR #75890)

2023-12-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cdc03926696d674c6aa61b55d5b509d7118ed023 43ecdfdc5d96d1b53ccfc851e3dce8547b2f6fe9 --

[llvm] [clang] [RISCV] Add sifive-p450 CPU. (PR #75760)

2023-12-18 Thread Wang Pengcheng via cfe-commits
wangpc-pp wrote: Add test in `clang/test/Driver/riscv-cpus.c`? https://github.com/llvm/llvm-project/pull/75760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [mlir] [lldb] [lld] [llvm] GFX12: Add LoopDataPrefetchPass (PR #75625)

2023-12-18 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/75625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Add -Wswitch-default warning option (PR #73077)

2023-12-18 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wswitch-default %s + +int f1(int a) { + switch (a) {// expected-warning {{'switch' missing 'default' label}} +case 1: a++; break; +case 2: a += 2; break; + } + return a; +} sha

[clang] fix issue 73559. (PR #74926)

2023-12-18 Thread via cfe-commits
https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 9b703f6fcdb67eb921b3b5cf67b92bbd24144cf9 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Tue, 19 Dec 2023 05:14:06 +0100 Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only

[clang] [Clang][Parser] Fix crash of clang when using C++ constructs like :: in C code (PR #74926)

2023-12-18 Thread via cfe-commits
https://github.com/ChipsSpectre edited https://github.com/llvm/llvm-project/pull/74926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Fix crash of clang when using C++ constructs like :: in C code (PR #74926)

2023-12-18 Thread via cfe-commits
ChipsSpectre wrote: @shafik ok, done https://github.com/llvm/llvm-project/pull/74926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #75711)

2023-12-18 Thread Max Winkler via cfe-commits
MaxEW707 wrote: MSVC STL requires the x64 adc intel intrinsics. I moved those to a separate file `adcintrin.h` that can be included from `immintrin.h` and `intrin0.h` for x64. I also made a table [here ](https://gist.github.com/MaxEW707/2f4bf26801bc1b6b088aa7a2fadba526) of all the intrinsics

[clang] [openmp] [Clang][OpenMP] Fix mapping of structs to device (PR #75642)

2023-12-18 Thread Shilei Tian via cfe-commits
shiltian wrote: The newly added test `offloading/struct_mapping_with_pointers.cpp` fails on NVIDIA GPUs as well. ``` TEST 'libomptarget :: nvptx64-nvidia-cuda :: offloading/struct_mapping_with_pointers.cpp' FAILED Exit Code: 1 Command Output (stdout):

[clang] [flang] [lld] [llvm] [lldb] [libc] [mlir] [libcxx] [compiler-rt] [clang-tools-extra] Don't emit relax relocs like R_X86_64_REX_GOTPCRELX on X86 target for OPENMP internal vars. (PR #75564)

2023-12-18 Thread via cfe-commits
https://github.com/UmeshKalappa0 updated https://github.com/llvm/llvm-project/pull/75564 >From 4125e4a709c594562fa6c52f045ba7442e3cb523 Mon Sep 17 00:00:00 2001 From: Umesh Kalappa Date: Fri, 15 Dec 2023 11:52:52 +0530 Subject: [PATCH 1/3] Problem :For Kernel Modules ,emitting the relocs like

[libc] [libcxx] [compiler-rt] [llvm] [clang] [compiler-rt]Add lld into dependency for apple builds now that lld Mach-O backend is available (PR #75884)

2023-12-18 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/75884 >From 2af4eed3a742173b8f385a5b8222e74d1c6e71ed Mon Sep 17 00:00:00 2001 From: Mingming Liu Date: Mon, 18 Dec 2023 17:22:10 -0800 Subject: [PATCH] [compiler-rt]Add lld into dependency for apple builds now tha

[lldb] [libc] [libcxx] [clang-tools-extra] [compiler-rt] [llvm] [mlir] [clang] [lld] [flang] Don't emit relax relocs like R_X86_64_REX_GOTPCRELX on X86 target for OPENMP internal vars. (PR #75564)

2023-12-18 Thread via cfe-commits
UmeshKalappa0 wrote: > Scattering around `setDSOLocal(false)` makes the logic hard to understand. > I'd strongly prefer to fix the initial setting of dso_local when we create > the global variable. We can refactor the code to make that work. @efriedma-quic ,thank you for the suggestions and w

[mlir] [clang] [llvm] [clang-tools-extra] [mlir][TilingInterface] Early return cloned ops if tile sizes are zeros. (PR #75410)

2023-12-18 Thread via cfe-commits
@@ -362,14 +362,20 @@ mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter, TilingInterface op, auto clonedOp = cast( cloneOpAndUpdateDestinationArgs(rewriter, op, clonedOpDestination)); - // 5b. Tile the cloned operation. + // 5b. Early return cloned op if tiling is

[mlir] [clang] [llvm] [clang-tools-extra] [mlir][TilingInterface] Early return cloned ops if tile sizes are zeros. (PR #75410)

2023-12-18 Thread via cfe-commits
https://github.com/MaheshRavishankar approved this pull request. https://github.com/llvm/llvm-project/pull/75410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement integral->complex casts (PR #75590)

2023-12-18 Thread Timm Baeder via cfe-commits
@@ -283,6 +283,28 @@ bool ByteCodeExprGen::VisitCastExpr(const CastExpr *CE) { case CK_ToVoid: return discard(SubExpr); + case CK_IntegralRealToComplex: + case CK_FloatingRealToComplex: { +// We're creating a complex value here, so we need to +// allocate stor

[clang] [Concepts] Avoid substituting into constraints for invalid TemplateDecls (PR #75697)

2023-12-18 Thread Younan Zhang via cfe-commits
@@ -353,6 +353,10 @@ static ExprResult calculateConstraintSatisfaction( if (Inst.isInvalid()) return ExprError(); + // An empty expression for substitution failure messages. + if (Template && Template->isInvalidDecl()) +retur

[clang] [C++20] [Modules] Introduce reduced BMI (PR #75894)

2023-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/71034 See https://discourse.llvm.org/t/rfc-c-20-modules-introduce-thin-bmi-and-decls-hash/74755 This patch introduces red

[clang] [C++20] [Modules] Introduce reduced BMI (PR #75894)

2023-12-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cdc03926696d674c6aa61b55d5b509d7118ed023 6354bb468098f25b869deae3a475bf6bcfe37d40 --

[clang] [C++20] [Modules] Introduce reduced BMI (PR #75894)

2023-12-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: My impression to the feedbacks is that every one of us loves the direction, while we may need more agreement on the user interfaces. To make it easier to review, I split all the user interfaces related part to following patches. So that the current patch won't affect users.

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-12-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Since there is no meaningful review opinions here, let's continue it in a new and clean PR: https://github.com/llvm/llvm-project/pull/75894 https://github.com/llvm/llvm-project/pull/71622 ___ cfe-commits mailing list cfe-commits@list

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

2023-12-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/71622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

2023-12-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: As I summarized in https://discourse.llvm.org/t/rfc-c-20-modules-introduce-thin-bmi-and-decls-hash/74755/43, people are interested in this direction, but it may be too early for us to implement it. Let's postpone this. https://github.com/llvm/llvm-project/pull/71627

<    1   2   3   4   5   >