[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Erich Keane via cfe-commits
@@ -235,6 +235,7 @@ Non-comprehensive list of changes in this release except that it returns the size of a type ignoring tail padding. * ``__builtin_classify_type()`` now classifies ``_BitInt`` values as the return value ``18`` and vector types as return value ``19``, to m

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Erich Keane via cfe-commits
@@ -3657,6 +3657,21 @@ an error: }]; } +def MSConstexprDocs : Documentation { + let Category = DocCatStmt; + let Content = [{ +The ``[[msvc::constexpr]]`` attribute can be applied only to a function +definition or a ``return`` statement. It does not impact function declarati

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Erich Keane via cfe-commits
@@ -2884,6 +2884,12 @@ def warn_cxx11_compat_constexpr_body_multiple_return : Warning< InGroup, DefaultIgnore; def note_constexpr_body_previous_return : Note< "previous return statement is here">; +def err_ms_constexpr_not_distinct : Error< + "[[msvc::constexpr]] cannot b

[lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-08 Thread Felipe de Azevedo Piovezan via cfe-commits
https://github.com/felipepiovezan requested changes to this pull request. Hi @jeevanghimire, thank you for the PR! I believe the original issue was not about changing LLVM test inputs, but rather about changing clang-tidy to warn about this kind of patterns. Please see my rationale in a previo

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Erich Keane via cfe-commits
erichkeane wrote: Also, please don't 'force-push', just push an additional commit to your review. It erases history and makes reviewing it about 3x harder since history/context gets lost. https://github.com/llvm/llvm-project/pull/71300 ___ cfe-commi

[clang] [Clang][SME2] Add multi-vector zip & unzip builtins (PR #74841)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kerry McLaughlin (kmclaughlin-arm) Changes Adds the following SME2 builtins: - svzip (x2 & x4) - svzipq (x2 & x4) - svuzp (x2 & x4) - svuzpq (x2 & x4) See https://github.com/ARM-software/acle/pull/217/files Patch by David Sherwood

[clang] [Clang][SME2] Add multi-vector zip & unzip builtins (PR #74841)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kerry McLaughlin (kmclaughlin-arm) Changes Adds the following SME2 builtins: - svzip (x2 & x4) - svzipq (x2 & x4) - svuzp (x2 & x4) - svuzpq (x2 & x4) See https://github.com/ARM-software/acle/pull/217/files Patch by David Sher

[llvm] [clang] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-08 Thread Sander de Smalen via cfe-commits
@@ -449,6 +452,9 @@ bool ClangTableGenMain(raw_ostream &OS, RecordKeeper &Records) { case GenArmFP16: EmitFP16(Records, OS); break; + case GenArmVectorType: +EmitVectorType(Records, OS); sdesmalen-arm wrote: nit: please use "Types" (plural) ins

[clang] [llvm] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-08 Thread Sander de Smalen via cfe-commits
@@ -1,5 +1,4 @@ // RUN: %clang_cc1 %s -triple armv7 -fsyntax-only -verify -typedef __attribute__((neon_vector_type(2))) int int32x2_t; // expected-error{{'neon_vector_type' attribute is not supported on targets missing 'neon' or 'mve'; specify an appropriate -march= or -mcpu=

[llvm] [clang-tools-extra] [clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-08 Thread Sander de Smalen via cfe-commits
@@ -2355,13 +2357,7 @@ void NeonEmitter::run(raw_ostream &OS) { OS << "#include \n"; - // Emit NEON-specific scalar typedefs. - OS << "typedef float float32_t;\n"; - OS << "typedef __fp16 float16_t;\n"; - - OS << "#ifdef __aarch64__\n"; - OS << "typedef double float64_

[llvm] [clang] [ARM][AArch32] Add support for AArch32 Cortex-M52 CPU (PR #74822)

2023-12-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [flang] [lldb] [lld] [clang] [llvm] [libcxxabi] [libcxx] [clang-tools-extra] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-08 Thread Jay Foad via cfe-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +(!cas

[llvm] [clang-tools-extra] [clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-08 Thread Paul Walker via cfe-commits
@@ -2355,13 +2357,7 @@ void NeonEmitter::run(raw_ostream &OS) { OS << "#include \n"; - // Emit NEON-specific scalar typedefs. - OS << "typedef float float32_t;\n"; - OS << "typedef __fp16 float16_t;\n"; - - OS << "#ifdef __aarch64__\n"; - OS << "typedef double float64_

[flang] [clang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-08 Thread David Truby via cfe-commits
https://github.com/DavidTruby approved this pull request. LGTM sorry sometimes reviews get lost in the noise on GitHub... https://github.com/llvm/llvm-project/pull/74139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[llvm] [clang] [clang-tools-extra] [LoopVectorize] Improve algorithm for hoisting runtime checks (PR #73515)

2023-12-08 Thread David Sherwood via cfe-commits
@@ -346,7 +346,9 @@ void RuntimePointerChecking::tryToCreateDiffCheck( auto *SinkStartAR = cast(SinkStartInt); const Loop *StartARLoop = SrcStartAR->getLoop(); if (StartARLoop == SinkStartAR->getLoop() && -StartARLoop == InnerLoop->getParentLoop()) { +

[flang] [llvm] [clang] [clang-tools-extra] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread Kiran Chandramohan via cfe-commits
@@ -10,10 +10,50 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "flang/Runtime/character.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h" +#ifdef

[clang-tools-extra] [flang] [llvm] [clang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread David Truby via cfe-commits
@@ -37,5 +77,30 @@ void FORTRAN_PROCEDURE_NAME(getarg)( (void)RTNAME(GetCommandArgument)( n, &value, nullptr, nullptr, __FILE__, __LINE__); } + +// CALL GETLOG(USRNAME) +void FORTRAN_PROCEDURE_NAME(getlog)(std::int8_t *arg, std::int64_t length) { DavidT

[llvm] [clang-tools-extra] [flang] [clang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread David Truby via cfe-commits
@@ -6,6 +6,37 @@ // //===--===// +// character.h DavidTruby wrote: nit: `string.h` instead? This is really dealing with c-style strings rather than characters https://github.com/llvm/llvm-

[llvm] [flang] [clang] [clang-tools-extra] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread David Truby via cfe-commits
https://github.com/DavidTruby edited https://github.com/llvm/llvm-project/pull/74628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [flang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread David Truby via cfe-commits
https://github.com/DavidTruby approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [flang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread David Truby via cfe-commits
@@ -10,10 +10,50 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "flang/Runtime/character.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h" +#ifdef

[clang] 8758e64 - [ARM][AArch32] Add support for AArch32 Cortex-M52 CPU (#74822)

2023-12-08 Thread via cfe-commits
Author: Jonathan Thackray Date: 2023-12-08T15:04:08Z New Revision: 8758e648da5f3565dde6c0088f2509526b6c URL: https://github.com/llvm/llvm-project/commit/8758e648da5f3565dde6c0088f2509526b6c DIFF: https://github.com/llvm/llvm-project/commit/8758e648da5f3565dde6c0088f2509526b6c.diff

[llvm] [clang] [ARM][AArch32] Add support for AArch32 Cortex-M52 CPU (PR #74822)

2023-12-08 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/74822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [llvm] [NFC][AMDGPU] Move address space enum to LLVM directory (PR #73944)

2023-12-08 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/73944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space updated https://github.com/llvm/llvm-project/pull/74377 From e5ebda3272925b4f5956c15d0e61f7fbc0016129 Mon Sep 17 00:00:00 2001 From: Andrzej Warzynski Date: Sat, 2 Dec 2023 14:01:02 + Subject: [PATCH 1/2] [flang][driver] Rename `flang-new` as `flang` This pa

[clang] 23dc248 - [Clang][SVE2p1]Add svboolx2 and svboolx4 types for svcreate, svget, s… (#74594)

2023-12-08 Thread via cfe-commits
Author: CarolineConcatto Date: 2023-12-08T15:14:30Z New Revision: 23dc248ef02366ab33d3c2f99936ed75b1505b24 URL: https://github.com/llvm/llvm-project/commit/23dc248ef02366ab33d3c2f99936ed75b1505b24 DIFF: https://github.com/llvm/llvm-project/commit/23dc248ef02366ab33d3c2f99936ed75b1505b24.diff L

[clang] [Clang][SVE2p1]Add svboolx2 and svboolx4 types for svcreate, svget, s… (PR #74594)

2023-12-08 Thread via cfe-commits
https://github.com/CarolineConcatto closed https://github.com/llvm/llvm-project/pull/74594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 11dfb3c - Work around an ICE in MSVC; NFC

2023-12-08 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-12-08T10:20:31-05:00 New Revision: 11dfb3cb3237a081ad711b06f1e8efbc7fff7a81 URL: https://github.com/llvm/llvm-project/commit/11dfb3cb3237a081ad711b06f1e8efbc7fff7a81 DIFF: https://github.com/llvm/llvm-project/commit/11dfb3cb3237a081ad711b06f1e8efbc7fff7a81.diff

[clang] [AArch64][SME2] Add builtins to cast svbool from/to svcount. (PR #74720)

2023-12-08 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov updated https://github.com/llvm/llvm-project/pull/74720 >From e54baef2fe3f6249464ba55dcd18809a5018b146 Mon Sep 17 00:00:00 2001 From: Dinar Temirbulatov Date: Thu, 7 Dec 2023 14:46:11 + Subject: [PATCH 1/2] [AArch64][SME2] Add builtins to cast svbool from/to

[clang] [Clang][Sema] Print more static_assert exprs (PR #74852)

2023-12-08 Thread via cfe-commits
https://github.com/sethp created https://github.com/llvm/llvm-project/pull/74852 This change introspects more values involved in a static_assert, and extends the supported set of operators for introspection to include binary operator method calls. It's intended to address the use-case where a

[clang] [Clang][Sema] Print more static_assert exprs (PR #74852)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (sethp) Changes This change introspects more values involved in a static_assert, and extends the supported set of operators for introspection to include binary operator method calls. It's intended to address the use-case where a sma

[clang] [Clang][C++20] Implement constexpr std::bit_cast for bit-fields (& [Sema] Print more static_assert exprs) (PR #74775)

2023-12-08 Thread via cfe-commits
sethp wrote: Easy enough: I opened a PR for just those changes as https://github.com/llvm/llvm-project/pull/74852 . For now, I hope it's OK if I leave them here too as I continue working on the bit-cast part: I'd still like to have them locally, and there's a lot of `git rebase -i` involved to

[clang] [Clang][C++20] Implement constexpr std::bit_cast for bit-fields (PR #74775)

2023-12-08 Thread via cfe-commits
https://github.com/sethp edited https://github.com/llvm/llvm-project/pull/74775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++20] Implement constexpr std::bit_cast for bit-fields (PR #74775)

2023-12-08 Thread via cfe-commits
https://github.com/sethp edited https://github.com/llvm/llvm-project/pull/74775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 46a5693 - [FlowSensitive] Fix warnings

2023-12-08 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-12-08T07:56:45-08:00 New Revision: 46a56931251eba767929f6a2110da5b1bcbc5eb9 URL: https://github.com/llvm/llvm-project/commit/46a56931251eba767929f6a2110da5b1bcbc5eb9 DIFF: https://github.com/llvm/llvm-project/commit/46a56931251eba767929f6a2110da5b1bcbc5eb9.diff L

[clang] [flang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space updated https://github.com/llvm/llvm-project/pull/74377 From 1eefb9136ea042e44ada4be66a18b4bf69c18fe3 Mon Sep 17 00:00:00 2001 From: Andrzej Warzynski Date: Sat, 2 Dec 2023 14:01:02 + Subject: [PATCH 1/2] [flang][driver] Rename `flang-new` as `flang` This pa

[clang] [clang][Interp] Implement __builtin_rotate{right, left} (PR #72984)

2023-12-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/72984 >From 71ee39aaf9e962701168290394333654a22ed918 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 21 Nov 2023 13:44:07 +0100 Subject: [PATCH] [clang][Interp] Implement __builtin_rotate{right

Re: [clang] 46a5693 - [FlowSensitive] Fix warnings

2023-12-08 Thread Aaron Ballman via cfe-commits
Thank you for the fix, sorry for the trouble! ~Aaron On Fri, Dec 8, 2023 at 10:56 AM Kazu Hirata via cfe-commits wrote: > > > Author: Kazu Hirata > Date: 2023-12-08T07:56:45-08:00 > New Revision: 46a56931251eba767929f6a2110da5b1bcbc5eb9 > > URL: > https://github.com/llvm/llvm-project/commit/46a

[clang-tools-extra] [clang] [llvm] [LoopVectorize] Improve algorithm for hoisting runtime checks (PR #73515)

2023-12-08 Thread David Sherwood via cfe-commits
https://github.com/david-arm updated https://github.com/llvm/llvm-project/pull/73515 >From 30251642f8c208c63f3f3097c337ef0d5bc633b5 Mon Sep 17 00:00:00 2001 From: David Sherwood Date: Mon, 27 Nov 2023 13:43:26 + Subject: [PATCH 1/4] [LoopVectorize] Improve algorithm for hoisting runtime ch

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: The current setting pre-dates the visibility flags, so it makes sense that it wouldn't be needed anymore. This change makes sense to me, but it would be nice to verify. > I don't see any testing in tree for anything except clang What tests do you see in Clang for this spec

[clang] [flang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space updated https://github.com/llvm/llvm-project/pull/74377 From 1eefb9136ea042e44ada4be66a18b4bf69c18fe3 Mon Sep 17 00:00:00 2001 From: Andrzej Warzynski Date: Sat, 2 Dec 2023 14:01:02 + Subject: [PATCH 1/2] [flang][driver] Rename `flang-new` as `flang` This pa

[clang] [AArch64][SME2] Add builtins to cast svbool from/to svcount. (PR #74720)

2023-12-08 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov closed https://github.com/llvm/llvm-project/pull/74720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 49b27b1 - [AArch64][SME2] Add builtins to cast svbool from/to svcount. (#74720)

2023-12-08 Thread via cfe-commits
Author: Dinar Temirbulatov Date: 2023-12-08T16:38:29Z New Revision: 49b27b150b97c190dedf8b45bf991c4b811ed953 URL: https://github.com/llvm/llvm-project/commit/49b27b150b97c190dedf8b45bf991c4b811ed953 DIFF: https://github.com/llvm/llvm-project/commit/49b27b150b97c190dedf8b45bf991c4b811ed953.diff

[clang] [clang][Interp] Implement __builtin_rotate{right, left} (PR #72984)

2023-12-08 Thread Aaron Ballman via cfe-commits
@@ -331,3 +331,17 @@ namespace bitreverse { char bitreverse3[__builtin_bitreverse32(0x12345678) == 0x1E6A2C48 ? 1 : -1]; char bitreverse4[__builtin_bitreverse64(0x0123456789ABCDEFULL) == 0xF7B3D591E6A2C480 ? 1 : -1]; } + +namespace rotateleft { + char rotateleft1[__builti

[clang] [clang][Interp] Implement inc/dec for IntegralAP (PR #69597)

2023-12-08 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[flang] [clang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/74139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. I'm making two more small suggestions, but these are nits. Fell free to ignore. LGTM, thank you! [nit] "legacy flang" --> "Classic Flang" (in summary) https://github.com/llvm/llvm-project/pull/74139 ___

[clang] [flang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
@@ -6345,6 +6345,10 @@ def J : JoinedOrSeparate<["-"], "J">, Group, Alias; +def no_fortran_main : Flag<["-"], "fno-fortran-main">, + Visibility<[FlangOption]>, Group, + HelpText<"Don't link in Fortran main">; banach-space wrote: [nit] For folks less fam

[clang] [llvm] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-12-08 Thread Björn Pettersson via cfe-commits
bjope wrote: Is the behavior seen in this example expected? https://godbolt.org/z/f8eqEnsq6 The comments in InstCombineCompares kind of indicates that you try to avoid changing a signed predicate to a unsigned. But isn't that what happens here. As well as increasing the instruction count by

[clang] [clang][Interp] Implement IntegralAP::{div, rem} (PR #72614)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM aside from a test request. https://github.com/llvm/llvm-project/pull/72614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [clang][Interp] Implement IntegralAP::{div, rem} (PR #72614)

2023-12-08 Thread Aaron Ballman via cfe-commits
@@ -44,6 +44,24 @@ static_assert(MulA * MulB == 50, ""); // ref-error {{not an integral constant ex static_assert(MulA * 5 == 25, ""); static_assert(-1 * MulB == -7, ""); + +constexpr _BitInt(4) DivA = 2; +constexpr _BitInt(2) DivB = 1; +static_assert(DivA / DivB == 2, ""); +

[clang] [clang][Interp] Implement IntegralAP::{div, rem} (PR #72614)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/72614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [compiler-rt] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread Ellis Hoag via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from Inp

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I'm really liking the direction here -- this was a much more simple solution than I was expecting. Aside from some tiny nits, this looks good to me, but I leave it to Erich for the final sign-off. https://github.com/llvm/llvm-project/pull/71300 __

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/71300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Aaron Ballman via cfe-commits
@@ -5546,11 +5563,14 @@ static EvalStmtResult EvaluateStmt(StmtResult &Result, EvalInfo &Info, case Stmt::LabelStmtClass: return EvaluateStmt(Result, Info, cast(S)->getSubStmt(), Case); - case Stmt::AttributedStmtClass: -// As a general principle, C++11 attributes

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Aaron Ballman via cfe-commits
@@ -3657,6 +3657,21 @@ an error: }]; } +def MSConstexprDocs : Documentation { + let Category = DocCatStmt; + let Content = [{ +The ``[[msvc::constexpr]]`` attribute can be applied only to a function +definition or a ``return`` statement. It does not impact function declarati

[llvm] [clang] [Sema] Implement support for -Wformat-signedness (PR #74440)

2023-12-08 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I have started to implement defining the -Wformat-signedness option config in > clang/include/clang/Basic/DiagnosticSemaKinds.td as suggested originally by > @hazohelet and I agree that the implementation is a lot cleaner that way. > However before finishing implementing

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-08 Thread 徐持恒 Xu Chiheng via cfe-commits
https://github.com/xu-chiheng created https://github.com/llvm/llvm-project/pull/74868 None From 680b2b48925d52c006eee5f26b1173856dfcf376 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?= Date: Sat, 9 Dec 2023 00:59:00 +0800 Subject: [PATCH] [Cygwin] Cygwin

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: 徐持恒 Xu Chiheng (xu-chiheng) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74868.diff 2 Files Affected: - (modified) clang/lib/Basic/Targets/X86.h (+4-1) - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+3-1) `

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: 徐持恒 Xu Chiheng (xu-chiheng) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74868.diff 2 Files Affected: - (modified) clang/lib/Basic/Targets/X86.h (+4-1) - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+3-

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 49b27b150b97c190dedf8b45bf991c4b811ed953 680b2b48925d52c006eee5f26b1173856dfcf376 --

[clang] b842b1b - Fix tests hip-offload-compress-zlib/zstd.hip (#74783)

2023-12-08 Thread via cfe-commits
Author: Yaxun (Sam) Liu Date: 2023-12-08T12:04:01-05:00 New Revision: b842b1b65aab3bff2c3dbf439054aa8fe63f8400 URL: https://github.com/llvm/llvm-project/commit/b842b1b65aab3bff2c3dbf439054aa8fe63f8400 DIFF: https://github.com/llvm/llvm-project/commit/b842b1b65aab3bff2c3dbf439054aa8fe63f8400.dif

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/74783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-08 Thread 徐持恒 Xu Chiheng via cfe-commits
https://github.com/xu-chiheng updated https://github.com/llvm/llvm-project/pull/74868 From 680b2b48925d52c006eee5f26b1173856dfcf376 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?= Date: Sat, 9 Dec 2023 00:59:00 +0800 Subject: [PATCH 1/2] [Cygwin] Cygwin ba

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > %T is deprecated in lit. You may want to migrate other `%T` related to AMDGPU. Thanks. I will try cleaning them up. https://github.com/llvm/llvm-project/pull/74783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-08 Thread Sam Tebbs via cfe-commits
@@ -3168,11 +3168,70 @@ static void checkArmStreamingBuiltin(Sema &S, CallExpr *TheCall, << TheCall->getSourceRange() << "streaming compatible"; return; } + + if (FnType == ArmNonStreaming && BuiltinType == ArmStreaming) { +S.Diag(TheCall->getBeginLoc(), di

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-08 Thread Sam Tebbs via cfe-commits
@@ -20,3 +21,23 @@ int16x8_t incompat_neon_smc(int16x8_t splat) __arm_streaming_compatible { // expected-warning@+1 {{builtin call has undefined behaviour when called from a streaming compatible function}} return (int16x8_t)__builtin_neon_vqaddq_v((int8x16_t)splat, (int8x

[clang] [llvm] [clang][RISCV] Change default abi with f extension but without d extension (PR #73489)

2023-12-08 Thread Alex Bradbury via cfe-commits
asb wrote: > > I think the conclusion from the LLVM sync-up call was that everyone happy > > to move in this direction, so please add the release note and we can do a > > final review. Thanks! > > Done, added release note. Thanks! Sorry I wasn't specific about this, but we need a Clang releas

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg approved this pull request. Looks good to me. Thanks for following up! https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] Fix test rocm-detect.hip (PR #74872)

2023-12-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/74872 Replace %T with %t since %T is deprecated. >From 91160285c17ef9ba2b35e6e8c4a8eb433ec5ad8a Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 8 Dec 2023 12:24:19 -0500 Subject: [PATCH] Fix test rocm-det

[clang] Fix test rocm-detect.hip (PR #74872)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Replace %T with %t since %T is deprecated. --- Full diff: https://github.com/llvm/llvm-project/pull/74872.diff 1 Files Affected: - (modified) clang/test/Driver/rocm-detect.hip (+17-17) ``dif

[clang] Fix test rocm-detect.hip (PR #74872)

2023-12-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: It seems that is the only HIP test that still uses %T. https://github.com/llvm/llvm-project/pull/74872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-08 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/73258 >From e0f245e8d6a395afac5de471b55358c7b730a170 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 22 Nov 2023 10:03:50 + Subject: [PATCH 1/8] [Clang][AArch64] Add fix vector types to header

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-08 Thread Sam Tebbs via cfe-commits
@@ -500,6 +506,12 @@ bool ClangTableGenMain(raw_ostream &OS, RecordKeeper &Records) { case GenArmSmeRangeChecks: EmitSmeRangeChecks(Records, OS); break; + case GenArmSmeStreamingAttrs: SamTebbs33 wrote: Done https://github.com/llvm/llvm-project/pu

[clang] 731361c - [OpenACC] Fix bug with directive name being a 'special token'

2023-12-08 Thread via cfe-commits
Author: erichkeane Date: 2023-12-08T09:32:49-08:00 New Revision: 731361cd1540d0e729633833e6f3a670443c4b84 URL: https://github.com/llvm/llvm-project/commit/731361cd1540d0e729633833e6f3a670443c4b84 DIFF: https://github.com/llvm/llvm-project/commit/731361cd1540d0e729633833e6f3a670443c4b84.diff LO

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, but please wait until sometime mid-next week to land in case Richard has concerns. https://github.com/llvm/llvm-project/pull/70829 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [clang][Interp] Fix float->int casts overflowing (PR #72658)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/72658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Decay arrays to the first element (PR #72660)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/72660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Decay arrays to the first element (PR #72660)

2023-12-08 Thread Aaron Ballman via cfe-commits
@@ -27,6 +27,9 @@ static_assert(foo[2][3] == &m, ""); static_assert(foo[2][4] == nullptr, ""); +const int SomeInt[] = {1}; +int getSomeInt() { return *SomeInt; } AaronBallman wrote: ```suggestion constexpr int SomeInt[] = {1}; constexpr int getSomeInt() { re

[clang] [clang][Interp] Decay arrays to the first element (PR #72660)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM with a testing nit https://github.com/llvm/llvm-project/pull/72660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bbb8a0d - [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

2023-12-08 Thread Shafik Yaghmour via cfe-commits
Author: Shafik Yaghmour Date: 2023-12-08T09:38:59-08:00 New Revision: bbb8a0df7367068e1cf2fc54edd376beb976b430 URL: https://github.com/llvm/llvm-project/commit/bbb8a0df7367068e1cf2fc54edd376beb976b430 DIFF: https://github.com/llvm/llvm-project/commit/bbb8a0df7367068e1cf2fc54edd376beb976b430.dif

[clang] [clang][Interp] Diagnose reads from non-const global variables (PR #71919)

2023-12-08 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1005,12 +1008,23 @@ bool SetThisField(InterpState &S, CodePtr OpPC, uint32_t I) { template ::T> bool GetGlobal(InterpState &S, CodePtr OpPC, uint32_t I) { const Block *B = S.P.getGlobal(I); + + if (!CheckConstant(S, OpP

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2023-12-08 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -378,3 +378,92 @@ namespace Packs { static_assert(foo() == 2, ""); static_assert(foo<>() == 0, ""); } + +namespace std { +template struct remove_reference { using type = T; }; +template struct remove_reference { using

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2023-12-08 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM assuming no surprises come up from the additional test coverage. https://github.com/llvm/llvm-project/pull/70772 ___ cfe-commits ma

[clang] 94c8373 - [NFC] A few whitespace changes.

2023-12-08 Thread Paul Walker via cfe-commits
Author: Paul Walker Date: 2023-12-08T18:01:12Z New Revision: 94c837345c27e173284a85471d4efda19eded08e URL: https://github.com/llvm/llvm-project/commit/94c837345c27e173284a85471d4efda19eded08e DIFF: https://github.com/llvm/llvm-project/commit/94c837345c27e173284a85471d4efda19eded08e.diff LOG: [

[clang] [clang] Better bitfield access units (PR #65742)

2023-12-08 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > I'm planning to take a closer look at this when I have more time. Sorry I > haven't been more responsive here. When might that be? https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-08 Thread Jordan R AW via cfe-commits
@@ -2700,19 +2701,18 @@ bool UnwindCursor::setInfoForSigReturn(Registers_arm64 &) { // [1] https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/vdso/sigreturn.S const pint_t pc = static_cast(this->getReg(UNW_REG_IP)); // The PC might contain an invalid address

[compiler-rt] [libcxx] [lldb] [libcxxabi] [clang-tools-extra] [lld] [llvm] [clang] [flang] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-08 Thread Stanislav Mekhanoshin via cfe-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +(!cas

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread David Blaikie via cfe-commits
dwblaikie wrote: Probably would be good to introduce the `-v1` version and require it first, then eventually change the default - so people don't get a silent behavior change? Even the existing users only using `*` and `.` need to change their syntax to migrate to v2, right? They'll need to ch

[clang] a341e17 - Thread safety analysis: Fix a bug in handling temporary constructors (#74020)

2023-12-08 Thread via cfe-commits
Author: Ziqing Luo Date: 2023-12-08T10:29:37-08:00 New Revision: a341e177cea1cee800793d357264f6f46a3b4979 URL: https://github.com/llvm/llvm-project/commit/a341e177cea1cee800793d357264f6f46a3b4979 DIFF: https://github.com/llvm/llvm-project/commit/a341e177cea1cee800793d357264f6f46a3b4979.diff LO

[clang] Thread safety analysis: Fix a bug in handling temporary constructors (PR #74020)

2023-12-08 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/74020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [openmp] [lldb] [polly] [mlir] [lld] [llvm] [clang] [flang] [VPlan] Initial modeling of VF * UF as VPValue. (PR #74761)

2023-12-08 Thread Florian Hahn via cfe-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/74761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread Ellis Hoag via cfe-commits
ellishg wrote: > Probably would be good to introduce the `-v1` version and require it first, > then eventually change the default - so people don't get a silent behavior > change? Even the existing users only using `*` and `.` need to change their > syntax to migrate to v2, right? They'll need

[flang] [compiler-rt] [lldb] [libc] [openmp] [libcxx] [llvm] [libcxxabi] [clang-tools-extra] [mlir] [lld] [clang] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-08 Thread Hristo Hristov via cfe-commits
@@ -8,10 +8,7 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17 -// sentinel() = default; -// constexpr explicit sentinel(sentinel_t end); -// constexpr sentinel(sentinel s) -// requires Const && convertible_to, sentinel_t>; +// constexpr sentinel_t base() const; --

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread David Blaikie via cfe-commits
dwblaikie wrote: > > Probably would be good to introduce the `-v1` version and require it first, > > then eventually change the default - so people don't get a silent behavior > > change? Even the existing users only using `*` and `.` need to change their > > syntax to migrate to v2, right? Th

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-08 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google edited https://github.com/llvm/llvm-project/pull/74791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [compiler-rt] [clang-tools-extra] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread Mingming Liu via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from Inp

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-08 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: > I assume that /volatile:ms is a legacy behavior that non-Windows OSes likely > don't want to adopt. That is correct, it is legacy behavior. However, I think this flag has potential porting applications, similar to `-fshort-wchar`. I also think operating sys

<    1   2   3   4   >