[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-12-04 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Ping @erichkeane https://github.com/llvm/llvm-project/pull/72863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang] (Re-)Enable alias tags pass by default (PR #74250)

2023-12-04 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/74250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9db6423 - [clang][AMDGPU] fix the return type for ballot (#73906)

2023-12-04 Thread via cfe-commits
Author: Sameer Sahasrabuddhe Date: 2023-12-04T15:15:02+05:30 New Revision: 9db642394dee768e8a4404978c0e5d3af07fed17 URL: https://github.com/llvm/llvm-project/commit/9db642394dee768e8a4404978c0e5d3af07fed17 DIFF: https://github.com/llvm/llvm-project/commit/9db642394dee768e8a4404978c0e5d3af07fed1

[flang] [libcxx] [llvm] [libc] [compiler-rt] [clang-tools-extra] [clang] [clang][AMDGPU] fix the return type for ballot (PR #73906)

2023-12-04 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra closed https://github.com/llvm/llvm-project/pull/73906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fflush` in the StreamChecker (PR #74296)

2023-12-04 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/74296 None >From 2929f07a9ac2c462bf7aed9fe10307ef79659074 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 4 Dec 2023 15:51:20 +0800 Subject: [PATCH] [clang][analyzer] Support `fflush` in the StreamChecker --- ..

[clang] [clang][analyzer] Support `fflush` in the StreamChecker (PR #74296)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74296.diff 3 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp (+16) - (m

[clang] [llvm] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: FWIW, Alive2 is complaining about this commit. These patches are not safe w.r.t. undef. https://github.com/llvm/llvm-project/pull/72912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang-format] Fix a bug in `git-clang-format --binary` (PR #74293)

2023-12-04 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/74293 >From a394ac020c1045705fb2898d32754bdf12fac4bd Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 4 Dec 2023 01:03:18 -0800 Subject: [PATCH] [clang-format] Fix a bug in `git-clang-format --binary` This is a rewor

[compiler-rt] [clang] [mlir] [llvm] [clang-tools-extra] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-12-04 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: I'm not sure I understand why gcc is giving an error in https://godbolt.org/z/qGfnzhfsK. It doesn't give an error with `typename` keyword and I think there shouldn't be any difference since `Y::E` refers to current instantiation and is being used by class member declaration s

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Thanks! There should be no more warning. I tried to edit my GitHub settings, great if it worked, otherwise GitHub or personal email is fine. https://github.com/llvm/llvm-project/pull/72385 ___ cfe-commits mailing list cfe-commits@list

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/72385 >From c6b5aac2b5a3d90d11a8fc0d092c2e794cff5856 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Wed, 15 Nov 2023 01:13:10 -0800 Subject: [PATCH] [clang-tidy] Add new modernize-use-starts-ends-with check

[clang] [llvm] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2023-12-04 Thread Sameer Sahasrabuddhe via cfe-commits
@@ -170,20 +173,49 @@ static Value *appendString(IRBuilder<> &Builder, Value *Desc, Value *Arg, return callAppendStringN(Builder, Desc, Arg, Length, IsLast); } +static Value *appendVectorArg(IRBuilder<> &Builder, Value *Desc, Value *Arg, + bool

[llvm] [clang] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2023-12-04 Thread Sameer Sahasrabuddhe via cfe-commits
@@ -4742,6 +4742,16 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.ClaimAllArgs(options::OPT_gen_cdb_fragment_path); } + if (TC.getTriple().isAMDGPU() && types::isOpenCL(Input.getType())) { +if (Args.getLastArg(options::OPT_mprintf_kind_EQ))

[clang] [clang][dataflow] Retrieve members from accessors called using member… (PR #73978)

2023-12-04 Thread via cfe-commits
dyung wrote: @bazuzi and @martinboehme this change seems to be causing a test failure on many bots. Can you take a look and revert if you need time to investigate? - https://lab.llvm.org/buildbot/#/builders/139/builds/54773 - https://lab.llvm.org/buildbot/#/builders/216/builds/31319 - https://

[llvm] [clang] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2023-12-04 Thread Vikram Hegde via cfe-commits
@@ -4742,6 +4742,16 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.ClaimAllArgs(options::OPT_gen_cdb_fragment_path); } + if (TC.getTriple().isAMDGPU() && types::isOpenCL(Input.getType())) { +if (Args.getLastArg(options::OPT_mprintf_kind_EQ))

[flang] [clang] Revert "[flang][Driver] Let the linker fail on multiple definitions of main()" (PR #74120)

2023-12-04 Thread Tom Eccles via cfe-commits
tblah wrote: > @tblah Would you mind trying this new option with one application code to see > if that will help? Yes this flag works for me, thanks! I think it would be a shame to require a flag not needed for classic-flang or gfortran, but we can come back to this. This solution is good eno

[clang] [clang][dataflow] Retrieve members from accessors called using member… (PR #73978)

2023-12-04 Thread Jay Foad via cfe-commits
jayfoad wrote: Hi, on my Release+Asserts build this is causing: ``` FAIL: Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/32/38 (134 of 658) TEST 'Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/32/38' FAILED **

[llvm] [clang] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2023-12-04 Thread Sameer Sahasrabuddhe via cfe-commits
@@ -4742,6 +4742,16 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.ClaimAllArgs(options::OPT_gen_cdb_fragment_path); } + if (TC.getTriple().isAMDGPU() && types::isOpenCL(Input.getType())) { +if (Args.getLastArg(options::OPT_mprintf_kind_EQ))

[clang] [clang][dataflow] Retrieve members from accessors called using member… (PR #73978)

2023-12-04 Thread via cfe-commits
martinboehme wrote: > @bazuzi and @martinboehme this change seems to be causing a test failure on > many bots. Can you take a look and revert if you need time to investigate? > > * https://lab.llvm.org/buildbot/#/builders/139/builds/54773 > * https://lab.llvm.org/buildbot/#/builders/216/builds/

[clang] Revert "[clang][dataflow] Retrieve members from accessors called using member…" (PR #74299)

2023-12-04 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/74299 Reverts llvm/llvm-project#73978 >From 8e476a4944f7ff27b289620740b1d23aa9c57c88 Mon Sep 17 00:00:00 2001 From: martinboehme Date: Mon, 4 Dec 2023 11:27:14 +0100 Subject: [PATCH] =?UTF-8?q?Revert=20"[clang][d

[clang] 3b6d63c - Revert "[clang][dataflow] Retrieve members from accessors called using member…" (#74299)

2023-12-04 Thread via cfe-commits
Author: martinboehme Date: 2023-12-04T11:27:31+01:00 New Revision: 3b6d63c5193bf5e3ce04c71703fc5c681a62f094 URL: https://github.com/llvm/llvm-project/commit/3b6d63c5193bf5e3ce04c71703fc5c681a62f094 DIFF: https://github.com/llvm/llvm-project/commit/3b6d63c5193bf5e3ce04c71703fc5c681a62f094.diff

[clang] Revert "[clang][dataflow] Retrieve members from accessors called using member…" (PR #74299)

2023-12-04 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/74299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: @nicovank "nvankem...@fb.com" is fine ? To enable "meta.com" you may need to add this email in github and confirm it. Then it will allow you to select it as "default". https://github.com/llvm/llvm-project/pull/72385 ___ cfe-commits ma

[clang] Revert "[clang][dataflow] Retrieve members from accessors called using member…" (PR #74299)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes Reverts llvm/llvm-project#73978 --- Full diff: https://github.com/llvm/llvm-project/pull/74299.diff 2 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp (+2-5) - (modified)

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
bcl5980 wrote: We need at lease one more IR test. https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang] (Re-)Enable alias tags pass by default (PR #74250)

2023-12-04 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. LGTM, ta! https://github.com/llvm/llvm-project/pull/74250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-04 Thread Kiran Chandramohan via cfe-commits
kiranchandramohan wrote: Just a drive-through comment. The CI is failing for the following two tests. Clang :: CodeGen/aapcs-align.cpp Clang :: CodeGen/aapcs64-align.cpp https://github.com/llvm/llvm-project/pull/73258 ___ cfe-commits mailing list c

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: I've made it my primary email, if it's not an option, `@fb`, `@gmail`, or the GitHub indirection is fine. https://github.com/llvm/llvm-project/assets/7906725/6ae684b4-429b-4f09-bb97-f4525422da39";> https://github.com/llvm/llvm-project/pull/72385 ___

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-04 Thread Kiran Chandramohan via cfe-commits
@@ -0,0 +1,13 @@ +//===--- arm_vector_types.td - ARM Fixed vector types compiler interface ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-04 Thread Kiran Chandramohan via cfe-commits
@@ -2229,6 +2231,12 @@ void NeonEmitter::runHeader(raw_ostream &OS) { static void emitNeonTypeDefs(const std::string& types, raw_ostream &OS) { std::string TypedefTypes(types); std::vector TDTypeVec = TypeSpec::fromTypeSpecs(TypedefTypes); + // arm_sve.h followed by arm_ne

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-04 Thread Kiran Chandramohan via cfe-commits
@@ -2546,6 +2555,53 @@ void NeonEmitter::runFP16(raw_ostream &OS) { OS << "#endif /* __ARM_FP16_H */\n"; } +void NeonEmitter::runVectorType(raw_ostream &OS) { + OS << "/*=== arm_vector_types - ARM vector type " +"--===\n" +" *\n" +" *\n" +

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-04 Thread Kiran Chandramohan via cfe-commits
@@ -2229,6 +2231,12 @@ void NeonEmitter::runHeader(raw_ostream &OS) { static void emitNeonTypeDefs(const std::string& types, raw_ostream &OS) { std::string TypedefTypes(types); std::vector TDTypeVec = TypeSpec::fromTypeSpecs(TypedefTypes); + // arm_sve.h followed by arm_ne

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread Nikita Popov via cfe-commits
https://github.com/nikic commented: LoopUnroll supports upper bound unrolling. Why is it not working in this case? https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin (PR #74303)

2023-12-04 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau created https://github.com/llvm/llvm-project/pull/74303 None >From de96ce8075385a3404a24e6cb7d81e46e23f8089 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 4 Dec 2023 10:55:24 + Subject: [PATCH] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin

[clang] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin (PR #74303)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matthew Devereau (MDevereau) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74303.diff 1 Files Affected: - (modified) clang/include/clang/Basic/arm_sme.td (+1-1) ``diff diff --git a/clang/include/clang/Basi

[llvm] [clang] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

2023-12-04 Thread Matthew Devereau via cfe-commits
@@ -298,3 +298,11 @@ multiclass ZAAddSub { defm SVADD : ZAAddSub<"add">; defm SVSUB : ZAAddSub<"sub">; + +// +// Spill and fill of ZT0 +// +let TargetGuard = "sme2" in { + def SVLDR_ZT : Inst<"svldr_zt", "viQ", "", MergeNone, "aarch64_sme_ldr_zt", [IsOverloadNone, IsStreamin

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-04 Thread Shengchen Kan via cfe-commits
KanRobert wrote: @phoebewang Thanks for the review! https://github.com/llvm/llvm-project/pull/74199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6d6baef - [X86] Support CFE flags for APX features (#74199)

2023-12-04 Thread via cfe-commits
Author: Shengchen Kan Date: 2023-12-04T19:22:56+08:00 New Revision: 6d6baef5c9bf880a28c3b9861fc5c1f578b6635c URL: https://github.com/llvm/llvm-project/commit/6d6baef5c9bf880a28c3b9861fc5c1f578b6635c DIFF: https://github.com/llvm/llvm-project/commit/6d6baef5c9bf880a28c3b9861fc5c1f578b6635c.diff

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-04 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert closed https://github.com/llvm/llvm-project/pull/74199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin (PR #74303)

2023-12-04 Thread David Sherwood via cfe-commits
@@ -319,7 +319,7 @@ let TargetGuard = "sme2" in { // Spill and fill of ZT0 // let TargetGuard = "sme2" in { - def SVLDR_ZT : Inst<"svldr_zt", "viQ", "", MergeNone, "aarch64_sme_ldr_zt", [IsOverloadNone, IsStreamingCompatible, IsSharedZA, IsPreservesZA], [ImmCheck<0, ImmCheck

[clang] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin (PR #74303)

2023-12-04 Thread Sander de Smalen via cfe-commits
@@ -319,7 +319,7 @@ let TargetGuard = "sme2" in { // Spill and fill of ZT0 // let TargetGuard = "sme2" in { - def SVLDR_ZT : Inst<"svldr_zt", "viQ", "", MergeNone, "aarch64_sme_ldr_zt", [IsOverloadNone, IsStreamingCompatible, IsSharedZA, IsPreservesZA], [ImmCheck<0, ImmCheck

[clang] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin (PR #74303)

2023-12-04 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/74303 >From de96ce8075385a3404a24e6cb7d81e46e23f8089 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 4 Dec 2023 10:55:24 + Subject: [PATCH 1/2] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin --

[clang] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin (PR #74303)

2023-12-04 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/74303 >From de96ce8075385a3404a24e6cb7d81e46e23f8089 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 4 Dec 2023 10:55:24 + Subject: [PATCH 1/3] [AArch64][SME2] Remove IsPreservesZA from ldr_zt builtin --

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: @nicovank Interesting, still shows fb as main email, most probably because commit were done from that one, you could try to change commit email and do force push, could help. Sad thing is that if you would have ability to click squash and merge, then it would show you option to

[clang] d43c081 - [clang][CGOpenMPRuntimeGPU] Merge consecutive AddrSpaceCasts (NFC) (#74279)

2023-12-04 Thread via cfe-commits
Author: Youngsuk Kim Date: 2023-12-04T07:03:09-05:00 New Revision: d43c081aef505b0f1d5e887a365cd69e7f9f37b2 URL: https://github.com/llvm/llvm-project/commit/d43c081aef505b0f1d5e887a365cd69e7f9f37b2 DIFF: https://github.com/llvm/llvm-project/commit/d43c081aef505b0f1d5e887a365cd69e7f9f37b2.diff

[clang] [clang][CGOpenMPRuntimeGPU] Merge consecutive AddrSpaceCasts (NFC) (PR #74279)

2023-12-04 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 closed https://github.com/llvm/llvm-project/pull/74279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: > We need at lease one more IR test. Let me try https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in `git-clang-format --binary` (PR #74293)

2023-12-04 Thread Jay Foad via cfe-commits
https://github.com/jayfoad approved this pull request. LGTM but the commit message should really explain what problem this fixes instead of just saying "rework". https://github.com/llvm/llvm-project/pull/74293 ___ cfe-commits mailing list cfe-commits@

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: > LoopUnroll supports upper bound unrolling. Why is it not working in this case? for example: #program unroll for (int I = 0; I < LoopCount; ++I) { // ConstNum > 1 if (Cond2) { break; } xxx loop body; } After the branches fodling, the old loop condition "I < LoopCount" changed/

[clang] f9afe40 - [clang][NFC] Fill in historical data on when C++ DRs 400-499 were fixed

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-12-04T15:15:40+03:00 New Revision: f9afe4049a8829aa8dad64b0eb7dccc8dd4a8bbe URL: https://github.com/llvm/llvm-project/commit/f9afe4049a8829aa8dad64b0eb7dccc8dd4a8bbe DIFF: https://github.com/llvm/llvm-project/commit/f9afe4049a8829aa8dad64b0eb7dccc8dd4a8bbe.

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/74311 This patch continues the work started with ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding PR for details. >From fc5d07e9917e84b7927b4d3f6ea5058b008f120f Mon Sep 17 00:00:00 2001

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch continues the work started with ea5b1ef016d020c37f903d6c7d4f623be975dab8. See that commit and its corresponding PR for details. --- Patch is 51.63 KiB, truncated to 20.00 KiB below, full v

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: This PR is opened to check this patch against pre-commit CI. https://github.com/llvm/llvm-project/pull/74311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [clang-tools-extra] [flang ]GETLOG runtime and extension implementation: get login username (PR #70917)

2023-12-04 Thread Yi Wu via cfe-commits
yi-wu-arm wrote: Hi @klausler, thanks for the comment, I have changed the initial letters and add `const` to buffer in function declaration. Is there anything else I should pay attention to? Thanks in advance! https://github.com/llvm/llvm-project/pull/70917

[clang] [flang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-04 Thread David Truby via cfe-commits
DavidTruby wrote: I think this solution is fine, at least in the short term. I had a think after reviewing the initial patch and looking at the failure that @tblah showed in #73124; my thoughts are that the “correct” way of doing this would be instead of linking Fortran_main all the time, we

[clang] [analyzer] Let the checkers query upper and lower bounds on symbols (PR #74141)

2023-12-04 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. The patch makes sense to me. https://github.com/llvm/llvm-project/pull/74141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-04 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm updated https://github.com/llvm/llvm-project/pull/74139 >From 2e41335a7de3d2efa88eacee659172a3b9525e45 Mon Sep 17 00:00:00 2001 From: Michael Klemm Date: Fri, 1 Dec 2023 21:41:44 +0100 Subject: [PATCH 1/5] Add -fno-fortran-main driver option --- clang/include/clang/

[flang] [clang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-04 Thread Michael Klemm via cfe-commits
mjklemm wrote: > I think this solution is fine, at least in the short term. > > I had a think after reviewing the initial patch and looking at the failure > that @tblah showed in #73124; my thoughts are that the “correct” way of doing > this would be instead of linking Fortran_main all the tim

[flang] [clang] [flang][driver] Add -fno-fortran-main (link time) option to remove Fortran_main from link line (PR #74139)

2023-12-04 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm updated https://github.com/llvm/llvm-project/pull/74139 >From 2e41335a7de3d2efa88eacee659172a3b9525e45 Mon Sep 17 00:00:00 2001 From: Michael Klemm Date: Fri, 1 Dec 2023 21:41:44 +0100 Subject: [PATCH 1/5] Add -fno-fortran-main driver option --- clang/include/clang/

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-12-04 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/72107 __

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-12-04 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. Sorry for reporting back only after a week or so. The analysis wa

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-12-04 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -413,6 +464,19 @@ bool ArrayBoundCheckerV2::isFromCtypeMacro(const Stmt *S, ASTContext &ACtx) {

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/74311 >From fc5d07e9917e84b7927b4d3f6ea5058b008f120f Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 4 Dec 2023 15:15:08 +0300 Subject: [PATCH 1/2] [clang][NFC] Refactor expected directives in C++ DRs 40

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread Nikita Popov via cfe-commits
nikic wrote: Can you please share the IR before the unroll pass? https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in `git-clang-format --binary` (PR #74293)

2023-12-04 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/74293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Add intrinsics & builtins for S/URSHL (single, multi) (PR #74066)

2023-12-04 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov closed https://github.com/llvm/llvm-project/pull/74066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/74311 >From fc5d07e9917e84b7927b4d3f6ea5058b008f120f Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 4 Dec 2023 15:15:08 +0300 Subject: [PATCH 1/3] [clang][NFC] Refactor expected directives in C++ DRs 40

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: > Can you please share the IR before the unroll pass? Sure: **with this patch**: 4523 ; *** IR Dump After LoopDeletionPass on for.body *** 4524 4525 ; Preheader: 4526 entry: 4527 br label %for.body 4528 4529 ; Loop: 4530 for.body:

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/74311 >From fc5d07e9917e84b7927b4d3f6ea5058b008f120f Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 4 Dec 2023 15:15:08 +0300 Subject: [PATCH 1/4] [clang][NFC] Refactor expected directives in C++ DRs 40

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-04 Thread via cfe-commits
xiangzh1 wrote: I first guess the trip.count maybe too small, but I changed the iteration Num from 16 to 1600, without this patch, it still not unroll. https://github.com/llvm/llvm-project/pull/74268 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-04 Thread Owen Pan via cfe-commits
@@ -153,8 +157,13 @@ def main(): else: if len(commits) > 2: die('at most two commits allowed; %d given' % len(commits)) + if len(commits) < 2 and opts.diff_from_common_commit: +die('--diff_from_common_commit is only allowed when two commits are given')

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-04 Thread Owen Pan via cfe-commits
@@ -328,6 +337,10 @@ def compute_diff(commits, files, staged): git_tool = 'diff-tree' elif staged: extra_args += ['--cached'] + + if len(commits) > 1 and diff_common_commit: +commits = [f'{commits[0]}...{commits[1]}'] owenca wrote: ```suggestion

[lldb] [lld] [libc] [compiler-rt] [mlir] [libcxx] [openmp] [llvm] [clang-tools-extra] [libunwind] [flang] [clang] [libcxxabi] [C23] Implement N3018: The constexpr specifier for object definitions (PR

2023-12-04 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 1/7] [C23] Implement N3018: The constexpr specifier f

[lldb] [lld] [libc] [compiler-rt] [mlir] [libcxx] [openmp] [llvm] [clang-tools-extra] [libunwind] [flang] [clang] [libcxxabi] [C23] Implement N3018: The constexpr specifier for object definitions (PR

2023-12-04 Thread Mariya Podchishchaeva via cfe-commits
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc, : IdentLoc); } +static ImplicitConversionKind getConversionKind(QualType FromType, +

[clang] c556c9c - [clang][NFC] Refactor expected directives in C++ DRs 400-499 (#74311)

2023-12-04 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-12-04T18:00:09+04:00 New Revision: c556c9c3792a322dfc3a9c60be9d7d32cf335235 URL: https://github.com/llvm/llvm-project/commit/c556c9c3792a322dfc3a9c60be9d7d32cf335235 DIFF: https://github.com/llvm/llvm-project/commit/c556c9c3792a322dfc3a9c60be9d7d32cf335235.

[clang] [clang][NFC] Refactor expected directives in C++ DRs 400-499 (PR #74311)

2023-12-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/74311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enhance handling of Apple-specific '-arch'/'-target' option values (PR #72821)

2023-12-04 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: @MaskRay @TNorthover @Artem-B Would be glad to see you review on the changes https://github.com/llvm/llvm-project/pull/72821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/72385 >From 2b7748352281eb1dfa85cc8e4672488dfadee277 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Wed, 15 Nov 2023 01:13:10 -0800 Subject: [PATCH] [clang-tidy] Add new modernize-use-starts-ends-with check

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Changed author to `@meta` in latest push, hopefully this fixes it... Didn't realise `@fb` was still default on my server. https://github.com/llvm/llvm-project/pull/72385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [Clang] Emit TBAA info for enums in C (PR #73326)

2023-12-04 Thread David Sherwood via cfe-commits
david-arm wrote: Gentle ping! https://github.com/llvm/llvm-project/pull/73326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'cache' construct parsing (PR #74324)

2023-12-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/74324 The 'cache' construct takes a list of 'vars', which are array-section style definitions. This patch implements the parsing, leaving the lower bound and length of the bound as expressions, so that we can valid

[clang] [OpenACC] Implement 'cache' construct parsing (PR #74324)

2023-12-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes The 'cache' construct takes a list of 'vars', which are array-section style definitions. This patch implements the parsing, leaving the lower bound and length of the bound as expressions, so that we can va

[clang-tools-extra] bc8cff1 - [clang-tidy] Add new modernize-use-starts-ends-with check (#72385)

2023-12-04 Thread via cfe-commits
Author: Nicolas van Kempen Date: 2023-12-04T15:39:28+01:00 New Revision: bc8cff1d7fb2069aa3f7333e25642f2571049af1 URL: https://github.com/llvm/llvm-project/commit/bc8cff1d7fb2069aa3f7333e25642f2571049af1 DIFF: https://github.com/llvm/llvm-project/commit/bc8cff1d7fb2069aa3f7333e25642f2571049af1.

[clang-tools-extra] [clang-tidy] Add new modernize-use-starts-ends-with check (PR #72385)

2023-12-04 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/72385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [openmp] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-12-04 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > but there appears to be no way to introspect the UnresolvedLookupExpr to > ensure I'm matching calls to `std::move` Try searching for `unresolvedLookupExpr` & `UnresolvedLookupExpr` in the clang-tidy directory. There is a high probability that another check has done somethin

[llvm] [clang] [Verifier] Check function attributes related to branch protection (NFC) (PR #70565)

2023-12-04 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/70565 >From 66a84fffb5d1b5c34eea9ecdb83a88afb0b627ff Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Sat, 28 Oct 2023 15:01:36 +0100 Subject: [PATCH 1/4] [Verifier] Check function attributes related to bra

[clang] [AArch64][SME2] Add _x2/_x4 svqrshr builtins. (PR #74100)

2023-12-04 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov updated https://github.com/llvm/llvm-project/pull/74100 >From f1fb62ba84d94d2e63efa97e2a3d98c633509589 Mon Sep 17 00:00:00 2001 From: Dinar Temirbulatov Date: Fri, 1 Dec 2023 16:27:42 + Subject: [PATCH 1/2] [AArch64][SME2] Add _x2/_x4 svqrshr builtins. Patc

[clang] [clang][Sema] Add -Wswitch-default warning option (PR #73077)

2023-12-04 Thread Erich Keane via cfe-commits
erichkeane wrote: I think there is value to adding this if only for the GCC compat story here. I realize we don't like non-on-by-default warnings, but it IS something that folks use reasonably often, and we've even acquiesced to making it an ignored flag IIRC. Aaron is the real decision make

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-12-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/72863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 374e828 - [flang] (Re-)Enable alias tags pass by default (#74250)

2023-12-04 Thread via cfe-commits
Author: Tom Eccles Date: 2023-12-04T15:28:15Z New Revision: 374e8288e047da640090629879072e4fa3af31fe URL: https://github.com/llvm/llvm-project/commit/374e8288e047da640090629879072e4fa3af31fe DIFF: https://github.com/llvm/llvm-project/commit/374e8288e047da640090629879072e4fa3af31fe.diff LOG: [f

[clang] [flang] [flang] (Re-)Enable alias tags pass by default (PR #74250)

2023-12-04 Thread Tom Eccles via cfe-commits
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/74250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-12-04 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. thanks a lot (and sorry for missing this, so far) https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-12-04 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-12-04 Thread kadir çetinkaya via cfe-commits
@@ -189,6 +189,10 @@ llvm::Expected Marshaller::fromProtobuf(const Ref &Message) { return Location.takeError(); Result.Location = *Location; Result.Kind = static_cast(Message.kind()); + auto ContainerID = SymbolID::fromStr(Message.container()); + if (!ContainerID) +

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2023-12-04 Thread kadir çetinkaya via cfe-commits
@@ -223,6 +223,7 @@ TEST(RemoteMarshallingTest, RefSerialization) { Location.FileURI = testPathURI( "llvm-project/llvm/clang-tools-extra/clangd/Protocol.h", Strings); Ref.Location = Location; + Ref.Container = llvm::cantFail(SymbolID::fromStr("0001")); --

[clang-tools-extra] [clang-tidy] readability-container-contains literal suffixes (PR #74215)

2023-12-04 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/74215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Exclude non-template classes when checking if constraint refers to containing template arguments (PR #74265)

2023-12-04 Thread Erich Keane via cfe-commits
@@ -1714,6 +1714,8 @@ class ConstraintRefersToContainingTemplateChecker // Friend, likely because it was referred to without its template arguments. void CheckIfContainingRecord(const CXXRecordDecl *CheckingRD) { CheckingRD = CheckingRD->getMostRecentDecl(); +if (!C

[clang] [clang] Exclude non-template classes when checking if constraint refers to containing template arguments (PR #74265)

2023-12-04 Thread Erich Keane via cfe-commits
@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -std=c++20 -verify %s + +template +concept C = true; + +class non_temp { +template T> +friend void f(); + +non_temp(); +}; + +template T> +void f() { +auto v = non_temp(); +} + +template +class temp { +template T> +frien

[libc] [libcxx] [llvm] [compiler-rt] [clang-tools-extra] [clang] [mlir] [flang] [mlir][nvvm] Introduce `fence.mbarrier.init` (PR #74058)

2023-12-04 Thread Guray Ozen via cfe-commits
https://github.com/grypp updated https://github.com/llvm/llvm-project/pull/74058 >From 9f35504e81246f97a9d8c14a06043685660ae15e Mon Sep 17 00:00:00 2001 From: Guray Ozen Date: Fri, 1 Dec 2023 11:10:40 +0100 Subject: [PATCH 1/2] [mlir][nvvm] Introduce `fence.mbarrier.init` This PR introduce `fen

[clang] [clang] assert fail when number of arguments in pack exceed implement… (PR #74220)

2023-12-04 Thread via cfe-commits
wheatman wrote: I'll change it from a assert to a diagnostic, my thought had been that it is not a fault with the program, but an issue with the compiler so figured it should be an assert. In that case I assume it should be an error and not a warning since I don't believe a correct program cou

<    1   2   3   4   >