[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-07 Thread Balázs Kéri via cfe-commits
balazske wrote: This change looks not very useful to me. These removed return statements indicate that at the end of the `if` branch there is no more work to do in this function, and it reduces complexity (less execution paths). The code becomes a bit shorter but not necessarily more easy to u

[clang] [polly] [llvm] [mlir] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-07 Thread Paulo Matos via cfe-commits
https://github.com/pmatos updated https://github.com/llvm/llvm-project/pull/71029 >From fe3ed6bcc6eface6e7bfa3e9b043f8287dd129b0 Mon Sep 17 00:00:00 2001 From: Paulo Matos Date: Fri, 3 Nov 2023 12:03:07 +0100 Subject: [PATCH 1/4] [NFC] Remove Type::getInt8PtrTy Replace this with PointerType::g

[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71394 >From f4115e95349fdc6970e40176aafd89ef12d3f14b Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Tue, 7 Nov 2023 14:11:37 +0800 Subject: [PATCH] [clang][analyzer][NFC] Remove redundant code in StreamChecker --- cl

[clang] 6b573f4 - [clang][dataflow] Fix assert-fail when calling assignment operator with by-value parameter. (#71384)

2023-11-07 Thread via cfe-commits
Author: martinboehme Date: 2023-11-07T09:48:40+01:00 New Revision: 6b573f4611df470c23c7048fe820e0f216e9a8e1 URL: https://github.com/llvm/llvm-project/commit/6b573f4611df470c23c7048fe820e0f216e9a8e1 DIFF: https://github.com/llvm/llvm-project/commit/6b573f4611df470c23c7048fe820e0f216e9a8e1.diff

[clang] [clang][dataflow] Fix assert-fail when calling assignment operator with by-value parameter. (PR #71384)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/71384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-07 Thread Ben Shi via cfe-commits
benshi001 wrote: How about only remove the second `return State` ? The removal of the first one may be less readable. But for the second one, it is very near to the final `return State`. It may looks strange for very near `return State`s. ``` if () { return State; } return State; ``` http

[llvm] [clang] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2023-11-07 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap updated https://github.com/llvm/llvm-project/pull/71019 >From ef0118818249da417706db7f8e7086d051d17d50 Mon Sep 17 00:00:00 2001 From: Pravin Jagtap Date: Thu, 2 Nov 2023 01:05:35 -0400 Subject: [PATCH 1/4] [AMDGPU] Add code model (#70760) test for amdgpu target.

[llvm] [clang] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2023-11-07 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap updated https://github.com/llvm/llvm-project/pull/71019 >From ef0118818249da417706db7f8e7086d051d17d50 Mon Sep 17 00:00:00 2001 From: Pravin Jagtap Date: Thu, 2 Nov 2023 01:05:35 -0400 Subject: [PATCH 1/4] [AMDGPU] Add code model (#70760) test for amdgpu target.

[llvm] [clang] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2023-11-07 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap updated https://github.com/llvm/llvm-project/pull/71019 >From ef0118818249da417706db7f8e7086d051d17d50 Mon Sep 17 00:00:00 2001 From: Pravin Jagtap Date: Thu, 2 Nov 2023 01:05:35 -0400 Subject: [PATCH 1/5] [AMDGPU] Add code model (#70760) test for amdgpu target.

[llvm] [clang] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2023-11-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bd29197fd8448265dbf8e370a8a21a477cd50f5a 746c51563292dd42145ea18414dadf9acf18aea2 --

[llvm] [clang] Reapply #2 [clang-repl] [test] Make an XFAIL more precise (PR #71168)

2023-11-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/71168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Reapply #2 [clang-repl] [test] Make an XFAIL more precise (PR #71168)

2023-11-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/71168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2c4f938 - Reapply #2 [clang-repl] [test] Make an XFAIL more precise (#71168)

2023-11-07 Thread via cfe-commits
Author: Martin Storsjö Date: 2023-11-07T11:41:56+02:00 New Revision: 2c4f938f1c01794d9b944c24e9067eac6763e95c URL: https://github.com/llvm/llvm-project/commit/2c4f938f1c01794d9b944c24e9067eac6763e95c DIFF: https://github.com/llvm/llvm-project/commit/2c4f938f1c01794d9b944c24e9067eac6763e95c.diff

[llvm] [clang] Reapply #2 [clang-repl] [test] Make an XFAIL more precise (PR #71168)

2023-11-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/71168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [flang] [clang-tools-extra] [libcxx] [lldb] [openmp] [compiler-rt] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-07 Thread Giorgis Georgakoudis via cfe-commits
ggeorgakoudis wrote: LGTM but fix comments: 1. Comments should be in their own line, move them above the relevant line 2. Comments should be complete sentences ending with a full stop https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mail

[clang] 0d3eeac - [clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter on MinGW (#71393)

2023-11-07 Thread via cfe-commits
Author: Martin Storsjö Date: 2023-11-07T11:48:12+02:00 New Revision: 0d3eeac8c0f45410398a87f72ae38ea6ae1c3073 URL: https://github.com/llvm/llvm-project/commit/0d3eeac8c0f45410398a87f72ae38ea6ae1c3073 DIFF: https://github.com/llvm/llvm-project/commit/0d3eeac8c0f45410398a87f72ae38ea6ae1c3073.diff

[clang] [clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter on MinGW (PR #71393)

2023-11-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/71393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

2023-11-07 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This is superseded by #71393 which was merged now. https://github.com/llvm/llvm-project/pull/66881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-07 Thread Balázs Kéri via cfe-commits
https://github.com/balazske approved this pull request. https://github.com/llvm/llvm-project/pull/71394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

2023-11-07 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68565 >From de07976922782b9dcf5d13d44551b782dc8b3b94 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/7] [AArch64][SME] Remove immediate argument restriction for sv

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-11-07 Thread Dinar Temirbulatov via cfe-commits
@@ -257,7 +257,7 @@ class ImmCheck { } class Inst ft, list ch, MemEltType met> { + list ft, list ch, MemEltType met = MemEltTyDefault> { dtemirbulatov wrote: I am not sure about propose of this change "met = MemEltTyDefault"? The last parameter i

[clang] 6b43764 - [clang][ExtractAPI] Update availability serialization in SGF (#71418)

2023-11-07 Thread via cfe-commits
Author: Daniel Grumberg Date: 2023-11-07T10:44:45Z New Revision: 6b43764a9553b1aa09013298d5ec8905dd635308 URL: https://github.com/llvm/llvm-project/commit/6b43764a9553b1aa09013298d5ec8905dd635308 DIFF: https://github.com/llvm/llvm-project/commit/6b43764a9553b1aa09013298d5ec8905dd635308.diff LO

[clang] [clang][ExtractAPI] Update availability serialization in SGF (PR #71418)

2023-11-07 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg closed https://github.com/llvm/llvm-project/pull/71418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2023-11-07 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap updated https://github.com/llvm/llvm-project/pull/71019 >From ef0118818249da417706db7f8e7086d051d17d50 Mon Sep 17 00:00:00 2001 From: Pravin Jagtap Date: Thu, 2 Nov 2023 01:05:35 -0400 Subject: [PATCH 1/6] [AMDGPU] Add code model (#70760) test for amdgpu target.

[llvm] [clang-tools-extra] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-07 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/70829 >From ac30780250875802d13450d17e6959f9e2ad3a70 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 31 Oct 2023 09:27:51 -0700 Subject: [PATCH 1/3] [clang] Fix false positive -Wmissing-field-initi

[llvm] [clang] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk created https://github.com/llvm/llvm-project/pull/71513 This patch reference ac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf to suppot a soft coding way to identify whether a cpu has a feature `unaligned-scalar-mem` by `RISCVProcessors.td`. This patch does not provide test

[llvm] [clang] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Yeting Kuo (yetingk) Changes This patch reference ac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf to suppot a soft coding way to identify whether a cpu has a feature `unaligned-scalar-mem` by `RISCVProcessors.td

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-07 Thread Mariya Podchishchaeva via cfe-commits
@@ -727,6 +729,44 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, if (hadError || VerifyOnly) { // Do nothing } else if (Init < NumInits) { Fznamznon wrote: Yes, we still warn for this case. https://github.com/

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-07 Thread Mariya Podchishchaeva via cfe-commits
@@ -465,7 +460,8 @@ class InitListChecker { void FillInEmptyInitForField(unsigned Init, FieldDecl *Field, const InitializedEntity &ParentEntity, InitListExpr *ILE, bool &RequiresSecondPass, -

[clang] [analyzer][solver] On SymSym RelOps, check EQClass members for contradictions (PR #71284)

2023-11-07 Thread Gabor Marton via cfe-commits
martong wrote: > it'd be good to "strengthen" the equality classes and ensure that we assign > the same RangeSet to each member of an EQClass (or, in other words, we assign > the RangeSet to an EQClass instead of an individual symbol). RangeSets (i.e. constraints) are assigned to EQClasses, ch

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-07 Thread Mariya Podchishchaeva via cfe-commits
@@ -802,9 +842,19 @@ InitListChecker::FillInEmptyInitializations(const InitializedEntity &Entity, } } } else { + InitListExpr *SForm = + ILE->isSyntacticForm() ? ILE : ILE->getSyntacticForm(); // The fields beyond ILE->getNumInits() are d

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-07 Thread Mariya Podchishchaeva via cfe-commits
@@ -727,6 +729,44 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, if (hadError || VerifyOnly) { // Do nothing } else if (Init < NumInits) { + if (MaybeEmitMFIWarning) { +auto CheckAnonMember = [&](const FieldDecl *FD

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-07 Thread Mariya Podchishchaeva via cfe-commits
@@ -4,7 +4,7 @@ // RUN: %clang_cc1 -std=c++20 %s -verify=cxx20,expected,reorder -Wno-c99-designator -Werror=reorder-init-list -Wno-initializer-overrides // RUN: %clang_cc1 -std=c++20 %s -verify=cxx20,expected,override -Wno-c99-designator -Wno-reorder-init-list -Werror=initiali

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/71518 None >From c2411fe31a465eaafc8606b5f0ef95d94781a25b Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Tue, 7 Nov 2023 16:44:05 +0800 Subject: [PATCH] [clang][analyzer] Support `fputc` in StreamChecker --- .../Sta

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71518.diff 3 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp (+66-8) - (modified) clang/test/Analysis/stream-error.c

[clang] [clang][analyzer] Support `fputc` in StreamChecker (PR #71518)

2023-11-07 Thread Ben Shi via cfe-commits
benshi001 wrote: `fgetc` should also be supported, and I will do that next week. https://github.com/llvm/llvm-project/pull/71518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1b45fe5 - [clang][analyzer][NFC] Remove redundant code in StreamChecker (#71394)

2023-11-07 Thread via cfe-commits
Author: Ben Shi Date: 2023-11-07T19:14:05+08:00 New Revision: 1b45fe5c83e196604dffa33412c6d0b22c48fcf4 URL: https://github.com/llvm/llvm-project/commit/1b45fe5c83e196604dffa33412c6d0b22c48fcf4 DIFF: https://github.com/llvm/llvm-project/commit/1b45fe5c83e196604dffa33412c6d0b22c48fcf4.diff LOG:

[clang] [clang][analyzer][NFC] Remove redundant code in StreamChecker (PR #71394)

2023-11-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/71394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [mlir] [lld] [clang] [NFC][IRCE] Add unit test to show room for improvement (PR #71506)

2023-11-07 Thread Aleksandr Popov via cfe-commits
https://github.com/aleks-tmb updated https://github.com/llvm/llvm-project/pull/71506 >From 1c946c72f19bb553ad7af2e9b4edb1796eee Mon Sep 17 00:00:00 2001 From: Aleksander Popov Date: Tue, 7 Nov 2023 05:16:45 +0100 Subject: [PATCH] [NFC][IRCE] Add unit test to show room for improvement Add t

[clang] [clang][dataflow] Expand debug dumping of `Value`s. (PR #71527)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/71527 None >From 4a07c0ae8021d77da1cec7932e02a05a37f35f51 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 7 Nov 2023 12:02:32 + Subject: [PATCH] [clang][dataflow] Expand debug dumping of `Value`s. -

[clang] [clang][dataflow] Expand debug dumping of `Value`s. (PR #71527)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71527.diff 1 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/Value.cpp (+12-7) ``diff diff --git a/clang/lib/Analysis/FlowSen

[clang] [clang][dataflow] Expand debug dumping of `Value`s. (PR #71527)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71527.diff 1 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/Value.cpp (+12-7) ``diff diff --git a/clang/lib/Analysi

[clang] [analyzer] Improve diagnostics from ArrayBoundCheckerV2 (PR #70056)

2023-11-07 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/70056 >From 77143e74edda6177248bebdf0424db915aa68a05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?=

[clang] [analyzer] Improve diagnostics from ArrayBoundCheckerV2 (PR #70056)

2023-11-07 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/70056 >From 77143e74edda6177248bebdf0424db915aa68a05 Mon Sep 17 00:00:00 2001 From: =?UTF-

[clang] [analyzer] Improve diagnostics from ArrayBoundCheckerV2 (PR #70056)

2023-11-07 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: DonatNagyE wrote: I decided to keep the `reportOOB()` calls without additional changes. I feel that adding `std::move()` has limited benefits (performance impact is negl

[clang] 16ef496 - [analyzer] Improve diagnostics from ArrayBoundCheckerV2 (#70056)

2023-11-07 Thread via cfe-commits
Author: DonatNagyE Date: 2023-11-07T13:26:32+01:00 New Revision: 16ef4968dc9e93f9c7b361b9ad0645445bd1210e URL: https://github.com/llvm/llvm-project/commit/16ef4968dc9e93f9c7b361b9ad0645445bd1210e DIFF: https://github.com/llvm/llvm-project/commit/16ef4968dc9e93f9c7b361b9ad0645445bd1210e.diff LO

[clang] [analyzer] Improve diagnostics from ArrayBoundCheckerV2 (PR #70056)

2023-11-07 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE closed https://github.com/llvm/llvm-project/pull/70056 ___ cfe-commits mailing list cfe-commits@l

[clang-tools-extra] [llvm] [flang] [libc] [clang] [libcxx] [compiler-rt] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-07 Thread Aaron Ballman via cfe-commits
@@ -712,9 +722,7 @@ StmtResult Parser::ParseLabeledStatement(ParsedAttributes &Attrs, assert(Tok.is(tok::identifier) && Tok.getIdentifierInfo() && "Not an identifier!"); - // The substatement is always a 'statement', not a 'declaration', but is - // otherwise in

[clang] [llvm] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli edited https://github.com/llvm/llvm-project/pull/71513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli approved this pull request. LGTM, with a couple of minor nits. Thanks! https://github.com/llvm/llvm-project/pull/71513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [llvm] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Francesco Petrogalli via cfe-commits
@@ -44,6 +45,11 @@ static const CPUInfo *getCPUInfoByName(StringRef CPU) { return nullptr; } +bool hasFastUnalignedAccess(StringRef CPU) { + const CPUInfo *Info = getCPUInfoByName(CPU); + return Info && Info->FastUnalignedAccess; fpetrogalli wrote: Would

[clang] [llvm] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Francesco Petrogalli via cfe-commits
@@ -60,9 +60,14 @@ static void EmitRISCVTargetDef(RecordKeeper &RK, raw_ostream &OS) { if (MArch.empty()) MArch = getMArch(*Rec); +bool FastUnalignedAccess = fpetrogalli wrote: ```suggestion const bool FastUnalignedAccess = ``` https://git

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-07 Thread via cfe-commits
zmodem wrote: > Me and Aaron are also wondering now how did it pass CI, and what's wrong with > changes here. I'm sorry @zmodem that we got you involved. Just to be clear, my comment wasn't intended as criticism of this patch. This does seem like a good opportunity to improve our presubmit tes

[clang] [clang][analyzer] Improve StdLibraryFunctionsChecker 'readlink' modeling. (PR #71373)

2023-11-07 Thread via cfe-commits
DonatNagyE wrote: Feel free to merge this @balazske, and thanks for the improvement! https://github.com/llvm/llvm-project/pull/71373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [lldb] [mlir] [libc] [libcxx] [llvm] [clang] [lld] [flang] [libc][bazel] Add powf target and fix bazel overlay. (PR #71464)

2023-11-07 Thread via cfe-commits
https://github.com/lntue updated https://github.com/llvm/llvm-project/pull/71464 >From c5b8cfbae37c302158e3671a271634c71693123a Mon Sep 17 00:00:00 2001 From: Tue Ly Date: Mon, 6 Nov 2023 18:52:11 -0500 Subject: [PATCH] [libc][bazel] Add powf target and fix bazel overlay. --- libc/src/math/gen

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-07 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Me and Aaron are also wondering now how did it pass CI, and what's wrong > > with changes here. I'm sorry @zmodem that we got you involved. > > Just to be clear, my comment wasn't intended as criticism of this patch. This > does seem like a good opportunity to improve o

[compiler-rt] [clang-tools-extra] [llvm] [clang] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

2023-11-07 Thread Nikita Popov via cfe-commits
@@ -334,6 +335,15 @@ template<> struct simplify_type { } }; +template <> struct GraphTraits { nikic wrote: > What's the issue with putting this here? Seems nicer than inlining yet > another DFS in another place. I have a couple of concerns about exposing

[compiler-rt] [clang-tools-extra] [clang] [llvm] [InferAddressSpaces] Fix constant replace to avoid modifying other functions (PR #70611)

2023-11-07 Thread Matt Arsenault via cfe-commits
@@ -334,6 +335,15 @@ template<> struct simplify_type { } }; +template <> struct GraphTraits { arsenm wrote: If we allowed bitcasts between address spaces with the same size, we could drop addrspacecast constantexprs altogether https://github.com/llvm/llv

[compiler-rt] [libcxx] [libc] [llvm] [clang-tools-extra] [flang] [clang] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/71398 >From 1d54a5cc6b34aca0e34ab57d7ee62815707d9153 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 6 Nov 2023 08:54:40 -0500 Subject: [PATCH 1/4] [C23] Complete support for WG14 N2508 In Clang 16, we im

[llvm] [clang] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Yeting Kuo via cfe-commits
@@ -44,6 +45,11 @@ static const CPUInfo *getCPUInfoByName(StringRef CPU) { return nullptr; } +bool hasFastUnalignedAccess(StringRef CPU) { + const CPUInfo *Info = getCPUInfoByName(CPU); + return Info && Info->FastUnalignedAccess; yetingk wrote: It's possi

[compiler-rt] [lldb] [mlir] [libc] [libcxx] [llvm] [clang] [lld] [flang] [libc][bazel] Add powf target and fix bazel overlay. (PR #71464)

2023-11-07 Thread via cfe-commits
https://github.com/lntue closed https://github.com/llvm/llvm-project/pull/71464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-11-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2e79133 - [clang] Improve `_Alignas` on a `struct` declaration diagnostic (#65638)

2023-11-07 Thread via cfe-commits
Author: Jerin Philip Date: 2023-11-07T08:27:41-05:00 New Revision: 2e7913342eb9d5cd1744d4c24e1898588429b80d URL: https://github.com/llvm/llvm-project/commit/2e7913342eb9d5cd1744d4c24e1898588429b80d DIFF: https://github.com/llvm/llvm-project/commit/2e7913342eb9d5cd1744d4c24e1898588429b80d.diff

[clang] [llvm] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk updated https://github.com/llvm/llvm-project/pull/71513 >From 1a6da0d00af17ae17e6c569f12f3e34fbbdf611d Mon Sep 17 00:00:00 2001 From: Yeting Kuo Date: Tue, 7 Nov 2023 18:48:04 +0800 Subject: [PATCH 1/2] [RISCV][Clang][TargetParser] Support getting feature unaligned-s

[clang] [llvm] [RISCV][Clang][TargetParser] Support getting feature unaligned-scalar-mem from mcpu. (PR #71513)

2023-11-07 Thread Yeting Kuo via cfe-commits
@@ -60,9 +60,14 @@ static void EmitRISCVTargetDef(RecordKeeper &RK, raw_ostream &OS) { if (MArch.empty()) MArch = getMArch(*Rec); +bool FastUnalignedAccess = yetingk wrote: Done. https://github.com/llvm/llvm-project/pull/71513

[compiler-rt] [libcxx] [libc] [llvm] [clang-tools-extra] [flang] [clang] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-07 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon commented: LGTM, but someone else must approve. https://github.com/llvm/llvm-project/pull/71398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-11-07 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3837-3838 return nullptr; - return Actions.ActOnOpenMPClause(Kind, Loc, Tok.getLocation()); + OMPClause *Clause = Actions.ActOnOpenMPClause(Kind, Loc, Tok.getLocation()); + return Clause; } --

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-07 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. Looks like correct fix to me. https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
https://github.com/zmodem edited https://github.com/llvm/llvm-project/pull/68447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,158 @@ +//===- raw_ostream_proxy.h - Proxies for raw output streams -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
https://github.com/zmodem commented: I started reviewing the first commit, but wanted to ask some high-level questions which will make it easier to review: The PR description doesn't say so, but the motivation for this is the CAS work, right? LLVM already has a "virtual filesystem", and I tho

[llvm] [clang] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,158 @@ +//===- raw_ostream_proxy.h - Proxies for raw output streams -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,158 @@ +//===- raw_ostream_proxy.h - Proxies for raw output streams -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,158 @@ +//===- raw_ostream_proxy.h - Proxies for raw output streams -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,219 @@ +//===- raw_ostream_proxy_test.cpp - Tests for raw ostream proxies -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,219 @@ +//===- raw_ostream_proxy_test.cpp - Tests for raw ostream proxies -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,219 @@ +//===- raw_ostream_proxy_test.cpp - Tests for raw ostream proxies -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-07 Thread Mehdi Amini via cfe-commits
joker-eph wrote: > I've seen those exact test failures locally, but since precommit CI was fine, > I landed this PR and kept a close eye on the bots. If you see failures locally, it's best to understand where they coming from: even if it passes on bots it just means we have a hole in our test

[clang-tools-extra] [clangd] Add tweak to inline concept requirements (PR #69693)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Vina (Venyla) Changes # Description This introduces a new refactoring for concept requirements, inlining simple require clauses into the template declaration. Here is an example of what it does: Before ```cpp template

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/70848 >From 7ec1f2d33118f382b008f0dad09fa0056844de2f Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 31 Oct 2023 19:12:30 + Subject: [PATCH 1/2] [clang][dataflow] Simplify flow conditions displayed in

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,55 @@ +//===-- SimplifyConstraints.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,183 @@ +//===-- SimplifyConstraints.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,183 @@ +//===-- SimplifyConstraints.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,183 @@ +//===-- SimplifyConstraints.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,183 @@ +//===-- SimplifyConstraints.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,183 @@ +//===-- SimplifyConstraints.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-11-07 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk updated https://github.com/llvm/llvm-project/pull/66043 >From 91bb1d9884276a37f93515a648aa6ece353fdc70 Mon Sep 17 00:00:00 2001 From: Yeting Kuo Date: Tue, 12 Sep 2023 12:28:00 +0800 Subject: [PATCH 1/4] [RISCV] Add MC layer support for Zicfiss. The patch adds the in

[llvm] [clang] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
@@ -0,0 +1,183 @@ +//===-- SimplifyConstraints.cpp -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (PR #70848)

2023-11-07 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/70848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7c63672 - [clang][dataflow] Simplify flow conditions displayed in HTMLLogger. (#70848)

2023-11-07 Thread via cfe-commits
Author: martinboehme Date: 2023-11-07T15:18:34+01:00 New Revision: 7c636728c0fc18fc79831bfc3cdf41841b9b517c URL: https://github.com/llvm/llvm-project/commit/7c636728c0fc18fc79831bfc3cdf41841b9b517c DIFF: https://github.com/llvm/llvm-project/commit/7c636728c0fc18fc79831bfc3cdf41841b9b517c.diff

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-11-07 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. https://github.com/llvm/llvm-project/pull/69725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-07 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > If you see failures locally, it's best to understand where they coming from: > even if it passes on bots it just means we have a hole in our test coverage. Sure, but it wasn't the first time I've seen local test failures that doesn't reproduce anywhere else (`Clang :: LibClang

[llvm] [clang] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #71540)

2023-11-07 Thread Paulo Matos via cfe-commits
https://github.com/pmatos created https://github.com/llvm/llvm-project/pull/71540 Originally reference types were designed as pointers to different address spaces. More recently TargetExtType were added to LLVM IR making it easier to represent reference types. This refactoring gets rid of was

[llvm] [clang] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #71540)

2023-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly Author: Paulo Matos (pmatos) Changes Originally reference types were designed as pointers to different address spaces. More recently TargetExtType were added to LLVM IR making it easier to represent reference types. This refactorin

[llvm] [clang] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #71540)

2023-11-07 Thread Paulo Matos via cfe-commits
pmatos wrote: The current patch implements successfully all the refactoring needed for externref. I will work on funcref next. This refactoring was triggered by the discussion at #71069 . Also the issue #71388 is currently blocking this. I include a workaround in the current patch. https://gi

[llvm] [clang] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #71540)

2023-11-07 Thread Paulo Matos via cfe-commits
https://github.com/pmatos edited https://github.com/llvm/llvm-project/pull/71540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #71540)

2023-11-07 Thread Paulo Matos via cfe-commits
https://github.com/pmatos edited https://github.com/llvm/llvm-project/pull/71540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-11-07 Thread Gábor Spaits via cfe-commits
spaits wrote: gentle ping @steakhal https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a737a33 - [clang][dataflow] Fix -Wrange-loop-construct in DataflowAnalysisContext.cpp (NFC)

2023-11-07 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2023-11-07T22:32:11+08:00 New Revision: a737a33eb995cf704f8ae9653811ca503d77ed65 URL: https://github.com/llvm/llvm-project/commit/a737a33eb995cf704f8ae9653811ca503d77ed65 DIFF: https://github.com/llvm/llvm-project/commit/a737a33eb995cf704f8ae9653811ca503d77ed65.diff LOG: [

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-07 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > If you see failures locally, it's best to understand where they coming > > from: even if it passes on bots it just means we have a hole in our test > > coverage. > > Sure, but it wasn't the first time I've seen local test failures that doesn't > reproduce anywhere else

  1   2   3   4   >