[clang] [Clang][RISCV] Add vundefine intrinsics for tuple types (PR #70354)

2023-10-30 Thread Yueh-Ting Chen via cfe-commits
@@ -7,534 +7,2189 @@ #include -// CHECK-RV64-LABEL: define dso_local @test_vundefined_f16mf4 -// CHECK-RV64-SAME: () #[[ATTR0:[0-9]+]] { +// CHECK-RV64-LABEL: define dso_local @test_vundefined_f16mf4( +// CHECK-RV64-SAME: ) #[[ATTR0:[0-9]+]] { // CHECK-RV64-NEXT: entry

[clang] [Clang][RISCV] Add vundefine intrinsics for tuple types (PR #70354)

2023-10-30 Thread Kito Cheng via cfe-commits
@@ -1,4 +1,4 @@ -// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 kito-cheng wrote: Does this cause those cha

[clang] [Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (PR #70355)

2023-10-30 Thread Yueh-Ting Chen via cfe-commits
eopXD wrote: A gentle ping now that we have this inside the spec. https://github.com/llvm/llvm-project/pull/70355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Add vundefine intrinsics for tuple types (PR #70354)

2023-10-30 Thread Yueh-Ting Chen via cfe-commits
@@ -1,4 +1,4 @@ -// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 eopXD wrote: I guess this is something new

[clang] [Clang][RISCV] Add vundefine intrinsics for tuple types (PR #70354)

2023-10-30 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/70354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove diagnostic that came with `[[clang::preferred_type]]` (PR #70632)

2023-10-30 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/70632 https://github.com/llvm/llvm-project/pull/69104 introduce a diagnostic that checked underlying type of an enum against type of bit-field that is annotated with `[[clang::preferred_type]]`. When I tried to introd

[clang] [clang] Remove diagnostic that came with `[[clang::preferred_type]]` (PR #70632)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes https://github.com/llvm/llvm-project/pull/69104 introduce a diagnostic that checked underlying type of an enum against type of bit-field that is annotated with `[[clang::preferred_type]]`. When I tried

[clang] [clang][analyzer] Add 'tmpfile' as an open function to SimpleStreamChecker (PR #70539)

2023-10-30 Thread Balázs Kéri via cfe-commits
balazske wrote: If I remember correctly there is somewhere in the clang documentation a file that refers to this checker, and the purpose of this checker is mostly documentation. I do not know if it is good to change the code or to extend this checker, because there is `StreamChecker` that sho

[clang] [clang][analyzer] Add 'tmpfile' as an open function to SimpleStreamChecker (PR #70539)

2023-10-30 Thread Ben Shi via cfe-commits
benshi001 wrote: > If I remember correctly there is somewhere in the clang documentation a file > that refers to this checker, and the purpose of this checker is mostly > documentation. I do not know if it is good to change the code or to extend > this checker, because there is `StreamChecker`

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-10-30 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc added a comment. In D70401#4655408 , @asb wrote: > First of all, thank you to everyone who has been trying to nudge this forward > and apologies it must have been a frustrating experience. > > I appreciate there are users who want to see this and I

[clang] [clang] Remove diagnostic that came with `[[clang::preferred_type]]` (PR #70632)

2023-10-30 Thread via cfe-commits
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT, diag::err_incomplete_type); - if (QT->isEnumeralType()) { -auto IsCorrespondingTy

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-30 Thread Matt Arsenault via cfe-commits
arsenm wrote: > This is not being handled for AMDGPU Targets. I'm assuming this is an artifact of passing all arguments both the host target and the offload target? @jhuber6 what's the correct way of filtering out irrelevant codegen options? https://github.com/llvm/llvm-project/pull/70262 __

[clang] b72732c - [clang][Interp] Handle CXXTryStmts (#70584)

2023-10-30 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-30T09:38:02+01:00 New Revision: b72732c37fd8d193cfa64e693b879dabdec813a5 URL: https://github.com/llvm/llvm-project/commit/b72732c37fd8d193cfa64e693b879dabdec813a5 DIFF: https://github.com/llvm/llvm-project/commit/b72732c37fd8d193cfa64e693b879dabdec813a5.diff L

[clang] [clang][Interp] Handle CXXTryStmts (PR #70584)

2023-10-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/70584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove diagnostic that came with `[[clang::preferred_type]]` (PR #70632)

2023-10-30 Thread Vlad Serebrennikov via cfe-commits
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT, diag::err_incomplete_type); - if (QT->isEnumeralType()) { -auto IsCorrespondingTy

[clang] [clang] Remove diagnostic that came with `[[clang::preferred_type]]` (PR #70632)

2023-10-30 Thread Vlad Serebrennikov via cfe-commits
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT, diag::err_incomplete_type); - if (QT->isEnumeralType()) { -auto IsCorrespondingTy

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-30 Thread via cfe-commits
DaMatrix wrote: @zygoloid can you commit this? I don't have write access to the repository. https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-10-30 Thread Sunil K via Phabricator via cfe-commits
koops updated this revision to Diff 557933. koops added a comment. Replacing the storing of "OMPClause *FailMemoryOrderClause" with "OpenMPClauseKind FailParameter" in class OMPFailClause. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files

[clang] [LoongArch] Fix ABI mismatch with gcc/g++ about empty structs passing (PR #70320)

2023-10-30 Thread via cfe-commits
https://github.com/heiher approved this pull request. https://github.com/llvm/llvm-project/pull/70320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SimplifyCFG] Prevent merging cbranch to cbranch if the branch probability from the first to second is too low. (PR #69375)

2023-10-30 Thread Valery Pykhtin via cfe-commits
https://github.com/vpykhtin updated https://github.com/llvm/llvm-project/pull/69375 >From fc1457d4856b3f4ae0a080a451669e344b0b1354 Mon Sep 17 00:00:00 2001 From: Valery Pykhtin Date: Tue, 17 Oct 2023 20:50:48 +0200 Subject: [PATCH 1/4] [SimplifyCFG] Add test on prevent merging cbranch to cbran

[clang] [clang][analyzer] Fix crash in CXXDeleteChecker (PR #70638)

2023-10-30 Thread via cfe-commits
https://github.com/Discookie created https://github.com/llvm/llvm-project/pull/70638 While inheritance can only be expressed if the class has a definition, in this case one of the types might be opaque to the analyzer. Fixes a crash encountered whie analyzing LLVM. >From 910445aacf8b87503990b

[clang] [clang][analyzer] Fix crash in CXXDeleteChecker (PR #70638)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Discookie (Discookie) Changes While inheritance can only be expressed if the class has a definition, in this case one of the types might be opaque to the analyzer. Fixes a crash encountered whie analyzing LLVM. --- Full

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-10-30 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. Thanks, I'll take another look. Rereading my previous comment I just wanted to clarify one part so it's not misunderstood. I said " I think it's unfortunate that this need for the ABI hasn't translated into effort to finalise the ABI definition in the psABI doc and to at le

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/70639 When an LLDB user asks for the value of a static data member, LLDB starts by searching the Names accelerator table for the corresponding variable definition DIE. For static data members with out-of-class defini

[clang] [LoongArch] Fix ABI mismatch with gcc/g++ about empty structs passing (PR #70320)

2023-10-30 Thread Xi Ruoyao via cfe-commits
xry111 wrote: LGTM. I've no permission to make a formal ("GitHub style") approval. https://github.com/llvm/llvm-project/pull/70320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Do not analyze opaque types in CXXDeleteChecker (PR #70638)

2023-10-30 Thread via cfe-commits
https://github.com/Discookie edited https://github.com/llvm/llvm-project/pull/70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-30 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: I can add the comment as requested, but for the other questions related to full expressions and modules I'd really need input from experts... https://github.com/llvm/llvm-project/pull/69076 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via cfe-commits
Michael137 wrote: Summing the size of all *.o files in my local debug Clang build increased by `0.7%` with this patch https://github.com/llvm/llvm-project/pull/70639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via cfe-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/70639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes When an LLDB user asks for the value of a static data member, LLDB starts by searching the Names accelerator table for the corresponding variable definition DIE. For static data members with out-of-class de

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a902ca66428164b4f11dedf1c551393add511271 e3ae0862dd834ca54a096b3154bbbcc5a627014f --

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70551)

2023-10-30 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70551 >From e02939572877cdc839894454a6fab36ab143d924 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][NFC] Add createConstantValueExpression

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70639 >From cbae5425ac00e3cb597827e4b6c402446cc40d9d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/3] [clang][DebugInfo][NFC] Add createConstantValueExpression

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70639 >From cbae5425ac00e3cb597827e4b6c402446cc40d9d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][NFC] Add createConstantValueExpression

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70551)

2023-10-30 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/70551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Do not analyze opaque types in CXXDeleteChecker (PR #70638)

2023-10-30 Thread via cfe-commits
https://github.com/DonatNagyE approved this pull request. LGTM, seems to be a straightforward fix. Note that "whie" is a typo in the commit message. https://github.com/llvm/llvm-project/pull/70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [clang][analyzer] Do not analyze opaque types in CXXDeleteChecker (PR #70638)

2023-10-30 Thread via cfe-commits
https://github.com/Discookie edited https://github.com/llvm/llvm-project/pull/70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-30 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm updated https://github.com/llvm/llvm-project/pull/69447 >From 2a65ae75e8c8e62e7275a439849837919599e896 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Thu, 14 Sep 2023 14:51:17 +0100 Subject: [PATCH 1/3] [Driver] Add ExclusiveGroup feature to multilib.yaml. Thi

[clang-tools-extra] [clangd] Add tweak for turning an unscoped into a scoped enum (PR #69481)

2023-10-30 Thread via cfe-commits
ckandeler wrote: ping https://github.com/llvm/llvm-project/pull/69481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-30 Thread Simon Tatham via cfe-commits
@@ -96,13 +97,39 @@ bool MultilibSet::select(const Multilib::flags_list &Flags, llvm::SmallVector &Selected) const { llvm::StringSet<> FlagSet(expandFlags(Flags)); Selected.clear(); - llvm::copy_if(Multilibs, std::back_inserter(Selected), -

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-30 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm edited https://github.com/llvm/llvm-project/pull/69447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Do not offer extraction to variable for decl init expression (PR #69477)

2023-10-30 Thread via cfe-commits
ckandeler wrote: ping https://github.com/llvm/llvm-project/pull/69477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-10-30 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff created https://github.com/llvm/llvm-project/pull/70646 When instantiation function, a call to Sema::resetFPOption was used to set the FP options associated with AST node. However this function also cleared FP pragma stack, and it is incorrect. Template instantiatio

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Serge Pavlov (spavloff) Changes When instantiation function, a call to Sema::resetFPOption was used to set the FP options associated with AST node. However this function also cleared FP pragma stack, and it is incorrect. Template instanti

[clang] 8f11f98 - [clang][NFC] Assert not llvm_unreachable (#70149)

2023-10-30 Thread via cfe-commits
Author: Nathan Sidwell Date: 2023-10-30T07:37:42-04:00 New Revision: 8f11f984817ffe48725e35cffa0fdc45492497e9 URL: https://github.com/llvm/llvm-project/commit/8f11f984817ffe48725e35cffa0fdc45492497e9 DIFF: https://github.com/llvm/llvm-project/commit/8f11f984817ffe48725e35cffa0fdc45492497e9.diff

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

2023-10-30 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/70149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7b2e009 - [clang] Robustify openmp test (#69739)

2023-10-30 Thread via cfe-commits
Author: Nathan Sidwell Date: 2023-10-30T07:39:45-04:00 New Revision: 7b2e0095bccb2f63e6b6cc8b8e524d206ebf8d69 URL: https://github.com/llvm/llvm-project/commit/7b2e0095bccb2f63e6b6cc8b8e524d206ebf8d69 DIFF: https://github.com/llvm/llvm-project/commit/7b2e0095bccb2f63e6b6cc8b8e524d206ebf8d69.diff

[clang] [clang] Robustify openmp test (PR #69739)

2023-10-30 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/69739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refactor TBAA Base Info construction (PR #70499)

2023-10-30 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/70499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Support mcmodel=large for AIX (PR #70652)

2023-10-30 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises created https://github.com/llvm/llvm-project/pull/70652 7e42545 rejects unsupported mcmodel options, but large should be a supported model for 32-bit AIX targets. >From 09c722552b69dd812c9117ba9832055f3abbf9a1 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Mon,

[clang] [clang] Refactor TBAA Base Info construction (PR #70499)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Nathan Sidwell (urnathan) Changes I noticed a few issues with `CodeGenTBAA::getBaseTypeInfo`. 1) `isValidBaseType` explicitly checks for a reference type to return false, but then also returns false for all non-record types. Just

[clang] [PowerPC] Support mcmodel=large for AIX (PR #70652)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qiu Chaofan (ecnelises) Changes 7e42545 rejects unsupported mcmodel options, but large should be a supported model for 32-bit AIX targets. --- Full diff: https://github.com/llvm/llvm-project/pull/70652.diff 1 Files Affected: - (modifie

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-10-30 Thread Tobias Hieta via cfe-commits
tru wrote: Thanks for the patch @spavloff - I will make sure to try it today! https://github.com/llvm/llvm-project/pull/70646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Per https://eel.is/c++draft/dcl.fct.def.default#2.2, the explicit object > parameter of a defaulted special member function must be of the same type as > the one of an equivalent implicitly defaulted function, ignoring references. I could use an explanation as to how they

[clang] [clang][nullability] Use `proves()` and `assume()` instead of deprecated synonyms. (PR #70297)

2023-10-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/70297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > This is not being handled for AMDGPU Targets. > > I'm assuming this is an artifact of passing all arguments both the host > target and the offload target? @jhuber6 what's the correct way of filtering > out irrelevant codegen options? I don't know what the desired behavior i

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread via cfe-commits
cor3ntin wrote: > > Per https://eel.is/c++draft/dcl.fct.def.default#2.2, the explicit object > > parameter of a defaulted special member function must be of the same type > > as the one of an equivalent implicitly defaulted function, ignoring > > references. > > I could use an explanation as

[clang] [clang][dataflow][NFC] Move `parseAll()` to TestingSupport and rename `parseFormulas()` (PR #70437)

2023-10-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/70437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread Aaron Ballman via cfe-commits
@@ -7748,6 +7748,24 @@ bool Sema::CheckExplicitlyDefaultedSpecialMember(CXXMethodDecl *MD, HadError = true; } } +// [C++23][dcl.fct.def.default]/p2.2 AaronBallman wrote: This requirement seems to be a general one but you've implemented i

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > Per https://eel.is/c++draft/dcl.fct.def.default#2.2, the explicit object > > > parameter of a defaulted special member function must be of the same type > > > as the one of an equivalent implicitly defaulted function, ignoring > > > references. > > > > > > I could u

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread via cfe-commits
@@ -7748,6 +7748,24 @@ bool Sema::CheckExplicitlyDefaultedSpecialMember(CXXMethodDecl *MD, HadError = true; } } +// [C++23][dcl.fct.def.default]/p2.2 cor3ntin wrote: It applies to special member functions - Which excludes comparison. and

[clang] 526c9b7 - [clang][nullability] Use `proves()` and `assume()` instead of deprecated synonyms. (#70297)

2023-10-30 Thread via cfe-commits
Author: martinboehme Date: 2023-10-30T13:18:57+01:00 New Revision: 526c9b7e37fa12abc17eebc68f21c1d213477ba8 URL: https://github.com/llvm/llvm-project/commit/526c9b7e37fa12abc17eebc68f21c1d213477ba8 DIFF: https://github.com/llvm/llvm-project/commit/526c9b7e37fa12abc17eebc68f21c1d213477ba8.diff

[clang] [clang][nullability] Use `proves()` and `assume()` instead of deprecated synonyms. (PR #70297)

2023-10-30 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/70297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Support mcmodel=large for AIX (PR #70652)

2023-10-30 Thread Chen Zheng via cfe-commits
@@ -5723,7 +5723,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, if (Arg *A = Args.getLastArg(options::OPT_mcmodel_EQ)) { StringRef CM = A->getValue(); bool Ok = false; -if (Triple.isOSAIX() && CM == "medium") { +if (Triple.isOSAIX() && (CM

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread Aaron Ballman via cfe-commits
@@ -7748,6 +7748,24 @@ bool Sema::CheckExplicitlyDefaultedSpecialMember(CXXMethodDecl *MD, HadError = true; } } +// [C++23][dcl.fct.def.default]/p2.2 AaronBallman wrote: Oh! I was thinking that spaceship was also a special member functio

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM though something seems to be amiss with precommit CI and so it might be nice to get a clean run of that before landing (I don't insist). https://github.com/llvm/llvm-project/pull/70176 _

[clang] [APINotes] Upstream APINotesReader (PR #66769)

2023-10-30 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/66769 >From e165261eb5baa8c2660ac8b2319cb96d13578572 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Tue, 19 Sep 2023 13:42:16 +0100 Subject: [PATCH] [APINotes] Upstream APINotesReader This upstreams more of the Cla

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-30 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70176 >From bd24d172c3ea66909748dca00fa368a7e4e9c358 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 25 Oct 2023 10:08:24 +0200 Subject: [PATCH 1/3] [Clang] Diagnose defaulted assignment operator with incomp

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-30 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. Thank you Momchil for the changes. https://github.com/llvm/llvm-project/pull/69598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [RISCV] Eliminate dead li after emitting VSETVLIs (PR #65934)

2023-10-30 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: Ping. https://github.com/llvm/llvm-project/pull/65934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-30 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-30 Thread via cfe-commits
@@ -4648,6 +4648,10 @@ struct FormatStyle { /// \version 11 std::vector WhitespaceSensitiveMacros; + /// Ignore formatting in preprocessor definitions. mydeveloperday wrote: If you are changing this you need to regenerate the documentation https://githu

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-30 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-30 Thread via cfe-commits
@@ -24153,6 +24153,23 @@ TEST_F(FormatTest, WhitespaceSensitiveMacros) { verifyNoChange("FOO(String-ized&Messy+But: :Still=Intentional);", Style); } +TEST_F(FormatTest, IgnorePPDefinitions) { + FormatStyle Style = getLLVMStyle(); + Style.IgnorePPDefinitions = true; + + ve

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

2023-10-30 Thread Erich Keane via cfe-commits
@@ -274,20 +274,27 @@ class DefaultIntArgument : IntArgument { } // This argument is more complex, it includes the enumerator type name, -// a list of strings to accept, and a list of enumerators to map them to. -class EnumArgument values, +// a list of possible values, and a

[clang] [Clang][RISCV] Add vundefine intrinsics for tuple types (PR #70354)

2023-10-30 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD closed https://github.com/llvm/llvm-project/pull/70354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Do not analyze opaque types in CXXDeleteChecker (PR #70638)

2023-10-30 Thread via cfe-commits
https://github.com/Discookie closed https://github.com/llvm/llvm-project/pull/70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 564e016 - [clang][analyzer] Do not analyze opaque types in CXXDeleteChecker (#70638)

2023-10-30 Thread via cfe-commits
Author: Discookie Date: 2023-10-30T14:03:33Z New Revision: 564e0165abc851dcd7a3485d4e728ce63c3d6466 URL: https://github.com/llvm/llvm-project/commit/564e0165abc851dcd7a3485d4e728ce63c3d6466 DIFF: https://github.com/llvm/llvm-project/commit/564e0165abc851dcd7a3485d4e728ce63c3d6466.diff LOG: [cl

[clang] [clang] Additional FP classification functions (PR #69041)

2023-10-30 Thread Serge Pavlov via cfe-commits
spavloff wrote: Ping. https://github.com/llvm/llvm-project/pull/69041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [sanitizer][msan] fix AArch64 vararg support for KMSAN (PR #70659)

2023-10-30 Thread Alexander Potapenko via cfe-commits
https://github.com/ramosian-glider created https://github.com/llvm/llvm-project/pull/70659 Cast StackSaveAreaPtr, GrRegSaveAreaPtr, VrRegSaveAreaPtr to pointers to fix assertions in getShadowOriginPtrKernel(). Fixes: https://github.com/llvm/llvm-project/issues/69738 Patch by Mark Johnston. >

[clang] [sanitizer][msan] fix AArch64 vararg support for KMSAN (PR #70659)

2023-10-30 Thread Alexander Potapenko via cfe-commits
https://github.com/ramosian-glider created https://github.com/llvm/llvm-project/pull/70659 Cast StackSaveAreaPtr, GrRegSaveAreaPtr, VrRegSaveAreaPtr to pointers to fix assertions in getShadowOriginPtrKernel(). Fixes: https://github.com/llvm/llvm-project/issues/69738 Patch by Mark Johnston. >

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-30 Thread Erich Keane via cfe-commits
@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema &S, llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifie

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-30 Thread Erich Keane via cfe-commits
@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema &S, llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifie

[clang-tools-extra] [sanitizer][msan] fix AArch64 vararg support for KMSAN (PR #70659)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Alexander Potapenko (ramosian-glider) Changes Cast StackSaveAreaPtr, GrRegSaveAreaPtr, VrRegSaveAreaPtr to pointers to fix assertions in getShadowOriginPtrKernel(). Fixes: https://github.com/llvm/llvm-project/issues/69738

[clang-tools-extra] [sanitizer][msan] fix AArch64 vararg support for KMSAN (PR #70659)

2023-10-30 Thread Alexander Potapenko via cfe-commits
https://github.com/ramosian-glider closed https://github.com/llvm/llvm-project/pull/70659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove diagnostic that came with `[[clang::preferred_type]]` (PR #70632)

2023-10-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Why doesn't this result in any changes to tests? I would expect having to remove them, right? https://github.com/llvm/llvm-project/pull/70632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang][Module] Mark test unsupported since objc doesn't have xcoff/g… (PR #70661)

2023-10-30 Thread Jake Egan via cfe-commits
https://github.com/jakeegan created https://github.com/llvm/llvm-project/pull/70661 …off support Same as D135848. The newly added test fails with `fatal error: error in backend: Objective-C support is unimplemented for object file format`. >From 9392421ef48aadfbbc0fcfe387f15c9fc1705b0d Mon S

[clang] [AArch64][Clang] Refactor code to emit SVE & SME builtins (PR #70662)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kerry McLaughlin (kmclaughlin-arm) Changes This patch removes duplicated code in EmitAArch64SVEBuiltinExpr and EmitAArch64SMEBuiltinExpr by creating a new function called GetAArch64SVEProcessedOperands which handles splitting up mul

[clang] [clang][Module] Mark test unsupported since objc doesn't have xcoff/g… (PR #70661)

2023-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jake Egan (jakeegan) Changes …off support Same as D135848. The newly added test fails with `fatal error: error in backend: Objective-C support is unimplemented for object file format`. --- Full diff: https://github.com/llvm/llvm-project

[clang] [clang] Additional FP classification functions (PR #69041)

2023-10-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: The `clang/Interp` parts LGTM https://github.com/llvm/llvm-project/pull/69041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SimplifyCFG] Prevent merging cbranch to cbranch if the branch probability from the first to second is too low. (PR #69375)

2023-10-30 Thread Valery Pykhtin via cfe-commits
vpykhtin wrote: @nikic or other reviewers, do you have objections to submit this patch? https://github.com/llvm/llvm-project/pull/69375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [SimplifyCFG] Prevent merging cbranch to cbranch if the branch probability from the first to second is too low. (PR #69375)

2023-10-30 Thread Valery Pykhtin via cfe-commits
vpykhtin wrote: @nikic or other reviewers, do you have objections to submit this patch? https://github.com/llvm/llvm-project/pull/69375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-30 Thread Kerry McLaughlin via cfe-commits
@@ -263,3 +263,38 @@ multiclass ZAFPOuterProd { defm SVMOPA : ZAFPOuterProd<"mopa">; defm SVMOPS : ZAFPOuterProd<"mops">; + + +// SME2 - ADD, SUB + +multiclass ZAAddSub { kmclaughl

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-30 Thread Kerry McLaughlin via cfe-commits
@@ -9571,22 +9571,17 @@ Value *CodeGenFunction::EmitSVEStructStore(const SVETypeFlags &TypeFlags, Value *BasePtr = Ops[1]; // Does the store have an offset? - if (Ops.size() > 3) + if (Ops.size() > (2 + N)) kmclaughlin-arm wrote: This change was intend

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-30 Thread Kerry McLaughlin via cfe-commits
@@ -10266,35 +10288,13 @@ Value *CodeGenFunction::EmitAArch64SVEBuiltinExpr(unsigned BuiltinID, Value *CodeGenFunction::EmitAArch64SMEBuiltinExpr(unsigned BuiltinID, const CallExpr *E) { - // Find out if any arguments are req

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

2023-10-30 Thread via cfe-commits
HaohaiWen wrote: Any more comments? I'd like to merge it if no objection. https://github.com/llvm/llvm-project/pull/68502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

2023-10-30 Thread via cfe-commits
HaohaiWen wrote: Any more comments? I'd like to merge it if no objection. https://github.com/llvm/llvm-project/pull/68502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-10-30 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2543 + void setFailParameter(OpenMPClauseKind FailParameter) { + +switch (FailParameter) { Remove this empty line Comment at: clang/include/clang/AST/OpenMPC

[clang-tools-extra] create new clang-tidy check to add namespaces to symbol references (PR #70621)

2023-10-30 Thread via cfe-commits
https://github.com/daltairwalter updated https://github.com/llvm/llvm-project/pull/70621 >From f44d7746a990a3bd8e53de047a30baee4da2c790 Mon Sep 17 00:00:00 2001 From: Daniel Walter Date: Mon, 30 Oct 2023 00:08:56 -0500 Subject: [PATCH 1/4] Initial commit of add new check before changes --- ..

[clang] [clang][Module] Mark test unsupported since objc doesn't have xcoff/g… (PR #70661)

2023-10-30 Thread Richard Howell via cfe-commits
https://github.com/rmaz approved this pull request. https://github.com/llvm/llvm-project/pull/70661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >