zahiraam wrote:
@AaronBallman Do I have your thumb up for this? Thanks.
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@AaronBallman Do I have your thumb up for this? Thanks.
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Fazlay Rabbi
Date: 2023-10-24T10:17:52-07:00
New Revision: 86b4388c90726f4d8b3364969780e91f7e38a9aa
URL:
https://github.com/llvm/llvm-project/commit/86b4388c90726f4d8b3364969780e91f7e38a9aa
DIFF:
https://github.com/llvm/llvm-project/commit/86b4388c90726f4d8b3364969780e91f7e38a9aa.diff
https://github.com/mdfazlay closed
https://github.com/llvm/llvm-project/pull/69534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/67700
>From 2fa183da3991c0bc4da6163609331d198f4a37af Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Tue, 26 Sep 2023 19:48:18 -0500
Subject: [PATCH 1/3] [HLSL] Support vector swizzles on scalars
HLSL supports
https://github.com/yxsamliu approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/70055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/manman-ren edited
https://github.com/llvm/llvm-project/pull/69640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/70046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
isuckatcs wrote:
> I think this might be working around the issue rather than fixing it. It
> looks to me like the bug is in `Decl::printGroup`:
>
> https://github.com/llvm/llvm-project/blob/f4023d4d5d6a6f35ef2315f1b1ce7dd35f24e901/clang/lib/AST/DeclPrinter.cpp#L223
>
> We are printing the tag
https://github.com/AaronBallman approved this pull request.
LGTM, thank you for the revert.
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/AaronBallman approved this pull request.
LGTM, thank you for the revert.
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/Endilll approved this pull request.
DR test part of this PR looks fine to me.
https://github.com/llvm/llvm-project/pull/70018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/69126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -389,10 +391,28 @@ template class LocalScope : public
VariableScope {
if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) {
this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{});
this->Ctx->emitRecordDestruction(Local.Desc);
+r
Author: Zahira Ammarguellat
Date: 2023-10-24T13:46:28-04:00
New Revision: d593f6cb387fe86aad47d3b763abcf0048e5b568
URL:
https://github.com/llvm/llvm-project/commit/d593f6cb387fe86aad47d3b763abcf0048e5b568
DIFF:
https://github.com/llvm/llvm-project/commit/d593f6cb387fe86aad47d3b763abcf0048e5b568
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Author: antangelo
Date: 2023-10-24T14:07:52-04:00
New Revision: f418319730341e9d41ce8ead6fbfe5603c343985
URL:
https://github.com/llvm/llvm-project/commit/f418319730341e9d41ce8ead6fbfe5603c343985
DIFF:
https://github.com/llvm/llvm-project/commit/f418319730341e9d41ce8ead6fbfe5603c343985.diff
LOG
https://github.com/antangelo closed
https://github.com/llvm/llvm-project/pull/69676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Overhatted wrote:
@MaskRay I can't add reviewers to the PR, not sure if I should tag the code
owner or if I should just wait.
Sorry to bother you in case I was meant to wait.
https://github.com/llvm/llvm-project/pull/69887
___
cfe-commits mailing list
HazardyKnusperkeks wrote:
What Owen says. And given that the modified lines were removed, maybe the
issue(s) are also gone?
To the review unrelated, why didn't it get the
@llvm/pr-subscribers-clang-format thing?
https://github.com/llvm/llvm-project/pull/69859
_
@@ -3191,20 +3198,167 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments)
{
"}\n"
"// Comment";
-#if 0
- // FIXME: The following comment is aligned with the namespace comment.
verifyFormat("namespace A {\n"
" int Foo;\n"
@@ -182,7 +182,7 @@ TEST_F(FormatTestComments, UnderstandsSingleLineComments) {
"int a; // This is unrelated"));
EXPECT_EQ("class C {\n"
" void f() { // This does something ..\n"
-" } // awesome..\n"
+"
Author: cor3ntin
Date: 2023-10-24T20:42:31+02:00
New Revision: 20d97adfd3e9ba305bf23b13749e2ae0af1069b0
URL:
https://github.com/llvm/llvm-project/commit/20d97adfd3e9ba305bf23b13749e2ae0af1069b0
DIFF:
https://github.com/llvm/llvm-project/commit/20d97adfd3e9ba305bf23b13749e2ae0af1069b0.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/70018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/70107
When implementing thread_local as a keyword in C23, we accidentally started
using C++11 thread_local semantics when using that keyword instead of using C11
_Thread_local semantics.
This oversight is fixed
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
When implementing thread_local as a keyword in C23, we accidentally started
using C++11 thread_local semantics when using that keyword instead of using C11
_Thread_local semantics.
This oversight is f
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/70107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4076,8 +4076,15 @@ void Parser::ParseDeclarationSpecifiers(
case tok::kw_thread_local:
if (getLangOpts().C23)
Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName();
- isInvalid = DS.SetStorageClassSpecThread(DeclSpec::TSCS_thread_local,
Loc,
-
https://github.com/cor3ntin commented:
LGTM but I did not review the codegen tests.
https://github.com/llvm/llvm-project/pull/70107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -fsyntax-only -std=c23 %s -verify
+
+// Ensure that thread_local and _Thread_local are synonyms in C23 and both
+// restrict local variables to be explicitly static or extern.
+void func(void) {
+ // FIXME: it would be nice if the diagnostic s
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
@@ -389,10 +391,28 @@ template class LocalScope : public
VariableScope {
if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) {
this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{});
this->Ctx->emitRecordDestruction(Local.Desc);
+r
@@ -1736,26 +1750,20 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
StaleCI->eraseFromParent();
-// Emit the body for wrapper function
-BasicBlock *WrapperEntryBB =
-BasicBlock::Create(M.getContext(), "", WrapperFunc);
-Builder.SetInse
@@ -1523,41 +1560,31 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
BasicBlock *TaskAllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "task.alloca");
+ InsertPointTy TaskAllocaIP =
+ InsertPointTy(TaskAllocaBB, TaskAllocaBB->begin());
+ InsertP
@@ -1523,41 +1560,31 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
BasicBlock *TaskAllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "task.alloca");
+ InsertPointTy TaskAllocaIP =
+ InsertPointTy(TaskAllocaBB, TaskAllocaBB->begin());
+ InsertP
@@ -1523,41 +1560,31 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
BasicBlock *TaskAllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "task.alloca");
+ InsertPointTy TaskAllocaIP =
+ InsertPointTy(TaskAllocaBB, TaskAllocaBB->begin());
+ InsertP
@@ -1736,26 +1750,20 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
StaleCI->eraseFromParent();
-// Emit the body for wrapper function
-BasicBlock *WrapperEntryBB =
-BasicBlock::Create(M.getContext(), "", WrapperFunc);
-Builder.SetInse
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/70107
>From 9db10fc83ec3683b1d5b6f8606fc37a83fe224fa Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Tue, 24 Oct 2023 15:15:15 -0400
Subject: [PATCH 1/2] [C23] Use thread_local semantics
When implementing thre
@@ -5771,84 +5779,63 @@ OpenMPIRBuilder::createTeams(const LocationDescription
&Loc,
BasicBlock *AllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "teams.alloca");
+ // Generate the body of teams.
+ InsertPointTy AllocaIP(AllocaBB, AllocaBB->begin());
+ InsertPoin
@@ -1736,26 +1750,20 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
StaleCI->eraseFromParent();
-// Emit the body for wrapper function
-BasicBlock *WrapperEntryBB =
-BasicBlock::Create(M.getContext(), "", WrapperFunc);
-Builder.SetInse
@@ -4076,8 +4076,15 @@ void Parser::ParseDeclarationSpecifiers(
case tok::kw_thread_local:
if (getLangOpts().C23)
Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName();
- isInvalid = DS.SetStorageClassSpecThread(DeclSpec::TSCS_thread_local,
Loc,
-
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/70107
>From 9db10fc83ec3683b1d5b6f8606fc37a83fe224fa Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Tue, 24 Oct 2023 15:15:15 -0400
Subject: [PATCH 1/3] [C23] Use thread_local semantics
When implementing thre
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/70107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/70116
Summary:
This patch is a first step to remove dependencies on the OpenMPIRBuilder
for creating generic offloading entires. This patch changes no
functionality and merely moves the code around. In the future the
in
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Joseph Huber (jhuber6)
Changes
Summary:
This patch is a first step to remove dependencies on the OpenMPIRBuilder
for creating generic offloading entires. This patch changes no
functionality and merely moves the code around. In the f
https://github.com/goldsteinn updated
https://github.com/llvm/llvm-project/pull/67166
>From 9f9f1d20759f6a9d71f9131baa656bfb7d459095 Mon Sep 17 00:00:00 2001
From: Noah Goldstein
Date: Fri, 22 Sep 2023 08:21:21 -0500
Subject: [PATCH 1/6] [InstSimplify] Add tests for simplify `llvm.ptrmask`; NFC
@@ -6411,6 +6411,41 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value
*Op0, Value *Op1,
return Constant::getNullValue(ReturnType);
break;
}
+ case Intrinsic::ptrmask: {
+if (isa(Op0) || isa(Op1))
+ return PoisonValue::get(Op0->getType());
+
+
goldsteinn wrote:
Rebased ontop of nikic's patch
https://github.com/llvm/llvm-project/pull/67166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c780352de961371949333c3eb0d9d55fda39bf7f
93d72202bc5776483eddb9285ab384979caa85f4 --
jamesETsmith wrote:
Sorry for the delay, just circling back to this. @philnik777 should I update
the `robust_against_*` tests in both `test/std/algorithms` and
`test/libcxx/algorithms/`?
Probably a simple follow-up question, but you're interested in adding
`ranges::iota` to the `ranges_robus
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/70124
None
>From 3b420fcb0a6d74dc034cfdf2d7b28e13e75f0e08 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 24 Oct 2023 13:51:50 -0700
Subject: [PATCH] Add a new attribute value for suppressing WebKit's unsafe
memb
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/70116
>From 35347649fe160073e73c3bca96506b6fd96d8a31 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 24 Oct 2023 15:27:21 -0500
Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from
OpenMP
https://github.com/HighCommander4 approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/69775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: robozati
Date: 2023-10-24T17:29:43-04:00
New Revision: 2f3d4f6c9829bfc17a3e2d034286c03940d506ec
URL:
https://github.com/llvm/llvm-project/commit/2f3d4f6c9829bfc17a3e2d034286c03940d506ec
DIFF:
https://github.com/llvm/llvm-project/commit/2f3d4f6c9829bfc17a3e2d034286c03940d506ec.diff
LOG:
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/69775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/69283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/70127
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/4] [clang][DFP] Add basic builtin type representation for
Author: Chris Carlon
Date: 2023-10-24T17:33:00-04:00
New Revision: 3935a29a3e8acf31bb1658265e8f9b977435f6bb
URL:
https://github.com/llvm/llvm-project/commit/3935a29a3e8acf31bb1658265e8f9b977435f6bb
DIFF:
https://github.com/llvm/llvm-project/commit/3935a29a3e8acf31bb1658265e8f9b977435f6bb.diff
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/69283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/70127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -24,15 +24,38 @@
using namespace llvm;
-/// Get the __llvm_prf_cnts section.
-Expected getCountersSection(const object::ObjectFile &Obj)
{
+namespace llvm {
+// Deprecated. Use -profile-correlate=debug-info.
+cl::opt DebugInfoCorrelate(
+"debug-info-correlate",
+c
@@ -55,6 +56,7 @@
#include "llvm/Target/TargetOptions.h"
#include "llvm/TargetParser/SubtargetFeature.h"
#include "llvm/TargetParser/Triple.h"
+#include "llvm/Transforms/HipStdPar/HipStdPar.h"
ellishg wrote:
Is this include used?
https://github.com/llvm/llvm-
s1Sharp wrote:
yes, issue with breaking after << is gone. I want to get your point about
functionality clang-format and implementing new option such as
"BreakAfterStreamOperator". As i can see, @HazardyKnusperkeks you agree with
"owenca" point?
May be i can do something with this feature
htt
https://github.com/spupyrev updated
https://github.com/llvm/llvm-project/pull/68617
>From ca0e18230d9b61aa8d65113d2ad0292f3b61c8a0 Mon Sep 17 00:00:00 2001
From: spupyrev
Date: Thu, 12 Oct 2023 17:32:36 -0700
Subject: [PATCH 1/4] review
---
llvm/lib/Transforms/Utils/CodeLayout.cpp | 130 +
https://github.com/spupyrev updated
https://github.com/llvm/llvm-project/pull/68617
>From ca0e18230d9b61aa8d65113d2ad0292f3b61c8a0 Mon Sep 17 00:00:00 2001
From: spupyrev
Date: Thu, 12 Oct 2023 17:32:36 -0700
Subject: [PATCH 1/4] review
---
llvm/lib/Transforms/Utils/CodeLayout.cpp | 130 +
jyknight wrote:
I think we can check whether it's been overridden more easily using an asm
alias like this (when libc++ is built under -fno-exceptions):
```
#include
#include
__attribute__((weak)) void* operator new(std::size_t size) {
void* mem = malloc(size);
if (!mem) abort();
return
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/70116
>From 2af5fc3dc871f0bc3bdfeff4ed2c08f6ccd089d5 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 24 Oct 2023 15:27:21 -0500
Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from
OpenMP
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/70116
>From 8add2113864618d310e01bdbb0cf16e1847eb9a8 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 24 Oct 2023 15:27:21 -0500
Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from
OpenMP
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/70144
Previously, Clang wouldn't try to resolve the module for the header being
checked via `__has_include`. This meant that such header was considered textual
(a.k.a. part of the module Clang is currently compil
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
Previously, Clang wouldn't try to resolve the module for the header being
checked via `__has_include`. This meant that such header was considered textual
(a.k.a. part of the module Clang is currently com
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/70144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shiltian wrote:
Can this stuff really be generic?
https://github.com/llvm/llvm-project/pull/70116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> Can this stuff really be generic?
Obviously flags are going to be target dependent, but the actual form,
generation, and iteration of these can be generic. The idea is to put them all
into a single section such that we can filter out the ones that apply to
whatever runtime so
https://github.com/benlangmuir commented:
Can you clarify how this bug occurs in terms of what information about the
header is stored that causes us to get the wrong module? It seems bad that
passing `nullptr` to `LookupFile` could cause incorrect behaviour and makes me
wonder if we need to al
https://github.com/urnathan created
https://github.com/llvm/llvm-project/pull/70149
An assert is better here.
>From 1120a9bd5490dba672898f6902e60e461792b711 Mon Sep 17 00:00:00 2001
From: Nathan Sidwell
Date: Tue, 24 Oct 2023 20:20:18 -0400
Subject: [PATCH] [clang][NFC] Assert not llvm_unreach
https://github.com/shafik created
https://github.com/llvm/llvm-project/pull/70150
During constant evaluation when value-initializing a class if the base class
was default-initialized it would undue the previously zero-initialized class
members. This fixes the way we handle default initializati
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shafik Yaghmour (shafik)
Changes
During constant evaluation when value-initializing a class if the base class
was default-initialized it would undue the previously zero-initialized class
members. This fixes the way we handle default initi
oskarwirga wrote:
> Upon function entry the caller guarantees that it has probed the stack (e.g.
> performed a store) at some address [sp, #N], where0 <= N <= 1024.
I haven't been able to produce a minimal, sharable example as of yet, but I'm
encountering a runtime error associated with an inl
@@ -0,0 +1,54 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -0,0 +1,54 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaronpuchert edited
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
https://github.com/aaronpuchert commented:
I assume this is meant to imitate the GCC warning of the same name, which I
found pretty useful. Would be nice to have the same in Clang!
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailin
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c99 -Wmissing-format-attribute %s
+
+#include
+#include
+
+va_list args;
+
+__attribute__((__format__ (__scanf__, 1, 4)))
+void foo(char *out,
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c99 -Wmissing-format-attribute %s
+
+#include
+#include
+
+va_list args;
aaronpuchert wrote:
This should be in the function b
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
&CI,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
HaohaiWen wrote:
> > See most recent comments about missing tests. That being said code looks
> > functionally correct to me. Still not 100% sure this is a desirable change.
> > Will defer to @nikic about that.
>
> I'm also skeptical about accepting this optimization. Looking at the
> motivat
201 - 300 of 330 matches
Mail list logo
