[clang] [Clang] Actually fix tests for __builtin_vectorelements (PR #69589)

lawben wrote: @nikic Could you please double-check if the syntax here is correct. After the mistake in #69582, I'm a bit nervous about merging a wrong fix again... 😅 https://github.com/llvm/llvm-project/pull/69589 ___ cfe-commits mailing list cfe-com

[clang] [Clang] Actually fix tests for __builtin_vectorelements (PR #69589)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Lawrence Benson (lawben) Changes In #69582, I accidentally disabled all tests for the changed introduced in #69010. This change should use the correct `REQUIRES` syntax to en-/disable target-specific tests. --- Full diff: https://github.

[clang] [Clang] Actually fix tests for __builtin_vectorelements (PR #69589)

https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/69589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

@@ -12120,8 +12120,7 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult &LHS, ExprResult &RHS, auto FXSema = S.Context.getFixedPointSemantics(LHSExprType); LeftSize = FXSema.getWidth() - (unsigned)FXSema.hasUnsignedPadding(); } - llvm::APInt LeftBits(Right.ge

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

@@ -12120,8 +12120,7 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult &LHS, ExprResult &RHS, auto FXSema = S.Context.getFixedPointSemantics(LHSExprType); LeftSize = FXSema.getWidth() - (unsigned)FXSema.hasUnsignedPadding(); } - llvm::APInt LeftBits(Right.ge

[clang] 3d7802d - [Clang] Actually fix tests for __builtin_vectorelements (#69589)

Author: Lawrence Benson Date: 2023-10-19T13:40:41+02:00 New Revision: 3d7802d2107f4f6518f366effc0e237bffe67bf1 URL: https://github.com/llvm/llvm-project/commit/3d7802d2107f4f6518f366effc0e237bffe67bf1 DIFF: https://github.com/llvm/llvm-project/commit/3d7802d2107f4f6518f366effc0e237bffe67bf1.dif

[clang] [Clang] Actually fix tests for __builtin_vectorelements (PR #69589)

https://github.com/lawben closed https://github.com/llvm/llvm-project/pull/69589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Correct end for the CastOperation.OpRange (PR #69480)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/69480 From f75c2e75042d6d8f5a093967a56f3f59d7e541f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Botond=20Istv=C3=A1n=20Horv=C3=A1th?= <56926027+hob...@users.noreply.github.com> Date: Wed, 18 Oct 2023 18:05:01 +0200 Subject

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

https://github.com/zmodem commented: I think there should be a proper Clang flag to control this, instead of requiring users to pass internal `-mllvm` flags. (Also the flag should be well documented.) https://github.com/llvm/llvm-project/pull/69493

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/69595 https://github.com/llvm/llvm-project/pull/68999 correctly computed conversion sequence for reversed args to a template operators. This was a breaking change as code, previously accepted in C++17, starts to break i

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes https://github.com/llvm/llvm-project/pull/68999 correctly computed conversion sequence for reversed args to a template operators. This was a breaking change as code, previously accepted in C++17, starts to

[clang] 93373c3 - [clang][Interp][NFC] Use a const reference in IncDecHelper

Author: Timm Bäder Date: 2023-10-19T14:21:52+02:00 New Revision: 93373c3da9416e52d3f516435500e04a7d142370 URL: https://github.com/llvm/llvm-project/commit/93373c3da9416e52d3f516435500e04a7d142370 DIFF: https://github.com/llvm/llvm-project/commit/93373c3da9416e52d3f516435500e04a7d142370.diff LO

[clang] [clang][Interp] Implement inc/dec for IntegralAP (PR #69597)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/69597 The tests are commented out and I can't merge this yet, since it creates memory leaks when the interpretation is aborted midway through. This problem also exists with floating-point values: ```c++ constexpr lo

[clang] [clang][Interp] Implement inc/dec for IntegralAP (PR #69597)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The tests are commented out and I can't merge this yet, since it creates memory leaks when the interpretation is aborted midway through. This problem also exists with floating-point values: ```c++ constexpr

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Momchil Velikov (momchil-velikov) Changes This patch adds reinterpret builtins in the form svx_t svreinterpret___x(svx_t op) where - and designate the source and the destination type

[clang] [clang][Interp] Implement inc/dec for IntegralAP (PR #69597)

tbaederr wrote: This is also something that would be fixed by https://reviews.llvm.org/D154581 it seems. https://github.com/llvm/llvm-project/pull/69597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/69104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8505c3b15bfc535ff6624e71add4082680745187 27a1015bb19caa15bc56817a1c90364af5f4bec3 --

[clang] [clang][dataflow] Remove `DataflowAnalysisContext::flowConditionIsTautology()`. (PR #69601)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/69601 It's only used in its own unit tests. >From 133d04d8cc6ae6f4ad87bf17ea721d29c41433d5 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Thu, 19 Oct 2023 12:38:25 + Subject: [PATCH] [clang][dataflow] R

[clang] [clang][dataflow] Remove `DataflowAnalysisContext::flowConditionIsTautology()`. (PR #69601)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes It's only used in its own unit tests. --- Full diff: https://github.com/llvm/llvm-project/pull/69601.diff 3 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder updated this revision to Diff 557773. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Descriptor.h clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/EvalEmit

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.h:203 +public: /// Initializes the map with no fields set. aaron.ballman wrote: > This interface is now more confusing as to how to use because it now has a > public non-default cons

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69595 >From 4460b02508d21d98cf05103bece99fc5bd474ab0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 19 Oct 2023 12:33:45 +0200 Subject: [PATCH 1/3] Reapply "Correctly compute conversion seq for args to fn with

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/67519 >From 400c889a4f0e867e3e2ceee43ae5c91f62f63c4d Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 18:20:05 +0530 Subject: [PATCH] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-li

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

https://github.com/xgupta reopened https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 311f725 - [clang][Interp] Create only globals when initializing a global variable

Author: Timm Bäder Date: 2023-10-19T14:50:17+02:00 New Revision: 311f725d9a6fa29b5672a2dd26a078c6c6dcd01a URL: https://github.com/llvm/llvm-project/commit/311f725d9a6fa29b5672a2dd26a078c6c6dcd01a DIFF: https://github.com/llvm/llvm-project/commit/311f725d9a6fa29b5672a2dd26a078c6c6dcd01a.diff LO

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG311f725d9a6f: [clang][Interp] Create only globals when initializing a global variable (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[clang] [clang][Interp] Handle unknown-size arrays better (PR #68868)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/68868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][Interp] Add explicit dummy descriptors (PR #68888)

Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/6 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

@@ -139,9 +139,23 @@ std::optional ProfileList::isFileExcluded(StringRef FileName, CodeGenOptions::ProfileInstrKind Kind) const { StringRef Section = getSectionName(Kind); - // Check for "source:=" + + // Convert the input file path to its canoni

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69595 >From 4460b02508d21d98cf05103bece99fc5bd474ab0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 19 Oct 2023 12:33:45 +0200 Subject: [PATCH 1/4] Reapply "Correctly compute conversion seq for args to fn with

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69360 >From be3f5faa6cd17d76f26fb1bc6d6b59a8a78ffe82 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 17 Oct 2023 19:37:28 +0200 Subject: [PATCH] Lifetime bound check for coroutine --- clang/lib/Sema/SemaInit.cp

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,28 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[PATCH] D151433: [Clang][SVE2.1] Add builtins for Multi-vector load and store

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. Thanks @CarolineConcatto, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151433/new/ https://reviews.llvm.org/D151433 __

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: AaronBallman wrote: > Ping Did you see https://github.com/llvm/llvm-project/pull/67095#discussion_r1355468253 ? https://github.com/llvm/llvm-project/pull/67095 ___ cfe-commit

[clang] [CXXNameMangler] Correct the mangling of SVE ACLE types within function names. (PR #69460)

https://github.com/david-arm approved this pull request. LGTM! An outstanding work of art @paulwalker-arm! https://github.com/llvm/llvm-project/pull/69460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: > > Ping > > Did you see [#67095 > (comment)](https://github.com/llvm/llvm-project/pull/67095#discussion_r1355468253) > ? Yes, I added the changes to `processTypeAttrs()` and added the subject list ba

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: AaronBallman wrote: > > > Ping > > > > > > Did you see [#67095 > > (comment)](https://github.com/llvm/llvm-project/pull/67095#discussion_r1355468253) > > ? > > Yes, I added the changes to `processTypeAttrs()` and add

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -8602,6 +8602,31 @@ static void HandleAnnotateTypeAttr(TypeProcessingState &State, CurType = State.getAttributedType(AnnotateTypeAttr, CurType, CurType); } +static void HandleRequiresCapabilityAt

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -136,6 +136,17 @@ int main(void) { // Cleanup happens automatically -> no warning. } + /// Function pointers + { +int __attribute__((requires_capability(&mu1))) (*function_ptr)(int) = F

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/66702 >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 18 Sep 2023 15:18:24 -0600 Subject: [PATCH 1/6] [flang][Driver] Support -rpath, -shared, and -static in t

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading (PR #68986)

dzhidzhoev wrote: > FWIW, I think we also saw, internally at Google, some significant and > surprising (growth in sections, like .debug_loclists and > .debug_gnu_pubnames/types) that were a bit surprising/not what I'd have > expected of the original committed/reverted patch. > > Could you run

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

https://github.com/erichkeane commented: I think this looks right, but if @shafik would take an additional look, I'd appreciate it. Additionally, this needs a release note. https://github.com/llvm/llvm-project/pull/69521 ___ cfe-commits mailing list

[clang] [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (PR #69469)

@@ -934,6 +934,76 @@ Check calls to various UNIX/Posix functions: ``open, pthread_once, calloc, mallo .. literalinclude:: checkers/unix_api_example.c :language: c +.. _unix-Errno: + +unix.Errno (C) +"" + +Check for improper use of ``errno``. +This checker impl

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

https://github.com/erichkeane commented: The release note needs work, and I'm not completely sure what you mean to say, if you try to clarify it, perhaps I can help correct the wording. Else LGTM. https://github.com/llvm/llvm-project/pull/68878 ___ c

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

@@ -396,6 +396,10 @@ Bug Fixes in This Version cannot be used with ``Release`` mode builds. (`#68237 `_). - Fix crash in evaluating ``constexpr`` value for invalid template function. Fixes (`#68542

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

https://github.com/erichkeane commented: The release note needs work, and I'm not completely sure what you mean to say, if you try to clarify it, perhaps I can help correct the wording. Else LGTM. https://github.com/llvm/llvm-project/pull/68878 ___ c

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

erichkeane wrote: > I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this > assertion but it will not result in crash.So I think you should not remove > this assertion and try to find the reason `!Result.isAbsent()` Maybe its > valueKind changed somewhere(just my guess). I ag

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

@@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -verify %s + +struct A { + enum E : unsigned {}; + [[clang::preferred_type(E)]] unsigned b : 2; + [[clang::preferred_type(E)]] int b2 : 2; + // expected-warning@-1 {{underlying type 'unsigned int' of enumeration 'E' doesn't match bit-field

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,28 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

erichkeane wrote: >I meant warning on something like https://godbolt.org/z/Ma17xjjc5. That >doesn't seem like it should be that hard. Yeah, that one wouldn't be too hard (and isn't a pattern I've ever seen TBH), but doesn't solve the problem at hand, which is that it is very common to need to

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: DonatNagyE wrote: @steakhal Could you briefly look at this commit? I'm open to modifying it if you say that it's necessary, but if I could merge it, then I'd be able to rebase and finalize my next commit (which adds det

[clang-tools-extra] [clang] Correct end for the `CastOperation.OpRange` (PR #69480)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: https://github.com/whisperity edited https://github.com/llvm/llvm-project/pull/69480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang] Correct end for the `CastOperation.OpRange` (PR #69480)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: https://github.com/whisperity edited https://github.com/llvm/llvm-project/pull/69480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] [CXXNameMangler] Correct the mangling of SVE ACLE types within function names. (PR #69460)

paulwalker-arm wrote: I've updated the release note to remove bogus references to a function's return type affecting its name mangling. https://github.com/llvm/llvm-project/pull/69460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] b781c7a - Fixed some wmma store builtins that had non-const src param

Author: JackAKirk Date: 2023-10-19T15:38:50+01:00 New Revision: b781c7ab574f54f54e1b32421398c723f3690f05 URL: https://github.com/llvm/llvm-project/commit/b781c7ab574f54f54e1b32421398c723f3690f05 DIFF: https://github.com/llvm/llvm-project/commit/b781c7ab574f54f54e1b32421398c723f3690f05.diff LOG

[clang] [NVPTX] Fixed some wmma store builtins that had non-const src param. (PR #69354)

https://github.com/ldrumm closed https://github.com/llvm/llvm-project/pull/69354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Fixed some wmma store builtins that had non-const src param. (PR #69354)

ldrumm wrote: ``` To github.com:llvm/llvm-project.git

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] Let clang-cl support CUDA/HIP (PR #68921)

yxsamliu wrote: ping. we tested it on Windows and it is able to compile both C++ and HIP without issues. https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

Endilll wrote: >>@erichkeane I guess you'd be pretty happy if our enums were declared the >> following way: >Not really? That doesn't gain us the 'we must change where this is stored' >situation like a preferred_type attribute would/could. We MIGHT be able to get >away with a comment on t

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

erichkeane wrote: > > > @erichkeane I guess you'd be pretty happy if our enums were declared the > > > following way: > > > Not really? That doesn't gain us the 'we must change where this is stored' > > situation like a preferred_type attribute would/could. We MIGHT be able to > > get away wi

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

Endilll wrote: Taking the example above, I think it would have to look the following way to fully complement a check for bit-field width in `preferred_type`: ```cpp enum StoredNameKind : unsigned _BitInt(3) { StoredIdentifier = 0, StoredObjCZeroArgSelector = Selector::ZeroArg, Store

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

erichkeane wrote: Ah, found it: https://godbolt.org/z/59sc87Y3Y See how on the assignment to a bitfield we check to make sure the largest value of the enum will fit in the bitfield? I'm saying I want us to do this EARLIER, on declaration with this attribute. https://github.com/llvm/llvm-proj

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

Endilll wrote: > See how on the assignment to a bitfield we check to make sure the largest > value of the enum will fit in the bitfield? I'm saying I want us to do this > EARLIER, on declaration with this attribute. I totally do. Thank you for pointing out to `-Wbitfield-enum-conversion`! But

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

jansvoboda11 wrote: > @jansvoboda11 still good with this change, or is there a less invasive way to > get this done? Hi, sorry for being unresponsive, I'm out of office until the end of the week. This looks reasonable to me, but I'd like to run a smoke test with the Darwin SDK first. I can ge

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

erichkeane wrote: > > See how on the assignment to a bitfield we check to make sure the largest > > value of the enum will fit in the bitfield? I'm saying I want us to do this > > EARLIER, on declaration with this attribute. > > I totally do. Thank you for pointing out to `-Wbitfield-enum-conv

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

https://github.com/benlangmuir commented: Is the issue with MDC's FileDeps that we are calling `makeAbsoluteAndPreferred` on the paths? Maybe we could instead move that call into `FullDependencyConsumer`. Or are there other issues? The fact we need to add additional `MDC.IsStdModuleP1689Form

[clang] Let clang-cl support CUDA/HIP (PR #68921)

https://github.com/rnk approved this pull request. Yep, we are fairly liberal about adding new clang options to the clang-cl mode, especially if they are in the feature `-f` flag namespace, which we believe will not conflict with MSVC flags. https://github.com/llvm/llvm-project/pull/68921

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

CarolineConcatto wrote: I think it is fine to point also the PR in the acle in the commit message: https://github.com/ARM-software/acle/pull/275/files https://github.com/llvm/llvm-project/pull/69598 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

https://github.com/ilya-biryukov requested changes to this pull request. https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang] [AMDGPU] Add an option to disable unsafe uses of atomic xor (PR #69229)

jansvoboda11 wrote: The command-line changes look good to me. Adding @arsenm as a reviewer proper. https://github.com/llvm/llvm-project/pull/69229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

@@ -1,336 +1,813 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // REQUIRES: aarch64-registered-target // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -S -disable-O0-optnone -Werror -Wall -emit-llvm

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

@@ -1,336 +1,813 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // REQUIRES: aarch64-registered-target // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -S -disable-O0-optnone -Werror -Wall -emit-llvm

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

Endilll wrote: > when does someone have an enum value that they don't intend to ever be in the > enum In my previous comments (https://github.com/llvm/llvm-project/pull/69104#issuecomment-1771167758, https://github.com/llvm/llvm-project/pull/69104#issuecomment-1771204043) I provided an examp

[clang] e880e8a - Let clang-cl support CUDA/HIP (#68921)

Author: Yaxun (Sam) Liu Date: 2023-10-19T11:56:56-04:00 New Revision: e880e8aedbc17ba04c969c9426d1f2567af72e7b URL: https://github.com/llvm/llvm-project/commit/e880e8aedbc17ba04c969c9426d1f2567af72e7b DIFF: https://github.com/llvm/llvm-project/commit/e880e8aedbc17ba04c969c9426d1f2567af72e7b.dif

[clang] Let clang-cl support CUDA/HIP (PR #68921)

https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

rnk wrote: I still support disabling delayed template parsing by default in all configurations. Ultimately, this feature is a source of bugs, and we should start the clock on its deprecation and removal. This, of course, involves real work, and I haven't allocated any time (mine or others') to

[PATCH] D151439: [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed)

CarolineConcatto updated this revision to Diff 557782. CarolineConcatto added a comment. -Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151439/new/ https://reviews.llvm.org/D151439 Files: clang/include/clang/Basic/arm_sve.td clang/test/

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

erichkeane wrote: >In my previous comments >(https://github.com/llvm/llvm-project/pull/69104#issuecomment-1771167758, >https://github.com/llvm/llvm-project/pull/69104#issuecomment-1771204043) I >provided an example of StoredNameKind enum that has enumerators 0 through 8 (9 >total, 4 bits to s

[clang] 9f93a99 - [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed)

Author: Caroline Concatto Date: 2023-10-19T16:10:51Z New Revision: 9f93a99a096c093b5c205cf9143d88ba1b53 URL: https://github.com/llvm/llvm-project/commit/9f93a99a096c093b5c205cf9143d88ba1b53 DIFF: https://github.com/llvm/llvm-project/commit/9f93a99a096c093b5c205cf9143d88ba1b53.diff

[PATCH] D151439: [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f93a99a096c: [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed) (authored by CarolineConcatto). Repository: rG LLVM Github Monorepo

[PATCH] D151461: [Clang][SVE2.1] Add builtins and intrinsics for SVBFMLSLB/T

CarolineConcatto updated this revision to Diff 557784. CarolineConcatto added a comment. - Rebase and - change test names to use _lane instead of _idx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151461/new/ https://reviews.llvm.org/D151461 Files

[PATCH] D151461: [Clang][SVE2.1] Add builtins and intrinsics for SVBFMLSLB/T

CarolineConcatto updated this revision to Diff 557785. CarolineConcatto added a comment. -Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151461/new/ https://reviews.llvm.org/D151461 Files: clang/include/clang/Basic/arm_sve.td clang/inclu

[clang] [AMDGPU] Add an option to disable unsafe uses of atomic xor (PR #69229)

pasaulais wrote: > The command-line changes look good to me. Adding @arsenm as a reviewer proper. Thanks Jan! https://github.com/llvm/llvm-project/pull/69229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

Endilll wrote: > which brings up an additional concern/thing to deal with for the non_storable > attribute (that is, do we apply it to assignments? how about > exact-assignments like you've done there?). Conservative approach would be to issue diagnostics based on `non_storable` only when LHS

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

@@ -1,336 +1,813 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // REQUIRES: aarch64-registered-target // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -S -disable-O0-optnone -Werror -Wall -emit-llvm

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

erichkeane wrote: > > which brings up an additional concern/thing to deal with for the > > non_storable attribute (that is, do we apply it to assignments? how about > > exact-assignments like you've done there?). > > Conservative approach would be to issue diagnostics based on `non_storable`

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

@@ -1,336 +1,813 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // REQUIRES: aarch64-registered-target // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -S -disable-O0-optnone -Werror -Wall -emit-llvm

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

AaronBallman wrote: > Taking the example above, I think it would have to look the following way to > fully complement a check for bit-field width in `preferred_type`: > > ```c++ > enum StoredNameKind : unsigned _BitInt(3) { > ... snip ... >``` > I think we can robustly diagnose new enumerator

[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/69371 >From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Tue, 17 Oct 2023 12:01:15 -0700 Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new head

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

erichkeane wrote: >>I'm still thinking my way through a non_storable attribute, but on its face, >>it seems like it could be overkill. I suspect (but haven't measured!) that >>there is way more code out there that maps enumerations to bit-fields that >>expect all members of the enumeration to

[clang] Correctly link and optimize device libraries with -mlink-builtin-bitcode (PR #69371)

jhuber6 wrote: > > You could potentially link in all the symbols and internalize them > > That probably won't work. After they are internalized, they have internal > linkage and cannot be used to resolve newly added call of the same function. > > The purpose of internalization is to allow you

<    1   2   3   4   5   >