[clang-tools-extra] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-11 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Tagging @llvm/pr-subscribers-compiler-rt-sanitizer for visibility again, since this PR is abandoned. https://github.com/llvm/llvm-project/pull/67673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-11 Thread via cfe-commits
https://github.com/fel-cab updated https://github.com/llvm/llvm-project/pull/68016 >From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001 From: Felipe Cabarcas Date: Mon, 18 Sep 2023 12:07:12 + Subject: [PATCH 01/13] testing Profiler features --- openmp/libomptarget/src/i

[clang] [flang] Add flags controlling whether to run the fir alias tags pass (PR #68595)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
@@ -54,6 +54,9 @@ struct FIRToLLVMPassOptions { // Generate TBAA information for FIR types and memory accessing operations. bool applyTBAA = false; + + // force the usage of a unified tbaa tree in TBAABuilder banach-space wrote: Upper case + full stop.

[clang] [flang] Add flags controlling whether to run the fir alias tags pass (PR #68595)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
@@ -214,6 +214,14 @@ static void parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts, clang::driver::options::OPT_fno_loop_versioning, false)) opts.LoopVersioning = 1; + opts.AliasAnalysis = false; + if (auto *arg = + args.getLastArg(cla

[clang] [flang] Add flags controlling whether to run the fir alias tags pass (PR #68595)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
@@ -0,0 +1,47 @@ +// test that tbaa attributes can be added to fir.load and fir.store banach-space wrote: Start with upper case https://github.com/llvm/llvm-project/pull/68595 ___ cfe-commits mailing list cfe-commits@l

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-11 Thread Rainer Orth via cfe-commits
rorth wrote: > > I wonder how to proceed with the patch at hand. > > I'm not a Solaris expert, but based on this discussion I'd consider adding > support for `-fuse-ld` in Flang. This sort of changes are often as simple as > updating Options.td. Same for `-r`. Support of `-fuse-ld` is not Sol

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-11 Thread Rainer Orth via cfe-commits
rorth wrote: > I'd like for this to move forward. Agreed: AFAICS the only open issue is whether the Solaris test should use the `GNU` label as I have done, introduce an new common one (like `UNIX`; there's nothing GNU-specific in that test), or really introduce a separate copy of the check un

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-11 Thread via cfe-commits
@@ -0,0 +1,82 @@ +//===--- CoroutineSuspensionHostileCheck.cpp - clang-tidy --===// EugeneZelenko wrote: Please make it same length as line at the end of comment block. https://github.com/llvm/llvm-project/pull/68738 _

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-11 Thread via cfe-commits
@@ -0,0 +1,82 @@ +//===--- CoroutineSuspensionHostileCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-11 Thread via cfe-commits
@@ -0,0 +1,48 @@ +.. title:: clang-tidy - misc-coroutine-hostile-raii + +misc-coroutine-hostile-raii + + +This check detects hostile-RAII objects which should not persist across a +suspension point in a coroutine. + +Some objects require that they be destroyed

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-11 Thread via cfe-commits
@@ -180,6 +180,12 @@ New checks Detects C++ code where a reference variable is used to extend the lifetime of a temporary object that has just been constructed. +- New :doc:`misc-coroutine-hostile-raii EugeneZelenko wrote: Please keep alphabetical order (

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-11 Thread via cfe-commits
@@ -0,0 +1,44 @@ +//===--- CoroutineHostileRAIICheck.h - clang-tidy ---*- C++-*-===// EugeneZelenko wrote: Please add one more dash. https://github.com/llvm/llvm-project/pull/68738 ___ cfe-commits mailing l

[clang] [clang] __is_trivially_equality_comparable for types containing lambdas (PR #68506)

2023-10-11 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/68506 >From cac3c586a85e1070b2d4aa2ccbc1589c1c84105c Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Sat, 7 Oct 2023 19:02:34 +0330 Subject: [PATCH 1/3] [clang] Rename some misleading names (Non-functional) ---

[clang-tools-extra] [mlir][OpenMP] Added omp.region operation (PR #65243)

2023-10-11 Thread via cfe-commits
shraiysh wrote: Sure I'll do that. https://github.com/llvm/llvm-project/pull/65243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] __is_trivially_equality_comparable for types containing lambdas (PR #68506)

2023-10-11 Thread Amirreza Ashouri via cfe-commits
AMP999 wrote: @cor3ntin Can you land this for me? https://github.com/llvm/llvm-project/pull/68506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] __is_trivially_equality_comparable for types containing lambdas (PR #68506)

2023-10-11 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/68506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4313351 - [clang] __is_trivially_equality_comparable for types containing lambdas (#68506)

2023-10-11 Thread via cfe-commits
Author: Amirreza Ashouri Date: 2023-10-11T17:12:15+02:00 New Revision: 4313351c135cc32cdf3b3fc3e44cf57f100a96ef URL: https://github.com/llvm/llvm-project/commit/4313351c135cc32cdf3b3fc3e44cf57f100a96ef DIFF: https://github.com/llvm/llvm-project/commit/4313351c135cc32cdf3b3fc3e44cf57f100a96ef.di

[clang] [clang][Interp] Support AddOffset with 128bit offsets (PR #68679)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -1437,7 +1437,7 @@ bool OffsetHelper(InterpState &S, CodePtr OpPC, const T &Offset, return false; }; - unsigned MaxOffset = MaxIndex - Ptr.getIndex(); + T MaxOffset = T::from(MaxIndex - Ptr.getIndex(), Offset.bitWidth()); AaronBallman wrote: I thi

[libunwind] [OpenMPIRBuilder] Add ThreadLimit and NumTeams clauses to teams construct (PR #68364)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh closed https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMPIRBuilder] Add ThreadLimit and NumTeams clauses to teams construct (PR #68364)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh closed https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeams clauses to teams construct (PR #68364)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh closed https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [OpenMPIRBuilder] Add ThreadLimit and NumTeams clauses to teams construct (PR #68364)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh closed https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Consistently pass start+length to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/68813 It previously took a start+end pint_t, but all but one callsite were actually passing start+length arguments. This should not have any functional change since the end argument is almost always ignored. I not

[libunwind] [libunwind] Consistently pass start+length to decodeEHHdr() (PR #68813)

2023-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Alexander Richardson (arichardson) Changes It previously took a start+end pint_t, but all but one callsite were actually passing start+length arguments. This should not have any functional change since the end argument is almost alway

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/68815 I was running the tests with baremetal picolibc which has a linker script that __eh_frame_start==__eh_frame_end (not equal to zero) in case there is no .eh_frame_hdr. I noticed that libunwind was trying to rea

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-11 Thread Richard Smith via cfe-commits
@@ -7098,6 +7052,69 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const VectorType *VTy = Ty->castAs(); +QualType EltTy = VTy->getElementType(); +unsigned NElts = VTy->getNumElemen

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Alexander Richardson (arichardson) Changes I was running the tests with baremetal picolibc which has a linker script that __eh_frame_start==__eh_frame_end (not equal to zero) in case there is no .eh_frame_hdr. I noticed that libunwind w

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

2023-10-11 Thread via cfe-commits
dankm wrote: If this looks good to people, is anyone able to merge it? I cannot do it myself. https://github.com/llvm/llvm-project/pull/68011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Kiran Chandramohan via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) kiranchandramohan wrote:

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Renaud Kauffmann via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) Renaud-K wrote: No, they

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Tom Eccles via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) tblah wrote: Thank you f

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-11 Thread Jerin Philip via cfe-commits
@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const { retur

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Saleem Abdulrasool via cfe-commits
@@ -53,8 +53,21 @@ template class EHHeaderParser { template bool EHHeaderParser::decodeEHHdr(A &addressSpace, pint_t ehHdrStart, -pint_t ehHdrEnd, EHHeaderInfo &ehHdrInfo) { +size_t ehHdrSize, EHHeaderIn

[libunwind] [libunwind] Consistently pass start+length to decodeEHHdr() (PR #68813)

2023-10-11 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd requested changes to this pull request. Can we merge this into #68815 please? https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-11 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 12b87f6 - [Driver] Silence stdlib warning when linking C on FreeBSD (#68011)

2023-10-11 Thread via cfe-commits
Author: dankm Date: 2023-10-11T12:28:04-04:00 New Revision: 12b87f6ef720080fab1e2d48ca2d8c5ba478ee5d URL: https://github.com/llvm/llvm-project/commit/12b87f6ef720080fab1e2d48ca2d8c5ba478ee5d DIFF: https://github.com/llvm/llvm-project/commit/12b87f6ef720080fab1e2d48ca2d8c5ba478ee5d.diff LOG: [D

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

2023-10-11 Thread Ed Maste via cfe-commits
https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/68011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

2023-10-11 Thread via cfe-commits
skc7 wrote: @hctim, We want to identify global variables instrumented by asan at AsmPrinter stage. I can think of two approaches here: - Add SanitizerMetadata::NoAddress(false) at asan pass and also check if global is present in llvm.compiler.used list. - Create a new attribute (For Ex: "A

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
@@ -53,8 +53,21 @@ template class EHHeaderParser { template bool EHHeaderParser::decodeEHHdr(A &addressSpace, pint_t ehHdrStart, -pint_t ehHdrEnd, EHHeaderInfo &ehHdrInfo) { +size_t ehHdrSize, EHHeaderIn

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
@@ -53,8 +53,21 @@ template class EHHeaderParser { template bool EHHeaderParser::decodeEHHdr(A &addressSpace, pint_t ehHdrStart, -pint_t ehHdrEnd, EHHeaderInfo &ehHdrInfo) { +size_t ehHdrSize, EHHeaderIn

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Saleem Abdulrasool via cfe-commits
@@ -53,8 +53,21 @@ template class EHHeaderParser { template bool EHHeaderParser::decodeEHHdr(A &addressSpace, pint_t ehHdrStart, -pint_t ehHdrEnd, EHHeaderInfo &ehHdrInfo) { +size_t ehHdrSize, EHHeaderIn

[libunwind] [libunwind] Consistently pass start+length to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68813 >From ff360ee7f304424dd0d12d00b8c0ba6801241410 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:34:55 -0700 Subject: [PATCH] [libunwind] Fix wrong end argument passed to decodeEHHdr()

[libunwind] [libunwind] Consistently pass start+length to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast approved this pull request. LGTM, but I am not sure if @stefanp-ibm continues to be concerned about enabling this for ABIs that have not been updated to specify a treatment of the VSX registers. https://github.com/llvm/llvm-project/pull/68476 _

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
arichardson wrote: > Can we merge this into #68815 please? I'd like to keep the two commits separate since they are addressing different bugs. https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
arichardson wrote: > > Can we merge this into #68815 please? > > I'd like to keep the two commits separate since they are addressing different > bugs. This would be a lot easier if I could chose rebase+merge in the PR flow. https://github.com/llvm/llvm-project/pull/68813 _

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68815 >From ff360ee7f304424dd0d12d00b8c0ba6801241410 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:34:55 -0700 Subject: [PATCH 1/2] [libunwind] Fix wrong end argument passed to decodeEHH

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

2023-10-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158069/new/ https://reviews.llvm.org/D158069 ___ cfe-commits mailing lis

[clang] Add support for -fcx-limited-range and #pragma CX_LIMTED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/68820 None >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH] Add support for -fcx-limited-range and #pragma CX_LIMTED_R

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/68820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-10-11 Thread Andrew Kaster via cfe-commits
@@ -483,6 +483,56 @@ struct FragmentCompiler { FullyQualifiedNamespaces.begin(), FullyQualifiedNamespaces.end()); }); } +auto QuotedFilter = compileHeaderRegexes(F.QuotedHeaders); +if (QuotedFilter.has_value()) { + Out.Apply.push_back( +

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c1b6ed42b75a17d1718aa377f76633b27e15a4e2 91de35737b74233f29da76573b4099bf64e8bdd4 --

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Stefan Pintilie via cfe-commits
@@ -828,10 +829,7 @@ const TargetInfo::AddlRegName GCCAddlRegNames[] = { }; ArrayRef PPCTargetInfo::getGCCAddlRegNames() const { - if (ABI == "elfv2") -return llvm::ArrayRef(GCCAddlRegNames); - else -return TargetInfo::getGCCAddlRegNames(); + return llvm::ArrayRef(G

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm approved this pull request. Thank you for fixing this! LGTM. https://github.com/llvm/llvm-project/pull/68476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm edited https://github.com/llvm/llvm-project/pull/68476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Hubert Tong via cfe-commits
hubert-reinterpretcast wrote: The code formatting check failure seems to be a infrastructure problem: https://discourse.llvm.org/t/clang-format-github-action-cannot-find-merge-base/73894 https://github.com/llvm/llvm-project/pull/68476 ___ cfe-commits

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -1,12 +1,14 @@ -// RUN: %clang_cc1 -verify -Wunused -Wused-but-marked-unused -Wunused-parameter -fsyntax-only %s +// RUN: %clang_cc1 -verify -Wunused -Wused-but-marked-unused -Wunused-parameter -fsyntax-only -fdeclspec %s int a; inline __attribute__((noreturn(a))) void *f

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -177,6 +177,10 @@ def warn_unknown_attribute_ignored : Warning< "unknown attribute %0 ignored">, InGroup; def warn_attribute_ignored : Warning<"%0 attribute ignored">, InGroup; +def warn_multiarg_malloc_attribute_ignored: Warning< + "'malloc' attribute ignored because"

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -289,6 +289,11 @@ Bug Fixes to Compiler Builtins Bug Fixes to Attribute Support ^^ +- Clang now emits a warning instead of an error when using the one or two + argument form of GCC 11's ``__attribute__((malloc(deallocator)))`` + or ``__attribut

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -3315,7 +3315,7 @@ def RequiresCapability : InheritableAttr { let TemplateDependent = 1; let ParseArgumentsAsUnevaluated = 1; let InheritEvenIfAlreadyPresent = 1; - let Subjects = SubjectList<[Function]>; + /*let Sub

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/67095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman commented: The changes also need a release note at some point. https://github.com/llvm/llvm-project/pull/67095 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -8141,6 +8141,16 @@ static void handleRequiresCapabilityAttr(Sema &S, Decl *D, if (!AL.checkAtLeastNumArgs(S, 1)) return; + // We allow this on function declaration as well as + // variable declarations of function

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -136,6 +136,17 @@ int main(void) { // Cleanup happens automatically -> no warning. } + /// Function pointers + { +int __attribute__((requires_capability(&mu1))) (*function_ptr)(int) = Foo_fun1;

[clang] [clang] static operators should evaluate object argument (PR #68485)

2023-10-11 Thread Tianlan Zhou via cfe-commits
https://github.com/SuperSodaSea updated https://github.com/llvm/llvm-project/pull/68485 >From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 7 Oct 2023 21:05:17 +0800 Subject: [PATCH 1/6] [clang] static operators should evaluate object argument

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68825 This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation i

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68825 This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation i

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Shraiysh (shraiysh) Changes This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation in

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Shraiysh (shraiysh) Changes This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation in

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
shraiysh wrote: Restarting discussion about yield here because something went wrong with rebasing on previous PR. Hopefully this won't have the same issues. Sorry :( I will push commit with yield as terminator soon. https://github.com/llvm/llvm-project/pull/68825 __

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
shraiysh wrote: Restarting discussion about yield here because something went wrong with rebasing on previous PR. Hopefully this won't have the same issues. Sorry :( I will push commit with yield as terminator soon. https://github.com/llvm/llvm-project/pull/68825 __

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/68815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68825 >From ff635ce0ce910f0cde248a4babb3c27333ddc108 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Sun, 3 Sep 2023 22:40:10 -0500 Subject: [PATCH 1/3] [mlir][OpenMP] Added omp.region operation This patch adds

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68825 >From ff635ce0ce910f0cde248a4babb3c27333ddc108 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Sun, 3 Sep 2023 22:40:10 -0500 Subject: [PATCH 1/3] [mlir][OpenMP] Added omp.region operation This patch adds

[libunwind] 05181a8 - [libunwind] Fix wrong end argument passed to decodeEHHdr() (#68813)

2023-10-11 Thread via cfe-commits
Author: Alexander Richardson Date: 2023-10-11T19:35:11+01:00 New Revision: 05181a849b4c1ec14fdd6d667285d6f5ad34a5a2 URL: https://github.com/llvm/llvm-project/commit/05181a849b4c1ec14fdd6d667285d6f5ad34a5a2 DIFF: https://github.com/llvm/llvm-project/commit/05181a849b4c1ec14fdd6d667285d6f5ad34a5a

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68815 >From 63415241cd457cd4bcd0661e077b9f8c48e246e2 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:52:45 -0700 Subject: [PATCH] [libunwind] Avoid reading OOB for non-existent .eh_frame_hd

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68815 >From 5d4e2bc5570f9fbcdebff2532370ad21f5cef2bb Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:52:45 -0700 Subject: [PATCH] [libunwind] Avoid reading OOB for non-existent .eh_frame_hd

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -6171,6 +6171,11 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "conversion fr

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hi @AaronBallman , I ran a compile using this change on clang as you asked > and have results. The compile ran with no crashes or errors, and produced > 1478 bitfield-conversion warnings. I'll show a few examples below. To put > that number into context, I enabled -Wconve

[libunwind] eb21049 - [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (#68815)

2023-10-11 Thread via cfe-commits
Author: Alexander Richardson Date: 2023-10-11T19:46:09+01:00 New Revision: eb21049b4b904b072679ece60e73c6b0dc0d1ebf URL: https://github.com/llvm/llvm-project/commit/eb21049b4b904b072679ece60e73c6b0dc0d1ebf DIFF: https://github.com/llvm/llvm-project/commit/eb21049b4b904b072679ece60e73c6b0dc0d1eb

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/68815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

2023-10-11 Thread Alexander Richardson via cfe-commits
@@ -886,7 +893,7 @@ def ARMInterrupt : InheritableAttr, TargetSpecificAttr { // MSP430Interrupt's, MipsInterrupt's and AnyX86Interrupt's spellings // must match. let Spellings = [GCC<"interrupt">]; - let Args = [EnumArgument<"Interrupt", "InterruptType", + let Args = [

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-10-11 Thread kleines Filmröllchen via cfe-commits
@@ -483,6 +483,56 @@ struct FragmentCompiler { FullyQualifiedNamespaces.begin(), FullyQualifiedNamespaces.end()); }); } +auto QuotedFilter = compileHeaderRegexes(F.QuotedHeaders); +if (QuotedFilter.has_value()) { + Out.Apply.push_back( +

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/68690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! Please be sure to add a release note to `clang/docs/ReleaseNotes.rst` so users know about the new functionality. https://github.com/llvm/llvm-project/pull/68690 ___ cfe-commits

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -7922,6 +7926,10 @@ void Clang::AddClangCLArgs(const ArgList &Args, types::ID InputType, CmdArgs.push_back("-fno-wchar"); } + if (Args.hasArg(options::OPT_fms_define_stdc)) { + CmdArgs.push_back("-fms-define-stdc"); + } AaronBallman wrote: ```sugges

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -123,6 +123,10 @@ // CHECK-CHAR8_T_: "-fno-char8_t" +// RUN: %clang_cl /dev/null /E -Xclang -dM 2> /dev/null | FileCheck -match-full-lines %s --check-prefix=STDCOFF +// RUN: %clang_cl /dev/null /E -Xclang -dM /Zc:__STDC__ 2> /dev/null | FileCheck -match-full-lines %s --c

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -2821,6 +2821,10 @@ def fms_compatibility : Flag<["-"], "fms-compatibility">, Group, Visibility<[ClangOption, CC1Option, CLOption]>, HelpText<"Enable full Microsoft Visual C++ compatibility">, MarshallingInfoFlag>; +def fms_define_stdc : Flag<["-"], "fms-define-stdc">

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -282,7 +282,7 @@ LANGOPT(HIPUseNewLaunchAPI, 1, 0, "Use new kernel launching API for HIP") LANGOPT(OffloadUniformBlock, 1, 0, "Assume that kernels are launched with uniform block sizes (default true for CUDA/HIP and false otherwise)") LANGOPT(HIPStdPar, 1, 0, "Enable Standa

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Renaud Kauffmann via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) Renaud-K wrote: Would it

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

2023-10-11 Thread Erich Keane via cfe-commits
@@ -274,20 +274,27 @@ class DefaultIntArgument : IntArgument { } // This argument is more complex, it includes the enumerator type name, -// a list of strings to accept, and a list of enumerators to map them to. -class EnumArgument values, +// a list of possible values, and a

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68820 >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH 1/2] Add support for -fcx-limited-range and #pragma CX_LIMTED_RAN

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread via cfe-commits
@@ -6171,6 +6171,11 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "conversion fr

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Tom Eccles via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) tblah wrote: So, if I un

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Tom Eccles via cfe-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/68727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] Add flags controlling whether to run the fir alias tags pass (PR #68595)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. LGTM, thank you for addressing my comments! https://github.com/llvm/llvm-project/pull/68595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] 52d0696 - [clang][dataflow] Add support for lambda captures (#68558)

2023-10-11 Thread via cfe-commits
Author: Stanislav Gatev Date: 2023-10-11T22:18:46+02:00 New Revision: 52d06963551938cfe9a2cf481608699cd988d824 URL: https://github.com/llvm/llvm-project/commit/52d06963551938cfe9a2cf481608699cd988d824 DIFF: https://github.com/llvm/llvm-project/commit/52d06963551938cfe9a2cf481608699cd988d824.dif

[clang] [clang][dataflow] Add support for lambda captures (PR #68558)

2023-10-11 Thread Stanislav Gatev via cfe-commits
https://github.com/sgatev closed https://github.com/llvm/llvm-project/pull/68558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   >