[clang-tools-extra] [clangd] Add tweak for turning an unscoped into a scoped enum (PR #67645)

https://github.com/ckandeler resolved https://github.com/llvm/llvm-project/pull/67645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add tweak for turning an unscoped into a scoped enum (PR #67645)

@@ -0,0 +1,222 @@ +//===--- ScopifyEnum.cpp --- -*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak for turning an unscoped into a scoped enum (PR #67645)

https://github.com/ckandeler resolved https://github.com/llvm/llvm-project/pull/67645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add tweak for turning an unscoped into a scoped enum (PR #67645)

@@ -0,0 +1,222 @@ +//===--- ScopifyEnum.cpp --- -*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] b406819 - [clang][Parser][NFC] Reformat if statement

Author: Timm Bäder Date: 2023-09-28T12:32:30+02:00 New Revision: b4068198327951f5298f9255c499a1d6c4cd6493 URL: https://github.com/llvm/llvm-project/commit/b4068198327951f5298f9255c499a1d6c4cd6493 DIFF: https://github.com/llvm/llvm-project/commit/b4068198327951f5298f9255c499a1d6c4cd6493.diff LO

[clang] 56a3574 - [clang][Parser][NFC] Fix a doc comment mishap

Author: Timm Bäder Date: 2023-09-28T12:32:30+02:00 New Revision: 56a35746debc172e36eb6eaf17c5dcf4927a425e URL: https://github.com/llvm/llvm-project/commit/56a35746debc172e36eb6eaf17c5dcf4927a425e DIFF: https://github.com/llvm/llvm-project/commit/56a35746debc172e36eb6eaf17c5dcf4927a425e.diff LO

[clang-tools-extra] [clangd] Add tweak for turning an unscoped into a scoped enum (PR #67645)

@@ -0,0 +1,222 @@ +//===--- ScopifyEnum.cpp --- -*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie updated this revision to Diff 557438. Discookie added a comment. Replaced backticks with single quotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158156/new/ https://reviews.llvm.org/D158156 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Ch

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie updated this revision to Diff 557439. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158156/new/ https://reviews.llvm.org/D158156 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Checkers/CMakeLists.tx

[clang-tools-extra] [clangd] Add tweak for turning an unscoped into a scoped enum (PR #67645)

https://github.com/ckandeler resolved https://github.com/llvm/llvm-project/pull/67645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

mbrkusanin added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + This is giving me a linker error: $ ninja unittests/IR/IRTests /usr/bin/ld: unittests/IR/CM

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie marked 5 inline comments as done. Discookie added a comment. Ran the checker on a couple larger projects, but no real-world reports found so far (same as DeleteWithNonVirtualDtor). Can't tell if it's an engine limitation or just the bug being uncommon in general. Co

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/67572 >From 2b6a23c71a41bc07e37b4bed2cfef8b790e84631 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 6 Sep 2023 13:39:27 +0200 Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/67572 >From 448999ecab28ea4d9768c1a8fa5fb4bb25e4bd32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 6 Sep 2023 13:39:27 +0200 Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan marked 3 inline comments as done. zyounan added a comment. Thank you guys again for the long and meticulous review! :) For a quick note, here are points I've excerpted from Nathan's reviews that need improvements later: 1. Implement a heuristic that works for function template pointers

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

skc7 wrote: > Yeah, `clang/test/CodeGen/memtag-globals-asm.cpp` is for MTE Globals, not > ASan - and the sizes of the GVs should be multiple-of-16 bytes: > https://github.com/ARM-software/abi-aa/blob/main/memtagabielf64/memtagabielf64.rst#compilation > > What problem are you trying to solve he

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557441. zyounan added a comment. Address nits; discard default template parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang/include/clang/Sema/S

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557442. zyounan added a comment. Sorry, wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-e

[clang] [C++20] [Modules] Don't generate call to an imported module that dont init anything (PR #67638)

https://github.com/iains approved this pull request. thanks, LGTM https://github.com/llvm/llvm-project/pull/67638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158156: [analyzer] Add C++ array delete checker

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It's good enough already, given you apply my last suggestion. References would be nice to support for notes, but not a blocker. Comment at: clang/lib/StaticAnalyzer/Check

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

hctim wrote: > > Yeah, `clang/test/CodeGen/memtag-globals-asm.cpp` is for MTE Globals, not > > ASan - and the sizes of the GVs should be multiple-of-16 bytes: > > https://github.com/ARM-software/abi-aa/blob/main/memtagabielf64/memtagabielf64.rst#compilation > > What problem are you trying to so

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

@@ -10,6 +10,7 @@ // //===--===// +#include "../Basic/Targets/NVPTX.h" sam-mccall wrote: @jchlanda ah, that's simpler than I expected! Wish I'd found that before reverting... That looks go

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

jp4a50 wrote: Thanks for the reviews! Can someone please merge for me? @HazardyKnusperkeks @owenca https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

https://github.com/gamesh411 created https://github.com/llvm/llvm-project/pull/67663 **This PR is a continuation of the Phabricator review https://reviews.llvm.org/D154603 ** The invalidation of pointer pointers returned by subsequent calls to genenv is suggested by the POSIX standard, but is

[clang] [clang][dataflow] Show triangle in `` element (PR #67655)

@@ -123,10 +123,21 @@ code.line:has(.bb-select):before { font-size: x-small; flex-grow: 1; } -.value summary { +.value > summary { background-color: #ace; display: flex; - justify-content: space-between; + cursor: pointer; +} +.value > summary::before { + content:

[clang] [clang][dataflow] Show triangle in `` element (PR #67655)

https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/67655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Show triangle in `` element (PR #67655)

https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/67655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/67663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang Changes **This PR is a continuation of the Phabricator review http

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx added a comment. @MaskRay do you think there's anything else that needs adjusting? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning:

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557443. zyounan added a comment. Fix the CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/cla

[clang] [clang][dataflow] Show triangle in `` element (PR #67655)

https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/67655 >From 24884a9d2c00547183eccde62248bf5e8f7f9463 Mon Sep 17 00:00:00 2001 From: martinboehme Date: Thu, 28 Sep 2023 10:55:02 +0200 Subject: [PATCH] [clang][dataflow] Show triangle in `` element. (#67431) Als

[clang] [clang][dataflow] Show triangle in `` element (PR #67655)

@@ -123,10 +123,21 @@ code.line:has(.bb-select):before { font-size: x-small; flex-grow: 1; } -.value summary { +.value > summary { background-color: #ace; display: flex; - justify-content: space-between; + cursor: pointer; +} +.value > summary::before { + content:

[clang] [clang][dataflow] Show triangle in `` element (PR #67655)

https://github.com/martinboehme resolved https://github.com/llvm/llvm-project/pull/67655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland [NVPTX] Add support for maxclusterrank in launch_bounds (#66496) (PR #67667)

https://github.com/jchlanda created https://github.com/llvm/llvm-project/pull/67667 This reverts commit 0afbcb20fd908f8bf9073697423da097be7db592. >From d8c1372998a74dfbfea921bf049575e5e9c0c5a7 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Thu, 28 Sep 2023 13:30:27 +0100 Subject: [PATCH] R

[clang] Reland [NVPTX] Add support for maxclusterrank in launch_bounds (#66496) (PR #67667)

jchlanda wrote: As discussed in: https://github.com/llvm/llvm-project/pull/66496#discussion_r134239 https://github.com/llvm/llvm-project/pull/67667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] Reland [NVPTX] Add support for maxclusterrank in launch_bounds (#66496) (PR #67667)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes This reverts commit 0afbcb20fd908f8bf9073697423da097be7db592. --- Patch is 26.22 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/67667.diff 15 Files Affected: - (modified) clang/includ

[clang] 53e3180 - [clang][dataflow] Show triangle in `` element (#67655)

Author: martinboehme Date: 2023-09-28T14:50:51+02:00 New Revision: 53e3180b6e02bbb3ccb99c9bbcc28efce691ee2f URL: https://github.com/llvm/llvm-project/commit/53e3180b6e02bbb3ccb99c9bbcc28efce691ee2f DIFF: https://github.com/llvm/llvm-project/commit/53e3180b6e02bbb3ccb99c9bbcc28efce691ee2f.diff

[clang] [clang][dataflow] Show triangle in `` element (PR #67655)

https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/67655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Only check RVV types is we have them (PR #67669)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/67669 isRVVType() is suprisingly expensive, so do the checks only if the target has rvv types. >From 847451fdf8c70b1deebdd4d4cf4ce3ce84845f5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 2

[clang] [clang][Sema] Only check RVV types is we have them (PR #67669)

llvmbot wrote: @llvm/pr-subscribers-clang Changes isRVVType() is suprisingly expensive, so do the checks only if the target has rvv types. --- Full diff: https://github.com/llvm/llvm-project/pull/67669.diff 1 Files Affected: - (modified) clang/lib/Sema/Sema.cpp (+1-1) ``diff

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

https://github.com/ldionne resolved https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

https://github.com/ldionne resolved https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

https://github.com/kaz7 created https://github.com/llvm/llvm-project/pull/67671 Add rpath for libc++ libraries in order to not specify rpath by user each time. Disable -frthlib-add-ppath by default for VE similar to other architectures. Update regression tests to check modifications. >From f

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes Add rpath for libc++ libraries in order to not specify rpath by user each time. Disable -frthlib-add-ppath by default for VE similar to other architectures. Update regression tests to check modifications. --- Full diff: https://g

[clang] [analyzer] Move alpha checker EnumCastOutOfRange to optin (PR #67157)

DonatNagyE wrote: Before merging this PR, the diagnostics of the EnumCast checker should be updated to mention the name of the `enum` type in question. @gamesh411 could you create a PR that implements this improvement (as we discussed)? https://github.com/llvm/llvm-project/pull/67157 _

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9bb9ec380ace81d040d3a0a0a2ae9a75733ab330 f50505a9eb1d86f029bf552cd846ccc8c6deb0e4 --

[clang] [HIP] Support compressing device binary (PR #67162)

yxsamliu wrote: ping A little background: some HIP applications face size restrictions for their packages. Compressing can significantly reduce the bundle size with acceptable overhead of uncompressing. Therefore they need this feature. https://github.com/llvm/llvm-project/pull/67162

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

https://github.com/kaz7 updated https://github.com/llvm/llvm-project/pull/67671 >From f50505a9eb1d86f029bf552cd846ccc8c6deb0e4 Mon Sep 17 00:00:00 2001 From: "Kazushi (Jam) Marukawa" Date: Thu, 28 Sep 2023 19:25:09 +0900 Subject: [PATCH 1/2] [Clang][VE] Correct rpath handling on VE Add rpath fo

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/67673 Functions with these attributes will be automatically called before main() or after main() exits gracefully. In glibc environments, the constructor function is passed the same arguments as main(), so that s

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

AaronBallman wrote: This is another pass at https://github.com/llvm/llvm-project/pull/67360 Note: llvm-libc will still have a test failure until I figure out the correct way to repair init_fini_array_test.cpp. I *think* I made the correct changes in compiler-rt's CMake so that all of the compi

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Functions with these attributes will be automatically called before main() or after main() exits gracefully. In glibc environments, the constructor function is passed the same arguments as main(), so that signature is allowed. In all othe

[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

syzaara added inline comments. Comment at: clang/include/clang/Driver/Options.td:2955 + MarshallingInfoFlag>; +def mno_tocdata_EQ : CommaJoined<["-"], "mno-tocdata=">, + Flags<[CC1Option,TargetSpecific]>, MaskRay wrote: > If `-mtocdata=` is opt-in, the conventi

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/Leporacanthicus created https://github.com/llvm/llvm-project/pull/67676 Support for vector scale range arguments, for AArch64 scalable vector extension (SVE) support. Adds -msve-vector-bits to the flang frontend, and for flang fc1 the options are -mvscale-min and -mvscale-m

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c51857b4e53031753d6b998ce0ef5f59c073aeb3 02565df450927fac88062f526a167c9beb518c2f --

[clang] [flang]Add vscale argument parsing (PR #67676)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Support for vector scale range arguments, for AArch64 scalable vector extension (SVE) support. Adds -msve-vector-bits to the flang frontend, and for flang fc1 the options are -mvscale-min and -mvscale-max (optional). These match the clang

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

This revision was automatically updated to reflect the committed changes. Closed by commit rG23ef8bf9c0f3: [clangd][CodeComplete] Improve FunctionCanBeCall (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://revi

[clang] 23ef8bf - [clangd][CodeComplete] Improve FunctionCanBeCall

Author: Younan Zhang Date: 2023-09-28T21:42:02+08:00 New Revision: 23ef8bf9c0f338ee073c6c1b553c42e46d2f22ad URL: https://github.com/llvm/llvm-project/commit/23ef8bf9c0f338ee073c6c1b553c42e46d2f22ad DIFF: https://github.com/llvm/llvm-project/commit/23ef8bf9c0f338ee073c6c1b553c42e46d2f22ad.diff

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

justincady added a comment. I suspect there's another unintended consequence of this change with regards to broken ODR violation detection. I filed an issue and am connecting it here should someone find this review first. Repository: rG LL

[clang] [flang]Add vscale argument parsing (PR #67676)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1b8fb1a6648aa8cebc05b3a060a4cdec07744245 25b53fa1d6d52e8f22dcdaaf5c7fbf47132e --

[clang] [LinkerWrapper] Correctly handle multiple image wrappers (PR #67679)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67679 Summary: We use these image wrappers to do runtime specifica registration of variables and to load the device image that was compiled. This was intended to support multiple of these running at the same time, e.g.

[clang-tools-extra] [clang-tidy]: Add TagDecl into LastTagDeclRanges in UseUsingCheck only when it is a definition (PR #67639)

jcsxky wrote: > Fix release notes, update change description (commit) to describe what was a > problem. Mainly why isThisDeclarationADefinition is needed. After that leave > it open for few days before pushing, so someone else could also look into > this and provide some comments if needed. O

[clang] [LinkerWrapper] Correctly handle multiple image wrappers (PR #67679)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Summary: We use these image wrappers to do runtime specifica registration of variables and to load the device image that was compiled. This was intended to support multiple of these running at the same time, e.g. you can have a CUDA instance

[clang] Reland [NVPTX] Add support for maxclusterrank in launch_bounds (#66496) (PR #67667)

https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/67667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix of possible crash "Did not find base!". (PR #67680)

https://github.com/balazske created https://github.com/llvm/llvm-project/pull/67680 A problem with AST import could lead to multiple instances of the same template class specialization, with different template arguments. The difference was caused by pointers to different declarations of the sa

[clang] [clang][ASTImporter] Fix of possible crash "Did not find base!". (PR #67680)

llvmbot wrote: @llvm/pr-subscribers-clang Changes A problem with AST import could lead to multiple instances of the same template class specialization, with different template arguments. The difference was caused by pointers to different declarations of the same function. Problem is fixed

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + mbrkusanin wrote: > This is giving me a linker error: > > $ ninja unittests/IR/IRTests > > /us

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -47,7 +47,11 @@ struct __libcpp_datasizeof { }; #endif phyBrackets wrote: Optional : Can you add a brief comment/note that why warnings are suppressed here? Mb something like : ``` // Disable warnings related to the use of `offsetof` on non-standard

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/66862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/erichkeane commented: Still OK with this, but Shafik should do the final approval. https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/67684 This option will cause -E to preserve the #include directives for system headers, rather than expanding them into the output. This can greatly reduce the volume of preprocessed source text in a test case, making t

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This option will cause -E to preserve the #include directives for system headers, rather than expanding them into the output. This can greatly reduce the volume of preprocessed source text in a test case, making test case reduction simpler.

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

b-sumner wrote: The reason this is a problem is that AMD language runtimes provide queries for the size of device global symbols, and functions to copy data to and from device global variables. This works fine when the ELF size reflects the actual size of the variable. But when it reflects t

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

AaronBallman wrote: > I _think_ I made the correct changes in compiler-rt's CMake so that all of > the compiler-rt projects can use reserved priorities, but I'd appreciate > confirmation from @MaskRay on those changes. Hmm, nope, it seems the test cases still fail (but the source files work).

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1b7285bf3ee73975fa63acfc5301a9b57a53fca2 a71131f734c90aeaff9c3fb0cdc57c0f81dd8971 --

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/67613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

https://github.com/erichkeane commented: >From what I can tell, this looks correct, though I don't know much about this >rewriter, I've only spent a little time reviewing it. That said, i think this >is a very nice improvement. One thing I might request (in addition to what I did in teh comme

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

@@ -332,12 +346,14 @@ void InclusionRewriter::CommentOutDirective(Lexer &DirectiveLex, // OutputContentUpTo() would not output anything anyway. return; } - OS << "#if 0 /* expanded by -frewrite-includes */" << MainEOL; + OS << "#if 0 /* " << getIncludedFileName(Inc

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67673 >From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 28 Sep 2023 09:20:12 -0400 Subject: [PATCH 1/2] Diagnose problematic uses of constructor/destructor att

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67673 >From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 28 Sep 2023 09:20:12 -0400 Subject: [PATCH 1/3] Diagnose problematic uses of constructor/destructor att

[clang-tools-extra] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67514 >From e2e0e10e13748ba9369b73c7547c035ee75dfffa Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Tue, 26 Sep 2023 18:55:44 -0700 Subject: [PATCH] [Clang] Fix crash when visting a fold expression in a default a

[libunwind] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67514 >From e2e0e10e13748ba9369b73c7547c035ee75dfffa Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Tue, 26 Sep 2023 18:55:44 -0700 Subject: [PATCH] [Clang] Fix crash when visting a fold expression in a default a

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

mbrkusanin added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + Prabhuk wrote: > mbrkusanin wrote: > > This is giving me a linker error: > > > > $ ninja unittest

[clang] fb2bdbb - [CodeGen] Avoid use of ConstantExpr::getZExt() (NFC)

Author: Nikita Popov Date: 2023-09-28T16:45:31+02:00 New Revision: fb2bdbb83d3913d9d32b28c1de3f3d8b4e6dfc8a URL: https://github.com/llvm/llvm-project/commit/fb2bdbb83d3913d9d32b28c1de3f3d8b4e6dfc8a DIFF: https://github.com/llvm/llvm-project/commit/fb2bdbb83d3913d9d32b28c1de3f3d8b4e6dfc8a.diff

[clang] cc24455 - [libc] Fix wrapper headers for some ctype macros and C++ decls

Author: Joseph Huber Date: 2023-09-28T10:00:34-05:00 New Revision: cc2445589d75c737ddf636ec1f1008b34939bfb7 URL: https://github.com/llvm/llvm-project/commit/cc2445589d75c737ddf636ec1f1008b34939bfb7 DIFF: https://github.com/llvm/llvm-project/commit/cc2445589d75c737ddf636ec1f1008b34939bfb7.diff

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/67691 Since 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 the recommended way to pass an executor is to use the _TEST_PARAMS variable, which means we now pass more complicated value (including ones that may contain mul

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

arichardson wrote: @vvereschaka I tested this locally by adding a parameter with quotes to my CMake invocation, so it should hopefully work. Could you please test if this fixes the builder? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-comm

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

arichardson wrote: @vvereschaka I tested this locally by adding a parameter with quotes to my CMake invocation, so it should hopefully work. Could you please test if this fixes the builder? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-comm

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

llvmbot wrote: @llvm/pr-subscribers-libcxxabi Changes Since 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 the recommended way to pass an executor is to use the _TEST_PARAMS variable, which means we now pass more complicated value (including ones that may contain multiple `=`) as part of this

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

@@ -234,6 +236,26 @@ class CGOpenMPTaskOutlinedRegionInfo final : public CGOpenMPRegionInfo { const UntiedTaskActionTy &Action; }; +/// API for captured statement code generation in OpenMP taskgraphs. +class CGOpenMPTaskgraphRegionInfo final : public CGOpenMPRegionInfo { +p

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

llvmbot wrote: @llvm/pr-subscribers-libcxxabi Changes Since 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 the recommended way to pass an executor is to use the _TEST_PARAMS variable, which means we now pass more complicated value (including ones that may contain multiple `=`) as part of this

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67673 >From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 28 Sep 2023 09:20:12 -0400 Subject: [PATCH 1/4] Diagnose problematic uses of constructor/destructor att

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/67663 __

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: https://github.com/DonatNagyE commented: This PR contains several useful improvements and the implementation seems

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -2399,13 +2399,34 @@ pointer. These functions include: getenv, localeconv, asctime, setlocale,

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -2399,13 +2399,34 @@ pointer. These functions include: getenv, localeconv, asctime, setlocale,

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -25,19 +25,36 @@ using namespace clang; using namespace ento; + namespace { + class Inva

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -1,15 +1,49 @@ +// Default options. // RUN: %clang_analyze_cc1

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -94,23 +119,40 @@ REGISTER_MAP_WITH_PROGRAMSTATE(PreviousCallResultMap, const FunctionDecl *,

<    1   2   3   4   5   >