[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-21 Thread via cfe-commits
cor3ntin wrote: @philnik777 may be able to help https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

2023-09-21 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Herald added a project: All. @rnk can we close this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763 ___ cfe-commits mailing list cfe-co

[PATCH] D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Is this relevant anymore or should we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37004/new/ https://reviews.llvm.org/D37004 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D37192: [clang-format] Add support for generic Obj-C categories

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added subscribers: Eugene.Zelenko, rjmccall, shafik. shafik added a comment. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. @rjmccall @Eugene.Zelenko this looks like it might still be relevant. CHANGES SINCE LA

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: One of the remaining tests fails because `PP->getIdentifierInfo()` ends up doing external lookup via `ASTReader`, which ends up emitting a diagnostic its

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik closed this revision. shafik added a comment. Herald added a project: All. It looks like these changes are already landed so closing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37196/new/ https://reviews.llvm.org/D37196 ___ cfe-commi

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-21 Thread John McCall via cfe-commits
@@ -4869,6 +4869,73 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__iso_volatile_store64: return RValue::get(EmitISOVolatileStore(*this, E)); + case Builtin::BI__builtin_ptrauth_auth: + case Builtin::BI__builtin_pt

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Is this PR still relevant or can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19201/new/ https://reviews.llvm.org/D19201 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-21 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-21 Thread John McCall via cfe-commits
@@ -0,0 +1,167 @@ +/*=== ptrauth.h - Pointer authentication ---=== + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Apac

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-21 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41130: git-clang-format: cleanup: Use run() when possible.

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Is this still relevant or can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41130/new/ https://reviews.llvm.org/D41130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Artem Belevich via cfe-commits
@@ -11836,6 +11836,10 @@ def err_sycl_special_type_num_init_method : Error< "types with 'sycl_special_class' attribute must have one and only one '__init' " "method defined">; +def warn_cuda_maxclusterrank_sm_90 : Warning< + "maxclusterrank requires sm_90 or higher, CUDA

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Artem Belevich via cfe-commits
@@ -5650,34 +5665,51 @@ static Expr *makeLaunchBoundsArgExpr(Sema &S, Expr *E, CUDALaunchBoundsAttr * Sema::CreateLaunchBoundsAttr(const AttributeCommonInfo &CI, Expr *MaxThreads, - Expr *MinBlocks) { - CUDALaunchBoundsAttr TmpAttr(Context, CI, Max

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -triple nvptx-unknown-unknown -target-cpu sm_90 -verify %s + +#include "Inputs/cuda.h" + +__launch_bounds__(128, 7) void Test2Args(void); +__launch_bounds__(128) void Test1Arg(void); + +__launch_bounds__(0x) v

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Artem Belevich via cfe-commits
@@ -5607,6 +5607,21 @@ bool Sema::CheckRegparmAttr(const ParsedAttr &AL, unsigned &numParams) { return false; } +// Helper to get CudaArch. +static CudaArch getCudaArch(const TargetInfo &TI) { Artem-B wrote: Considering that we do have TargetInfo pointer h

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Artem Belevich via cfe-commits
@@ -12,7 +12,7 @@ __launch_bounds__(0x1) void TestWayTooBigArg(void); // expected- __launch_bounds__(-128, 7) void TestNegArg1(void); // expected-warning {{'launch_bounds' attribute parameter 0 is negative and will be ignored}} __launch_bounds__(128, -7) void T

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Artem Belevich via cfe-commits
@@ -537,59 +537,46 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function &F, raw_ostream &O) const { // If the NVVM IR has some of reqntid* specified, then output // the reqntid directive, and set the unspec

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

2023-09-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk closed this revision. rnk added a subscriber: MaskRay. rnk added a comment. Closing, we left the test alone, it still uses `-fuse-ld=lld-link2`. Perhaps in the future we should reconsider this, but that's how things stand now, and we aren't going to land this patch as is. + @MaskRay , who ha

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

2023-09-21 Thread Dmitriy Smirnov via Phabricator via cfe-commits
d-smirnov updated this revision to Diff 557187. d-smirnov added a comment. comment updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp l

[PATCH] D41145: git-clang-format: refactor to support upcoming --staged flag

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: wangpc. Herald added a project: All. Is this still relevant or can we close this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41145/new/ https://reviews.llvm.org/D41145 ___ cfe-commits mail

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-21 Thread Ben Langmuir via cfe-commits
@@ -524,13 +524,7 @@ enum ASTRecordTypes { /// of source-location information. SOURCE_LOCATION_OFFSETS = 14, - /// Record code for the set of source location entries - /// that need to be preloaded by the AST reader. - /// - /// This set contains the source location en

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-21 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir commented: > in my experience, it's not actually referenced in most modules Can you clarify what you looked at here? I assume you checked non-scanner modules as well? https://github.com/llvm/llvm-project/pull/66962 ___

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-21 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir edited https://github.com/llvm/llvm-project/pull/66962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: wangpc. Herald added a project: All. Is this still relevant? It looks like some of these changes made it in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23130/new/ https://reviews.llvm.org/D23130 _

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

2023-09-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > So this is truly a test of the ld.otherlinker feature pattern, not some > special case driver feature. I guess we should leave the test alone. > Closing, we left the test alone, it still uses -fuse-ld=lld-link2. Perhaps in > the future we should reconsider this, but th

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/66951 >From a956ea32c145d84ee771c985ceb3becbd03f4022 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Wed, 20 Sep 2023 13:42:20 -0700 Subject: [PATCH 1/3] [clang-format] Don't split "DPI"/"DPI-C" in imports The sp

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/66951 >From a956ea32c145d84ee771c985ceb3becbd03f4022 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Wed, 20 Sep 2023 13:42:20 -0700 Subject: [PATCH 1/4] [clang-format] Don't split "DPI"/"DPI-C" in imports The sp

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Arthur Eubanks via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/5] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/5] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/6] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/6] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/7] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/7] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: I wanted to make some minor naming suggestions, and I used the GitHub "edit this file" feature for the first time to commit them as new commits to your branch. I've never done this before, so I don't really know how it works, but clang-format isn't available,

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-21 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-21 Thread Balint Cristian via cfe-commits
cbalint13 wrote: @DavidSpickett , > Looks good to me, thanks for working on this. Thank you very much for the time ! > I'm not sure if you'll have permissions to click the merge button but if you > do, go ahead. * No, don't, I am outside contributor. >Please remember to edit the final com

[PATCH] D37192: [clang-format] Add support for generic Obj-C categories

2023-09-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Is that really the way we want to recommend formatting that, with the generics clause separated from the class name but not separated from the category clause? I'd expect the opposite: write the generics clause with no separation after the class name but with separati

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/66702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/66702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Fangrui Song via cfe-commits
@@ -50,3 +50,15 @@ ! MSVC-SAME: FortranDecimal.lib ! MSVC-SAME: /subsystem:console ! MSVC-SAME: "[[object_file]]" + +! Verify that certain linker flags are known to the frontend and are passed on +! to the linker. + +! RUN: %flang -### -rpath /path/to/dir -shared -static %s 2>&

[clang] e0388e0 - [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (#66951)

2023-09-21 Thread via cfe-commits
Author: Arthur Eubanks Date: 2023-09-21T11:21:20-07:00 New Revision: e0388e0e061d2499aa654c28a3c4a5a27f7d7a28 URL: https://github.com/llvm/llvm-project/commit/e0388e0e061d2499aa654c28a3c4a5a27f7d7a28 DIFF: https://github.com/llvm/llvm-project/commit/e0388e0e061d2499aa654c28a3c4a5a27f7d7a28.diff

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-21 Thread wael yehia via Phabricator via cfe-commits
w2yehia added a comment. Please update InstrProfilingPlatformAIX.c as well, specifically add new dummy vars for the new section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846 __

[PATCH] D156711: [clang][ExprConstant] Fix assertion failure in constant expression folding

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. It looks like I fixed this in: https://reviews.llvm.org/D158557 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156711/new/ https://reviews.llvm.org/D156711 ___ cfe-commits mailing

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/66702 >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 18 Sep 2023 15:18:24 -0600 Subject: [PATCH 1/3] [flang][Driver] Support -rpath, -shared, and -static in t

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Is this change still relevant of can we close this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45234/new/ https://reviews.llvm.org/D45234 ___ cfe-commits mailing

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes updated https://github.com/llvm/llvm-project/pull/66706 >From 6312dd56ed3a2f47e7291ae32ca044622a317259 Mon Sep 17 00:00:00 2001 From: Bruno Cardoso Lopes Date: Wed, 20 Sep 2023 15:00:06 -0700 Subject: [PATCH 1/2] [Clang][LLVM][Coroutines] Prevent __coro_gro from

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -6691,6 +6691,22 @@ sections that the user does not want removed after linking. ... !0 = !{} +'``coro.outside.frame``' Metadata +^^ + +``coro.outside.frame`` metadata may be attached to an alloca instruction to +to signify that it shouldn't be promo

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes resolved https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -104,3 +105,5 @@ invoker g() { // CHECK: call void @_ZN7invoker15invoker_promise17get_return_objectEv({{.*}} %[[AggRes]] co_return; } + +// CHECK: ![[OutFrameMetadata]] = !{} bcardosolopes wrote: Done https://github.com/llvm/llvm-project/pull/66706 __

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes resolved https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-21 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: Applied suggested changes and updated PR. https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-21 Thread Sunho Kim via cfe-commits
https://github.com/sunho created https://github.com/llvm/llvm-project/pull/67050 None >From 9d759677e725c244a7a3eb06864d6474253b6d86 Mon Sep 17 00:00:00 2001 From: Sunho Kim Date: Mon, 21 Aug 2023 15:48:26 +0900 Subject: [PATCH 1/4] [ORC] Introduce RedirectionManager interface and implementati

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: steven.zhang. Herald added a project: All. @hubert.reinterpretcast is this still relevant? It looks like portions of this have landed, can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18360/new/ https://reviews.llvm.org/D

[PATCH] D61309: [clang] Add no-warn support for Wa

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik closed this revision. shafik added a comment. Herald added subscribers: ormris, MaskRay. Herald added a project: All. Closing since these changes looks like they have landed already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61309/new/ h

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/8] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/8] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > I wanted to make some minor naming suggestions, and I used the GitHub "edit > this file" feature for the first time to commit them as new commits to your > branch. I've never done this before, so I don't really know how it works, but > clang-format isn't available, so now I'v

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > I wanted to make some minor naming suggestions, and I used the GitHub "edit > this file" feature for the first time to commit them as new commits to your > branch. I've never done this before, so I don't really know how it works, but > clang-format isn't available, so now I'v

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/2] [NFC][CodeGen] Create method to clear registers Place the

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/2] [NFC][CodeGen] Create method to clear registers Place the

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik closed this revision. shafik added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. Closing as it look like this is now `modernize-make-unique` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. https://github.com/llvm/llvm-project/pull/66702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

2023-09-21 Thread Stephen Crane via Phabricator via cfe-commits
rinon abandoned this revision. rinon added a comment. Looks like this was effectively implemented in c4d75361 , so this change is no longer necessary. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D7842: Make clang-format-diff compatible with Python 3.4

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik closed this revision. shafik added a comment. Herald added a project: All. Closing this does not look relevant anymore CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7842/new/ https://reviews.llvm.org/D7842 ___ cfe-commits mailing list

[PATCH] D61663: [clang-format] Fix a JavaScript import order bug.

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. @MyDeveloperDay this looks like it still could be relevant. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61663/new/ https://reviews.

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @rnk can we close this PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69766/new/ https://reviews.llvm.org/D69766 __

[PATCH] D75047: Add Control Flow Guard in Clang release notes.

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik closed this revision. shafik added a comment. Herald added a project: All. Closing since this was landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75047/new/ https://reviews.llvm.org/D75047 __

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-09-21 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. Friendly Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. It looks like this is almost there, can we get it over the line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113838/new/ https://reviews.llvm.org/D113838 __

[clang] 33f6161 - [-Wunsafe-buffer-usage] Group parameter fix-its

2023-09-21 Thread Ziqing Luo via cfe-commits
Author: Ziqing Luo Date: 2023-09-21T12:45:30-07:00 New Revision: 33f6161d9eaaa7c5a01ee8e50dec440d3052d34a URL: https://github.com/llvm/llvm-project/commit/33f6161d9eaaa7c5a01ee8e50dec440d3052d34a DIFF: https://github.com/llvm/llvm-project/commit/33f6161d9eaaa7c5a01ee8e50dec440d3052d34a.diff LO

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

2023-09-21 Thread Ziqing Luo via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33f6161d9eaa: [-Wunsafe-buffer-usage] Group parameter fix-its (authored by ziqingluo-90). Changed prior to commit: https://reviews.llvm.org/D15305

[PATCH] D99466: Fix PR48889: assertion failure for void() in flattened ternary expression

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. This is accepted but it looks like we need the previous `void{}` fix in order to land this. It would be nice to get both in before phab is not usable anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/66702 >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 18 Sep 2023 15:18:24 -0600 Subject: [PATCH 1/4] [flang][Driver] Support -rpath, -shared, and -static in t

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: Thanks @MaskRay and @banach-space for taking a look at this. I have marked the test as unsupported on windows because of a failing buildkite. I don't have access to a Windows machine so I can't add an equivalent test for that platform. https://github.com/llvm/llvm-project/pu

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu resolved https://github.com/llvm/llvm-project/pull/66702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu resolved https://github.com/llvm/llvm-project/pull/66702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread via cfe-commits
https://github.com/DaMatrix updated https://github.com/llvm/llvm-project/pull/66894 >From 99d894e132468a7008e89aaab4847e16b4743bc7 Mon Sep 17 00:00:00 2001 From: DaPorkchop_ Date: Sun, 13 Aug 2023 22:39:12 +0200 Subject: [PATCH] [clang] Implement constexpr bit_cast for vectors --- clang/lib/A

[clang] c4a3157 - Add mangling for type trait expressions.

2023-09-21 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2023-09-21T12:58:32-07:00 New Revision: c4a3157d6622928b3773695159d8039cdea140e3 URL: https://github.com/llvm/llvm-project/commit/c4a3157d6622928b3773695159d8039cdea140e3 DIFF: https://github.com/llvm/llvm-project/commit/c4a3157d6622928b3773695159d8039cdea140e3.diff

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-21 Thread Anatoly Trosinenko via cfe-commits
@@ -4869,6 +4869,73 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__iso_volatile_store64: return RValue::get(EmitISOVolatileStore(*this, E)); + case Builtin::BI__builtin_ptrauth_auth: + case Builtin::BI__builtin_pt

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

2023-09-21 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for reviving this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 __

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread via cfe-commits
https://github.com/DaMatrix updated https://github.com/llvm/llvm-project/pull/66894 >From cb7e616dacc1afcdf3357a4a95278479a234be6d Mon Sep 17 00:00:00 2001 From: DaPorkchop_ Date: Sun, 13 Aug 2023 22:39:12 +0200 Subject: [PATCH] [clang] Implement constexpr bit_cast for vectors --- clang/lib/A

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread via cfe-commits
@@ -7095,6 +7096,21 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); + +CharUnits ElemWidth = Info.Ctx.getTypeSizeInChars(VT->getElementType()); +unsign

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) {

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) {

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-21 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > > in my experience, it's not actually referenced in most modules > > Can you clarify what you looked at here? I assume you checked non-scanner > modules as well? I took a typical Xcode project and chose one TU that happens to transitively depend on 37 modules. I built it

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread via cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) {

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-21 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. LGTM other than my nit about the comment https://github.com/llvm/llvm-project/pull/66962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread via cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) {

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

2023-09-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk closed this revision. rnk added a comment. Let's close it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69766/new/ https://reviews.llvm.org/D69766 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
@@ -7095,6 +7096,45 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) {

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-09-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D148381#4649683 , @void wrote: > Friendly Ping. Aaron is away at a conference this week, so hopefully he'll do another pass when he gets back next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-21 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6bcef54 - Ensure we disambiguate NTTP names when doing TemplateTree comparisons

2023-09-21 Thread via cfe-commits
Author: erichkeane Date: 2023-09-21T13:28:04-07:00 New Revision: 6bcef543e3a31da26b0164ba4ed6e79e8f0a72c3 URL: https://github.com/llvm/llvm-project/commit/6bcef543e3a31da26b0164ba4ed6e79e8f0a72c3 DIFF: https://github.com/llvm/llvm-project/commit/6bcef543e3a31da26b0164ba4ed6e79e8f0a72c3.diff LO

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/3] [NFC][CodeGen] Create method to clear registers Place the

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/3] [NFC][CodeGen] Create method to clear registers Place the

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >