[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-21 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. I just noticed this also broke some lit tests on mac: https://bugs.chromium.org/p/chromium/issues/detail?id=1485487#c0 That's also visible on greendragon: https://green.lab.llvm.org/green/view/Clang/job/clang-stage1-RA/35721/testReport/ Repository: rG LLVM Github Monore

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From f85c72686613389671667ddd4997bec696f81c77 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

2023-09-21 Thread Sheng via Phabricator via cfe-commits
0x59616e added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5c92faeea71ae72725010c256a3e29aa3a7bcfca Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,84 @@ +//===- llvm/unittest/ADT/PagedVectorTest.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] 4af62db - [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (#66954)

2023-09-21 Thread via cfe-commits
Author: Takuya Shimizu Date: 2023-09-21T21:27:38+09:00 New Revision: 4af62db053413ea0b01e59adbd51677c5665328b URL: https://github.com/llvm/llvm-project/commit/4af62db053413ea0b01e59adbd51677c5665328b DIFF: https://github.com/llvm/llvm-project/commit/4af62db053413ea0b01e59adbd51677c5665328b.diff

[clang] [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (PR #66954)

2023-09-21 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/66954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-21 Thread Sam McCall via cfe-commits
@@ -88,10 +88,12 @@ class ModelDumper { void dump(Value &V) { JOS.attribute("value_id", llvm::to_string(&V)); -if (!Visited.insert(&V).second) - return; - JOS.attribute("kind", debugString(V.getKind())); +if (!Visited.insert(&V).second) { + JOS.att

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-21 Thread Sam McCall via cfe-commits
@@ -123,13 +125,16 @@ class ModelDumper { } void dump(const StorageLocation &L) { JOS.attribute("location", llvm::to_string(&L)); -if (!Visited.insert(&L).second) - return; - JOS.attribute("type", L.getType().getAsString()); if (auto *V = Env.getValue

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-21 Thread Sam McCall via cfe-commits
@@ -88,10 +88,12 @@ class ModelDumper { void dump(Value &V) { JOS.attribute("value_id", llvm::to_string(&V)); -if (!Visited.insert(&V).second) - return; - JOS.attribute("kind", debugString(V.getKind())); +if (!Visited.insert(&V).second) { --

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From da6f21f1d69814082cfcc0272c62445004276b07 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH] [analyzer] Add std::variant checker Adding a checker that checks fo

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
https://github.com/gchatelet updated https://github.com/llvm/llvm-project/pull/66504 >From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001 From: Guillaume Chatelet Date: Fri, 15 Sep 2023 12:34:17 + Subject: [PATCH 1/5] [clang-tidy] Update llvmlibc-implementation-in-namespa

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
@@ -3,18 +3,18 @@ #define MACRO_A "defining macros outside namespace is valid" class ClassB; -// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared within the '__llvm_libc' namespace +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check( return; gchatelet wrote: Done https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [analyzer] Remove inaccurate legacy handling of bad bitwise shifts (PR #66647)

2023-09-21 Thread Balazs Benics via cfe-commits
steakhal wrote: I think I'm fine with the numbers. Note that I could not inspect individual reports because the URL likely refers to some internal server on your side. Anyway, I'd recommend keeping the test files for two reasons: - It's probably not a big deal, we are talking about ~150 lines

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-21 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
gchatelet wrote: > As a single small change to make hardcoded namespaces configurable looks > fine. I added some comments related to overall issues in this check. Fell > free to fix them or ignore them. Thx for the review! I had to restructure the code a bit to accommodate for anonymous names

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-21 Thread Balazs Benics via cfe-commits
steakhal wrote: @DonatNagyE Any news on this? https://github.com/llvm/llvm-project/pull/66358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-21 Thread David Spickett via cfe-commits
DavidSpickett wrote: Looks good to me, thanks for working on this. I'm not sure if you'll have permissions to click the merge button but if you do, go ahead. Please remember to edit the final commit message to remove the links to the output files. https://github.com/llvm/llvm-project/pull/667

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

2023-09-21 Thread via cfe-commits
@@ -2445,6 +2445,11 @@ bool ModuleAddressSanitizer::InstrumentGlobals(IRBuilder<> &IRB, Module &M, // zero so we can copy the metadata over as is. NewGlobal->copyMetadata(G, 0); +// Set sanitizer metadata for newly created global, +// if it doesn't have it. --

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
@@ -307,6 +307,14 @@ void CodeGenModule::handleCUDALaunchBoundsAttr( NVPTXTargetCodeGenInfo::addNVVMMetadata(F, "minctasm", MinBlocks.getExtValue()); } + if (Attr->getMaxBlocks()) { +llvm::APSInt MaxBlocks(32); +Max

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
@@ -5662,22 +5677,39 @@ Sema::CreateLaunchBoundsAttr(const AttributeCommonInfo &CI, Expr *MaxThreads, return nullptr; } + if (MaxBlocks) { +// Feature '.maxclusterrank' requires .target sm_90 or higher. +auto SM = getCudaArch(Context.getTargetInfo()); +if

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda updated https://github.com/llvm/llvm-project/pull/66496 >From 9c8caed3c8def15ccdbfdf831f36d0befed1fc84 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Fri, 15 Sep 2023 12:08:04 +0100 Subject: [PATCH 1/2] [NVPTX] Add support for maxclusterrank in launch_bounds Sin

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
@@ -537,59 +537,52 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function &F, raw_ostream &O) const { // If the NVVM IR has some of reqntid* specified, then output // the reqntid directive, and set the unspec

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda updated https://github.com/llvm/llvm-project/pull/66496 >From 9c8caed3c8def15ccdbfdf831f36d0befed1fc84 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Fri, 15 Sep 2023 12:08:04 +0100 Subject: [PATCH 1/3] [NVPTX] Add support for maxclusterrank in launch_bounds Sin

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [LIBCLC] Teach prepare-builtins how to handle text based IR (PR #66993)

2023-09-21 Thread Jakub Chlanda via cfe-commits
@@ -5,30 +5,37 @@ #include "llvm/Bitcode/ReaderWriter.h" #endif +#include "llvm/Config/llvm-config.h" #include "llvm/IR/Function.h" #include "llvm/IR/GlobalVariable.h" #include "llvm/IR/LLVMContext.h" #include "llvm/IR/Module.h" +#include "llvm/IRReader/IRReader.h" #inclu

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-21 Thread Alexey Bataev via cfe-commits
@@ -2729,6 +2729,55 @@ class OMPTaskwaitDirective : public OMPExecutableDirective { } }; +/// This represents '#pragma ompx taskgraph' directive. +/// Available with OMPX extensions. +/// +/// \code +/// #pragma ompx taskgraph +/// \endcode +/// +class OMPTaskgraphDirective

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
@@ -18,32 +18,32 @@ const static StringRef RequiredNamespaceStart = "__llvm_libc"; const static StringRef RequiredNamespaceMacroName = "LIBC_NAMESPACE"; void ImplementationInNamespaceCheck::registerMatchers(MatchFinder *Finder) { - Finder->addMatcher( - decl(hasParent(t

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
@@ -18,32 +18,32 @@ const static StringRef RequiredNamespaceStart = "__llvm_libc"; const static StringRef RequiredNamespaceMacroName = "LIBC_NAMESPACE"; void ImplementationInNamespaceCheck::registerMatchers(MatchFinder *Finder) { - Finder->addMatcher( - decl(hasParent(t

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-09-21 Thread Krystian Stasiowski via cfe-commits
@@ -1016,21 +1003,20 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) { } case FunctionDecl::TK_DependentFunctionTemplateSpecialization: { // Templates. -UnresolvedSet<8> TemplDecls; -unsigned NumTemplates = Record.readInt(); -while (NumTemplates-

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-09-21 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer updated https://github.com/llvm/llvm-project/pull/66632 >From 18f494a4006b4c21b364a91107d4a07ceaf88213 Mon Sep 17 00:00:00 2001 From: Stephen Tozer Date: Mon, 18 Sep 2023 09:59:11 +0100 Subject: [PATCH 1/2] [LLVM] Add new attribute `optdebug` to optimize for debuggin

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

2023-09-21 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

2023-09-21 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-21 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65918 >From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 11 Sep 2023 09:15:41 +0800 Subject: [PATCH 1/5] [Sema] add cast from IncompleteArrayType to ConstantArray

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-21 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65918 >From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 11 Sep 2023 09:15:41 +0800 Subject: [PATCH 1/5] [Sema] add cast from IncompleteArrayType to ConstantArray

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
https://github.com/gchatelet updated https://github.com/llvm/llvm-project/pull/66504 >From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001 From: Guillaume Chatelet Date: Fri, 15 Sep 2023 12:34:17 + Subject: [PATCH 1/6] [clang-tidy] Update llvmlibc-implementation-in-namespa

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
@@ -18,32 +18,32 @@ const static StringRef RequiredNamespaceStart = "__llvm_libc"; const static StringRef RequiredNamespaceMacroName = "LIBC_NAMESPACE"; void ImplementationInNamespaceCheck::registerMatchers(MatchFinder *Finder) { - Finder->addMatcher( - decl(hasParent(t

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/66702 >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 18 Sep 2023 15:18:24 -0600 Subject: [PATCH 1/2] [flang][Driver] Support -rpath, -shared, and -static in t

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-21 Thread Tarun Prabhu via cfe-commits
@@ -50,3 +50,19 @@ ! MSVC-SAME: FortranDecimal.lib ! MSVC-SAME: /subsystem:console ! MSVC-SAME: "[[object_file]]" + +! Verify that certain linker flags are known to the frontend and are passed on +! to the linker. + +! RUN: %flang -### -rpath /path/to/dir %s 2>&1 \

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Remove inaccurate legacy handling of bad bitwise shifts (PR #66647)

2023-09-21 Thread via cfe-commits
DonatNagyE wrote: Sorry for the inaccessible reports, I forgot to specify that the results should go to the server that we use for open-source reviews. I'd like to skip the conversion of the testcases that I deleted, because there won't be folks "wondering what happened with these reports": In

[clang] [Serialization] Do less redundant work computing affecting module maps (PR #66933)

2023-09-21 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/66933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-21 Thread via cfe-commits
https://github.com/DonatNagyE approved this pull request. Hmm, let's just merge this. My only concern was that I felt that running a tainted executable is significantly more problematic than passing tainted command-line arguments to a trusted executable, but you're right that even a tainted co

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for inline asm (PR #67018)

2023-09-21 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD created https://github.com/llvm/llvm-project/pull/67018 This commit fixes compilation issue for RVV tuple types as OutputOperand for inline asm. The LLVM IR generated by the test case added is currently not handled successfully in the backend, which also needs a fix too

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for inline asm (PR #67018)

2023-09-21 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD updated https://github.com/llvm/llvm-project/pull/67018 >From 565785dd4938355c738a792676f8c4b1f9684329 Mon Sep 17 00:00:00 2001 From: eopXD Date: Thu, 21 Sep 2023 06:34:57 -0700 Subject: [PATCH] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for inline

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for inline asm (PR #67018)

2023-09-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes This commit fixes compilation issue for RVV tuple types as OutputOperand for inline asm. The LLVM IR generated by the test case added is currently not handled successfully in the backend, which also needs a fix too. --- Full diff:

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread via cfe-commits
https://github.com/sstwcw edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 0585b814aa7cda8f6908d198b1d7f4d300c85951 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for inline asm (PR #67018)

2023-09-21 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD edited https://github.com/llvm/llvm-project/pull/67018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From f21af0d0dccdc23eebe3b4c3b13c072b9398cc18 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

2023-09-21 Thread via cfe-commits
@@ -2445,6 +2445,11 @@ bool ModuleAddressSanitizer::InstrumentGlobals(IRBuilder<> &IRB, Module &M, // zero so we can copy the metadata over as is. NewGlobal->copyMetadata(G, 0); +// Set sanitizer metadata for newly created global, +// if it doesn't have it. --

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

2023-09-21 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added a comment. @codemzs, I'm sorry for the very long delay following up on this review. I've been struggling to keep up, but expect to be able to devote some time to this next week. I'm committed to helping to ensure we land this before Phabricator stops accepting new diffs (propo

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 774116b - [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (#66504)

2023-09-21 Thread via cfe-commits
Author: Guillaume Chatelet Date: 2023-09-21T17:05:47+02:00 New Revision: 774116b8f669a5a1fc12aaef6ebb408a5f064172 URL: https://github.com/llvm/llvm-project/commit/774116b8f669a5a1fc12aaef6ebb408a5f064172 DIFF: https://github.com/llvm/llvm-project/commit/774116b8f669a5a1fc12aaef6ebb408a5f064172.

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
https://github.com/gchatelet closed https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. Is this PR still relevant or should it just be closed? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24439/new/ https://reviews.llvm.org/D24439 ___

[PATCH] D11235: clang-format: Fix breaking before nested 'operator' in function declarations

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. @Eugene.Zelenko it this still relevant or should this be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11235/new/ https://reviews.llvm.org/D11235 ___ cfe-commits mailing list cfe-co

[clang-tools-extra] [SelectionDAG] Flags are dropped when creating a new FMUL (PR #66701)

2023-09-21 Thread Sirish Pande via cfe-commits
https://github.com/srpande closed https://github.com/llvm/llvm-project/pull/66701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SelectionDAG] Flags are dropped when creating a new FMUL (PR #66701)

2023-09-21 Thread Sirish Pande via cfe-commits
https://github.com/srpande closed https://github.com/llvm/llvm-project/pull/66701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Should we close this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23602/new/ https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
https://github.com/DonatNagyE commented: Yet another round of review, with even less significant remarks :) https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,104 @@ +//===- TaggedUnionModeling.h -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,349 @@ +// RUN: %clang %s -std=c++17 -Xclang -verify --analyze \ +// RUN: -Xclang -analyzer-checker=core \ +// RUN: -Xclang -analyzer-checker=debug.ExprInspection \ +// RUN: -Xclang -analyzer-checker=core,alpha.core.StdVariant + +#include "Inputs/system-header-sim

[PATCH] D19385: [scan-build] fix warnings emitted on Clang Format code base

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Is this relevant anymore or should it be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19385/new/ https://reviews.llvm.org/D19385 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/4] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for inline asm (PR #67018)

2023-09-21 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD updated https://github.com/llvm/llvm-project/pull/67018 >From a26eb9fe0c09fc0fd504d261874630d8b5edae26 Mon Sep 17 00:00:00 2001 From: eopXD Date: Thu, 21 Sep 2023 06:34:57 -0700 Subject: [PATCH] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for inline

[PATCH] D25171: clang-format: Add two new formatting options

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Is this still relevant or should this be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D25171/new/ https://reviews.llvm.org/D25171 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D22334: Fix for Bug 28172 : clang crashes on invalid code (with too few arguments to __builtin_signbit) without any proper diagnostics.

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. It looks like the examples no longer crash: https://godbolt.org/z/Yn8qK3fnT So likely we should just close this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22334/new/ https://reviews.llvm.org/D22334 __

[PATCH] D28144: clang support for Mageia 6 distro

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. @bkramer is this still relevant or should it be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28144/new/ https://reviews.llvm.org/D28144 __

[PATCH] D18478: python bindings: expose the clang version string

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: arphaman. Herald added a project: All. @compnerd is this still relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18478/new/ https://reviews.llvm.org/D18478 ___ cfe-commits mailing list

[PATCH] D22189: llvm.noalias - Clang CodeGen - check restrict variable map only for restrict-qualified lvalues

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added subscribers: mattd, gchakrabarti, asavonic, jeroen.dobbelaere, bollu. Herald added a project: All. @rjmccall is this still relevant or can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22189/new/ https://reviews.llvm.org/D22189 ___

<    1   2   3   4   5   >