[clang] [RISCV] Update Zicntr and Zihpm to version 2p0 (PR #66323)

2023-09-14 Thread Yueh-Ting Chen via cfe-commits
@@ -629,7 +629,7 @@ TEST(getTargetFeatureForExtension, RetrieveTargetFeatureFromOneExt) { TEST(RiscvExtensionsHelp, CheckExtensions) { std::string ExpectedOutput = -R"(All available -march extensions for RISC-V + R"(All available -march extensions for RISC-V --

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

2023-09-14 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG293ae0b4b45f: [clang][Interp] Actually consider ConstantExpr result (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158169: [X86] Fix i128 argument passing under SysV ABI

2023-09-14 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. In D158169#4645012 , @RalfJung wrote: >> I think the CCIfSplit means it was larger than i64 to start. > > What about the case where `R9` would take the *second* half of a split i128 > (i.e., the value gets split across `R8` and `R9

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: It looks like we need to touch the section `Returned-Continuation Lowering` too https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Chuanqi Xu via cfe-commits
@@ -3046,7 +3046,8 @@ void coro::buildCoroutineFrame( // Collect the spills for arguments and other not-materializable values. for (Argument &A : F.args()) for (User *U : A.users()) - if (Checker.isDefinitionAcrossSuspend(A, U)) + if (Checker.isDefinitionAcros

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-14 Thread Nikita Popov via cfe-commits
https://github.com/nikic review_request_removed https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-14 Thread Nikita Popov via cfe-commits
https://github.com/nikic review_request_removed https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-14 Thread Nikita Popov via cfe-commits
https://github.com/nikic review_request_removed https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-14 Thread Nikita Popov via cfe-commits
https://github.com/nikic review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

2023-09-14 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon commented: Perhaps it needs a release note? https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

2023-09-14 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon review_requested https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

2023-09-14 Thread Yueh-Ting Chen via cfe-commits
eopXD wrote: > > Maybe test coverage with `-I %resource_dir`? > > Which file should I place the test? `clang/test/Headers/` https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-14 Thread via cfe-commits
mikaelholmen wrote: I see compilation problems with this patch. By mistake I originally posted about the problems in https://github.com/llvm/llvm-project/issues/66268#issuecomment-1718791073 So the problem: On a RHEL7 server we see stuff like: ` In file included from /repo/uabelho/dev-main/comp

[clang] 84216d1 - [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_instantiation members during explicit instantiation (#65961)

2023-09-14 Thread via cfe-commits
Author: Hans Date: 2023-09-14T10:20:01+02:00 New Revision: 84216d17359fcf6c314726d9f8d0416f8118d968 URL: https://github.com/llvm/llvm-project/commit/84216d17359fcf6c314726d9f8d0416f8118d968 DIFF: https://github.com/llvm/llvm-project/commit/84216d17359fcf6c314726d9f8d0416f8118d968.diff LOG: [cl

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-14 Thread via cfe-commits
https://github.com/zmodem closed https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/66339: Minimize the headers included in header files to reduce the number of files that need recompiled after a change. >From fafc158270aa454253d885111c297ab0aaaca7dc Mon Sep 17 00:00:00 2001 From: Bill Wendling Da

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling review_requested https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling review_requested https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-14 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-14 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-14 Thread Phoebe Wang via cfe-commits
@@ -645,7 +645,7 @@ static __inline__ __m128i __DEFAULT_FN_ATTRS _mm_mul_epi32(__m128i __V1, /// \returns A 128-bit integer vector containing the data stored at the ///specified memory location. static __inline__ __m128i __DEFAULT_FN_ATTRS -_mm_stream_load_si128(__m128i co

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-14 Thread Phoebe Wang via cfe-commits
@@ -2979,7 +2979,7 @@ _mm256_xor_si256(__m256i __a, __m256i __b) ///A pointer to the 32-byte aligned memory containing the vector to load. /// \returns A 256-bit integer vector loaded from memory. static __inline__ __m256i __DEFAULT_FN_ATTRS256 -_mm256_stream_load_si256(__m

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-14 Thread Phoebe Wang via cfe-commits
@@ -358,6 +358,12 @@ __m128i test_mm_stream_load_si128(__m128i const *a) { return _mm_stream_load_si128(a); } +__m128i test_mm_stream_load_si128_void(void const *a) { phoebewang wrote: `const void`? https://github.com/llvm/llvm-project/pull/66310 _

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Minimize the headers included in header files to reduce the number of files that need recompiled after a change. -- Full diff: https://github.com/llvm/llvm-project/pull/66339.diff 6 Files Affected: - (modified) clang/include/cl

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-09-14 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 556749. void added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h c

[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

2023-09-14 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158414: [LexerTest] Use LexAll() in StringifyArgs

2023-09-14 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-14 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-14 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. @Hahnfeld, let's move forward and rely on a post-commit review here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commi

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

2023-09-14 Thread via cfe-commits
alexfh wrote: > Here is the new fix. #66321 Thanks! I think, I found another pattern where string literal breaking is not allowed - in parameters of `goog.module.get()` (https://google.github.io/closure-library/api/goog.module.html). I'm not completely sure, which tool produces the error I'm

[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

2023-09-14 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:998 +std::vector Preprocessor::LexAll() { + std::vector toks; Shouldn't we take the results as a `LexAll(std::vector &result)`? Perhaps we should rename this interface to `LexToken

[clang] [clang-format] More on unbreakable strings in TypeScript (PR #66321)

2023-09-14 Thread via cfe-commits
alexfh wrote: LGTM https://github.com/llvm/llvm-project/pull/66321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-14 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. This revision cannot land without https://reviews.llvm.org/D158413 and for that one I really want to have feedback from somebody working in that area... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://re

[clang] [clang-format] More on unbreakable strings in TypeScript (PR #66321)

2023-09-14 Thread via cfe-commits
https://github.com/alexfh review_requested https://github.com/llvm/llvm-project/pull/66321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] More on unbreakable strings in TypeScript (PR #66321)

2023-09-14 Thread via cfe-commits
https://github.com/alexfh approved this pull request. https://github.com/llvm/llvm-project/pull/66321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: > One of the main user of these kind of coroutines is swift. There yield-once > (retcon.once) coroutines are used to temporary "expose" pointers to internal > fields of various objects creating borrow scopes. > > However, in some cases it might be useful

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Chuanqi Xu via cfe-commits
@@ -3046,7 +3046,8 @@ void coro::buildCoroutineFrame( // Collect the spills for arguments and other not-materializable values. for (Argument &A : F.args()) for (User *U : A.users()) - if (Checker.isDefinitionAcrossSuspend(A, U)) + if (Checker.isDefinitionAcros

[clang] [AArch64][Clang] Implement ACLE rintn intrinsics (PR #66112)

2023-09-14 Thread David Green via cfe-commits
https://github.com/davemgreen approved this pull request. Thanks. LGTM https://github.com/llvm/llvm-project/pull/66112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-14 Thread Shengchen Kan via cfe-commits
@@ -1223,6 +1223,12 @@ __m256i test_mm256_stream_load_si256(__m256i const *a) { return _mm256_stream_load_si256(a); } +__m256i test_mm256_stream_load_si256_const(void const *a) { KanRobert wrote: +1 https://github.com/llvm/llvm-project/pull/66310 _

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Anders Waldenborg via cfe-commits
https://github.com/wanders approved this pull request. LGTM. Assuming that clang/examples/Attribute/ still compiles fine (it should be part of clang/test/Frontend/ tests) https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list c

[clang] [clang] Allow MCTargetOptions to be parseable by -mllvm. (PR #66347)

2023-09-14 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli created https://github.com/llvm/llvm-project/pull/66347: The cl::opt used by MCTargetOptions are not created until RegisterMCTargetOptionsFlags is instantiated. Due to this deferral the compiler driver -mllvm path is unable to parse flags such as --no-deprecated-

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

2023-09-14 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. Herald added a subscriber: sunshaoce. I am afraid there is also error at clang/test/Driver/as-options.s when default triple is 'riscv32-unknown-elf' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://revi

[clang] [clang] Allow MCTargetOptions to be parseable by -mllvm. (PR #66347)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow MCTargetOptions to be parseable by -mllvm. (PR #66347)

2023-09-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The cl::opt used by MCTargetOptions are not created until RegisterMCTargetOptionsFlags is instantiated. Due to this deferral the compiler driver -mllvm path is unable to parse flags such as --no-deprecated-warn which work prope

[clang] [clang][bpf] Fix invalid RUN lines in stack protector warning test (PR #65251)

2023-09-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: I'm going to assume this is fine given that the test passes. We can always revert it if that is not the case. https://github.com/llvm/llvm-project/pull/65251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] 7e6a5fe - [clang][bpf] Fix invalid RUN lines in stack protector warning test (#65251)

2023-09-14 Thread via cfe-commits
Author: David Spickett Date: 2023-09-14T10:24:26+01:00 New Revision: 7e6a5fe1603f3f768e299de0bea2cde8bc3c31db URL: https://github.com/llvm/llvm-project/commit/7e6a5fe1603f3f768e299de0bea2cde8bc3c31db DIFF: https://github.com/llvm/llvm-project/commit/7e6a5fe1603f3f768e299de0bea2cde8bc3c31db.diff

[clang] [clang][bpf] Fix invalid RUN lines in stack protector warning test (PR #65251)

2023-09-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow MCTargetOptions to be parseable by -mllvm. (PR #66347)

2023-09-14 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli review_requested https://github.com/llvm/llvm-project/pull/66347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow MCTargetOptions to be parseable by -mllvm. (PR #66347)

2023-09-14 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli review_requested https://github.com/llvm/llvm-project/pull/66347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0009032 - [NFC] Minimize header includes (#66339)

2023-09-14 Thread via cfe-commits
Author: Bill Wendling Date: 2023-09-14T02:29:11-07:00 New Revision: 0009032a27f7c8461b7c107cb05b1eac61be7197 URL: https://github.com/llvm/llvm-project/commit/0009032a27f7c8461b7c107cb05b1eac61be7197 DIFF: https://github.com/llvm/llvm-project/commit/0009032a27f7c8461b7c107cb05b1eac61be7197.diff

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 967604a - [clang][dataflow] In tests, error out if we didn't find any matching target functions. (#66197)

2023-09-14 Thread via cfe-commits
Author: martinboehme Date: 2023-09-14T11:32:17+02:00 New Revision: 967604a07b1d5da15fb561d4ceae04cbaef02df7 URL: https://github.com/llvm/llvm-project/commit/967604a07b1d5da15fb561d4ceae04cbaef02df7 DIFF: https://github.com/llvm/llvm-project/commit/967604a07b1d5da15fb561d4ceae04cbaef02df7.diff

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

2023-09-14 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/66197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

2023-09-14 Thread Balazs Benics via cfe-commits
steakhal wrote: I finished the review of this PR. By looking at the disappeared reports you attached, I'm convinced that the `MsgTaintedBufferSize` diagnostics give little to no benefit in general. On the other side, I've seen good hits for OOBV2 in the presence of taint - even if that's rare

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

2023-09-14 Thread Balazs Benics via cfe-commits
https://github.com/steakhal requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

2023-09-14 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/66086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

2023-09-14 Thread Balazs Benics via cfe-commits
@@ -915,24 +915,6 @@ void testStrndupa(size_t n) { clang_analyzer_isTainted_charp(result); // expected-warning {{YES}} } -size_t strlen(const char *s); -void testStrlen() { - char s[10]; - scanf("%9s", s); - - size_t result = strlen(s); - clang_analyzer_isTainted_int(res

[clang] 094a63a - [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

2023-09-14 Thread Sergio Afonso via cfe-commits
Author: Sergio Afonso Date: 2023-09-14T10:33:54+01:00 New Revision: 094a63a20bf54f18efafbb6a727466da0f22a245 URL: https://github.com/llvm/llvm-project/commit/094a63a20bf54f18efafbb6a727466da0f22a245 DIFF: https://github.com/llvm/llvm-project/commit/094a63a20bf54f18efafbb6a727466da0f22a245.diff

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

2023-09-14 Thread Sergio Afonso via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG094a63a20bf5: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1472

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

2023-09-14 Thread Sergio Afonso via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG29aa749087be: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to… (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] [analyzer] First batch of patches for the Juliet benchmark for taint improvements (PR #66074)

2023-09-14 Thread via cfe-commits
https://github.com/DonatNagyE approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/66074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9058762 - [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

2023-09-14 Thread Sergio Afonso via cfe-commits
Author: Sergio Afonso Date: 2023-09-14T10:35:44+01:00 New Revision: 9058762789c0a83560c2b567a347b993e70b05ae URL: https://github.com/llvm/llvm-project/commit/9058762789c0a83560c2b567a347b993e70b05ae DIFF: https://github.com/llvm/llvm-project/commit/9058762789c0a83560c2b567a347b993e70b05ae.diff

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

2023-09-14 Thread Sergio Afonso via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9058762789c0: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] [AArch64] Remove copy instruction between uaddlv with v8i16 and dup (PR #66068)

2023-09-14 Thread David Green via cfe-commits
@@ -194,8 +194,23 @@ entry: ret <8 x i8> %vrshrn_n2 } -declare <8 x i8> @llvm.aarch64.neon.rshrn.v8i8(<8 x i16>, i32) +define dso_local <8 x i16> @uaddlv_dup_v8i16(<8 x i16> %a) { +; CHECK-LABEL: uaddlv_dup_v8i16: +; CHECK: // %bb.0: // %entry +; CHECK-NEXT:uaddlv

[clang-tools-extra] [AArch64] Remove copy instruction between uaddlv with v8i16 and dup (PR #66068)

2023-09-14 Thread David Green via cfe-commits
@@ -194,8 +194,23 @@ entry: ret <8 x i8> %vrshrn_n2 } -declare <8 x i8> @llvm.aarch64.neon.rshrn.v8i8(<8 x i16>, i32) +define dso_local <8 x i16> @uaddlv_dup_v8i16(<8 x i16> %a) { +; CHECK-LABEL: uaddlv_dup_v8i16: +; CHECK: // %bb.0: // %entry +; CHECK-NEXT:uaddlv

[clang] [AArch64] Remove copy instruction between uaddlv with v8i16 and dup (PR #66068)

2023-09-14 Thread David Green via cfe-commits
@@ -6077,6 +6077,8 @@ defm : DUPWithTruncPats; defm : DUPWithTruncPats; defm : DUPWithTruncPats; +defm : DUPWithTruncPats; davemgreen wrote: There isn't really an trunc going on here, If I'm understanding what is going on. Can we add a DAG combine for ```

[clang-tools-extra] [AArch64] Remove copy instruction between uaddlv with v8i16 and dup (PR #66068)

2023-09-14 Thread David Green via cfe-commits
@@ -194,8 +194,23 @@ entry: ret <8 x i8> %vrshrn_n2 } -declare <8 x i8> @llvm.aarch64.neon.rshrn.v8i8(<8 x i16>, i32) +define dso_local <8 x i16> @uaddlv_dup_v8i16(<8 x i16> %a) { +; CHECK-LABEL: uaddlv_dup_v8i16: +; CHECK: // %bb.0: // %entry +; CHECK-NEXT:uaddlv

[clang-tools-extra] [AArch64] Remove copy instruction between uaddlv with v8i16 and dup (PR #66068)

2023-09-14 Thread David Green via cfe-commits
@@ -5329,7 +5329,8 @@ SDValue AArch64TargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op, case Intrinsic::aarch64_neon_uaddlv: { EVT OpVT = Op.getOperand(1).getValueType(); EVT ResVT = Op.getValueType(); -if (ResVT == MVT::i32 && (OpVT == MVT::v8i8 || OpVT == MVT:

[clang] [AArch64] Remove copy instruction between uaddlv with v8i16 and dup (PR #66068)

2023-09-14 Thread David Green via cfe-commits
@@ -194,8 +194,23 @@ entry: ret <8 x i8> %vrshrn_n2 } -declare <8 x i8> @llvm.aarch64.neon.rshrn.v8i8(<8 x i16>, i32) +define dso_local <8 x i16> @uaddlv_dup_v8i16(<8 x i16> %a) { +; CHECK-LABEL: uaddlv_dup_v8i16: +; CHECK: // %bb.0: // %entry +; CHECK-NEXT:uaddlv

[clang] 0b2778d - [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (#66109)

2023-09-14 Thread via cfe-commits
Author: DonatNagyE Date: 2023-09-14T11:51:46+02:00 New Revision: 0b2778d5e59192331351e082a354843b0e9c1235 URL: https://github.com/llvm/llvm-project/commit/0b2778d5e59192331351e082a354843b0e9c1235 DIFF: https://github.com/llvm/llvm-project/commit/0b2778d5e59192331351e082a354843b0e9c1235.diff LO

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

2023-09-14 Thread via cfe-commits
https://github.com/DonatNagyE closed https://github.com/llvm/llvm-project/pull/66109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 909c963 - [analyzer] Fix stdin declaration in C++ tests (#66074)

2023-09-14 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-14T11:55:10+02:00 New Revision: 909c9639994b5467e8c8424580063e29139d1def URL: https://github.com/llvm/llvm-project/commit/909c9639994b5467e8c8424580063e29139d1def DIFF: https://github.com/llvm/llvm-project/commit/909c9639994b5467e8c8424580063e29139d1def.diff

[clang] 8243bc4 - [analyzer] Make socket `accept()` propagate taint (#66074)

2023-09-14 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-14T11:55:10+02:00 New Revision: 8243bc40452bc90fa4f66a374d088907c1fe38cb URL: https://github.com/llvm/llvm-project/commit/8243bc40452bc90fa4f66a374d088907c1fe38cb DIFF: https://github.com/llvm/llvm-project/commit/8243bc40452bc90fa4f66a374d088907c1fe38cb.diff

[clang] 61924da - [analyzer] Propagate taint for wchar variants of some APIs (#66074)

2023-09-14 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-14T11:55:10+02:00 New Revision: 61924da630532c91f00351b7e84548eb42e2e1e0 URL: https://github.com/llvm/llvm-project/commit/61924da630532c91f00351b7e84548eb42e2e1e0 DIFF: https://github.com/llvm/llvm-project/commit/61924da630532c91f00351b7e84548eb42e2e1e0.diff

[clang] [analyzer] First batch of patches for the Juliet benchmark for taint improvements (PR #66074)

2023-09-14 Thread Balazs Benics via cfe-commits
steakhal wrote: Merged manually, to allow landing these commits separately. https://github.com/llvm/llvm-project/pull/66074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] First batch of patches for the Juliet benchmark for taint improvements (PR #66074)

2023-09-14 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/66074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 09ffb9e - [AArch64][Clang] Implement ACLE rintn intrinsics (#66112)

2023-09-14 Thread via cfe-commits
Author: M Iyengar Date: 2023-09-14T11:00:49+01:00 New Revision: 09ffb9ee19a73d8369ce11502e991c190fdafe5c URL: https://github.com/llvm/llvm-project/commit/09ffb9ee19a73d8369ce11502e991c190fdafe5c DIFF: https://github.com/llvm/llvm-project/commit/09ffb9ee19a73d8369ce11502e991c190fdafe5c.diff LOG

[clang] [AArch64][Clang] Implement ACLE rintn intrinsics (PR #66112)

2023-09-14 Thread Victor Campos via cfe-commits
https://github.com/vhscampos closed https://github.com/llvm/llvm-project/pull/66112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66354: See https://reviews.llvm.org/D136154#3890747 for context. Fixes part of #58592. >From 9a15ec3256e2d380d5eb70f0751ea1bb457895dd Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700 Subje

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes See https://reviews.llvm.org/D136154#3890747 for context. Fixes part of #58592. -- Full diff: https://github.com/llvm/llvm-project/pull/66354.diff 2 Files Affected: - (modified) clang/lib/Format/ContinuationIndenter.cpp (+3-2)

[clang] 2dee316 - Fixup "[analyzer] Propagate taint for wchar variants of some APIs"

2023-09-14 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-14T12:22:11+02:00 New Revision: 2dee316a04be3fa466944542ee05926f28aa9ce4 URL: https://github.com/llvm/llvm-project/commit/2dee316a04be3fa466944542ee05926f28aa9ce4 DIFF: https://github.com/llvm/llvm-project/commit/2dee316a04be3fa466944542ee05926f28aa9ce4.diff

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-14 Thread Balazs Benics via cfe-commits
https://github.com/steakhal labeled https://github.com/llvm/llvm-project/pull/66358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-14 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/66358: Variadic arguments were not considered as taint sink arguments. I also decided to extend the list of exec-like functions. (Juliet CWE78_OS_Command_Injection__char_connect_socket_execl) --- This commit was sp

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-14 Thread Balazs Benics via cfe-commits
https://github.com/steakhal review_requested https://github.com/llvm/llvm-project/pull/66358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix taint sink rules for exec-like functions (PR #66358)

2023-09-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Changes Variadic arguments were not considered as taint sink arguments. I also decided to extend the list of exec-like functions. (Juliet CWE78_OS_Command_Injection__char_connect_socket_execl) --- This commit was spl

[PATCH] D151834: Include math-errno with fast-math

2023-09-14 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. What's the way forward here? Revert if it's unclear what to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 ___ cfe-commits mailing

[clang] [clang][dataflow] Add a test for context-sensitive analysis on a self-referential class. (PR #66359)

2023-09-14 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/66359: The test demonstrates that the `this` pointer seen in the constructor has the same value as the address of the variable the object is constructed into. >From c2219d46c4cdb5e82bf98d0249412c95c0781c97 Mon Se

[clang] [clang][dataflow] Add a test for context-sensitive analysis on a self-referential class. (PR #66359)

2023-09-14 Thread via cfe-commits
https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/66359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add a test for context-sensitive analysis on a self-referential class. (PR #66359)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add a test for context-sensitive analysis on a self-referential class. (PR #66359)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add a test for context-sensitive analysis on a self-referential class. (PR #66359)

2023-09-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The test demonstrates that the `this` pointer seen in the constructor has the same value as the address of the variable the object is constructed into. -- Full diff: https://github.com/llvm/llvm-project/pull/66359.diff 1 Files A

[clang] 263fc4c - Turn off memory leaks in unit test

2023-09-14 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2023-09-14T13:16:22+02:00 New Revision: 263fc4c79a2b41a57dd1bf3a17873002c5d69265 URL: https://github.com/llvm/llvm-project/commit/263fc4c79a2b41a57dd1bf3a17873002c5d69265 DIFF: https://github.com/llvm/llvm-project/commit/263fc4c79a2b41a57dd1bf3a17873002c5d69265.dif

  1   2   3   4   >